July 2004 - Wine-Devel - list.winehq.org

Re: [Wine]Help the wine project
by Joshua Crawford July 31, 2004

July 31, 2004

* Michael Chang <michael(a)cherryblossom.homelinux.com> [2004-07-30 13:12 -0400]: > On Fri, 30 Jul 2004 14:12:50 +1000, Joshua Crawford > <mortarn_lists(a)yahoo.com.au> wrote: > >* Ivan Leo Puoti <puoti(a)inwind.it> [2004-07-28 19:14 +0200]: > >>The wine developers have created a test sistem to check if wine works > >>like microsoft windows, but more users are needed to run the tests. > [snip] > >I installed this on a windows 98se box. I can't say I like having the DOS > >window open all the time (it's ugly). Can this not be written as a > >windows programme, and sit in the system tray? > Yes. I don't know how, but I know it's possible. You'd have to probably > find example code that allows this -- writing that kind of thing requires > knowledge of the Windows API for the systray. I think. Maybe send this > request to wine-devel? I don't know (how). One thing to point out though > - > if it ran in the system tray, then you wouldn't be able to run it within > wine. (Yes, I know that sounds stupid...) Cc: to wine-devel added. <snip console app vs. gui, and resizing window> > >Also, during the installation process, after I entered my email address, > >the installer removed what it called 'invalid characters' - i.e., > >underscores. > >All my main email addresses contain underscores, so I was forced to > >enter an old one that is not very reliable. > > How'd this happen? Underscores are very much valid characters in e-mails. > Was the installation check only accepting alpha-numeric characters as > the user part of the e-mail? Dashes should also be acceptable, in both > the username and the domain name. (Otherwise, how could we send e-mail > to the "wine-users" account of the mail server so the mailman service > could get to them?) It boggles me too. Something new: I just booted up that system for the first time since installing winrash (it's not used often), and Windows complained about it performing an illegal operation. Naturally, I tried repeating that by rebooting, and it didn't do it again. -- Joshua 'bruce' Crawford ... http://www.geocities.com/mortarn "Always be sincere, even when you don't mean it." -Irene Peter

2 1

Re: Wine isn't GUI user friendly
by Mike Hearn July 31, 2004

July 31, 2004

Christian Neumair <chris(a)gnome-de.org> writes: > That reminds me of asking for nicer, GUI-driven error handling: > touch mustardandwiener.exe && > wine mustardandwiener.exe > returns > wine: cannot determine executable type for L"H:\\Desktop\\test.exe" > which is neither verbose enough nor user friendly, because it is simply > printed at a terminal. Modern desktop environments usually launch wine > from their file manager, i.e. without terminals. Well, as to the contents of the message itself, I don't know how it could be improved. You asked Wine to run an empty file and it said it can't figure out what kind of executable it is: why is this a problem? As to using message boxes for errors, well I have submitted patches to do this before and some were accepted, and some were not. The reasoning was that having all errors appear in message boxes would be annoying. Perhaps if there was a generic mechanism such that when a terminal was available the message was printed, and when it was not (like in a GUI) a message box was used, that would be more acceptable. I don't know how to tell if a console is available or not though. Plus to be convenient it'd need to be a new Wine API and we're trying to remove them rather than add to them :) > Can't we have popup dialogs for that kind of errors? As far as I know, > debian guys have build a shell/wrapper around wine that pops up if weird > things like these occur. Can't we have such a wrapper in stock wine? For > now, it would be enough to just catch the most common problems (binary > not found, binary can't be loaded, etc.). To be frank I still think displaying the output of stderr when a program launched from the GUI fails is the desktops job. All kinds of messages can be printed by Wine before we even have a chance to initialize the GUI subsystem - in fact the "cannot run exe" message may well be an example of that. Writing a patch to Gnome to make it do that wouldn't be hard and would solve a broad class of problems. thanks -mike

6 10

Re: No go here (Re: [D3D] Added native and emulated S3TC support (take 2))
by Andreas Mohr July 31, 2004

July 31, 2004

Hi, On Sat, Jul 31, 2004 at 01:16:45PM +0200, Lionel Ulmer wrote: > Fixed in the attached patch... At least we know now that Alexandre finally > installed some OpenGL stuff on his development box :-) Works. :) Oh, wait... just when I *wanted* to say it works, I switched back to the console compiling Wine, and: make[2]: Entering directory `/usr/src/apps/CVS/wine/dlls/ddraw' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o main.o main.c main.c:123: error: parse error before "fetch_2d_texel_rgba_dxt1" main.c:123: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt1' main.c:123: warning: data definition has no type or storage class main.c:124: error: parse error before "fetch_2d_texel_rgba_dxt3" main.c:124: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt3' main.c:124: warning: data definition has no type or storage class main.c:123: error: parse error before "fetch_2d_texel_rgba_dxt1" main.c:123: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt1' main.c:123: warning: data definition has no type or storage class main.c:124: error: parse error before "fetch_2d_texel_rgba_dxt3" main.c:124: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt3' main.c:124: warning: data definition has no type or storage class main.c:125: error: parse error before "fetch_2d_texel_rgba_dxt5" main.c:125: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt5' main.c:125: warning: data definition has no type or storage class main.c: In function `DDRAW_bind_to_s3tc': main.c:148: warning: assignment makes integer from pointer without a cast main.c:148: warning: comparison between pointer and integer main.c:149: warning: assignment makes integer from pointer without a cast main.c:149: warning: comparison between pointer and integer main.c:150: warning: assignment makes integer from pointer without a cast main.c:150: warning: comparison between pointer and integer make[2]: *** [main.o] Error 1 make[2]: Leaving directory `/usr/src/apps/CVS/wine/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/usr/src/apps/CVS/wine/dlls' make: *** [dlls] Error 2 Take (more ;) care, Andreas

1 0

No go here (Re: [D3D] Added native and emulated S3TC support (take 2))
by Andreas Mohr July 31, 2004

July 31, 2004

Hi, On Thu, Jul 29, 2004 at 11:49:33PM +0100, Christian Costa wrote: > Hi, > > This is the second version of my patch which take into account Lionel's > comments plus another fix. > > I've only mentionned the libtxc_dxtn.so library for software > decompression when the video card does not support S3TC. > Maybe Lionel can say if we can add more precise information i.e > reference to the DRI project. CVS compile bombs for me with: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw/hal.o ddraw/hal.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw/main.o ddraw/main.c ddraw/main.c: In function `create_texture': ddraw/main.c:394: error: `GL_extensions' undeclared (first use in this function)ddraw/main.c:394: error: (Each undeclared identifier is reported only once ddraw/main.c:394: error: for each function it appears in.) make[2]: *** [ddraw/main.o] Error 1 make[2]: Leaving directory `/usr/src/apps/CVS/wine/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/usr/src/apps/CVS/wine/dlls' make: *** [dlls] Error 2 Command exited with non-zero status 2 /* Check if we can really support DXT1, DXT3 & DXT5 */ if ((ddsd.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) && !GL_extensions.s3tc_compressed_texture && !s3tc_initialized) { ERR("Trying to create DXT1, DXT3 or DXT5 texture which is not supported by the video card!!!\n"); ERR("However there is a library libtxc_dxtn.so that can be used to do the software decompression...\n"); return DDERR_INVALIDPIXELFORMAT; } ii xlibmesa-gl 4.3.0.dfsg.1-1 Mesa 3D graphics library [XFree86] ii xlibmesa-glu 4.3.0.dfsg.1-1 Mesa OpenGL utility library [XFree86] 01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400 AGP (rev 03) (shouldn't matter anyway) /* Define if the OpenGL headers define extension typedefs */ /* #undef HAVE_GLEXT_PROTOTYPES */ /* Define if the OpenGL library supports the glXGetProcAddressARB call */ /* #undef HAVE_GLX_GETPROCADDRESS */ /* Define to 1 if you have the <GL/glext.h> header file. */ /* #undef HAVE_GL_GLEXT_H */ /* Define to 1 if you have the <GL/glx.h> header file. */ /* #undef HAVE_GL_GLX_H */ /* Define to 1 if you have the <GL/gl.h> header file. */ /* #undef HAVE_GL_GL_H */ /* Define if OpenGL is present on the system */ /* #undef HAVE_OPENGL */ /* Define to the soname of the libGL library. */ #define SONAME_LIBGL "libGL.so" Good luck, Andreas Mohr

1 0

shell32 patch
by Jens Collin July 31, 2004

July 31, 2004

Hi, I've made a small change in shell32.dll to enable one to type a myfile.txt from Start->Run dialog (for example). I've simply replaced the call to CreateProcess with ShellExecute. I've tested this change in reactos and it works nicely. It won't really work since there is something wrong with ShellExecute itself (or rather FindExecutable) but I've contacted Francois (fgouget(a)free.fr) to get some help on this. Anyway, it partially adds a tiny function and it doesn't break anything. Can someone commit this small patch for me please? Thanks in advance, Jens Collin

1 0

Re: USB?
by Ivan Leo Puoti July 31, 2004

July 31, 2004

I don't think drivers are an issue, what we wants to do is use an app that uses the usb ports, and he wants to use this app from wine. So he wants to write an interface for wine, that would take driver calls from the program and forward them to ioctl(whatever) so the app will work with the usb ports, or at least thats how I think it may work. I don't think it's easy to find USB ports not supported by linux now days, but wine isn't usb-aware. Ivan.

1 0

Re: Question about mmap issues on FreeBSD/NetBSD
by Yorick Hardy July 31, 2004

July 31, 2004

Thanks for the response. I must be doing something wrong, since wine-kthread gave the same error. Anything I may have missed? I copied wine-kthread from loader/wine-kthread. It does not appear to be correct, but is there any chance madvise(..., MADV_DONTNEED) could help? Also in libs/wine/mmap.c line 119 the result of mincore is never tested, should it not be if ( (mincore( (caddr_t)addr + i, pagesize, &vec ) != -1) && (vec&1) ) (with a slight variation for FreeBSD), although I think this will not resolve the current problem. >You need MAP_NORESERVE support otherwise we can't control the address >space correctly (unless you have a ton of virtual memory): if you run >wine-kthread directly it should still work though unless you have >execshield type address space randomisation active. > >On Thu, 29 Jul 2004 09:13:25 +0200, Yorick Hardy wrote: >> Just a question about the mmap issues experienced on FreeBSD, i.e. >> http://www.winehq.org/?issue=230#Wine%20on%20FreeBSD >> >> I encountered the same on NetBSD. It seems the error message is set from >> ld.elf_so in NetBSD and ld-elf.so.1 in FreeBSD, when the address space >> is mapped for the run time linking? Since MAP_NORESERVE is not documented >> (and not supported?) for mmap on FreeBSD and NetBSD, it would appear >> that wine and the ld.elf_so together require too much memory for all the mmap >> calls. Kind regards, -- Yorick Hardy

5 5

ms devel tools
by Ivan Leo Puoti July 31, 2004

July 31, 2004

If anyone needs to test something out with m$ development tools for whatever reason, they are giving away free betas (It doesn't matter, all m$ software is alpha/beta) of the express development tools, so if you need one get it until you can. http://lab.msdn.microsoft.com/express/ I'm going to try and see how much of wine will build with visualc++. Ivan.

1 0

Re: [D3D] Added native and emulated S3TC support (take 2)
by Lionel Ulmer July 30, 2004

July 30, 2004

> I've only mentionned the libtxc_dxtn.so library for software > decompression when the video card does not support S3TC. > Maybe Lionel can say if we can add more precise information i.e > reference to the DRI project. Well, the page where you can download it is the third Google link when searching for 'libtxc_dxtn'. So I think the information there is enough :-) Lionel PS: thanks for the edits, will be able to test the final version now that it's commited :-) -- Lionel Ulmer - http://www.bbrox.org/

1 0

regression
by Ivan Leo Puoti July 30, 2004

July 30, 2004

The following patch http://www.winehq.com/hypermail/wine-cvs/2004/03/0434.html causes an infinite loop when installing the word97/2k viewer. A relay log from the loop is attached. Can someone please fix this? Ivan.

1 0

RPCRT4_NdrClientCall2 stub (fixme)?
by Jeroen Janssen July 30, 2004

July 30, 2004

Hello, I have 'hit' upon a RPCRT4_NdrClientCall2 stub/fixme call. It seems some discussion on this has been happening in a the past few months? Can someone maybe explain the current status on this? (probably Rob or Mike, since they seem to be the Wine COM "gurus"?) Below is is a short snip of trace logging I get: trace:ole:COMPOBJ_DLLList_Add trace:ole:CStdPSFactory_QueryInterface (0x660cea80)->QueryInterface({d5f569d0-593b-101a-b569-08002b2dbf7a},0x4067faa4) trace:ole:CStdPSFactory_CreateProxy (0x660cea80)->CreateProxy((nil),{11ef83d1-553a-11d3-bb12-0004ac9658d6},0x4067faa0,0x4067fbfc) trace:ole:FindProxyInfo found: ProxyInfo 0x660cbc48 Index 65 trace:ole:StdProxy_Construct ((nil),0x660cd048,0x660cea80,0x4067faa0,0x4067fbfc) ICoKMFactoryManager trace:ole:StdProxy_Construct stubless=0x660c5230 trace:ole:StdProxy_Construct iid={11ef83d1-553a-11d3-bb12-0004ac9658d6} trace:ole:StdProxy_Construct vtbl=0x660cd050 trace:ole:StdProxy_Construct stubless thunks: count=6 trace:ole:StdProxy_Construct method 3: stacksize=12 trace:ole:StdProxy_Construct method 4: stacksize=16 trace:ole:StdProxy_Construct method 5: stacksize=4 trace:ole:CStdPSFactory_AddRef (0x660cea80)->AddRef() trace:ole:CStdPSFactory_Release (0x660cea80)->Release() trace:ole:StdProxy_Connect (0x4034f1f0)->Connect(0x4034f288) trace:ole:StdProxy_Release (0x4034f1f0)->Release() trace:ole:ObjectStubless (0x4034f1f4)->(3)([12 bytes]) ret=4067fc94 fixme:ole:RPCRT4_NdrClientCall2 (pStubDec == ^0x660c7c08,pFormat = ^0x660c7d30,...): stub trace:ole:IUnknown_Release_Proxy (0x4034f1f0)->Release() ICoKMFactoryManager wine: Unhandled exception (thread 0014), starting debugger... Best regards, Jeroen Janssen

5 8

Re: possible bug in wcmd
by Ivan Leo Puoti July 30, 2004

July 30, 2004

It looks like a bug to me. [ivan(a)localhost wcmd]$ ./wcmd WCMD Version 0.17 Z:\home\ivan\Development\Wine\CVS\wine\wine\programs\wcmd>help for wine: Unhandled exception (thread 0009), starting debugger... fixme:console:SetConsoleCtrlHandler (0x405ec9e0,1) - no error checking or testing yet WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x20656854 in 32-bit code (0x400d2473). In 32 bit mode. 0x400d2473 strlen in libc.so.6: movl 0x0(%eax),%ecx Wine-dbg>bt Backtrace: =>1 0x400d2473 strlen+0x33 in libc.so.6 (0x406eed1c) 2 0x400ba8cb _IO_vsprintf+0x8b in libc.so.6 (0x406eede4) 3 0x405c9eeb WCMD_output+0x2b(format=0x406ef20c) [wcmdmain.c:741] in wcmd (0x406ef200) 4 0x405c7020 WCMD_give_help+0x80(command=0x4039b8a5) [builtins.c:352] in wcmd (0x406efa18) 5 0x405c9563 .L153+0x9 in wcmd (0x406efa58) 6 0x405c91d4 main+0x4f4(argc=0x1, argv=0xbffff49c) [wcmdmain.c:244] in wcmd (0x406efe9c) 7 0x405c6169 __wine_exe_main+0x169 in wcmd (0x406eff2c) 8 0x404e6a88 start_process+0xc8(arg=0x0) [process.c:995] in kernel32 (0x406efff4) 9 0x4001cd9d wine_switch_to_stack+0x11 in libwine.so.1 (0x00000000) Wine-dbg>quit WineDbg terminated on pid 0x8 [ivan(a)localhost wcmd]$

1 0

Re: RPCRT4_NdrClientCall2 stub (fixme)?
by Filip Navara July 30, 2004

July 30, 2004

Alexandre Julliard wrote: > Mike Hearn <mike(a)navi.cx> writes: > >>> Yes, I have an implementation of NdrClientCall2 in my local tree, but >>> I'm a bit busy with other COM things at the moment. I'll send an >>> updated >>> patch to the list either tonight or sometime over the weekend. >>> >> >> Alexandre, why was this not merged when it was originally sent? >> > > No idea, please resubmit. > IIRC Robert said that the patch isn't cleaned up yet and so it shouldn't be commited. He also said that he hasn't tested it much except for simple tests and the complex types weren't tested at all. - Filip

3 4

possible bug in wcmd
by Henning Gerhardt July 30, 2004

July 30, 2004

Hi, I discovered a possible bug in wcmd. If you run "help for" inside wcmd, wcmd crashed and the winedebugger is called. I used to confirm this bug on my machine the latest tarball and a CVS-snapshot from today. If anybody can confirm this bug I will be happy :) The following lines are only correct if this bug is true: The problem is that a single % letter inside the resource strings. Look for the for-help text in En.rc file and you find the sentence "The requirement to double the % sign when using FOR in a batch file does") get parsed and this single % caused the crash. I found the following solutions and I don't know what is the right solution: 1. replace the single % with a double %% in all resource files 2. replace in the function WCMD_give_help (builtins.c:330) WCMD_output with WCMD_output_asis (WCMD_output (wcmdmain.c:733) called WCMD_output_asis but make some stuff for possible dynamic parameters) 3. patch the function WCMD_output (wcmdmain.c:733) with the attached patch (Replace a single % with a double % and all later called system function are be happy) I prefer personal the second or third solution. Regards, Henning

1 0

Linking with dlls and Linux libs using winelib?
by James Supancic July 30, 2004

July 30, 2004

I need to compile a Windows application under Linux. I need to use dlls and Linux librarys. No matter what I try I can't get winegcc to include the Linux librarys in the linking stage. What must I do to get winegcc to link with both the dlls and Linux libs? Thank you for your time, James Steven Supancic III _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today - it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

2 1

Re: Re: WineHQ:service.cgi: fix winrash option
by chmorgan＠charter.net July 30, 2004

July 30, 2004

> <chmorgan(a)charter.net> writes: > > > Which errors are you referring to? The most frequent ones > > lately are the ones where the winetest package isn't > > available on the sourceforge osdn mirror. > > For example this: > > > Winrash version: winrash-0008-chris-msvc.exe > > [...] > > winetest = winetest-200407091000-kevin-mingw.zip > > winetest_history = > > Script: > > 8 total commands, current command is 6 > > 0: error_url http://test.winehq.org/error > > 1: error_sleep 3600 > > 2: download winetest-200407091000-kevin-mingw.zip http://osdn.dl.sourceforge.net/sourceforge/wine/winetest-200407091000-kevin… > > 3: cookie winetest winetest-200407091000-kevin-mingw.zip > > 4: cookie winetest_history > > 5: unzip winetest-200407091000-kevin-mingw.zip > > --> 6: run winetest-200407091000-kevin-mingw.exe -c -t Cogman -u http://osdn.dl.sourceforge.net/sourceforge/wine/winetest-200407091000-kevin… > > 7: sleep 300 > > Command in error: > > 6 > > Last error text: The system cannot find the file specified. > > Does the above mean that the download was unsuccessful? > Equally for "Last error text: %1 is not a valid Win32 > application."? Then we don't need these messages (which > could be improved at least). > Yep. I just tried that url and it worked. Many of the ones I've tried in the past haven't and the cause seems to be that the mirror chosen doesn't have the file. I'm not sure what a good solution is. Perhaps we should implement a way of providing a list of potential download sites for a file. I'm not sure how to detect that the download fails. Sourceforge provides a page that says that the file can't be found. This is what winrash probably downloaded in this case. Any ideas how to make the system more robust without making it much more complex? > Hmm, some still try to download winrash-0008 from the osdn > mirror, which has been obsoleted for a long time. Why? > I have no idea what the issue is here. The script should be telling the 0007 client to download 0009. I'm not sure if this is a bug or not. > And service.cgi shouldn't pass the -u option to winetest > anymore, I patched it out. At least I think so. > > > We are still asking people to download the tests from this > > location for particular test releases. I'd imagine the > > fix is simply to point the downloads at valid mirror for > > the file. > > By editing service.cgi's database? You could ask Jer, his > is very helpful if you can catch him on IRC. I wish there > was some logging feature in service.cgi... I'll go deeper > in a couple of days. > -- > Feri. Your help is much appreciated. This is a tricky issue it seems as SF isn't always reliable for downloads... Chris

7 9

formal standard for wine devel style
by James Hawkins July 30, 2004

July 30, 2004

Is there a written formal standard specifying the style in which wine code is written? I remember a message a while back about how a patch couldn't be committed because it didn't meet the standards of wine coding style and that someone who knew the style could fix it. -- James Hawkins

3 2

Re: DCOM: Disconnect Proxies at COM Shutdown
by Robert Shearman July 30, 2004

July 30, 2004

Robert Shearman wrote: > Changelog: > > Mike Hearn <mh(a)codeweavers.com> > Disconnect proxies at COM shutdown to release the corresponding stubs. Sorry, this one was an old patch. Rob

1 0

Bug in menu.c
by Dan Timis July 30, 2004

July 30, 2004

Hi, The MS documentation on the structure MENUITEMINFO says that the field fMask indicates what fields to retrieve or set. Here is what it says about the value MIIM_TYPE: > Retrieves or sets the fType and dwTypeData members. Windows 98/Me, > Windows 2000/XP: MIIM_TYPE is replaced by MIIM_BITMAP, MIIM_FTYPE, > and MIIM_STRING. So if one wants to specify a text menu item in XP, one would use MIIM_STRING, not MIIM_TYPE. fType would also need to be MFT_STRING. In menu.c in GetMenuItemInfo_common(): /* copy the text string */ if ((lpmii->fMask & (MIIM_TYPE|MIIM_STRING)) && (MENU_ITEM_TYPE(menu->fType) == MF_STRING) && menu->text) { and so on... This works fine. It retrieves the text if either MIIM_TYPE or MIIM_STRING are set. But, in GetMenuItemInfo_common(): if (lpmii->fMask & MIIM_TYPE) { /* Get rid of old string. */ if (IS_STRING_ITEM(menu->fType) && menu->text) { HeapFree(GetProcessHeap(), 0, menu->text); menu->text = NULL; } /* make only MENU_ITEM_TYPE bits in menu->fType equal lpmii->fType */ menu->fType &= ~MENU_ITEM_TYPE(menu->fType); menu->fType |= MENU_ITEM_TYPE(lpmii->fType); menu->text = lpmii->dwTypeData; and so on... This sets the text only if MIIM_TYPE is set. I changed the first line to: if (lpmii->fMask & (MIIM_TYPE|MIIM_STRING)) { and menus that were drawing before as a long thin vertical line, started to show correctly. I'm not sure if this is the right way to fix this, but it works for me. I am using a wine version from 2004-04-08. BTW, I reported earlier a crash in menu.c. I did not hear anything back. Should I log this into Bugzilla? Thanks, Dan Timis Muse Research, Inc.

2 1

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov July 30, 2004

July 30, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > This is a resubmit of my original patch that cleans up a->w cross > calls in crypt. > > Changelog > * cleanup a->w cross calls in advapi32/crypt.c > + static const WCHAR KEYSTR[] = { > + 'S','o','f','t','w','a','r','e','\\','\\', > + 'M','i','c','r','o','s','o','f','t','\\','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\','\\', > + 'D','e','f','a','u','l','t','s','\\','\\', > + 'P','r','o','v','i','d','e','r','\\','\\',0 > + }; Remove double backslashes here and everywhere else. > - keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1); > + keyname = CRYPT_Alloc(strlenW(KEYSTR) + strlenW(pProvName) + 1); Add '* sizeof(WCHAR)' and everywhere else where storage for unicode strings is allocated. > - keyname = CRYPT_Alloc( (user ? strlen(USERSTR) : strlen(MACHINESTR)) +1); > + keyname = CRYPT_Alloc( (user ? strlenW(USERSTR) : strlenW(MACHINESTR)) +1); Add '* sizeof(WCHAR)' > + static WCHAR nameW[] = {'N','a','m','e',0}; > + static WCHAR typeW[] = {'T','y','p','e',0}; > + static WCHAR imagePathW[] = {'I','m','a','g','e',' ','P','a','t','h',0}; > + static WCHAR signatureW[] = {'S','i','g','n','a','t','u','r','e',0}; > + static WCHAR sigInFileW[] = {'S','i','g','I','n','F','i','l','e',0}; Add 'const'. > - if ( !(provname = CRYPT_Alloc(strlen(pszProvider) +1)) ) > + if ( !(provname = CRYPT_Alloc(strlenW(pszProvider) +1)) ) Add '* sizeof(WCHAR)' > - len = ExpandEnvironmentStringsA(temp, NULL, 0); > + len = ExpandEnvironmentStringsW(temp, NULL, 0); > if ( !(imagepath = CRYPT_Alloc(len)) ) Add '* sizeof(WCHAR)' ... And lots of similar bugs. -- Dmitry.

1 0

Re: change the nt service pack version from 6 to 6a, correct win2k3 name
by Ivan Leo Puoti July 30, 2004

July 30, 2004

>Easy, take several W2K3 system DLLs and kick them through winedump with what command line?

1 0

Re: add autodetect audio driver capability to winmm, second try
by Alexandre Julliard July 29, 2004

July 29, 2004

James Hawkins <truiken(a)gmail.com> writes: > + /* try to detect arts */ > + argv_new[2] = "ps awx|grep artsd|grep -v grep|grep artsd > /dev/null"; > + if(!spawnvp(_P_WAIT, "/bin/sh", argv_new)) > + { > + driversFound[numFound] = "winearts.drv"; > + name[numFound] = "aRts"; > + numFound++; > + } This code does not belong in winmm. Autodetection in winmm should be done by having the drivers themselves fail to load if the corresponding support is missing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Test drive error
by sergio ojalvo July 29, 2004

July 29, 2004

Hi I'm working on Debian Linux. I just install the wine packages and download sources for trying the test driver. Running Winemaker to winemine test project I note: that configure script was not created and Makefile is created instead of Makefile.in. (like wrote in the web page) I think is a new feature... I'm wrong? Anyway, I try to run make after that and that is the output: winebuild -o winemine.exe.dbg.c --debug -C. dialog.c main.c winegcc -c -mno-cygwin -I. -o winemine.exe.dbg.o winemine.exe.dbg.c winegcc -c -mno-cygwin -I. -o dialog.o dialog.c winegcc -c -mno-cygwin -I. -o main.o main.c wrc -I. -foEn.res En.rc En.rc:23:22: Error: syntax error make: *** [En.res] Error 1 After that I try with another 2 projects (win32 code) and I receive a lot of compilation errors like: In file included from /usr/include/c++/3.3/iosfwd:46, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/c++/3.3/i486-linux/bits/c++locale.h:53: error: `uselocale' was not declared in this scope In file included from /usr/include/c++/3.3/i486-linux/bits/c++io.h:35, from /usr/include/c++/3.3/bits/fpos.h:44, from /usr/include/c++/3.3/iosfwd:49, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/c++/3.3/cstdio:167: error: `snprintf' not declared /usr/include/c++/3.3/cstdio:168: error: `vfscanf' not declared /usr/include/c++/3.3/cstdio:169: error: `vscanf' not declared /usr/include/c++/3.3/cstdio:171: error: `vsscanf' not declared /usr/include/c++/3.3/cstdio:177: error: `snprintf' not declared /usr/include/c++/3.3/cstdio:178: error: `vfscanf' not declared /usr/include/c++/3.3/cstdio:179: error: `vscanf' not declared /usr/include/c++/3.3/cstdio:181: error: `vsscanf' not declared In file included from /usr/include/c++/3.3/i486-linux/bits/gthr-default.h:37, from /usr/include/c++/3.3/i486-linux/bits/gthr.h:98, from /usr/include/c++/3.3/i486-linux/bits/c++io.h:37, from /usr/include/c++/3.3/bits/fpos.h:44, from /usr/include/c++/3.3/iosfwd:49, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/pthread.h:651: error: type specifier omitted for parameter `clockid_t' /usr/include/pthread.h:651: error: parse error before `*' token In file included from /usr/include/c++/3.3/bits/fpos.h:45, from /usr/include/c++/3.3/iosfwd:49, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/c++/3.3/cwchar:142: error: `fwide' not declared /usr/include/c++/3.3/cwchar:149: error: `mbsinit' not declared /usr/include/c++/3.3/cwchar:157: error: `vfwscanf' not declared /usr/include/c++/3.3/cwchar:159: error: `vswscanf' not declared /usr/include/c++/3.3/cwchar:161: error: `vwscanf' not declared /usr/include/c++/3.3/cwchar:176: error: `wcstof' not declared /usr/include/c++/3.3/cwchar:182: error: `wmemcmp' not declared /usr/include/c++/3.3/cwchar:183: error: `wmemcpy' not declared /usr/include/c++/3.3/cwchar:184: error: `wmemmove' not declared /usr/include/c++/3.3/cwchar:185: error: `wmemset' not declared /usr/include/c++/3.3/cwchar:213: error: `wmemchr' not declared /usr/include/c++/3.3/cwchar: In function `wchar_t* std::wmemchr(wchar_t*, wchar_t, unsigned int)': /usr/include/c++/3.3/cwchar:217: error: invalid conversion from `const wchar_t* ' to `wchar_t*' /usr/include/c++/3.3/cwchar: At global scope: /usr/include/c++/3.3/cwchar:233: error: `wcstold' not declared /usr/include/c++/3.3/cwchar:242: error: `wcstoll' not declared /usr/include/c++/3.3/cwchar:243: error: `wcstoull' not declared /usr/include/c++/3.3/cwchar:249: error: `wcstold' not declared /usr/include/c++/3.3/cwchar:250: error: `wcstoll' not declared /usr/include/c++/3.3/cwchar:251: error: `wcstoull' not declared etc, etc, etc.... I send you my gcc configuration: gcc -v Reading specs from /usr/lib/gcc-lib/i486-linux/3.3.4/specs Configured with: ../src/configure -v --enable-languages=c,c++,java,f77,pascal,objc,ada,treelang --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-gxx-include-dir=/usr/include/c++/3.3 --enable-shared --with-system-zlib --enable-nls --without-included-gettext --enable-__cxa_atexit --enable-clocale=gnu --enable-debug --enable-java-gc=boehm --enable-java-awt=xlib --enable-objc-gc i486-linux Thread model: posix gcc version 3.3.4 (Debian 1:3.3.4-4) Any suggestion? Thanks a lot for your help. -- ____________________________ ________ _______________________________ | Sergio Ojalvo \ \ / | | Senior System Analyst \ \/ To bring IN-OVATION turn to | | mailto:sergio(a)ximpo.com /\ \ your open source of solutions | | Phone: +972-545-558586 / \ \ | | Fax: +972-151-545-558586 -------- http://www.ximpo.com/ | |__________________________ Ximpo Group _____________________________|

3 4

Re: [D3D] Added native and emulated S3TC support
by Lionel Ulmer July 29, 2004

July 29, 2004

I have just a few comments on the patch (yeah, it would not have been fun if I had commented on wine-d3d first :-) ). But anyway, great work ! > +static BOOL DDRAW_bind_to_s3tc( void ) > +{ > + const char *s3tcname = SONAME_LIBS3TC; > + > + s3tc_handle = wine_dlopen(s3tcname, RTLD_NOW, NULL, 0); > + if (!s3tc_handle) { > + printf("Wine cannot find the S3TC software decompression library (%s).\n",s3tcname); Why did you use 'printf' here instead of WARN or ERR ? Moreover, with this, we will print an error at DirectX loading when the users do not have this library installed ... even if the game does never request any compressed mode textures. Would it not be better to somehow print the error message when the application wants to create a DXTN texture (ie somehow remember that we do not support this feature and keep the error message for later). > + return FALSE; > + } > + > +#define API_FUNCTION(f) \ > + if((f = wine_dlsym(s3tc_handle, #f, NULL, 0)) == NULL) \ > + { \ > + printf("Can't find symbol %s\n", #f); \ Same printf comment here (but this one can be kept here :-) ). > + goto sym_not_found; \ > + } > + API_FUNCTION(fetch_2d_texel_rgba_dxt1); > + API_FUNCTION(fetch_2d_texel_rgba_dxt3); > + API_FUNCTION(fetch_2d_texel_rgba_dxt5); > +#undef API_FUNCTION > + > + return TRUE; > + > +sym_not_found: > + WARN("Wine cannot find functions that are necessary for S3TC decompression\n"); > + wine_dlclose(s3tc_handle, NULL, 0); > + s3tc_handle = NULL; > + return FALSE; > +} > + (...) > > + if (src_pf->dwFlags & DDPF_FOURCC) { > + GLenum retVal; > + int size = surf_ptr->surface_desc.u1.dwLinearSize; > + int width = surf_ptr->surface_desc.dwWidth; > + int height = surf_ptr->surface_desc.dwHeight; > + LPVOID buffer = surf_ptr->surface_desc.lpSurface; > + > + switch (src_pf->dwFourCC) { > + case MAKE_FOURCC('D','X','T','1'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT1_EXT; break; > + case MAKE_FOURCC('D','X','T','3'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT3_EXT; break; > + case MAKE_FOURCC('D','X','T','5'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT5_EXT; break; > + default: > + FIXME("FourCC Not supported\n"); > + return DD_OK; > + break; > + } > + GL_extensions.glCompressedTexImage2D(GL_TEXTURE_2D, current_level, retVal, width, height, 0, size, buffer); How are we sure that this code will never be called with the 'glCompressedTexImage2D' unset ? I.e. when we are in emulation mode, what happens here ? Is this because when we are in emulation mode, we do not advertise support for DTXN textures, this means that the application can create such textures, but will be automagically converted to RGB ones at Loading ? Anyway, I would still prefer a test here to prevent crashes for application which do not behave well :-) (...) > + if (current_surface->surface_desc.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) { > + GLint retVal; > + int size = current_surface->surface_desc.u1.dwLinearSize; > + int width_ = current_surface->surface_desc.dwWidth; > + int height_ = current_surface->surface_desc.dwHeight; > + LPVOID buffer = current_surface->surface_desc.lpSurface; > + > + switch (current_surface->surface_desc.u4.ddpfPixelFormat.dwFourCC) { > + case MAKE_FOURCC('D','X','T','1'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT1_EXT; break; > + case MAKE_FOURCC('D','X','T','3'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT3_EXT; break; > + case MAKE_FOURCC('D','X','T','5'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT5_EXT; break; > + default: > + FIXME("Not supported\n"); > + return DD_OK; > + break; > + } > + /* GL_extensions.glCompressedTexSubImage2D(GL_TEXTURE_2D, current_level, xoffset, yoffset, width, height, retVal, (unsigned char*)temp_buffer); */ > + GL_extensions.glCompressedTexImage2D(GL_TEXTURE_2D, current_level, retVal, width_, height_, 0, size, buffer); Same here. > + } > + > + if (strstr(glExtensions, "GL_EXT_texture_compression_s3tc")) { > + TRACE(" - S3TC compression supported\n"); > + GL_extensions.s3tc_compressed_texture = TRUE; > + GL_extensions.glCompressedTexImage2D = pglXGetProcAddressARB("glCompressedTexImage2D"); > + GL_extensions.glCompressedTexSubImage2D = pglXGetProcAddressARB("glCompressedTexSubImage2D"); > } If I were pedantic, you should test for 'GL_ARB_texture_compression' to be able to get the 'glCompressedTexImage2DARB' and 'glCompressedTexSubImage2DARB' functions (which may be better than using the non-ARB versions which are, AFAIK, the ones in GL 1.4). And then to get 'GL_EXT_texture_compression_s3tc' to set 'GL_extensions.s3tc_compressed_texture' to TRUE. But as 'GL_EXT_texture_compression_s3tc' depends on 'GL_ARB_texture_compression', I will let you do this shortcut :-) > - /* We do not support for now compressed texture formats... */ > - if (ddsd.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) > + /* We support for now only DXT1, DXT3 & DXT5 compressed texture formats... */ > + if ((ddsd.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) && > + (ddsd.u4.ddpfPixelFormat.dwFourCC != MAKE_FOURCC('D','X','T','1')) && > + (ddsd.u4.ddpfPixelFormat.dwFourCC != MAKE_FOURCC('D','X','T','3')) && > + (ddsd.u4.ddpfPixelFormat.dwFourCC != MAKE_FOURCC('D','X','T','5')) ) > { > return DDERR_INVALIDPIXELFORMAT; > } What to do here when neither hardware nor emulated support is present ? Maybe we should print an error (cf previous comment) and return INVALIDPIXELFORMAT, no ? Lionel (who goes testing NOFL :-) ) -- Lionel Ulmer - http://www.bbrox.org/

3 5

Re: Fix crash in dsound test
by Robert Reif July 29, 2004

July 29, 2004

How did this fail in windows. Since it doesn't crash with wine, wine is doing something wrong. Lets try to figure out what is wrong and correct wine to have the same behavior as windows or at least notify someone that something is wrong. Is anyone working on getting direct sound into the windows port of our regression tests? Francois Gouget wrote: > > Changelog: > > * dlls/dsound/tests/dsound.c > > Francois Gouget <fgouget(a)codeweavers.com> > Call IDirectSound::Initialize() as per MSDN before using the > DirectSound object. Fixes a crash on Windows. > >------------------------------------------------------------------------ > >Index: dlls/dsound/tests/dsound.c >=================================================================== >RCS file: /var/cvs/wine/dlls/dsound/tests/dsound.c,v >retrieving revision 1.24 >diff -u -r1.24 dsound.c >--- dlls/dsound/tests/dsound.c 13 Jul 2004 23:35:09 -0000 1.24 >+++ dlls/dsound/tests/dsound.c 16 Jul 2004 16:23:51 -0000 >@@ -69,6 +69,9 @@ > if (rc==DS_OK) > IDirectSound8_Release(ds8); > >+ rc=IDirectSound_Initialize(dso,NULL); >+ ok(rc==DS_OK,"IDirectSound_Initialize(NULL) failed: %s\n",DXGetErrorString9(rc)); >+ > /* DSOUND: Error: Invalid caps buffer */ > rc=IDirectSound_GetCaps(dso,0); > ok(rc==DSERR_INVALIDPARAM,"GetCaps should have failed: %s\n",DXGetErrorString9(rc)); >@@ -168,6 +171,9 @@ > if (rc==DS_OK) > IDirectSound8_Release(ds8); > >+ rc=IDirectSound8_Initialize(dso,NULL); >+ ok(rc==DS_OK,"IDirectSound_Initialize(NULL) failed: %s\n",DXGetErrorString9(rc)); >+ > /* DSOUND: Error: Invalid caps buffer */ > rc=IDirectSound8_GetCaps(dso,0); > ok(rc==DSERR_INVALIDPARAM,"GetCaps should have failed: %s\n",DXGetErrorString9(rc)); > >

5 7