July 2004 - Wine-Devel - list.winehq.org

ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed
by Saulius Krasuckas July 10, 2004

July 10, 2004

With thepatch [1] I am getting some this line from Wine: err:wave:OSS_RawOpenDevice ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed (Input/output error) Yes, my soundcard doesn't support full duplex, I believe (I have OPTi 82c931 chip with mad16 driver running here). But shouldn't the type of the message be WARN or TRACE instead of ERR then? [1] http://cvs.winehq.org/patch.py?id=12636

2 1

Re: Initial creation of directory and config with ttydrv
by Shachar Shemesh July 10, 2004

July 10, 2004

brettholcomb(a)charter.net wrote: >Just run wine. The first time it will create the directory. > > > >>From: Shachar Shemesh <wine-devel(a)shemesh.biz> >>Date: 2004/07/08 Thu AM 11:35:21 GMT >>To: Wine Development <wine-devel(a)winehq.org> >>Subject: Initial creation of directory and config with ttydrv >> >>Hi all, >> >>I need to create the initial environment for wine (the .wine directory) >>in an environment where no X11 server is available. Once the directory >>is up (for example, if I copy it from somewhere), there is no problem to >>add a config file that chooses the ttydrv driver. However, I cannot >>create the initial directory. >> >>Is there any solution to this problem, or should I just copy the initial >>config from somewhere? >> >> Shachar >> >> Wine won't run if it is set to use the X11drv driver, and there is no X11 display. Then again, the only way I can tell it to use the ttydrv is by placing a config file in the .wine directory, which does not exist until I run wine once. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

4 7

Re: D3D8_GetCreationParameters fix
by Andrei Barbu July 10, 2004

July 10, 2004

MSDN says that if it's given an invalid pointer it should return D3DERR_INVALIDCALL, so that's what it does now. MSDN: http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… So I'm guessing this is right now. I don't have a windows computer to check this against, but it does comply with the docs. Andrei On Fri, 2004-07-09 at 11:19, Mike McCormack wrote: > This patch is better than the first one, but... > > Windows doesn't usually check pointers like this. Can you try testing > the Windows implementation of IDirect3DDevice8->GetCreationParameters() > to see whether it crashes when passed an invalid pointer such as NULL or > 0x00000001? It may be that the invalid pointer is coming from somewhere > else in Wine's code, so you may be just hiding another bug. > > Mike > > Andrei Barbu wrote: > > And this is the correct patch. > > > @@ -380,6 +381,12 @@ > > HRESULT WINAPI IDirect3DDevice8Impl_GetCreationParameters(LPDIRECT3DDEVICE8 iface, D3DDEVICE_CREATION_PARAMETERS *pParameters) { > > ICOM_THIS(IDirect3DDevice8Impl,iface); > > TRACE("(%p) copying to %p\n", This, pParameters); > > + > > + if( IsBadWritePtr( pParameters , sizeof( D3DDEVICE_CREATION_PARAMETERS ) ) ) > > + { > > + WARN("(%p) : bad pointer in device caps (%p)\n", This, pParameters); > > + return D3DERR_INVALIDCALL; > > + } > > memcpy(pParameters, &This->CreateParms, sizeof(D3DDEVICE_CREATION_PARAMETERS)); > > return D3D_OK; > > } > >

4 7

Re: MSI: implement MsiVerifyPackage, cosmetic fixes (with the patch)
by Mike McCormack July 9, 2004

July 9, 2004

Mike McCormack wrote: > > This is the last change required to sync up the CrossOver's current MSI > implementation with WineHQs. > > Mike > > > ChangeLog: > * implement MsiVerifyPackage, cosmetic fixes > diff -ur dlls/msi/action.c /home/mike/codeweavers/office/wine/dlls/msi/action.c --- dlls/msi/action.c 2004-07-09 14:07:57.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/action.c 2004-06-28 15:01:36.000000000 -0500 @@ -3023,7 +3023,7 @@ } /* - * components FeatureState defaults to FALSE. the idea is we want to + * Components FeatureState defaults to FALSE. The idea is we want to * enable the component is ANY feature that uses it is enabled to install */ for(i = 0; i < package->loaded_features; i++) @@ -3050,7 +3050,7 @@ if (override != NULL) HeapFree(GetProcessHeap(),0,override); /* - * so basically we ONLY want to install a component if its Enabled AND + * So basically we ONLY want to install a component if its Enabled AND * FeatureState are both TRUE */ return ERROR_SUCCESS; @@ -3303,10 +3303,10 @@ static UINT ACTION_RegisterTypeLibraries(MSIPACKAGE *package) { /* - * ok this is a bit confusting.. I am given a _Component key and i believe + * OK this is a bit confusing.. I am given a _Component key and I believe * that the file that is being registered as a type library is the "key file - * of that component" which i interpert to mean "The file in the KeyPath of - * that component" + * of that component" which I interpret to mean "The file in the KeyPath of + * that component". */ UINT rc; MSIQUERY * view; @@ -3388,8 +3388,8 @@ debugstr_w(package->files[index].TargetPath)); else { - /* yes the row has more fields than i need, but #1 is - correct and the only one i need. why make a new row */ + /* Yes the row has more fields than I need, but #1 is + correct and the only one I need. Why make a new row? */ ui_actiondata(package,szRegisterTypeLibraries,row); @@ -3533,8 +3533,8 @@ static UINT ACTION_RegisterClassInfo(MSIPACKAGE *package) { /* - * Again I am assuming the words, "Whose key file respesents" when refering - * to a Component as to mean the Components KeyPath file + * Again I am assuming the words, "Whose key file represents" when refering + * to a Component as to meaning that Components KeyPath file * * Also there is a very strong connection between ClassInfo and ProgID * that I am mostly glossing over. @@ -3811,12 +3811,12 @@ static UINT ACTION_RegisterProgIdInfo(MSIPACKAGE *package) { /* - * Sigh, here i am just brute force registering all progid + * Sigh, here I am just brute force registering all progids * this needs to be linked to the Classes that have been registerd * but the easiest way to do that is to load all these stuff into * memory for easy checking. * - * gives me something to continue to work toward + * Gives me something to continue to work toward. */ UINT rc; MSIQUERY * view; diff -ur dlls/msi/cond.y /home/mike/codeweavers/office/wine/dlls/msi/cond.y --- dlls/msi/cond.y 2004-07-09 13:34:00.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/cond.y 2004-06-28 14:58:46.000000000 -0500 @@ -57,8 +57,6 @@ static LPWSTR COND_GetString( struct cond_str *str ); static int COND_lex( void *COND_lval, COND_input *info); -UINT get_property(MSIHANDLE hPackage, const WCHAR* prop, WCHAR* value, - DWORD* size); typedef INT (*comp_int)(INT a, INT b); typedef INT (*comp_str)(LPWSTR a, LPWSTR b, BOOL caseless); diff -ur dlls/msi/package.c /home/mike/codeweavers/office/wine/dlls/msi/package.c --- dlls/msi/package.c 2004-07-09 14:15:00.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/package.c 2004-07-02 15:07:40.000000000 -0500 @@ -254,7 +254,7 @@ 'D','e','s','k','t','o','p','\\',0}; /* - * Other things i notice set + * Other things I notice set * ScreenY ScreenX --- dlls/msi/msi.c 2004-07-09 14:07:57.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/msi.c 2004-06-28 15:06:37.000000000 -0500 @@ -1180,14 +1181,38 @@ UINT WINAPI MsiVerifyPackageA( LPCSTR szPackage ) { - FIXME("%s\n", debugstr_a(szPackage) ); - return ERROR_CALL_NOT_IMPLEMENTED; + UINT r, len; + LPWSTR szPack = NULL; + + TRACE("%s\n", debugstr_a(szPackage) ); + + if( szPackage ) + { + len = MultiByteToWideChar( CP_ACP, 0, szPackage, -1, NULL, 0 ); + szPack = HeapAlloc( GetProcessHeap(), 0, len*sizeof(WCHAR) ); + if( !szPack ) + return ERROR_OUTOFMEMORY; + MultiByteToWideChar( CP_ACP, 0, szPackage, -1, szPack, len ); + } + + r = MsiVerifyPackageW( szPack ); + + HeapFree( GetProcessHeap(), 0, szPack ); + + return r; } UINT WINAPI MsiVerifyPackageW( LPCWSTR szPackage ) { - FIXME("%s\n", debugstr_w(szPackage) ); - return ERROR_CALL_NOT_IMPLEMENTED; + MSIHANDLE handle; + UINT r; + + TRACE("%s\n", debugstr_w(szPackage) ); + + r = MsiOpenDatabaseW( szPackage, MSIDBOPEN_READONLY, &handle ); + MsiCloseHandle( handle ); + + return r; } INSTALLSTATE WINAPI MsiGetComponentPathA(LPCSTR szProduct, LPCSTR szComponent,

1 0

Re: Fix snprintfW Return Value
by Alexandre Julliard July 9, 2004

July 9, 2004

Rob Shearman <rob(a)codeweavers.com> writes: > At present, if the size of the buffer passed to snprintfW is too small > then the function returns -1, as opposed to the required size of the > buffer (as per C snprintf). This greatly limits its usefulness and can > give incorrect results for those using the function that don't > explicitly check for -1 being returned. A grep of the source tree shows > that nothing depends on this behaviour. Actually, something does depend on it: it is used to implement _vsnwprintf in ntdll, so you can't change it. -- Alexandre Julliard julliard(a)winehq.org

2 2

support code for HANDLE tables
by Michael Jung July 9, 2004

July 9, 2004

Hello, I'm currently playing around with the rsabase.dll implementation. Since this is the first time I'm writing wine code, I've got some questions: Is there support code for managing HANDLE tables? Or does every dll implementation provide it's own functions for doing this? Or do HANDLEs of each and every kind have to be administered by wineserver? The current CVS version of rsabase just casts between pointers and HCRYPTPROVs. Is this just a quick and dirty hack or common practice? Greetings and thanks, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

3 2

Re: D3D8_GetCreationParameters fix
by Andrei Barbu July 9, 2004

July 9, 2004

I don't personally know enough about IsBadWritePtr to write a test case. Any suggestions? :P I'll check out the code later on, but for now it seems to be fine. What else could it use to validate that pointer? Andrei On Fri, 2004-07-09 at 15:02, Mike McCormack wrote: > Andrei Barbu wrote: > > > I think even if a wine bug might be generating that bad pointer, which I > > don't think it is since Chessmaster works fine after that, this is how > > DX works, so we should implement it. If it doesn't crash on windows, why > > should it in wine? > > It is rare that Windows uses IsBadWritePtr to validate arguments, so if > you believe it works that way, prove it by writing a test case and > running it on a Windows box. Somebody is going to be suprised by the > results ;) > > Mike >

2 1

Re: D3D8_GetCreationParameters fix
by Andrei Barbu July 9, 2004

July 9, 2004

And this is the correct patch. Sorry about that, ignore the above. The above actually allocated the memory, this just returns that the op. didn't succeed which is the correct thing to do. Chessmaster seems to be happy too. On Thu, 2004-07-08 at 15:38, Andrei Barbu wrote: > Changelog: > > Fixes a memory access fault inside of D3D8_GetCreationParameters. > >

1 0

Fullscreening patch
by Mike Hearn July 9, 2004

July 9, 2004

Hi Alexandre, Yes, it's that time again. Can you take another look at this patch? Getting it in is the first step towards fixing a bunch of "i typed but it appeared on the console instead of the game!" bugs (as well as improving a bunch of apps like IE, TightVNC etc). thanks -mike Index: dlls/x11drv/window.c =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/x11drv/window.c,v retrieving revision 1.49.2.1.2.2 diff -u -w -B -r1.49.2.1.2.2 window.c --- dlls/x11drv/window.c 28 Apr 2004 00:08:44 -0000 1.49.2.1.2.2 +++ dlls/x11drv/window.c 12 May 2004 13:57:38 -0000 @@ -78,6 +78,7 @@ "_MOTIF_WM_HINTS", "_KDE_NET_WM_SYSTEM_TRAY_WINDOW_FOR", "_NET_WM_STATE", + "_NET_WM_STATE_FULLSCREEN", "_NET_WM_STATE_MAXIMIZED_VERT", "_NET_WM_STATE_MAXIMIZED_HORZ", "_NET_WM_STATE_SKIP_TASKBAR", @@ -133,6 +134,7 @@ inline static BOOL is_window_managed( WND *win ) { if (!managed_mode) return FALSE; + /* tray window is always managed */ if (win->dwExStyle & WS_EX_TRAYWINDOW) return TRUE; /* tool windows *are* managed if we have mwm hints */ @@ -156,6 +158,8 @@ if (win->dwExStyle & WS_EX_TOOLWINDOW) return FALSE; /* windows with thick frame are managed */ if (win->dwStyle & WS_THICKFRAME) return TRUE; + /* windows with a system menu are managed */ + if (win->dwStyle & WS_SYSMENU) return TRUE; /* * CODEWEAVERS HACK @@ -189,13 +193,7 @@ /* application windows are managed */ if (win->dwExStyle & WS_EX_APPWINDOW) return TRUE; - /* full-screen popup windows are managed */ - if ((win->dwStyle & WS_POPUP) && - (win->rectWindow.right-win->rectWindow.left) == screen_width && - (win->rectWindow.bottom-win->rectWindow.top) == screen_height) - { - return TRUE; - } + /* default: not managed */ return FALSE; } @@ -435,7 +432,10 @@ size_hints->y = data->whole_rect.top; size_hints->flags = PWinGravity | PPosition; - if ( !(win->dwStyle & WS_THICKFRAME) ) + /* we only want to be able to resize windows with WS_THICKFRAME. + * in addition, metacity refuses to fullscreen non-resizable windows + */ + if ( !(win->dwStyle & WS_THICKFRAME) && !data->fullscreened) { size_hints->max_width = data->whole_rect.right - data->whole_rect.left; size_hints->max_height = data->whole_rect.bottom - data->whole_rect.top; @@ -590,7 +590,7 @@ if (win->dwStyle & WS_MINIMIZEBOX) mwm_hints.functions |= MWM_FUNC_MINIMIZE; if (win->dwStyle & WS_MAXIMIZEBOX) mwm_hints.functions |= MWM_FUNC_MAXIMIZE; if (win->dwStyle & WS_SYSMENU) mwm_hints.functions |= MWM_FUNC_CLOSE; - if ((win->dwStyle & WS_CAPTION) == WS_CAPTION) mwm_hints.decorations |= MWM_DECOR_TITLE; + if (((win->dwStyle & WS_CAPTION) == WS_CAPTION) && (!data->fullscreened)) mwm_hints.decorations |= MWM_DECOR_TITLE; if (win->dwExStyle & WS_EX_DLGMODALFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER; else if (win->dwStyle & WS_THICKFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER | MWM_DECOR_RESIZEH; else if ((win->dwStyle & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER; @@ -607,6 +607,15 @@ XChangeProperty( display, data->whole_window, x11drv_atom(XdndAware), XA_ATOM, 32, PropModeReplace, (unsigned char*)&dndVersion, 1 ); + /* for windows that are already mapped, toggle_fullscreen sends a message to the WM */ + if (data->fullscreened && !(win->dwStyle & WS_VISIBLE)) { + Atom newstate = x11drv_atom(_NET_WM_STATE_FULLSCREEN); + + TRACE("setting state to _NET_WM_STATE_FULLSCREEN\n"); + XChangeProperty( display, data->whole_window, x11drv_atom(_NET_WM_STATE), + XA_ATOM, 32, PropModeReplace, (unsigned char*)&newstate, 1 ); + } + wm_hints = XAllocWMHints(); wine_tsx11_unlock(); @@ -963,6 +972,8 @@ RECT rect; BOOL is_top_level = is_window_top_level( win ); + data->fullscreened = FALSE; + rect = win->rectWindow; X11DRV_window_to_X_rect( win, &rect ); Index: dlls/x11drv/winpos.c =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/x11drv/winpos.c,v retrieving revision 1.44.2.3.2.1 diff -u -w -B -r1.44.2.3.2.1 winpos.c --- dlls/x11drv/winpos.c 27 Apr 2004 22:38:15 -0000 1.44.2.3.2.1 +++ dlls/x11drv/winpos.c 12 May 2004 13:57:50 -0000 @@ -76,6 +76,45 @@ extern XContext winContext; /*********************************************************************** + * toggle_fullscreen + * + * Use the NETWM fullscreening protocol to toggle fullscreened state. This only + * works for mapped windows. + */ +static void toggle_fullscreen( HWND hwnd ) +{ + WND *win = WIN_GetPtr(hwnd); + struct x11drv_win_data *data = win->pDriverData; + XEvent xev; + + TRACE("hwnd=%p, current=%s\n", hwnd, data->fullscreened ? "true" : "false"); + data->fullscreened = !data->fullscreened; + + wine_tsx11_lock(); + + X11DRV_set_wm_hints(thread_display(), win); + if (win->dwStyle & WS_VISIBLE) { + TRACE("toggling fullscreen state\n"); + xev.xclient.type = ClientMessage; + xev.xclient.window = data->whole_window; + xev.xclient.message_type = x11drv_atom(_NET_WM_STATE); + xev.xclient.serial = 0; + xev.xclient.display = thread_display(); + xev.xclient.send_event = True; + xev.xclient.format = 32; + /* using _NET_WM_STATE_TOGGLE here does not work correctly with some WMs */ + xev.xclient.data.l[0] = (data->fullscreened ? _NET_WM_STATE_ADD : _NET_WM_STATE_REMOVE); + xev.xclient.data.l[1] = x11drv_atom(_NET_WM_STATE_FULLSCREEN); + xev.xclient.data.l[2] = 0; + XSendEvent(thread_display(), root_window, False, SubstructureRedirectMask | SubstructureNotifyMask, &xev); + TRACE("toggled\n"); + } + + wine_tsx11_unlock(); + WIN_ReleasePtr(win); +} + +/*********************************************************************** * clip_children * * Clip all children of a given window out of the visible region @@ -936,25 +976,44 @@ RECT newWindowRect, newClientRect; RECT oldWindowRect, oldClientRect; UINT wvrFlags = 0; - BOOL bChangePos; + BOOL bChangePos, fromXEvent; + struct x11drv_win_data *data; - TRACE( "hwnd %p, after %p, swp %d,%d %dx%d flags %08x\n", + TRACE("hwnd %p, insert-after %p, swp %d,%d %dx%d\n", winpos->hwnd, winpos->hwndInsertAfter, winpos->x, winpos->y, - winpos->cx, winpos->cy, winpos->flags); + winpos->cx, winpos->cy); + fromXEvent = winpos->flags & SWP_WINE_NOHOSTMOVE; bChangePos = !(winpos->flags & SWP_WINE_NOHOSTMOVE); winpos->flags &= ~SWP_WINE_NOHOSTMOVE; /* Check window handle */ if (winpos->hwnd == GetDesktopWindow()) return FALSE; + if (!(wndPtr = WIN_FindWndPtr( winpos->hwnd ))) return FALSE; + data = wndPtr->pDriverData; + if (!SWP_DoWinPosChanging( winpos, &newWindowRect, &newClientRect )) return FALSE; + if (data->fullscreened) { + + /* Windows has no concept of fullscreen, so to unfullscreen an app you just resize it or move it. + * Therefore we need to watch for this behaviour and release fullscreen mode so we can once again + * control our position. + */ + + if (!fromXEvent /* ignore spurious WM changes once we are fullscreened */ + && !(winpos->flags & (SWP_FRAMECHANGED|SWP_NOMOVE|SWP_NOSIZE|SWP_NOACTIVATE)) /* ignore SWP calls that aren't changing our geometry */ + && !((newWindowRect.left < 0) && (newWindowRect.top < 0))) /* probably moving us beyond the screen boundaries to hide the borders, ignore */ { + + TRACE("releasing fullscreen for %p\n", winpos->hwnd); + toggle_fullscreen( winpos->hwnd ); + } + } + /* Fix redundant flags */ if (!fixup_flags( winpos )) return FALSE; - if (!(wndPtr = WIN_FindWndPtr( winpos->hwnd ))) return FALSE; - TRACE(" current (%ld,%ld)-(%ld,%ld), client (%ld,%ld)-(%ld,%ld), style %08x\n", wndPtr->rectWindow.left, wndPtr->rectWindow.top, wndPtr->rectWindow.right, wndPtr->rectWindow.bottom, @@ -973,8 +1032,9 @@ } /* Common operations */ + wvrFlags = SWP_DoNCCalcSize( winpos, &newWindowRect, &newClientRect ); /* FIXME: this should only be called if the size is actually being changed, unless SWP_FRAMECHANGED is set */ - wvrFlags = SWP_DoNCCalcSize( winpos, &newWindowRect, &newClientRect ); + TRACE("after NC_CALCSIZE (%ld,%ld,%ld,%ld)\n", newWindowRect.left, newWindowRect.top, newWindowRect.right, newWindowRect.bottom); if(!(winpos->flags & SWP_NOZORDER) && winpos->hwnd != winpos->hwndInsertAfter) { @@ -1049,6 +1109,7 @@ XClearArea( display, get_whole_window(wndPtr), 0, 0, 0, 0, True ); winpos->flags |= SWP_FRAMECHANGED; } + if (winpos->flags & SWP_SHOWWINDOW) { set_visible_style( winpos->hwnd, TRUE ); @@ -1124,6 +1185,7 @@ SendMessageA( winpos->hwnd, WM_WINDOWPOSCHANGED, 0, (LPARAM)winpos ); /* WM_WINDOWPOSCHANGED is send even if SWP_NOSENDCHANGING is set */ + TRACE("done for %p\n", winpos->hwnd); return TRUE; } @@ -1206,6 +1265,7 @@ POINT size; LONG old_style; WINDOWPLACEMENT wpl; + struct x11drv_win_data* data; TRACE("%p %u\n", hwnd, cmd ); @@ -1224,9 +1284,12 @@ if (!(wndPtr = WIN_FindWndPtr( hwnd ))) return 0; + data = wndPtr->pDriverData; + size.x = wndPtr->rectWindow.left; size.y = wndPtr->rectWindow.top; + switch( cmd ) { case SW_MINIMIZE: @@ -1400,11 +1463,13 @@ BOOL X11DRV_ShowWindow( HWND hwnd, INT cmd ) { WND* wndPtr = WIN_FindWndPtr( hwnd ); + struct x11drv_win_data *data; BOOL wasVisible, showFlag, wmMaximize, wmMinimize; RECT newPos = {0, 0, 0, 0}; UINT swp = 0; if (!wndPtr) return FALSE; + data = wndPtr->pDriverData; hwnd = wndPtr->hwndSelf; /* make it a full handle */ TRACE("hwnd=%p, cmd=%d\n", hwnd, cmd); @@ -1539,11 +1604,18 @@ MAKELONG(wndPtr->rectClient.left, wndPtr->rectClient.top) ); } + if (!data->fullscreened && wmMaximize) { + /* we should fullscreen captionless windows on maximization (IE uses this) */ + if ((wndPtr->dwStyle & WS_CAPTION) != WS_CAPTION) { + if ((wmMaximize && data->fullscreened) || (cmd == SW_RESTORE && !data->fullscreened)) { + TRACE("toggling fullscreen due to %s of captionless window %p\n", wmMaximize ? "maximization" : "restoration", hwnd); + toggle_fullscreen( hwnd ); + } + } else /* ask the window manager to maximize this window for us */ - if( wmMaximize ) X11DRV_WMMaximizeWindow(wndPtr, TRUE); - else if ( wmMinimize ) - X11DRV_WMMinimizeWindow(wndPtr); + } else if (wmMinimize) X11DRV_WMMinimizeWindow(wndPtr); + END: WIN_ReleaseWndPtr(wndPtr); @@ -2191,8 +2263,10 @@ /* if nothing changed, don't do anything */ if (winpos.flags == (SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE)) return; + TRACE("syncing window pos enter\n"); SetWindowPos( hwnd, winpos.hwndInsertAfter, winpos.x, winpos.y, winpos.cx, winpos.cy, winpos.flags | SWP_WINE_NOHOSTMOVE ); + TRACE("syncing window pos leave\n"); } Index: dlls/x11drv/x11drv.h =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/x11drv/x11drv.h,v retrieving revision 1.16.4.1 diff -u -w -B -r1.16.4.1 x11drv.h --- dlls/x11drv/x11drv.h 27 Apr 2004 22:38:15 -0000 1.16.4.1 +++ dlls/x11drv/x11drv.h 12 May 2004 13:57:54 -0000 @@ -420,6 +420,7 @@ XATOM__MOTIF_WM_HINTS, XATOM__KDE_NET_WM_SYSTEM_TRAY_WINDOW_FOR, XATOM__NET_WM_STATE, + XATOM__NET_WM_STATE_FULLSCREEN, XATOM__NET_WM_STATE_MAXIMIZED_VERT, XATOM__NET_WM_STATE_MAXIMIZED_HORZ, XATOM__NET_WM_STATE_SKIP_TASKBAR, @@ -555,6 +556,7 @@ XIC xic; /* X input context */ HBITMAP hWMIconBitmap; HBITMAP hWMIconMask; + BOOL fullscreened; /* does the window have a NETWM fullscreening hint set? */ }; typedef struct x11drv_win_data X11DRV_WND_DATA;

1 0

Re: Re: D3D8_GetCreationParameters fix
by Christian Costa July 9, 2004

July 9, 2004

> Message du 09/07/04 10:46 > De : "Lionel Ulmer" > A : "Andrei Barbu" > Copie à : "Christian Costa" , "Marcus Meissner" , "Mike McCormack" , wine-devel(a)winehq.org > Objet : Re: D3D8_GetCreationParameters fix > On Thu, Jul 08, 2004 at 08:45:16PM -0400, Andrei Barbu wrote: > > I agree on the docs, interestingly enough though, > > Chessmaster 9000 gives an invalid pointer (0x1) > > and there's a memory access error. > > > > Works on Windows though, so I'm assuming DX might be > > allocating the memory on it's own. > > When you mean 'works on Windows' is it Chessmaser 9000 or the fact that > giving a bad pointer to this DX8 API call does not make the program crash ? > I think he means ChessMaster 9000. > Because to be sure to get your patch applied, the best way would be to > understand WHY CM9000 gives this 0x1 pointer to the DX8 function. It may be > due to a memory allocation error, some stack trashing, some other bugs in > Wine, ... Agreed. > > So I fear that only doing some REing of the CM9000 code would help here. > This is the best things to do but the problem is not always obvious. If REing does not give significant result, I would suggest to check how the function behaves in windows and implement the same behaviour with maybe a big comment about ChessMaster 9000. Bye, Christian

2 1

Re: Re: D3D8_GetCreationParameters fix
by Christian Costa July 9, 2004

July 9, 2004

> Message du 09/07/04 00:57 > De : "Andrei Barbu" > A : "Christian Costa" > Copie à : "Marcus Meissner" , "Mike McCormack" , wine-devel(a)winehq.org > Objet : Re: D3D8_GetCreationParameters fix > Having given thought to the issue, you're right. > That was a bad solution, sorry. > > It should have failed with D3DERR_INVALIDCALL if it's a bad write > pointer. > Is this new patch ok? > Seems good. :-) Bye, Christian

1 0

Re: D3D8_GetCreationParameters fix
by Mike McCormack July 9, 2004

July 9, 2004

You probably want to use a Windows method to allocate memory here, such as HeapAlloc() or CoTaskMemAlloc, as the caller is not going to use free() to free the memory... Mike Andrei Barbu wrote: > Changelog: > > Fixes a memory access fault inside of D3D8_GetCreationParameters. ... > HRESULT WINAPI IDirect3DDevice8Impl_GetCreationParameters(LPDIRECT3DDEVICE8 iface, D3DDEVICE_CREATION_PARAMETERS *pParameters) { > ICOM_THIS(IDirect3DDevice8Impl,iface); > TRACE("(%p) copying to %p\n", This, pParameters); > + > + pParameters = (D3DDEVICE_CREATION_PARAMETERS*) malloc( sizeof( D3DDEVICE_CREATION_PARAMETERS )); > memcpy(pParameters, &This->CreateParms, sizeof(D3DDEVICE_CREATION_PARAMETERS)); > return D3D_OK; > }

6 8

Initial creation of directory and config with ttydrv
by Shachar Shemesh July 8, 2004

July 8, 2004

Hi all, I need to create the initial environment for wine (the .wine directory) in an environment where no X11 server is available. Once the directory is up (for example, if I copy it from somewhere), there is no problem to add a config file that chooses the ttydrv driver. However, I cannot create the initial directory. Is there any solution to this problem, or should I just copy the initial config from somewhere? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

HKEY_DYN_DATA in win9x
by Robert Reif July 8, 2004

July 8, 2004

I have a program that fails when it can't find HKEY_DYN_DATA\Config Manager\Enum in the registry. Any pointers on where to start?

2 3

Re: Cleanup A->W calls:
by Dmitry Timoshkov July 8, 2004

July 8, 2004

truiken(a)gmail.com wrote: > @@ -362,6 +363,24 @@ > */ > BOOL WINAPI Shell_NotifyIconA(DWORD dwMessage, PNOTIFYICONDATAA pnid ) > { > + BOOL ret; > + > + PNOTIFYICONDATAW p = HeapAlloc(GetProcessHeap(),0,sizeof(NOTIFYICONDATAW)); > + memcpy(p, pnid, sizeof(NOTIFYICONDATAW)); > + MultiByteToWideChar( CP_ACP, 0, pnid->szTip, -1, p->szTip, sizeof(p->szTip) ); MultiByteToWideChar takes number of wide characters, not bytes for the target buffer. > + p->szTip[sizeof(p->szTip)-1] = 0; Since p->szTip is a unicode buffer you have to divide sizeof(p->szTip) by sizeof(p->szTip[0]) here. -- Dmitry.

1 0

Re: Fix two bugs in SetScrollRange
by Dmitry Timoshkov July 8, 2004

July 8, 2004

"Troy Rollo" <wine(a)troy.rollo.name> wrote: > This fixes two bugs in SetScrollRange: > > 1. Setting the scroll range with the "bRedraw" flag set to true on a > non-control scrollbar results in the scrollbar being drawn over the whole > window area. > > 2. If you don't set WS_HSCROLL/WS_VSCROLL on window creation, setting a scroll > range does nothing. Setting the scroll range to a non-zero range should cause > scroll bars to be displayed (and the appropriate flag to be set in the window > styles). Setting the range to a zero range should cause the relevant scroll > bar to be hidden (and the flag to be removed from the window styles). > > The second attachment is a test program that can be used to verify the > behaviour associated with the second bug by using the left and right mouse > buttons to set a non-zero/zero scroll range on mouse-down/mouse-up. The left > mouse button affects SB_HORZ and the right affects SB_VERT. Thanks Troy for fixing a breakage I introduced with my recent patch. This patch certainly can be applied, after that I'll send a more comprehensive test suite and a few more fixes I have in my tree. -- Dmitry.

1 0

WINE regression
by Christian Costa July 7, 2004

July 7, 2004

Hi Alexandre, I've just update my tree and now I'm experiencing problems about: - screen no more updated in a game - X protocol error when moving a window for 3 other games It seems the patch that causes the regression is http://cvs.winehq.org/patch.py?id=12703 Could you look at it? I can provide some logs or other info if you want... Thanks in advance Christian

2 3

Pending patches
by Ge van Geldorp July 7, 2004

July 7, 2004

Last week I submitted the following patches: http://www.winehq.org/hypermail/wine-patches/2004/06/0227.html (dlls/commdlg "old style" file dialogs - take 2) and http://www.winehq.org/hypermail/wine-patches/2004/06/0276.html (dlls/shell32 RestartDialog and RestartDialogEx) Is there any particular reason they haven't been accepted yet? Gé van Geldorp.

1 0

RE: WM_NEXTDLGCTL changes the default button ID and does not res t ore default control identifier
by Krishna Murthy July 7, 2004

July 7, 2004

Alexandre, Please find attached conformance test. Thanks, krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Friday, June 25, 2004 12:34 PM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: FW: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Alexandre, > Is these changes looks good? Do I have to submit this patch to > 'wine-patches(a)winehq.org' ? Well, I'm not really happy with it, that whole bSetDefID thing is fairly ugly IMO. I'd really appreciate if you could write a regression test that illustrates the behavior of both DM_SETDEFID and WM_NEXTDLGCTL so that the code can be restructured in a more readable way. -- Alexandre Julliard julliard(a)winehq.org

1 0

HANDLE support code
by Michael Jung July 7, 2004

July 7, 2004

Hello, is there any kind of support code to implement HANDLE tables in the wine source tree? I'm thinking of something like the code server/handle.c, but for use in dll implementations. I would think that most dll implementations need something like this. Thanks, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

1 0

Wine and PATH
by Raghavan Gurumurthy July 6, 2004

July 6, 2004

BlankI have set this in the Wine config file (~/.wine/config): [wine] "Path"="c:\\windows;c:\\windows\system;c:\myapp" I have placed the executable (and its dependent DLLs) in c:\myapp directory. Now, if i run this command: # wine myapp.exe <<<--- I get error: "wine: cannot find myapp.exe". But, if i do: # wine c:\\myapp\\myapp.exe <<--- Everything is fine. Is Wine looking in the PATH variable i set in the config file or not? I did a wineboot as well as a reboot of the machine and still no luck. What am i missing? Note that if i copy myapp.exe to c:\\windows directory, Wine does let me run it without specifying the full path - but, i don't want to do that for obvious reasons. Is this supported or not? Thanks, Raghavan Gurumurthy Gupta Technologies

2 1

uxtheme metatheme
by Olaf Leidinger July 6, 2004

July 6, 2004

Hello! I'm new to the list and I'd like to know how complete the Windows-XP theme support is. I don't know anything about XP themes or win32-api programming in general but I wondered if it would be possible to create a "metatheme - plugin" for wine. Metatheme [1] is a new project which aim is to unify the appearance between different graphics toolkits. Although it's a new project it's quiet stable. I talked already to the author but he isn't sure if all MetaTheme requirements can be satisfied. The problem should be the metrics and so on. This should only be a suggestion for a TODO-item or a proposal as I can't write such a theme - at least not at the moment ;-( [1] http://jezek2.advel.cz/projects/metatheme/ Thanks a lot, Ciao, Olaf

2 1

Survey: "Motivation of Free/Open Source Software (F/OSS) Developers"
by Marc Röttig July 6, 2004

July 6, 2004

Survey: "Motivation of Free/Open Source Software (F/OSS) Developers" We (Marc Röttig and Carl-Daniel Hailfinger) are currently working on a survey on the motivation of open source developers as part of a "Computer Science and Society" project at the CS department of the University of Tübingen. We invite every developer in the Free / Open Source Software community to help us with our survey by filling out a little web form to give us some hints on possible motivation-motifs of F/OSS-developers. You can find the survey-form at http://foss.ta-altensteig.de/ Privacy statement: We do not want to collect personal information about you without your agreement. That's why we do not ask for your name and give you the ability to leave personal information unspecified (age and profession). We (the authors) will not make the raw survey data available to anyone except members of our faculty for verification of proper scientific procedures in extracting the results. Thank you in advance for your support. You can reach our CS faculty at http://www.informatik.uni-tuebingen.de/

1 0

Re: [Wine]Run-time error '-2147221168 (80040150) Automation error
by Satish A. Lele July 6, 2004

July 6, 2004

Hello, When I run the following command: #wine Birthday\ Remainder.exe I get the following command line output: fixme:ole:CoRegisterMessageFilter stub fixme:ole:OleLoadPictureEx (0x4147e464,32981,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x4072fb00), partially implemented. fixme:ole:OleLoadPictureEx (0x4147e464,774,0,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x4072fb00), partially implemented. fixme:ole:OleLoadPictureEx (0x4147e464,1086,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x4072fb00), partially implemented. fixme:ole:OleLoadPictureEx (0x4147e464,3646,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x4072fad0), partially implemented. fixme:ole:OLEPictureImpl_get_hPal (0x4023b070)->(0x4072fa7c): stub fixme:ole:OLEPictureImpl_get_hPal (0x4022c320)->(0x4072fa44): stub fixme:ole:OLEPictureImpl_SaveAsFile (0x402344b8)->(0x4023ddb0, 0, (nil)), hacked stub. I get the following error: Run-time error'-2147221168(80040150):- Automation error Please suggest the solution. Thanks, Satish. On Mon, 2004-07-05 at 14:29, Fabian Cenedese wrote: > >I have installed Visual Basic based Birthday Reminder application on > >Windows 2000 professional. Birthday application is shared. > > > >I am using Red Hat Linux 9 as a client. When I map i.e. mount Windows > >2000 server directory on Red Hat Linux 9 client machine and run Birthday > >remainder.exe file (i.e. wine Birthday\ Remainder.exe )using > >wine-20040615-1rh9winehq.i386.rpm, I get the following error: > > > >Run-time error '-2147221168 (80040150) Automation error' > > Do you get any messages on the command line, like errors, fixmes > or such? If yes, post the complete output to the wine-devel list. There > aren't that many users on the wine-users list. > > bye Fabi > > > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users >

2 2

MSI in Wine
by Gearoid Donnellan July 5, 2004

July 5, 2004

Hey again, I am very shocked that this actually works and you probably know already but If you down load and extract the Windows Installer redistributable in the wine directory you can then install MSI's using "wine msiexec /i <msiname>". Tried it with winzip.msi and it worked perfectly. Don't know if that will hold through with others though

2 1