July 2004 - Wine-Devel - list.winehq.org

Re: PrintDlg collate question
by J. Wesley Cleveland July 17, 2004

July 17, 2004

Hi, With this patch, the behavior of the Copies section of the print dialog box is correct. The new behavior is: If number of copies is 1, collate option is unchecked and shaded because collate is not possible, and collate icon is removed whether it was set to collate or not collate. else if number of copies > 2, collate option is unchecked but not shaded, and no_collate icon is displayed. There is only one change that im not sure should go in or not, and that is when the collate option is checked and we drop the number of copies to one, should we uncheck the collate option as well as shade it? On my windows 2000 box, the collate option comes up checked and grayed as default, and the collate icon does not change as the number of copies is changed. The collate checkbox is grayed and ungrayed as the number of copies changes to and from 1, but the checked status remains whatever I set it to.

1 0

Re: fix collate icon behavior in printdlg
by Robert Shearman July 16, 2004

July 16, 2004

James Hawkins wrote: >Hi, > > With this patch, the behavior of the Copies section of the print >dialog box is correct. The new behavior is: > >If number of copies is 1, > collate option is unchecked and shaded because collate is not possible, and > collate icon is removed whether it was set to collate or not collate. >else if number of copies > 2, > collate option is unchecked but not shaded, and > no_collate icon is displayed. > >There is only one change that im not sure should go in or not, and >that is when the collate option is checked and we drop the number of >copies to one, should we uncheck the collate option as well as shade >it? > > It is a nice touch that shows the user that the option doesn't mean anything in that state. However, if the user decreases the copies to 1 and then increases up to 2 their setting has been lost. Also, the dialog doesn't look right when in its default state of only 1 copy. There is a large gap where the collate image would have been. It would be nice if we could put another image there of say, only one sheet of paper, showing why the collate option is disabled. Rob

1 0

PrintDlg collate question
by James Hawkins July 16, 2004

July 16, 2004

Hi, With this patch, the behavior of the Copies section of the print dialog box is correct. The new behavior is: If number of copies is 1, collate option is unchecked and shaded because collate is not possible, and collate icon is removed whether it was set to collate or not collate. else if number of copies > 2, collate option is unchecked but not shaded, and no_collate icon is displayed. There is only one change that im not sure should go in or not, and that is when the collate option is checked and we drop the number of copies to one, should we uncheck the collate option as well as shade it? -- James Hawkins

1 0

Debugger bugs
by Mike Hearn July 16, 2004

July 16, 2004

Hi guys, I've got a few problems with various debuggers. Can anybody help? 1) gdb doesn't seem to catch signals to sent to Wine. In a crash, winedbg is invoked without gdb ever being aware of it. 2) winedbg can't locate files anymore, the paths seem to be stripped: 0x401cdb48 fixup_imports [loader.c:509] in ntdll: movl 0x0(%eax),%edx Unable to open file loader.c Wine-dbg>list Wine-dbg> 3) winedbg won't print the values of local variables: Wine-dbg>print i fixme:dbghelp:SymGetTypeInfo Someone didn't properly set ModBase (0x4078ebfc) fixme:winedbg:print_value ---error thanks -mike

2 3

DefPushButton management patch
by Katia Maculan July 16, 2004

July 16, 2004

I found and fixed 2 problems in DEAFULTPUSHBUTTON management: 1) In function DIALOG_CreateControls32 if a default push button exists the dlgInfo->idResult is set with the DefPushButtonId. If I change the focus to other controls of the dialog with the TAB key, each time I change the focus the function DEFDLG_SetDefButton is called (and that is correct) and the dlgInfo->idResult is set with the new control id also if it is NOT a button (i.e. "edit control"). As a result, pressing the 'Enter'key, nothing happens. I reviewed the code and changed the following: 1. added a member in the DIALOGINFO structure (int OriDefButID) where the original default button ID is stored. 2. modified the DEFDG_SetDefButton function (windows/defdlg.c). 2) Pressing the Enter key in a Dialog without a default push-button, a wrong button ID is returned (always '1'). I modifiied the code (DIALOG_CreateControls32 function in ./windows/dialog.c), so that at least an existing button-ID is stored as a default. NB: I can't use CVS (for a login problem) -- Katia Maculan Developer ISIS Papyrus Italy Srl Tel: (+39) 0125 6455400 Fax: (+39) 0125 6455150 E-mail: katia.maculan(a)isis-papyrus.com Info: info(a)isis-papyrus.com Hotline: +43-2236-27551-111 Visit our Website: http://www.isis-papyrus.com diff -urN oldwinedir/dlls/user/controls.h newwinedir/dlls/user/controls.h --- oldwinedir/dlls/user/controls.h 2004-03-04 02:41:11.000000000 +0100 +++ newwinedir/dlls/user/controls.h 2004-07-15 14:05:44.000000000 +0200 @@ -126,6 +126,7 @@ INT idResult; /* EndDialog() result / default pushbutton ID */ UINT flags; /* EndDialog() called for this dialog */ HGLOBAL16 hDialogHeap; + INT OriDefButID; /* the original DEFPUSHBUTTON */ } DIALOGINFO; #define DF_END 0x0001 diff -urN oldwinedir/windows/defdlg.c newwinedir/windows/defdlg.c --- oldwinedir/windows/defdlg.c 2004-04-20 06:02:35.000000000 +0200 +++ newwinedir/windows/defdlg.c 2004-07-15 14:07:12.000000000 +0200 @@ -135,13 +135,27 @@ { DWORD dlgcode=0; /* initialize just to avoid a warning */ HWND hwndNew = GetDlgItem(hwndDlg, wParam); - - dlgInfo->idResult = wParam; + //more tests are necessary before save that id like a defpushbutton dlgInfo->idResult = wParam; if (hwndNew && !((dlgcode=SendMessageW(hwndNew, WM_GETDLGCODE, 0, 0 )) & (DLGC_UNDEFPUSHBUTTON | DLGC_BUTTON))) + { + //if destination is not a push button the original def push button is set like default + if (dlgInfo->idResult) + { + HWND hwndOld = GetDlgItem( hwndDlg, dlgInfo->idResult ); + if (hwndOld && (SendMessageA( hwndOld, WM_GETDLGCODE, 0, 0) & DLGC_DEFPUSHBUTTON)) + SendMessageA( hwndOld, BM_SETSTYLE, BS_PUSHBUTTON, TRUE ); + } + dlgInfo->idResult = dlgInfo->OriDefButID; + hwndNew = GetDlgItem (hwndDlg, dlgInfo->OriDefButID); + if (hwndNew) + SendMessageA( hwndNew, BM_SETSTYLE, BS_DEFPUSHBUTTON, TRUE ); return FALSE; /* Destination is not a push button */ + } + if (dlgInfo->idResult == wParam) //if new defbutton is the actual nothing change + return TRUE; if (dlgInfo->idResult) /* There's already a default pushbutton */ { HWND hwndOld = GetDlgItem( hwndDlg, dlgInfo->idResult ); @@ -150,8 +164,11 @@ } if (hwndNew) { - if(dlgcode==DLGC_UNDEFPUSHBUTTON) + if(dlgcode & DLGC_UNDEFPUSHBUTTON) //it is DLGC_UNDEFBUTTON && DLGC_BUTTON + { SendMessageA( hwndNew, BM_SETSTYLE, BS_DEFPUSHBUTTON, TRUE ); + dlgInfo->idResult = wParam; // now is correct to save the new def push button + } } return TRUE; } diff -urN oldwinedir/windows/dialog.c newwinedir/windows/dialog.c --- oldwinedir/windows/dialog.c 2004-05-18 22:45:22.000000000 +0200 +++ newwinedir/windows/dialog.c 2004-07-15 14:07:05.000000000 +0200 @@ -292,6 +292,7 @@ DLG_CONTROL_INFO info; HWND hwndCtrl, hwndDefButton = 0; INT items = dlgTemplate->nbItems; + DWORD dlgcode=0; //to have the control information TRACE(" BEGIN\n" ); while (items--) @@ -353,7 +354,8 @@ /* Send initialisation messages to the control */ if (dlgInfo->hUserFont) SendMessageA( hwndCtrl, WM_SETFONT, (WPARAM)dlgInfo->hUserFont, 0 ); - if (SendMessageA(hwndCtrl, WM_GETDLGCODE, 0, 0) & DLGC_DEFPUSHBUTTON) + dlgcode = SendMessageA(hwndCtrl, WM_GETDLGCODE, 0, 0); //save the result for future test + if (dlgcode & DLGC_DEFPUSHBUTTON) { /* If there's already a default push-button, set it back */ /* to normal and use this one instead. */ @@ -361,7 +363,21 @@ SendMessageA( hwndDefButton, BM_SETSTYLE, BS_PUSHBUTTON, FALSE ); hwndDefButton = hwndCtrl; dlgInfo->idResult = GetWindowLongA( hwndCtrl, GWL_ID ); + dlgInfo->OriDefButID = dlgInfo->idResult; //save the ID like the original DEFPUSHBUTTON } + else + { + // if no defpushbutton is found and the control is a normal pushbutton + // this button is set like defpushbutton + if ((dlgInfo->idResult == 0) && (dlgcode & DLGC_UNDEFPUSHBUTTON)) + { + hwndDefButton = hwndCtrl; + dlgInfo->idResult = GetWindowLongA( hwndCtrl, GWL_ID ); + dlgInfo->OriDefButID = dlgInfo->idResult; + SendMessageA( hwndDefButton, BM_SETSTYLE, BS_DEFPUSHBUTTON, FALSE ); + } + + } } TRACE(" END\n" ); return TRUE;

2 2

printdlg question
by truiken＠gmail.com July 16, 2004

July 16, 2004

Hi, In the PRINTDLG_WMInitDialog() and PRINTDLG_SetUpPrinterListCombo() functions, what purpose does the 'name' variable server? I know it's the name of the current printer, but what role does it play in setting up the printer list combo? dlls/commdlg/printdlg.c Thanks, James Hawkins

1 0

Re: wine-pthread use the TEB register on PowerPC
by Alexandre Julliard July 16, 2004

July 16, 2004

"Pierre d'Herbemont" <pidherbemont(a)opendarwin.org> writes: > This patch enables the use of wine-pthread on darwin, and more > generally on PowerPC hosts. > > Pierre. > > ChangeLog: > Use the TEB register on PowerPC hosts. The intent is that wine-pthread should use only portable pthread functions. Why do you need the TEB register to be setup when using wine-pthread? -- Alexandre Julliard julliard(a)winehq.org

1 0

wrong test results on test.winehq.org
by Stefan Leichter July 15, 2004

July 15, 2004

Hello, is it right that the test result in the directory 200407111000 are build from cvs of the 11th July 2004? If no please delete the mail now ;-) Otherwise please take a look to the failing kernel:profile tests results of e.g win98 (http://test.winehq.org/data/200407111000/98se_JosephBooker/kernel32:profile…) you will see lines like profile.c:82: Test failed: test<01>: ret<0000000000> exp<4294967295> but if you check the source code of the tests (http://cvs.winehq.org/cvsweb/wine/dlls/kernel/tests/profile.c?rev=1.5&conte…) you will find that a second number must be displayed at the end of the line ok((res == profileInt[i].result) || (res == profileInt[i].result9x), "test<%02d>: ret<%010u> exp<%010u><%010u>\n", ^^^^^ here i, res, profileInt[i].result, profileInt[i].result9x); So either the test binary used old source files or the results are sorted into a wrong "wine version". Can please someone have a look Thanks Stefan

2 1

Re: Prevent heap corruption in CryptAcquireContext
by Alexandre Julliard July 15, 2004

July 15, 2004

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > this is a resubmit of a simple patch I've sent yesterday, but which was not > applied to cvs. I would like to give some detail on it: There is a section of > code labeled "error:" at the end of CryptAcquireContext, which releases > occupied resources in the case of an error. Amongst others, the allocated > memory pointed to by "keyname" is released. However, in some cases keyname is > released twice, once in the normal code and once in the error cleanup code. > CRYPT_Free uses LocalFree, which returns "NULL" if the memory was > successfully released. And it does basically nothing if it is called with a > "NULL" pointer. This means that by executing "keyname = > (PSTR)CRYPT_Free(keyname)" the second call to CRYPT_Free does basically > nothing, which is better than corrupting the heap ;) The patch is OK, but it would be better to really avoid calling CRYPT_Free twice, and also to fix all the other places in that function that have the same problem. -- Alexandre Julliard julliard(a)winehq.org

2 1

FMOD audio engine fails to initialize DirectMusic
by Saulius Krasuckas July 15, 2004

July 15, 2004

I discovered it by running one simple game [1]: [s2(a)katleriai Tetris]$ wine Tetris.exe err:wave:OSS_RawOpenDevice ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed (Input/output error) fixme:dsound:IDirectSoundImpl_SetCooperativeLevel level=DSSCL_PRIORITY not fully supported fixme:dmime:IDirectMusicPerformance8Impl_Init (iface = 0x402a0748, dmusic = 0x100506e4, dsound = 0x4026c288, hwnd = (nil)) err:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_SetObject : couldn't parse descriptor MessageBox the pops up and says: "Data files missing or corrupt. Please reinstall." Querying the "dmloader" debug channel gives: [s2(a)katleriai Tetris]$ WINEDEBUG=+dmloader wine Tetris.exe err:wave:OSS_RawOpenDevice ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed (Input/output error) fixme:dsound:IDirectSoundImpl_SetCooperativeLevel level=DSSCL_PRIORITY not fully supported fixme:dmime:IDirectMusicPerformance8Impl_Init (iface = 0x40260600, dmusic = 0x100506e4, dsound = 0x4026c298, hwnd = (nil)) trace:dmloader:DMLOADER_DllGetClassObject (CLSID_DirectMusicLoader, IID_IClassFactory, 0x4074f39c) trace:dmloader:DMUSIC_CreateDirectMusicLoaderCF (IID_IClassFactory, 0x4074f39c, (nil)) trace:dmloader:IDirectMusicLoaderCF_QueryInterface (0x40260918, IID_IClassFactory, 0x4074f39c) trace:dmloader:IDirectMusicLoaderCF_AddRef (0x40260918): AddRef from 0 trace:dmloader:IDirectMusicLoaderCF_CreateInstance (0x40260918, (nil), IID_IDirectMusicLoader, 0x100506f0) trace:dmloader:DMUSIC_CreateDirectMusicLoaderImpl (IID_IDirectMusicLoader, 0x100506f0, (nil)) trace:dmloader:DMUSIC_InitLoaderSettings : (0x40260938) trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_SetObject (0x40260938, 0x4074f008): pDesc: DMUS_OBJECTDESC (0x4074f008): - dwSize = 0x00000350 - dwValidData = 0x00000033 ( DMUS_OBJ_OBJECT DMUS_OBJ_CLASS DMUS_OBJ_FILENAME DMUS_OBJ_FULLPATH ) - guidClass = CLSID_DirectMusicCollection - guidObject = {f17e8673-c3b4-11d1-870b-00600893b1bd} - wszFileName = L"c:\\windows\\system\\drivers\\gm.dls" trace:dmloader:DMUSIC_CreateDirectMusicLoaderFileStream (0x4074e868) trace:dmloader:IDirectMusicLoaderFileStream_IStream_QueryInterface (0x40262250, IID_IStream, 0x4074e868) trace:dmloader:IDirectMusicLoaderFileStream_IStream_AddRef (0x40262250): AddRef from 0 trace:dmloader:IDirectMusicLoaderFileStream_Attach (0x40262250, L"c:\\windows\\system\\drivers\\gm.dls", 0x40260938) trace:dmloader:IDirectMusicLoaderFileStream_Detach (0x40262250) warn:dmloader:IDirectMusicLoaderFileStream_Attach : failed err:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_SetObject : couldn't parse descriptor trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_QueryInterface (0x40260938, IID_IDirectMusicLoader, 0x100506f0) trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_AddRef (0x40260938): AddRef from 0 trace:dmloader:IDirectMusicLoaderCF_Release (0x40260918): ReleaseRef to 0 trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_EnableCache (0x40260938, CLSID_DirectMusicSegment, 0) trace:dmloader:DMUSIC_GetLoaderSettings : (0x40260938, CLSID_DirectMusicSegment, (nil), 0x4074f3a4) trace:dmloader:DMUSIC_SetLoaderSettings : (0x40260938, CLSID_DirectMusicSegment, (nil), 0x4074f3c4) I think FMOD tries to open the "General MIDI collection of DLS instruments" called GM.DLS and fails to do so as Wine doesn't have it. Any ideas on the legal way to install it onto the Wine system? MS states [2] some stuff regarding GM.DLS collection: > You can use this collection with any DirectMusic Producer piece, and it > is available on all DirectMusic playback systems. > > The default GM.dls collection is available to all projects at all times, > and you should not add it to the project tree. > > The sounds in this DLS collection consist of the GM/GS Sound Set that > are licensed from Roland Corporation and are the same as those used for > Roland's Sound Canvas family of music synthesizers. > > Important > For more information about legal issues related to using the GM.dls., > click the copyright link at the bottom of this page. Does anyone knows or can explain the license MS mentions here? Am i allowed to copy the file from any web page or another place? Or another point: would it be sane to expect the Wine devs to implement simplified/different version of this collection in the future? TIA. [1] http://gamedev.kobra.ktu.lt/Downloads/TetrisMav/Tetris.zip [2] http://msdn.microsoft.com/library/shared/deeptree/asp/rightframe.asp?dtcfg=…

5 8