July 2004 - Wine-Devel - list.winehq.org

Re: Re: D3D8_GetCreationParameters fix
by Christian Costa July 9, 2004

July 9, 2004

> Message du 09/07/04 00:57 > De : "Andrei Barbu" > A : "Christian Costa" > Copie à : "Marcus Meissner" , "Mike McCormack" , wine-devel(a)winehq.org > Objet : Re: D3D8_GetCreationParameters fix > Having given thought to the issue, you're right. > That was a bad solution, sorry. > > It should have failed with D3DERR_INVALIDCALL if it's a bad write > pointer. > Is this new patch ok? > Seems good. :-) Bye, Christian

1 0

Re: D3D8_GetCreationParameters fix
by Mike McCormack July 9, 2004

July 9, 2004

You probably want to use a Windows method to allocate memory here, such as HeapAlloc() or CoTaskMemAlloc, as the caller is not going to use free() to free the memory... Mike Andrei Barbu wrote: > Changelog: > > Fixes a memory access fault inside of D3D8_GetCreationParameters. ... > HRESULT WINAPI IDirect3DDevice8Impl_GetCreationParameters(LPDIRECT3DDEVICE8 iface, D3DDEVICE_CREATION_PARAMETERS *pParameters) { > ICOM_THIS(IDirect3DDevice8Impl,iface); > TRACE("(%p) copying to %p\n", This, pParameters); > + > + pParameters = (D3DDEVICE_CREATION_PARAMETERS*) malloc( sizeof( D3DDEVICE_CREATION_PARAMETERS )); > memcpy(pParameters, &This->CreateParms, sizeof(D3DDEVICE_CREATION_PARAMETERS)); > return D3D_OK; > }

6 8

Initial creation of directory and config with ttydrv
by Shachar Shemesh July 8, 2004

July 8, 2004

Hi all, I need to create the initial environment for wine (the .wine directory) in an environment where no X11 server is available. Once the directory is up (for example, if I copy it from somewhere), there is no problem to add a config file that chooses the ttydrv driver. However, I cannot create the initial directory. Is there any solution to this problem, or should I just copy the initial config from somewhere? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

HKEY_DYN_DATA in win9x
by Robert Reif July 8, 2004

July 8, 2004

I have a program that fails when it can't find HKEY_DYN_DATA\Config Manager\Enum in the registry. Any pointers on where to start?

2 3

Re: Cleanup A->W calls:
by Dmitry Timoshkov July 8, 2004

July 8, 2004

truiken(a)gmail.com wrote: > @@ -362,6 +363,24 @@ > */ > BOOL WINAPI Shell_NotifyIconA(DWORD dwMessage, PNOTIFYICONDATAA pnid ) > { > + BOOL ret; > + > + PNOTIFYICONDATAW p = HeapAlloc(GetProcessHeap(),0,sizeof(NOTIFYICONDATAW)); > + memcpy(p, pnid, sizeof(NOTIFYICONDATAW)); > + MultiByteToWideChar( CP_ACP, 0, pnid->szTip, -1, p->szTip, sizeof(p->szTip) ); MultiByteToWideChar takes number of wide characters, not bytes for the target buffer. > + p->szTip[sizeof(p->szTip)-1] = 0; Since p->szTip is a unicode buffer you have to divide sizeof(p->szTip) by sizeof(p->szTip[0]) here. -- Dmitry.

1 0

Re: Fix two bugs in SetScrollRange
by Dmitry Timoshkov July 8, 2004

July 8, 2004

"Troy Rollo" <wine(a)troy.rollo.name> wrote: > This fixes two bugs in SetScrollRange: > > 1. Setting the scroll range with the "bRedraw" flag set to true on a > non-control scrollbar results in the scrollbar being drawn over the whole > window area. > > 2. If you don't set WS_HSCROLL/WS_VSCROLL on window creation, setting a scroll > range does nothing. Setting the scroll range to a non-zero range should cause > scroll bars to be displayed (and the appropriate flag to be set in the window > styles). Setting the range to a zero range should cause the relevant scroll > bar to be hidden (and the flag to be removed from the window styles). > > The second attachment is a test program that can be used to verify the > behaviour associated with the second bug by using the left and right mouse > buttons to set a non-zero/zero scroll range on mouse-down/mouse-up. The left > mouse button affects SB_HORZ and the right affects SB_VERT. Thanks Troy for fixing a breakage I introduced with my recent patch. This patch certainly can be applied, after that I'll send a more comprehensive test suite and a few more fixes I have in my tree. -- Dmitry.

1 0

WINE regression
by Christian Costa July 7, 2004

July 7, 2004

Hi Alexandre, I've just update my tree and now I'm experiencing problems about: - screen no more updated in a game - X protocol error when moving a window for 3 other games It seems the patch that causes the regression is http://cvs.winehq.org/patch.py?id=12703 Could you look at it? I can provide some logs or other info if you want... Thanks in advance Christian

2 3

Pending patches
by Ge van Geldorp July 7, 2004

July 7, 2004

Last week I submitted the following patches: http://www.winehq.org/hypermail/wine-patches/2004/06/0227.html (dlls/commdlg "old style" file dialogs - take 2) and http://www.winehq.org/hypermail/wine-patches/2004/06/0276.html (dlls/shell32 RestartDialog and RestartDialogEx) Is there any particular reason they haven't been accepted yet? Gé van Geldorp.

1 0

RE: WM_NEXTDLGCTL changes the default button ID and does not res t ore default control identifier
by Krishna Murthy July 7, 2004

July 7, 2004

Alexandre, Please find attached conformance test. Thanks, krishna -----Original Message----- From: Alexandre Julliard [mailto:julliard(a)winehq.org] Sent: Friday, June 25, 2004 12:34 PM To: Krishna Murthy Cc: wine-devel(a)winehq.org Subject: Re: FW: FW: WM_NEXTDLGCTL changes the default button ID and does not rest ore default control identifier Krishna Murthy <Krishna.Murthy(a)guptaworldwide.com> writes: > Alexandre, > Is these changes looks good? Do I have to submit this patch to > 'wine-patches(a)winehq.org' ? Well, I'm not really happy with it, that whole bSetDefID thing is fairly ugly IMO. I'd really appreciate if you could write a regression test that illustrates the behavior of both DM_SETDEFID and WM_NEXTDLGCTL so that the code can be restructured in a more readable way. -- Alexandre Julliard julliard(a)winehq.org

1 0

HANDLE support code
by Michael Jung July 7, 2004

July 7, 2004

Hello, is there any kind of support code to implement HANDLE tables in the wine source tree? I'm thinking of something like the code server/handle.c, but for use in dll implementations. I would think that most dll implementations need something like this. Thanks, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

1 0