July 2004 - Wine-Devel - list.winehq.org

Re: COM RPC: Fix Infinite Loop
by Robert Shearman July 28, 2004

July 28, 2004

Robert Shearman wrote: > Changelog: > Fix for infinite loop that could occur if _invoke_onereq failed. Please don't apply this patch. I'll submit a better and more complete one in a minute. Rob

1 0

Non-working patch for 3GB of memory allocation
by Shachar Shemesh July 28, 2004

July 28, 2004

Ok, this patch would probably not be appropriate even if it did work. The surprising thing, however, is that it doesn't. The idea was simple. We use mmap as usual until mmap starts to fail with no memory. When that happens, we switch to allocating memory with malloc, which allegably knows how to use "brk" in order to allocate memory from the lower 1GB area. The patch is against 20040716. The attached program tries to repeatedly allocate ~100MB, until it fails. It is compiled for advanced server (i.e. - it has 3GB of address space, but that's besides the point). When actually run (through strace), one can see the mmaps being carried out and successful, and then the mmap that fails (no memory). Then malloc is attempted, which tries mmap, then brk, and then mmap again. All fail. This is the point where I stop understanding. Does anyone have any explanation as to why malloc fails? Does wine prevent large scale use of the lower area due to some reason? Any ideas would be appreciated. Shachar ? runconfig ? dlls/ntdll/.virtual.c.swp Index: dlls/ntdll/virtual.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/virtual.c,v retrieving revision 1.37 diff -u -r1.37 virtual.c --- dlls/ntdll/virtual.c 22 Jun 2004 03:02:35 -0000 1.37 +++ dlls/ntdll/virtual.c 26 Jul 2004 13:53:41 -0000 @@ -78,6 +78,7 @@ /* Per-view flags */ #define VFLAG_SYSTEM 0x01 /* system view (underlying mmap not under our control) */ #define VFLAG_VALLOC 0x02 /* allocated by VirtualAlloc */ +#define VFLAG_MALLOC 0x04 /* allocated using malloc */ /* Conversion from VPROT_* to Win32 flags */ static const BYTE VIRTUAL_Win32Flags[16] = @@ -168,9 +169,13 @@ DPRINTF( "View: %p - %p", addr, addr + view->size - 1 ); if (view->flags & VFLAG_SYSTEM) DPRINTF( " (system)\n" ); - else if (view->flags & VFLAG_VALLOC) - DPRINTF( " (valloc)\n" ); - else if (view->mapping) + else if (view->flags & VFLAG_VALLOC) { + DPRINTF( " (valloc" ); + if (view->flags & VFLAG_MALLOC) + DPRINTF( " using malloc)\n" ); + else + DPRINTF( ")\n" ); + } else if (view->mapping) DPRINTF( " %p\n", view->mapping ); else DPRINTF( " (anonymous)\n"); @@ -348,7 +353,12 @@ */ static void delete_view( struct file_view *view ) /* [in] View */ { - if (!(view->flags & VFLAG_SYSTEM)) unmap_area( view->base, view->size ); + if (!(view->flags & VFLAG_SYSTEM)) { + if( !(view->flags & VFLAG_MALLOC) ) + unmap_area( view->base, view->size ); + else + free( view->base ); + } list_remove( &view->entry ); if (view->mapping) NtClose( view->mapping ); free( view ); @@ -559,6 +569,7 @@ { void *ptr; NTSTATUS status; + int used_malloc=0; if (base) { @@ -602,7 +613,19 @@ { if ((ptr = wine_anon_mmap( NULL, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) { - if (errno == ENOMEM) return STATUS_NO_MEMORY; + if (errno == ENOMEM) + { + /* mmap allocation failed. Let's see if we can try malloc, and whether it is going to be more lucky */ + FIXME("About to try malloc\n"); + if( /* Unix protection is not malloc compatible, or */ (ptr = malloc( size ))!=NULL ) + { + used_malloc=1; + goto memory_allocated; + } else { + FIXME("malloc failed\n"); + return STATUS_NO_MEMORY; + } + } return STATUS_INVALID_PARAMETER; } /* if we got something beyond the user limit, unmap it and retry */ @@ -623,8 +646,17 @@ munmap( (char *)ptr + size, view_size - size ); } +memory_allocated: status = create_view( view_ret, ptr, size, vprot ); - if (status != STATUS_SUCCESS) unmap_area( ptr, size ); + if( used_malloc && status==STATUS_SUCCESS ) + (*view_ret)->flags|=VFLAG_MALLOC; + else if (status != STATUS_SUCCESS) + { + if( !used_malloc ) + unmap_area( ptr, size ); + else + free( ptr ); + } return status; }

2 6

delayed unloading of .so in WINE
by Santosh Siddheshwar July 28, 2004

July 28, 2004

Hi, Is there any way to specify in config file or any other place, a way to prevent/delay a shared object from being unloaded till the application using it terminates? In dlopen there is a flag RTLD_NODELETE which keeps the loaded shared object in memory even after dlclose is called. The shared object is unloaded only when the app exits. Do we have some way to do this in WINE? Or does any feature in Windows necessitate implementing this kind of behaviour in WINE? I can think of VC++ linker flags /DELAYLOAD and /DELAY:unload which might need the use of such mechanism. Regards Santosh Siddheshwar ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

generation date/version of the (online) wine documentation
by Jeroen Janssen July 28, 2004

July 28, 2004

Hi, I have a few questions: * is it possible to add the date/version in the online wine documentation at http://www.winehq.com/site/documentation (for the user, devel docs) * when exactly are these pages generated? (nightly/daily/?) best regards, Jeroen

2 1

handling IUnknown/IRemUnknown for (outproc) objects
by Jeroen Janssen July 28, 2004

July 28, 2004

Hello, After last weeks discussion on the "unhandled interface" message in CFProxy_QueryInterface I was getting, we concluded (if I'm correct) that this is part of the "IRemUnknown" handling that is not (yet) implemented correctly in the wine CVS tree. I'm trying to figure out exactly where in the (OLE) code, this should be handled. If someone could point me in the right direction I would appreciate it very much. I think it would also be helpfull if there was some "fixme" logging so other people can also see if they hit upon the same problem (since it took a while to finally figure out the problem). --- Jeroen

3 3

Re: change the nt service pack version from 6 to 6a, correct win2k3 name
by Ivan Leo Puoti July 28, 2004

July 28, 2004

I've found this hex value in user32.dll 5e07c is this good or bad? Ivan.

1 0

Re: DCOM: Document wrong behaviour for IRunningObjectTable
by Robert Shearman July 28, 2004

July 28, 2004

Robert Shearman wrote: > Changelog: > Document wrong behaviour for IRunningObjectTable. Sorry, the changelog for this patch should have been as follows: Mike Hearn <mh(a)codeweavers.com> Robert Shearman <rob(a)codeweavers.com> Document wrong behaviour for IRunningObjectTable.

1 0

Re: change the nt service pack version from 6 to 6a, correct win2k3 name
by Andreas Mohr July 28, 2004

July 28, 2004

Hi, On Wed, Jul 28, 2004 at 11:39:30AM +0200, Ivan Leo Puoti wrote: > I'm not 100% sure this patch is correct, please let me know if it isn't. > BTW at line 342 of dlls/ntdll/version.c I read /* FIXME: Not sure, should be > verified with a Win2K3 dll */ > how can this be verified? Easy, take several W2K3 system DLLs and kick them through winedump (or pedump.exe) to verify whether their RtlImageNtHeader(hmod)->OptionalHeader.MajorOperatingSystemVersion value (i.e. their MajorOperatingSystemVersion value) is 7 like our Wine code assumes here. Otherwise you'll have to find out other characteristic DLL version number differences of these DLLs compared to WinXP to be able to properly return the WIN2K3 version for these AND ONLY these... Andreas Mohr

1 0

icons contribuition
by Marcio Esper July 28, 2004

July 28, 2004

Hello, My name is Marcio Esper. The Ivan tell me than I can send to you using this e-mail some icons. >We could do with some better icons, email wine-devel(a)winehq.com if you >want to contribute I made a new icon to be used with wine. 128x128, 64x64, 48x48, 32x32, 16x16. I hope you like it. The icons are made in Kpovmodeler on Mandrake linux 10 AMD64 and you can use and spread it without any restrition just geve me credits puting my name in the readmes and or were you think a good place to talk about it. ;p If we whant more models and sizes, let me know. Best regards, Marcio Esper

3 5

RelayExclude
by Diego 'Flameeyes' Pettenò July 28, 2004

July 28, 2004

Hi, I've a question about RelayExclude setting in [Debug] section of ~/.wine/config : I was trying to debug the load of ClrMamePro watching at the relay output, but there's a lot of call of ntdll.RtlEnterCriticalSection ntdll.RtlLeaveCriticalSection and so on. I already added them to RelayExclude last year when I debugged another app, but seems like now this setting is ignored. I also tried to add the complete ntdll.RtlEnterCriticalSection name, but nothing changed. Any suggestion? TIA, -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

4 3