January 2005 - Wine-Devel - list.winehq.org

Re: PSAPI: stub implementations (#3)
by Juan Lang Jan. 16, 2005

Jan. 16, 2005

Hi Hans, +BOOL WINAPI GetPerformanceInfo( PPERFORMANCE_INFORMATION info, DWORD size ) +{ + NTSTATUS status; + + TRACE( "(%p, %ld)\n", info, size ); + + status = NtQueryInformationProcess( GetCurrentProcess(), SystemPerformanceInformation, info, size, NULL ); + + if (status) + { + SetLastError( RtlNtStatusToDosError( status )); + return FALSE + } + return FALSE; Shouldn't this return TRUE on success? --Juan __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

Re: PSAPI: stub implementations (#2)
by Rob Shearman Jan. 15, 2005

Jan. 15, 2005

Hans Leidekker wrote: >Call SetLastError() on failure, as suggested by Juan Lang. > > -Hans > >Changelog: > Stub implementations for EnumPageFiles{A,W}, GetProcessImageFileName{A,W}. > Implement GetPerformanceInfo, GetProcessMemoryInfo on top of > NtQueryInformationProcess and GetWsChanges, QueryWorkingSet{,Ex} on top > of NtQueryVirtualMemory. > > >------------------------------------------------------------------------ > >@@ -443,15 +461,85 @@ > } > > /*********************************************************************** >+ * GetPerformanceInfo (PSAPI.@) >+ */ >+BOOL WINAPI GetPerformanceInfo( PPERFORMANCE_INFORMATION info, DWORD size ) >+{ >+ NTSTATUS status; >+ >+ TRACE( "(%p, %ld)\n", info, size ); >+ >+ if (size < sizeof(PERFORMANCE_INFORMATION)) >+ { >+ SetLastError( ERROR_INSUFFICIENT_BUFFER ); >+ return FALSE; >+ } >+ > > This check is redundant. All NtQueryInformation* functions check the buffer size for you. >+ status = NtQueryInformationProcess( GetCurrentProcess(), SystemPerformanceInformation, info, size, NULL ); >+ >+ if (status) >+ { >+ SetLastError( RtlNtStatusToDosError( status )); >+ return FALSE >+ } >+ return FALSE; >+} > > >@@ -459,14 +547,25 @@ > /*********************************************************************** > * GetWsChanges (PSAPI.@) > */ >-BOOL WINAPI GetWsChanges(HANDLE hProcess, >- PPSAPI_WS_WATCH_INFORMATION lpWatchInfo, DWORD cb) >+BOOL WINAPI GetWsChanges( HANDLE process, PPSAPI_WS_WATCH_INFORMATION watchinfo, DWORD size ) > { >- FIXME("(hProcess=%p, %p, %ld): stub\n", >- hProcess, lpWatchInfo, cb); >+ NTSTATUS status; >+ >+ TRACE( "(%p, %p, %ld)\n", process, watchinfo, size ); >+ >+ if (size < sizeof(PSAPI_WS_WATCH_INFORMATION)) >+ { >+ SetLastError( ERROR_INSUFFICIENT_BUFFER ); >+ return FALSE; >+ } > > So is this. > >- memset(lpWatchInfo, 0, cb); >+ status = NtQueryVirtualMemory( process, NULL, ProcessWorkingSetWatch, watchinfo, size, NULL ); > >+ if (status) >+ { >+ SetLastError( RtlNtStatusToDosError( status )); >+ return FALSE >+ } > return TRUE; > } > > > Could you also make sure that the NtDll functions that you are calling give out a useful fixme message when called from these functions? At the moment you are mostly replacing some good fixme messages with bad fixme messages. Rob

1 0

Re: PSAPI: stub implementations
by Juan Lang Jan. 15, 2005

Jan. 15, 2005

Hi Hans, + status = NtQueryInformationProcess( GetCurrentProcess(), SystemPerformanceInformation, info, size, NULL ); + if (status != STATUS_SUCCESS) return FALSE; without a test case I don't know for sure, but it seems likely you should do the something like following on failure: if (status) { SetLastError( RtlNtStatusToDosError( status )); return FALSE; } You might take a look at how advapi32's security.c does it. --Juan __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: WineHQ:winetest: produce valid HTML
by Dimitrie O. Paun Jan. 15, 2005

Jan. 15, 2005

On Wed, Jan 12, 2005 at 05:29:18PM +0100, Ferenc Wagner wrote: > ChangeLog: * Generate valid HTML 4.01 Strict. > * Underline vis_note class links, too. Cool stuff Feri. Anyone knows what happened to the tests? The last one at http://test.winehq.org/data/ is 2004-12-28. Also, the last tests build at SF is winetest-200409111000 which is a bit outdated :) What gives? -- Dimi.

8 20

file associations in wine
by Rainer Haake Jan. 15, 2005

Jan. 15, 2005

hi there first of all, please excuse my poor english... I know I can associate a file extension in wine with a linux application like i did for .sxw in this .reg-file: REGEDIT4 [HKEY_CLASSES_ROOT\.sxw] @="sxw.document" [HKEY_CLASSES_ROOT\sxw.document] @="sxw.document" [HKEY_CLASSES_ROOT\sxw.document\shell] [HKEY_CLASSES_ROOT\sxw.document\shell\open] [HKEY_CLASSES_ROOT\sxw.document\shell\open\command] @="C:\\windows\\command\\start.exe kdestart.exe \"%1\"" where kdestart.exe is a link to the following script: #!/bin/bash i=`winepath -u "$*"` kfmclient exec "$i" so now sxw-files open in OpenOffice like I wanted. But now I would like to have a file association to each filetype unknown to wine, so that all these files will be openend with the corresponding KDE programs. I tried: [HKEY_CLASSES_ROOT\*] [HKEY_CLASSES_ROOT\*\shell] [HKEY_CLASSES_ROOT\*\shell\open] [HKEY_CLASSES_ROOT\*\shell\open\command] @="C:\\windows\\command\\start.exe kdestart.exe \"%1\"" because i thought that would be the default file association, but it doesn't work... Is this possible? It would be a great step for the integration of wine with KDE (or GNOME, because a similar script could be developed) thanks for any help Rainer

1 0

Sharing files between users
by Vitaly Lipatov Jan. 14, 2005

Jan. 14, 2005

I am looking for any resolve a problem with sharing open files. When one user calls CreateFile with sharing=FILE_SHARE_READ, other user can open the same file with sharing=FILE_SHARE_WRITE wthout any fails. I know sharing control done in wine-server, but it resolves problem only when single user sharing files, not two or more. I guess to move sharing support in kernel in some way. Any suggestions? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Janitorial : add missing declarations ( #3 )
by Dmitry Timoshkov Jan. 14, 2005

Jan. 14, 2005

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > diff -u dlls/x11drv/x11drv_main.c dlls/x11drv/x11drv_main.c > --- dlls/x11drv/x11drv_main.c 2004-12-08 18:27:53.000000000 +0100 > +++ dlls/x11drv/x11drv_main.c 2005-01-12 21:23:02.000000000 +0100 > @@ -119,6 +119,8 @@ > #define IS_OPTION_FALSE(ch) \ > ((ch) == 'n' || (ch) == 'N' || (ch) == 'f' || (ch) == 'F' || (ch) == '0') > > +BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ); This one should not be needed. -- Dmitry.

2 1

WineConf 2005
by Brian Vincent Jan. 14, 2005

Jan. 14, 2005

WINECONF 2005 GOES TO EUROPE! We have a tentative reservation for Wineconf and we'd like some feedback regarding dates and times: WHERE: Stuttgart, Germany WHEN: April 30 / May 1st (plan on arriving April 29th) We realize it's not possible to accomodate everyone's schedule, but these dates seem to work nicely for a lot of people. In addition, SambaXP will be held May 2nd and 3rd near the area, so this event may attract some other folks interested in this stuff. Can anyone foresee any glaring problems with the location and dates? Otherwise, we'll move forward with firming up the plans and send an official announcement later in the week. -Brian

2 1

Re: Add WM_GETOBJECT definition, remove WM_OTHERWINDOWCREATED define
by Robert North Jan. 14, 2005

Jan. 14, 2005

Dmitry Timoshkov dmitry-at-baikal.ru |Wine Mailing Lists| wrote: > Hello, > > Platform SDK defines WM_GETOBJECT as 0x003d and doesn't have a > message with value 0x003c at all. WM_GETOBJECT is used by Active > Accessibility to retrieve an interface pointer from a window. > > Changelog: Dmitry Timoshkov <dmitry(a)codeweavers.com> Add WM_GETOBJECT > definition, remove WM_OTHERWINDOWCREATED define. > > diff -up cvs/hq/wine/include/winuser.h wine/include/winuser.h --- > cvs/hq/wine/include/winuser.h 2005-01-10 13:55:58.000000000 +0800 +++ > wine/include/winuser.h 2005-01-14 16:23:38.000000000 +0800 @@ -985,8 > +985,8 @@ BOOL WINAPI SetSysColors(INT,cons #define > WM_COMPAREITEM 0x0039 #define WM_TESTING 0x003a > > > -#define WM_OTHERWINDOWCREATED 0x003c -#define > WM_OTHERWINDOWDESTROYED 0x003d I thought this removal looked a bit suspicious... So, I did a quick google for WM_OTHERWINDOWCREATED , and there seems to be a consensus that these two messages are defined as follows: WM_OTHERWINDOWCREATED 0x00000042 WM_OTHERWINDOWDESTROYED 0x00000043 What do you think? Should google be trusted? P.S. If yo do the google search, there's a link to a Russian windows internals book that may shed further light on these methods. Bye -Rob.

2 1

Re: advpack: add two missing stubs
by Robert Reif Jan. 14, 2005

Jan. 14, 2005

Robert Reif wrote: > Add stubs for NeedReboot and NeedRebootInit. > without FIXME bug Index: dlls/advpack/advpack.c =================================================================== RCS file: /home/wine/wine/dlls/advpack/advpack.c,v retrieving revision 1.6 diff -u -r1.6 advpack.c --- dlls/advpack/advpack.c 15 Dec 2004 10:52:57 -0000 1.6 +++ dlls/advpack/advpack.c 11 Jan 2005 00:57:39 -0000 @@ -96,3 +96,28 @@ return ret; } + +/*********************************************************************** + * NeedRebootInit (ADVPACK.@) + */ +DWORD WINAPI NeedRebootInit(VOID) +{ + FIXME("() stub!\n"); + + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + + return 0; +} + +/*********************************************************************** + * NeedReboot (ADVPACK.@) + */ + +BOOL WINAPI NeedReboot(DWORD dwRebootCheck) +{ + FIXME("(0x%08lx) stub!\n", dwRebootCheck); + + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + + return FALSE; +} Index: dlls/advpack/advpack.spec =================================================================== RCS file: /home/wine/wine/dlls/advpack/advpack.spec,v retrieving revision 1.4 diff -u -r1.4 advpack.spec --- dlls/advpack/advpack.spec 15 Dec 2004 10:52:57 -0000 1.4 +++ dlls/advpack/advpack.spec 11 Jan 2005 00:57:39 -0000 @@ -15,8 +15,8 @@ @ stub IsNTAdmin @ stdcall LaunchINFSection(ptr ptr str long) @ stdcall LaunchINFSectionEx(ptr ptr str long) -@ stub NeedReboot -@ stub NeedRebootInit +@ stdcall NeedReboot(long) +@ stdcall NeedRebootInit() @ stub OpenINFEngine @ stub RebootCheckOnInstall @ stdcall RegInstall(ptr str ptr)

4 7

Re: [AppDB] layout corners size
by Dimitrie O. Paun Jan. 14, 2005

Jan. 14, 2005

On Fri, Jan 14, 2005 at 01:58:25PM +0100, Jonathan Ernst wrote: > After doing it for lostwages I did the same for AppDB. Cool, don't forget Bugzilla too :) -- Dimi.

1 0

Re: [Fwd: OLEAUT32: VARIANT parsing of hex/octal integer string must not negate value]
by Alexandre Julliard Jan. 14, 2005

Jan. 14, 2005

Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > Apparently this patch did not make it in time for the 20050111 > release, so I am resending it. Could you please submit a test case for this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: listview: fix alignment tests
by Paul Vriens Jan. 14, 2005

Jan. 14, 2005

Dimitrie O. Paun wrote: > > ChangeLog > Use the LVCFMT_{LEFT,RIGHT,CENTER} enumeration flags properly. > > /* set text alignment (leftmost column must be left-aligned) */ > - if (nColumn == 0 || lpColumn->fmt & LVCFMT_LEFT) > + if (nColumn == 0 || (lpColumn->fmt & LVCFMT_JUSTIFYMASK) == > LVCFMT_LEFT) > lphdi->fmt |= HDF_LEFT; HDF_LEFT is also 0, so should we get rid of the first check, and only check for LVCFMT_RIGHT and LVCFMT_CENTER? > > if (lpColumn->fmt & LVCFMT_BITMAP_ON_RIGHT) > > -- > Dimi. > > Cheers, Paul.

2 1

Re: Writing a driver for scanners
by gslink Jan. 14, 2005

Jan. 14, 2005

The other day I came across a wrapper for wireless lan drivers that uses the XP driver and loads it into Linux. Driver interfaces in Windows are fairly standard for a certain type of device. I suggest you look on the web for sites that list drivers and see if something like this is available. If it is not then add to the wifi wrapper so that it handles the XP or 2000 driver that came with your scanner. The resulting code would be very valuable to both Wine and Linux especially if it allowed the use of an XP driver for the thousands of special devices that only have XP drivers. Start by looking at www.linuxdrivers.org.

1 0

WineHQ: suggested improvement
by Dimitrie O. Paun Jan. 14, 2005

Jan. 14, 2005

Hi folks, I haven't looked at the template system to see how easy this would be, but I have one problem with the site as it is now, that may be very easy to solve. Namely, when you load it first time, the browser doesn't know to render all the corners (since they are all images), and as a result the layout happens in stages, and it's annoying. Can we please provide _explicit_ sizes for <img>es like these: <img src="./images/winehq_border_top_right.gif" alt=""> <img src="./images/winehq_border_bottom_right.gif" alt=""> ... This should take care of this little annoyance, and would make the site feel better. -- Dimi.

2 1

Wine and FreeBSD
by Jason But Jan. 14, 2005

Jan. 14, 2005

Hello all, First, happy to see the new release of WINE 20050111 for FreeBSD (and previous 20041201) I obtained and compiled the latest version for my standard FreeBSD 5.3 install. Upon running any windows/wine app I get the error messages err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not available err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not available err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! Some apps (if they do not use the heap) continue to run, the apps I want to use (MS Office 2000 - Word/Excel/PowerPoint) fail as follows: ------------------------ MS Word will display the splash screen and then a message box with "There is not enough memory or disk space to run Word." before crashing ------------------------ MS Excel will start with the message box "Cannot use object linking and embedding" before starting, but attempting use excel will result in an out of memory error and then a crash ------------------------ MS PowerPoint doesn't even start. ------------------------ This is dissapointing, we have managed (http://caia.swin.edu.au/reports/041129A) to install MS Office 2K on WINE 20040505 under FreeBSD but were hoping that this newer version would fix our two discovered problems (the new file.. dialog and the pulldown menus if more than one office app is running). Unfortunately, it seems that the new version breaks everything. Further pottering around found... HEAP_CreateSystemHeap() calls MapViewOfFileEx() which calls NtMapViewOfSection() which calls map_view() which attempts a normal allocation - wine_mmap_is_in_reserved_area() == 0 calling wine_anon_mmap() The returned pointer is valid so wine_anon_mmap() succeeds BUT the returned ptr != base and so the function returns STATUS_CONFLICTING_ADDRESSES which returns up the chain and the heap allocation fails. On my system base being requested is 0x80000000 and ptr being returned is 0x9996d000. This result then fails the is_beyond_limit() test... Any clues would help!! Thanks. Jason

1 0

The use of a zero flag
by Paul Vriens Jan. 14, 2005

Jan. 14, 2005

Hi, a few days ago I found a bug in ole32/compobj.c where we did something like: if ( foo & FLAG) .... where FLAG=0 This 'inspired' me to check for more of these kind of checks. One that I already found is in dlls/dplayx/dplay.c We are checking for DPSET_REMOTE (which is zero) where we should have checked for !DPSET_LOCAL or something alike. Is it worthwhile to set up a Janitorial task for this or are these plain bugs? On the one hand it will be hard to find these and you have to know the code of course. Cheers, Paul.

3 5

WINE and FreeBSD
by Jason But Jan. 14, 2005

Jan. 14, 2005

Hello all, I wasn't quite sure which list to post this on (no flames please) First, happy to see the new release of WINE 20050111 for FreeBSD (and previous 20041201) I obtained and compiled the latest version for my standard FreeBSD 5.3 install. Upon running any windows/wine app I get the error messages err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not available err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not available err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! Some apps (if they do not use the heap) continue to run, the apps I want to use (MS Office 2000 - Word/Excel/PowerPoint) fail as follows: ------------------------ MS Word will display the splash screen and then a message box with "There is not enough memory or disk space to run Word." before crashing ------------------------ MS Excel will start with the message box "Cannot use object linking and embedding" before starting, but attempting use excel will result in an out of memory error and then a crash ------------------------ MS PowerPoint doesn't even start. ------------------------ This is dissapointing, we have managed (http://caia.swin.edu.au/reports/041129A) to install MS Office 2K on WINE 20040505 under FreeBSD but were hoping that this newer version would fix our two discovered problems (the new file.. dialog and the pulldown menus if more than one office app is running). Unfortunately, it seems that the new version breaks everything. Further pottering around found... HEAP_CreateSystemHeap() calls MapViewOfFileEx() which calls NtMapViewOfSection() which calls map_view() which attempts a normal allocation - wine_mmap_is_in_reserved_area() == 0 calling wine_anon_mmap() The returned pointer is valid so wine_anon_mmap() succeeds BUT the returned ptr != base and so the function returns STATUS_CONFLICTING_ADDRESSES which returns up the chain and the heap allocation fails. On my system base being requested is 0x80000000 and ptr being returned is 0x9996d000. This result then fails the is_beyond_limit() test... Any clues would help!! Thanks. Jason

1 0

Re: Keyboard+Ukrainian
by Dmitry Timoshkov Jan. 14, 2005

Jan. 14, 2005

"Oleh R. Nykyforchyn" <nick(a)pu.if.ua> wrote: > I propose two patches to Wine20050111 (sorry for not using CVS, but I have rather > slow dialup connection). First is more or less obvious: current cp_20866.c page > includes only Russian KOI8-R codes and is insufficient for Ukrainian and Byelarussian users. > It is easy to add four Ukrainian pairs and one Byelarussian pair of letters (in fact, > move to KOI8-RU). I patched the Perl script an regenerated cp_20866.c: You can't do that. Windows has a distinct code page for Ukrainian and Byelarussian, it's 21866. > Second proposal is more complicated. I have four XKB groups in my X.org > (Latin + 3 cyrillic encodings), and, moreover, use overlays to switch > between Ukrainian and Russian. This approach is typical among Cyrillic > Linux users. Of course, wine cannot handle my case, so I partially rewrote > keyboard.c to take care of groups and overlays switching if XKB is present. > Now You can have four independent layouts up to four shift levels in each. > If XKB is absent, wine will behave as before. Driver will switch internal > XKB group counter each time when looked up symbol doesn't match previously > built tables. If this doesn't help, the whole layout ONLY FOR THIS GROUP > (to save time) will be refreshed. The real fix for your problem is to add a proper support for keyboard layouts, and switch internal x11drv layout on an appropriate X event. -- Dmitry.

1 0

Code cleanup: SHFileOperationW
by Joris Huizer Jan. 14, 2005

Jan. 14, 2005

Hi, I took out a part of the function SHFileOperationW and put it in a new function - please give any comments: is this the way to make this function more readable you want it? what is a better way of calling such a function? regards, Joris ? .patch.diff.swp ? backup-010320051808-pre-wine.tgz ? backup-010920052053-pre-wine.tgz ? backup-011120051329-pre-wine.tgz ? backup-011120051339-pre-wine.tgz ? backup-011220050008-pre-wine.tgz ? backup-123120041614-pre-wine.tgz ? badrefs ? description-pak ? doc-pak ? getrefs ? patch.diff ? ref ? refs ? versions ? wine-working.deb ? wine_cvs-041231-1_i386.deb ? wine_cvs-050103-1_i386.deb ? wine_cvs-050109-1_i386.deb ? wine_cvs-050111.noalsa-1_i386.deb ? wine_cvs-050112.release-1_i386.deb ? programs/notepad2 Index: dlls/shell32/shlfileop.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shlfileop.c,v retrieving revision 1.50 diff -u -r1.50 shlfileop.c --- dlls/shell32/shlfileop.c 23 Dec 2004 17:12:07 -0000 1.50 +++ dlls/shell32/shlfileop.c 13 Jan 2005 14:13:33 -0000 @@ -861,6 +861,40 @@ #define ERROR_SHELL_INTERNAL_FILE_NOT_FOUND 1026 #define HIGH_ADR (LPWSTR)0xffffffff +static int WINAPI SHFileOperationW_delete( WIN32_FIND_DATAW *wfd,SHFILEOPSTRUCTW nFileOp, LPWSTR pFromFile,LPWSTR pTempFrom,HANDLE hFind) + +{ + LPWSTR lpFileName; + BOOL b_Mask = (NULL != StrPBrkW(&pFromFile[1], wWildcardChars)); + int retCode = 0; + do + { + lpFileName = wfd->cAlternateFileName; + if (!lpFileName[0]) + lpFileName = wfd->cFileName; + if (IsDotDir(lpFileName) || + ((b_Mask) && IsAttribDir(wfd->dwFileAttributes) && (nFileOp.fFlags & FOF_FILESONLY))) + continue; + SHFileStrCpyCatW(&pFromFile[1], lpFileName, NULL); + /* TODO: Check the SHELL_DeleteFileOrDirectoryW() function in shell32.dll */ + if (IsAttribFile(wfd->dwFileAttributes)) + { + if(SHNotifyDeleteFileW(pTempFrom) != ERROR_SUCCESS) + { + nFileOp.fAnyOperationsAborted = TRUE; + retCode = 0x78; /* value unknown */ + } + } + else if(!SHELL_DeleteDirectoryW(pTempFrom, (!(nFileOp.fFlags & FOF_NOCONFIRMATION)))) + { + nFileOp.fAnyOperationsAborted = TRUE; + retCode = 0x79; /* value unknown */ + } + } + while (!nFileOp.fAnyOperationsAborted && FindNextFileW(hFind,wfd)); + return retCode; +} + /************************************************************************* * SHFileOperationW [SHELL32.@] * @@ -1080,33 +1114,9 @@ /* ??? b_Mask = (!SHFileStrICmpA(&pFromFile[1], &wfd.cFileName[0], HIGH_ADR, HIGH_ADR)); */ if (!pTo) /* FO_DELETE */ { - do - { - lpFileName = wfd.cAlternateFileName; - if (!lpFileName[0]) - lpFileName = wfd.cFileName; - if (IsDotDir(lpFileName) || - ((b_Mask) && IsAttribDir(wfd.dwFileAttributes) && (nFileOp.fFlags & FOF_FILESONLY))) - continue; - SHFileStrCpyCatW(&pFromFile[1], lpFileName, NULL); - /* TODO: Check the SHELL_DeleteFileOrDirectoryW() function in shell32.dll */ - if (IsAttribFile(wfd.dwFileAttributes)) - { - if(SHNotifyDeleteFileW(pTempFrom) != ERROR_SUCCESS) - { - nFileOp.fAnyOperationsAborted = TRUE; - retCode = 0x78; /* value unknown */ - } - } - else - { - if(!SHELL_DeleteDirectoryW(pTempFrom, (!(nFileOp.fFlags & FOF_NOCONFIRMATION)))) - { - nFileOp.fAnyOperationsAborted = TRUE; - retCode = 0x79; /* value unknown */ - } - } - } while (!nFileOp.fAnyOperationsAborted && FindNextFileW(hFind, &wfd)); + int ret = SHFileOperationW_delete(&wfd,nFileOp,pFromFile,pTempFrom,hFind); + if (ret != 0) + retCode = ret; FindClose(hFind); hFind = INVALID_HANDLE_VALUE; if (nFileOp.fAnyOperationsAborted) Index: dlls/wined3d/basetexture.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/basetexture.c,v retrieving revision 1.2 diff -u -r1.2 basetexture.c --- dlls/wined3d/basetexture.c 9 Jan 2005 17:37:02 -0000 1.2 +++ dlls/wined3d/basetexture.c 13 Jan 2005 14:13:34 -0000 @@ -37,16 +37,17 @@ ULONG WINAPI IWineD3DBaseTextureImpl_AddRef(IWineD3DBaseTexture *iface) { IWineD3DBaseTextureImpl *This = (IWineD3DBaseTextureImpl *)iface; - TRACE("(%p) : AddRef increasing from %ld\n", This, This->resource.ref); + ULONG ref = InterlockedIncrement(&This->resource.ref); + + TRACE("(%p) : AddRef increasing from %ld\n", This,ref - 1); IUnknown_AddRef(This->resource.parent); - return InterlockedIncrement(&This->resource.ref); + return ref; } ULONG WINAPI IWineD3DBaseTextureImpl_Release(IWineD3DBaseTexture *iface) { IWineD3DBaseTextureImpl *This = (IWineD3DBaseTextureImpl *)iface; - ULONG ref; - TRACE("(%p) : Releasing from %ld\n", This, This->resource.ref); - ref = InterlockedDecrement(&This->resource.ref); + ULONG ref = InterlockedDecrement(&This->resource.ref); + TRACE("(%p) : Releasing from %ld\n", This, ref + 1); if (ref == 0) { IWineD3DDevice_Release((IWineD3DDevice *)This->resource.wineD3DDevice); HeapFree(GetProcessHeap(), 0, This); Index: dlls/wined3d/indexbuffer.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/indexbuffer.c,v retrieving revision 1.4 diff -u -r1.4 indexbuffer.c --- dlls/wined3d/indexbuffer.c 9 Jan 2005 17:37:02 -0000 1.4 +++ dlls/wined3d/indexbuffer.c 13 Jan 2005 14:13:34 -0000 @@ -38,16 +38,16 @@ ULONG WINAPI IWineD3DIndexBufferImpl_AddRef(IWineD3DIndexBuffer *iface) { IWineD3DIndexBufferImpl *This = (IWineD3DIndexBufferImpl *)iface; - TRACE("(%p) : AddRef increasing from %ld\n", This, This->resource.ref); + ULONG ref = InterlockedIncrement(&This->resource.ref); + TRACE("(%p) : AddRef increasing from %ld\n", This, ref - 1); IUnknown_AddRef(This->resource.parent); - return InterlockedIncrement(&This->resource.ref); + return ref } ULONG WINAPI IWineD3DIndexBufferImpl_Release(IWineD3DIndexBuffer *iface) { IWineD3DIndexBufferImpl *This = (IWineD3DIndexBufferImpl *)iface; - ULONG ref; - TRACE("(%p) : Releasing from %ld\n", This, This->resource.ref); - ref = InterlockedDecrement(&This->resource.ref); + ULONG ref = InterlockedDecrement(&This->resource.ref); + TRACE("(%p) : Releasing from %ld\n", This, ref + 1); if (ref == 0) { HeapFree(GetProcessHeap(), 0, This->allocatedMemory); IWineD3DDevice_Release((IWineD3DDevice *)This->resource.wineD3DDevice); Index: dlls/wined3d/resource.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/resource.c,v retrieving revision 1.4 diff -u -r1.4 resource.c --- dlls/wined3d/resource.c 9 Jan 2005 17:37:02 -0000 1.4 +++ dlls/wined3d/resource.c 13 Jan 2005 14:13:34 -0000 @@ -36,15 +36,15 @@ ULONG WINAPI IWineD3DResourceImpl_AddRef(IWineD3DResource *iface) { IWineD3DResourceImpl *This = (IWineD3DResourceImpl *)iface; - TRACE("(%p) : AddRef increasing from %ld\n", This, This->resource.ref); - return InterlockedIncrement(&This->resource.ref); + ULONG ref = InterlockedIncrement(&This->resource.ref); + TRACE("(%p) : AddRef increasing from %ld\n", This, ref - 1); + return ref; } ULONG WINAPI IWineD3DResourceImpl_Release(IWineD3DResource *iface) { IWineD3DResourceImpl *This = (IWineD3DResourceImpl *)iface; - ULONG ref; - TRACE("(%p) : Releasing from %ld\n", This, This->resource.ref); - ref = InterlockedDecrement(&This->resource.ref); + ULONG ref = InterlockedDecrement(&This->resource.ref); + TRACE("(%p) : Releasing from %ld\n", This, ref + 1); if (ref == 0) { IWineD3DDevice_Release((IWineD3DDevice *)This->resource.wineD3DDevice); HeapFree(GetProcessHeap(), 0, This); Index: dlls/wined3d/surface.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/surface.c,v retrieving revision 1.1 diff -u -r1.1 surface.c --- dlls/wined3d/surface.c 9 Jan 2005 17:37:02 -0000 1.1 +++ dlls/wined3d/surface.c 13 Jan 2005 14:13:35 -0000 @@ -38,16 +38,16 @@ ULONG WINAPI IWineD3DSurfaceImpl_AddRef(IWineD3DSurface *iface) { IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface; - TRACE("(%p) : AddRef increasing from %ld\n", This, This->resource.ref); + ULONG ref = InterlockedIncrement(&This->resource.ref); + TRACE("(%p) : AddRef increasing from %ld\n", This,ref - 1); IUnknown_AddRef(This->resource.parent); - return InterlockedIncrement(&This->resource.ref); + return ref } ULONG WINAPI IWineD3DSurfaceImpl_Release(IWineD3DSurface *iface) { IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface; - ULONG ref; - TRACE("(%p) : Releasing from %ld\n", This, This->resource.ref); - ref = InterlockedDecrement(&This->resource.ref); + ULONG ref = InterlockedDecrement(&This->resource.ref); + TRACE("(%p) : Releasing from %ld\n", This, ref + 1); if (ref == 0) { HeapFree(GetProcessHeap(), 0, This->allocatedMemory); IWineD3DDevice_Release((IWineD3DDevice *)This->resource.wineD3DDevice); Index: dlls/wined3d/vertexbuffer.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/vertexbuffer.c,v retrieving revision 1.6 diff -u -r1.6 vertexbuffer.c --- dlls/wined3d/vertexbuffer.c 9 Jan 2005 17:37:02 -0000 1.6 +++ dlls/wined3d/vertexbuffer.c 13 Jan 2005 14:13:35 -0000 @@ -38,16 +38,16 @@ ULONG WINAPI IWineD3DVertexBufferImpl_AddRef(IWineD3DVertexBuffer *iface) { IWineD3DVertexBufferImpl *This = (IWineD3DVertexBufferImpl *)iface; - TRACE("(%p) : AddRef increasing from %ld\n", This, This->resource.ref); + ULONG ref = InterlockedIncrement(&This->resource.ref); + TRACE("(%p) : AddRef increasing from %ld\n", This, ref - 1); IUnknown_AddRef(This->resource.parent); - return InterlockedIncrement(&This->resource.ref); + return ref; } ULONG WINAPI IWineD3DVertexBufferImpl_Release(IWineD3DVertexBuffer *iface) { IWineD3DVertexBufferImpl *This = (IWineD3DVertexBufferImpl *)iface; - ULONG ref; - TRACE("(%p) : Releasing from %ld\n", This, This->resource.ref); - ref = InterlockedDecrement(&This->resource.ref); + ULONG ref = InterlockedDecrement(&This->resource.ref); + TRACE("(%p) : Releasing from %ld\n", This, ref + 1); if (ref == 0) { HeapFree(GetProcessHeap(), 0, This->allocatedMemory); IWineD3DDevice_Release((IWineD3DDevice *)This->resource.wineD3DDevice);

4 10

Re: [AppDB] new fix for preferences
by Paul van Schayck Jan. 13, 2005

Jan. 13, 2005

Hey, On Thu, 13 Jan 2005 14:43:49 -0500, Chris Morgan <chmorgan(a)charter.net> wrote: > Good job guys. That was a tricky one to figure out. Yes it was (all honor to Tony and Jonathan for finding it). The memory alloc problems were caused by addmsg() calling itself recursively trying to insert a message, failing, and trying to insert a message again (trough query_error()). And those failures were caused because the connection to mysql was changed to use another database (the bugzilla db, hence the failure just after using a bugzilla function). And that was caused because although we defined a different connection resource internally the same handle was used (as descriped by the PHP manual) Now we are reselecting the database with each call to the query functions. This is still not completely a clean solution. As this will send an additional query to mysql with each query. I will try something with Tony tomorrow to get it completely clean. We also need to protect addmsg calling itself recursively. I was thinking of checking if it send out the same message already and if so exit;. Another solution would be to not use quer_appdb() but just mysql_query(). What do you think? Paul

1 0

COM inheritance Q
by Ann and Jason Edmeades Jan. 13, 2005

Jan. 13, 2005

Hiya, In the wined3d code I have, for example, a class surface which inherits a lot of methods of Resource. Most of these methods can be called as-is, and I have code which looks like: HRESULT WINAPI IWineD3DSurfaceImpl_GetParent(IWineD3DSurface *iface, IUnknown **pParent) { return IWineD3DResource_GetParent((IWineD3DResource *)iface, pParent); } Great idea.... but this fails: IWineD3DResource_GetParent is a macro: #define IWineD3DSurface_GetParent(p,a) (p)->lpVtbl->GetParent(p,a) So we then go iface->lpVtbl->GetTable. Since iface is a surface, once cast to a resource its GetParent is in the same place in the table... Hence the call ends up being effectively HRESULT WINAPI IWineD3DSurfaceImpl_GetParent(IWineD3DSurface *iface, IUnknown **pParent) { return IWineD3DSurfaceImpl_GetParent (iface, pParent); } Whats the solution? In d3d8 I would have coded IWineD3DSurfaceImpl_GetParent as IWineD3DResourceImpl_GetParent(iface, pParent) because the Impl versions were prototyped - Is this the only way to solve this? Jason

4 10

heapalloc woes..
by Oliver Stieber Jan. 13, 2005

Jan. 13, 2005

Hi, I've been doing some DirectX work with Jason and have come across a problem? with heapalloc. As soon as my system ram maxes out heapalloc fails, even though Linux is using some ram for cache and only 500k of swap is used. Wine is using <300Mb I ahve 512Mb ram and 512 swap. I've written a small test app using malloc to make sure swap is working and I can allocate well over 700Mb of ram without any problems. Should I be using something other than heapalloc or is this a 'wine' problem? ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

1 0

[DPLAYX] Get rid of check for DPSET_REMOTE in dplayx.c
by Paul Vriens Jan. 13, 2005

Jan. 13, 2005

Hi, as DPSET_REMOTE is 0 we cannot check for it, like it's currently done in dplayx.c: if( dwFlags & DPSET_REMOTE ) we have to use some other method. As DPSET_REMOTE and DPSET_LOCAL (which is 1) are mutually exclusive we could do: if (!(dwFlags & DPSET_LOCAL)) { } or if (dwFlags & DPSET_LOCAL) { } else /* DPSET_REMOTE */ { } The attached patch gets rid of the afore mentioned wrong checks. Remember that because of the changes the code-path changes as well. We now get into places where we 'never' went before. Patch is only compile tested and I changed some of the coding-style. Any comment is welcome. (I'm learning). Cheers, Paul.

1 0

Re: [LOSTWAGES] Add janitorial task to avoid using strncpy
by Joris Huizer Jan. 13, 2005

Jan. 13, 2005

Mike McCormack wrote: > ChangeLog: > * Add janitorial task to avoid using strncpy > > > ------------------------------------------------------------------------ > > Index: templates/en/janitorial.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/janitorial.template,v > retrieving revision 1.61 > diff -u -r1.61 janitorial.template > --- templates/en/janitorial.template 11 Jan 2005 20:33:41 -0000 1.61 > +++ templates/en/janitorial.template 13 Jan 2005 15:15:44 -0000 > @@ -7,6 +7,24 @@ > Janitor's List</a>), and it's high time that we have one too. > What is there to clean up? Well, lots of things! :) > > + <h2>Eliminate uses of strncpy/strncpyW</h2> > + > + <i>strncpy(dst,src,n)</i> has two subtle > + <a href="http://weblogs.asp.net/oldnewthing/archive/2005/01/07.aspx"> > + problems</a>. The first is that it always fills the whole <i>dst</i> > + buffer (<i>n</i> characters). The second is that it doesn't always nul > + terminate the <i>dst</i> buffer that it's filling.<p> > + > + Wine code should avoid the use of strncpy for these reasons, and instead > + use lstrcpyA/W or memcpy. You can use the following command to find > + occurences of strncpy in the Wine source code:<p> > + > + <tt>find . -name \*.c -exec grep strncpy {} \; -ls</tt><p> > + > + The aim is to make sure that we only copy as many bytes as necessary into > + the <i>dst</i> buffer, and always nul terminate the buffer when we > + intended to.<p> > + > <h2>Regedit fixes</h2> > > Regedit lacks a few features. We need to improve regedit to: Couldn't we just make a sane implementation of strncpy, not adding more '\0' characters than necessary and making sure the last character is an '\0'? (untested ofcourse ;)) char *strncpy(char *dst,char *src,int n) { int i; for (i = 0; (dst[i] = src[i]) != '\0' && i < n; i++) ; /* n - 1 is '\0'; ensures the end of the string is '\0' */ dst[n - 1] = '\0'; } Now, something like this would at least save us of replacing all strncpyW, wouldn't it? regards, Joris

5 5

Re: NOTIFY_PRE and NOTIFY_POST definitions in include files
by Juan Lang Jan. 13, 2005

Jan. 13, 2005

Francois wrote: > So I would say the correct values are the ones in npapi.h and that > netspi.h should be moved to dlls/mpr which is the only place where it is > used. But this needs a bit more investigation. I agree. I would conjecture that netspi.h is old, and the declarations in it have been superceded by those in npapi.h. For example, the definitions of NOFIYADD, NOTIFYCANCEL, and NOTIFYINFO don't match MSDN: http://msdn.microsoft.com/library/en-us/secauthn/security/notifyadd.asp http://msdn.microsoft.com/library/en-us/secauthn/security/notifycancel.asp http://msdn.microsoft.com/library/en-us/secauthn/security/notifyinfo.asp but those in npapi.h do. The main use of netspi.h seems to be to declare the NPS functions defined in mpr/nps.c. These aren't documented on MSDN, but are exported by Win9x versions of mpr.dll. Anything that doesn't support these functions should be deleted, and since it's not part of the PSDK, making it a private header is fine, or just moving the required declarations to nps.c should be fine too. --Juan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

[AppDB] create new users is Br0ck.
by tony_lambregts＠telusplanet.net Jan. 13, 2005

Jan. 13, 2005

The last patch broke make_bugzilla_version_list() which is used by account.php and admin/editAppVersion.php. That means that new users can not create accounts and maintainers cannot edit their versions. http://cvs.winehq.org/patch.py?id=15387 The same code on my machine works fine with my test databases. I do not know how to fix this other than reversing the patch. -- Tony Lambregts.

4 7

NOTIFY_PRE and NOTIFY_POST definitions in include files
by Paul Vriens Jan. 13, 2005

Jan. 13, 2005

Hi, just found the following: [paul(a)penguin include]$ grep -e NOTIFY_PRE -e NOTIFY_POST * netspi.h:#define NOTIFY_PRE 0x00 netspi.h:#define NOTIFY_POST 0x01 npapi.h:#define NOTIFY_PRE 0x00000001 npapi.h:#define NOTIFY_POST 0x00000002 this doesn't look right although they do not seem to be used anywhere in the code currently. Any comments? Cheers, Paul.

2 1

Re: The use of a zero flag
by Rolf Kalbermatter Jan. 13, 2005

Jan. 13, 2005

Paul Vriens wrote: >a few days ago I found a bug in ole32/compobj.c where we did something >like: > >if ( foo & FLAG) .... where FLAG=0 > >This 'inspired' me to check for more of these kind of checks. > >One that I already found is in dlls/dplayx/dplay.c > >We are checking for DPSET_REMOTE (which is zero) where we should have >checked for !DPSET_LOCAL or something alike. Often flag sets with a zero flag are more like an enumeration than real flags and have some sort of mask defined which specifies which bits are relevant for that group of flags. Microsoft does something mix real flags and enumeration flags in the same integer but always at different bit locations. Something like if ((foo & MASK) == FLAG) will usually work fine then. Rolf Kalbermatter

1 0

[COMCTL32] The use of the PGS_VERT flag
by Paul Vriens Jan. 13, 2005

Jan. 13, 2005

Hi, the flag PGS_VERT is zero and should not be checked against. It's only the lack of PGS_HORZ that should be checked. Is the following piece of code needed in dll//comctl32/pager.c: 851 if (!(dwStyle & PGS_HORZ) && !(dwStyle & PGS_VERT)) 852 { 853 dwStyle |= PGS_VERT; 854 SetWindowLongA(hwnd, GWL_STYLE, dwStyle); 855 } The check is whether any of the flags is set, but PGS_VERT is already the default when there is a lack of PGS_HORZ. Cheers, Paul.

1 0

Best DLLs to write conformance tests for?
by Dan Kegel Jan. 13, 2005

Jan. 13, 2005

Recently, I helped a student at Harvey Mudd college write and submit a conformance test for the lzexpand dll: http://www.winehq.com/hypermail/wine-cvs/2004/11/0164.html I picked lzexpand.dll since (lacking a GUI) it seemed simple to test. Now I'm putting together a reusable lab project for other colleges, at http://kegel.com/wine/sweng, and am trying to pick a few good DLLs for the students to write tests for. (I plan ask the students to send me their patches so I can review them before they post them on wine-patches.) Clearly, I shouldn't ask anyone to write a conformance test for a huge DLL in a term, so I guess I'll focus on on the DLLs with under 100 functions. And I'd like to skip DLLs that have GUIs, so I guess I'll omit any where the word HWND occurs. That leaves the following 53 DLLs or VxDs: amstream atl cabinet capi2032 cards cfgmgr32 comcat crypt32 d3dx8 d3dxof dbghelp devenum dinput8 dmband dmcompos dmscript dmsynth dmusic32 dplayx dpnet dpnhpast dswave dxdiagn dxerr8 dxerr9 glu32 iccvid icmp ifsmgr.vxd imagehlp itss mmdevldr.vxd monodebg.vxd msdmo mshtml msimg32 msisys msnet32 msvidc32 mswsock olepro32 olesvr qcap secur32 vdhcp.vxd vmm.vxd vnbt.vxd vnetbios.vxd vtdapi.vxd vwin32.vxd win32s winaspi wsock32 That's a small enough list that I can start guessing at which ones are worth writing tests for. Let's see, how 'bout the following 12: amstream atl cabinet crypt32 dplayx dpnet icmp imagehlp itss mswsock winaspi wsock32 Are any of those obviously poor choices for writing a conformance test? Or are there others that are obviously good choices, but that I missed? Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: USER32: Implement SPI_{GET,SET}MINIMIZEDMETRICS
by Mike McCormack Jan. 13, 2005

Jan. 13, 2005

jchevrier(a)nexicom.net wrote: > *Implemented SPI_GETMINIMIZEDMETRICS calculated from values returned by > GetSystemMetrics. The math applied to the values returned from > GetSystemMetrics was verified against Windows 98 and XP using a simple test > program. Yey for test programs :) Would you mind sending it to the list or adding some tests in dlls/user/tests/sysparams.c ? thanks, Mike

1 0

[AppDB] script to clean duplicate users
by Jonathan Ernst Jan. 12, 2005

Jan. 12, 2005

This script will remove duplicate users from the appdb (same email address), give their data to the most recently logged user that has the same email address and then fix the db structure so that it's not possible anymore to have two time the same email address. Usage: 1)chmod u+x ./clean.php 2)edit clean.php to set up the database connection (line 11 and 12) 3)./clean.php (if php is not in /usr/bin/php you'll have to edit the first line too)

1 0

Re: [QUARTZ] Revert regsvr.c patch
by Robert Shearman Jan. 12, 2005

Jan. 12, 2005

Paul Vriens wrote: >Hi, > >Christian made me aware of the following: > >--- >As long as this object is not implemented, the FIXME should remain to >remind us that something is missing from quartz. >--- > >As 'Seeking' is not yet implemented I would like to have this patch >reverted. > >Sorry for any inconvenience. > >Cheers, > >Paul > >Changelog > Remove CLSID for registration as it's not implemented yet. > > There is no need to revert the patch because, although the CLSID is not implement yet, it will still print out a fixme in DllGetClassObject (line 181 in dlls/quartz/main.c). Rob

1 0

Re: Palm OS Desktop & Wine
by Stefan Dösinger Jan. 12, 2005

Jan. 12, 2005

> > The palm Desktop > > installer requires some playing with MSI, I don't remember exactly what I > > did. Note that you can't run the Palm Desktop application, but you can > > run hotsync.exe which is enought to get PDF files onto the palm. > > hotsync.exe: I guess you mean running the HotSync icon on the PDA. No, it's an Win32 binary in the Palm Desktop install directory (usually C: \program files\palm\) It's the "Hotsync Manager". Of course you'll need the HotSync programs on the PalmOS side too. > > No, it doesn't work with USB. > > OK that, it is clear. Well, I didn't try, it might work but I don't think so. Especially because visor.c claims the device. > Here I am lost: Sorry for that. > Could you please explain me this a little more in detail. Should I use > infrared connection or USB connection for what you just described (network > sync with 127.0.0.1)? I do have pi-nredir & pilot-link on my linux laptop > but I do not see what I should configure on my PDA. Moroever, which port > should I provide to pi-nredir ? Could give me the right command to use for > "pi-nredir" to install > /mnt/cdrom/essential_software/acrobatreader_for_palmos/adobereader-palmos.e >xe as example ? A small step-for-step howto: *Install Palm Desktop. *install the Adobe Reader for PalmOS converter. This means running adobereader-palmos.exe with wine *Launch hotsync.exe from the directory where Palm.exe is installed. You'll get the hotsync icon in your Desktop's systray *Double-click it with the right mouse button. You'll always have to double click the hotsync icon to open the menu, I don't know why *Select the "Setup..." menu item or whatever it is called. I have the German version and it's labeled "Einrichten..." *Open the network tab, press "TCP/IP Settings". Check if the ip is correct and enter a correct subnet mask, e.g. 255.255.255.0 *Press OK to close the windows *terminate any Linux app which might access the Palm. Connect the Palm to your PC with the USB cable *Launch the Hotsync program on your PalmOS device *Open the menu and select "LANSync-Setup" or what it's called. The german version labels it "LANSync-Einst..." *Select LANSync and tab OK to close the dialog *Start the Hotsync over the usb cable. *Run pi-nredir -p /dev/pilot on your Computer 3 or 4 secounds later. The Hotsync dialog should pop up and the Device should perform a hotsync with the Win32 Palm Desktop. (replace /dev/pilot with the hotsync port visor.c provides to you. Usually /dev/ttyUSBX or /dev/usb/tts/X) To upload a pdf launch the pdf converter from it's install directory, and select the pdf file to upload. Then perform a hotsync. I hope this is correct, I wrote it down from memory. Cheers, Stefan

1 0

Janitorial : check all refcounts in Wine?
by Paul Vriens Jan. 12, 2005

Jan. 12, 2005

Hi, for the described Janitorial task 'Use Interlocked functions in AddRef and Release methods' I'm currently looking at This->ref. If I however do a wider search I find a bit more, for example: kernel/atom.c:256: entryPtr->refCount++; msi/handle.c:188: ret = info->refcount--; rpcrt4/cproxy.c:219: This->RefCount++; setupapi/virtcopy.c:106: vhstrlist[n]->refcount++; and so on. I only looked at names containing 'ref'. But there are more around where 'ref' is not in the name: ole32/compobj.c: COM_CurrentInfo()->inits++; I know it's a hell of a job, but should these also be 'fixed'/changed? Of course it's a bit hard to tell which are thread unsafe. Cheers, Paul.

2 1

[AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c
by Paul Vriens Jan. 12, 2005

Jan. 12, 2005

Hi, during my code cleanup I came to acmstream.c and found the following: static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRACE("(%p) -> %ld\n", iface, This->ref + 1); /* also add reference to the nested stream */ if (This->pStream != NULL) IAVIStream_AddRef(This->pStream); return ++(This->ref); } the AddRef can be cleaned up. the Release however looks buggy: static ULONG WINAPI ACMStream_fnRelease(IAVIStream* iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRACE("(%p) -> %ld\n", iface, This->ref - 1); if (This->ref == 0) { /* destruct */ This means I have to do a Release twice before it actually goes into the if statement, because the decrementing takes place at the end of the Release function. Can anybody confirm my finding. Cheers, Paul.

2 3

Request for Sourceforge Upload Access
by Scott Ritchie Jan. 12, 2005

Jan. 12, 2005

I need to upload the Debian packages into the Sourceforge HTTP space in order for our APT server to be up to date. It'd be nice if I could do it myself. My sourceforge name is yokozar If someone could add me that would be great. Thanks, Scott Ritchie

1 0

[Fwd: msttcorefonts are missing I think]
by Scott Ritchie Jan. 12, 2005

Jan. 12, 2005

A user sent me this. I'm not exactly sure what she's referring to. Any ideas?

2 1

import stubs
by Dan Notestein Jan. 12, 2005

Jan. 12, 2005

Instead of directly using native methods to export functions from wine shared libs, Wine and WineLib emulate the windows methodology for exporting/importing these functions. Is this just to enable the use of native Windows dlls in Wine, or is it needed for other reasons? I ask because we're currently using WineLib to port to Solaris and HPUX, where native Windows dlls wouldn't work anyways, and it might be nice if we can remove this overhead on these platforms (and save us some porting headaches). However, before we started this work, we want to be sure there are no "gotchas" associated with removing it.

1 0

Re: Correction to COINIT_MULTITHREADED test
by Christian Costa Jan. 11, 2005

Jan. 11, 2005

> Message du 11/01/05 08:45 > De : "Paul Vriens" > A : "Bill Medland" > Copie à : "wine-devel(a)winehq.org" > Objet : Re: Correction to COINIT_MULTITHREADED test > On Mon, 2005-01-10 at 21:20, Bill Medland wrote: > > Bill Medland (billmedland(a)mercuryspeed.com) > > Correct testing for multithreaded > > (as spotted by Paul Vriens; fix suggested by Robert Shearman) > > > Hi Bill, > > it wasn't the check that was way over my head. The thing is, that with > this code change we walk a new path in COM_CreateApartment. > > I don't know what the result is but in CoInitializeEx we do: > > 545 if (!(apt = COM_CurrentInfo()->apt)) > 546 { > 547 apt = COM_CreateApartment(dwCoInit); > 548 if (!apt) return E_OUTOFMEMORY; > 549 } > > and apparently that leaves us with a E_OUTOFMEMORY all the time. Which > means that we will not come to the part: All the time ? Looking at COM_CreateApartment it seems COINIT_APARTMENTTHREADED works but indeed COINIT_MULTITHREADED always return NULL. I think the code at the beginning of COM_CreateApartment is wrong. TRACE("thread 0x%lx is entering the multithreaded apartment\n", GetCurrentThreadId()); COM_CurrentInfo()->apt = &MTA; return apt; I think we should return COM_CurrentInfo()->apt rather than apt. Bye, Christian

2 4

Palm OS Desktop & Wine
by FyD Jan. 11, 2005

Jan. 11, 2005

Dear All, I have a Tungsten E PDA and use K-pilot/J-pilot to backup/restore/install .pdb/.prc files with my linux box. No problem for that. => However, I would like to install a .pdf viewer on my PDA and the files provided for this installation are not .pdb/.prc files but a Windows executable file (AdobeReader305-PalmOS.exe). To install this file, I need to install the whole Palm Desktop CD under windows. => Consequently, I thought to use Wine for that: I compiled Wine_20041201 on my linux box (RedHat 9.0), configured it with 'winesetuptk' and run 'wine /mnt/cdrom/autorun.exe' to install the whole Palm Desktop CD for window. The installation seems to start ok & I get the following error message: [...] fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:powermgnt:SetThreadExecutionState (0x80000000): stub, harmless. Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to (nil) fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to 0x4c Installation of D:\palm desktop\Palm Desktop.msi (SETUPEXEDIR=D:\palm desktop) failed. err:dc:DCE_FreeWindowDCE [0x20024] GetDC() without ReleaseDC()! I tried to find info on the web about 'Palm OS Desktop installation & Wine' without success... Is it possible to do install the 'Palm OS Desktop' CD with Wine and/or any idea for my problem ? Thanks a lot, regards, Francois

6 10

Re: [AppDB] mysql_query -> appdb_query in /include
by Paul van Schayck Jan. 11, 2005

Jan. 11, 2005

Hey Jonathan, On Tue, 11 Jan 2005 00:59:44 +0100, Jonathan Ernst <Jonathan(a)ernstfamily.ch> wrote: > This patch replaces nearly all mysql_query with appdb_query in /include. We should use query_userdb() in include/user.php. We're allowing a seperate database for it. This patch was already applied tough: http://www.winehq.org/hypermail/wine-cvs/2005/01/0257.html But also your previous mysql_query patch is using query_appdb where it should use query_userdb(). Or will we just start dropping that second database? It seems like the live server did not seperate them. Jeremy can you confirm? Paul

2 1

(Job) Two Embedded Positions - S. CALIF
by Naren Jan. 11, 2005

Jan. 11, 2005

I have 2 embedded positions in this email: Position 1) Embedded Engineer - S. California This is my direct client opening - I need an Embedded Engineer for my client in S. California - 6 months contract to hire position I need an Embedded Engineer, as follows: Minimum of five years experience in developing embedded management systems for telecom/datacom products. Proven track record in C++ and Linux programming. Strong hands-on design knowledge of SNMP, web browser and IP based network management architectures applying Ethernet, RS-232 and I2C protocols is required. This is a Full time Permanent FTE position with the client in S. CA. Salary being offered is $80K - $90K per year, with standard benefits. Very stable company with a great working atmosphere. Client would prefer to have local US citizens or GC Holders only (but may be open to H1 Visa transfer for the right individual). Client prefers not to pay for relocation for this position. Please complete and copy/paste this completed skills-matrix to me with your response: Full name: Total IT exp: Total Embedded Engineer exp: Total Embedded telecom products exp: Total Embedded datacom products exp: Total C++ exp: Total Linux exp: Total SNMP exp: Total web browser programming exp: Total IP based network protocols exp: Specify protocols used: Degree Major: Are you a US citizen or GC holder (Y/N): Specify: What percentage of a fit are you, based on the above job description?: Are the above skills reflected in your resume? (Please ensure you send me a resume that shows all the above skills) Salary required: Day Tel# Eve Tel# Cell number: Availability: Your current City / State: If you qualify for this position, are available immediately and are interested, please send your resume, rate and contact information to mailto:ResumeCGT9(a)cgt-consult.com?subject=Embedded-Eng-S-CA Please ensure you complete and copy/paste the above completed matrix with your response. Position 2) Embedded Linux Networking Systems Engineer - Los Angeles This is my direct client opening - I need an Embedded Linux Networking Systems Engineer for my client in S. California - Full time permanent position I need an Embedded Linux Networking Systems Engineer, as follows: PRINCIPAL FUNCTIONS · Embedded system architecture definition and design with particular emphasis on standard and tailored MAC (Medium Access Control) layer protocols. · Design, modify and implement Linux device drivers for wireless physical interfaces. · Design, modify and guide the implementation of tools for testing and user network configuration and administration. · Design and guide the selection and implementation of IP security algorithms and processes. · Support Sales and Product Management as required. JOB SKILLS · Must understand software/firmware development and testing strategies. · Proficiency in GNU C++ Compiler, Real-time programming concepts, Linux drivers. . Experience in Python and/or Visual C++ in Windows is a bonus. · Fundamental understanding of wireless networking and 802.11x standards. · A working knowledge of IP security techniques. · Technical knowledge of IP routing protocols and algorithms (RIP2, OSPF, OLSR, BGP) · Working knowledge of internet standards and protocols, MAC Layer concepts, scheduling algorithms and routing algorithms. · Familiar with Linux Kernel, Red Hat and Fedora. QUALIFICATIONS · Must recently have had the responsibilities of Embedded System or Design Engineer. · BS or Masters, or equivalent, in Electrical Engineering, Computer Science or Physics. This is a Full time Permanent FTE position with the client in Los Angeles, S. CA. Salary being offered is $80K - $90K per year, with standard benefits. Very stable company with a great working atmosphere. Client would prefer to have local US citizens or GC Holders only. There is no relocation available for this position. Please complete and copy/paste this completed skills-matrix to me with your response: Full name: Total IT exp: Total MAC layer protocols exp: Total Wireless exp: Specify (CDMA, 802.11x): Total IP security algorithms and processes exp: Total IP security protocols exp: Specify: Total Linux exp: Total Routing exp: Total Python exp: Total VC++ exp: Degree Major: Are you a US citizen or GC holder (Y/N): Specify: What percentage of a fit are you, based on the above job description?: Are the above skills reflected in your resume? (Please ensure you send me a resume that shows all the above skills) Salary required: Day Tel# Eve Tel# Cell number: Availability: Your current City / State: If you qualify for this position, are available immediately and are interested, please send your resume, rate and contact information to mailto:ResumeCGT9(a)cgt-consult.com?subject=Embed-Linux-Network-Sys-Eng Please ensure you complete and copy/paste the above completed matrix with your response. Please click here to view all other openings from CGT Consulting: http://www.cgt-consult.com/displayjobs.asp PS - If you know of other groups where I can post these jobs, I would welcome such suggestions. The more candidates who get the opportunity to review our opening the more candidates we can help find a job!! I am only looking for job sites, which cater for US candidates only. PSS - If you want to receive future real-time IT job notifications, from CGT Consulting Inc., via email, go to: <http://www.cgt-consult.com/join-cgt-groups.htm> and sign up to receive such notifications, based on your skills. Subscribe to receive ALL job postings or openings for only your specific background. Feel free to refer your friends, who are looking for a job to the above groups!! Please feel free to forward this email to anybody whom you know would be interested or is looking for a job and can benefit from joining our job groups. Expand your job search and send your resume to over 3,000 recruiters - http://www.ResumeAgencies.com CGT Consulting Privacy Policy: <http://www.cgt-consult.com/privacy> Can Spam Compliant To opt-out of future correspondence, please send an email to mailto:cgt(a)cgt-consult.com?subject=Remove-Embededd or reply with "REMOVE" in the subject heading and include in the body of your email. Email-id: wine-devel(a)winehq.com

1 0

OXID marshaling error
by Bill Medland Jan. 11, 2005

Jan. 11, 2005

Any idea what is going wrong in the OXID handling here? Is "a" the first thread of the new process? Is the problem that it should be "b"? (I've removed a few extraneous traces) (This is after the COM_CreateApartment fixes patch) 0009:trace:ole:create_marshalled_proxy rclsid={4dfceca2-156a-4e02-9d02-2e5253ad1d01}, iid={00000001-0000-0000-c000-000000000046} 0009:trace:ole:create_marshalled_proxy waiting for \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:trace:ole:create_server activating local server 'L"G:\\runtime\\a4wlpmgr.exe -Embedding"' for {4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:trace:ole:create_marshalled_proxy waiting for \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:warn:ole:create_marshalled_proxy Could not open named pipe to broker \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01}, le is 2 000b:trace:ole:DllMain 0x540000 0x1 0x1 0009:trace:ole:create_marshalled_proxy waiting for \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01} 0009:warn:ole:create_marshalled_proxy Could not open named pipe to broker \\.\pipe\{4DFCECA2-156A-4E02-9D02-2E5253AD1D01}, le is 2 000b:trace:ole:CoInitializeEx ((nil), 0) 000b:trace:ole:CoInitializeEx () - Initializing the COM libraries 000b:trace:ole:RunningObjectTableImpl_Initialize () 000b:trace:ole:COM_CreateApartment thread 0xb is entering the multithreaded apartment 000b:trace:ole:CoRegisterClassObject ({4dfceca2-156a-4e02-9d02-2e5253ad1d01},0x405701a0,0x00000004,0x00000005,0x412054) 000b:trace:ole:CoMarshalInterface (0x4006b7a0, {00000001-0000-0000-c000-000000000046}, 0x405701a0, 0, (nil), 1) 000b:trace:ole:CoGetStandardMarshal ({00000001-0000-0000-c000-000000000046},0x405701a0,0,(nil),1,0x51fd84) 000b:trace:ole:CoMarshalInterface Using standard marshaling 000b:trace:ole:CoMarshalInterface Calling IMarshal::MarshalInterace 000b:trace:ole:StdMarshalImpl_MarshalInterface (...,{00000001-0000-0000-c000-000000000046},...) 000b:trace:ole:start_apartment_listener_thread apt->listenertid=0 000d:trace:ole:apartment_listener_thread Apartment listener thread starting on (\\.\pipe\WINE_OLE_StubMgr_0000000a00000000) 000b:trace:ole:CoGetPSClsid () riid={00000001-0000-0000-c000-000000000046}, pclsid=0x51fd18 000b:trace:ole:CoGetPSClsid () Returning CLSID={00000320-0000-0000-c000-000000000046} 000b:trace:ole:CoGetClassObject CLSID: {00000320-0000-0000-c000-000000000046}, IID: {d5f569d0-593b-101a-b569-08002b2dbf7a} 000b:trace:ole:COMPOBJ_DLLList_Add 000b:trace:ole:PSFacBuf_CreateStub ({00000001-0000-0000-c000-000000000046},0x405701a0,0x51fd10) 000b:fixme:ole:StdMarshalImpl_MarshalInterface table marshalling unimplemented 000b:warn:ole:get_stub_manager_from_object Could not map OXID a00000000 to apartment object 000b:trace:ole:register_ifstub constructing new stub manager 000b:warn:ole:register_ifstub Could not map OXID a00000000 to apartment object -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

2 2

Re: USER32: cursoricon
by Alexandre Julliard Jan. 11, 2005

Jan. 11, 2005

Vitaly Lipatov <lav(a)etersoft.ru> writes: > Changelog: > return fail if file format is unknown This will make it fail for all normal cursor/icon files. These don't have a header so you can't check a magic number. -- Alexandre Julliard julliard(a)winehq.org

2 2

ole32: questions about the COINIT flags
by Paul Vriens Jan. 11, 2005

Jan. 11, 2005

Hi, I was looking through some MSDN doc: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cm… there it's stated that: If neither concurrency model is specified by the dwCoInit parameter, the default is COINIT_MULTITHREADED. Does this mean we should change the way we interpret these flags (in compobj.c for example) because COINIT_MULTITHREADED equals 0 (which is a bit strange value for a flag)? The native QUARTZ.DDL calls CoInitializeEx with a COINIT of 4 which effectively has the COINIT_DISABLE_OLE1DDE and the COINIT_MULTITHREADED flags set. Shouldn't we have a check for COINIT_APARTMENTTHREADED and if this flag is not set we have to assume COINIT_MULTITHREADED? Especially because both these flags cannot be set at the same time (see mentioned MSDN doc). Cheers, Paul.

2 1

Re: [QUARTZ] Get rid of a CLSID fixme
by Christian Costa Jan. 11, 2005

Jan. 11, 2005

> Message du 11/01/05 13:50 > De : "Paul Vriens" > A : "wine-patches(a)winehq.org" > Copie à : "Christian Costa" > Objet : [QUARTZ] Get rid of a CLSID fixme > Hi, > > just needed an extra CLSID in the registry to avoid some fixme's: > > fixme:ole:CoCreateInstance no classfactory created for CLSID > {060af76c-68dd-11d0-8fc1-00c04fd9189d} As long as this object is not implemented, the FIXME should remain to remind us that something is missing from quartz. Bye, Christian

1 0

wine alsa detection
by Joris Huizer Jan. 11, 2005

Jan. 11, 2005

Hello, Today I switched back to alsa 0.9 (downgraded everything that had to do with alsa 1.0 as far as I can tell) but still, alsa is detected as available: checking alsa/asoundlib.h usability... yes checking alsa/asoundlib.h presence... yes checking for alsa/asoundlib.h... yes checking for snd_pcm_open in -lasound... yes And wine breaks when compiling wine alsa - then it does all the compiling again as dependencies are assumed to be wrong -- finally breaking again at the same place; Are you sure your configuration patch tests for those failing functions? I attached a log of it failing with wine 0.9 - maybe you have to test for some (all??) of those? If you have reason to think I forgot something when downgrading, please tell me what it was (I'm using debian/stable - with added unofficial alsa packages, of http://afavant.elte.hu/~wferi/lilypond/, as suggested earlier on the list ) regards, Joris

2 3

Re: Janitorial : Use Compiler Warnings ( -Wmissing-declarations ) ( #1, take 2 )
by Alexandre Julliard Jan. 11, 2005

Jan. 11, 2005

Rémi Assailly <remi.assailly(a)free.fr> writes: > diff -u libs/wine/debug.c libs/wine/debug.c > --- libs/wine/debug.c 2005-01-10 20:12:34.748897920 +0100 > +++ libs/wine/debug.c 2005-01-10 19:18:26.000000000 +0100 > @@ -61,6 +61,9 @@ > return strcmp( name, *chan + 1 ); > } > > +void *__wine_dbg_register( char * const *channels, int nb ); > +void __wine_dbg_unregister( void *channel ); This is useless, please don't add such code only to quiet optional warnings. > diff -u include/wine/unicode.h include/wine/unicode.h > --- include/wine/unicode.h 2005-01-09 12:09:03.000000000 +0100 > +++ include/wine/unicode.h 2005-01-10 19:23:51.000000000 +0100 > @@ -95,6 +95,8 @@ > extern int vsprintfW( WCHAR *str, const WCHAR *format, va_list valist ); > extern int vsnprintfW( WCHAR *str, size_t len, const WCHAR *format, va_list valist ); > > +extern int get_decomposition(WCHAR src, WCHAR *dst, unsigned int dstlen); > + get_decomposition is an internal function, it shouldn't be exported in the public header. -- Alexandre Julliard julliard(a)winehq.org

1 0