November 2005 - Wine-Devel - list.winehq.org

GetOpenFileNameA has trouble with UTF-8 locale and UTF-8 encoded pathname
by Alex Villacís Lasso Nov. 22, 2005

Nov. 22, 2005

Consider the following MSVC program: --------------------- cut ------------------------- // PruebaOpenDlg.cpp : Defines the entry point for the console application. // #include <stdio.h> #include <stdlib.h> #include <errno.h> #include <windows.h> int main(int argc, char* argv[]) { OPENFILENAME ofn; // common dialog box structure char szFile[260]; // buffer for file name // Initialize OPENFILENAME ZeroMemory(&ofn, sizeof(OPENFILENAME)); ofn.lStructSize = sizeof(OPENFILENAME); ofn.hwndOwner = NULL; ofn.lpstrFile = szFile; ofn.nMaxFile = sizeof(szFile); ofn.lpstrFilter = "All\0*.*\0Text\0*.TXT\0"; ofn.nFilterIndex = 1; ofn.lpstrFileTitle = NULL; ofn.nMaxFileTitle = 0; ofn.lpstrInitialDir = NULL; // ofn.Flags = OFN_PATHMUSTEXIST | OFN_FILEMUSTEXIST; // Display the Open dialog box. memset(szFile, 0, sizeof(szFile)); if (GetOpenFileName(&ofn)==TRUE) { char * p; FILE * hFile; printf("Chosen filename is: %s\n", ofn.lpstrFile); printf("Byte encoding is :"); for (p = ofn.lpstrFile; *p; p++) { printf(" (%c %02x)", *p, *p); } printf("\n"); hFile = fopen(ofn.lpstrFile, "rb"); if (hFile != NULL) { fclose(hFile); puts("File is readable through specified filename"); } else { printf("Unable to reach file through %s - %s\n", ofn.lpstrFile, strerror(errno)); } } return 0; } --------------------- cut ------------------------- Consider also the following Linux environment: home directory is /home/alex, and is mapped to drive F: in dosdevices. The home directory contains a directory named gatón (the string contains a [U+00F3 LATIN SMALL LETTER O WITH ACUTE] and is UTF-8 encoded as 0x67 0x61 0x74 0xC3 0xB3 0x6E), inside of which a sample file exists, which is to be selected by the Open File dialog. All tests were made in a Fedora Core 4 system with a *default* LANG=es_EC.UTF-8. The symptom is that, when wine runs with an UTF-8 locale (as specified with the LANG environment variable), and an attempt is made to choose a filename that is UTF-8 encoded in the filesystem, GetOpenFileNameA may return a byte string that CreateFile and other file functions are unable to map into a valid filename. Whether GetOpenFileNameA returns a valid filename or not seems to depend on the way the navigation is performed. That is, if the application starts the Open File dialog from the current directory, and the user navigates by directory change only, the invalid filename will be returned. However, if the user first chooses a drive letter (such as F:) and then navigates from there, the filename returned is a valid one. The following tests illustrate the behavior. For each entry, the first two lines are the conditions for the test. The remaining three lines are the actual output from the supplied program, copied and pasted from the console. The instances of \uffff seen are from invalid character encodings displayed in the console. LANG=en_US From current directory /home/alex: Chosen filename is: f:\gatón\Barenaked Ladies - One Week.mp3 Byte encoding is : (f 66) (: 3a) (\ 5c) (g 67) (a 61) (t 74) (\uffff ffffffc3) (\uffff ffffffb3) (n 6e) (\ 5c) (B 42) (a 61) (r 72) (e 65) (n 6e) (a 61) (k 6b) (e 65) (d 64) ( 20) (L 4c) (a 61) (d 64) (i 69) (e 65) (s 73) ( 20) (- 2d) ( 20) (O 4f) (n 6e) (e 65) ( 20) (W 57) (e 65) (e 65) (k 6b) (. 2e) (m 6d) (p 70) (3 33) File is readable through specified filename LANG=en_US From explicit choice from drive F: : Chosen filename is: F:\gatón\Barenaked Ladies - One Week.mp3 Byte encoding is : (F 46) (: 3a) (\ 5c) (g 67) (a 61) (t 74) (\uffff ffffffc3) (\uffff ffffffb3) (n 6e) (\ 5c) (B 42) (a 61) (r 72) (e 65) (n 6e) (a 61) (k 6b) (e 65) (d 64) ( 20) (L 4c) (a 61) (d 64) (i 69) (e 65) (s 73) ( 20) (- 2d) ( 20) (O 4f) (n 6e) (e 65) ( 20) (W 57) (e 65) (e 65) (k 6b) (. 2e) (m 6d) (p 70) (3 33) File is readable through specified filename LANG=es_EC From current directory /home/alex: Chosen filename is: f:\gatón\Barenaked Ladies - One Week.mp3 Byte encoding is : (f 66) (: 3a) (\ 5c) (g 67) (a 61) (t 74) (\uffff ffffffc3) (\uffff ffffffb3) (n 6e) (\ 5c) (B 42) (a 61) (r 72) (e 65) (n 6e) (a 61) (k 6b) (e 65) (d 64) ( 20) (L 4c) (a 61) (d 64) (i 69) (e 65) (s 73) ( 20) (- 2d) ( 20) (O 4f) (n 6e) (e 65) ( 20) (W 57) (e 65) (e 65) (k 6b) (. 2e) (m 6d) (p 70) (3 33) File is readable through specified filename LANG=es_EC From explicit choice from drive F: : Chosen filename is: F:\gatón\Barenaked Ladies - One Week.mp3 Byte encoding is : (F 46) (: 3a) (\ 5c) (g 67) (a 61) (t 74) (\uffff ffffffc3) (\uffff ffffffb3) (n 6e) (\ 5c) (B 42) (a 61) (r 72) (e 65) (n 6e) (a 61) (k 6b) (e 65) (d 64) ( 20) (L 4c) (a 61) (d 64) (i 69) (e 65) (s 73) ( 20) (- 2d) ( 20) (O 4f) (n 6e) (e 65) ( 20) (W 57) (e 65) (e 65) (k 6b) (. 2e) (m 6d) (p 70) (3 33) File is readable through specified filename LANG=es_EC.UTF-8 From current directory /home/alex: Chosen filename is: f:\gatón\Barenaked Ladies - One Week.mp3 Byte encoding is : (f 66) (: 3a) (\ 5c) (g 67) (a 61) (t 74) (\uffff ffffffc3) (\uffff ffffffb3) (n 6e) (\ 5c) (B 42) (a 61) (r 72) (e 65) (n 6e) (a 61) (k 6b) (e 65) (d 64) ( 20) (L 4c) (a 61) (d 64) (i 69) (e 65) (s 73) ( 20) (- 2d) ( 20) (O 4f) (n 6e) (e 65) ( 20) (W 57) (e 65) (e 65) (k 6b) (. 2e) (m 6d) (p 70) (3 33) Unable to reach file through f:\gatón\Barenaked Ladies - One Week.mp3 - No such file or directory LANG=es_EC.UTF-8 From explicit choice from drive F: : Chosen filename is: F:\gat\uffffn\Barenaked Ladies - One Week.mp3 Byte encoding is : (F 46) (: 3a) (\ 5c) (g 67) (a 61) (t 74) (\uffff fffffff3) (n 6e) (\ 5c) (B 42) (a 61) (r 72) (e 65) (n 6e) (a 61) (k 6b) (e 65) (d 64) ( 20) (L 4c) (a 61) (d 64) (i 69) (e 65) (s 73) ( 20) (- 2d) ( 20) (O 4f) (n 6e) (e 65) ( 20) (W 57) (e 65) (e 65) (k 6b) (. 2e) (m 6d) (p 70) (3 33) File is readable through specified filename Case 5 is incorrect, but is the easiest to hit in the UTF-8 locales. This problem is significant because all Fedora distributions since at least Fedora Core 2 have UTF-8 support, which is probably enabled in non-US locales. Other popular distributions probably have this UTF-8 support enabled too. I am posting this on wine-devel instead of creating a bug report because I wanted to receive some comments on what the expected behavior should be before trying to submit a patch myself. Unless somebody says otherwise, I would try to submit a patch that makes case 5 behave like case 6, by modifying the encoding of the ANSI string to match what the file-open functions would expect for the filename. However, this essentially requires an answer to the following question: should non-Unicode strings that represent filenames be UTF-8 encoded, or locale encoded? In the UTF-8 locales, GetOpenFileNameA seems to think UTF-8 encoded sometimes, but the file open functions expect locale-encoded (in my case is ISO-8859-1). Therefore, the incorrect behavior. How would the answer change (if at all) for Chinese or Japanese locales with a need for multibyte characters? Alex Villacís Lasso

4 6

Re: Wine bug id 3900
by Dimi Paun Nov. 22, 2005

Nov. 22, 2005

From: " Andrew Webb" <andrew7webb(a)comcast.net> > I think I have the right format for a patch. But if not, please be > patient as its my first attempt. Andrew, it seems to me the patch is wrapped. The easiest way to avoid the wrapping would be to simply attach it as a text file. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Fwd: Re: MBR was destroyed
by seorge Nov. 22, 2005

Nov. 22, 2005

Please tell me, what exact information should I provide the developers with the experiment described below. I really want to help, but I also don't want to play with my data without understanding what exactly is needed from me. Thanks in advance! ---------- Forwarded Message ---------- > Ok, and can restore ~/.wine dir to previous state (maybe "rm -rf ~/.wine > && wineprefixcreate" would help) and reproduce this bug again, please? I've removed my previous .wine dirrectory, so the only thing I can do is to reproduce everything happend with me yesturday: 1. try to launch some win32 application - this will create .wine 2. try to setup disks and change labels. As I undestand after this experiment I need to send something or at the mailing list from the content of the .wine. Please tell me what it should be.

5 7

Re: error of double click chinese name txt file in softwares (e.g winefile, WinRAR)
by Paul Vriens Nov. 22, 2005

Nov. 22, 2005

On Tue, 2005-11-22 at 15:02 +0800, mengzhuo li wrote: > ChangeLog: > dlls/kernel/process.c > > limengzhuo muziwind(a)yahoo.com.cn > > fix the error of double clicking chinese name txt file in software > (e.g. winfile). > > it shows the error > wine: cannot open builtin library for L"C:\\windows\\\6d4b\8bd5.txt" > > ______________________________________________________________________ > 无限容量雅虎相册，原图等大下载，超快速度，赶快抢注！ > plain text document attachment > (fix-crash-of-double-click-chinese-name-txt-in-softwares.diff), > "3670824031-fix-crash-of-double-click-chinese-name-txt-in-softwares.diff" > ? fix-crash-of-double-click-chinese-name-txt-in-softwares.diff > Index: dlls/kernel/process.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel/process.c,v > retrieving revision 1.109 > diff -u -p -r1.109 process.c > --- dlls/kernel/process.c 10 Oct 2005 10:28:48 -0000 1.109 > +++ dlls/kernel/process.c 22 Nov 2005 06:31:07 -0000 > @@ -247,6 +247,8 @@ static BOOL find_exe_file( const WCHAR * > enum loadorder_type loadorder[LOADORDER_NTYPES]; > int i, file_exists; > > + file_exitst = 0; > + Did you actually compile this ? (exists != exitst) Paul.

1 0

Re: error of double click chinese name txt file in softwares (e.g winefile, WinRAR)
by Andreas Mohr Nov. 22, 2005

Nov. 22, 2005

Hi, On Tue, Nov 22, 2005 at 03:02:16PM +0800, mengzhuo li wrote: > ChangeLog: > dlls/kernel/process.c > > limengzhuo muziwind(a)yahoo.com.cn > > fix the error of double clicking chinese name txt file in software (e.g. winfile). > > it shows the error > wine: cannot open builtin library for L"C:\\windows\\\6d4b\8bd5.txt" Thanks for the patch, but have you actually tested it and verified it to work? The spelling of the variable suggests you haven't... > int i, file_exists; > > + file_exitst = 0; Andreas Mohr

1 0

Re: [wined3d] pixel shader cross compiler [3] resend
by Ivan Gyurdiev Nov. 22, 2005

Nov. 22, 2005

> +typedef FLOAT D3DMATRIX44[4][4]; > +typedef FLOAT D3DMATRIX43[4][3]; > +typedef FLOAT D3DMATRIX34[4][4]; > +typedef FLOAT D3DMATRIX33[4][3]; > +typedef FLOAT D3DMATRIX32[4][2]; > Are those matrices bigger than they should be, or is this intentional? Also, all the matrices that have size(x)!=size(y) seem backwards to be - maybe I'm misunderstanding, but I think your x and y indices are backwards in functions using m2x3, m3x4 and m4x3, and will segfault (but then again, I haven't tried it, so I could be wrong). Additionally: +void pshader_m3x4(WINED3DSHADERVECTOR* d, WINED3DSHADERVECTOR* s0, D3DMATRIX34 mat) { + d->x = mat[0][0] * s0->x + mat[0][1] * s0->y + mat[0][2] * s0->z; + d->y = mat[2][0] * s0->x + mat[1][1] * s0->y + mat[1][2] * s0->z; + d->z = mat[2][0] * s0->x + mat[2][1] * s0->y + mat[2][2] * s0->z; + d->w = mat[3][0] * s0->x + mat[3][1] * s0->y + mat[3][2] * s0->z; Wrong index, second row. +void pshader_m3x3(WINED3DSHADERVECTOR* d, WINED3DSHADERVECTOR* s0, D3DMATRIX33 mat) { + d->x = mat[0][0] * s0->x + mat[0][1] * s0->y + mat[2][2] * s0->z; + d->y = mat[1][0] * s0->x + mat[1][1] * s0->y + mat[2][2] * s0->z; + d->z = mat[2][0] * s0->x + mat[2][1] * s0->y + mat[2][2] * s0->z; + d->w = 1.0f; + PSTRACE(("executing m3x3(1): mat=(%f, %f, %f) s0=(%f) d=(%f) \n", mat[0][0], mat[0][1], mat[0][2], s0->x, d->x)); + PSTRACE(("executing m3x3(2): mat=(%f, %f, %f) (%f) (%f) \n", mat[1][0], mat[1][1], mat[1][2], s0->y, d->y)); + PSTRACE(("executing m3x3(3): mat=(%f, %f, %f) X (%f) = (%f) \n", mat[2][0], mat[2][1], mat[2][2], s0->z, d->z)); + PSTRACE(("executing m3x3(4): (%f) \n", d->w)); +} Wrong index, second row. In pshader_lrp... I wouldn't know if the 4th row is a bug or not, but I'm suspicious.

2 2

Re: WINEMAILER: a new winelib app
by Alexandre Julliard Nov. 22, 2005

Nov. 22, 2005

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog > Added winemailer, a winelib app that wraps the native OS > mail client. I think this could just as well go into winebrowser, it's really a very similar functionality. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine and automation objects
by Curro Amores Nov. 22, 2005

Nov. 22, 2005

hi, I have an application with Access 97 and i use automation for some aspects. The app runs perfectly but when i want to do something that uses automation it crashes. Anybody could help me? thanks

3 2

windows.h
by Steven Edwards Nov. 22, 2005

Nov. 22, 2005

Hi All, I don't understand the reason we are still manually including each header in most of the sources. Its like totally incompatible with the latest PSDK unless you add a define for _X86_. We are getting to the point in some of the sources where we might as well just include Windows.h becuase we already include all of the files it includes or close enough to them. Can someone explain the reason to me we are still manually messing with a lot of these headers? Thanks Steven P.S. I have even read threads online where Microsoft's Visual Studio developers tell the users NOT to manually include WinNT, WinBase, etc.

2 1

Licensing and technical issues with a Wine package that includes the Mozilla ActiveX Control
by Scott Ritchie Nov. 22, 2005

Nov. 22, 2005

Greetings, As part of my work to create the ultimate works-out-of-the-box Wine package, I've begun to ponder the idea of including the Mozilla ActiveX control inside the Wine package. Currently, to install applications that use Internet Explorer internally, such as Steam, the user has to download the Mozilla ActiveX control as a tar file and then manually register the DLL to get Wine to use it (see the Howto in the AppDB entry here: http://appdb.winehq.org/appview.php?versionId=1554 ) Modifying Wine to recognize when the Mozilla ActiveX Control is installed without having to register it manually should be easy enough, however distributing it with the Wine package or as a separate side package presents an unusual licensing issue. Now, the Mozilla ActiveX control is freely licensed, and we can redistribute it however we please. Unfortunately, to make it work in Wine we also need to use the dlls for the Microsoft Foundation Classes that it's written in such as msvcp70.dll, as Wine does not currently implement those. These files have an unusual license. Someone who owns the compiler (such as MSVC 7) is allowed to distribute them, however redistribution further from there isn't necessarily allowed, as the person receiving the file doesn't have a license to redistribute like the EULA for the compiler grants. This doesn't seem to prevent us from giving out the package with the DLL included, however users wouldn't be able to redistribute it. This sounds much like the way the situation is with the NVidia drivers. Would building the package be the right way to go here, with the ultimate destination being the restricted copyright repository in Ubuntu? Or is there something I'm overlooking here (perhaps reading the license wrong)? Thanks, Scott Ritchie

6 7

[BugZilla] adding usefull functionnalities
by Raphael Nov. 21, 2005

Nov. 21, 2005

Hi, can we have a "Meta Bugs" fast access on "Task Lists" who group all known meta bugs ? (better than txt file i use) Thx Regards, Raphael

1 0

Re: PATCH: dlls/winsock/socket.h portability fix
by Alexandre Julliard Nov. 21, 2005

Nov. 21, 2005

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > ChangeLog: > On some systems like FreeBSD, EAI_NODATA is defined in <lwres/netdb.h>, > so include this if present. Why isn't it in netdb.h? And if we get it from lwres shouldn't we then link to liblwres? -- Alexandre Julliard julliard(a)winehq.org

2 4

usb driver proxy
by Maris Paupe Nov. 21, 2005

Nov. 21, 2005

Hi, First of all, sorry for my bad English. I have a USB device which doesn' t have a driver in linux, I wrote it as kernel module, but because I want to run windows software under wine which uses this device it seems that I will need to write something like proxy in wine (like audio and video drivers are written) to enable my software to use this device. Right now I am planning to rewite this driver using libusb and implement everything in wine's proxy. Maybe somebody have some dummy driver for purposes like this or I sould just take audio or some other driver and use it as starting point, maybe you have some useful suggestions to give me before I start?

7 9

KERNEL: parsing /proc/scsi/scsi
by Saulius Krasuckas Nov. 21, 2005

Nov. 21, 2005

While running my wine I started getting this recently: $ ./wine --version | err:reg:SCSI_getprocentry SCSI type line scan count error | Wine 0.9.1 Next: $ uname -r | 2.6.14-1.1637_FC4 $ cat /proc/scsi/scsi | Attached devices: | Host: scsi0 Channel: 00 Id: 00 Lun: 00 | Vendor: PLEXTOR Model: DVDR PX-712A Rev: 1.04 | Type: CD-ROM ANSI SCSI revision: ffffffff Next: $ dmesg | grep -C1 PLEXTOR.*1.04 | scsi0 : SCSI host adapter emulation for IDE ATAPI devices | Vendor: PLEXTOR Model: DVDR PX-712A Rev: 1.04 | Type: CD-ROM ANSI SCSI revision: 00 Strange difference. If I search for a "ANSI SCSI revision" string, I get: $ grr "ANSI SCSI revision" linux-2.6.14/ | linux-2.6.14/drivers/block/acsi.c: printk(" ANSI SCSI revision: %02x", data[2] & 0x07); | linux-2.6.14/drivers/scsi/megaraid.c: " ANSI SCSI revision: %02x", scsi_inq[2] & 0x07); | linux-2.6.14/drivers/scsi/scsi_scan.c: printk(" ANSI SCSI revision: %02x", I am not sure, why this happens, as I see no code which forms "scsi/scsi" proc-file content, but still I think it is bug in our parser: $ grep -B6 "SCSI type line scan count error" dlls/kernel/oldconfig.c | result = fscanf( procfile, | " Type:%*3[ ]%32c%*1[ ]ANSI%*1[ ]SCSI%*1[ ]revision:%*1[ ]%d\n", | dev->type, | &dev->ansirev ); | if( result != 2 ) | { | ERR("SCSI type line scan count error\n"); where parser treats last number as a decimal one, while it is in hexadecimal format. I would appreaciate explanation, why dmesg and /proc/scsi/scsi writer behaves in slightly different ways.

2 1

Repeat message - Why was the included patch rejected?
by Robert Lunnon Nov. 21, 2005

Nov. 21, 2005

This message never seemed to make it to the list so here is a resend ========================================================== Anyone know why this patch wasn't applied ? I don't know about anyone else but I'm still getting va_list undeclared. Bob ---------- Forwarded Message ---------- Subject: [winternl.h]Add missing header file Date: Friday 11 November 2005 03:29 From: Sütő Gergely <geri(a)aplusnet.hu> To: wine-patches(a)winehq.org ChangeLog: Add a missing stdarg.h includes. This is my first patch please check it! :) BYe: Geri_ ------------------------------------------------------- winternl_h.diff

2 2

Fwd: [winternl.h]Add missing header file
by Robert Lunnon Nov. 21, 2005

Nov. 21, 2005

Anyone know why this patch wasn't applied ? I don't know about anyone else but I'm still getting va_list undeclared. Bob ---------- Forwarded Message ---------- Subject: [winternl.h]Add missing header file Date: Friday 11 November 2005 03:29 From: Sütő Gergely <geri(a)aplusnet.hu> To: wine-patches(a)winehq.org ChangeLog: Add a missing stdarg.h includes. This is my first patch please check it! :) BYe: Geri_ -------------------------------------------------------

4 3

Re: widl: Properly dereference the out parameter when copying
by Alexandre Julliard Nov. 21, 2005

Nov. 21, 2005

James Hawkins <truiken(a)gmail.com> writes: > Anything wrong with this patch? > > Changelog > * Properly dereference the out parameter when copying. It seems to me that if you dereference the variable then you should remove the dereference in the typecast, otherwise the types won't match. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: SHELL32_GetItemAttributes() [resend]
by Alexandre Julliard Nov. 21, 2005

Nov. 21, 2005

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Changelog: > correctly call HCR_GetFolderAttributes() in SHELL32_GetItemAttributes() It breaks the tests here: shlfolder.c:671: Test failed: SHGetPathFromIDList succeeded where it shouldn't! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Add a test showing that SaveDC after GetDC should return 1
by Alexandre Julliard Nov. 21, 2005

Nov. 21, 2005

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > +todo("windows") > +{ /* XP returns COMPLEXREGION although dump_region reports only 1 rect */ > + ok(ret == SIMPLEREGION, "IntersectClipRect returned %d instead of SIMPLEREGION\n", ret); > +} It doesn't make sense to add a todo for Windows, we won't be able to fix the bug there... -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: wine/dlls/comctl32 syslink.c
by Thomas Weidenmueller Nov. 21, 2005

Nov. 21, 2005

@@ -1666,9 +1712,8 @@ */ VOID SYSLINK_Register (void) { - WNDCLASSW wndClass; + WNDCLASSW wndClass = {0}; - ZeroMemory (&wndClass, sizeof(wndClass)); wndClass.style = CS_GLOBALCLASS | CS_VREDRAW | CS_HREDRAW; wndClass.lpfnWndProc = SysLinkWindowProc; wndClass.cbClsExtra = 0; Is there a reason this change wasn't applied? Calling ZeroMemory is slower and prevents certain optimizations by the compiler. - Thomas

2 1

Spelling error?
by Saulius Krasuckas Nov. 21, 2005

Nov. 21, 2005

This one comes from old Erics patch, and I may be wrong with a french language here, but wouldn't one name be spelled differently here? :-] Index: dlls/kernel/tests/process.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/tests/process.c,v retrieving revision 1.23 diff -p -u -r1.23 process.c --- dlls/kernel/tests/process.c 27 Oct 2005 10:25:49 -0000 1.23 +++ dlls/kernel/tests/process.c 21 Nov 2005 10:39:35 -0000 @@ -724,7 +725,7 @@ static void test_CommandLine(void) startup.dwFlags = STARTF_USESHOWWINDOW; startup.wShowWindow = SW_SHOWNORMAL; - /* from Frangois */ + /* from Francois */ get_file_name(resfile); sprintf(buffer, "%s tests/process.c %s \"a\\\"b\\\\\" c\\\" d", selfname, resfile); ok(CreateProcessA(NULL, buffer, NULL, NULL, FALSE, 0L, NULL, NULL, &startup, &info), "CreateProcess\n");

2 1

DirectX 8 wrapper update
by Oliver Stieber Nov. 21, 2005

Nov. 21, 2005

Hi, I've updated the directX 8 wrapper with a load more bug fixes notably Max payne 2 now works correctly. For anyone who's interested the update patch is avaialble here: https://sourceforge.net/project/shownotes.php?release_id=371929&group_id=13… Thanks, Oliver ___________________________________________________________ Yahoo! Model Search 2005 - Find the next catwalk superstars - http://uk.news.yahoo.com/hot/model-search/

5 13

Re: [wined3d] pixel shader cross compiler [2] resend
by Alexandre Julliard Nov. 21, 2005

Nov. 21, 2005

Oliver Stieber <oliver_stieber(a)yahoo.co.uk> writes: > const IWineD3DPixelShaderVtbl IWineD3DPixelShader_Vtbl = > { > @@ -118,5 +1824,7 @@ > /*** IWineD3DPixelShader methods ***/ > IWineD3DPixelShaderImpl_GetParent, > IWineD3DPixelShaderImpl_GetDevice, > - IWineD3DPixelShaderImpl_GetFunction > + IWineD3DPixelShaderImpl_GetFunction, > + /* not part of d3d */ > + IWineD3DPixelShaderImpl_SetFunction There are missing entries before SetFunction. -- Alexandre Julliard julliard(a)winehq.org

1 0

Another Multithreaded Direct3D biest??
by Stefan Dösinger Nov. 21, 2005

Nov. 21, 2005

Hello, After quite some time I returned to my D3D7->WineD3D work, and I gave Need for speed 3 a try. It's an old DirectX 5 game, with DirectDraw software rendering, Direct3D rendering and some hardware specific renderers. Need for speed 3 causes a crash in the GL library. A look at a +tid,+ddraw, +d3d trace shows that it creates a DirectDraw object in TID 0x9(No D3D involved), and then switches the graphics operations to another thread, 0xc. This thread sucessfully created and releases 2 DirectDraw and Direct3D objects. When the third WineD3D object is created, a crash in glXMakeCurrent in swapchain.c::IWineD3DDeviceImpl_CreateAdditionalSwapChain occurs. Is this a multithread problem? There's one thread change involved, but it occurs before the first Direct3D object is created. Does anyone know any not multithreaded Direct3D7(or previous) games, which do not rely on ProcessVertices?? Which games are working with the old D3D7 implementation? I have tried Empire Earth(Mulitthreaded), Half-Life 1 (ProcessVertices) and Need for Speed 3(Multithreaded??) now. Now I am running out of games :( Stefan

3 3

Fwd: MBR was destroyed
by seorge Nov. 21, 2005

Nov. 21, 2005

Hi, Since I'm not a developerr and therefore can't take part in any discussion here may I ask you to discuss the bug I reported, because Dustin Navea asked me to join this list. Or if nobody really need my presence here, please let me know and I will unsubscribe. Thanks in advance! ---------- Forwarded Message ---------- Subject: MBR was destroyed Date: Sunday 20 November 2005 08:49 From: seorge <seorge(a)gmail.com> To: wine-devel(a)winehq.org I've just submitted a bug (3889) about destroyed MBR and Dustin Navea asked me to subscribe to this list. Here comes some detailed description: As a regular user I've launched winecfg as a regular user, then proceeded to the dist setup. I've tried several options like automatic configuration, manual configuration. Then I've tried to change some drive letters manually. After reboot a "PRESS A KEY TO REBOOT" message appeared instead of a GRUB screen. Next time I booted with grub-floppy and then restored the MBR with grub-install /dev/hda. Please let me know what additional information you need. It's happend on Slackware 10.2 system, 2.6.14 kernel with ck-3 patches. -------------------------------------------------------

4 3

Re: [advpack/setupapi] LaunchINFSection
by Robert Shearman Nov. 21, 2005

Nov. 21, 2005

Raphael wrote: > Changelog: > - semi implementation of advpack APIs LaunchINFSection/LaunchINFSectionEx > - semi implementation of advpack API ExtractFiles > - setupapi: correct and check pExtractFiles return code > > I have a few comments: >------------------------------------------------------------------------ >@@ -91,30 +105,132 @@ > } > > /*********************************************************************** >- * LaunchINFSection (ADVPACK.@) >- */ >-void WINAPI LaunchINFSection( HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show ) >-{ >- FIXME("(%p %p %s %d): stub\n", hWnd, hInst, debugstr_a(cmdline), show ); >-} >- >-/*********************************************************************** > * LaunchINFSectionEx (ADVPACK.@) > */ >-void WINAPI LaunchINFSectionEx( HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show ) >+static UINT LaunchINFSectionEx_CabExtractCallBackA(PVOID Context, UINT Notification, UINT_PTR Param1, UINT_PTR Param2) > { >- FIXME("(%p %p %s %d): stub\n", hWnd, hInst, debugstr_a(cmdline), show ); >-} >+ LPCSTR file = (LPCSTR) Context; >+ PFILE_IN_CABINET_INFO_A pInfo = (PFILE_IN_CABINET_INFO_A) Param1; >+ if ( Notification != SPFILENOTIFY_FILEINCABINET ) return 0; >+ assert( 0 != Param1 ); > > Why bother with the assert? You'll crash more nicely by just dereferencing the NULL pointer. At least then you'll get a backtrace in the debugger. >+ if (0 != strcmp(file, pInfo->NameInCabinet)) return FILEOP_SKIP; >+ lstrcpyA(pInfo->FullTargetName, pInfo->NameInCabinet); >+ TRACE("Extraction of '%s'\n", pInfo->NameInCabinet); >+ return FILEOP_DOIT; >+} >+ >+HRESULT WINAPI LaunchINFSectionEx( HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show ) >+{ >+ CHAR inf_name[512]; >+ CHAR section_name[512]; >+ CHAR cab_name[512]; >+ CHAR szFlags[48]; >+ CHAR szShow[2]; >+ DWORD dwFlags; >+ CHAR* cursor = NULL; >+ SIZE_T sz = 0; >+ BOOL bTest; >+ HINF hinf; >+ void* callback_context; > >-/* this structure very closely resembles parameters of RunSetupCommand() */ >-typedef struct >-{ >- HWND hwnd; >- LPCSTR title; >- LPCSTR inf_name; >- LPCSTR dir; >- LPCSTR section_name; >-} SETUPCOMMAND_PARAMS; >+ FIXME("(%p %p %s %d): semi-stub\n", hWnd, hInst, debugstr_a(cmdline), show ); >+ >+ cursor = strchr(cmdline, ','); >+ if (NULL == cursor) { return E_INVALIDARG; } > > This is just personal preference, but the extra brackets there aren't needed and don't add to the readability and I haven't seen this style used elsewhere in the Wine source code. >+ sz = (cursor - cmdline) + 1; >+ lstrcpynA(inf_name, cmdline, sz); inf_name[sz] = 0; >+ cmdline = cursor + 1; >+ >+ cursor = strchr(cmdline, ','); >+ if (NULL == cursor) { return E_INVALIDARG; } >+ sz = (cursor - cmdline) + 1; >+ lstrcpynA(section_name, cmdline, sz); section_name[sz] = 0; >+ cmdline = cursor + 1; >+ >+ cursor = strchr(cmdline, ','); >+ if (NULL == cursor) { return E_INVALIDARG; } >+ sz = (cursor - cmdline) + 1; >+ lstrcpynA(cab_name, cmdline, sz); cab_name[sz] = 0; >+ cmdline = cursor + 1; >+ >+ cursor = strchr(cmdline, ','); >+ if (NULL == cursor) { return E_INVALIDARG; } >+ sz = (cursor - cmdline) + 1; >+ lstrcpynA(szFlags, cmdline, sz); szFlags[sz] = 0; >+ cmdline = cursor + 1; >+ >+ lstrcpynA(szShow, cmdline, 2); szShow[1] = 0; >+ >+ dwFlags = atol(szFlags); >+ >+ TRACE("cab name('%s')\n", cab_name); >+ TRACE("inf name('%s')\n", inf_name); >+ TRACE("inf section name('%s')\n", section_name); >+ TRACE("flags('%s','%lu')\n", szFlags, dwFlags); >+ TRACE("nShow('%s')\n", szShow); >+ >+ if (dwFlags & 0x04) { >+ FIXME("dwFlags: Quiet Mode\n"); >+ } >+ if (dwFlags & 0x08) { >+ FIXME("dwFlags: Don't Run GrpConv\n"); >+ FIXME("Unsupported\n"); return E_NOTIMPL; >+ } >+ if (dwFlags & 16) { >+ FIXME("dwFlags: Force self-updating\n"); >+ FIXME("Unsupported\n"); return E_NOTIMPL; >+ } >+ if (dwFlags & 32) { >+ FIXME("dwFlags: Backup data before install\n"); >+ } >+ if (dwFlags & 64) { >+ FIXME("dwFlags: Rollback data to previous state\n"); >+ /*FIXME("Unsupported\n"); return E_NOTIMPL;*/ >+ } >+ if (dwFlags & 128) { >+ FIXME("dwFlags: Validate Backup data before install\n"); >+ FIXME("Unsupported\n"); return E_NOTIMPL; >+ } >+ if (dwFlags & 256) { >+ FIXME("dwFlags: Rollback data to previous state\n"); >+ FIXME("Unsupported\n"); return E_NOTIMPL; >+ } >+ if (dwFlags & 512) { >+ FIXME("dwFlags: Force delay of OCX registration\n"); >+ FIXME("Unsupported\n"); return E_NOTIMPL; >+ } >+ >+ if (0 != strcmp(cab_name, "")) { >+ FIXME("Unsupported Cab Extraction\n"); return E_NOTIMPL; > > Is this left over debugging code? >+ bTest = SetupIterateCabinetA(cab_name, 0, >+ (PSP_FILE_CALLBACK_A) LaunchINFSectionEx_CabExtractCallBackA, >+ (LPVOID) inf_name); > > Don't cast LaunchINFSectionEx_CabExtractCallBackA. That's a recipe for using a function with an incorrect calling convention and trashing the stack. >+ if (!bTest) return E_FAIL; > > Don't use E_FAIL. Try to return a proper error code, preferably using what native returns in this circumstance by adding a test case. >+ } >+ >+ hinf = SetupOpenInfFileA(inf_name, NULL, INF_STYLE_WIN4, NULL); >+ if (hinf == INVALID_HANDLE_VALUE) { >+ ERR("Failed to SetupOpenInfFileA(%s)\n", inf_name); >+ return E_FAIL; > > Again, don't use E_FAIL. Also consider adding some more debugging information to the error message (like, say, the value returned by GetLastError()). >+ } >+ >+ callback_context = SetupInitDefaultQueueCallback(hWnd); >+ bTest = SetupInstallFromInfSectionA(NULL, hinf, >+ section_name, >+ SPINST_ALL, >+ NULL, NULL, 0, >+ SetupDefaultQueueCallbackA, >+ callback_context, >+ NULL, NULL); >+ SetupTermDefaultQueueCallback(callback_context); >+ SetupCloseInfFile(hinf); >+ >+ if (!bTest) { >+ ERR("Failed to SetupInstallFromInfSectionA(%s, %s)\n", inf_name, section_name); >+ return E_FAIL; > > Again, don't use E_FAIL - return a proper error code. >+ } >+ return S_OK; >+} > > /*********************************************************************** > * DoInfInstall (ADVPACK.@) >@@ -144,6 +260,15 @@ > } > > /*********************************************************************** >+ * LaunchINFSection (ADVPACK.@) >+ */ >+HRESULT WINAPI LaunchINFSection( HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show ) >+{ >+ FIXME("(%p %p %s %d): semi-stub\n", hWnd, hInst, debugstr_a(cmdline), show ); > > Can you give us a clue as to what the difference between LaunchINFSection and LaunchINFSectionEx might be by adding a comment? If you don't know, a comment would still be appreciated saying that it should be doing something different here. >+ return LaunchINFSectionEx( hWnd, hInst, cmdline, show ); >+} >+ >+/*********************************************************************** > * IsNTAdmin (ADVPACK.@) > */ > BOOL WINAPI IsNTAdmin( DWORD reserved, PDWORD pReserved ) >@@ -395,16 +520,59 @@ > /*********************************************************************** > * ExtractFiles (ADVPACK.@) > * >+ * @param CabName: Cabinet file path >+ * @param ExpandDir: Extraction Output Directory >+ * @param Flags: UNKNOWN >+ * @param FileList: if NULL extract all files >+ * else UNKNOWN >+ * > > I don't think that is a c2man compatible documentation format. > * BUGS > * Unimplemented > */ >+typedef struct >+{ >+ DWORD Flags; >+ LPCSTR ExpandDir; >+ LPCSTR FileList; >+} ExtractFiles_CabExtractCallBackA_params_t; >+ >+static UINT ExtractFiles_CabExtractCallBackA(PVOID Context, UINT Notification, UINT_PTR Param1, UINT_PTR Param2) >+{ >+ ExtractFiles_CabExtractCallBackA_params_t* pParams = (ExtractFiles_CabExtractCallBackA_params_t*) Context; >+ PFILE_IN_CABINET_INFO_A pInfo = (PFILE_IN_CABINET_INFO_A) Param1; >+ if ( Notification != SPFILENOTIFY_FILEINCABINET ) return 0; >+ assert( 0 != Param1 ); >+ assert( 0 != Param2 ); >+ /** stupid heuristic: waiting for better: ie. understanding what is FileList format */ >+ if (NULL != pParams->FileList) >+ { >+ if (NULL == strstr(pParams->FileList, pInfo->NameInCabinet)) return FILEOP_SKIP; >+ } >+ lstrcpyA(pInfo->FullTargetName, pParams->ExpandDir); >+ /** we should test if pParams->ExpandDir finished with "\" but each app examples i found have it */ >+ lstrcatA(pInfo->FullTargetName, pInfo->NameInCabinet); >+ TRACE("Extraction '%s' to '%s' (wanted Path was '%s')\n", pInfo->NameInCabinet, pInfo->FullTargetName, pParams->ExpandDir); >+ return FILEOP_DOIT; >+} > > HRESULT WINAPI ExtractFiles ( LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags, > LPCSTR FileList, LPVOID LReserved, DWORD Reserved) > { >- FIXME("(%p %p 0x%08lx %p %p 0x%08lx): stub\n", CabName, ExpandDir, Flags, >+ ExtractFiles_CabExtractCallBackA_params_t params; >+ BOOL bTest; >+ >+ FIXME("(%p %p 0x%08lx %p %p 0x%08lx): semi-stub\n", CabName, ExpandDir, Flags, > FileList, LReserved, Reserved); >- return E_FAIL; >+ >+ params.Flags = Flags; >+ params.ExpandDir = ExpandDir; >+ params.FileList = FileList; >+ >+ bTest = SetupIterateCabinetA(CabName, 0, >+ (PSP_FILE_CALLBACK_A) ExtractFiles_CabExtractCallBackA, >+ (LPVOID) &params); > > Again, don't cast ExtractFiles_CabExtractCallBackA. Just fix up the declaration of that function if it issues a warning here. >+ if (!bTest) return E_FAIL; > > Again, don't use E_FAIL. -- Rob Shearman

2 2

Re: [advpack/setupapi] LaunchINFSection
by Dimi Paun Nov. 21, 2005

Nov. 21, 2005

On Wed, 2005-11-16 at 23:56 +0100, Raphael wrote: > + if (!bRet) { > + ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src), > debugstr_w(dst)); > + } You shouldn't issue ERR if the function can deal with the error condition. Just return the appropriate error code. ERR is to signal a case that should NEVER happen. This is not the case in any of the instances where you used ERR in this patch. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

Re: [advpack/setupapi] LaunchINFSection
by James Hawkins Nov. 21, 2005

Nov. 21, 2005

On 11/16/05, Raphael <fenix(a)club-internet.fr> wrote: > > Changelog: > - semi implementation of advpack APIs LaunchINFSection/LaunchINFSectionEx > - semi implementation of advpack API ExtractFiles > - setupapi: correct and check pExtractFiles return code > I appreciate your work on advpack, but some comments that might help get it accepted more easily: * separate the patch into as many independent chunks as you can. It seems like each function you implement can be sent in separate and linearly. * it would help to add test cases wherever you can even if it's just to check how the function handles parameters. > + if (!bRet) { > + ERR("Failed to CopyFileW(%s, %s)\n", debugstr_w(src), debugstr_w(dst)); > + } The rest of the file uses standard C indentation, so it's best to stick with that: if (x) { } but seeing as how it's just a one liner, if (!bRet) ERR("..."); -- James Hawkins

3 3

Re: D3D7 & WineD3D success
by Stefan Dösinger Nov. 20, 2005

Nov. 20, 2005

> Doesn't the demo for Tomb Raider 3 rely on wierdo installshield stuff? > I have the full version of that game (it came with my videocard) and I > can't get past the installer using the winehq wine tree. Not that I know... It installed without any problems here. The demo is a WinZip self extractor, which extracts an old (non-DCOM) installshield installer, which worked out of the box for me. But, for the game to run, you have to set the Windows Version to Win98, otherwise the game will stop with a privileged instruction exception during startup. Stefan

2 1

NTSTATUS values in ntstatus.h and winnt.h
by Ge van Geldorp Nov. 20, 2005

Nov. 20, 2005

The PSDK defines some NTSTATUS values in both ntstatus.h and in winnt.h, guarded by "#ifndef WIN32_NO_STATUS". Unfortunately, the definitions in the PSDK are not equivalent. In ntstatus.h: #define STATUS_xxx ((NTSTATUS) 0x........) In winnt.h: #define STATUS_xxx ((DWORD) 0x........) The Wine headers don't cast the literal to NTSTATUS resp DWORD. This means it is ok to #include both winnt.h and ntstatus.h without #defining WIN32_NO_STATUS using the Wine headers, but it is not ok to do so using PSDK (or, in my case, ReactOS) headers. Would a patch adding the appropriate casts in ntstatus.h/winnt.h and then fixing the resulting problems in Wine by #defining WIN32_NO_STATUS where appropriate (an example is dlls/netapi32/wksta.c) be acceptable? Gé van Geldorp.

1 0

Re: PATCH: long registry lines loading
by Andreas Mohr Nov. 20, 2005

Nov. 20, 2005

Hi, On Sun, Nov 20, 2005 at 05:45:13PM +0100, Marcus Meissner wrote: > I have this patch proposal, but I fear it might not fly with Alexandre ;) Not only with Alexandre, I'm afraid ;) Why not follow a dual strategy: use a static buffer for <= MAX_PATH and use a malloc()ed buffer if it exceeds that size? (ok, scrap that, static plus malloc() is a BAD idea:) Or, since the original buffer variable was static anyway, you could just *always* (re-)use an malloc()ed buffer and *grow* it whenever the previous size was to small... I haven't looked too closely at the code, but repeated malloc()/free() in "fast-as-lightning" registry code sounds like a terrible solution that can be easily transformed into something better here, it seems. Andreas

1 0

MBR was destroyed
by seorge Nov. 20, 2005

Nov. 20, 2005

I've just submitted a bug (3889) about destroyed MBR and Dustin Navea asked me to subscribe to this list. Here comes some detailed description: As a regular user I've launched winecfg as a regular user, then proceeded to the dist setup. I've tried several options like automatic configuration, manual configuration. Then I've tried to change some drive letters manually. After reboot a "PRESS A KEY TO REBOOT" message appeared instead of a GRUB screen. Next time I booted with grub-floppy and then restored the MBR with grub-install /dev/hda. Please let me know what additional information you need. It's happend on Slackware 10.2 system, 2.6.14 kernel with ck-3 patches.

3 2

Re: Licensing and technical issues with a Wine package that includes the Mozilla ActiveX Control
by Mike Hearn Nov. 20, 2005

Nov. 20, 2005

On Sun, 20 Nov 2005 12:55:30 +0100, Stephan Hermann wrote: > As I understand the Howto, Steam somehow needs this mfc dll, but doens't > ship it. That can mean, that the Steam developer don't have the rights > to distribute it, which sounds a bit strange to me. If they don't > deliver a vital dll for their software, they have a problem, which we or > better you should not solve, with shipping any propietary software in > the wine app. Windows comes with the MFC DLL and has done for yonks, so it's effectively an OS component now.

1 0

Re: [winecfg] add sound driver test
by Steven Edwards Nov. 20, 2005

Nov. 20, 2005

Hi, On 11/13/05, Robert Reif <reif(a)earthlink.net> wrote: > Changelog: > - add a simple sound driver test > > Download the test wave file from: This is 3 megs. Could we not use a higher level studd and use winemp3 to docode a mp3 that can be embedded in a resource script? I wrote a patch a few months back alot like the one you submitted but I decided to trash the idea when I saw how large and how much of a pain it would be to deal with a *.wav test. Thanks Steven

5 5

Thread tests failure on Windows
by Paul Vriens Nov. 20, 2005

Nov. 20, 2005

Hi, I've not been able to get the kernel thread tests working on windows. The only thing I've found is that changing thread.c: /* simulate a call to set_test_val(10) */ #if 0 stack = (int *)ctx.Esp; stack[-1] = 10; stack[-2] = ctx.Eip; ctx.Esp -= 2 * sizeof(int *); ctx.Eip = (DWORD)set_test_val; #endif or even #if 0 ctx.Eip = (DWORD)set_test_val; #endif makes the test run instead of crashing. They still fail, but only for the last ok(). Unfortunatly this is way over my head. So I'd appreciate if someone could have a look. What worries me (maybe needless) is that the test runs OK on Wine. So either we're way better or we implement things differently. Cheers, Paul.

4 5

MixOne buffer underrun, ideas?
by george multescu Nov. 20, 2005

Nov. 20, 2005

Hi all! I want to get your oppinion on some buffer underrun i've been experiencing. Driver: Alsa, Hardware acceleration : Emulation. I've been testing Diablo2 v1.11b. My hardware: 256Mb ram, 1.1 ghz duron, via kle133 chipset, The error: err:dsound:DSOUND_MixOne underrun on sound buffer 0x7a631a70 that isn't very informative, so i've added some more parameters to the err: ERR("underrun on sound buffer %p dsb->buf_mixpos = %ld dsb->buflen = %ld \n", dsb, dsb->buf_mixpos, dsb->buflen); and got this: //////////////////////////////////////////////////////////////////////////////////////////////// err:dsound:DSOUND_MixOne underrun on sound buffer 0x7a631a70 dsb->buf_mixpos= 0 dsb->buflen= 131072 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7a631f70 dsb->buf_mixpos= 0 dsb->buflen= 131072 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7a6311b8 dsb->buf_mixpos= 0 dsb->buflen= 131072 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7a631008 dsb->buf_mixpos= 0 dsb->buflen= 131072 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7a5d0788 dsb->buf_mixpos= 0 dsb->buflen= 131072 /////////////////////////////////////////////////////////////////////////////////////// so it seems that dsb->buflen is almost always 1310702, with the small exception of: 262144( which is (1310702 * 2)); dsb->buflen= 262144 only happend once or twice. So, any ideas? __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com

1 0

problem compiling value.c in /home/storri/src/wine/dlls/wldap32
by Stephen Torri Nov. 20, 2005

Nov. 20, 2005

I am using CVS version of wine that I synced with just tonight. I did the following commands: make clean cvs up ./configure make depend make When it came to compiling value.c in /home/storri/src/wine/dlls/wldap32 I get an error that: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o value.o value.c value.c: In function `bv2str': value.c:123: error: dereferencing pointer to incomplete type value.c:128: error: dereferencing pointer to incomplete type value.c: At top level: value.c:135: warning: 'bv2str_array' defined but not used make[2]: *** [value.o] Error 1 make[2]: Leaving directory `/home/storri/src/wine/dlls/wldap32' make[1]: *** [wldap32] Error 2 make[1]: Leaving directory `/home/storri/src/wine/dlls' make: *** [dlls] Error 2 The type system used does not make sense to be as a user. I don't see where ULONG is defined athat I see being used at line 123 in value.c Stephen

2 1

Steam regression in CVS
by James Liggett Nov. 19, 2005

Nov. 19, 2005

Hi, Yesterday I found a regression in Steam in current CVS. It fails to start, giving the error message: "ERROR: Failed to get local IP address of SocketToServer." Steam dies a few seconds after this. I tracked down the cause to a recent Winsock patch: http://www.winehq.com/pipermail/wine-cvs/2005-November/019293.html Can someone confirm this/take a look at it? Thanks. James

4 4

RFC: Presentation for Desktop Architecture meeting
by Jeremy White Nov. 19, 2005

Nov. 19, 2005

I'm preparing for the Desktop Architecture meeting; each project is being asked to prepare a presentation using a standard format. I've filled in their template and was hoping to ask for feedback. The Open Office file is available for download here: http://dl.codeweavers.com access key 'deskarch' It's about 327K; I'm also including, in line, the outline, which is about 1.5K <grin>. I'd appreciate thoughts/suggestions/comments. I gather the main purpose of the meeting is to try to increase cooperation between projects. Cheers, Jeremy ----- Wine Project Overview Purpose: Implement Windows API for Unix Wine loader – run Windows Applications Winelib – port Windows applications Deliverables (the dream) All PE format files (.exe + .dll) 'just work' with binary loader. C/C++ code recompiles and 'just works' with Winelib Affiliations CodeWeavers ReactOS project Wine Project History Founded 1993 Single Maintainer 797 Contributors over Lifetime, ~40 active Alpha Software, limited functionality, through 2005 First Beta (0.9) released October 2005 Many things work Server interface stable Some ABI stability Associations With Other Desktop Organizations Wine is a power user of the kernel, glibc, and x.org Have very specific needs around memory, threading, and display control We break X more than any other app I know We get no respect exec shield, glibc threading changes, feels like a constant arms race; be nice if we could be more involved, given time to respond Also touch: OpenGL, ALSA/Jack/ESD/Arts/OSS Hurray for Freedesktop.org Menu Specifications Xembed Protocol Gap Analysis In Current Implementations Missing capabilities Many things don't work == a whole lotta bugs Developing capabilities Most core pieces are there, most things 'should' work DirectX coming along nicely Sound still needs work Many things at 90%+, but still need work Top priority development items in plan “We have not yet begun to optimize” Regression testing Driving to 1.0 Major Plans 6 month plan Refine beta releases of 0.9, drive towards 1.0 2 year plan World Domination?

7 9

Minor graphical glitches in 3dMark2000's GUI
by Dustin Navea Nov. 19, 2005

Nov. 19, 2005

OK, these are all in the GUI, not while running the Demo or the Benchmark itself. First is when you initially run the program, it shows a splash screen, but it looks like there is another small piece of the splash that is not being displayed (just shows up as a white box in the middle of the rest of the splash, which works fine).. 2nd is when you go to the help menu and then to about, when that window first opens up, for about a sixth of a second,you see what is supposed to be drawn, which is grey bg and some test, with the 3dmark/madonion.com logo on the left.. After that sixth of a second, the are where the text is displayed becomes black, but the logo still displays. But since the text is black, and the bg is too, you can't read the text.. 3rd, which I'm going to put on bugzilla, is some error messages that spit out on the console, which I think prevent the app from running all of the benchmarks.. The ones that dont run, just tell you something like unsupported hardware, etc, and then it continues with the next mark. This app can be downloaded from Madonion.com, as shareware, in the unsupported and outdated products section :-/... The only things disabled in the demo version are things like the results browser, and 2 of the benchmarks.

1 0

displaying 'interval' timings in debug info
by Oliver Stieber Nov. 19, 2005

Nov. 19, 2005

Hi, I've got a patch that displays timings between debug messages with TRACE+interval enabled that I'm using for some profiling and thought someone else may be interested. The patch is against dlls/ntdll . Oliver. ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

1 0

What would most aid WINE development?
by Susheel Daswani Nov. 19, 2005

Nov. 19, 2005

Hello WINE Development community, My name is Susheel Daswani. I am a second-year law student at Berkeley School of Law. I am also a software engineer - I used to develop the LimeWire open source Gnutella p2p application. Nice to meet everyone. For my 'Antitrust & IP' course this semester I am writing a brief about why I think the remedy in the Microsoft antitrust case was inadequate. My main recommendation is that the 'applications barrier to entry' phenomenon (users like OSes with lot of applications, developers like OSes that users like) need not aid Windows' dominance. This is of course familiar thinking to the WINE community - if a *nix (or any other OS) could effortlessly run every Windows application, then we wouldn't have a monopolist over in Redmond, or at least we'd have some fervent competition in the personal desktop OS space. So my question for the WINE developers is "What materials from Microsoft would most aid the development of WINE"? The Windows API is of course public, so my guess is that isn't a huge bar to creating WINE. So what are the bars? Is it simply the scope of the project? Is there information that MS could divulge that would greatly aid the WINE effort? Would open sourcing part of Windows help? I plan to use your answers for no other purpose than educating my professor on what, alas, *could* have been done to help restore competition to the personal desktop OS market. Thanks very much! Susheel Daswani http://www.susheeldaswani.com sdaswani(a)boalthall.berkeley.edu

6 6

Re: make builtin dlls visible for applications?
by Juan Lang Nov. 19, 2005

Nov. 19, 2005

> 2) place dummy files for all builtin dlls in c:\windows\system32 I believe this is the correct approach. I know of at least one InstallShield installer (that uses MSI) that searches for IE by looking for the file shdocvw.dll and checking its version. Presumably we'd like our users to have the option of installing programs using all builtin DLLs, even with silly checks like this. Eric once mentioned he had some hacky program that parsed PE headers that we might be able to coerce into creating such dummy DLLs. What we're looking for (besides him posting the code) is a volunteer to work on it. > hmm I guess you would get into trouble if you use WINEDLLOVERRIDE. > Wouldn't LoadLibrary try to load those dummy files? Someone proposed a hack where the loader would know that these DLLs are dummies based on a wine-specific flag in the header. --Juan __________________________________ Yahoo! Mail - PC Magazine Editors' Choice 2005 http://mail.yahoo.com

5 4

Quick q about bug posting
by Dustin Navea Nov. 19, 2005

Nov. 19, 2005

Just wondering, I'm going through all of the different apps that I have to see what sorts of problems I am running into, and in several of them, the programs run fine, but there are some graphic glitches (nothing major).. Should I report those here, to bugzilla, or both? They all see to be trivial to fix, and could be a plus to have listed as like gold or platinum (if there is a platinum designation). These are all _apps_.. not games.. So like I said, here, bugzilla or both? Dustin

1 0

Using Windows .DLLs in Linux C++ code - possible?
by Jim Morash Nov. 19, 2005

Nov. 19, 2005

Is it possible, via Wine, to link against a Windows DLL in a C++ program compiled under Linux? My specific situation: I would like to interface a piece of hardware over a serial port. The manufacturer refuses to provide a serial comms specification for the device "because it's proprietary", but they will happily provide a Windows DLL that can be used to control the device. Any chance of using it under Linux? thanks --Jim Morash

3 2

make builtin dlls visible for applications?
by Peter Beutner Nov. 18, 2005

Nov. 18, 2005

Hi There is yet another issue preventing SeriousSam from working. It fails to load opengl32.dll because before loading the dll it makes sure it can find it via SearchPath().The problem is that SearchPath doesn't know about the builtin dlls provided by wine, so it fails to find them and SeriousSam won't start. I can think of several ways to work around that, but i don't really like any of them. Maybe somebody else can throw in some comments or even has a better idea: possible solutions: 1) let SearchPath search for builtin dlls, and if found make it pretend the file exists in the c:\windows\system32\. This will cause all sorts of trouble if the application want to do anything else with the file beside trying to load it.(think of somebody browsing around with a Filemanager trying to copy/move/rename those files) 2) place dummy files for all builtin dlls in c:\windows\system32 (or symlinks pointing to corresponding *.dll.so files) hmm I guess you would get into trouble if you use WINEDLLOVERRIDE. Wouldn't LoadLibrary try to load those dummy files? 3) just put it under the category "application-specific hack", and put instructions somewhere(appdb,..) what to do to get it working. ie:"touch ~/.wine/drive_c/windows/system32/opengl32.dll", would do it in this case. 4) combination from 1) and 3), solve it like in 1) but make it a per-application configuration setting similar to dll overrides. Comments? Better ideas? Peter

2 1

Re: What would most aid WINE development?
by Juan Lang Nov. 18, 2005

Nov. 18, 2005

> The Windows API is of course public, so my guess is that isn't > a huge bar to creating WINE. Unfortunately, you guess incorrectly. While the API may legally be public (the interface can't be protected, as far as we know,) it isn't always documented. MS uses undocumented APIs very, very frequently in its own products, and I don't just mean in its applications: parts of its API depend on other, hidden parts of its API. Even the parts that are documented are not documented completely. For example, many APIs take 32-bit flags parameters, some of whose meanings are documented. But the behavior for all possible values is not well-specified, nor are the return values. I continue this thread next: > Is it simply the scope of the project? This is a large part of the problem. It's difficult to appreciate just how large it is. (There was a presentation about this once, maybe by David Korn, but I've lost track of it.) We can only learn the behavior through experimentation, and so do application developers. The application developers depend on undocumented behaviors, so we have to replicate them, including bugs. The problem is, there are many more of application developers (and Windows developers) than there are of us. Also part of the problem, though I don't think it comes close to scale as far as its impact, is that our architectures are different. For example, the code obfuscation tools (securom, safedisk et al) depend on device drivers being loaded by ntoskrnl.exe. This is related to the hidden assumpmtions problem I described already, but sometimes we have to implement a large amount of silliness that we didn't anticipate having to do, or reimplement stuff that was already working for some apps. ReactOS can potentially avoid some of these issues, since they're copying much more of Windows's architecture. > Would open sourcing part of Windows help? Only if it were done in a way that didn't encumber our ability to develop WINE. --Juan __________________________________ Start your day with Yahoo! - Make it your home page! http://www.yahoo.com/r/hs

3 2

RESENT: [msvcrt] I64 and ll support
by Raphael Nov. 17, 2005

Nov. 17, 2005

On Wednesday 09 November 2005 02:15, Raphael wrote: > Hi, > > Changelog: > - add I64 modifier support on msvcrt *printf functions > - correct ll modifier support on msvcrt *printf functions > - correct tests > > this should correct bug 3759 and 2075 (and many others) > > Now for libc who don't support %ll modifiers (which one?) > Jesse Allen provide the patch (see bug 2075 content) > > Regards, > Raphael better patch than previous: now Jesse can put his code into #else / #endif :) Changelog: - add configure check to detect support of %ll modifier on libc printf - add I64 modifier support on msvcrt *printf functions - add I32 modifier support on msvcrt *printf functions - correct ll and LL modifier support on msvcrt *printf functions - some FIXMEs on unsupported cases - correct tests Regards, Raphael

2 3

program name clashes
by Daniel Nov. 17, 2005

Nov. 17, 2005

Hi, a problem which just popped up in the newsgroup: Imagine a program called start.exe (or notepad.exe or regedit.exe, etc.). Invoking 'wine start.exe' will not run this program, but the start.exe that comes with wine. The only workaround is to do WINEDLLOVERRIDES="start.exe=n" wine start.exe. This neither logical nor intuitive, instead it is rather silly. At least 'wine ./start.exe' should actually run the program intended, not some obscure program the average user has never heard about. regards, Daniel

1 0

Drop the PFD_GENERIC_ACCELERATED flag?
by Peter Beutner Nov. 17, 2005

Nov. 17, 2005

At the moment wine always set the PFD_GENERIC_ACCELERATED flag in X11DRV_DescribePixelFormat. SeriousSam uses this flag to determine if the pixelformat is hardware accelerated. If the flag is set it is interpreted as _no_ hardware acceleration available. Unfortunately MSDN isn't really clear about what that flag really means: it describes it as: "The pixel format is supported by a device driver that accelerates the generic implementation." After reading [1] I think it should be like that instead: If PFD_GENERIC_ACCELERATED is set the pixelformat is partially accelerated by the device driver and some parts are just software fallbacks. If PFD_GENERIC_FORMAT is set everything is done in software. And only if none of both is set it is fully accelerated in hardware. Is there anything similiar in GLX(full vs. partial accelerated) so we could set that flag according to that? Or, if not, can we just drop it? Imo it's better always off than always on. Thanks Peter [1] http://www.microsoft.com/msj/archive/S2085.aspx

4 8