November 2005 - Wine-Devel - list.winehq.org

Rejected patches in dmloader and dmime
by Peter Berg Larsen Nov. 5, 2005

Nov. 5, 2005

Hi, Whats is wrong with http://www.winehq.org/pipermail/wine-patches/2005-October/021445.html http://www.winehq.org/pipermail/wine-patches/2005-October/021446.html http://www.winehq.org/pipermail/wine-patches/2005-October/021447.html and http://www.winehq.org/pipermail/wine-patches/2005-October/021448.html They were first time send in September. Peter

1 0

Re: Fix warning about signedness of pointers
by Robert Shearman Nov. 5, 2005

Nov. 5, 2005

Vincent Béron wrote: >Changelog: >Fix warning about signedness of pointers in x11drv. > >Vincent > > >------------------------------------------------------------------------ > >Index: dlls/x11drv/event.c >=================================================================== >RCS file: /home/wine/wine/dlls/x11drv/event.c,v >retrieving revision 1.59 >diff -u -r1.59 event.c >--- dlls/x11drv/event.c 12 Sep 2005 15:14:07 -0000 1.59 >+++ dlls/x11drv/event.c 4 Nov 2005 00:13:43 -0000 >@@ -698,7 +698,7 @@ > > if( !aux_long && p_data) /* don't bother if > 64K */ > { >- signed char *p = (signed char*) p_data; >+ char *p = (char *)p_data; > char *p_drop; > > aux_long = 0; >@@ -736,7 +736,7 @@ > lpDrop->fWide = FALSE; > WIN_ReleasePtr(pDropWnd); > p_drop = (char *)(lpDrop + 1); >- p = p_data; >+ p = (char *)p_data; > while(*p) > { > if( *p != -1 ) /* use only "good" entries */ > > Mike McCormack already tried an identical patch, but it was rejected because the implications of the fix were not considered. It doesn't seem that they were addressed in this patch either. IIRC, the main issue was that *p can in fact be negative. -- Rob Shearman

2 1

Re: Move functions to remove function declaration
by Robert Shearman Nov. 5, 2005

Nov. 5, 2005

Vincent Béron wrote: >Changelog: >Move functions in comctl32/string.c to remove function declaration. > > The current ordering is more logical, but the more important point is that these functions are exported and so should be put in a header file somewhere. -- Rob Shearman

1 0

bug 3514 fix (dsound primary buffer) needs fix?
by Peter Berg Larsen Nov. 5, 2005

Nov. 5, 2005

Hi, The following patch http://www.winehq.org/pipermail/wine-patches/2005-October/021269.html fixes http://bugs.winehq.org/show_bug.cgi?id=3514 but crashed Railroad tycoon, as it always sets device->primary->dsound to null when there are more than one user of the device. The following patch fixes railroad tycoon; does it still fix bug 3514? Peter RCS file: /home/wine/wine/dlls/dsound/dsound.c,v retrieving revision 1.42 diff -u -r1.42 dsound.c --- dsound.c 19 Oct 2005 19:21:38 -0000 1.42 +++ dsound.c 5 Nov 2005 03:09:22 -0000 @@ -251,7 +251,7 @@ if (This->device) { if (DirectSoundDevice_Release(This->device) != 0) { /* device not released so make sure primary reference to This removed */ - if (This->device->primary) + if (This->device->primary && This->device->primary->dsound == This) This->device->primary->dsound = NULL; } }

2 1

DISPLAY vs. \\.\DISPLAY1
by Tim Martin Nov. 5, 2005

Nov. 5, 2005

I had discovered a bug with Quicken 2005 where certain graphics aren't being drawn on screen, depending on whether the application is using W98 or W2k "emulation". The behavior actually changed (from works in W98 but broken in W2k to works in W2k but broken in W98) at some point in time. After some tedius recompiling and testing (hey, I'm new to wine!) I discovered the behavior swap was due to a CVS commit to dlls\user\misc.c on 29 September 2005. Something to do with the display name being unicode DISPLAY vs. \\.\DISPLAY1 (which seems to be the first display name for Windows). I just sent a proposed patch to fix this bug, but thought I would also ask on this list to make sure I haven't done anything stupid (which I probably have). Basically, there were several files that declare static constants for a display name - I globally search & replaced all DISPLAY with \\.\DISPLAY1 where it seemed to make sense, but hopefully others will have an opinion here. Tim

2 2

Small visual issues with P-CAD2000 and wine 0.9
by Marcos Vicente Cruz Nov. 4, 2005

Nov. 4, 2005

HI, I having small visual issues in P-CAD 2000's toolbar on Linux since I've upgraded to wine 0.9. The buttons aren't displayed properly. See the screenshot attached. Thank you, Marcos

4 5

Re: PATCH: Olepicture Dispatch Invoke
by Robert Shearman Nov. 4, 2005

Nov. 4, 2005

Marcus Meissner wrote: >Hi, > >ExpressPCB (http://bugs.winehq.org/show_bug.cgi?id=3752) >does some invokes on IPictures. > >I implemented the ones it needs. > >GetTypeInfo is stolen from olefont.c. > > Please try not to introduce any more of this code into wine. We should be deferring to typelibs here and in olefont. However, it doesn't work because ITypeInfo_Invoke doesn't work on variables yet. I plan to refactor the function to reduce the levels of indentation for the majority of it and generate a fake FUNCDESC to parse, reusing the existing code. -- Rob Shearman

1 0

WineProbe part II; Propaganda for Wine
by David Gümbel Nov. 4, 2005

Nov. 4, 2005

Hello everybody, as most of you probably remember, my company (ITOMIG) launched an initiative called WineProbe (=~ "WineTasting" in English) some time ago. As part of this initiative, we're arranging an informational event next week on thursday afternoon in Stuttgart. We'll present Wine and its capabilities for migrating and porting applications to Unix. Details are available online (in German) [1]. The target audience are software vendors who would like to create a Linux or cross-platform version of their Windows-based products. However, anyone interested is cordially invited to come, listen and discuss, and have a glass of good wine afterwards ;) The event is free, you just need to send us a small application form avaliable online on [1]. Aside from that, I wrote an article titled "Grenzen überschreiten" ("Crossing Borders") about Wine and its use in the city of Böblingen in a project we're running together with Böblingen and Tübingen University. It was published in print this week in the magazine Kommune21 [2]. Kommune21 is a magazine about the use of information technology in municipalities (german: "Kommunen"). About 11 000 copies are printed every month, and I'd say the CIO of pretty much every major german city has a subscription. They do not normally have a free online version of their contents available. However, they provided me with a PDF of the article, which we're allowed to put online on our web site. I think this is very nice advertisement for Wine, in particular because of the very specific audience of that publication. Anyone interested can find the article available online at [3]. Bye, David [1] http://www.itomig.de/Initiative_Wine-Probe.26.0.html [2] http://www.kommune21.de [3] http://www.itomig.de/Downloads.10.0.html

3 3

Re: hhctrl: Free an alloc'ed string
by Vincent Béron Nov. 4, 2005

Nov. 4, 2005

Le ven 04/11/2005 à 12:22, James Hawkins a écrit : > Hi, > > Changelog > * Free an alloc'ed string. > > -- > James Hawkins > ---- > > Index: dlls/hhctrl.ocx/hhctrl.c > =================================================================== > RCS file: /home/wine/wine/dlls/hhctrl.ocx/hhctrl.c,v > retrieving revision 1.9 > diff -u -p -r1.9 hhctrl.c > --- dlls/hhctrl.ocx/hhctrl.c 4 Nov 2005 11:15:01 -0000 1.9 > +++ dlls/hhctrl.ocx/hhctrl.c 4 Nov 2005 17:20:57 -0000 > @@ -97,6 +97,7 @@ HWND WINAPI HtmlHelpW(HWND caller, LPCWS > FIXME("Not all HH cases handled correctly\n"); > doWinMain(GetModuleHandleW(NULL), file); > default: > + HeapFree(GetProcessHeap(), 0, (LPVOID)filename); file, not filename. Vincent

1 0

Re: WININET: small fix for InternetCreateUrlA
by James Hawkins Nov. 4, 2005

Nov. 4, 2005

On 11/4/05, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > This was a one minute looker, so it can contain some logical errors or so. > No it's good. I don't know why I got ERROR_ALREADY_EXISTS when I was testing, but I swear I did! I don't get the error anymore so it must have been leftover from something else. -- James Hawkins

1 0