February 2005 - Wine-Devel - list.winehq.org

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

ownerdraw paint recursion in listbox
by Alexander Yaworsky Aug. 4, 2005

Aug. 4, 2005

Hello, recently i tried to install some application and it hung when i tried to select options. It uses listbox with ownerdraw items with checkboxes. When listbox is initially painted everything is ok. But when i try to select other item, an extra WM_PAINT is sent to listbox when application draws item. This causes infinite recursion. I've been implemented a simple workaround adding boolean to listbox structure but i have doubts. I briefly looked at some other controls and had not noticed similar countermeasures. Have somebody ever seen such behaviour? It would be interesting to test other controls sending WM_PAINT from ownerdraw handler but i'm short of time to do it soon. Should this workaround implemented in this way or something is wrong deeper with WM_PAINT handling? Thanks.

2 7

rpcrt4.dll NdrGetUserMarshalInfo() problem
by J. Grant July 2, 2005

July 2, 2005

Hello, I am getting the attached error when running an install of Overnet v0.52. Basically it cannot find NdrGetUserMarshalInfo(), despite it being in the dll at entry point: 77d43452h, order 199. Any ideas what this problem could be? I'm expecting this to be the symptom of some wider problem. Any help appreciated. Kind regards JG p.s. Is there any way to get these mangled function names to be displayed un-mangled please? c:\opt\overnet_0_52>overnet c:\opt\overnet_0_52>err:module:import_dll No implementation for MSVCRT.dll.??_U(a)YAPAXI@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V(a)YAXPAX@Z imported from L"C:\\opt\\overnet_0_52\\MSVCIRT.dll", setting to 0xdeadbeef -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

3 3

lotus notes regression
by Paul R Streitman June 25, 2005

June 25, 2005

Patch 14725, applied 2004/12/07 11:31:53, breaks lotus notes. The symptom is a hang with the CPU at 100%, and it happens immediately if you try to click on a notes 'bookmark', or shortly after you try to do much of anything else if you try to avoid the 'bookmarks'. Sorry that it took me so long to report this, when I decided that it wasn't just a temporary instability I eventually had to iteratively compile (many) CVS snapshots to narrow down when the problem was introduced because I found it impossible to untangle the various patches that went in around that time frame. I also ran afoul of the jack problems near the end. I do not know how to narrow the problem down further. I tried running winedbg (at CVS level a couple of days ago), and that seems to be broken too -- it wanted to run things from the wine build tree? There are no unusual console messages or anything when the problem happens. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

7 8

Re: Broken cross-build, again.
by Paul Vriens April 16, 2005

April 16, 2005

On Wed, 2005-02-09 at 16:59, Paul Millar wrote: > I haven't worked on any of winetest's innards, so this is largely > guess work... > > On Wednesday 09 February 2005 13:22, you wrote: > > If I run winetest-200502091000-paul-mingw manually on my win98 box > > I get several messages "Can't parse subtests output of" for the > > following tests [...] > > just before the tests actually start. > > My guess is that winetest is attempting to run these tests, but that > they are dying straight away, with some error message. This error > message is not the expected output, hence the error messsage. > > [...] > > Does this mean that we have a deeper lying problem? > > Yes, obviously! The tests are failing and we have no mechanism for > detecting this. This, in itself, is a bug. > > > Or just that > > more tests are somehow not correct (in combination with mingw)? > > I've bundled the individual tests in: > http://www.astro.gla.ac.uk/users/paulm/WRT/winetest-bin-20050209.zip > (its some 2.6MiB in size, though) > > I image you should be able to run the shlwapi test individually, which > should help narrow down the cause. > > HTH, > > Paul. Hi Paul, I've included wine-devel again as this must touch others as well. I wasn't able to run the shlwapi tests on my win98 box, by itself. Running this gives an error box: The SHLWAPI_.EXE file is linked to missing export SHLWAPI.DLL:PathIsValidCharA and just for completeness sake: dsound: ... linked to missing export DSOUND.DLL:DirectSoundCreate8 mlang: ... linked to missing export NTDLL.DLL:atoi msvcrtd: A required .DLL, MSVCRTD.DLL, was not found ole32: ... linked to missing export NTDLL.DLL:atoi Cheers, Paul Vriens.

7 10

Regression in comctl32 Treeview (breaks Filezilla)
by Hannu Valtonen March 30, 2005

March 30, 2005

Hi, The following patch: ChangeSet ID: 15259 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard <cleonard(a)go.ro> Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the "New site" button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?dow… and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downl… I would appreciate it if some comctl32 messaging guru could step up and take look at this problem -- - Hannu Valtonen Hannu.Valtonen(a)hut.fi +358408030179

1 1

Support for IDvdInfo2::GetDiscID
by James Courtier-Dutton March 25, 2005

March 25, 2005

The Windows api method uses the function call IDvdInfo2::GetDiscID http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… This returns a unique 64bit ID for a DVD. Has anyone found out what exactly it does to create this 64bit ID. It would be nice to get linux DVD players to be able to use the same method. Cheers James

2 2

wine + winamp: fixme:wave:OSS_AddRingMessage two fast messages in the queue!!!!
by seut March 16, 2005

March 16, 2005

hello, we are using winamp 2.95 with latest wine 0.0.20040914 and are wondering what there is about these 'fixme:wave:OSS_AddRingMessage two fast messages in the queue!!!!' messages dumped out at the console every few seconds... Same happens(but with 'ALSA_AddRingMessages' of course) if we're using the wine alsa-driver. Winamp normally works, but sometimes there is a 15sec pause at the playback, so we are trying to search the problem. I watched the wine source-code, but as my less C knowledge I didn't really understand the part where this 'FIXME' message is implemented. As I understand the code, why somebody added the 'FIXME' message to the code, if the code can handle this problem(two fast messages)? Or can somebody explain me the reason for this 'two fast messages'? thanks a lot seut btw. I'm not a member of the mailing-list, so please send answer to me too! and please don't suggest us to use a native linux-player instead, for some reasons, we have to use winamp..

2 2

World Of Warcraft
by cyrix12＠cox.net March 15, 2005

March 15, 2005

Hi, I'm the maintainer for World of Warcraft, and I've noticed a few things which have been pointed out before (on irc, bugzilla, mailing list) but have not really gotten any attention. As this is one of the most popular, if not THE most popular pc game at the moment, it seems as though it would be worthwhile to look into getting this to work if it does not require a complete rewrite of wine to do so. There are currently two things preventing operation of the game. Firstly, I'll start off by saying that there are two separate modes to run the game in. d3d9, and opengl. The d3d9 mode doesn't currently work since the support for this dll is not complete. I have been following it closely though, and I constantly find myself impressed with the amount of work being poured into it lately. It's really coming along, and I've even gotten it to run a few demos. Unfortunately, even with the latest patches it still comes up with a blank screen. I don't want to rush anything in this department since I know there's a massive transition from the d3d* architecture to wine3d, and I think it's a really great idea to funnel everything through opengl and only need one rendering library. It's hard for me to say as a WoW addict myself, but I would rather have a complete implementation of d3d9 than one that is only able to play WoW. So I guess what I'd like to say on this front is this: awesome work guys! As for the opengl mode, it crashes strangely just after the character loading screen, but before actually getting into the game. I'm not really sure exactly what is causing the crash. I've run several traces, and all that comes up is a large group of fixmes which look like this: fixme:thread:GetThreadTimes Cannot get kerneltime or usertime of other threads fixme:thread:NtQueryInformationThread info class 9 not supported yet The error I am able to get (when I change my winver to win2k) is an actual game error (not given by wine). This one looks like this: ERROR #0 (0x85100000) Program: C:\Program Files\World of Warcraft\WoW.exe File: C:\build\buildWoW\WoW\Source\Ui\MinimapFrame.cpp Line: 1287 Expr: !("CGMinimapFrame::Initialize(): can't get render target for minimap") I posted a bug about this on December 7, 2004 at this location: http://bugs.winehq.org/show_bug.cgi?id=2603 Nothing has happened yet with this bug except for someone else confirming it. I'd appreciate it if someone could give me one of two pieces of information (both would be spectacular!): 1) What exactly is causing the problem with the opengl version, and is it easy to fix? 2) Is there any sort of goal that the people working on d3d9 dlls have set as far as a date they would like to have it done by? Or is it just one of those "It will be done when it's done" sort of things? Thanks in advance, Darckness -- Stop searching forever. Happiness is unattainable.

14 57

Re: New uninstaller
by Dmitry Timoshkov March 12, 2005

March 12, 2005

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > With some help I'll be able to improve it (more unicodification, etc.) > when I'll come back. You can't really convert to unicode partially, you have to do it in one go. That not only will simplify things a lot, but also will save you a lot of time. > + for (i=0; i < numentries; i++) > + { > + len = WideCharToMultiByte(CP_UNIXCP, 0, entries[i].descr, -1, NULL, 0, NULL, NULL); > + descr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + WideCharToMultiByte(CP_UNIXCP, 0, entries[i].descr, -1, descr, len, NULL, NULL); > + printf("%s|||%s\n", entries[i].key, descr); There is no need to allocate len * sizeof(WCHAR) bytes, len works just fine. > +int wmain(int argc, char *argv[]) wmain takes 'WCHAR *argv[]' list. All remaining problems are caused by the fact that now argv[] array is passed in unicode but you still handle argv[] strings as ASCII and pass them around to internal functions which accept 'char *' not 'WCHAR *' strings. -- Dmitry.

5 15

Editbox background regression (bug 2695)
by George Ginden March 9, 2005

March 9, 2005

*See Bug #2695 for screenshots: http://bugs.winehq.com/show_bug.cgi?id=2695 This regression was introduced within wine 20041019, since wine-20040914 was working just fine. (The latest release is still affected by the problem). The diff between these two versions is 5 megs big so I'm just wondering, which area of the codebase is affected by the bug... edit.c is not the case... Regards. *

3 4

Re: edit control
by Robert Shearman March 9, 2005

March 9, 2005

Ulrich Czekalla wrote: >Running some tests under WinXP I noticed that if the edit control doesn't >have WS_EX_CLIENTEDGE it looses the WS_BORDER style and it handles painting >the border. This also has the side effect that it's non-client area goes to >zero. > >ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Handle painting the border if WS_EX_CLIENTEDGE is not set > > This changelog doesn't really seem to match the patch. Are you sure it's right? >------------------------------------------------------------------------ > >Index: dlls/user/edit.c >=================================================================== >RCS file: /home/wine/wine/dlls/user/edit.c,v >retrieving revision 1.2 >diff -u -r1.2 edit.c >--- dlls/user/edit.c 9 Sep 2004 19:18:40 -0000 1.2 >+++ dlls/user/edit.c 15 Sep 2004 16:30:50 -0000 >@@ -4423,13 +4423,18 @@ > /* > * In Win95 look and feel, the WS_BORDER style is replaced by the > * WS_EX_CLIENTEDGE style for the edit control. This gives the edit >- * control a non client area. Not always. This coordinates in some >- * way with the window creation code in dialog.c When making >- * modifications please ensure that the code still works for edit >- * controls created directly with style 0x50800000, exStyle 0 ( >- * which should have a single pixel border) >+ * control a nonclient area so we don't need to draw the border. >+ * If WS_BORDER without WS_EX_CLIENTEDGE is specified we shouldn't have >+ * a nonclient area and we should handle painting the border ourselves. >+ * >+ * When making modifications please ensure that the code still works >+ * for edit controls created directly with style 0x50800000, exStyle 0 >+ * (which should have a single pixel border) > */ >- es->style &= ~WS_BORDER; >+ if (lpcs->dwExStyle & WS_EX_CLIENTEDGE) >+ es->style &= ~WS_BORDER; >+ else if (es->style & WS_BORDER) >+ SetWindowLongW(hwnd, GWL_STYLE, es->style & ~WS_BORDER); > > This doesn't seem right at all. The new code should be exactly the same as the old, barring any side effects from SetWindowLong (which shouldn't affect the control anyway since this the function changed is the handler for WM_NCCREATE). Rob

3 3

text edit box not painting text ( on form startup )
by Doug Herbert March 9, 2005

March 9, 2005

( I have posted a similiar question in wine-users, don't flame me for doing so, just thinking about this some more, perhaps it may be more a developer question ) Ok, I have a windows app, that runs under wine fine - not quite. This app has a form, with many text field edit boxes on. Quite often these edit boxes already have text values, ie. they are not empty - there is a database behind the form. Anyway, the form shows on the screen, but the text within the edit fields is invisible, until you activate each edit box component. When you leave one edit box to the next, the text remains visible. It seems like the repainting is not working, on initial startup of the form. As a way to debug this database app ( I don't have the source code for it ) I wrote a real basic form app in Visual Studio, with two edit boxes, with data in each. Now this basic app shows the text values immediately on startup. So there must be something different that the database app is not doing. I then ran wine using 'wine --debugmsg +edit programname' for both app's. I see both logging 'Creating ANSI edit control, style = xxxxx' but the style reference is different between apps - I am not sure if this the cause or not. The problem app reports style = 54011104 and the basic app shows style = 50010080. Can somebody explain what this style reference means and how do I force an app to use a certain style of edit box ? What other wine class debugmsg types should I use to narrow down the source of this problem ? Is there anyway I can check to see how the database app is repainting text within the text edit components ? Regards Doug Herbert. __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

3 4

Any resources about threading problems?
by Bill Medland March 5, 2005

March 5, 2005

Does anyone know any site or book or something with a decent discussion about the problems of the different threading models and their implementations? In the Developer's Guide in section 8.3 there are references to "the threading chapter". Is this a section that has not yet been written? As I understand it we (in the pthreads version) "override the native pthreads library". What does this mean? I am trying to research the issues associated with threading so that I understand the complications. The fact that Linux has two models and that Wine, FreeDCE and Samba (that I know of) seem to have found it necessary to bypass/hack/modify/override them indicates to me that there is something to understand. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

2 3

ESD sound support in Wine 20050111
by Kumaran Santhanam March 4, 2005

March 4, 2005

I found a patch for ESD (Enlightenment Sound Daemon) support in Wine from July 2004. I modified this to work with Wine-20050111 and compiled the wineesd.drv.so driver. This driver works in both Wine and CrossOver 4.1. The patch and instructions are attached to this email. I have been using it for a few weeks and it seems to be working well. It would be great if it could be incorporated into the main Wine tree. Please let me know if you have any questions. Best Regards, Kumaran Wine Enlightenment Sound Daemon support --------------------------------------- [Jul 2004] Original driver code by Zhangrong Huang <hzhr(a)users.sourceforge.net> [Feb 2005] Ported to Wine 20050111 and CrossOver Office Professional 4.1 by Kumaran Santhanam <rhapsody(a)users.sourceforge.net> Instructions: 0) Make sure that esound-devel is installed. 1) Untar Wine-20050111.tar.gz 2) cd wine-20050111 3) patch -p1 <wineesd-20050111.patch 4) autoconf configure.ac >configure 5) ./configure 6) make depend 7) make Binary is built as dlls/winmm/wineesd/wineesd.drv.so

3 2

World of Warcraft - crash in game
by Alex Woods March 3, 2005

March 3, 2005

Hi, World of Warcraft is working beautifully now apart from a crash that occurs seemingly randomly. The application is catching the crash, and giving a message like this: This application has encountered a critical error: ERROR #132 (0x85100084) Program: C:\Program Files\World of Warcraft\WoW.exe Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557102CD EAX=00000000 EBX=55BDFCA8 ECX=00000000 EDX=55BDFBB8 ESI=5E320308 EDI=00000000 EBP=55BDFC08 ESP=55BDFB9C EIP=557102CD FLG=00010212 CS =0023 DS =002B ES =002B SS =002B FS =005B GS=0063 I know this isn't really much use on it's own. I've tried turning on +relay logging, but it's proved futile - it seems to end up freezing up my system before a crash occurs. One thing that might be useful is that the access violation always seems to be around the same small area of memory each time, eg: Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557103CD Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:5571025D Over the course of 13 (unlucky for me ;)) crashes, these are the only 3 addresses it has given. My question is what can I do to debug this? +relay logging is probably infeasible, but I'd be happy to hack around to get it to only log certain things - I'm not sure what I'd need to log. Also, the last time it crashed, I was lucky enough to have it leave me in winedbg, which I've left open. Is there anything worth my while poking around with in there while I have the chance? I guess I'll be running memtest on my machine too, but I'd like to do what I can in winedbg first ;) Cheers. -- Alex

4 6

vartest.c - major pain in the build process
by Krzysztof Foltman March 2, 2005

March 2, 2005

Is there any reason for gcc 3.3.1 to spend several minutes on compiling dlls/oleaut32/tests/vartest.c ? I guess it can be explained by optimization stage going nuts on compiling long functions with many branches (contained in the macros), but there must be a way to speed this up. It's barely tolerable now, and upgrading gcc is not an option for everyone. Krzysztof

9 23

Re: [PATCH] Added 2 functions to shell32
by Jacek Caban March 1, 2005

March 1, 2005

> I doubt shell32 function on windows does this check, also original windows shell32 > function is a lot more complicated and longer, I've compared the results between > real and my code and they are correct. I wrote a small test for this function showing that your implementation is almost correct. It failes in two cases: 1. If a path ends with '\' and is compared with one that doesn't, then it's length is less than the other one, but both are the same paths. 2. If a path doesn't end with '\' and is compared with a longer one that has the same first len chars, but is not the same, ex: c:\test c:\test123 Changelog: Added test for PathIsEqualOrSubFolder Index: dlls/shell32/tests/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shellpath.c,v retrieving revision 1.6 diff -u -p -r1.6 shellpath.c --- dlls/shell32/tests/shellpath.c 10 Feb 2005 19:19:35 -0000 1.6 +++ dlls/shell32/tests/shellpath.c 28 Feb 2005 21:19:31 -0000 @@ -871,6 +871,55 @@ static void testNonExistentPath(void) userShellFolders); } +typedef BOOL (WINAPI*fnPathIsEqualOrSubFolder)(LPCWSTR path1, LPCWSTR path2); + +static void test_PathIsEqualOrSubFolder() +{ + fnPathIsEqualOrSubFolder pPathIsEqualOrSubFolder; + BOOL ret; + static const WCHAR path1[] = {'c',':','\\','t','e','s','t',0}; + static const WCHAR path2[] = {'c',':','\\','t','e','s','t','\\','t','e','s','t',0}; + static const WCHAR path3[] = {'c',':','\\','t','e','s','t','1','2','3',0}; + static const WCHAR path4[] = {'c',':','\\','t','e','s','t','\\',0}; + static const WCHAR path5[] = {'c',':','\\','t','e','s','t','\\','t','e','s','t','2', + '\\','.','.','\\','t','e','s','t',0}; + + pPathIsEqualOrSubFolder = GetProcAddress(hShell32, (LPSTR)755); + if(!pPathIsEqualOrSubFolder) + return; + +#define TEST_PATH(p1, p2, r) \ + ret = pPathIsEqualOrSubFolder(p1, p2); \ + ok(ret == r, "PathIsEqualOrSubFolder(" #p1 " " #p2 ") failed, expected: %x\n", r); + + TEST_PATH(path1, path1, TRUE); + TEST_PATH(path1, path2, TRUE); + TEST_PATH(path1, path3, FALSE); + TEST_PATH(path1, path4, TRUE); + TEST_PATH(path2, path1, FALSE); + TEST_PATH(path2, path2, TRUE); + TEST_PATH(path2, path3, FALSE); + TEST_PATH(path2, path4, FALSE); + TEST_PATH(path3, path1, FALSE); + TEST_PATH(path3, path2, FALSE); + TEST_PATH(path3, path3, TRUE); + TEST_PATH(path3, path4, FALSE); + TEST_PATH(path4, path1, TRUE); + TEST_PATH(path4, path2, TRUE); + TEST_PATH(path4, path3, FALSE); + TEST_PATH(path4, path4, TRUE); + TEST_PATH(path5, path1, FALSE); + TEST_PATH(path5, path2, FALSE); + TEST_PATH(path5, path3, FALSE); + TEST_PATH(path5, path4, FALSE); + TEST_PATH(path5, path5, TRUE); + TEST_PATH(NULL, path1, FALSE); + TEST_PATH(path1, NULL, FALSE); + TEST_PATH(NULL, NULL, FALSE); + +#undef TEST_PATH +} + START_TEST(shellpath) { if (!init()) return; @@ -892,5 +941,6 @@ START_TEST(shellpath) testWinDir(); testSystemDir(); testNonExistentPath(); + test_PathIsEqualOrSubFolder(); } }

3 2

New uninstaller
by Jonathan Ernst March 1, 2005

March 1, 2005

As requested, I'm trying to make a new uninstaller using a dialog instead of a window. It's my first windows program and I have something working but there are still some issues. If someone could help with some of the following problems, I'd be very thanfull. 1) Strange problem with UpdateWindow uninstaller.c, line 264 I implemented a search/filter field and I want to repaint the window after each input in the EDITTEXT control. However, when I call UpdateWindow on this line, the value returned is 1 so that a WM_PAINT message should be sent right ? But strangly no message is sent and I have to make something else (like moving the dialog) to force the window to repaint and filter the entries. The funny thing is that UpdateWindow on line 279 works just fine. I guess it's a bug in my code and not in Wine so I'd be glad if you could help me. 2) Improve filter code Currently I filter the entries that match exactly the filter string. I would like to at least make a case insensitive strstr on the string. What's the best way to do it (See uninstaller.c, line 235) 3) Stringtables a)Is there a way to load localized strings without having to guess beforehand the size of the string in each language ? b)Is there a way to not call LoadString for each string ? c)Where is the best place to load every string of a stringtable ? in main(), just before calling DialogBox() ? 4) Please tell me if you see things that are bad in the attached code, so that I'll fix it before submitting a patch. Thanks you for your help

7 13

Tools for identifying what a DLL provides?
by David D. Hagood March 1, 2005

March 1, 2005

I have a DLL from a manufacturer that I don't have the source for, nor do I have the header or the import library for. Since Wine developers frequently have to reverse engineer what a given DLL provides, does anybody have a good recommendation for a tool that can scan the DLL and report what functions it exports, and their arg types and return types?

4 4

Re: [programs/regedit] Use Favorit* instead of Favourit*
by Robert Shearman March 1, 2005

March 1, 2005

Paul Vriens wrote: >Hi, > >Our regedit displays Favourites in the menu. This patch changes that to >use Favorites. The patch also changes the variables with FAVOURITE in >the name. The reasoning is: > >a. Windows uses Favorite(s) all over the place. >b. We do too. > >That's the only reasoning and not if either one is better (UK/US etc..) > >No functional changes btw. > >Changelog > Change Favourite(s) into Favorite(s) > > Fair enough for strings in the English, US resources, as long as the strings in the English, Neutral resources are still spelt correctly. > Change variables containing FAVOURITE into FAVORITE > > Why do this? Rob

2 1

Crash in Polar Precision Performance Software
by Ron Jensen Feb. 28, 2005

Feb. 28, 2005

Hello, This trace is from Polar's Precision Performance Software http://www.codeweavers.com/site/compatibility/browse/name?app_id=681 running on CVS wine. This crash happens with CVS wine, and wine I compiled from http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz It does not happen with the precompiled binaries in CXOffice's Loki installer. Can someone give me a clue as to were to start looking to fix this? Thanks. /*******/ wineuser$wine 'C:\Program Files\Polar\Polar 32.exe' fixme:gdi:Escape16 unknown/unsupported 16-bit escape c03 (56,0x403815de,0x40381626 fixme:gdi:Escape16 unknown/unsupported 16-bit escape c03 (56,0x403815de,0x40381626 wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0xa84c73e0 in 32-bit code (0x00415809). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00415809 ESP:4069e63c EBP:4069e6c4 EFLAGS:00010282( - 00 - RIS1) EAX:00000000 EBX:4082f8d4 ECX:a84c73e0 EDX:000004e7 ESI:4069f3f0 EDI:00020040 Stack dump: 0x4069e63c: 00414e23 4069f3f0 000004e7 00020040 0x4069e64c: 4069f3f0 4069e6c4 4082f8d4 004144c9 0x4069e65c: 00020040 4069f3f0 000004e7 0052c3ec 0x4069e66c: 00020040 00000638 00020040 000000a0 0x4069e67c: 00020040 408517a8 4069e6c4 4082f8d4 0x4069e68c: 403d6a28 403d6980 00000000 4007aa04 Backtrace: =>1 0x00415809 in polar 32 (+0x15809) (0x4069e6c4) 2 0x407ae6c0 WINPROC_CallWndProc+0x70(msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069e700) 3 0x407b393e CallWindowProcA+0xfe(func=0x408517a8, hwnd=0x20040, msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:2940] in user32 (0x4069e72c) 4 0x4078ff36 DefDlgProcA(hwnd=0x20040, msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/defdlg.c:453] in user32 (0x4069e75c) 5 0x407ae277 WINPROC_wrapper+0x17 in user32 (0x4069e780) 6 0x407ae6c0 WINPROC_CallWndProc+0x70(msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069e7bc) 7 0x407b3be4 CallWindowProcW+0x184(func=0x4085145a, hwnd=0x20040, msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:3053] in user32 (0x4069eca0) 8 0x407e1d13 call_window_proc+0xc3(wparam=0x0, lparam=0x4069edf0, unicode=0x1, same_thread=0x1) [/home/wineuser/src/wine/dlls/user/message.c:1475] in user32 (0x4069ed00) 9 0x407e1eef SendMessageTimeoutW+0x14f(hwnd=0x20040, msg=0x4e, wparam=0x0, lparam=0x4069edf0, flags=0x0, timeout=0xffffffff, res_ptr=0x4069ed80) [/home/wineuser/src/wine/dlls/user/message.c:1989] in user32 (0x4069ed5c) 10 0x407e1f35 SendMessageW(hwnd=0x20040, msg=0x4e, wparam=0x0, lparam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/message.c:2070] in user32 (0x4069ed88) 11 0x406eee3b PROPSHEET_SetCurSel(skipdir=0x1, hpage=0x403e2cd0) [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:2102] in comctl32 (0x4069ee0c) 12 0x406f26c4 PROPSHEET_DialogProc(hwnd=0x4002e, uMsg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:3379] in comctl32 (0x4069f3f0) 13 0x407ae277 WINPROC_wrapper in user32 (0x4069f414) 14 0x407ae6c0 WINPROC_CallWndProc(msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069f450) 15 0x407b393e CallWindowProcA+0xfe(func=0x40851794, hwnd=0x4002e, msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:2940] in user32 (0x4069f47c) 16 0x4078ff36 DefDlgProcA(hwnd=0x4002e, msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/defdlg.c:453] in user32 (0x4069f4ac) 17 0x407ae277 WINPROC_wrapper+0x17 in user32 (0x4069f4d0) 18 0x407ae6c0 WINPROC_CallWndProc+0x70(msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069f50c) 19 0x407b3be4 CallWindowProcW+0x184(func=0x4085145a, hwnd=0x4002e, msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:3053] in user32 (0x4069f9f0) 20 0x407e1d13 call_window_proc+0xc3(wparam=0x0, lparam=0x403e2328, unicode=0x1, same_thread=0x1) [/home/wineuser/src/wine/dlls/user/message.c:1475] in user32 (0x4069fa50) 21 0x407e1eef SendMessageTimeoutW+0x14f(hwnd=0x4002e, msg=0x110, wparam=0x0, lparam=0x403e2328, flags=0x0, timeout=0xffffffff, res_ptr=0x4069fad0) [/home/wineuser/src/wine/dlls/user/message.c:1989] in user32 (0x4069faac) 22 0x407e1f35 SendMessageW(hwnd=0x4002e, msg=0x110, wparam=0x0, lparam=0x403e2328) [/home/wineuser/src/wine/dlls/user/message.c:2070] in user32 (0x4069fad8) 23 0x4079427e DIALOG_CreateIndirect(owner=0x1004e, dlgProc=0x406f1780, param=0x403e2328, unicode=0x0, modal=0x1) [/home/wineuser/src/wine/dlls/user/../../windows/dialog.c:667] in user32 (0x4069fbe4) 24 0x407946d9 DialogBoxIndirectParamAorW+0x39(hInstance=0x400000, template=0x403e17a8, owner=0x1004e, dlgProc=0x406f1780, param=0x403e2328, flags=0x2) [/home/wineuser/src/wine/dlls/user/../../windows/dialog.c:841] in user32 (0x4069fc08) 25 0x4079476b DialogBoxIndirectParamA(hInstance=0x400000, template=0x403e17a8, owner=0x1004e, dlgProc=0x406f1780, param=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/dialog.c:852] in user32 (0x4069fc2c) 26 0x406edb53 PROPSHEET_CreateDialog [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:729] in comctl32 (0x4069fc5c) 27 0x406f0961 PropertySheetA+0x2d1(lppsh=0x4069fca4) [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:2794] in comctl32 (0x4069fc80) 28 0x00414354 in polar 32 (+0x14354) (0x00000111) 29 0x00000000 (0x00000000) 0x00415809: cmpl %edx,0x0(%ecx) Wine-dbg>quit WineDbg terminated on pid 0x8

2 2

Help with winebuild/winegcc
by Ivan Leo Puoti Feb. 28, 2005

Feb. 28, 2005

Hello, I'm trying to get a program in the programs/ directory to export symbols, I've added -shared path/to/spec/spec.c to the linker command, but I now get a segmentation fault at startup. Can someone knowledgeable about winegcc/winebuild give me a suggestion/solution? I'm really stuck because of this and can't get on with safedisc support. Ivan.

1 0

Re: Implements OleLoadPicturePath
by Robert Shearman Feb. 28, 2005

Feb. 28, 2005

Maxime Bellengé wrote: >Hello, here is an implementation of OleLoadPicturePath. >The filename can be either a local file or an url. >In case of a url, I needed a user-agent for wininet. I put a dummy value >as I didn't find a default wine value. Is there a default value >somewhere for the whole project ? > >a+ > >Max > >ChangeLog: > * Implements OleLoadPicturePath > > > >------------------------------------------------------------------------ > >Index: wine/dlls/oleaut32/olepicture.c >=================================================================== >RCS file: /home/wine/wine/dlls/oleaut32/olepicture.c,v >retrieving revision 1.55 >diff -u -r1.55 olepicture.c >--- wine/dlls/oleaut32/olepicture.c 25 Feb 2005 14:07:57 -0000 1.55 >+++ wine/dlls/oleaut32/olepicture.c 27 Feb 2005 10:51:43 -0000 >@@ -71,7 +71,9 @@ > #include "olectl.h" > #include "oleauto.h" > #include "connpt.h" >+#include "wininet.h" > #include "wine/debug.h" >+#include "wine/unicode.h" > > #include "wine/wingdi16.h" > #include "cursoricon.h" >@@ -1998,11 +2000,122 @@ > DWORD dwReserved, OLE_COLOR clrReserved, REFIID riid, > LPVOID *ppvRet ) > { >- FIXME("(%s,%p,%ld,%08lx,%s,%p): stub\n", >+ static const WCHAR file[] = { 'f','i','l','e',':','/','/',0 }; >+ static const WCHAR name[] = { 'w','i','n','e','-','a','g','e','n','t',0}; >+ IPicture *ipicture; >+ HANDLE hFile; >+ DWORD dwFileSize; >+ HGLOBAL hGlobal = NULL; >+ DWORD dwBytesRead = 0; >+ IStream *stream; >+ BOOL bRead; >+ IPersistStream *pStream; >+ HRESULT hRes; >+ >+ TRACE("(%s,%p,%ld,%08lx,%s,%p): stub\n", > debugstr_w(szURLorPath), punkCaller, dwReserved, clrReserved, > debugstr_guid(riid), ppvRet); > >- return E_NOTIMPL; >+ if (!ppvRet) return E_POINTER; >+ >+ if (strncmpW(szURLorPath, file, 7) == 0) { >+ szURLorPath += 7; >+ >+ hFile = CreateFileW(szURLorPath, GENERIC_READ, 0, NULL, OPEN_EXISTING, >+ 0, NULL); >+ if (hFile == INVALID_HANDLE_VALUE) >+ return E_UNEXPECTED; >+ >+ dwFileSize = GetFileSize(hFile, NULL); >+ if (dwFileSize != INVALID_FILE_SIZE ) >+ { >+ hGlobal = GlobalAlloc(GMEM_FIXED,dwFileSize); >+ if ( hGlobal) >+ { >+ bRead = ReadFile(hFile, hGlobal, dwFileSize, &dwBytesRead, NULL); >+ if (!bRead) >+ { >+ GlobalFree(hGlobal); >+ hGlobal = 0; >+ } >+ } >+ } >+ CloseHandle(hFile); >+ } else { >+ HINTERNET hInternet; >+ BOOL res = FALSE; >+ >+ hInternet = InternetOpenW(name, INTERNET_OPEN_TYPE_PRECONFIG, NULL, >+ NULL, 0); >+ if (hInternet) >+ { >+ HINTERNET hFile; >+ hFile = InternetOpenUrlW(hInternet, szURLorPath, NULL, -1L, >+ INTERNET_FLAG_RESYNCHRONIZE, (DWORD_PTR)NULL); >+ if (hFile) >+ { >+ DWORD total = 4096; >+ DWORD nbRead; >+ >+ hGlobal = GlobalAlloc(GMEM_FIXED, 4096); >+ if (hGlobal) >+ { >+ do { >+ res = InternetReadFile(hFile, hGlobal, 4096, &nbRead); >+ if (res && (nbRead>0)) >+ { >+ HGLOBAL hNewGlobal; >+ hNewGlobal = GlobalReAlloc(hGlobal, total+4096, 0); >+ if (!hNewGlobal) >+ { >+ res = FALSE; >+ break; >+ } >+ } >+ } while (res && (nbRead>0)); >+ } >+ } >+ >+ InternetCloseHandle(hInternet); >+ } >+ if (!res) >+ { >+ GlobalFree(hGlobal); >+ } >+ } >+ >+ if (!hGlobal) >+ return E_UNEXPECTED; >+ >+ hRes = CreateStreamOnHGlobal(hGlobal, TRUE, &stream); >+ if (FAILED(hRes)) >+ { >+ if (stream != NULL) IStream_Release(stream); > > A valid stream will not be returned on failure, so no need for the extra check here. >+ GlobalFree(hGlobal); >+ return hRes; >+ } >+ >+ hRes = CoCreateInstance(&CLSID_StdPicture, punkCaller, CLSCTX_INPROC_SERVER, >+ &IID_IPicture, (LPVOID*)&ipicture); >+ if (hRes != S_OK) { > > Lack of cleanup code here. >+ return hRes; >+ } >+ >+ hRes = IPicture_QueryInterface(ipicture, &IID_IPersistStream, (LPVOID*)&pStream); >+ if (hRes) { >+ IPicture_Release(ipicture); > > And here. >+ return hRes; >+ } >+ >+ IPersistStream_Load(pStream, stream); > > You should probably check the return value from this function as it is kinda vital to the function you are implementing. >+ IPersistStream_Release(pStream); >+ IStream_Release(stream); >+ hRes = IPicture_QueryInterface(ipicture,riid,ppvRet); >+ if (hRes) >+ FIXME("Failed to get interface %s from IPicture.\n",debugstr_guid(riid)); >+ >+ IPicture_Release(ipicture); >+ return hRes; > } > > /******************************************************************************* > > >Index: wine/dlls/oleaut32/Makefile.in >=================================================================== >RCS file: /home/wine/wine/dlls/oleaut32/Makefile.in,v >retrieving revision 1.57 >diff -u -r1.57 Makefile.in >--- wine/dlls/oleaut32/Makefile.in 27 Oct 2004 00:47:53 -0000 1.57 >+++ wine/dlls/oleaut32/Makefile.in 27 Feb 2005 10:52:08 -0000 >@@ -4,7 +4,7 @@ > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = oleaut32.dll >-IMPORTS = ole32 rpcrt4 user32 gdi32 advapi32 kernel32 ntdll >+IMPORTS = ole32 rpcrt4 user32 gdi32 advapi32 kernel32 ntdll wininet > DELAYIMPORTS = comctl32 > EXTRALIBS = $(LIBUNICODE) -luuid > > I don't think oleaut32 should be importing from wininet for just the implementation of OleLoadPicturePath. It surprises me that there is not already an implementation of IStream for URLs that can be re-used. If there is no alternative, I think we should just make wininet a delayed import. Rob

2 1

Re: [QUARTZ] Handle End Of Stream notifications
by Robert Shearman Feb. 28, 2005

Feb. 28, 2005

Christian Costa wrote: >Index: dlls/quartz/dsoundrender.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/dsoundrender.c,v >retrieving revision 1.6 >diff -u -r1.6 dsoundrender.c >--- dlls/quartz/dsoundrender.c 6 Jan 2005 19:36:47 -0000 1.6 >+++ dlls/quartz/dsoundrender.c 27 Feb 2005 20:48:17 -0000 >@@ -550,8 +550,8 @@ > > static HRESULT WINAPI DSoundRender_JoinFilterGraph(IBaseFilter * iface, IFilterGraph *pGraph, LPCWSTR pName) > { >- HRESULT hr; > DSoundRenderImpl *This = (DSoundRenderImpl *)iface; >+ HRESULT hr = S_OK; > > TRACE("(%p/%p)->(%p, %s)\n", This, iface, pGraph, debugstr_w(pName)); > >@@ -563,7 +563,14 @@ > *This->filterInfo.achName = '\0'; > This->filterInfo.pGraph = pGraph; /* NOTE: do NOT increase ref. count */ > >- hr = IFilterGraph_QueryInterface(pGraph, &IID_IMediaEventSink, (LPVOID*)&This->pEventSink); >+ This->pEventSink = NULL; >+ if (pGraph) >+ { >+ /* Cache IMediaEventSink interface w/o increasing filtergraph refcount */ > > I appreciate that this works perfectly fine at the moment, but these kind of assumptions can lead to difficult to track memory corruptions, so it would be best to avoid caching the object here and querying for it when it's needed. >+ hr = IFilterGraph_QueryInterface(pGraph, &IID_IMediaEventSink, (LPVOID*)&This->pEventSink); >+ if (SUCCEEDED(hr)) >+ IMediaEventSink_Release(This->pEventSink); >+ } > } > LeaveCriticalSection(&This->csFilter); > > Rob

1 0