February 2005 - Wine-Devel - list.winehq.org

Text Alignment, how is it handled ?
by George Ginden Feb. 10, 2005

Feb. 10, 2005

Hi the following code part is not working in Wine as it work (as supposed) in Windows. HRight = GetDlgItem (hDlg,IDC_RIGHT); Edit_SetText(HRight, "Right"); How is text alignment, in a edit field, handled ? It looks like the Edit_SetText function is mapped to SetWindowText, which calls X11DRV_SetWindowText... But again, text alignment doesn't work. Can I do something ? PS: c source code is attacched Regards. /* ** Ditta..........:TeamSystem spa ** Programmatore..:Stefano Peraldini ** Nome programma.:Test Wine ** Data...........:04/02/2005 ** */ //INCLUDE #include <windows.h> #include <WindowsX.h> #include "resource.h" //VARIABILI GLOBALI HWND hUnaligned, HCenter, HRight; HDC hdc; //PROTOTIPI BOOL CALLBACK DlgProc (HWND, UINT, WPARAM, LPARAM); //MAIN int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpszCmdLine, int nCmdShow) { // Visualizzazione e controllo errore visualizzazione dialog if (DialogBox (hInstance, (LPCSTR) IDD_DIALOG1, NULL, DlgProc) == -1) MessageBox (NULL, "Errore visualizzazione dialog!!","Test Wine", MB_ICONQUESTION | MB_OK); return 0; } //DLGPROC della dialog1 BOOL CALLBACK DlgProc (HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) { //Switch per la gestione dei messaggi provenienti dalla dialog1 switch (message) { //Gestione del VM_CLOSE case WM_CLOSE: return TRUE; break; //Impostazione dialog1 case WM_INITDIALOG: { hUnaligned = GetDlgItem (hDlg,IDC_UNALIGNED); HCenter = GetDlgItem (hDlg,IDC_CENTER); HRight = GetDlgItem (hDlg,IDC_RIGHT); //Edit Box Unaligned Edit_SetText(hUnaligned, "Unaligned"); //Edit Box Center Edit_SetText(HCenter, "Center"); //Edit Box Right Edit_SetText(HRight, "Right"); return TRUE; } //Gestione messaggi dialog1 case WM_COMMAND: switch (LOWORD (wParam)) { case IDOK: EndDialog (hDlg, 0); return TRUE; break; // END WMCOMMAND } return FALSE; } return FALSE; }

4 4

Re: RESEND: dlls/comctl32/treeview.c: remove repainting
by Robert Shearman Feb. 10, 2005

Feb. 10, 2005

yuxdwa702(a)sneakemail.com wrote: > Changelog: > tinus <yuxdwa702(a)sneakemail.com> > Scroll instead of repainting when expanding/collapsing trees > Don't repaint on hover if 'hot tracking' isn't on > > > Index: dlls/comctl32/treeview.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/treeview.c,v > retrieving revision 1.164 > diff -u -p -r1.164 treeview.c > --- dlls/comctl32/treeview.c 14 Jan 2005 15:13:24 -0000 1.164 > +++ dlls/comctl32/treeview.c 31 Jan 2005 01:51:30 -0000 > @@ -631,7 +631,8 @@ TREEVIEW_SendCustomDrawItemNotify(TREEVI > uItemState |= CDIS_SELECTED; > if (wineItem == infoPtr->selectedItem) > uItemState |= CDIS_FOCUS; > - if (wineItem == infoPtr->hotItem) > + /* I'm not sure of this, needs to be compared to the real thing */ Usually you find this out before submitting a patch. > + if ((infoPtr->dwStyle & TVS_TRACKSELECT) && wineItem == > infoPtr->hotItem) > uItemState |= CDIS_HOT; > @@ -5037,11 +5107,13 @@ TREEVIEW_KeyDown(TREEVIEW_INFO *infoPtr, > static LRESULT > TREEVIEW_MouseLeave (TREEVIEW_INFO * infoPtr) > { > - if (infoPtr->hotItem) > + HTREEITEM orgItem = infoPtr->hotItem; > + infoPtr->hotItem = NULL; > + > + /* remove hot effect from item */ > + if (infoPtr->dwStyle & TVS_TRACKSELECT) > { > - /* remove hot effect from item */ > - InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, TRUE); > - infoPtr->hotItem = NULL; > + InvalidateRect(infoPtr->hwnd, &orgItem->rect, TRUE); > } > return 0; > } If hot tracking isn't required when TVS_TRACKSELECT isn't set, then don't call TrackMouseEvent, instead of putting these exceptions everywhere. > @@ -5080,11 +5152,11 @@ TREEVIEW_MouseMove (TREEVIEW_INFO * info > if (item != infoPtr->hotItem) > { > /* redraw old hot item */ > - if (infoPtr->hotItem) > + if (infoPtr->hotItem && (infoPtr->dwStyle & TVS_TRACKSELECT) ) > InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, > TRUE); > infoPtr->hotItem = item; > /* redraw new hot item */ > - if (infoPtr->hotItem) > + if (infoPtr->hotItem && (infoPtr->dwStyle & TVS_TRACKSELECT) ) > InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, > TRUE); > Same here. Don't change the hot item if the hot item isn't going to be repainted anyway. Rob

1 0

Re: rsaenh: CPGetProvParam's PP_ENUMCONTAINERS
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > Changelog: > Implemented CPGetProvParam's PP_ENUMCONTAINERS parameter type > Added corresponding test > Removed some tabs that slipped in with the last patch The test fails for me: rsaenh.c:1383: Test failed: 00000103 rsaenh.c:1391: Test failed: 0, 00000103 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [Discuss] Recycle Bin problem with Preclick image editing software
by Mike Hearn Feb. 9, 2005

Feb. 9, 2005

On Wed, 2005-02-09 at 15:34 -0500, Don Feliciano wrote: > SUCCESS! Woo Hoo! You rock... now my wife can't tell me b*tch at me > for ditching Windows. Thanks a ton. Niceness Don. Of course, it'd rock more if this had worked out of the box. I expect we're missing some shell magic for the recycle bin. Wouldn't be hard to investigate but have a million other things to do so I'll CC this to wine-devel. Context is: app has a "send to recycle bin" option to delete photos. Doesn't work. Native shell32/shfolder fixes it. If anybody is up for what is probably an easy task, figure out why and fix it so c:\Recycled is used. For bonus points we should bridge it to KDE/GNOME so if an app recycles something it appears in your actual trash can :) thanks -mike

3 2

Re: Rearrange WINPROC_CallWndProc to give clearer tracing
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Mike Hearn <mh(a)codeweavers.com> writes: > Yes, I realised the stack allocation might be a problem but only a while > after I sent the patch. Here's another that uses the heap. I don't think you want that either, it won't really make things less confusing if you are adding extra heap calls. You may want to look into using RelayFromExclude instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Rearrange WINPROC_CallWndProc to give clearer tracing
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Mike Hearn <mh(a)codeweavers.com> writes: > ChangeLog: > Rearrange WINPROC_CallWndProc to give clearer tracing > > --- windows/winproc.c (revision 132) > +++ windows/winproc.c (local) > @@ -408,20 +408,25 @@ static LRESULT WINPROC_CallWndProc( WNDP > { > LRESULT retvalue; > int iWndsLocks; > + char msgname[1024]; You don't want to do that, window procs can be nested quite deeply. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: x86_64 multilib configure fix
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Alex Woods <wine-devel(a)giblets.org> writes: > Changelog: > * configure.ac: Alex Woods <wine-devel(a)giblets.org> > Handle host_cpu of x86_64 like other x86s. This will break the 64-bit build. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: More complete stubs for DuplicateTokenEx and NtAdjustPrivilegesToken
by Rob Shearman Feb. 9, 2005

Feb. 9, 2005

Dmitry Timoshkov wrote: >Hello, > >Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > More complete stubs for DuplicateTokenEx and NtAdjustPrivilegesToken. > > I have an even more complete patch for this that implements the necessary server calls. Alexandre, please don't apply. Rob

1 0

Broken cross-build, again.
by Paul Millar Feb. 9, 2005

Feb. 9, 2005

Hi everyone, Just a head's up that the new tests broken cross-building winetest.exe. The gory details are reproduced below. I'm afraid I'm away for a long weekend, without net access, so can't fix any until I'm back (Wednesday). Cheers, Paul. [paulm(a)quisquiliae tests]$ make i686-mingw32msvc-gcc clist.o clsid.o generated.o ordinal.o path.o shreg.o string.o testlist.o -o shlwapi_test.exe -lshlwapi -ladvapi32 -lole32 -loleaut32 path.o(.text+0x20bb): In function `test_PathIsValidCharA': /home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:653: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x2106):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:656: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x2152):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:661: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x21c2):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:669: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x224b): In function `test_PathIsValidCharW': /home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:681: undefined reference to `PathIsValidCharW(a)8' path.o(.text+0x2296):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:684: undefined reference to `PathIsValidCharW(a)8' path.o(.text+0x22e0):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:689: undefined reference to `PathIsValidCharW(a)8' path.o(.text+0x2350):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:697: undefined reference to `PathIsValidCharW(a)8' distcc[26570] ERROR: compile on localhost failed make: *** [shlwapi_test.exe] Error 1

3 3

IDC_RIGHT, IDC_CENTER not defined ?
by George Ginden Feb. 9, 2005

Feb. 9, 2005

OK I'm trying to implement text alignment in the edit control. Now, one question how do I know (in the EDIT_WM_NCCreate for example) if the text alignment has been requested by the programmer ? I guess the GetDlgItem function on es->hwndParent should do the job... but IDC_RIGHT and IDC_LEFT are not defined. So How can I get check for the requested alignment ? Regards.

3 3

Re: dlls/shell32/cpanelfolder.c - extended
by Dmitry Timoshkov Feb. 9, 2005

Feb. 9, 2005

"Ge van Geldorp" <gvg(a)reactos.com> wrote: > memcpy(&sei_tmp, psei, sizeof(sei_tmp)); > sei_tmp.lpFile = path; > sei_tmp.fMask &= ~SEE_MASK_INVOKEIDLIST; > + sei_tmp.lpVerb = L"cplopen"; You can't use unicode literals in Wine, you need to explicitly declare them. -- Dmitry.

1 0

Regression in "Star wars: The Phantom Menace"
by Carlos Lozano Feb. 8, 2005

Feb. 8, 2005

Hello, The patch: http://www.winehq.org/hypermail/wine-cvs/2005/01/0612.html Log message: Rein Klazes <wijn(a)wanadoo.nl> Get rid of the rdtsc cpu instruction method for calculation of the performance counter. Put the calculation (based on gettimeofday) in NtQueryPerformanceCounter() and use that in the kernel functions. Causes regression in the game "Star Wars: The Phantom Menace". The game was playable before of the patch, now it is freezes in the 3th title screen. Regards, Carlos. -- ___ _ \ | / Consulting | . |._ _ _| | ___ ___ ___ http://www.andago.com | || ' |/ . |<_> |/ . |/ . \__ GNU/Linux |_|_||_|_|\___|<___|\_. |\___/ _ \ __|\ \ / Carlos A. Lozano <___'/ | \ -_) __/\__ \ > < -_) [ carlos.lozano(a)andago.com ]\___|_| ____/ _/\_\___| [ calb(a)epsxe.com ] http://www.ePSXe.com

3 3

Lotus Notes - still broken
by Paul R Streitman Feb. 8, 2005

Feb. 8, 2005

This is not intended to be a nag, but since so very much has gone into CVS in the two months since 12/07 I thought that I would try today's CVS level with Lotus Notes. As the subject says, it is still broken. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

2 2

Re: winrash bug
by Chris Morgan Feb. 8, 2005

Feb. 8, 2005

Is this based on what the installer displays or upon output from winrash in the debug.txt file? Chris > > From: Ivan Leo Puoti <ivanleo(a)gmail.com> > Date: 2005/02/08 Tue PM 01:35:43 EST > To: wine-devel(a)winehq.com > Subject: winrash bug > > version 0011 incorrectly detects windows nt 4.0 as windows 95. > > Ivan. > >

2 1

winrash bug
by Ivan Leo Puoti Feb. 8, 2005

Feb. 8, 2005

version 0011 incorrectly detects windows nt 4.0 as windows 95. Ivan.

1 0

Re: Tests for bug 2686
by Alexandre Julliard Feb. 8, 2005

Feb. 8, 2005

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > Here's some tests which show the problem reported as bug 2686. I tried to > find a way to fix it but its not simple. (Note I can only confirm that XP > behaves as described). On XP yes, but it will fail on Win9x, the API doesn't guarantee that the returned size will be identical to the allocated size. Unless you have a real app that depends on that I don't think there's much point in doing that test. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: MSIEXEC: fix command line parsing
by Alexandre Julliard Feb. 8, 2005

Feb. 8, 2005

Mike McCormack <mike(a)codeweavers.com> writes: > ChangeLog: > * Fix msiexec's command line parsing. What does msiexec require that the standard command-line parsing cannot support? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: bi-arch on an amd64
by Alex Woods Feb. 8, 2005

Feb. 8, 2005

Hi, I too am trying to compile a working multilib wine. I have got a little further, and actually have a binary that doesn't produce any errors now. Unfortunately, it doesn't seem to do anything at all, and just returns me to the command line with an exit status of 2. I've yet to dig into that one. For reference, I am using gentoo with a multilib gcc, applying the attached patch and then running this sequence of commands: autoconf ./configure --x-libraries=/emul/linux/x86/usr/X11R6/lib make depend && make The small patch I've attached fixes the two problems I came across - one already mentioned by Gabriel de Perthuis. That problem appears to be one of a deprecated? syscall. The other problem is that configure was not detecting x86_64 as being an x86 and hence not building the wine-preloader which is why Gabriel was getting his strange 'wine: could not exec \uffff\uffffmU\uffff\uffffmUp/bin/wine-pthread' message. Should I send the patch to wine-patches also? Or can it make its way into CVS from here? I'm going to see if I can track down which exit(2) I'm hitting now. I'm new to the wine source code, so any suggestions are welcome. -- Alex

1 3

Re: widl: let widl understand typedef enum
by Huw D M Davies Feb. 8, 2005

Feb. 8, 2005

On Sun, Feb 06, 2005 at 09:31:37AM -0500, Vincent Béron wrote: > Le dim 06/02/2005 à 09:01, Mike Hearn a écrit : > > On Sat, 05 Feb 2005 12:37:08 -0600, Rob Shearman wrote: > > > Yeah, it seems strange, but I have a test program here that shows it is > > > 32-bits application-side for proxies/stubs. > > > > There's all kinds of brokenness going on in their variant marshalling, eg > > some types are mapped seemingly at random to others. I have a list with > > some of the details around here somewhere, but I'd totally believe > > whatever Rob says on this no matter how weird. > > VT_I4 it is then. > > This supercedes my widl3.diff patch. > > Changelog: > A RPC_FC_ENUM16 is a VT_I4. Actually this should be VT_USERDEFINED. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Wine for Linux PPC emulate Mac OS
by M-Rick Feb. 8, 2005

Feb. 8, 2005

The Wine http://www.winehq.com/ project has been created to emulate Windows to be able to run windows softwares directly under Linux without to have to emulate Windows. It's very great and wonderful idea ! The Darwine http://darwine.opendarwin.org/ project aims to to the same but under Mac OS X with adding also the emulation of an x86 CPU. But, I wanted to know something, or even to make a proposal. Would it be possible to make a special Wine version for Linux PPC that instead of emulating Windows would emulate Mac OS ? Yes there's already the very great Mac On Linux PPC (MOL) http://www.maconlinux.org/ that can let run Mac OS applications, but you have to run Mac OS in parallel ... It is great, but Mac OS takes rooms and CPU and for some usages, maybe it is not completely useful. Would it be possible to make such a software a WinePPC for exemple that would let run Microsoft Office X 2004 Mac or Adobe CS Mac or Macromedia MX Mac directly under Linux PPC without having to install a Mac OS ? To make simple to run Mac OS softwares directly under the Linux desktop environment.

6 6

Re: dsound: Properly implement DllCanUnloadNow
by Robert Reif Feb. 8, 2005

Feb. 8, 2005

James Hawkins wrote: >Hi, > >Changelog >* Properly implement DllCanUnloadNow ref counting. > > > dsound.dll is a strange dll that doesn't really follow proper COM reference counting rules for buffers. This is intentional by Microsoft (don't know why) and was made common by the example code from "Inside Direct X" . You may want to add a test to the dsound.dll regression tests to verify what Microsoft does.

2 2

[oleaut32/typelib.c] TLB_ReadTypeLib question
by Paul Vriens Feb. 7, 2005

Feb. 7, 2005

Hi, while browsing through typelib.c I saw: 287 */ 288 int TLB_ReadTypeLib(LPCWSTR file, INT index, ITypeLib2 **ppTypelib); 289 290 HRESULT WINAPI LoadTypeLib( Is line 288 supposed to be there ? Cheers, Paul.

2 1

Re: widl: support ATTR_READONLY for interface properties
by Huw D M Davies Feb. 7, 2005

Feb. 7, 2005

On Sun, Feb 06, 2005 at 09:50:31AM -0500, Vincent Béron wrote: > There are probably other easy ones like this one, but for now I only > need this one. > > Huw, am I stepping on your toes? Nope, but I do have some more patches left in my tree that I need to tidy up a bit before submitting - notably support for modules. I've almost got a version of stdole2.tlb too... But feel free to carry on. Cheers, Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re-examining SetThreadContext
by Mike Hearn Feb. 7, 2005

Feb. 7, 2005

Hi Alexandre, A user recently reported another app that doesn't work due to Armadillo copy protection. This scheme requires SetThreadContext/GetThreadContext to work properly and currently they do not. These two functions require the thread to be suspended, therefore they always return a bogus context (blocking on a wineserver wait pipe). I wrote a patch for this a while ago: http://navi.cx/svn/misc/trunk/winekb/patches/thread-context.patch However you felt it had races in it. There were two possible races I could see: - The race between suspending the thread and the sigcontext being uploaded. This was not a problem with my patch as Get/SetThreadContext loop. - A race where you can call SuspendThread again before the SIGUSR1 handler has completed. I believe this was the sticking point last time, no? But I can't see how this can happen because SIGUSR1 is blocked while it's being handled. So in the following sequence: PROCESS A: SuspendThread() PROCESS A: GetThreadContext() PROCESS B: SIGUSR1 PROCESS B: upload sigcontext PROCESS B: block PROCESS A: GetThreadContext() returns PROCESS A: ResumeThread PROCESS B: unblock, download sigcontext, restore, finish I do not see where the races are. Could you please re-examine this patch and let me know if there are any more problems with it? Dealing with the set/thread context operations in SIGUSR1 makes sense because they are only allowed when the target thread is suspended. thanks -mike

2 5

Re: wine/dlls/dbghelp elf_module.c
by Eric Pouech Feb. 7, 2005

Feb. 7, 2005

Alexandre Julliard a écrit : > ChangeSet ID: 15811 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2005/01/31 10:24:57 > > Modified files: > dlls/dbghelp : elf_module.c > > Log message: > Silence a noisy FIXME I fear that the issue may be somewhere else than the pure FIXME. Can you describe what actually happened ? A+ -- Eric Pouech

2 1