February 2005 - Wine-Devel - list.winehq.org

How do native win32 apps end up calling into x11drv?
by Adam Connell Feb. 25, 2005

Feb. 25, 2005

Greetings, I'm trying to understand how windows drawing gets translated into X in wine and so I was looking at the {im,ex}ports of x11drv and gdi32. x11drv depends on gdi32 and just seems to export a good chunk of the api that gdi32 exports (BitBlt etc). gdi32 doesn't depend on x11drv or even Xlib. How do native win32 apps end up calling into x11drv? Cheers, Adam

2 1

Re: setupapi: enumerate serial ports
by Alexandre Julliard Feb. 25, 2005

Feb. 25, 2005

Juan Lang <juan_lang(a)yahoo.com> writes: > +/* Based on code from winspool's info.c */ > +static UINT SETUP_CountSerialPorts(void) > +{ > + UINT i, ret; > + > + /* FIXME: it should be possible for more than four COM ports to exist, not > + * sure why we retain that limit, but winspool does too so go with it. > + */ > + for (i = 0, ret = 0; i < 4; i++) > + { > + if (SETUP_SerialPortExists(i)) > + ret++; > + } > + TRACE("returning %d\n", ret); > + return ret; > +} It would probably be better to use QueryDosDevice here. -- Alexandre Julliard julliard(a)winehq.org

2 2

using safe string functions in wine
by James Hawkins Feb. 25, 2005

Feb. 25, 2005

Hey, While perusing msdn recently, I stumbled across string safe functions. These functions were created to replace the standard c string handling routines. The following are some design criteria of string safe functions (msdn): * Always NULL-terminate the string. * Always take a destination buffer size. * Always return consistent return codes (an HRESULT). * Support 32-bit and 64-bit environments. * Flexibility. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnsecure/h… What is your opinion on whether we should implement and use either the user-mode or kernel-mode (or both) string safe functions? Using these functions instead of the standard c string functions would promote consistency and security in the wine code base. On the other hand, using these functions adds another layer of calls to the code. What are other pro's and con's of using string safe functions? -- James Hawkins

3 2

Microsoft admits targeting Wine users
by Tom Feb. 25, 2005

Feb. 25, 2005

Here is the link: http://news.zdnet.co.uk/0,39020330,39189180,00.htm Tom

3 2

While we're saying thanks, another thing that works is...
by Holly Bostick Feb. 25, 2005

Feb. 25, 2005

... the Neverwinter Nights Toolset. Amazingly enough, after I had followed a whole lot of very complex instructions in order to download and compile some half-ancient version of WineX (3.3.2), patch it to nwwine (which is the common name of the patched version that is supposed to get the toolset working; it's in Portage and everything), and add Registry entries and native dlls, it turned out that the toolset ran 'perfectly well' under regular old Wine 20050211 (and in fact not very well under nwwine; couldn't use the menus, etc.). My wine is all hacked together atm, so I'll have to do a clean install to see if it needs anything special other than a couple of native dlls (that it might not need, but I had installed them to the program folder for nwwine) before attempting to add it to the appdb, but it definitely works. I've added custom content to all 7 of the Original Campaign modules using it (and the game is using the content properly, so it's correctly added). Oh, and by the way, thanks for the fix of the titlebars; it's really really nice to have the same window decorations in Wine programs as on the rest of the desktop. Just noticed it today (can't believe I didn't before) and wanted to let you know I appreciate it. Holly

1 0

WineConf agenda ideas
by Brian Vincent Feb. 25, 2005

Feb. 25, 2005

Over the the past week or so I've harassed some folks about the agenda for WineConf. At this point there's a lot that remains to be filled in, but I need some feedback. Also, I need more ideas for presentations. Does anyone want to present something? It'd be great if someone would volunteer. I think what we're shooting for is a presentation followed by discussion all contained within about one hour. In total we'll have 10 - 12 different topics. Here's the items that are definitely going to be on the agenda: WRS intro Keynote - Alexandre Road to .9 and 1.0 - Dimi ReactOS update - all the ReactOS guys Wine / networking / Samba issues - Juan Lang We've also got some other items, but I need feedback as to whether any of you find this stuff interesting. (So reply and tell me if any of these items sound interesting.) Windows authentication - Andrew Bartlett (um.. haven't asked him yet though) Something else Samba related? - Samba guys Commercial port of a Winelib app and using Wine - an enterprise user CXTest and regression testing - someone from CodeWeavers Version control - Mike Hearn wearing a fire retardant suit DCOM work - Mike or Rob DirectX update - ? Also, if you need to make hotel reservations, there's just a few weeks left to do that. Check out the WineConf page for details: http://www.winehq.org/site/wineconf As people begin to figure out travel plans, the wineconf mailing list will pick up. How to join: http://www.winehq.org/mailman/listinfo/wineconf Let me know if you have any questions. -Brian

1 0

Re: [winecfg] Drive autodetection
by Mike Hearn Feb. 25, 2005

Feb. 25, 2005

Paul van Schayck wrote: > Changelog: > As last option for drive type detection we try the device node name. Looks good but please try and use the same code style as in the rest of the program. In particular note that winecfg doesn't use Hungarian notation anywhere, eg "szNode" would just be "node" or "nodename". thanks -mike

2 2

Re: wsock32 conformance test
by Juan Lang Feb. 25, 2005

Feb. 25, 2005

Hey guys, nice work. Minor comments below: > +/* we often pass this size by reference */ > +int sizeofSOCKADDR_IN = sizeof(SOCKADDR_IN); When you pass it by reference, you don't reinitialize it after a call that might modify it, e.g. here: > + /* get port number */ > + getsockname(*sock, (SOCKADDR *) &tmpAddr, &sizeofSOCKADDR_IN); I think it'd be safer to declare a local int initialized to sizeof(SOCKADDR_IN) and pass this by ref instead. > + for (connIndex = 0; connIndex < NUM_CLIENTS; connIndex++) { > + /* accept connection */ > + tmpSock = accept(*sock, (SOCKADDR *) &tmpSockAddr, &sizeofSOCKADDR_IN); Your indenting's off here. (Do you have to use tabs? Ick.) > + connection->serverThread.Handle = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) &BlockingServerConnection_Run, connection, 0, &connection->serverThread.ID); Please wrap long lines. > + const int numTests = 3; Might as well make that static too. Props for first post :) --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: SHELL32: implement loading and saving of MSI advertised shortcut info
by Juan Lang Feb. 25, 2005

Feb. 25, 2005

Hi Mike, > + * in that string is parsed an stored. s/an/and/ > +typedef struct volume_info_t > +{ > + DWORD type; > + DWORD serial; > + WCHAR label[12]; /* assume 8.3 */ Shouldn't label's size be 13? 8+3+'.'+NULL? > + if( (buffer.magic&0xffff0000) != 0xa0000000 ) A symbolic constant would be nice here. Thanks, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Compiling wine dlls for windows
by Michael Jung Feb. 25, 2005

Feb. 25, 2005

Hello, I would like to test a wine dll I'm working on on windows. Could you please tell me how the wine dlls are build for windows ? (Or beat me to the the place where it is documented.) Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

4 4

Re: [RESEND2] Uninstaller localization
by Dmitry Timoshkov Feb. 25, 2005

Feb. 25, 2005

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > Next I'll change the window to a dialog if I can. Thanks. > - wc.lpszClassName = appname; > + wc.lpszClassName = sAppname; > > if (!RegisterClass(&wc)) exit(1); > - hWnd = CreateWindow( appname, "Wine Application Uninstaller", > + hWnd = CreateWindow( sAppname, sAppname, Sorry for not pointing out to it earlier, but it's better to leave the window class name in ASCII. -- Dmitry.

1 0

Re: working installshield?
by Robert Shearman Feb. 25, 2005

Feb. 25, 2005

Marcus Meissner wrote: >Hi, > >Is there any chance to have a working installshield at some time? > >I don't really want to fall back to the december or even earlier WINE >releases for our spring SUSE Linux product ;) > > I haven't been testing against InstallShield for a while, but last time I checked it was hanging because we do not process window messages during RPCs. If you want to implement this yourself, I can give you details on how to do this. I will get around to this eventually, but at the moment I have other priorities. If the worst happens and InstallShield is still not working, then you can still ship the December ole32 with the most recent Wine. Rob

2 2

WINE: Rendering in Diamond2.x works :-)
by Tobias Burnus Feb. 25, 2005

Feb. 25, 2005

Hello, I'd like to thank the Winegrowers for providing such a nice flavoured Wine. With the current version, the program Diamond is even able to render the output (at least if one turns off the double buffering): w/o rendering: http://www.physik.fu-berlin.de/~tburnus/wine/diamond2.png w/ rendering: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_rend.png (somehow the menu/tool/status bars are not correctly redrawn and the rendering seems to be too low by the height of a toolbar, but rendering works :-) and hitting Shift-Ctrl-N now works as well (thanks to Dimitry!). Tobias

1 0

wsock32 conformance test
by Thomas Kho Feb. 25, 2005

Feb. 25, 2005

Hi, We're working on a set of tests for wsock32.dll. So far we've completed a test of blocking network I/O with multiple threads. Before we post to wine-patches, we'd appreciate any critiques/input. Fredy, Doug, and I are UCLA undergraduates in a software engineering course. Thanks for your help, Thomas Kho cc: Fredy Garcia, Douglas Rosenberg (group members) Files available at: http://www.geekymedia.com/viewcvs/cgi/viewcvs.cgi/wine4/wine/dlls/wsock32/t…

1 0

Re: [RESEND] Uninstaller localization
by Dmitry Timoshkov Feb. 25, 2005

Feb. 25, 2005

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > This time I didn't translate the WINE_ERR messages and translated another messagebox. It would be better to not touch WINE_ERR lines at all then. > Changelog: > - localization of uninstaller > + /* We load the strings */ > + LoadString( hInst, IDS_APPNAME, sAppname, sizeof(sAppname)); ... > - wc.hIcon = LoadIcon( hInst, appname ); > + wc.hIcon = LoadIcon( hInst, sAppname ); LoadIcon will always fail in the localized case. -- Dmitry.

1 0

Re: Fix recently introduced SEGV in DOCFILE IStorage implementation
by Troy Rollo Feb. 24, 2005

Feb. 24, 2005

On Thursday 24 February 2005 20:39, Paul Vriens wrote: > Could you send the patch to wine-patches :-). Damn, another typo on my part (I meant it to go there in the first place) On Friday 25 February 2005 03:26, Mike McCormack wrote: > Thanks for finding this problem. I think the root cause of the problem > is that three structures that need to be the same require 3 seperate > tweaks. > > Can you confirm that this patch also fixes the problem for you? I probably could, but given the nature of your patch there's a much more efficient test that should give much greater confidence in it - compiling the affected source files without debugging information using your patch and mine should give identical object files (except for time stamps in the object file headers).

1 1

broken faq.sgml
by Vitaly Lipatov Feb. 24, 2005

Feb. 24, 2005

Patch http://cvs.winehq.org/patch.py?id=16300 breaks faq.sgml in line <question id="Can-I-bundle-everything-in-one-huge-executable"> during compiling: jade:/home/lav/RPM/BUILD/wine-20050224/documentation/faq.sgml:1716:66:Q: length of name token must not exceed NAMELEN (44) -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Fix recently introduced SEGV in DOCFILE IStorage implementation
by Paul Vriens Feb. 24, 2005

Feb. 24, 2005

On Thu, 2005-02-24 at 17:26, Mike McCormack wrote: > Troy Rollo wrote: > > After changing StorageBaseImpl, StorageInternalImpl was not updated to reflect > > the change. > > Thanks for finding this problem. I think the root cause of the problem > is that three structures that need to be the same require 3 seperate tweaks. > > Can you confirm that this patch also fixes the problem for you? > > thanks, > > Mike > Hi Mike, this fixes one of the problems I had with the Uru_Ages_Beyond_Myst_Demo. I still have problems with InstallShield but that's a known problem, and worked on ;-). Cheers, Paul.

1 0

Re: Child windows require IsWindowVisible() test in DestroyWindow()
by Dmitry Timoshkov Feb. 24, 2005

Feb. 24, 2005

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > in the msg.c,test_DestroyWindow() test case adding WS_VISIBLE to all > windows except a parent shows that behaviour doesn't change for child > windows but a popup window starts to receive WM_WINDOWPOSCHANGING and > friends indicating that child windows require IsWindowVisible() test. > > I don't want to add that to the real test in order to keep the test > as simple as possible. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > A test shows that child windows require IsWindowVisible() test > in DestroyWindow() in order to suppress ShowWindow() call. Alexandre, please do not apply this patch, it's wrong. -- Dmitry.

1 0

Re: Uninstaller localization
by Dmitry Timoshkov Feb. 24, 2005

Feb. 24, 2005

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > Changelog: > - localization of uninstaller You should not localize WINE_ERR messages, encoding of strings might be incompatible in Wine and underlying system. Also, is it possible to use normal dialog for uninstaller's main window? We could use conventional dialog templates in resources for different locales then. Right now localization will look ugly if lengths of strings in various locales are different. -- Dmitry.

1 0

Fwd: Invitation to the mediation manual
by Duane Clark Feb. 24, 2005

Feb. 24, 2005

Oops, I inadvertently deleted this from the queue, sorry. Robert Schuster wrote: Dear Wine developers, I wrote some guidelines that should help FOSS projects getting more lively and lowering the barrier for new developers to join. You can find them in form of a small manual here http://projects.mi.fu-berlin.de/w/bin/view/SE/ThesisFOSSIMMediationManual. These ideas are the result of work for my bachelor thesis and have been used successfully at the GNU Classpath project. If the topic is of interest to you, I would be happy to receive criticism and comments concerning the manual or the general idea. For further discussion I have set up a mailing-list (use http://lists.spline.inf.fu-berlin.de/mailman/listinfo/mediation_manual to subscribe or mediation_manual(a)lists.spline.inf.fu-berlin.de to post unsubscribed). Please send your feedback to this list but if you have reasons to contact me directly then just reply to this mail. In case you answer to your project's mailing list please CC me. Best regards Robert Schuster

1 0

Re: Poor performance when using Texas Instruments code generation tools in Wine
by Jan Tore Korneliussen Feb. 24, 2005

Feb. 24, 2005

We found a simple solution (workaround?) to make this application perform well under WINE. Typical running time of the linking process is down from 30min to 15sec (!). A short explanation: The TI linker allocates and frees a lot of small buffers, typical size 24-32 bytes - but we have not seen allocation of buffers smaller than 24 bytes. Due to fragmentation of the heap in WINE, the number of free buffers smaller than 24 bytes gradually increases. Since the free buffers are organized in 4 lists based on their size, the small (<24 bytes) buffers will go in the first list (which in the current version holds buffers of size <= 32), and each new allocation will have to search past these small buffers. After a while this consumes all processor time, due to the large number of allocations done by the linker. A sufficient fix for this particular application is to introduce a new free list for buffers smaller than 24 bytes. In this way the small buffers will simply be skipped for each allocation, keeping allocation time relatively constant. Note that this is a custom fix for this application, but maybe introducing more free list for small buffers can help other applications which allocate a lot of small buffers. I guess one has to collect data from a lot of apps to make a good tradeoff here. Anyway it was a good thing for us that the heap is "tunable". The diff is with respect to Wine-20050211.tar.gz dlls/ntdll/heap.c -- Jan Tore Korneliussen R&D Engineer TANDBERG Phone +47 6783 8514 mail jan.tore.korneliussen(a)tandberg.net 85c85 < #define HEAP_NB_FREE_LISTS 5 /* Number of free lists */ --- > #define HEAP_NB_FREE_LISTS 4 /* Number of free lists */ 90c90 < 0x10, 0x20, 0x80, 0x200, ~0UL --- > 0x20, 0x80, 0x200, ~0UL

1 0

Re: SHELL32: fix SHSimpleIDListFromPath to do the correct thing for non-existing pathes
by Alexandre Julliard Feb. 24, 2005

Feb. 24, 2005

Mike McCormack <mike(a)codeweavers.com> writes: > ChangeLog: > * fix SHSimpleIDListFromPath to do the correct thing for non-existing pathes This is causing some test failures (and also some extra successes, I guess we are on the right track...) shelllink.c:177: Test succeeded inside todo block: path_to_pidl returned a NULL pidl shelllink.c:197: Test failed: GetPath returned 'C:\nonexistent\file' shelllink.c:234: Test succeeded inside todo block: GetIconLocation failed (0x00000000) shelllink.c:236: Test failed: GetIconLocation returned 'c:\windows\system\shell32.dll' shelllink.c:238: Test succeeded inside todo block: GetIconLocation returned 0 -- Alexandre Julliard julliard(a)winehq.org

1 0

Fix recently introduced SEGV in DOCFILE IStorage implementation
by Troy Rollo Feb. 24, 2005

Feb. 24, 2005

After changing StorageBaseImpl, StorageInternalImpl was not updated to reflect the change. ChangeLog: Fix SEGV in IStorage implementation due to structure mismatch between StorageBaseImpl and StorageInternalImpl.

1 0

pcmconverter.c question
by Jeremy White Feb. 23, 2005

Feb. 23, 2005

The attached patch fixes all remaining test failures in winmm when run in interactive mode on my box with Wineoss. It does so by making msacm conversions start aligned (which lets them finish aligned for my test cases). However, it's clear that Robert Reif intended them not to be aligned. My question is: why? Cheers, Jer

2 1