February 2005 - Wine-Devel - list.winehq.org

Re: appdb/include screenshot.php
by Steven Edwards Feb. 17, 2005

Feb. 17, 2005

Hello, --- WineHQ <wineowner(a)wine.codeweavers.com> wrote: > ChangeSet ID: 16156 > CVSROOT: /opt/cvs-commit > Module name: appdb > Changes by: wineowner(a)wine.codeweavers.com 2005/02/16 19:16:51 Would it be possible for the appdb module to go to its own cvs commit list? While I care about the commit messages to the wine module and from time to time the lostwages module I never care about whats going on in appdb. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - Easier than ever with enhanced search. Learn more. http://info.mail.yahoo.com/mail_250

2 1

Re: Wine and SCONS
by Ira Krakow Feb. 17, 2005

Feb. 17, 2005

Scott, Integrating SCONS and Winelib is a wonderful idea. I'm currently struggling with explaining in a cookbook way how to port an MFC program to Winelib. Also, there's a lot of demand for porting .NET apps and if Winelib can support that as well this will attract more developers. I'll be happy to do whatever I can to help. Ira

1 0

re: Winelib and SCons
by Dan Kegel Feb. 17, 2005

Feb. 17, 2005

> Then, the developer needs to write his own makefiles and hammer autoconf > and stuff into working right. This is the hard part, and it's where I > gave up when trying to port Miranda Instant Messenger with Winelib even > though it worked in MinGW. There are many other open source Windows > apps out there that I'd like to try porting (say, eMule), but they're > currently all written in Visual Studio and getting Visual Studio support > into Winelib has been on our perpetual todo list for some years now. I doubt SCons will help here in any substantial way. Its chief appeal seems to be to people who like using python for everything, and who like badmouthing make. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

cleanroom legalaties
by Oliver Stieber Feb. 17, 2005

Feb. 17, 2005

I've been using GPL software, and reverse engineering for years (manuals with more than an int13 reference used to be hard to get hold of) and have just stumbled onto an interesting link. In the US there a process called 'Abstraction, Filtration, Comparison' that is used to determine if a work falls under the copyright of another work. It doesn't look like anything that affects wine, but interesting anyway. http://digital-law-online.info/lpdi1.0/treatise22.html ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

1 0

Re: portability fixes (yet another attempt)
by Steven Edwards Feb. 17, 2005

Feb. 17, 2005

Hi Thomas, --- Thomas Weidenmueller <wine-patches(a)reactsoft.com> wrote: > I unfortunately don't know as I couldn't find referencces to the other > HAVE_* definitions, which I guess are somewhere outside of wine sources. > There however needs to be a macro for strtoulW which can be named > differently... .e.g. HAVE__VSNPRINTF is also just undef'ed, I'm sorry I > don't know if that's defined in some gcc headers (mingw at least doesn't > define them), libc or somewhere else. You need to add a check to the configure and configure.ac scripts for these functions. When you run ./configure it will check to see if this function is implemented on the given platform and define as needed. Thanks Steven __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

wineprefixcreate
by Ann and Jason Edmeades Feb. 16, 2005

Feb. 16, 2005

Hiya, I was working on bug#2716 - a trap running install which turned out to be due to a missing registry key which wineprefixcreate should have created. Now I had an excuse (I deleted *.reg for another test previously!) but the reporter also got the same problem. To quote: "I've installed WINE via RPM package (there's a link to Mandrake package maintainer's RPM with WINE version 20050211 on www.winehq.com) There is no wineprefixcreate in it. I downloaded source tarball, which contains this utility, but it is part of another script, which COMPILES wine and that's what i want to avoid - system based on RPM's is more easily to maintain - you don't have to search for all installed files when uninstalling.... (Compiled programs must always be deleted manually..... :-( ) But i don't understand why running wine rundll32.exe setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf DIDN'T put it in? No error messages..... (That was what i did before running any program with RPM based WINE). Although this helped, i found other problems, so i finally installed WINE from source tarball, just to be sure, there is no installation problem.... " Can someone please clarify when wineprefixcreate is actually driven, and for an RPM (which I've never installed, so apologies) how should this problem have been created. (Mind you, in my case ie after deleting the registry, it would have been nice for it to be pre-populate with some of the keys too!) Thanks! Jason

2 1

Re: x11drv: make minimizing windows work again
by Vitaliy Margolen Feb. 16, 2005

Feb. 16, 2005

Ok, that semi-helps. Now I don't have an extra window that was showing up after minimize. But programs still don't want to stay minimized. They blink in the task bar and immediately restore themselves. Any suggestions where could it be? People have commented on this before. To reiterate: all programs (that I have) behave in this manner, not staying minimized. BTW one side affect of this patch - application icon is not displayed in the task bar anymore. Now it's back to wine's logo. Vitaliy Margolen Tuesday, February 15, 2005, 5:51:34 AM, Vitaliy Margolen wrote: > changelog: > - make minimized windows stay minimized

3 2

Re: CVS Update/Quicken popup/Help please/Followup
by Carl Sopchak Feb. 16, 2005

Feb. 16, 2005

>> Carl Sopchak writes: > > I guess my problem is that I have NO CLUE as to how this SHOULD be handled. > > Should the style be set to (style & ~WS_VISIBLE) when the rectangle is > > {0,0;0,0}? Should {0,0;0,0} be considered a valid rectangle in > > validate_window_rectangles()? Should validate_window_rectangles() only get > > called if the rectangle is not {0,0;0,0}? Or, very possibly, is there > > something else that should happen? Just to see what happened, I commented > > out the call to validate_window_rectangles, and the popup disappeared as it > > should. > Alexandre Julliard replied: > > The client rectangle should have been set to {0,0;0,0} too. You should > look at the WM_NCCALCSIZE processing (SWP_DoNCCalcSize in > dlls/x11drv/winpos.c) and check what's happening there with the > rectangles. > > Ok, so what is happening is this: In dlls/x11drv/winpos.c, the pNewWindowRect is coming into SWP_DoNCCalcSize as (0,0;0,0), wndPtr->rectWindow is (182,977;662;998), and wndPty->rectClient is (183,978;661,997). Then winpos.c sends it's own WM_NCCALCSIZE message, and upon return, params.rgrc[0] is (1,1;1,1)! This, in turn, causes the third and fourth conditions in the section commented as "If the application sends back garbage, ignore it" to be true, which in turn causes the next condition to be false, so the client rectangle (pNewClientRect) does NOT get set. (Follow that?? <g>) Tracing through the processing of this WM_NCCALCSIZE, I find it ends up generating two WM_NCCALCSIZE messages, one being handled by DefWindowProc32. This leads me to ./windows/defwnd.c, which calls NC_HandleNCCalcSize in ./windows/nonclient.c. Within NC_HandleNCCalcSize, a call is made to NC_AdjustRectOuter, then the window's rectangle (winRect) is adjusted based on this call. It is this call and adjustment of winRect that changes winRect from (0,0;0,0) to (1,1;-1,-1), which is later "fixed" to (1,1;1,1). Diving deeper, into NC_AdjustRectOuter, I find that because the window style has WS_BOARDER set, adjust is set to 1, then InflateRect is called, which sets rect to (-1,-1;1,1) [returned to NC_HandleNCCalcSize tmpRect variable]. So, there's the problem. The new rectangle size is (0,0;0,0), but has WS_BOARDER set, so the WM_NCCALCSIZE message returns (1,1;1,1) erroneously. The only thing is, I'm still not sure where the "best" place would be to check for the new window rectangle of (0,0;0,0) and handle it appropriately - or what "appropriate" would be, for that matter... Further help would be appreciated. Thanks, Carl

1 0

Re: [shell32tests/shelllink.c] Use aliases for ordinals
by Francois Gouget Feb. 16, 2005

Feb. 16, 2005

Hi, Paul Vriens wrote: > Hi, > > this makes the crosstest compile work again for shell32. Result tested > on win98/winxp. > > Changelog: > Use aliases for calls to ordinals. As far as I know, SHILCreateFromPath, ILFree and ILIsEqual are all exported by name on Windows. So, IMHO, unless we find a problem running the test on some Windows versions it would be better to fix MinGW. -- Francois Gouget fgouget(a)codeweavers.com

6 8

Re: dlls/shell32/shlfileop.c cleanup
by Alexandre Julliard Feb. 16, 2005

Feb. 16, 2005

Joris Huizer <jorishuizer(a)planet.nl> writes: > Changelog: > * renamed file_operation_delete to SHFileDelete > * renamed file_operation_checkFlags to SHFileCheckFlags Please don't do that. Internal functions should not be named to look like the exported ones, that's very confusing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: add RegOpenKey, RegCloseKey tests
by Alexandre Julliard Feb. 16, 2005

Feb. 16, 2005

James Hawkins <truiken(a)gmail.com> writes: > The last patch forgot to close the keys opened. Use this one instead. > > Changelog > * Add RegOpenKey, RegCloseKey tests. The tests fail on Wine. You need to add todo_wine blocks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: portability fixes (yet another attempt)
by Mike McCormack Feb. 16, 2005

Feb. 16, 2005

Thomas Weidenmueller wrote: > I unfortunately don't know as I couldn't find referencces to the other > HAVE_* definitions, which I guess are somewhere outside of wine sources. The HAVE_* definitions are set by the configure script. You need to add a test into configure.ac that detects the presence or absence of strtoulW and vnsprintf. Mike

1 0

Re: get rid of unnecessary libunicode dependencies in some more places
by Mike McCormack Feb. 16, 2005

Feb. 16, 2005

Thomas Weidenmueller wrote: > - sz = strlenW(fmt) + 1; > + sz = wcslen(fmt) + 1; libc and wine may have differing interpretations of what wchar_t. Specifically, if -fshort-wchar is not used, wchar_t will be int, won't it? You'd be better off using lstrlenW() than wcslen(), but that will be slow since it has an exception handler. Alexandre was talking about making an inline wine only version of lstrlenW() without the exception handler to solve that problem. Mike

4 4

IDirect3DDevice9Impl_SetVertexShader in d3d9/vertexshader.c
by Paul Vriens Feb. 16, 2005

Feb. 16, 2005

Hi, I have a demo-app that calls SetVertexShader with a NULL value. According to MSDN this is valid: To set a fixed-function vertex shader (after having set a programmable vertex shader), call IDirect3DDevice9::SetVertexShader(NULL) to release the programmable shader, and then call IDirect3DDevice9::SetFVF with the fixed-function vertex format. The app bails out of course because we do not handle the NULL value. Will this be fixed in the big upcoming d3d updates? Cheers, Paul.

1 0

WM_CREATE failure and SetScrollRange argument validation
by Krzysztof Foltman Feb. 16, 2005

Feb. 16, 2005

I've noticed another two things where Wine and Windows XP differ: 1. SetScrollRange(hWnd, SB_VERT, 0, -1) does nothing in WinXP, and is equivalent to SetScrollRange(hWnd, SB_VERT, 0, 0) in Wine. I guess it's true for all kinds of invalid arguments. 2. In WinXP, returning -1 from WM_CREATE causes window creation to fail - the newly created window is automatically destroyed (which sends WM_DESTROY to the window). In Wine, WM_DESTROY is not sent (which prevents the example program to finish). The short piece of relevant code can be downloaded from: http://foltman.com/wintest-scroll.zip Krzysztof

1 0

Re: [shell32tests/shelllink.c] Use aliases for ordinals
by Rolf Kalbermatter Feb. 16, 2005

Feb. 16, 2005

Francois Gouget wrote: >Ok, that would be a good reason. >There's something I don't understand though: when I compile the test >before your changes with Visual C++ 6.0 it compiles just fine but it >turns out the resulting executable imports these three APIs by ordinal. It all depends on the SDK you have installed. The Windows DLLs always exported those functions by ordinal since about Win95. The very early SDKs for Win95 included those APIs in the import libraries so calling them in an app would link fine. Then MS removed all undocumented APIs from their release SDK import libs. Later after the court case they documented most of those formely undocumented APIs and also included them back into the next SDK release. >Is this something that MinGW can / should do too? Yes MinGW libraries should probably include those APIs as well in their link libraries if they want to be compatible with the current SDK. >And for the Winelib side of things, is this something that winebuild can do? With proper definition in Wines spec files this should be no problem at all. Rolf Kalbermatter

1 0

Re: [shell32tests/shelllink.c] Use aliases for ordinals
by Rolf Kalbermatter Feb. 16, 2005

Feb. 16, 2005

Francois Gouget wrote: >As far as I know, SHILCreateFromPath, ILFree and ILIsEqual are all >exported by name on Windows. So, IMHO, unless we find a problem running >the test on some Windows versions it would be better to fix MinGW. Those functions are all exported by ordinal only from most Windows systems except maybe the Win XP versions and systems updated with the latest IE Explorer version. Rolf Kalbermatter

1 0

Re: wine/ programs/winefile/Pt.rc programs/winecfg ...
by Marcelo Duarte Feb. 16, 2005

Feb. 16, 2005

Hi, Alexandre Julliard escreveu: >ChangeSet ID: 16090 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2005/02/14 05:12:30 > > In this file below, the correct is "usuário", but in cvs is incorrect "usuÃ¡rio" and I dont know how to correct... In my tree it is correct. Index: wine/dlls/mpr/mpr_Pt.rc diff -u -p wine/dlls/mpr/mpr_Pt.rc:1.1 wine/dlls/mpr/mpr_Pt.rc:1.2 --- wine/dlls/mpr/mpr_Pt.rc:1.1 Wed Feb 16 09:36:32 2005 +++ wine/dlls/mpr/mpr_Pt.rc Wed Feb 16 09:36:32 2005 @@ -24,3 +24,23 @@ STRINGTABLE DISCARDABLE { IDS_ENTIRENETWORK "Toda a rede" } + +IDD_PROXYDLG DIALOG LOADONCALL MOVEABLE DISCARDABLE 36, 24, 250, 154 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "Entre a senha da rede" +FONT 8, "Helv" +{ + LTEXT "Por favor, entre como o nome de usuÃ¡rio e a senha:", IDC_EXPLAIN, 40, 6, 150, 15 +

2 2

CreateCaret resets caret position (while it shouldn't)
by Krzysztof Foltman Feb. 16, 2005

Feb. 16, 2005

There seems to be a difference in functionality of CreateCaret between Windows (XP at least) and Wine. You can find a test program at: http://foltman.com/wintest-caret.zip Look at this code snippet: CreateCaret(hWnd, NULL, 0, 20); SetCaretPos(100,100); CreateCaret(hWnd, NULL, 10, 10); In Wine, the 2nd CreateCaret resets caret position to (0, 0). In Windows, caret position doesn't get reset - it's still positioned at (100, 100). Note that calling CreateCaret twice without DestroyCaret is not a bug (after MSDN): - - - - - cut - - - - - CreateCaret automatically destroys the previous caret shape, if any, regardless of the window that owns the caret. The caret is hidden until the application calls the ShowCaret function to make the caret visible. - - - - - cut - - - - - Is it easy to fix for anyone ? Krzysztof

1 0

Re: portability fixes (yet another attempt)
by Dmitry Timoshkov Feb. 16, 2005

Feb. 16, 2005

"Thomas Weidenmueller" <wine-patches(a)reactsoft.com> wrote: > > My understanding was that Dmitry suggested you modify your headers, > > not ours. > > I did, unfortunately wine's headers were/are also incomplete so porting > code that called vsnprintfW() or strtoulW() in any case would link > against libunicode (unnecessarily). In order to get rid of a dependency on libunicode for vsnprintfW and strtoulW you have to do the same header magic (if I understood Filip correctly) as you already do for strcmpW/wcslen and map them to whatever ntdll equivalent is available. Your very recent version of the patch still has strlenW/wcslen changes not acceptable for Wine code, if you could resend it again without it that would be great. -- Dmitry.

1 0

Cross-test failed ...
by Paul Millar Feb. 16, 2005

Feb. 16, 2005

Hi, Quick message: building cross-test died again (output below). This time its the shell32 dll tests that are causing consternation. Suggestions greatfully received. Cheers, Paul. i686-mingw32msvc-gcc generated.o shelllink.o shellpath.o shlfileop.o shlfolder.o string.o testlist.o -o shell32_test.exe -lshell32 -lole32 -lshlwapi -ladvapi32 -luuid shelllink.o(.text+0xc1): In function `path_to_pidl': /home/paulm/Testing/wine-cross-source/dlls/shell32/tests/shelllink.c:72: undefined reference to `SHILCreateFromPath(a)12' distcc[21503] ERROR: compile on localhost failed make: *** [shell32_test.exe] Error 1

3 2

Anyone have Wine PowerPoint slides?
by Ira Krakow Feb. 16, 2005

Feb. 16, 2005

I'm giving a presentation on converting Windows programs to Linux at MIT (the Boston Linux User Group) on April 20th from 7pm to 9pm. The BLU may be the oldest Linux user group in the US. It's been around at least since 1993, has been meeting regularly since then, and has a lot of activity. The group started under the umbrella of the Boston Computer Society, which at one time had over 20,000 members. I was wondering if anyone has any Wine PowerPoint slides? I will do the presentation in PowerPoint under Crossover Office 4.1. I can either develop the slides myself or adapt and use slides that have been developed already. Maybe something from a previous WineConf? Thanks in advance. Ira

4 3

Re: portability fixes (yet another attempt)
by Mike McCormack Feb. 16, 2005

Feb. 16, 2005

Thomas Weidenmueller wrote: > I'm however not sure about the changes in include/wine/port.h and > include/config.h so please adjust or correct them so it builds correctly. If you don't build and test your patches against Wine, then don't submit patches. If you're trying to fix Reactos, then why don't you just fix your own headers? Dmitry already pointed out that you can easily add some #define's or inline functions to achieve what you want. That seems like a better idea than submitting untested patches to wine-patches and hoping we're going to fix your problems for you. Mike

3 3

Re: winecfg: various drive detection enhancements
by Michael Jung Feb. 16, 2005

Feb. 16, 2005

Hi Richard, On Wednesday 16 February 2005 08:45, you wrote: > Windows permits the user to set the name of the windows directory > to whatever he desires. At one time I had directories called > /Win31 and /Win98. Not a common practice, but you may wish to > make provision for this if there are later revisions to the code. > > So the line above might look something like: > > cp "datadir/wine.inf" "$CROOT_WINDOWS/inf/wine.inf" > > if I understand your code correctly. On the other hand, there may be > benefits in having a standard installation designed with a /windows > directory in mind, and the wine user then handles non-standard > installations with whatever skills he has available. wineprefixcreate is executed only if the user calls wine without having a '.wine' directory in place at all. What this means is that there is no registry and no configuration at all at this time. So there is no way that the user has already configured a "/Win98" as the system directory or somesuch. wineprefixcreate is meant to install a default configuration for users who don't have the knowledge or the desire to do so on their own. The configuration it installs is a good starting point to be tailored to your needs, though. It won't be touched by wineprefixcreate again, once it is generated. That said, the line of code you are refering to is not from me. I've only added the call to winecfg. Ciao, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: [AppDB] edit version and edit notes
by Scott Ritchie Feb. 16, 2005

Feb. 16, 2005

Cool, I can edit application version info again when I'm a maintainer (and a supermaintainer), however I still can't do it if I'm just a supermaintainer (the only button available in an app version is to resign as supermaintainer.) Furthermore, as a related feature request, listing the names of the supermaintainers in the maintainer field when viewing a version would be useful, so that it appears that a supermaintained app is actually maintained. Thanks for the good work! -Scott Ritchie

2 1