February 2005 - Wine-Devel - list.winehq.org

Re: ntdll/time.c - TZ_INFO
by Uwe Bonnes Feb. 14, 2005

Feb. 14, 2005

>>>>> "Marcelo" == Marcelo Duarte <wine-devel(a)bol.com.br> writes: Marcelo> Hi, In my system/language I see some messages: Marcelo> fixme:ntdll:TIME_GetTZAsStr Can't match system time zone name Marcelo> "BRST" to an entry in TZ_INFO fixme:ntdll:TIME_GetTZAsStr Marcelo> Please add appropriate entry to TZ_INFO and submit as patch to Marcelo> wine-patches Marcelo> And before to update TZ_INFO I modifyied the FIXME and I think Marcelo> that it explain better the problem: fixme:ntdll:TIME_GetTZAsStr Marcelo> Can't match system time zone name "BRST", bias=120 and dst=1 to Marcelo> an entry in TZ_INFO. Please add appropriate entry to TZ_INFO Marcelo> and submit as patch to wine-patches Marcelo> And I see the real problem. In TZ_INFO bias=180 and dst=0. I Marcelo> added another BRST information. Is this correct? I don't live in the Brasilian Timezone, so I cant tell. Maybe the old entry was wrong, or there is a mixup with standard and summer time... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

Re: mmtimer resolution question
by Robert Reif Feb. 14, 2005

Feb. 14, 2005

Jeremy White wrote: > > You might try putting traces around the > conditional YieldExecution on line 730 > of ntdll/sync.c and see if that chews up time; > if it does, removing the Yield might help. Removing the Yield fixes a regression in Need For Speed III where the loader and server consume 100% of the CPU. This is with RH 9 which is a 2.4 kernel.

4 11

Re: mmtimer resolution question
by Jeremy White Feb. 13, 2005

Feb. 13, 2005

I'm taking a public thread that I responded to privately back to public view: Robert Reif wrote: > Jeremy White wrote: > >>> Putting traces into the mmtimer thread loop shows >>> WaitForSingleObject is sleeping for about 20 ms and then >>> calling the callback twice to catch up. >> >> >> >> Well, that means mmtimer is right. >> >> You might try putting traces around the >> conditional YieldExecution on line 730 >> of ntdll/sync.c and see if that chews up time; >> if it does, removing the Yield might help. >> >> > Interesting results. It fixes the sound quality and FIXME problem > but it is still going about 20 ms between callback pairs. > > Could the yield just be aggravating the timer resolution problem? I think this is the thread priority problem I mentioned earlier. The behavior of winmm is correct; it is supposed to deliver every single timer request, even if it has to double or triple (or more!) up to do it. I verified that very carefully on Windows. The reason you see pretty steady 10 ms resolution on Windows is that the winmm thread on Windows is flagged as a priority 15 thread, so it does not get interrupted or time sliced away; it fires precisely when it wants to. It's much harder to achieve the same thing on Linux, sadly. Hmm. As I sit here and think about this, though, I do find myself a little bit puzzled. I would have expected that, if my understanding is right, you would have seen much more dramatic time gaps. On a 2.6 kernel, for example, I would expect you to see jumps on the order of 100 ms (hence ten winmm requests fired). And exactly 20 ms spacing is a little too consistent and interesting a number; it suggests that there is a more precise understanding that should be available. That may be a function of the test program, though. I suspect in a 'real' program, where other active threads are demanding more cpu that you might get more sporadic results. It might be interesting to add a spin looping thread to the test case and see if you suddenly get larger gaps. Cheers, Jeremy

4 13

Problem to minimize a window
by Maxime Bellengé Feb. 13, 2005

Feb. 13, 2005

Hello, Has anybody managed to minimize a window in managed mode since this patch ? Maximizing and restoring a window works but minimizing does not work, the window minimizes and then reopen itself immediately. I doubt it is a problem with my window manager (metacity), however I tried all this afternoon to identify the problem with no success. Thanks Max ChangeSet ID: 15812 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/01/31 10:34:07 Modified files: dlls/x11drv : x11drv.h winpos.c window.c mouse.c dlls/wined3d : directx.c dlls/d3d8 : directx.c Log message: Only create an X window for top-level windows, not for child windows. Get rid of the X client window too, it's no longer needed. Patch: http://cvs.winehq.org/patch.py?id=15812

3 3

Numpad evilness
by Crestez Leonard Feb. 13, 2005

Feb. 13, 2005

I've found a wierd bug in keyboard handling. The problem is that wine doesn't seem to correctly translate key board messages. The program receives WM_KEYDOWN VK_NUMPAD2 and WM_KEYUP VK_DOWN(really bad). I've traced the bug to dlls/x11drv/keyboard.c. Apparently EVENT_event_to_vkey correctly converts KeyPress message, but not KeyRelease messages. If you look at the source code there is a hack of sorts for numpad keys. EVENT_event_to_vkey calls something from X to get a keysym, and does some special handling for numpad 0-9 and dot. Apparently for the KeyRelease event that doesn't work, keysym comes back as 0, causing EVENT_event_to_vkey to malfunction. This bug doesn't always happen (but it does most of the time). I'm scared this might be a bug in my X, but I hope it's not. BTW, isn't there a better way to handle numpad stuff? Here is the relevant portion of the wine log: trace:key:X11DRV_KeyEvent type 2, window 3600001, state 0x0010, keycode 0x0058 trace:key:X11DRV_KeyEvent state = 10 nbyte = 1, status 0x4 trace:key:X11DRV_KeyEvent KeyPress : keysym=FFB2 (KP_2), # of chars=1 / 0x32 / '2' trace:key:X11DRV_KeyEvent keycode 0x58 converted to vkey 0x62 trace:key:X11DRV_KeyEvent bScan = 0x50. trace:key:queue_kbd_event wParam=0062, lParam=40500001, InputKeyState=81 trace:msg:MSG_peek_message got type 7 msg 100 (WM_KEYDOWN) hwnd 0x10022 wp 62 lp 40500001 trace:msg:MSG_peek_message got type 7 msg 100 (WM_KEYDOWN) hwnd 0x10022 wp 62 lp 40500001 trace:key:TranslateMessage (WM_KEYDOWN, 0062, 40500001) trace:key:TranslateMessage Translating key VK_NUMPAD2 (0062), scancode 50 trace:msg:GetKeyboardState (0x778da29c) trace:key:X11DRV_ToUnicodeEx (0062, 4050) : faked state = 0x0010 trace:key:X11DRV_ToUnicodeEx type 2, window 3600001, state 0x0010, keycode 0x0058 trace:key:X11DRV_ToUnicodeEx Translating char 0x32 to unicode trace:key:X11DRV_ToUnicodeEx ToUnicode about to return 1 with char 32 trace:key:TranslateMessage 1 -> PostMessageW(0x10022,WM_CHAR,0032,40500001) trace:msg:PostMessageW hwnd 0x10022 msg 102 (WM_CHAR) wp 32 lp 40500001 trace:msg:GetKeyState key (0x14) -> 0 trace:msg:MSG_peek_message got type 6 msg 102 (WM_CHAR) hwnd 0x10022 wp 32 lp 40500001 trace:msg:MSG_peek_message got type 6 msg 102 (WM_CHAR) hwnd 0x10022 wp 32 lp 40500001 trace:key:TranslateMessage (WM_CHAR, 0032, 40500001) trace:key:X11DRV_KeyEvent type 3, window 3600001, state 0x0010, keycode 0x0058 trace:key:X11DRV_KeyEvent state = 10 nbyte = 0, status 0x1 trace:key:X11DRV_KeyEvent KeyRelease : keysym=0 (No Name), # of chars=0 / 0x00 / '' trace:key:EVENT_event_to_vkey e->keycode = 58 trace:key:X11DRV_KeyEvent keycode 0x58 converted to vkey 0x28 trace:key:X11DRV_KeyEvent bScan = 0x50. trace:key:queue_kbd_event wParam=0028, lParam=c0500001, InputKeyState=0 trace:msg:MSG_peek_message got type 7 msg 101 (WM_KEYUP) hwnd 0x10022 wp 28 lp c0500001 trace:msg:MSG_peek_message got type 7 msg 101 (WM_KEYUP) hwnd 0x10022 wp 28 lp c0500001 trace:key:TranslateMessage (WM_KEYUP, 0028, C0500001)

1 0

RtlFillMemoryUlong
by Dietrich Teickner Feb. 13, 2005

Feb. 13, 2005

With one inline asm-statement this function would smaler and faster. And the comment for * ulCount [I] Number of bytes to write need change. And one question, How can I start ntdll_test.exe.so in wine ? Dietrich /************************************************************************* * RtlFillMemoryUlong [NTDLL.@] * * Fill memory with a 32 bit (dword) value. * * PARAMS * lpDest [I] Bitmap pointer * ulCount [I] Number of bytes to write * ulValue [I] Value to fill with * * RETURNS * Nothing. */ VOID WINAPI RtlFillMemoryUlong(ULONG* lpDest, ULONG ulCount, ULONG ulValue) { TRACE("(%p,%ld,%ld)\n", lpDest, ulCount, ulValue); #if 1 ulCount /= sizeof(ULONG); __asm__ __volatile__("rep stosl" : :"D" (lpDest), "c" (ulCount), "a" (ulValue)); #else ulCount /= sizeof(ULONG); while(ulCount--) *lpDest++ = ulValue; #endif }

3 2

Re: REGION_FrameRgn fix.
by Filip Navara Feb. 13, 2005

Feb. 13, 2005

Rein Klazes wrote: >Hi, > >FrameRgn paints a frame around a region, the frame should be painted on >the inside of the edges, not the outside as it does now. > > It's a shame that we're duplicating work all over again :-( http://www.winehq.org/hypermail/wine-patches/2004/06/0250.html

2 1

Regression in "Braveheart"
by Carlos Lozano Feb. 13, 2005

Feb. 13, 2005

Hello, The patch: http://www.winehq.org/hypermail/wine-cvs/2004/06/0104.html Log message: Dmitry Timoshkov <dmitry(a)codeweavers.com> Do nothing in ShowWindow(SW_SHOW) if a window is already visible. Causes regression in the game "Braveheart". The intro was working before of the patch, now it freezes with black screen on start. Regards, Carlos. -- ___ _ \ | / Consulting | . |._ _ _| | ___ ___ ___ http://www.andago.com | || ' |/ . |<_> |/ . |/ . \__ GNU/Linux |_|_||_|_|\___|<___|\_. |\___/ _ \ __|\ \ / Carlos A. Lozano <___'/ | \ -_) __/\__ \ > < -_) [ carlos.lozano(a)andago.com ]\___|_| ____/ _/\_\___| [ calb(a)epsxe.com ] http://www.ePSXe.com

2 1

Re: setupapi - ReactOS Merge 20050205
by Alexandre Julliard Feb. 12, 2005

Feb. 12, 2005

Steven Edwards <steven_ed4153(a)yahoo.com> writes: > +BOOL WINAPI DelayedMove(LPCWSTR lpExistingFileName, LPCWSTR lpNewFileName) > +{ > + if (OsVersionInfo.dwPlatformId != VER_PLATFORM_WIN32_NT) > + { > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return FALSE; > + } > + > + return MoveFileExW(lpExistingFileName, lpNewFileName, > + MOVEFILE_REPLACE_EXISTING | MOVEFILE_DELAY_UNTIL_REBOOT); > +} You shouldn't do that kind of preventive version check, you should always call the function and then deal with failures appropriately. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: Regression in "DeusEx"
by luis lenders Feb. 12, 2005

Feb. 12, 2005

Hello again, > The patch: > http://www.winehq.org/hypermail/wine-cvs/2004/10/0395.html > > Log message: > Get rid of the WIN_NEEDS_BEGINPAINT flag, Windows will happily loop > forever too if WM_PAINT is not handled properly. > > Causes regression in the game "DeusEx". > The game was playable before of the patch, now it freezes > in the 2th title screen. The same patch causes regression in the game "Trickstyle". The same problems, it was playable, and now it freezes in the 2th title screen. Regards, Carlos. The aforementioned patch also screws up foobar2000. See http://appdb.winehq.org/appview.php?versionId=2355 , last comment. Maybe someone could have a look at it because it affects, as it appears, quite some apps. Regards ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

2 1

Latest News needs a url fix!
by Tom Feb. 12, 2005

Feb. 12, 2005

The latest news on the frontpage has a incorrect link, "Read more" points to : http://www.winehq.org/?announce=1.95 when it should be 1.96 I'm away from my Linux box tonight or I would send a patch... Can someone fix this? Tom

2 1

Re: Fix winsock / protcol.c compilation on Windows
by Paul Vriens Feb. 12, 2005

Feb. 12, 2005

On Fri, 2005-02-11 at 23:09, Francois Gouget wrote: > I guess this was accidental. > > > Changelog: > > * dlls/winsock/tests/protocol.c > > Francois Gouget <fgouget(a)codeweavers.com> > Tests cannot use wine/test.h because it does not exist on Windows. Hi Francois, the Changelog says wine/test.h, yet you remove wine/debug.h ? Cheers, Paul.

1 0

Appdb hackers please read
by Ivan Leo Puoti Feb. 12, 2005

Feb. 12, 2005

Hello guys, I have the impression the inactive warning messages have been sent out again, I was convinced they were only sent once, followed a month later by a closed account notification. In any case please solve the problem, I can't take 500+ bounces in my mail box every other day, I'm planning to fill up my gmail box in something like 2040, not mid 2005, and don't want to waste time deleting hundreds of bounces. Ivan.

1 0

strange problem with RtlCompareUnicodeString
by Ivan Leo Puoti Feb. 12, 2005

Feb. 12, 2005

RtlCompareUnicodeString should return 0 if it receives two identical string. But for some strange reason this code http://rafb.net/paste/results/e3tHCg40.html prints this output http://rafb.net/paste/results/SS5U2N81.html Is it a mistake I've missed, or is this a bug in the implementation of RtlCompareUnicodeString? Ivan.

1 1

Re: Re: winrash bug
by Chris Morgan Feb. 11, 2005

Feb. 11, 2005

Oh, that's mostly because I was lazy. I'm pretty sure the text says that "if you are on windows95 you should install winsock2". I'm not sure how to detect whether the user needs to install winsock2 or not by looking at dlls. I was planning on adding detection of the windows version and using that as a way of narrowing down who sees the winsock prompt. That doesn't address which version of winsock the user has installed though... I'll put in the windows version check so only 95 users see the winsock2 prompt since thats pretty easy. Chris > > From: Ivan Leo Puoti <ivanleo(a)gmail.com> > Date: 2005/02/08 Tue PM 02:11:29 EST > To: cmorgan(a)alum.wpi.edu > CC: wine-devel(a)winehq.com > Subject: Re: winrash bug > > Chris Morgan wrote: > > >Is this based on what the installer displays or upon output from winrash in the debug.txt file? > > > > > It is based on the installer telling me I'm on windows 95 and that I > must install the > winsock2 update for windows 95. > > Ivan. >

3 2

Re: Real-world appdb
by Holly Bostick Feb. 11, 2005

Feb. 11, 2005

(3rd of 3) Chris Morgan wrote: >>Then vote for what you really want or need... I want to see 100 games >>working but if I had to pick one >>it would be HL2. And if you give me 20 or 30 votes there *diluted* votes >>from the get-go! > > I agree. Maybe 5 votes per-user is a good number so each one counts but all of their eggs aren't in one basket. > > Chris > > >

1 0

Re: Real-world appdb
by Holly Bostick Feb. 11, 2005

Feb. 11, 2005

(2nd of 3) Tom wrote: > Chris Morgan wrote: > >>> Having a single vote per-person makes the assumption that the person >>> has a single application that they want working. Often users have a >>> handful of them. I'd prefer multiple votes per-person. >> > Then vote for what you really want or need... I want to see 100 games > working but if I had to pick one > it would be HL2. And if you give me 20 or 30 votes there *diluted* votes > from the get-go! > If you have *one* vote its going to mean something...... if you have > 20-30 votes what is vote 28 > going to really mean to you? That you searched around looking for > something to vote for? > > We have 10 categories at this time and if we do move to multiable votes > I would only hope > we set it to 1 vote per categorie and that would give 10 diluted votes.... > > Tom > >>> Clearing the current votes is a safe bet. >>> >>> Chris >>> > >

1 0

Re: Real-world appdb
by Holly Bostick Feb. 11, 2005

Feb. 11, 2005

How you guys managed to hit "Reply to all" and somehow not include the list, I don't know, but I'll forward :-) ... (1st of 3 such) Chris Morgan wrote: >>>- Voting for app version ( not app family). >>>- only one vote per person per version. >>>- more total votes, say 10-20 instead of 3. >>> >>> >>I would like to propose......... >> >>- one person one vote >>- vote for app family not version >>- clear the current votes and start fresh... >> > > Having a single vote per-person makes the assumption that the person has a single application that they want working. Often users have a handful of them. I'd prefer multiple votes per-person. > > Clearing the current votes is a safe bet. > > Chris > > > >

1 0

Wine, CrossOver wins LQ Members Choice awards 2004
by Mike Hearn Feb. 11, 2005

Feb. 11, 2005

Hey, we won by a large margin! http://www.linuxquestions.org/questions/showthread.php?s=&threadid=272137 Wine 293 42.59% Crossover Office 139 20.20% Cedega 131 19.04% VMware 101 14.68% Win4lin 24 3.49% Good going chaps and chapettes! Nice also to see the results are ranked in rough order of "freeness" too. Let's see if we can win again in the 2005 voting :) thanks -mike

3 2

Subject: Re: Faster TlsAlloc() or zero_bit_scan
by Dietrich Teickner Feb. 11, 2005

Feb. 11, 2005

Not all You can every write in c/c++. Sometime You need a call for a library function. I think, that can be one and I think, not only TlsAlloc use a zero_bit_scan. It must be first zero_bit in the first 'bytecount' DWORD from the bitmap addr. Dietrich On Thu, 10 Feb 2005 18:59:21 +0100, Dietrich Teickner wrote: >> I have a suggestion for a faster implementation of the zero_bit_scan in >> RtlFindClearBits [NTDLL.@] >> (rlbitmap.c) for e.g. TlsAlloc() >> The main is the usage of the instruction 'bsf eax, eax' >> >> This I have implemented in the new experimental odinxp-tree for finding >> the first zero_bit in the first 'bytecount' bytes of the bitmap addr. Does this actually make a noticeable difference? Rewriting stuff in assembly for theoretical performance improvements isn't so great, as far fewer people can read/write assembly than C. thanks -mike

1 0

Subject: Re: Faster TlsAlloc() or zero_bit_scan
by Dietrich Teickner Feb. 11, 2005

Feb. 11, 2005

Not all You can every write in c/c++. Sometime You need a call for a library function. I think, that can be one and I think, not only TlsAlloc use a zero_bit_scan. Dietrich On Thu, 10 Feb 2005 18:59:21 +0100, Dietrich Teickner wrote: >> I have a suggestion for a faster implementation of the zero_bit_scan in >> RtlFindClearBits [NTDLL.@] >> (rlbitmap.c) for e.g. TlsAlloc() >> The main is the usage of the instruction 'bsf eax, eax' >> >> This I have implemented in the new experimental odinxp-tree for finding >> the first zero_bit in the first 'bytecount' bytes of the bitmap addr. Does this actually make a noticeable difference? Rewriting stuff in assembly for theoretical performance improvements isn't so great, as far fewer people can read/write assembly than C. thanks -mike

1 0

Faster TlsAlloc() or zero_bit_scan
by Dietrich Teickner Feb. 11, 2005

Feb. 11, 2005

Hi, I have a suggestion for a faster implementation of the zero_bit_scan in RtlFindClearBits [NTDLL.@] (rlbitmap.c) for e.g. TlsAlloc() The main is the usage of the instruction 'bsf eax, eax' This I have implemented in the new experimental odinxp-tree for finding the first zero_bit in the first 'bytecount' bytes of the bitmap addr. Dietrich public _search_zero_bit ;int CDECL search_zero_bit(int bytecount, void *addr); _search_zero_bit proc near push esi push edx mov esi, [esp+16] mov edx, [esp+12] inc edx loop: add esi, 4 mov eax, -1 dec edx ;not found jz short found xor eax, dword ptr [esi - 4] jz loop bsf eax, eax jz short loop sub esi, 4 sub esi, [esp+16] shl esi, 5-2 add eax, esi found: pop edx pop esi ret _search_zero_bit endp

3 2

Rewriting the User Guide Question: FreeBSD
by Scott Ritchie Feb. 11, 2005

Feb. 11, 2005

Ok so I'm going through the User Guide's getting/installing/compiling chapters. Essentially my idea is to cannibalize most of it, since the information is outdated, wrong, or at best duplicitous. However, while combing through the User Guide, I realized that there's some stuff I don't know much about - namely, FreeBSD. So, if you're a Wine FreeBSD guru, take a moment to peek at the existing "Getting Wine" chapter on the web site, and tell me if any of that information is at all relevant. My suspicion is that FreeBSD has advanced quite a bit since the guide was written, and that all that information is rather useless. My goal is to eliminate most of the distro-specific stuff anyway, since there are better places for it. Thanks, Scott Ritchie Chief Executive Officer of further Wine documentation

1 0

mmtimer resolution question
by Robert Reif Feb. 11, 2005

Feb. 11, 2005

I'm trying to track down a problem with the direct sound regression tests when run in emulation mode using the wave api. I'm getting a lot of FIXMEs and poor quality playback. The dsound mixer callback routine expects to be called every 10 ms but is being called twice every 20 ms. Setting the timer resolution to 1 ms didn't help. I hacked the mmtimer to run at the requested 10 ms interval and the playback problems disappeared. Since the mmtimer thread uses WaitForSingleObject(sleep_time) for it's timer source, has something changed recently which would explain this behavior?

1 0

Problems with wine-patches
by Paul Vriens Feb. 10, 2005

Feb. 10, 2005

Hi, I'm not able to send (what I think is normal) email to wine-patches anymore. The Test mail worked. Any ideas? Cheers, Paul.

7 10

Text Alignment, how is it handled ?
by George Ginden Feb. 10, 2005

Feb. 10, 2005

Hi the following code part is not working in Wine as it work (as supposed) in Windows. HRight = GetDlgItem (hDlg,IDC_RIGHT); Edit_SetText(HRight, "Right"); How is text alignment, in a edit field, handled ? It looks like the Edit_SetText function is mapped to SetWindowText, which calls X11DRV_SetWindowText... But again, text alignment doesn't work. Can I do something ? PS: c source code is attacched Regards. /* ** Ditta..........:TeamSystem spa ** Programmatore..:Stefano Peraldini ** Nome programma.:Test Wine ** Data...........:04/02/2005 ** */ //INCLUDE #include <windows.h> #include <WindowsX.h> #include "resource.h" //VARIABILI GLOBALI HWND hUnaligned, HCenter, HRight; HDC hdc; //PROTOTIPI BOOL CALLBACK DlgProc (HWND, UINT, WPARAM, LPARAM); //MAIN int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpszCmdLine, int nCmdShow) { // Visualizzazione e controllo errore visualizzazione dialog if (DialogBox (hInstance, (LPCSTR) IDD_DIALOG1, NULL, DlgProc) == -1) MessageBox (NULL, "Errore visualizzazione dialog!!","Test Wine", MB_ICONQUESTION | MB_OK); return 0; } //DLGPROC della dialog1 BOOL CALLBACK DlgProc (HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) { //Switch per la gestione dei messaggi provenienti dalla dialog1 switch (message) { //Gestione del VM_CLOSE case WM_CLOSE: return TRUE; break; //Impostazione dialog1 case WM_INITDIALOG: { hUnaligned = GetDlgItem (hDlg,IDC_UNALIGNED); HCenter = GetDlgItem (hDlg,IDC_CENTER); HRight = GetDlgItem (hDlg,IDC_RIGHT); //Edit Box Unaligned Edit_SetText(hUnaligned, "Unaligned"); //Edit Box Center Edit_SetText(HCenter, "Center"); //Edit Box Right Edit_SetText(HRight, "Right"); return TRUE; } //Gestione messaggi dialog1 case WM_COMMAND: switch (LOWORD (wParam)) { case IDOK: EndDialog (hDlg, 0); return TRUE; break; // END WMCOMMAND } return FALSE; } return FALSE; }

4 4

Re: RESEND: dlls/comctl32/treeview.c: remove repainting
by Robert Shearman Feb. 10, 2005

Feb. 10, 2005

yuxdwa702(a)sneakemail.com wrote: > Changelog: > tinus <yuxdwa702(a)sneakemail.com> > Scroll instead of repainting when expanding/collapsing trees > Don't repaint on hover if 'hot tracking' isn't on > > > Index: dlls/comctl32/treeview.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/treeview.c,v > retrieving revision 1.164 > diff -u -p -r1.164 treeview.c > --- dlls/comctl32/treeview.c 14 Jan 2005 15:13:24 -0000 1.164 > +++ dlls/comctl32/treeview.c 31 Jan 2005 01:51:30 -0000 > @@ -631,7 +631,8 @@ TREEVIEW_SendCustomDrawItemNotify(TREEVI > uItemState |= CDIS_SELECTED; > if (wineItem == infoPtr->selectedItem) > uItemState |= CDIS_FOCUS; > - if (wineItem == infoPtr->hotItem) > + /* I'm not sure of this, needs to be compared to the real thing */ Usually you find this out before submitting a patch. > + if ((infoPtr->dwStyle & TVS_TRACKSELECT) && wineItem == > infoPtr->hotItem) > uItemState |= CDIS_HOT; > @@ -5037,11 +5107,13 @@ TREEVIEW_KeyDown(TREEVIEW_INFO *infoPtr, > static LRESULT > TREEVIEW_MouseLeave (TREEVIEW_INFO * infoPtr) > { > - if (infoPtr->hotItem) > + HTREEITEM orgItem = infoPtr->hotItem; > + infoPtr->hotItem = NULL; > + > + /* remove hot effect from item */ > + if (infoPtr->dwStyle & TVS_TRACKSELECT) > { > - /* remove hot effect from item */ > - InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, TRUE); > - infoPtr->hotItem = NULL; > + InvalidateRect(infoPtr->hwnd, &orgItem->rect, TRUE); > } > return 0; > } If hot tracking isn't required when TVS_TRACKSELECT isn't set, then don't call TrackMouseEvent, instead of putting these exceptions everywhere. > @@ -5080,11 +5152,11 @@ TREEVIEW_MouseMove (TREEVIEW_INFO * info > if (item != infoPtr->hotItem) > { > /* redraw old hot item */ > - if (infoPtr->hotItem) > + if (infoPtr->hotItem && (infoPtr->dwStyle & TVS_TRACKSELECT) ) > InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, > TRUE); > infoPtr->hotItem = item; > /* redraw new hot item */ > - if (infoPtr->hotItem) > + if (infoPtr->hotItem && (infoPtr->dwStyle & TVS_TRACKSELECT) ) > InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, > TRUE); > Same here. Don't change the hot item if the hot item isn't going to be repainted anyway. Rob

1 0

Re: rsaenh: CPGetProvParam's PP_ENUMCONTAINERS
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > Changelog: > Implemented CPGetProvParam's PP_ENUMCONTAINERS parameter type > Added corresponding test > Removed some tabs that slipped in with the last patch The test fails for me: rsaenh.c:1383: Test failed: 00000103 rsaenh.c:1391: Test failed: 0, 00000103 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [Discuss] Recycle Bin problem with Preclick image editing software
by Mike Hearn Feb. 9, 2005

Feb. 9, 2005

On Wed, 2005-02-09 at 15:34 -0500, Don Feliciano wrote: > SUCCESS! Woo Hoo! You rock... now my wife can't tell me b*tch at me > for ditching Windows. Thanks a ton. Niceness Don. Of course, it'd rock more if this had worked out of the box. I expect we're missing some shell magic for the recycle bin. Wouldn't be hard to investigate but have a million other things to do so I'll CC this to wine-devel. Context is: app has a "send to recycle bin" option to delete photos. Doesn't work. Native shell32/shfolder fixes it. If anybody is up for what is probably an easy task, figure out why and fix it so c:\Recycled is used. For bonus points we should bridge it to KDE/GNOME so if an app recycles something it appears in your actual trash can :) thanks -mike

3 2

Re: Rearrange WINPROC_CallWndProc to give clearer tracing
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Mike Hearn <mh(a)codeweavers.com> writes: > Yes, I realised the stack allocation might be a problem but only a while > after I sent the patch. Here's another that uses the heap. I don't think you want that either, it won't really make things less confusing if you are adding extra heap calls. You may want to look into using RelayFromExclude instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Rearrange WINPROC_CallWndProc to give clearer tracing
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Mike Hearn <mh(a)codeweavers.com> writes: > ChangeLog: > Rearrange WINPROC_CallWndProc to give clearer tracing > > --- windows/winproc.c (revision 132) > +++ windows/winproc.c (local) > @@ -408,20 +408,25 @@ static LRESULT WINPROC_CallWndProc( WNDP > { > LRESULT retvalue; > int iWndsLocks; > + char msgname[1024]; You don't want to do that, window procs can be nested quite deeply. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: x86_64 multilib configure fix
by Alexandre Julliard Feb. 9, 2005

Feb. 9, 2005

Alex Woods <wine-devel(a)giblets.org> writes: > Changelog: > * configure.ac: Alex Woods <wine-devel(a)giblets.org> > Handle host_cpu of x86_64 like other x86s. This will break the 64-bit build. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: More complete stubs for DuplicateTokenEx and NtAdjustPrivilegesToken
by Rob Shearman Feb. 9, 2005

Feb. 9, 2005

Dmitry Timoshkov wrote: >Hello, > >Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > More complete stubs for DuplicateTokenEx and NtAdjustPrivilegesToken. > > I have an even more complete patch for this that implements the necessary server calls. Alexandre, please don't apply. Rob

1 0

Broken cross-build, again.
by Paul Millar Feb. 9, 2005

Feb. 9, 2005

Hi everyone, Just a head's up that the new tests broken cross-building winetest.exe. The gory details are reproduced below. I'm afraid I'm away for a long weekend, without net access, so can't fix any until I'm back (Wednesday). Cheers, Paul. [paulm(a)quisquiliae tests]$ make i686-mingw32msvc-gcc clist.o clsid.o generated.o ordinal.o path.o shreg.o string.o testlist.o -o shlwapi_test.exe -lshlwapi -ladvapi32 -lole32 -loleaut32 path.o(.text+0x20bb): In function `test_PathIsValidCharA': /home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:653: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x2106):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:656: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x2152):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:661: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x21c2):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:669: undefined reference to `PathIsValidCharA(a)8' path.o(.text+0x224b): In function `test_PathIsValidCharW': /home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:681: undefined reference to `PathIsValidCharW(a)8' path.o(.text+0x2296):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:684: undefined reference to `PathIsValidCharW(a)8' path.o(.text+0x22e0):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:689: undefined reference to `PathIsValidCharW(a)8' path.o(.text+0x2350):/home/paulm/Testing/wine-cross-source/dlls/shlwapi/tests/path.c:697: undefined reference to `PathIsValidCharW(a)8' distcc[26570] ERROR: compile on localhost failed make: *** [shlwapi_test.exe] Error 1

3 3

IDC_RIGHT, IDC_CENTER not defined ?
by George Ginden Feb. 9, 2005

Feb. 9, 2005

OK I'm trying to implement text alignment in the edit control. Now, one question how do I know (in the EDIT_WM_NCCreate for example) if the text alignment has been requested by the programmer ? I guess the GetDlgItem function on es->hwndParent should do the job... but IDC_RIGHT and IDC_LEFT are not defined. So How can I get check for the requested alignment ? Regards.

3 3

Re: dlls/shell32/cpanelfolder.c - extended
by Dmitry Timoshkov Feb. 9, 2005

Feb. 9, 2005

"Ge van Geldorp" <gvg(a)reactos.com> wrote: > memcpy(&sei_tmp, psei, sizeof(sei_tmp)); > sei_tmp.lpFile = path; > sei_tmp.fMask &= ~SEE_MASK_INVOKEIDLIST; > + sei_tmp.lpVerb = L"cplopen"; You can't use unicode literals in Wine, you need to explicitly declare them. -- Dmitry.

1 0

Regression in "Star wars: The Phantom Menace"
by Carlos Lozano Feb. 8, 2005

Feb. 8, 2005

Hello, The patch: http://www.winehq.org/hypermail/wine-cvs/2005/01/0612.html Log message: Rein Klazes <wijn(a)wanadoo.nl> Get rid of the rdtsc cpu instruction method for calculation of the performance counter. Put the calculation (based on gettimeofday) in NtQueryPerformanceCounter() and use that in the kernel functions. Causes regression in the game "Star Wars: The Phantom Menace". The game was playable before of the patch, now it is freezes in the 3th title screen. Regards, Carlos. -- ___ _ \ | / Consulting | . |._ _ _| | ___ ___ ___ http://www.andago.com | || ' |/ . |<_> |/ . |/ . \__ GNU/Linux |_|_||_|_|\___|<___|\_. |\___/ _ \ __|\ \ / Carlos A. Lozano <___'/ | \ -_) __/\__ \ > < -_) [ carlos.lozano(a)andago.com ]\___|_| ____/ _/\_\___| [ calb(a)epsxe.com ] http://www.ePSXe.com

3 3

Lotus Notes - still broken
by Paul R Streitman Feb. 8, 2005

Feb. 8, 2005

This is not intended to be a nag, but since so very much has gone into CVS in the two months since 12/07 I thought that I would try today's CVS level with Lotus Notes. As the subject says, it is still broken. Thanks, Paul z/OS core components development Internet: prs(a)us.ibm.com

2 2

Re: winrash bug
by Chris Morgan Feb. 8, 2005

Feb. 8, 2005

Is this based on what the installer displays or upon output from winrash in the debug.txt file? Chris > > From: Ivan Leo Puoti <ivanleo(a)gmail.com> > Date: 2005/02/08 Tue PM 01:35:43 EST > To: wine-devel(a)winehq.com > Subject: winrash bug > > version 0011 incorrectly detects windows nt 4.0 as windows 95. > > Ivan. > >

2 1

winrash bug
by Ivan Leo Puoti Feb. 8, 2005

Feb. 8, 2005

version 0011 incorrectly detects windows nt 4.0 as windows 95. Ivan.

1 0

Re: Tests for bug 2686
by Alexandre Julliard Feb. 8, 2005

Feb. 8, 2005

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > Here's some tests which show the problem reported as bug 2686. I tried to > find a way to fix it but its not simple. (Note I can only confirm that XP > behaves as described). On XP yes, but it will fail on Win9x, the API doesn't guarantee that the returned size will be identical to the allocated size. Unless you have a real app that depends on that I don't think there's much point in doing that test. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: MSIEXEC: fix command line parsing
by Alexandre Julliard Feb. 8, 2005

Feb. 8, 2005

Mike McCormack <mike(a)codeweavers.com> writes: > ChangeLog: > * Fix msiexec's command line parsing. What does msiexec require that the standard command-line parsing cannot support? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: bi-arch on an amd64
by Alex Woods Feb. 8, 2005

Feb. 8, 2005

Hi, I too am trying to compile a working multilib wine. I have got a little further, and actually have a binary that doesn't produce any errors now. Unfortunately, it doesn't seem to do anything at all, and just returns me to the command line with an exit status of 2. I've yet to dig into that one. For reference, I am using gentoo with a multilib gcc, applying the attached patch and then running this sequence of commands: autoconf ./configure --x-libraries=/emul/linux/x86/usr/X11R6/lib make depend && make The small patch I've attached fixes the two problems I came across - one already mentioned by Gabriel de Perthuis. That problem appears to be one of a deprecated? syscall. The other problem is that configure was not detecting x86_64 as being an x86 and hence not building the wine-preloader which is why Gabriel was getting his strange 'wine: could not exec \uffff\uffffmU\uffff\uffffmUp/bin/wine-pthread' message. Should I send the patch to wine-patches also? Or can it make its way into CVS from here? I'm going to see if I can track down which exit(2) I'm hitting now. I'm new to the wine source code, so any suggestions are welcome. -- Alex

1 3

Re: widl: let widl understand typedef enum
by Huw D M Davies Feb. 8, 2005

Feb. 8, 2005

On Sun, Feb 06, 2005 at 09:31:37AM -0500, Vincent Béron wrote: > Le dim 06/02/2005 à 09:01, Mike Hearn a écrit : > > On Sat, 05 Feb 2005 12:37:08 -0600, Rob Shearman wrote: > > > Yeah, it seems strange, but I have a test program here that shows it is > > > 32-bits application-side for proxies/stubs. > > > > There's all kinds of brokenness going on in their variant marshalling, eg > > some types are mapped seemingly at random to others. I have a list with > > some of the details around here somewhere, but I'd totally believe > > whatever Rob says on this no matter how weird. > > VT_I4 it is then. > > This supercedes my widl3.diff patch. > > Changelog: > A RPC_FC_ENUM16 is a VT_I4. Actually this should be VT_USERDEFINED. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Wine for Linux PPC emulate Mac OS
by M-Rick Feb. 8, 2005

Feb. 8, 2005

The Wine http://www.winehq.com/ project has been created to emulate Windows to be able to run windows softwares directly under Linux without to have to emulate Windows. It's very great and wonderful idea ! The Darwine http://darwine.opendarwin.org/ project aims to to the same but under Mac OS X with adding also the emulation of an x86 CPU. But, I wanted to know something, or even to make a proposal. Would it be possible to make a special Wine version for Linux PPC that instead of emulating Windows would emulate Mac OS ? Yes there's already the very great Mac On Linux PPC (MOL) http://www.maconlinux.org/ that can let run Mac OS applications, but you have to run Mac OS in parallel ... It is great, but Mac OS takes rooms and CPU and for some usages, maybe it is not completely useful. Would it be possible to make such a software a WinePPC for exemple that would let run Microsoft Office X 2004 Mac or Adobe CS Mac or Macromedia MX Mac directly under Linux PPC without having to install a Mac OS ? To make simple to run Mac OS softwares directly under the Linux desktop environment.

6 6

Re: dsound: Properly implement DllCanUnloadNow
by Robert Reif Feb. 8, 2005

Feb. 8, 2005

James Hawkins wrote: >Hi, > >Changelog >* Properly implement DllCanUnloadNow ref counting. > > > dsound.dll is a strange dll that doesn't really follow proper COM reference counting rules for buffers. This is intentional by Microsoft (don't know why) and was made common by the example code from "Inside Direct X" . You may want to add a test to the dsound.dll regression tests to verify what Microsoft does.

2 2

[oleaut32/typelib.c] TLB_ReadTypeLib question
by Paul Vriens Feb. 7, 2005

Feb. 7, 2005

Hi, while browsing through typelib.c I saw: 287 */ 288 int TLB_ReadTypeLib(LPCWSTR file, INT index, ITypeLib2 **ppTypelib); 289 290 HRESULT WINAPI LoadTypeLib( Is line 288 supposed to be there ? Cheers, Paul.

2 1

Re: widl: support ATTR_READONLY for interface properties
by Huw D M Davies Feb. 7, 2005

Feb. 7, 2005

On Sun, Feb 06, 2005 at 09:50:31AM -0500, Vincent Béron wrote: > There are probably other easy ones like this one, but for now I only > need this one. > > Huw, am I stepping on your toes? Nope, but I do have some more patches left in my tree that I need to tidy up a bit before submitting - notably support for modules. I've almost got a version of stdole2.tlb too... But feel free to carry on. Cheers, Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re-examining SetThreadContext
by Mike Hearn Feb. 7, 2005

Feb. 7, 2005

Hi Alexandre, A user recently reported another app that doesn't work due to Armadillo copy protection. This scheme requires SetThreadContext/GetThreadContext to work properly and currently they do not. These two functions require the thread to be suspended, therefore they always return a bogus context (blocking on a wineserver wait pipe). I wrote a patch for this a while ago: http://navi.cx/svn/misc/trunk/winekb/patches/thread-context.patch However you felt it had races in it. There were two possible races I could see: - The race between suspending the thread and the sigcontext being uploaded. This was not a problem with my patch as Get/SetThreadContext loop. - A race where you can call SuspendThread again before the SIGUSR1 handler has completed. I believe this was the sticking point last time, no? But I can't see how this can happen because SIGUSR1 is blocked while it's being handled. So in the following sequence: PROCESS A: SuspendThread() PROCESS A: GetThreadContext() PROCESS B: SIGUSR1 PROCESS B: upload sigcontext PROCESS B: block PROCESS A: GetThreadContext() returns PROCESS A: ResumeThread PROCESS B: unblock, download sigcontext, restore, finish I do not see where the races are. Could you please re-examine this patch and let me know if there are any more problems with it? Dealing with the set/thread context operations in SIGUSR1 makes sense because they are only allowed when the target thread is suspended. thanks -mike

2 5

Re: wine/dlls/dbghelp elf_module.c
by Eric Pouech Feb. 7, 2005

Feb. 7, 2005

Alexandre Julliard a écrit : > ChangeSet ID: 15811 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2005/01/31 10:24:57 > > Modified files: > dlls/dbghelp : elf_module.c > > Log message: > Silence a noisy FIXME I fear that the issue may be somewhere else than the pure FIXME. Can you describe what actually happened ? A+ -- Eric Pouech

2 1