March 2005 - Wine-Devel - list.winehq.org

Re: ntdll: Add NtCreateKey tests
by Robert Shearman March 3, 2005

March 3, 2005

James Hawkins wrote: >On 03 Mar 2005 11:02:24 +0100, Alexandre Julliard <julliard(a)winehq.org> wrote: > > >>James Hawkins <truiken(a)gmail.com> writes: >> >> >> >>>I've been discerning the behavior of RegCreateKey and NtCreateKey when >>>creating a key directly under HKLM or HKU, and this test reveals that >>>NtCreateKey does check for this case and returns a >>>STATUS_INVALID_PARAMETER. >>> >>> >>This is going to break registry initialisation. Do you really have an >>app that depends on that? >> >> >> > >What are the steps I need to take to break registry initialisation? I >did wonder how anything in the real win32 registry could be created >though if you can't create a key directly under HKLM or HKU. If this >really does break initialisation, can we implement a different >create_key that has little restrictions and would only be used >internally, or would this just be scrapped entirely? > > It looks like Windows only uses RegLoadKey to create keys under HKLM and HKU. Maybe we should do the same. Rob

2 4

Re: Wine cabinet.dll FDI Conformance Test Patch
by Dimitrie O. Paun March 3, 2005

March 3, 2005

On Wed, Mar 02, 2005 at 03:41:21PM -0800, Rizwan Kassim wrote: Good stuff guys! Here are a few comments: +#ifndef STANDALONE +#include <wine/test.h> +#define ok2 ok +#else +/* To build outside Wine tree, compile with cl -DSTANDALONE -D_X86_ tvfs.c cabinet_fdi.c FDI.lib + These are only called if standalone are used, defining ok and START_TEST, which would normally be declared in winetree */ +#include <assert.h> +#include <stdio.h> +#define START_TEST(name) main(int argc, char **argv) +#define ok(condition, msg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__); \ + exit(1); \ + } } while(0) +#define ok2(condition, msg, arg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__, arg); \ + exit(1); \ + } } while(0) +#define todo_wine Please get rid of this. It is useless in the Wine tree. If you need it, just put it in a private header file, and include it there. +#ifndef DEBUG_ALLOC +FNALLOC(final_alloc) { + return malloc(cb); +} +FNFREE(final_free) { + free(pv); + return; +} +#else +FNALLOC(final_alloc) { + trace(" FNALLOC just called with %d\n",cb); + return malloc(cb); +} +FNFREE(final_free) { + trace(" FNFREE just called with %d\n",pv); + free(pv); + return; +} +#endif No need for this either. It's a test after all, there's no big deal if you have a memory leak... :) +#ifdef VERBOSE + trace(" FNFDINOTIFY real just called with %d, %d \n",fdint,pfdin); +#endif Don't do it this way. Define trace such that you can use it unconditionally. In general, try to avoid using the preprocessor in the code. + trace(" Cabinet Data : cbC %d cF %d cFi %d si %d iC %d fr %d hp %d hn %d\n", + cabinfo.cbCabinet, + cabinfo.cFolders , + cabinfo.cFiles , + cabinfo.setID, + cabinfo.iCabinet, + cabinfo.fReserve , + cabinfo.hasprev , + cabinfo.hasnext ); These should fit on 2-3 lines, no? + ok2 ( cabinfo.cbCabinet == TcbCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFolders == TcFolders, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFiles == TcFiles, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.setID == TsetID, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.iCabinet == TiCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.fReserve == TfReserve, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasprev == Thasprev, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasnext == Thasnext, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); Use ok() instead of ok2(). Also, it's probably better if the message contains the values of the variables that don't match, so we know why it failed. +#ifdef TVFS_DEBUG + trace("tvfs_create called with %s, %d, %d\n", fname, buf, len); +#endif Similar to the one above, do the test inside the body of trace(), not on every use. + switch(whither) { + case SEEK_SET: { + handles[h]->pos = whence; + break; + } + case SEEK_CUR: { + handles[h]->pos += whence; + break; + } This one needs a bit of indentation, no? +int tvfs_close(int h){ + int inode = handles[h]->inode; +#ifdef TVFS_DEBUG + trace("tvfs_close called with %d\n", h); +#endif + if (!files[inode]){ + return -1; + } + free(handles[h]); + /* Currently does NOT enabled open to reuse this handle */ + return 0; + } The formatting on this is funny. It needs indenting, spaces before '{', and the opening braket for the function on a new line. +main(){ Ditto. -- Dimi.

2 1

Re: MSI trouble with ALLUSERPROFILE
by Juan Lang March 3, 2005

March 3, 2005

> I get err with %ALLUSERPROFILE during install program: <snip> > Where I will set this env variable? (I know I can do it in shell, but > what is the right way?) Hm.. I never did get this quite right. For consistency, it should be in wine.inf. That's where USERPROFILE is: HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"USERPROFILE",,"%53%" But I don't think it can go here, because setupapi (which is what interprets those funny "%53" type strings) doesn't have a magic constant for this, and there isn't a CSIDL value for it. So maybe shell32 should set it in SHELL_RegisterShellFolders? --Juan __________________________________ Celebrate Yahoo!'s 10th Birthday! Yahoo! Netrospective: 100 Moments of the Web http://birthday.yahoo.com/netrospective/

1 0

Use of STLPort with winegcc
by Boaz Harrosh March 3, 2005

March 3, 2005

Winegcc will prepend any of the command line switches with "-I wine/include/msvcrt" if the "-no-cygwin" flag is specified. This breaks STLPort because STLPort must be first on the search path, before the regular c-runtime of the compiler. This way it can do it's tricks of what to use and what not to use from the standard c-runtime. What is the current way to solve it. I could remove the "-no-cygwin" flag and Manually add the "-I wine/include/msvcrt" and "-D__MSVCRT__". But how do I add the "-dmsvcrt" on the Winebuild command line, as it is all internal to winegcc. What would be the right way to do it? I would submit a patch, but what should I do? Just append the "-I .../msvcrt" instead of prepend, or maybe use "-isystem .../msvcrt". The docs for gcc say that "-isystem" folders will be searched before the default gcc folders but after any -I folders. Free Life Boaz

2 1

Re: MSI: Radio Buttons
by Dmitry Timoshkov March 3, 2005

March 3, 2005

"Ulrich Czekalla" <ulrich.czekalla(a)utoronto.ca> wrote: > + if (control->hwnd) > + { > + WNDPROC oldproc = (WNDPROC) SetWindowLongW(control->hwnd, GWLP_WNDPROC, > + (LONG)MSIRadioGroup_WndProc); I'd suggest to use SetWindowLongPtrW even it's just a macro in Win32 we still need to write 64-bit clean code. -- Dmitry.

1 0

Speach rec. on Wine
by wino＠piments.com March 3, 2005

March 3, 2005

Hi, I am trying to get Dragon Naturally Speaking to run under Wine. I have got it installed successfully from CD, now I need to get it running. I have wine-20050111 installed , a 2.6.10 kernel and a current version of IE6 since Dragon apparently needs IE installed . Some advice please. Is there any fundemental problems which make this a no-hoper, has anyone got this working so far? Any a-priori conditions or advice I should know, like what sound model to use on Linux. Where should I search for detailed info on debugging something like this? There seems to be very little detailed help for Wine which I find surprising. Maybe I have just missed it Any other advice that could save me wasting lots of time. TIA .

2 1

Re: Add all MIME types
by Mike Hearn March 3, 2005

March 3, 2005

On Wed, 02 Mar 2005 12:56:33 +0000, Mike Hearn wrote: > Oh my god, there are a lot of these! Wouldn't it be a better long term > solution to just get the desktop environments sorted out? They should be > sharing the same MIME database now right? So why are they not all > identifying EXEs as the same MIME type? By the way, that wasn't an objection to the patch. I think it should go in. It's trivial enough and doesn't have any bad consequences except slightly less "elegance" but we can fix that one day when all the desktops are fixed :)

1 0

http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz
by Grant Williamson March 3, 2005

March 3, 2005

Hi, I am just wondering how much does the wine source located on http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz differ from 20040716. I guess its codeweavers internal patched version, I see changes in there dating to January. Are there any restrictions on using this source?

3 3

Re: imagelist: style fixes
by Alexandre Julliard March 3, 2005

March 3, 2005

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > ChangeLog > Style fixes for consistent formatting. I knew I was going to regret applying Mike's indentation patches... Folks, please let's not start an indentation police, there's no reason to "fix" anything unless a file is really so messed up that it becomes unreadable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [user/tests/sysparams.c] Added more SetLastError(0)'s
by Dmitry Timoshkov March 3, 2005

March 3, 2005

"Paul Vriens" <Paul.Vriens(a)xs4all.nl> wrote: > as discussed a few times on wine-devel, there isa need to clear the > last error before calling a SPI_{GET|SET} routine. > > It appears that not every call resets the last error to 0 on succession > and thus errors will propagate and leave us in the dark. You have to set last error to some bogus value (usually 0xdeadbeef) in order to test whether an API really has changed it. -- Dmitry.

3 2

Re: MSI: Radio Buttons
by Alexandre Julliard March 3, 2005

March 3, 2005

Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes: > const static WCHAR szStatic[] = { 'S','t','a','t','i','c',0 }; > +const static WCHAR szButton[] = { 'B','U','T','T','O','N', 0 }; > + > +const static WCHAR szButtonData = { 0 }; Did you really intend to use an empty string here for the button property? That doesn't seem right; though if you really need to redefine the winproc it would be much cleaner IMO to define a proper window class. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20 and test app
by Mike McCormack March 3, 2005

March 3, 2005

Hi Krzysztof, Krzysztof Foltman wrote: > This is an attempt at starting a RichEdit 2.0 clone, plus a test app for > it (which I, for some reason, decided to call Wine WordPad). Cool. Looks like you've done alot of good work. > It lacks most essential functionality, and source formatting is not > exactly standard, but it has enough functionality to make a couple of > Wine developers convince me to release it now. Or weeks ago. Well, you wrote it, so you get to choose the formatting. I like that you've used lots of small functions, rather than monolithic 200 line globs. I like the asserts too. > The test app uses the Mike McCormack's test snippet to fill the control > with some fancy formatted text. > > Hope the patch is OK. Adding new DLL's and EXE's isn't an easy process. OK, now some suggestions: * submitting riched20 and the new wordpad program seperately would be a good idea. The bigger the patch, the longer it tends to hang round before it's committed. * instead of #ifndef __WINESRC__ ... printf ... #endif, how about using wine's debug macros TRACE, ERR, etc? Then you can just #define TRACE to printf when __WINESRC__ isn't defined * instead of XXXFK how about FIXME? * you probably should get rid of the _int3 macro in wrap.c, and replace it with DebugBreak() * ME_DumpParaStyle isn't used... maybe change it to use MESSAGE() rather than a message box. You can dump stuff by checking the condition WINE_TRACE_ON(richedit). You'll need to declare a WINE_DEFAULT_DEBUG_CHANNEL for that.. * maybe you want to add LGPL licenses on your header files? * keep the formatting in your Makefile.in the same as the other dlls. Julliard's a bit fussy about that, so he's probably going to change it anyway. Might as well save him the time. Mike

1 0

World of Warcraft - crash in game
by Alex Woods March 3, 2005

March 3, 2005

Hi, World of Warcraft is working beautifully now apart from a crash that occurs seemingly randomly. The application is catching the crash, and giving a message like this: This application has encountered a critical error: ERROR #132 (0x85100084) Program: C:\Program Files\World of Warcraft\WoW.exe Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557102CD EAX=00000000 EBX=55BDFCA8 ECX=00000000 EDX=55BDFBB8 ESI=5E320308 EDI=00000000 EBP=55BDFC08 ESP=55BDFB9C EIP=557102CD FLG=00010212 CS =0023 DS =002B ES =002B SS =002B FS =005B GS=0063 I know this isn't really much use on it's own. I've tried turning on +relay logging, but it's proved futile - it seems to end up freezing up my system before a crash occurs. One thing that might be useful is that the access violation always seems to be around the same small area of memory each time, eg: Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557103CD Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:5571025D Over the course of 13 (unlucky for me ;)) crashes, these are the only 3 addresses it has given. My question is what can I do to debug this? +relay logging is probably infeasible, but I'd be happy to hack around to get it to only log certain things - I'm not sure what I'd need to log. Also, the last time it crashed, I was lucky enough to have it leave me in winedbg, which I've left open. Is there anything worth my while poking around with in there while I have the chance? I guess I'll be running memtest on my machine too, but I'd like to do what I can in winedbg first ;) Cheers. -- Alex

4 6

%Fp printf format specifier
by Uwe Bonnes March 3, 2005

March 3, 2005

Hallo, http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore98/H… uses a "%Fp" format spezifier. Running with native msvcrt, this seems to be the same as "%p". However builtin msvcrt stumbles about the "superfluous" 'F". Does anybody know what the meaning of the "F" is? I didn't find anything on the net. And b.t.w., how do I get Google to not ignore the '%' in a search for "%Fp"? And mingw/malloc.h has the definitions of _USEDENTRY and _FREEENTRY excahnged and misses more entries... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

6 12

MSI trouble with ALLUSERPROFILE
by Vitaly Lipatov March 3, 2005

March 3, 2005

I get err with %ALLUSERPROFILE during install program: trace:msi:MSI_FormatRecordW (L"[%ALLUSERSPROFILE]") trace:msi:deformat_string_internal Starting with L"[%ALLUSERSPROFILE]" trace:msi:find_next_outermost_key Found Key L"%ALLUSERSPROFILE" trace:msi:deformat_string_internal Current (null) .. L"%ALLUSERSPROFILE" err:msi:deformat_environment Unknown environment variable trace:msi:deformat_string_internal after everything (null) Where I will set this env variable? (I know I can do it in shell, but what is the right way?) -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Use IsWindowVisible instead of GetWindowLong(GWL_STYLE) & WS_VISIBLE as a test for desktop visibility
by Ferenc Wagner March 3, 2005

March 3, 2005

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > let's see if IsWindowVisible() better detects a not visible desktop. Ah, fine, this may put some momentum into the situation! -- Feri.

3 2

Printing in Wine (using "ttydrv" device)...
by Juergen Hammelmann March 3, 2005

March 3, 2005

Hi All, we are developing a windows/wine app for automation of MS Word (serial printing in background to PS files with the WINEPS driver on SuSE 9.2 platform, wine-20050211). We want to run this application and Word in background as server, no graphical output should occur in this environment, we don't like to install a X11-/VNC-Server on the server: Using "ttydrv" device I found out that all graphical output is disabled and wine can run without a X11 Server / VNC Server, this is prefered: but here graphical output of printing is disabled, too! The PS files created are blank! Is there any way to configure functioning printing with "ttydrv" device? Ferenc Wagner told me, that printing and graphical output is done through GDI both, so ttydrv as GDI backend disable this all!? Is this the right explanation? Is there any way to enable this for printing again? Best Regards, Jürgen

1 0

Visual C++ 6.0 as a Winelib IDE?
by Ira Krakow March 3, 2005

March 3, 2005

I have Visual C++ 6.0 running under Crossover Office 4.1, which of course means it's running under Wine. For one of the examples in the Wine/Winelib book, I decided to take the code produced by the VC++ Win32 "Hello World" wizard and see how to port it to Wine. Turns out, it's almost trivial. Create an empty directory, copy the *.c, *.rc, *.h, and *.ico files to it. VC++ produces tons of other files, but they're either used to maintain the Visual Studio environment, or are intermediate compilation files that aren't needed. Then run: $ winemaker . The Makefile that Winemaker generates _almost_ works. You need to delete the references to the mfc library and mfc.dll. After doing that, running make generates the .so file. Wine runs it flawlessly. I got to thinking - can I convert the code from the MFC application as easily? Seems like it's doable, because the generated code runs in VC++/Crossover Office 4.1. I tried the same steps as before, with Winemaker, but I couldn't figure out what Makefile modifications were needed. All of this got me to thinking - could Wine running Visual C++ be a viable IDE for porting? Maybe just linking VC++ with the Winelib libraries would do it. Maybe after tweaking Winemaker and publishing a HOWTO we could show that this is a viable path? It's certainly easier than for Visual Studio developers and could help attract them to Wine. Another benefit - we could use the Visual C++ sample programs as tests for Wine. The programs might exercise areas that haven't been tested thoroughly. What do you think? Ira

5 6

wine-user.pdf feedback
by Dan W. March 2, 2005

March 2, 2005

I think I have the answer why feedback to the wine-user.pdf has so far been disappointing: It's too well written. No questions to ask, almost. Actually, probably 90% of users try to get by without reading it. I saw a posting somwhere today, someone advising someone else about running the wine install, without mentioning uninstalling any old versions. The blind leading the blind. You need to put a big README!!!.TXT file somewhere, where it should say: "You choose: Spend 1 day reading wine-user.pdf, and another day setting it up; or spend a week trying to set it up, a month asking questions at the forums, a year in depression, then finally a day reading wine-user.pdf, and another day setting it up." But probably, the lucky 10% who read it never have any questions, so you don't hear from them. In my case, though, combining a high IQ and being a complete helpless newbie to Linux, is a powerful combination that produces questions out of nowhere. In the chapter about installing and un-installing, one small detail got left out: "How does one KNOW whether wine is installed, and if so what version it is?" I'm sure it must sound like typical newbie crap questions to you, but to me it's a solid and tangible one. Well, I do know that I do have wine installed, because when I installed Fedora Core 2, I said "install everything". Besides, I tried.. "wine /mnt/C/windows/notepad.exe" and it worked!!!! :-) :-) :-) But as for the version of wine I have, I have no idea how to find out. In Windows, I'd check the Add/remove programs, to see if it mentions the version, or I'd look in the installation folder for a readme.txt file. In Linux, not so easy: Even after doing a file search for "wine", I still can't tell what folder it is installed in, if indeed it is installed in ONE folder, and not many. Looks like many, by the looks of it... Or at least two: One under /usr/local, which only contains two files, another for documentation, elsewhere, and I saw a folder somewhere with alotof.dll.so files. Anyways, thank you for the great work you've done and are doing. Some day Historians will remember you like today we remember Leonardo, or whoever: How Humanity rid itself of a great monopoli threat. As newbie as I am in Linux, I'm the expert here at work. If I can get our Windows apps to run on Linux, I might succeed at having the company switch over. Wish me luck.

3 2

vartest.c - major pain in the build process
by Krzysztof Foltman March 2, 2005

March 2, 2005

Is there any reason for gcc 3.3.1 to spend several minutes on compiling dlls/oleaut32/tests/vartest.c ? I guess it can be explained by optimization stage going nuts on compiling long functions with many branches (contained in the macros), but there must be a way to speed this up. It's barely tolerable now, and upgrading gcc is not an option for everyone. Krzysztof

9 23

user/tests/sysparams.c : test_SPI_SETKEYBOARDPREF on win98
by Paul Vriens March 2, 2005

March 2, 2005

Hi, I saw this test was recently added. It fails partly on my win98 box as this registry has the values in a different place. WinXP: [HKEY_CURRENT_USER\Control Panel\Accessibility\Keyboard Preference] "On"="0" Win98: [HKEY_CURRENT_USER\Control Panel\Accessibility] "Keyboard Preference"="0" What's the best(tm) way to cater for both? Just use: SPI_SETKEYBOARDPREF_REGKEY and SPI_SETKEYBOARDPREF_WIN98_REGKEY for example and have the test check the windows version? Or change test_reg_key to cope with 2 different sets? Cheers, Paul.

1 0

Re: Dump HeapWalk entries
by Dimitrie O. Paun March 2, 2005

March 2, 2005

On Wed, Mar 02, 2005 at 05:52:45PM +0100, Uwe Bonnes wrote: > + if ((entry->wFlags & PROCESS_HEAP_ENTRY_BUSY ) > + && (entry->wFlags & PROCESS_HEAP_ENTRY_MOVEABLE)) > + { > + /* Treat as block */ > + DPRINTF( "BLOCK->hMem\t\t:%08lx\n", (DWORD)entry->u.Block.hMem); > + } Please don't introduce _another_ style of brackets, just use the one that's used in the file. Should be either: if (....) { .... } or if (....) { .... } -- Dimi.

1 0

DPLAYX_ConstructData error during tools/wineinstall
by Paul Vriens March 2, 2005

March 2, 2005

Hi, I don't know when it started and if found I wasn't able to reproduce, but this is the message I sometimes get during a tools/wineinstall on a clean cvs install: Configuring Wine for a no-windows install in /data/wine-c... err:dplay:DPLAYX_ConstructData : unable to map static data into process memory space (487) /home/paul/.wine updated successfully. I can only say that I noticed this the last few (3?) weeks or so and haven't before. The first time I saw it, I did some regression testing, but as said, I wasn't able to reproduce at will. Is this a problem or can it be ignored (although it's an err). Or better yet, what could be the cause. Cheers, Paul.

1 0

CVS SERVER OUT OF SPACE?
by Oliver Stieber March 2, 2005

March 2, 2005

Hi, It looks like cvs server has run out of diskspace. cvs update reports. cvs server: Updating . cvs server: failed to create lock directory for `/home/wine/wine' (/home/wine/wine/#cvs.lock): No space left on device cvs server: failed to obtain dir lock in repository `/home/wine/wine' cvs [server aborted]: read lock failed - giving up Send instant messages to your online friends http://uk.messenger.yahoo.com

4 5

Re: [winedbg] Get expressions working again.
by Pouech Eric DMI AEI CAEN March 2, 2005

March 2, 2005

I don't think this patch should go in as it is: - I don't think it's a good idea to have two ways to express a pointer type in the debugger (one being the standard dbghelp's SymTagPointerType, the other one the new deref count you've introduced). It would be better to add dynamic winedbg types (in the contrary to the static one's we already use dbg_itype_*), when we cannot find one in a module. - the returned string (for internal types' name) should be HeapAllocate:d, not a static buffer - please, use the current style for parenthesis, braces... and don't add a new one A+ > Message du 01/03/05 18:28 > De : "Oliver Stieber" > A : wine-patches(a)winehq.com > Copie à : > Objet : [winedbg] Get expressions working again. > > Hi, > This patch starts to get expressions working again and > also allows derefrencing where there is no explicit > type for that dereference. e.g. > > (short)0x12356 now returns the correct value instead > of an error > > *((int *)0x23467) is now a valid expression. > and > ***((int ***)0x23467) should also work properly. > > This should also fix watches with expressions but I > haven't given it much testing. > > Send instant messages to your online friends http://uk.messenger.yahoo.com > > [ winedbg_expressions_os_1.patch (18.4 Ko) ]

2 1