March 2005 - Wine-Devel - list.winehq.org

Re: dlls/advapi32/tests/security.c - Bugfix in test!
by Alexandre Julliard March 19, 2005

March 19, 2005

Jakob Eriksson <jakov(a)vmlinux.org> writes: > --- dlls/advapi32/tests/security.c 14 Mar 2005 17:20:58 -0000 1.12 > +++ dlls/advapi32/tests/security.c 16 Mar 2005 09:32:28 -0000 > @@ -289,8 +289,8 @@ > luid.LowPart = i; > cchName = sizeof(buf); > ret = pLookupPrivilegeNameA(NULL, &luid, buf, &cchName); > - ok( ret && GetLastError() != ERROR_NO_SUCH_PRIVILEGE, > - "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); > + if (GetLastError() != ERROR_NO_SUCH_PRIVILEGE) > + ok( ret, "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); It doesn't really make sense to check the last error if the function succeeded. -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: Wine FAQ removed from the doc tarballs
by Hiji March 19, 2005

March 19, 2005

> I always find it annoying when I cannot go to > /usr/share/doc/<package> I suppose the other option is to provide all docs as a seperate package on a release basis (like any other package.) I could be wrong on this, but I don't think the docs are updated on a monthly basis. :) For example, a user could see that the newest Wine package released thus far is from March and the newest Wine docs package could be November of last year (arbitrary date). And if its only 23kb, it shouldn't be much of a problem for modem users; escpecially since it saves them from having to download an extra 23kb with every Wine release when they don't really need it. :) Hiji P.S. Looking at http://www.gimp.org/downloads/ , it looks like they are already doing something similar with their help files. They offer them as a seperate download. __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: RICHED20: remove casts and unused code
by Dimitrie O. Paun March 19, 2005

March 19, 2005

> +static inline char *RTFStrSave(char *s) Not a big deal, but the name is a bit uncommon. Wouldn't RTFStrDup() be a better/more recognizable name? -- Dimi.

1 0

Re: Wine FAQ removed from the doc tarballs
by Hiji March 18, 2005

March 18, 2005

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > On Fri, Mar 18, 2005 at 02:04:08PM +0100, Francois > Gouget wrote: > > But I don't see any reason not to put it in > wine-doc-html.tar.gz or > > wine-doc-txt.tar.gz. The idea of these tar files > is so that one can get > > all the Wine documentation with just one download > and the FAQ is part of > > the documentation. > > Yes, but I can not possibly see why would anyone > want to download and > read the FAQ like this. A FAQ is essentially a Web > type of document, > best view and browsed on the Web. By including it in > those packages, > we just make them bigger for 99.99% of the users > that don't care > about the FAQ, and those users are probably the ones > that have most > bandwidth restrictions anyway. > > But I'm not totally against it being there, if > people feel strongly > that we must, I'll go with the flow. As a web developer (and Wine user), I feel inclined to believe that all major documentation should be removed from the source. A README file pointing the user to the web site for the latest documentation would be most efficient and beneficial. Basically, by doing this, users will begin realizing that if they want documentation, WineHQ is the place to go. In a sense, it is streamlining information. Not only does this reduce user confusion, but it also minimizes the propagation of old documentation which no one will have the power to update. By not consolidating the documentation resource, there will eventually be a certain percentage of the Wine userbase trying to follow outdated Wine documents. Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

TlsAlloc limitation in winxp mode
by Michael Ost March 18, 2005

March 18, 2005

With the emulation mode set to "winxp" I can only TlsAlloc 64 indexes, even though the MSDN docs say there should be at least 20 million. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/ba… Has anyone done any work on this? Any workaround/hackarounds? ... mo

3 3

Re: [WINEOSS] use default prepare functions
by Francois Gouget March 18, 2005

March 18, 2005

On Thu, 17 Mar 2005, Robert Reif wrote: > Fall back to default header prepare and unprepare functions. > > A driver only needs to support prepare and unprepare functions > when it is doing something special like allocating a DMA buffer for > each header. Since we don't do anything special, just fall back > to the default functions. Removes redundant code. Does that mean we could do the same wor winealsa, winearts, etc? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

3 4

Re: RICHEDIT: RTF reader i18n (now with font charset support)
by Vitaly Lipatov March 18, 2005

March 18, 2005

В сообщении от 17 Март 2005 13:20 Phil Krylov написал(a): > this patch replaces my precious patch "RICHEDIT: RTF reader i18n" and > needs to be applied after Krzysztof Foltman's "RICHEDIT: RTF reader > improvements and optimizations (TAB craziness fixed)" patch. > > ChangeLog: > > Replaced slow and outdated character set handling in RTF reader by > Unicode/codepages support. Added charset->codepage conversion. Will we do this code in locale independent manner? Why we have ansiCodePage=1252 by default? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Registration of dlls - proposition
by Jacek Caban March 18, 2005

March 18, 2005

Hi, Currently functions Dll[Un]RegisterServer in Wine look strange to me. It's a great code duplication. As we have ATLRegistrar implementation right now it can be changed. We can use ATL to register dlls. This way functions Dll[Un]RegisterServer can be really simple and registry can be described by elastic and simple rgs scripts. You can see example of rgs script here: http://cvs.winehq.org/cvsweb/wine/dlls/atl/atl.rgs?rev=1.2&content-type=tex… and documentation of ATLRegistrar here: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vcmfc98/ht… There are two more aspects of this solution: - dependence on atl I don't think it's a true problem as we can create ATLRegistrar by CoCreateInstance and finally we depend on atl _only_ while registering, so it's not a great dependency... - header file We would need to make atliface.idl accessible for other dlls. Actually it is a public ATL header file, so there is nothing wrong in doing this. We could just move it to include/ (or maybe include/atl where, in future, more headers of ATL could be placed). The benefit is: no code duplication, more elastic and clean registration code. What do you think? Is it a good idea? Thanks, Jacek

2 1

Re: Add some autoconf warnings
by Alexandre Julliard March 18, 2005

March 18, 2005

Francois Gouget <fgouget(a)free.fr> writes: > I thought I had sent this patch months ago but apparently not. The > idea is to warn the user when some often used libraries are missing > and is based on the warnings issued for bad Mesa or X > configurations. Let me know if the range of checks should be expanded > or reduced or otherwise tweaked. We've discussed this before, I don't think we should warn about these things, it's perfectly harmless in most cases and will just alarm users for no good reason. -- Alexandre Julliard julliard(a)winehq.org

5 5

Re: Wine FAQ removed from the doc tarballs
by wino＠piments.com March 18, 2005

March 18, 2005

>> A FAQ is essentially a Web type of document, best view and browsed on the Web. This does not ring true. I dont see that any part of the doc "best viewed on the web" unless it's something like a change log or last minute info. Someone with limitted acces time or pay by the minute may well want to grab the whole thing at full speed and read it later off line. Neither do I think that the FAQ represents such a large percentage of the total that it merits speciail treatment. If the doc as a whole is deemed too big split it, I doubt that this is necessary. Regards. -- Opera 7 mail on Linux

1 0

Re: STI, device drivers and stuff
by Damjan Jovanovic March 18, 2005

March 18, 2005

--- Kuba Ober <kuba(a)mareimbrium.org> wrote: > > IStiDeviceControl are probably part of the Windows > DDK > > (Device Driver Kit), and that you get separately > from > > Microsoft (for a ridiculous price). > > It's a free CD. You pay only for shipping. If you > want, I've got two of those > and can transfer one of them to be taken care of by > the wine folks. As long > as it's a US address, that is. > > Cheers, Kuba No, I live in South Africa. Can't you email me the file? Bye Damjan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

Wine FAQ removed from the doc tarballs
by Francois Gouget March 18, 2005

March 18, 2005

I noticed that we don't include the Wine FAQ in the Wine documentation tarballs. So I added it but then I noticed that it was removed from the tarballs by this patch: --- revision 1.36 date: 2003-09-18 20:51:32 +0000; author: julliard; state: Exp; lines: +9 -5 Remove the FAQ from the doc tarball, and build it as a single .html file (based on patch by Dimitrie O. Paun). --- What's the reasoning behind this? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In theory, theory and practice are the same, but in practice they're different.

2 3

Re: ddraw correctness fixes patch
by Christian Costa March 18, 2005

March 18, 2005

> Message du 18/03/05 06:44 > De : "Tom Wickline" > A : "wine-devel" > Copie à : > Objet : ddraw correctness fixes patch > > anyone know why this patch hasn't been accepted? > > http://www.winehq.org/hypermail/wine-patches/2005/03/0328.html > > Tom > Hi Tom, Sorry I missed the patch on wine-patches but I do remember an old version sent to wine-devel. So let's review it. :-) The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize = sizeof(ddesc); if (src == NULL) IDirectDrawSurface7_Lock(iface, &lock_dst, &ddesc, DDLOCK_WRITEONLY, 0); else if (src == iface) { RECT lock_union = < rect that just contains lock_dst and lock_src >; IDirectDrawSurface7_Lock(iface, &lock_union, &ddesc, 0, 0); sdesc = ddesc; } else { IDirectDrawSurface7_Lock(src, &lock_src, &sdesc, DDLOCK_READONLY, 0); IDirectDrawSurface7_Lock(iface, &lock_dst, &ddesc, DDLOCK_WRITEONLY, 0); } and the previous locking code should be used. The added DD_STRUCT_INIT are useless. Hope that helps. Bye, Christian

1 0

animate control regression
by Krzysztof Foltman March 18, 2005

March 18, 2005

The current CVS version has a regression in the animate control, causing a deadlock, most probably in WM_DESTROY handler, in the app I'm testing Wine with. trace:message:SPY_ExitMessage (0x10038) L"{SysAnimate32}" message [0047] WM_WINDOWPOSCHANGED returned 00000000 trace:message:SPY_EnterMessage (0x10038) L"{SysAnimate32}" message [0002] WM_DESTROY sent from self wp=00000000 lp=00000000 err:ntdll:RtlpWaitForCriticalSection section 0x403a3cb8 "?" wait timed out in thread 0009, blocked by 000a, retrying (60 sec) Reversing these two patches seems to fix the problem: http://cvs.winehq.org/patch.py?id=16654 http://cvs.winehq.org/patch.py?id=16619 I don't know if patch 16654 has any effect on this problem - I don't know this code well enough to reverse patches in random order. Hope it isn't difficult to fix... Krzysztof

3 3

New wine user
by Jerry H. Menor March 18, 2005

March 18, 2005

Hi all, Wine is ronning just fine, and our program.exe is working, I just want to know if it is possible to create a shorcut of our program on our desktop so that a end user will just click the icon on the desktop to run the program.exe without typing on th text command "wine program.exe". TYIA! Jerry

2 1

Re: TlsAlloc limitation in winxp mode
by Jon Griffiths March 18, 2005

March 18, 2005

Hi Michael, > With the emulation mode set to "winxp" I can only TlsAlloc 64 > indexes, even though the MSDN docs say there should be at least > 20 million. You're misreading that page, the limits are: Win 2000/2003 & XP - 1088 indexes per process Win Me/98 - 80 indexes per process Win NT and 95 - 64 indexes per process So it seems that Me/98 add 16 on top of the original 64 limit, while from Win2k onwards another 1024 indices were added. You can almost certainly work around this if you have the source for the app you are trying to run, unless your app has more than 64 threads running at once. Just take all of the per-thread data you need and stick it into a structure, store only the pointer to that for each thread (1 slot). This adds a layer of indirection but means you are limited only by the heap, provided you don't have more than 64 threads. See dlls/msvcrt/thread.c for an implementation example. Cheers, Jon "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: New wine user
by Hiji March 18, 2005

March 18, 2005

--- "Jerry H. Menor" <jerry(a)netserve.ph> wrote: > Hi all, > > Wine is ronning just fine, and our program.exe is > working, I just want to > know if it is possible to create a shorcut of our > program on our desktop > so that a end user will just click the icon on the > desktop to run the > program.exe without typing on th text command "wine > program.exe". > > TYIA! > Jerry Hi Jerry, Yes, you can. On your Linux desktop, create a launcher with the "wine program.exe" command (there should be a field for such a thing). Also, for general Wine usage, wine-users(a)winehq.org might be better suited for your needs. :) Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: OLE32: Allow STGM_SHARE_EXCLUSIVE for nameless storage files
by Mike McCormack March 18, 2005

March 18, 2005

Actually, I think the test is just the wrong way round. It should read if (STGM_SHARE_MODE(grfMode) != STGM_SHARE_EXCLUSIVE) I screwed it up in the following commit: http://cvs.winehq.org/cvsweb/wine/dlls/ole32/storage32.c.diff?r1=1.71&r2=1.… Mike Troy Rollo wrote: > StgOpenStorage was failing if pwcsName was NULL and the share flags were > STGM_SHARE_EXCLUSIVE. It shouldn't (Windows allows this). > > ChangeLog: > Allow STGM_SHARE_EXCLUSIVE for StgOpenStorage with pwcsName == NULL > - if (STGM_SHARE_MODE(grfMode) == STGM_SHARE_EXCLUSIVE) > - goto end; > -

1 0

ddraw correctness fixes patch
by Tom Wickline March 17, 2005

March 17, 2005

anyone know why this patch hasn't been accepted? http://www.winehq.org/hypermail/wine-patches/2005/03/0328.html Tom

1 0

Re: STI, device drivers and stuff
by Damjan Jovanovic March 17, 2005

March 17, 2005

--- Mike McCormack <mike(a)codeweavers.com> wrote: > > I've noticed that STI.DLL uses the > IStiDeviceControl > > interface, which is defined by the STIUSD.H file I > > haven't got (it might be part of the Windows DDK > or > > something). Any idea where to find it? > > I can't see any definition of IStiDeviceControl in > the Windows SDK. > Where are you seeing stiusd.h? It's in the .NET 2003 MSDN Library documentation, section "Windows Development", subsection "Device Drivers", somewhere in the still image stuff (I can send you a PDF of it, it's around 30 MB). IStiUSD and IStiDeviceControl are probably part of the Windows DDK (Device Driver Kit), and that you get separately from Microsoft (for a ridiculous price). I'll see if I can get it from the ReactOS people. Does anyone else on this mailing list have the Windows DDK around and a spare stiusd.h they want to share? > Mike Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Re: [WINEALSA] use real name for wave also
by Robert Reif March 17, 2005

March 17, 2005

Robert Reif wrote: > Use real names for wave device also. Please disregard this patch. I will present a better one shortly.

1 0

WineConf: book your hotel now
by Brian Vincent March 17, 2005

March 17, 2005

I'm just sending this out as a reminder for everyone to book your hotel room for WineConf. For more information, check out: 1. http://www.winehq.com/site/wineconf 2. http://www.winehq.com/site/wineconf/travel The last day to reserve a room is tomorrow - March 17th. There's no guarantee rooms will be available after that, and I don't have any indication the hotel will allow reservations after that. If you haven't looked at the details, it's a great deal - 81EUR for Friday and Saturday night and it includes breakfast in the morning. If you're thinking to yourself, "I'd like to go to Wineconf, but I don't think I'm cool enough." Well, you should try to attend. You'll probably really enjoy it. PS - still looking for ideas for the agenda, if you have any, let me know. Also let me know if you'd like to present something. -Brian

9 19

Suggestion for a couple of additional janitorial projects
by Dmitry Timoshkov March 17, 2005

March 17, 2005

Hi all, I'd like to suggest to add the following janitorial projects for Wine: 1. Fix Wine to be compilable by a 64-bit compiler a) before accomplishing this task read a good article about porting Win32 code to Win64. b) inspect and fix all public Win32 headers to match PSDK definitions. c) make sure that pointers do not get truncated. d) add support for Win64. 2. Fix wrong assumptions in Wine about endianess. a) inspect all Wine code and public headers to eliminate endianess dependent constructs (low/high parts of a field, bit fileds), add WORDS_BIGENDIAN when appropriate. b) make sure that Wine code handles data in an endianess independent way. -- Dmitry.

2 2

Re: ole32: begin implementing IPropertyStorage
by Alexandre Julliard March 17, 2005

March 17, 2005

Juan Lang <juan_lang(a)yahoo.com> writes: > This is getting big enough I might as well float a patch by. > > ChangeLog: start of implementation of IPropertyStorage This breaks the tests: storage32.c:481: Test failed: failed to create property set storage storage32.c:489: Test failed: failed to create property set storage storage32.c:496: Test failed: open failed storage32.c:534: Test failed: ref count wrong storage32.c:537: Test failed: ref count wrong make[1]: *** [storage32.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: SHELL32: minor fix in debughlp.c (crash in file dialogs)
by Mike McCormack March 17, 2005

March 17, 2005

This following patch breaks the file open dialog, so if your file open dialog box crashes in the CVS, this is the thing to revert. _dbg_ILGetNext doesn't seem to return NULL if pidl->mkid.cb is zero... Mike Filip Navara wrote: > _dbg_ILGetNext returns NULL if pidl->mkid.cb is zero, fix the > loops accordingly. > > > ------------------------------------------------------------------------ > > --- dlls/shell32/debughlp.c > +++ dlls/shell32/debughlp.c > @@ -215,7 +215,7 @@ > > pidltemp = _dbg_ILGetNext(pidltemp); > > - } while (pidltemp->mkid.cb); > + } while (pidltemp); > } > else > { > @@ -275,7 +275,7 @@ > } > } > pidltemp = _dbg_ILGetNext(pidltemp); > - } while (pidltemp->mkid.cb); > + } while (pidltemp); > } > return ret; > }

1 0