March 2005 - Wine-Devel - list.winehq.org

Re: dlls/advapi32/tests/security.c - Bugfix in test!
by Alexandre Julliard March 19, 2005

March 19, 2005

Jakob Eriksson <jakov(a)vmlinux.org> writes: > --- dlls/advapi32/tests/security.c 14 Mar 2005 17:20:58 -0000 1.12 > +++ dlls/advapi32/tests/security.c 16 Mar 2005 09:32:28 -0000 > @@ -289,8 +289,8 @@ > luid.LowPart = i; > cchName = sizeof(buf); > ret = pLookupPrivilegeNameA(NULL, &luid, buf, &cchName); > - ok( ret && GetLastError() != ERROR_NO_SUCH_PRIVILEGE, > - "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); > + if (GetLastError() != ERROR_NO_SUCH_PRIVILEGE) > + ok( ret, "LookupPrivilegeNameA(0.%ld) failed: %ld\n", i, GetLastError()); It doesn't really make sense to check the last error if the function succeeded. -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: Wine FAQ removed from the doc tarballs
by Hiji March 19, 2005

March 19, 2005

> I always find it annoying when I cannot go to > /usr/share/doc/<package> I suppose the other option is to provide all docs as a seperate package on a release basis (like any other package.) I could be wrong on this, but I don't think the docs are updated on a monthly basis. :) For example, a user could see that the newest Wine package released thus far is from March and the newest Wine docs package could be November of last year (arbitrary date). And if its only 23kb, it shouldn't be much of a problem for modem users; escpecially since it saves them from having to download an extra 23kb with every Wine release when they don't really need it. :) Hiji P.S. Looking at http://www.gimp.org/downloads/ , it looks like they are already doing something similar with their help files. They offer them as a seperate download. __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: RICHED20: remove casts and unused code
by Dimitrie O. Paun March 19, 2005

March 19, 2005

> +static inline char *RTFStrSave(char *s) Not a big deal, but the name is a bit uncommon. Wouldn't RTFStrDup() be a better/more recognizable name? -- Dimi.

1 0

Re: Wine FAQ removed from the doc tarballs
by Hiji March 19, 2005

March 19, 2005

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > On Fri, Mar 18, 2005 at 02:04:08PM +0100, Francois > Gouget wrote: > > But I don't see any reason not to put it in > wine-doc-html.tar.gz or > > wine-doc-txt.tar.gz. The idea of these tar files > is so that one can get > > all the Wine documentation with just one download > and the FAQ is part of > > the documentation. > > Yes, but I can not possibly see why would anyone > want to download and > read the FAQ like this. A FAQ is essentially a Web > type of document, > best view and browsed on the Web. By including it in > those packages, > we just make them bigger for 99.99% of the users > that don't care > about the FAQ, and those users are probably the ones > that have most > bandwidth restrictions anyway. > > But I'm not totally against it being there, if > people feel strongly > that we must, I'll go with the flow. As a web developer (and Wine user), I feel inclined to believe that all major documentation should be removed from the source. A README file pointing the user to the web site for the latest documentation would be most efficient and beneficial. Basically, by doing this, users will begin realizing that if they want documentation, WineHQ is the place to go. In a sense, it is streamlining information. Not only does this reduce user confusion, but it also minimizes the propagation of old documentation which no one will have the power to update. By not consolidating the documentation resource, there will eventually be a certain percentage of the Wine userbase trying to follow outdated Wine documents. Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

TlsAlloc limitation in winxp mode
by Michael Ost March 19, 2005

March 19, 2005

With the emulation mode set to "winxp" I can only TlsAlloc 64 indexes, even though the MSDN docs say there should be at least 20 million. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/ba… Has anyone done any work on this? Any workaround/hackarounds? ... mo

3 3

Re: [WINEOSS] use default prepare functions
by Francois Gouget March 18, 2005

March 18, 2005

On Thu, 17 Mar 2005, Robert Reif wrote: > Fall back to default header prepare and unprepare functions. > > A driver only needs to support prepare and unprepare functions > when it is doing something special like allocating a DMA buffer for > each header. Since we don't do anything special, just fall back > to the default functions. Removes redundant code. Does that mean we could do the same wor winealsa, winearts, etc? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

3 4

Re: RICHEDIT: RTF reader i18n (now with font charset support)
by Vitaly Lipatov March 18, 2005

March 18, 2005

В сообщении от 17 Март 2005 13:20 Phil Krylov написал(a): > this patch replaces my precious patch "RICHEDIT: RTF reader i18n" and > needs to be applied after Krzysztof Foltman's "RICHEDIT: RTF reader > improvements and optimizations (TAB craziness fixed)" patch. > > ChangeLog: > > Replaced slow and outdated character set handling in RTF reader by > Unicode/codepages support. Added charset->codepage conversion. Will we do this code in locale independent manner? Why we have ansiCodePage=1252 by default? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Registration of dlls - proposition
by Jacek Caban March 18, 2005

March 18, 2005

Hi, Currently functions Dll[Un]RegisterServer in Wine look strange to me. It's a great code duplication. As we have ATLRegistrar implementation right now it can be changed. We can use ATL to register dlls. This way functions Dll[Un]RegisterServer can be really simple and registry can be described by elastic and simple rgs scripts. You can see example of rgs script here: http://cvs.winehq.org/cvsweb/wine/dlls/atl/atl.rgs?rev=1.2&content-type=tex… and documentation of ATLRegistrar here: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vcmfc98/ht… There are two more aspects of this solution: - dependence on atl I don't think it's a true problem as we can create ATLRegistrar by CoCreateInstance and finally we depend on atl _only_ while registering, so it's not a great dependency... - header file We would need to make atliface.idl accessible for other dlls. Actually it is a public ATL header file, so there is nothing wrong in doing this. We could just move it to include/ (or maybe include/atl where, in future, more headers of ATL could be placed). The benefit is: no code duplication, more elastic and clean registration code. What do you think? Is it a good idea? Thanks, Jacek

2 1

Re: Add some autoconf warnings
by Alexandre Julliard March 18, 2005

March 18, 2005

Francois Gouget <fgouget(a)free.fr> writes: > I thought I had sent this patch months ago but apparently not. The > idea is to warn the user when some often used libraries are missing > and is based on the warnings issued for bad Mesa or X > configurations. Let me know if the range of checks should be expanded > or reduced or otherwise tweaked. We've discussed this before, I don't think we should warn about these things, it's perfectly harmless in most cases and will just alarm users for no good reason. -- Alexandre Julliard julliard(a)winehq.org

5 5

Re: Wine FAQ removed from the doc tarballs
by wino＠piments.com March 18, 2005

March 18, 2005

>> A FAQ is essentially a Web type of document, best view and browsed on the Web. This does not ring true. I dont see that any part of the doc "best viewed on the web" unless it's something like a change log or last minute info. Someone with limitted acces time or pay by the minute may well want to grab the whole thing at full speed and read it later off line. Neither do I think that the FAQ represents such a large percentage of the total that it merits speciail treatment. If the doc as a whole is deemed too big split it, I doubt that this is necessary. Regards. -- Opera 7 mail on Linux

1 0

Re: STI, device drivers and stuff
by Damjan Jovanovic March 18, 2005

March 18, 2005

--- Kuba Ober <kuba(a)mareimbrium.org> wrote: > > IStiDeviceControl are probably part of the Windows > DDK > > (Device Driver Kit), and that you get separately > from > > Microsoft (for a ridiculous price). > > It's a free CD. You pay only for shipping. If you > want, I've got two of those > and can transfer one of them to be taken care of by > the wine folks. As long > as it's a US address, that is. > > Cheers, Kuba No, I live in South Africa. Can't you email me the file? Bye Damjan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

Wine FAQ removed from the doc tarballs
by Francois Gouget March 18, 2005

March 18, 2005

I noticed that we don't include the Wine FAQ in the Wine documentation tarballs. So I added it but then I noticed that it was removed from the tarballs by this patch: --- revision 1.36 date: 2003-09-18 20:51:32 +0000; author: julliard; state: Exp; lines: +9 -5 Remove the FAQ from the doc tarball, and build it as a single .html file (based on patch by Dimitrie O. Paun). --- What's the reasoning behind this? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ In theory, theory and practice are the same, but in practice they're different.

2 3

Re: ddraw correctness fixes patch
by Christian Costa March 18, 2005

March 18, 2005

> Message du 18/03/05 06:44 > De : "Tom Wickline" > A : "wine-devel" > Copie à : > Objet : ddraw correctness fixes patch > > anyone know why this patch hasn't been accepted? > > http://www.winehq.org/hypermail/wine-patches/2005/03/0328.html > > Tom > Hi Tom, Sorry I missed the patch on wine-patches but I do remember an old version sent to wine-devel. So let's review it. :-) The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize = sizeof(ddesc); if (src == NULL) IDirectDrawSurface7_Lock(iface, &lock_dst, &ddesc, DDLOCK_WRITEONLY, 0); else if (src == iface) { RECT lock_union = < rect that just contains lock_dst and lock_src >; IDirectDrawSurface7_Lock(iface, &lock_union, &ddesc, 0, 0); sdesc = ddesc; } else { IDirectDrawSurface7_Lock(src, &lock_src, &sdesc, DDLOCK_READONLY, 0); IDirectDrawSurface7_Lock(iface, &lock_dst, &ddesc, DDLOCK_WRITEONLY, 0); } and the previous locking code should be used. The added DD_STRUCT_INIT are useless. Hope that helps. Bye, Christian

1 0

animate control regression
by Krzysztof Foltman March 18, 2005

March 18, 2005

The current CVS version has a regression in the animate control, causing a deadlock, most probably in WM_DESTROY handler, in the app I'm testing Wine with. trace:message:SPY_ExitMessage (0x10038) L"{SysAnimate32}" message [0047] WM_WINDOWPOSCHANGED returned 00000000 trace:message:SPY_EnterMessage (0x10038) L"{SysAnimate32}" message [0002] WM_DESTROY sent from self wp=00000000 lp=00000000 err:ntdll:RtlpWaitForCriticalSection section 0x403a3cb8 "?" wait timed out in thread 0009, blocked by 000a, retrying (60 sec) Reversing these two patches seems to fix the problem: http://cvs.winehq.org/patch.py?id=16654 http://cvs.winehq.org/patch.py?id=16619 I don't know if patch 16654 has any effect on this problem - I don't know this code well enough to reverse patches in random order. Hope it isn't difficult to fix... Krzysztof

3 3

New wine user
by Jerry H. Menor March 18, 2005

March 18, 2005

Hi all, Wine is ronning just fine, and our program.exe is working, I just want to know if it is possible to create a shorcut of our program on our desktop so that a end user will just click the icon on the desktop to run the program.exe without typing on th text command "wine program.exe". TYIA! Jerry

2 1

Re: TlsAlloc limitation in winxp mode
by Jon Griffiths March 18, 2005

March 18, 2005

Hi Michael, > With the emulation mode set to "winxp" I can only TlsAlloc 64 > indexes, even though the MSDN docs say there should be at least > 20 million. You're misreading that page, the limits are: Win 2000/2003 & XP - 1088 indexes per process Win Me/98 - 80 indexes per process Win NT and 95 - 64 indexes per process So it seems that Me/98 add 16 on top of the original 64 limit, while from Win2k onwards another 1024 indices were added. You can almost certainly work around this if you have the source for the app you are trying to run, unless your app has more than 64 threads running at once. Just take all of the per-thread data you need and stick it into a structure, store only the pointer to that for each thread (1 slot). This adds a layer of indirection but means you are limited only by the heap, provided you don't have more than 64 threads. See dlls/msvcrt/thread.c for an implementation example. Cheers, Jon "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: New wine user
by Hiji March 18, 2005

March 18, 2005

--- "Jerry H. Menor" <jerry(a)netserve.ph> wrote: > Hi all, > > Wine is ronning just fine, and our program.exe is > working, I just want to > know if it is possible to create a shorcut of our > program on our desktop > so that a end user will just click the icon on the > desktop to run the > program.exe without typing on th text command "wine > program.exe". > > TYIA! > Jerry Hi Jerry, Yes, you can. On your Linux desktop, create a launcher with the "wine program.exe" command (there should be a field for such a thing). Also, for general Wine usage, wine-users(a)winehq.org might be better suited for your needs. :) Hiji __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: OLE32: Allow STGM_SHARE_EXCLUSIVE for nameless storage files
by Mike McCormack March 18, 2005

March 18, 2005

Actually, I think the test is just the wrong way round. It should read if (STGM_SHARE_MODE(grfMode) != STGM_SHARE_EXCLUSIVE) I screwed it up in the following commit: http://cvs.winehq.org/cvsweb/wine/dlls/ole32/storage32.c.diff?r1=1.71&r2=1.… Mike Troy Rollo wrote: > StgOpenStorage was failing if pwcsName was NULL and the share flags were > STGM_SHARE_EXCLUSIVE. It shouldn't (Windows allows this). > > ChangeLog: > Allow STGM_SHARE_EXCLUSIVE for StgOpenStorage with pwcsName == NULL > - if (STGM_SHARE_MODE(grfMode) == STGM_SHARE_EXCLUSIVE) > - goto end; > -

1 0

ddraw correctness fixes patch
by Tom Wickline March 18, 2005

March 18, 2005

anyone know why this patch hasn't been accepted? http://www.winehq.org/hypermail/wine-patches/2005/03/0328.html Tom

1 0

Re: STI, device drivers and stuff
by Damjan Jovanovic March 17, 2005

March 17, 2005

--- Mike McCormack <mike(a)codeweavers.com> wrote: > > I've noticed that STI.DLL uses the > IStiDeviceControl > > interface, which is defined by the STIUSD.H file I > > haven't got (it might be part of the Windows DDK > or > > something). Any idea where to find it? > > I can't see any definition of IStiDeviceControl in > the Windows SDK. > Where are you seeing stiusd.h? It's in the .NET 2003 MSDN Library documentation, section "Windows Development", subsection "Device Drivers", somewhere in the still image stuff (I can send you a PDF of it, it's around 30 MB). IStiUSD and IStiDeviceControl are probably part of the Windows DDK (Device Driver Kit), and that you get separately from Microsoft (for a ridiculous price). I'll see if I can get it from the ReactOS people. Does anyone else on this mailing list have the Windows DDK around and a spare stiusd.h they want to share? > Mike Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Re: [WINEALSA] use real name for wave also
by Robert Reif March 17, 2005

March 17, 2005

Robert Reif wrote: > Use real names for wave device also. Please disregard this patch. I will present a better one shortly.

1 0

WineConf: book your hotel now
by Brian Vincent March 17, 2005

March 17, 2005

I'm just sending this out as a reminder for everyone to book your hotel room for WineConf. For more information, check out: 1. http://www.winehq.com/site/wineconf 2. http://www.winehq.com/site/wineconf/travel The last day to reserve a room is tomorrow - March 17th. There's no guarantee rooms will be available after that, and I don't have any indication the hotel will allow reservations after that. If you haven't looked at the details, it's a great deal - 81EUR for Friday and Saturday night and it includes breakfast in the morning. If you're thinking to yourself, "I'd like to go to Wineconf, but I don't think I'm cool enough." Well, you should try to attend. You'll probably really enjoy it. PS - still looking for ideas for the agenda, if you have any, let me know. Also let me know if you'd like to present something. -Brian

9 19

Suggestion for a couple of additional janitorial projects
by Dmitry Timoshkov March 17, 2005

March 17, 2005

Hi all, I'd like to suggest to add the following janitorial projects for Wine: 1. Fix Wine to be compilable by a 64-bit compiler a) before accomplishing this task read a good article about porting Win32 code to Win64. b) inspect and fix all public Win32 headers to match PSDK definitions. c) make sure that pointers do not get truncated. d) add support for Win64. 2. Fix wrong assumptions in Wine about endianess. a) inspect all Wine code and public headers to eliminate endianess dependent constructs (low/high parts of a field, bit fileds), add WORDS_BIGENDIAN when appropriate. b) make sure that Wine code handles data in an endianess independent way. -- Dmitry.

2 2

Re: ole32: begin implementing IPropertyStorage
by Alexandre Julliard March 17, 2005

March 17, 2005

Juan Lang <juan_lang(a)yahoo.com> writes: > This is getting big enough I might as well float a patch by. > > ChangeLog: start of implementation of IPropertyStorage This breaks the tests: storage32.c:481: Test failed: failed to create property set storage storage32.c:489: Test failed: failed to create property set storage storage32.c:496: Test failed: open failed storage32.c:534: Test failed: ref count wrong storage32.c:537: Test failed: ref count wrong make[1]: *** [storage32.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: SHELL32: minor fix in debughlp.c (crash in file dialogs)
by Mike McCormack March 17, 2005

March 17, 2005

This following patch breaks the file open dialog, so if your file open dialog box crashes in the CVS, this is the thing to revert. _dbg_ILGetNext doesn't seem to return NULL if pidl->mkid.cb is zero... Mike Filip Navara wrote: > _dbg_ILGetNext returns NULL if pidl->mkid.cb is zero, fix the > loops accordingly. > > > ------------------------------------------------------------------------ > > --- dlls/shell32/debughlp.c > +++ dlls/shell32/debughlp.c > @@ -215,7 +215,7 @@ > > pidltemp = _dbg_ILGetNext(pidltemp); > > - } while (pidltemp->mkid.cb); > + } while (pidltemp); > } > else > { > @@ -275,7 +275,7 @@ > } > } > pidltemp = _dbg_ILGetNext(pidltemp); > - } while (pidltemp->mkid.cb); > + } while (pidltemp); > } > return ret; > }

1 0

Re: SHELL32: use structure defined in standard headers for advertised shortcut info
by Dmitry Timoshkov March 17, 2005

March 17, 2005

"Mike McCormack" <mike(a)codeweavers.com> wrote: > - LINK_ADVERTISEINFO buffer; > + EXP_DARWIN_LINK buffer; ... > - TRACE("magic %08lx string = %s\n", buffer.magic, debugstr_w(buffer.bufW)); > + TRACE("magic %08lx string = %s\n", buffer.dbh.dwSignature, debugstr_w(buffer.szwDarwinID)); > > - if( (buffer.magic&0xffff0000) != 0xa0000000 ) > + if( (buffer.dbh.dwSignature&0xffff0000) != 0xa0000000 ) After reading your patch I inspected ShlObj.h from PlatformSDK and found out the following: typedef struct { DWORD cbSize; // Size of this extra data block DWORD dwSignature; // signature of this extra data block CHAR szTarget[ MAX_PATH ]; // ANSI target name w/EXP_SZ in it WCHAR swzTarget[ MAX_PATH ]; // UNICODE target name w/EXP_SZ in it } EXP_SZ_LINK, *LPEXP_SZ_LINK; #define EXP_SZ_LINK_SIG 0xA0000001 // LPEXP_SZ_LINK (target) #define EXP_SZ_ICON_SIG 0xA0000007 // LPEXP_SZ_LINK (icon) Is it a better choice? -- Dmitry.

5 4

AW: WineConf: book your hotel now
by Hans-Ulrich Schmid March 17, 2005

March 17, 2005

Hi, there are enough rooms left in the hotel. Please use "WineConf" as keyword. See you in Stuttgart Hans-Ulrich Schmid Wirtschaftsförderung Region Stuttgart GmbH Stuttgart Region Economic Development Corporation FIR_st - Forum IT-Region Stuttgart Friedrichstr. 10 70174 Stuttgart www.first.region-stuttgart.de www.opensource.region-stuttgart.de www.competenzatlas.de www.region-stuttgart.de Tel ++49.711.22835 - 27 Tel mobil ++49.172.7310463 Fax ++49.711.22835 - 55 > -----Ursprüngliche Nachricht----- > Von: Brian Vincent [mailto:brian.vincent(a)gmail.com] > Gesendet: Mittwoch, 16. März 2005 22:41 > An: Paul van Schayck > Cc: wine-devel(a)winehq.org; Hans-Ulrich Schmid > Betreff: Re: WineConf: book your hotel now > > > On Wed, 16 Mar 2005 21:08:29 +0100, Paul van Schayck > <polleke(a)gmail.com> wrote: > > They are already completely booked... they replied "At this time we > > have not any rooms" this afternoon. > > This happened a few weeks ago and they did have rooms available. Did > you include the keyword "WINECON" with your reservation request? As > far as I know we're still ok - the RSVP list is still slightly less > than the number of rooms we've got, plus we know some people on the > RSVP list aren't staying there. > > I'm CC'ing our local contact to see if he can find out what's going > on. Hopefully we're still ok on rooms. Mr. Schmid - can you email > Paul as well as cc the wine-devel(a)winehq.org list when you find out? > > -Brian >

1 0

Re: Problems with VirtualAlloc/Lock
by Michael Ost March 17, 2005

March 17, 2005

On Mon, 2005-03-14 at 20:13, you wrote: > > * VirtualLock does nothing in Wine > VirtualLock does nothing in win95,98,ME as well :) > > I bet the correct behaviour for wine is to do anything in VirtualLock > only if you set windows version to NT/2000/XP. Did you do it? Good point. But the setting is "winxp". I played with the setting and it doesn't change the behavior. > Anyway, mlock() seems to work fine, so this should be implementable. That would be the natural call to use. The absence of mlock in the wine source tree was one of my early clues that there was a problem! %) > > * Wine makes no distinction between MEM_RESERVE and MEM_COMMIT > Assuming that we're talking about VirtualAlloc(). Yes, but I wasn't specific enough. VirtualAlloc(MEM_RESERVE) and MEM_COMMIT are handled differently in the code. I don't understand the code, the design, or Linux mmap() sufficiently to say if they work correctly or not. They both end up calling mmap() which looks right. What I was trying to say is that in winxp MEM_RESERVE and MEM_COMMIT will VirtualAlloc() and/or VirtualLock very different amounts of memory than wine, even on the same (dual booting) machine. Here were my results when I tried to see how much winxp and wine would allocate and lock. The machine has 368M of RAM on it and a ~1GB paging file in Windows. winxp: 1. VirtualAlloc(MEM_RESERVE) -> 2,086,912k 2. SetProcessWorkingSetSize(260,000k) + VirtualAlloc(MEM_COMMIT) + VirtualLock() -> 259,072k 3. VirtualAlloc(MEM_COMMIT) -> 1,011,712k wine: 1. VirtualAlloc(MEM_RESERVE) -> 1,020,928k 2. SetProcessWorkingSetSize(260,000k) + VirtualAlloc(MEM_COMMIT) + VirtualLock() -> 1,020,928k 3. VirtualAlloc(MEM_COMMIT) -> 1,020,928k What I meant by "makes no distinction" is that wine always lets you MEM_RESERVE or MEM_COMMIT 1,020,928k no matter what. In winxp, * VirtualAlloc(MEM_COMMIT) seems bounded by the size of the paging file * VirtualAlloc(MEM_RESERVE) seems just to be 2GB * VirtualLock() is bounded by GetProcessWorkingSet * GetProcessWorkingSet is bounded by how much RAM you have > > * Wine has no implementation of Windows' process working sets > Linux doesn't either. At least I don't know of a documented API that > could > reliably implement semantics of Windows working sets. Maybe it could be > implemented on other OSes like some BSDs if they have such APIs. Maybe > there's something in /proc/sys/vm or somesuch to tweak those, but then > it > would probably be system-wide. I'm no expert here I'm afraid :( I was wondering about getrtlimit/setrlimit. The upper bound of the working set size seems to map well to RLIMIT_MEMLOCK. However I can't see what the parallel would be for the lower bound. Also RLIMIT_AS could be the limit for how much memory you can MEM_RESERVE. These are process based values. They are available in Linux. Not sure about other platforms. > > * Wine limits MEM_RESERVE to 1GB, but WinXP goes up to 2GB > Wine? Maybe linux, but I doubt wine would do anything like that. Yep, it does. Give it a try. As far as I can tell: int total = 0; for (;;) { LPVOID* leak = ::VirtualAlloc(NULL, 1048576, MEM_RESERVE, PROT_NOACCESS); if (leak) { total += 1048576/1024; printf("Allocated %ldk\r", total); } else { printf("\n"); PrintWindowsError("VirtualAlloc", ::GetLastError(); break; } } will stop at 1,022,976k (1GB) on any wine machine. In winxp it goes up to 2GB, as it ought to. > > Further, these DLLs are audio processing plugins. The apparent fact > that > > VirtualLock doesn't _actually_ lock memory into RAM for real time > I didn't look into the code, but anyway a prerequisite for it would be > to set > windows version to NT/2000/XP. Or at least wine should behave like that, > assuming that MSDN doesn't lie here. > > Apart from that, I bet you didn't raise ulimits for your processes. On > my FC3 > system, ulimit -l gives a meager 32 pages. So that's how many mlock() > could > lock anyway. There's not a problem there. My ulimit -l is "unlimited". BTW we are using an old kernel which required a hack to mlock to allow us to lock more than half the ram (regardless of the ulimit), but that doesn't change any of this behavior. Thanks for your feedback... mo

4 9

Re: [SETUPAPI] fix bug 1140
by Alexandre Julliard March 17, 2005

March 17, 2005

Raphael <fenix(a)club-internet.fr> writes: > patch who correct bug 1140 (http://bugs.winehq.org/show_bug.cgi?id=1140) > htmlhelp install is success :) > > Changelog: > - fix GenFormStrWithoutPlaceHolders16 > ie fix PARSER_string_substW to only keep valid texts entries (no comments > or tabs) This is wrong, comments should have already been taken into account when PARSER_string_substW is called. The right fix is to make GenFormStrWithoutPlaceHolders16 properly split the line like the 32-bit functions do. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: dlls/user/button.c - fix AUTO3STATE with BS_OWNERDRAW
by Tony Lambregts March 17, 2005

March 17, 2005

Michael Lin wrote: > AUTO3STATE control with BS_OWNERDRAW set will not get created. > > ChangeLog: > * fix AUTO3STATE with BS_OWNERDRAW set > > > ------------------------------------------------------------------------ > > Index: dlls/user/button.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/button.c,v > retrieving revision 1.6 > diff -r1.6 button.c > 183c183,186 > < return (window_style & 0x0f); > --- > >> if ((window_style & BS_OWNERDRAW) == BS_OWNERDRAW) >> return BS_OWNERDRAW; >> else >> return (window_style & 0x0f); Patches should be in diff -u format (cvs diff -u) please resubmit.. -- Tony Lambregts

1 0

Re: winetest, winrash and new volunteers
by Steven Edwards March 16, 2005

March 16, 2005

--- Chris Morgan <cmorgan(a)alum.wpi.edu> wrote: > winetest to upload the testing results. The winetest building is black magic > to me :-) Right now I am interested in the winetest side of things. Like how to get winetest and the server to talk to each other and what is needed in the build and url files. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

MSN Webcam patch
by Vladdy Impaler March 16, 2005

March 16, 2005

RIght now I'm working on a patch so I can use my webcam under wine without having to switch to unix or use non-working solutions.. Right now there are 2 patches needed to get MSN to connect to the internet: first is to disable SSL, second strcpy's a value at urlmon getuseragent or something To get this to work, a few modifications to existing files are needed: First of all, if the catagory exists, let devenum return all from videoinput catagory: diff -Nru /root/wine-20050211/dlls/devenum/createdevenum.c wine-20050211/dlls/devenum/createdevenum.c --- /root/wine-20050211/dlls/devenum/createdevenum.c 2005-01-25 11:56:39.000000000 +0100 +++ wine-20050211/dlls/devenum/createdevenum.c 2005-03-15 00:15:47.000000000 +0100 @@ -117,7 +117,8 @@ if (IsEqualGUID(clsidDeviceClass, &CLSID_AudioRendererCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_AudioInputDeviceCategory) || - IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory)) + IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory) || + IsEqualGUID(clsidDeviceClass, &CLSID_VideoInputDeviceCategory)) { hbasekey = HKEY_CURRENT_USER; strcpyW(wszRegKey, wszActiveMovieKey); and a few other patches to devenum main (Not sure if those are needed) diff -Nru /root/wine-20050211/dlls/devenum/devenum_main.c wine-20050211/dlls/devenum/devenum_main.c --- /root/wine-20050211/dlls/devenum/devenum_main.c 2004-12-07 15:37:11.000000000 +0100 +++ wine-20050211/dlls/devenum/devenum_main.c 2005-03-15 00:15:47.000000000 +0100 @@ -122,7 +122,7 @@ {&CLSID_AudioCompressorCategory, acmcat, TRUE}, {&CLSID_VideoCompressorCategory, vidcat, TRUE}, {&CLSID_LegacyAmFilterCategory, filtcat, TRUE}, - {&CLSID_VideoInputDeviceCategory, vfwcat, FALSE}, + {&CLSID_VideoInputDeviceCategory, vfwcat, TRUE}, {&CLSID_AudioInputDeviceCategory, wavein, FALSE}, {&CLSID_AudioRendererCategory, waveout, FALSE}, {&CLSID_MidiRendererCategory, midiout, FALSE}, @@ -156,7 +156,7 @@ pMapper = (IFilterMapper2*)mapvptr; - IFilterMapper2_CreateCategory(pMapper, &CLSID_VideoInputDeviceCategory, MERIT_DO_NOT_USE, friendlyvidcap); + IFilterMapper2_CreateCategory(pMapper, &CLSID_VideoInputDeviceCategory, MERIT_NORMAL, friendlyvidcap); IFilterMapper2_CreateCategory(pMapper, &CLSID_LegacyAmFilterCategory, MERIT_NORMAL, friendlydshow); IFilterMapper2_CreateCategory(pMapper, &CLSID_VideoCompressorCategory, MERIT_DO_NOT_USE, friendlyvidcomp); IFilterMapper2_CreateCategory(pMapper, &CLSID_AudioInputDeviceCategory, MERIT_DO_NOT_USE, friendlyaudcap); I wanted to put all custom code into qcap, but because of the pins that's not possible. I wrote a basic stub for CaptureGraphBuilder and added it and regsvr calls to qcap. There s no current implementation of qcap, so therefore I added my gzipped qcap.tgz as an attachment (To keep things simple) My current implementation of the actual interface was based on filesource.c, so i made some functions and struct defs global in quartz: diff -Nru /root/wine-20050211/dlls/quartz/filesource.c wine-20050211/dlls/quartz/filesource.c --- /root/wine-20050211/dlls/quartz/filesource.c 2005-01-06 20:36:47.000000000 +0100 +++ wine-20050211/dlls/quartz/filesource.c 2005-03-15 00:15:47.000000000 +0100 @@ -663,17 +663,6 @@ FileSource_GetCurFile }; - -/* the dwUserData passed back to user */ -typedef struct DATAREQUEST -{ - IMediaSample * pSample; /* sample passed to us by user */ - DWORD_PTR dwUserData; /* user data passed to us */ - OVERLAPPED ovl; /* our overlapped structure */ - - struct DATAREQUEST * pNext; /* next data request in list */ -} DATAREQUEST; - void queue(DATAREQUEST * pHead, DATAREQUEST * pItem) { DATAREQUEST * pCurrent; diff -Nru /root/wine-20050211/dlls/quartz/quartz_private.h wine-20050211/dlls/quartz/quartz_private.h --- /root/wine-20050211/dlls/quartz/quartz_private.h 2005-02-10 18:13:18.000000000 +0100 +++ wine-20050211/dlls/quartz/quartz_private.h 2005-03-15 00:15:47.000000000 +0100 @@ -52,8 +52,8 @@ HRESULT QUARTZ_CreateSystemClock(IUnknown * pUnkOuter, LPVOID * ppv); HRESULT ACMWrapper_create(IUnknown * pUnkOuter, LPVOID * ppv); HRESULT WAVEParser_create(IUnknown * pUnkOuter, LPVOID * ppv); - HRESULT EnumMonikerImpl_Create(IMoniker ** ppMoniker, ULONG nMonikerCount, IEnumMoniker ** ppEnum); +HRESULT VfwCapture_create(IUnknown * pUnkOuter, LPVOID * ppv); typedef struct tagENUMPINDETAILS { @@ -80,4 +80,14 @@ BOOL CompareMediaTypes(const AM_MEDIA_TYPE * pmt1, const AM_MEDIA_TYPE * pmt2, BOOL bWildcards); void dump_AM_MEDIA_TYPE(const AM_MEDIA_TYPE * pmt); +typedef struct DATAREQUEST +{ + IMediaSample * pSample; /* sample passed to us by user */ + DWORD_PTR dwUserData; /* user data passed to us */ + OVERLAPPED ovl; /* our overlapped structure */ + + struct DATAREQUEST * pNext; /* next data request in list */ +} DATAREQUEST; + +void queue(DATAREQUEST * pHead, DATAREQUEST * pItem); #endif /* __QUARTZ_PRIVATE_INCLUDED__ */ As you can see here, a VfwCapture class is being created to use it, we must register it and qcap with regsvr32 diff -Nru /root/wine-20050211/dlls/quartz/regsvr.c wine-20050211/dlls/quartz/regsvr.c --- /root/wine-20050211/dlls/quartz/regsvr.c 2005-02-10 18:13:18.000000000 +0100 +++ wine-20050211/dlls/quartz/regsvr.c 2005-03-15 00:15:47.000000000 +0100 @@ -922,6 +922,12 @@ "quartz.dll", "Both" }, + { &CLSID_VfwCapture, + "Video for wine capture interface", + NULL, + "quartz.dll", + "Both" + }, { NULL } /* list terminator */ }; @@ -1112,6 +1118,18 @@ { 0xFFFFFFFF }, } }, + { &CLSID_VfwCapture, + &CLSID_VideoInputDeviceCategory, + {'V','i','d','e','o',' ','F','o','r',' ','W','i','n','e',' ','(','V','4','W',')', 0}, + 0x800000, + { { REG_PINFLAG_B_OUTPUT, + { { &MEDIATYPE_Stream, &GUID_NULL }, + { NULL } + }, + }, + { 0xFFFFFFFF }, + } + }, /* This creates a fake device for us with an ugly name */ { NULL } /* list terminator */ }; Also, main.c needs to be informed of a new class: diff -Nru /root/wine-20050211/dlls/quartz/main.c wine-20050211/dlls/quartz/main.c --- /root/wine-20050211/dlls/quartz/main.c 2005-03-14 23:47:05.000000000 +0100 +++ wine-20050211/dlls/quartz/main.c 2005-03-15 00:15:47.000000000 +0100 @@ -71,7 +71,8 @@ { &CLSID_AVIDec, AVIDec_create }, { &CLSID_SystemClock, &QUARTZ_CreateSystemClock }, { &CLSID_ACMWrapper, &ACMWrapper_create }, - { &CLSID_WAVEParser, &WAVEParser_create } + { &CLSID_WAVEParser, &WAVEParser_create }, + { &CLSID_VfwCapture, &VfwCapture_create } }; static HRESULT WINAPI And at last, we need the interface of course: diff -Nru /root/wine-20050211/dlls/quartz/Makefile.in wine-20050211/dlls/quartz/Makefile.in --- /root/wine-20050211/dlls/quartz/Makefile.in 2005-02-10 18:13:18.000000000 +0100 +++ wine-20050211/dlls/quartz/Makefile.in 2005-03-15 00:15:47.000000000 +0100 @@ -28,7 +28,8 @@ systemclock.c \ transform.c \ videorenderer.c \ - waveparser.c + waveparser.c \ + v4wsource.c (v4wsource.c added as attachment) Before you think 'yey i can use a webcam now', I have to warn you, you won't What did is made from figuring out what MSN did at every step, for this to work and keeping it debuggable I ONLY used builtin dlls minimum required overrides in wine config: "quartz" = "builtin";FUCKING WORK!!!! "amstream" = "builtin" "qcap" = "builtin";You go girl..... "ole32" = "builtin";Not really needed, but makes debugging easier Currently this is NOT working, and MSN crashes for a reason I do not understand, Iif you want to help me continue working on webcam support i would greatly appreciate it if you could help me pinpoint the source of the crash.. WINEDEBUG=+quartz,+qcap is recommended.. and for now I'm only Currently the code mostly exists out of ugly hacks, what I was working on before msn crashed were the video formats (IKSPropertySet and IAMStreamConfig capabilities), if someone can help me figure out why and were it crashes, I could continue on my webcam project :=). You could try to get it to work through 'Extra' 'Configure webcam' (Or something like that, since I'm using Dutch version), and it crashes for a reason unknown to me.. PS: I accidentally deleted my first patch file, you need to add IAMStreamConfig and perhaps some other class into the include/*.idl files, I'll release a patch when I'm at least 1% awake again :/

2 1

Clipboard regression
by Ron Jensen March 16, 2005

March 16, 2005

>Hello List, > >This patch from 2005/03/07 causes a Clipboard regression: > >http://www.winehq.org/hypermail/wine-cvs/2005/03/0111.html > >Whenever the clipboard is used the process crashes with an X error. >To reproduce it just start notepad and right click into the text area: This also seems to be the cause of X11 errors I am seeing with IrfanView and Textpad. Both apps fail at startup with an X Error, IrfanView is the simpler case: :~$ WINEDEBUG=clipboard wine C/Program\ Files/IrfanView/i_view32.exe trace:clipboard:X11DRV_CLIPBOARD_InsertClipboardFormat Registering format(49173): L"Rich Text Format" drvData 399 trace:clipboard:X11DRV_CLIPBOARD_InsertClipboardFormat Registering format(49174): L"GIF" drvData 396 trace:clipboard:X11DRV_IsClipboardFormatAvailable (0008) trace:clipboard:X11DRV_EmptyClipboard 0 entries remaining in cache. X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 1 (X_CreateWindow) Serial number of failed request: 208 Current serial number in output stream: 209 The offending function seems to be the calls to X11DRV_CLIPBOARD_QueryTargets() in X11DRV_CLIPBOARD_QueryAvailableData(). X11DRV_IsClipboardFormatAvailable() calls X11DRV_CLIPBOARD_UpdateCache() which calls X11DRV_CLIPBOARD_QueryAvailableData() which calls X11DRV_CLIPBOARD_QueryTargets() which throws the X Error. These apps both work if started in a desktop window. Ron Jensen

3 4

Re: shell32: set %AllUsersProfile%, and fix shell folder registration
by Juan Lang March 16, 2005

March 16, 2005

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > It's not a c:\windows, it's a %10%. setupapi takes care of putting the > right value in there (defaulting to c:\windows if nothing else is > specified). All I see in dirid.c is a call to GetWindowsDirectoryW. That, in turn, checks %windir%. So the windows directory appears to be set on a per-process basis, not on a per-install basis. This doesn't strike me as correct. --Juan __________________________________ Do you Yahoo!? Make Yahoo! your home page http://www.yahoo.com/r/hs

2 1

Re: shell32: set %AllUsersProfile%, and fix shell folder registration
by Juan Lang March 16, 2005

March 16, 2005

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > Not sure what you mean, the windows dir is definitely being set in > wine.inf, and you can use %10% in there to access it. Where? I don't see a c:\windows anywhere in there. The env var stuff in shellpath.c was always a hack though, and I think the registration bug was holding me back from working on it. I'll try to move all the "special" stuff out of it and into wine.inf. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

Re: RICHEDIT: RTF reader improvements and optimizations (synced to current CVS)
by Alexandre Julliard March 16, 2005

March 16, 2005

Krzysztof Foltman <kfoltman(a)portal.onet.pl> writes: > @@ -3721,6 +3723,22 @@ > else > RTFRouteToken(info); /* "\*" is ignored with known destinations */ > break; > + case rtfUnicode: > + { > + WCHAR buf[2]; > + buf[0] = info->rtfParam; The indentation is messed up, it looks like you set your tabs to 2 spaces. You should *never* do that, a tab is 8 spaces. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [bug2796] Richedit bug
by Paul Vriens March 16, 2005

March 16, 2005

On Wed, 2005-03-16 at 18:54, Ann and Jason Edmeades wrote: > Nice bug: > > WCHAR *p = ALLOC_N_OBJ(WCHAR, nLen+1); > #define ALLOC_N_OBJ(type, count) (type *)HeapAlloc(me_heap, 0, > count*sizeof(type)) > > becomes > (WCHAR *)HeapAlloc(me_heap, 0, nLen+1*sizeof(WCHAR)) > > and by precedence rules means we allocate just nLen + 2 bytes rather than 2 > * (nLen+1) > > Changelog > > Correct memory allocation routine > > > Krzysztof - Does this solve the issue in the comment below it, ie the memory > overrun? > > Jason > Hi, this one also fixes a bug with riched20 when trying to install DVD Shrink 3.2.0.15. Thanks, Paul.

1 0

Re: [bug2796] Richedit bug
by Krzysztof Foltman March 16, 2005

March 16, 2005

Ann and Jason Edmeades wrote: > WCHAR *p = ALLOC_N_OBJ(WCHAR, nLen+1); > #define ALLOC_N_OBJ(type, count) (type *)HeapAlloc(me_heap, 0, > count*sizeof(type)) That is so embarrasing! They teach this in the nursery school :/ By coincidence, I've spent at least half an hour today on finding the memory overwrite elsewhere, which turned out to be caused by the bug above. The buffer overrun comment refers to something else - I'm not sure if WideCharToMultiByte will produce single byte character string for ANSI codepages. If it produced a real multibyte string, it could exceed the buffer supplied by the application. Krzysztof

1 0

Re: IP Address control broken
by Rob Shearman March 16, 2005

March 16, 2005

Robert Reif wrote: > Rob Shearman wrote: > >>> Disabling the control does not change it's color. >> It doesn't change colour when disabled on Windows. Of course, this is purely a user interface feature so we could make this a Wine-only extenstion. Rob

2 1

wineboot - Multi-User environment
by Joe Baker March 16, 2005

March 16, 2005

It seems that if user1 is running a wine app and user2 is running a wine app, and user2 wants to perform a wineboot command, wineboot will wait till user1 closes out all wine applications. My observations are based on running winetools as user2 to install software while user1 continues to run a wine application. When it comes time to perform a "Windows Reboot", winetools just hangs there waiting for the wine processes to terminate. I think that wineboot should be modified to only attempt to stop processes owned by the user calling wineboot. -Joe Baker

1 0

winsock conformance tests
by gslink March 16, 2005

March 16, 2005

I have noted for some time that the winsock in Odin, the OS/2 version of Wine, seems to work better than the one in Wine. This might figure in conformance testing and in Wine updates.

1 0

IBM Acknowledges Wine! Offers bounty to port it to PPC64!
by Scott Ritchie March 16, 2005

March 16, 2005

IBM has started a new contest meant to spur open source development on their POWER architecture, http://www.linuxonpower.com/ Prizes are offered for coders that port some common open source applications to the architecture. A Tier 2 prize, a Mac G5, is offered to anyone who can port one of the list of Tier 2 applications. Color me shocked to find Wine and Winelib listed there! This marks a change in IBMs policy towards Wine, or perhaps signals a management oversight. While normally it seems that they have an active policy of censoring any references to Wine and completely denying its existence, here they are offering prizes for porting it to PPC. So, now, I guess, the obvious questions: Does Winelib even need any porting? Does it build on PPC as it is? Can we run notepad and such on Linux/PPC? Does any of the work done on porting to AMD64 help us here? Thanks, Scott Ritchie

5 7

STI, device drivers and stuff
by Damjan Jovanovic March 16, 2005

March 16, 2005

Hi I've started working on implementing STI functionality in Wine. STI is a Windows 98/2000 "Still Image" capture system, and I'm doing it to get my scanner working in Linux. I have a few questions: 1. Do you support/accept/like C++ code in Wine? COM is bad enough in C++, I would rather not do it in C. 2. STI has kernel mode components to deal USB / SCSI / serial / parallel ports. Is there any attempt to bring kernel mode support into Wine (ReactOS/Wine merger?) any time soon? If not, should I implement USB support using libusb in user-space? 3. Either way, changes need to be made to CreateFile(), CloseHandle(), DeviceIoControl(), ReadFile() and WriteFile() to accomodate this. What's the best way to do this? Do I need to change the Wine server, or just Wine's KERNEL32.DLL and/or NT*.DLL equivalents? 4. Anyone wanna help out? Bye Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 4

Re: animate: audit and some fixes
by Tom Wickline March 16, 2005

March 16, 2005

On Wed, 16 Mar 2005 07:45:03 -0500, Dimitrie O. Paun <dpaun(a)rogers.com> wrote: > ChangeLog > Audit the control against Comctl32.dll version 6.0. > Proper handling of GWL_STYLE. > Implement WM_CLOSE. Fix WM_SIZE implementation. > Small cleanups. > > Index: dlls/comctl32/animate.c Hello Dimi, Can you update the http://winehq.org/site/status_ui page or do you want me to? Tom

2 1

SetFocus and DefPushButton management
by Katia Maculan March 16, 2005

March 16, 2005

After the creation of a dialog if the focus is set on a PushButton this one must have also the BS_DEFPUSHBUTTON style like in windows. Attached the patch with a regression test. Katia -- Katia Maculan Developer ISIS Papyrus Italy Srl Tel: (+39) 0125 6455400 Fax: (+39) 0125 6455400 E-mail: katia.maculan(a)isis-papyrus.com Info: info(a)isis-papyrus.com Hotline: +43-2236-27551-111 Visit our Website: http://www.isis-papyrus.com diff -urN oldwinedir/dlls/user/tests/dialog.c newwinedir/dlls/user/tests/dialog.c --- oldwinedir/dlls/user/tests/dialog.c 2005-03-07 12:12:40.000000000 +0100 +++ newwinedir/dlls/user/tests/dialog.c 2005-03-14 16:33:03.000000000 +0100 @@ -849,6 +849,40 @@ } } +static LRESULT CALLBACK DlgFocusProc (HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) +{ + HWND hwndFocusCtrl = NULL; + HWND hwndDefPushButton = NULL; + LRESULT DlgCode; + LRESULT CtrlState; + switch (message) + { + case WM_INITDIALOG: + PostMessage(hDlg, WM_USER, 0, 0); + return TRUE; + + case WM_USER: + // Check if the focus is on IDOK button + CtrlState = SendMessage (GetDlgItem(hDlg, IDOK), BM_GETSTATE, 0, 0); + if (CtrlState == BST_FOCUS) + hwndFocusCtrl = GetDlgItem(hDlg, IDOK); + // Check if IDOK is the default push button + DlgCode = SendMessage (GetDlgItem(hDlg, IDOK), WM_GETDLGCODE, 0, 0); + if (DlgCode & DLGC_DEFPUSHBUTTON) + hwndDefPushButton = GetDlgItem(hDlg, IDOK); + ok (hwndFocusCtrl && hwndDefPushButton, "The focus and the DLGC_DEFPUSHBUTTON style are not in the same button\n"); + EndDialog(hDlg, LOWORD(wParam)); + return TRUE; + } + return FALSE; + +} + +static void InitialFocusTest1 (void) +{ + DialogBox(g_hinst, "DEFPUSHBUTTON_TEST_DIALOG", NULL, (DLGPROC)DlgFocusProc); + +} START_TEST(dialog) { @@ -860,4 +894,5 @@ IsDialogMessageWTest(); WM_NEXTDLGCTLTest(); InitialFocusTest(); + InitialFocusTest1(); } diff -urN oldwinedir/windows/dialog.c newwinedir/windows/dialog.c --- oldwinedir/windows/dialog.c 2005-03-07 12:12:54.000000000 +0100 +++ newwinedir/windows/dialog.c 2005-03-14 16:30:19.000000000 +0100 @@ -669,8 +669,23 @@ { /* By returning TRUE, app has requested a default focus assignment */ dlgInfo->hwndFocus = GetNextDlgTabItem( hwnd, 0, FALSE); - if( dlgInfo->hwndFocus ) - SetFocus( dlgInfo->hwndFocus ); + if (dlgInfo->hwndFocus) + { + SetFocus( dlgInfo->hwndFocus ); + HWND hWndOldDefPushButton = NULL; + if (SendMessageW(dlgInfo->hwndFocus, WM_GETDLGCODE, 0, 0) + & (DLGC_UNDEFPUSHBUTTON | DLGC_BUTTON)) + { + SendMessageA (dlgInfo->hwndFocus, BM_SETSTYLE, BS_DEFPUSHBUTTON, TRUE); + /*Check for a previous defpushbutton*/ + if (dlgInfo->idResult) + { + hWndOldDefPushButton = GetDlgItem (hwnd,dlgInfo->idResult); + if (hWndOldDefPushButton && (hWndOldDefPushButton != dlgInfo->hwndFocus)) + SendMessageA (hWndOldDefPushButton, BM_SETSTYLE, BS_PUSHBUTTON, TRUE); + } + } + } } if (template.style & WS_VISIBLE && !(GetWindowLongW( hwnd, GWL_STYLE ) & WS_VISIBLE))

3 2

wine + winamp: fixme:wave:OSS_AddRingMessage two fast messages in the queue!!!!
by seut March 16, 2005

March 16, 2005

hello, we are using winamp 2.95 with latest wine 0.0.20040914 and are wondering what there is about these 'fixme:wave:OSS_AddRingMessage two fast messages in the queue!!!!' messages dumped out at the console every few seconds... Same happens(but with 'ALSA_AddRingMessages' of course) if we're using the wine alsa-driver. Winamp normally works, but sometimes there is a 15sec pause at the playback, so we are trying to search the problem. I watched the wine source-code, but as my less C knowledge I didn't really understand the part where this 'FIXME' message is implemented. As I understand the code, why somebody added the 'FIXME' message to the code, if the code can handle this problem(two fast messages)? Or can somebody explain me the reason for this 'two fast messages'? thanks a lot seut btw. I'm not a member of the mailing-list, so please send answer to me too! and please don't suggest us to use a native linux-player instead, for some reasons, we have to use winamp..

2 2

Re: Are mailslots implemented?
by Kuba Ober March 16, 2005

March 16, 2005

> |>>Which application uses mailslots? I only ever found one real > |>>application that used them, and that was "Declan's Korean Dictionary" > |>>from [1]. > |> > |>The browse (Network Neighborhood) service uses them. Other then that, > |>I have not seen any uses of it. > | > | Protel 98 (likely higher versions too) uses them. > | > | MSDN says that the datagrams are limited to 424 bytes in length, so > > even if > > | they are not very useful otherwise, getting Protel running on wine > > seems a > > | worthy goal to me. I'll try hacking on it and seeing where I end up. > > See http://www.ubiqx.org/cifs/Browsing.html#BRO.3 for more information > libsmbclient from Samba 3 does not support it at the moment What do the "match_mailslot_name" and "cli_send_mailslot" functions do, then? Anyway, if the wire protocol is simple enough, and so it seems from ubiqx.org article, then I can just synthesize all the relevant layers to send the multicast UDP. The only piece of info that I'll (hopefully) need from wine is the netbios node name. For reception, I'll bind UDP port 138 (netbios-dgm) if it's not already bound, to receive the mailslots coming in. Now, if a samba server is already running on given host, which is reasonable if the person running wine wants to share something with other windows hosts, is it possible to somehow poll the nmbd and/or smbd to get the mailslot datagrams that weren't "consumed" by the browsing protocols? Does that make sense? Any more hints? Cheers, Kuba

7 8

Problem with winebuild
by Robert Lunnon March 16, 2005

March 16, 2005

The following problem is evident under solaris NULL pointer passed to printf I'm not sure if this is a poblem with the spec file or winebuild.... Still it's not good to pass NULL pointers to printf Starting program: /export/home/src/wine2004/wine/tools/winebuild/winebuild -w --def -o amstream/amstream.spec.def --export amstream/amstream.spec Program received signal SIGSEGV, Segmentation fault. 0xd2722a6c in strlen () from /usr/lib/libc.so.1 (gdb) bt #0 0xd2722a6c in strlen () from /usr/lib/libc.so.1 #1 0xd2777d3e in _ndoprnt () from /usr/lib/libc.so.1 #2 0xd277a8b7 in fprintf () from /usr/lib/libc.so.1 #3 0x0805d962 in BuildDef32File (outfile=0x8077078, spec=0x8077630) at spec32.c:848 #4 0x08054819 in main (argc=7, argv=0x80477f4) at main.c:469

3 4

Re: dlls/shell32/shelllink.c
by Mike McCormack March 16, 2005

March 16, 2005

Ge van Geldorp wrote: > I have some shortcuts (created in Windows 2000) which only have 24 bytes of > LOCATION_INFO, i.e. they are missing the dwFinalPathOfs member. > Also lots of shortcuts seem to have another chunk at the end of the stream, > I get a lot of "Last word was not zero" messages. Could you send me a shortcut like that, or even modify winedump (lnk mode) to dump out the right thing in that case? thanks, Mike

2 1

Re: dlls/shell32/shelllink.c (please don't apply)
by Mike McCormack March 16, 2005

March 16, 2005

Ge van Geldorp wrote: > - ERR("Last word was not zero\n"); > + TRACE("Last word was not zero\n"); btw. the right solution is to fix the problem, not ignore it, so I object to this patch being applied as is. Mike

1 0