March 2005 - Wine-Devel - list.winehq.org

Re: combo - implement GetComboBoxInfo
by Steven Edwards March 16, 2005

March 16, 2005

Hi, --- Alexandre Julliard <julliard(a)winehq.org> wrote: > The IsWindow check is useless, what you need is to verify that it's > really a combobox. The right way to do that is probably to send a > CB_GETCOMBOBOXINFO message instead. How about something like this instead? Index: dlls/user/combo.c =================================================================== RCS file: /home/wine/wine/dlls/user/combo.c,v retrieving revision 1.8 diff -u -r1.8 combo.c --- dlls/user/combo.c 23 Dec 2004 17:21:05 -0000 1.8 +++ dlls/user/combo.c 15 Mar 2005 19:09:52 -0000 @@ -27,7 +27,6 @@ * If you discover missing features, or bugs, please note them below. * * TODO: - * - GetComboBoxInfo() * - ComboBox_[GS]etMinVisible() * - CB_GETCOMBOBOXINFO * - CB_GETMINVISIBLE, CB_SETMINVISIBLE @@ -2293,10 +2292,27 @@ /************************************************************************* * GetComboBoxInfo (USER32.@) */ -BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ - PCOMBOBOXINFO pcbi /* [in/out] combo box information */) -{ - FIXME("\n"); - return FALSE; - +BOOL WINAPI +GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ + PCOMBOBOXINFO pcbi /* [in/out] combo box information */) +{ + static const WCHAR ComboBoxW[] = { 'C', 'o', 'm', 'b', 'o', 'B', 'o', 'x', 0 }; + CHAR szBuffer[MAX_PATH + 1]; + int dwSize; + LPHEADCOMBO lphc; + + dwSize = GetClassNameW(hwndCombo, szBuffer, sizeof(szBuffer)/sizeof(szBuffer[0])-1); + + if (lstrcmpiW(szBuffer, ComboBoxW) != 0) + return FALSE; + + lphc = (LPHEADCOMBO)GetWindowLongPtrW( hwndCombo, 0 ); + + pcbi->hwndCombo = hwndCombo; + pcbi->hwndList = lphc->hWndLBox; + pcbi->hwndItem = lphc->hWndEdit; + pcbi->rcItem = lphc->textRect; + pcbi->rcButton = lphc->buttonRect; + pcbi->stateButton = lphc->wState; + return TRUE; } __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

5 5

Debugging idiosyncrasy
by Paul Millar March 16, 2005

March 16, 2005

Hi, Something I've noticed whilst playing with winedbg (and its auto mode). If there's no AeDebug key in the registry, then the default is to run the debugger in non-interactive mode: paul(a)scaramanga:~/CVS/wine$ grep cmdline.*winedbg dlls/kernel/except.c sprintf(cmdline, "winedbg --auto %ld %ld", Yet, if there's no registry at all, then the default registry values are configured to run the debugger in interactive mode: paul(a)scaramanga:~/CVS/wine$ grep AeDebug.*Debugger tools/wine.inf HKLM,Software\Microsoft\Windows NT\CurrentVersion\AeDebug,"Debugger",,"winedbg %ld %ld" I think we should be consistent here, no? Cheers, Paul

1 0

Got message form ./configure to send this e-mail
by Lauris Misa March 16, 2005

March 16, 2005

Hello! I'm trying to compile wine on my AMD64 system and I got this message on STDERR: configure: WARNING: valgrind/memcheck.h: present but cannot be compiled configure: WARNING: valgrind/memcheck.h: check for missing prerequisite headers? configure: WARNING: valgrind/memcheck.h: see the Autoconf documentation configure: WARNING: valgrind/memcheck.h: section "Present But Cannot Be Compiled" configure: WARNING: valgrind/memcheck.h: proceeding with the preprocessor's result configure: WARNING: valgrind/memcheck.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## and of course it crashes when I run make depend.;( Is there some way to get wine compiled? Thank You! Lauris >LMP< -- For people who like peace and quiet: a phoneless cord.

1 0

Re: shell32: set %AllUsersProfile%, and fix shell folder registration
by Juan Lang March 16, 2005

March 16, 2005

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > > ChangeLog: > > - %AllUsersProfile% was not getting set in the environment, spotted by > > Vitaly Lipatov > > This should be done in wine.inf, not in the code. Okay, but it's a subdirectory of the windows directory, and that's no longer getting set in wine.inf either. I rely on GetWindowsDirectory to find it. If you want it back here though I'll move it. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

2 1

Wine's Documentation in French
by Francois Gouget March 16, 2005

March 16, 2005

The Wine documentation has been translated to French by students from the Insa of Rouen. The credits for the translation go to: * Wine User Guide Romain CONSEIL Damien GIRAUDEAU Guillaume LEFEBVRE Yvon BENOIST (proofreading) http://fgouget.free.fr/wine/wine-user.html * Wine FAQ Romuald VIEUX Yvon BENOIST (proofreading) http://fgouget.free.fr/wine/wine-faq.html * WineLib User Guide José CARRENO Yvon BENOIST (proofreading) http://fgouget.free.fr/wine/winelib-user.html And believe me, this is a lot of work so they really deserve our kudos. You probably noticed that the Wine Developer's Guide was not translated but that makes sense: if you want to work on Wine it's really best if you speak English anyway. So what's needed now is to integrate the translation with Wine. This is what I have done by converting the translation to .po format to make it easier to maintain and tweaking the Makefiles accordingly. The patch is pretty big (even compressed it's more than 200KB) so I did not attach it to this email. Instead I have set up a page on my web site and you can the patch using this URL: http://fgouget.free.fr/wine/docfr.diff.gz Here is what the patch does: Add a Makedoc.rules.in file which handles the conversion of SGML files to the final documentation format. Modify documentation/Makefile.in to use Makedoc.rules.in. Add documentation/fr with the po files of the French translation. Use po4a to generate a translated Sgml file from the original sgml documentation and then let Makedoc.rules.in generate the documentation. Detect po4a in configure.ac. The translation appears to have been made from a snapshot of the documentation taken in the summer of 2004. Now, a bit more than 6 months later, the translation is still more than 90% complete. IMHO this proves that maintaining the translation is quite feasible. If you see any bits of English in the documents above, this is precisely because the translation is not 100% complete anymore: in that case po4a-translate keeps the original version rather than use the outdated translation. For more information about po4a: http://po4a.alioth.debian.org/ I will upload anything new to the following page: http://fgouget.free.fr/wine/docfr.shtml Now you pretty much know everything. Let me know if you have concerns, suggestions, etc. I'm hoping we can get this in place soon. -- Francois Gouget fgouget(a)codeweavers.com

2 2

Re: SHELL32: add defines for SLDF flags
by Dmitry Timoshkov March 16, 2005

March 16, 2005

"Mike McCormack" <mike(a)codeweavers.com> wrote: > +typedef struct { > + DWORD cbSize; > + DWORD cbSignature; > + CHAR szTarget[MAX_PATH]; > + WCHAR szwTarget[MAX_PATH]; > +} EXP_SZ_LINK, EXP_SZ_LINK_SIG; It's for sure a typo: EXP_SZ_LINK_SIG was supposed to be *LPEXP_SZ_LINK. -- Dmitry.

1 0

Regression (SimCity 3000 is Broke )
by Tony Lambregts March 16, 2005

March 16, 2005

After working prefectly for over 2 years SimCity 3000 is broken. The patch that broke it is http://www.winehq.org/hypermail/wine-cvs/2005/03/0098.html basicly the problem is simple. The source and the destination are both the same surface in DIB_DirectDrawSurface_Blt() and with the new locking in place the destination never gets updated. So althought it might fix Picasa2 it is definatly not correct. -- Tony Lambregts

5 12

Re: flexible-mmap breaks application
by Michael Ost March 16, 2005

March 16, 2005

On Tue, 2005-03-15 at 15:55, Uwe Bonnes (bon_at_elektron.ikp.physik.tu-darmstadt.de) wrote: > The definition of the task is clear: > Have a way to tell the kernel to not mmap memory above 0x7fffffff > However the implementation is unclear to me: > - Should this be a new syscall? > - Or should we set some kernel parameter? Per task or global? There is a related problem in that Wine's VirtualAlloc won't allocate the full 2GB it should. As I understand it the problem is the different memory ranges that linux and windows allocate from --- the intersection of the two platforms is only 1GB (not the 2GB it should be) from 0x4000,0000 to 0x8000,0000. Could this patch also include a lower limit, letting linux mmap from addresses in the same range that win32 does? - mo PS: the thread on this issue starts at http://www.winehq.com/hypermail/wine-devel/2005/03/0643.html. It also covers the issue of Wine's lack of mlock/munlock functionality.

1 0

winsock conformance test - added tests for sendto, recvfrom, and getservbyname
by Thomas Kho March 16, 2005

March 16, 2005

Hi, We're working to add conformance tests to winsock, and we've currently added tests for sendto, recvfrom, and getservbyname. Before we post to wine-patches, we'd appreciate any critiques/input. We chose these previously untested functions to test for the following reasons: - UDP is often used and was not previously tested - getservbyname uses the same critical section code as the other database functions; we thought it would be useful to stress tests this. We ran gcov to see how much of dlls/winsock/socket.c we tested, and found: Before: 41.16% of file dlls/winsock/socket.c After: 46.38% of file dlls/winsock/socket.c http://hkn.icsl.ucla.edu/~tom/socket_c_2.gcov.txt We'd also appreciate other targets to test. Thanks for your help, Thomas Kho Files available at: http://www.geekymedia.com/viewcvs/cgi/viewcvs.cgi/wine4/wine/dlls/winsock/t… Changelog: * dlls/winsock/tests/sock.c added tests for sendto, recvfrom, and getservbyname # Signed-off-by: Thomas Kho <tkho(a)ucla.edu> # --- wine_cvs/dlls/winsock/tests/sock.c 2005-03-15 07:49:01.000000000 -0800 +++ wine_build/dlls/winsock/tests/sock.c 2005-03-15 15:14:52.000000000 -0800 @@ -37,6 +37,14 @@ #define TEST_TIMEOUT 30 /* seconds to wait before killing child threads after server initialization, if something hangs */ +#define NUM_UDP_PEERS 3 /* Number of UDP sockets to create and test > 1 */ + +#define NUM_THREADS 3 /* Number of threads to run getservbyname */ +#define NUM_QUERIES 250 /* Number of getservbyname queries per thread */ + +#define SERVERIP "127.0.0.1" /* IP to bind to */ +#define SERVERPORT 9374 /* Port number to bind to */ + #define wsa_ok(op, cond, msg) \ do { \ int tmp, err = 0; \ @@ -862,8 +870,8 @@ #define STD_STREAM_SOCKET \ SOCK_STREAM, \ 0, \ - "127.0.0.1", \ - 9374 + SERVERIP, \ + SERVERPORT static test_setup tests [NUM_TESTS] = { @@ -932,6 +940,105 @@ } }; +static void test_UDP() +{ + /* This function tests UDP sendto() and recvfrom(). UDP is unreliable, so it is + possible that this test fails due to dropped packets. */ + + /* peer 0 receives data from all other peers */ + struct sock_info peer[NUM_UDP_PEERS]; + char buf[16]; + int ss, i, n_recv, n_sent; + + for ( i = NUM_UDP_PEERS - 1; i >= 0; i-- ) { + ok ( ( peer[i].s = socket ( AF_INET, SOCK_DGRAM, 0 ) ) != INVALID_SOCKET, "UDP: socket failed\n" ); + + peer[i].addr.sin_family = AF_INET; + peer[i].addr.sin_addr.s_addr = inet_addr ( SERVERIP ); + + if ( i == 0 ) { + peer[i].addr.sin_port = htons ( SERVERPORT ); + } else { + peer[i].addr.sin_port = htons ( 0 ); + } + + do_bind ( peer[i].s, (struct sockaddr *) &peer[i].addr, sizeof( peer[i].addr ) ); + + /* test getsockname() to get peer's port */ + ss = sizeof ( peer[i].addr ); + ok ( getsockname ( peer[i].s, (struct sockaddr *) &peer[i].addr, &ss ) != SOCKET_ERROR, "UDP: could not getsockname()\n" ); + ok ( peer[i].addr.sin_port != htons ( 0 ), "UDP: bind() did not associate port\n" ); + } + + /* test getsockname() */ + ok ( peer[0].addr.sin_port == htons ( SERVERPORT ), "UDP: getsockname returned incorrect peer port\n" ); + + for ( i = 1; i < NUM_UDP_PEERS; i++ ) { + /* send client's ip */ + memcpy( buf, &peer[i].addr.sin_port, sizeof(peer[i].addr.sin_port) ); + n_sent = sendto ( peer[i].s, buf, sizeof(buf), 0, (struct sockaddr*) &peer[0].addr, sizeof(peer[0].addr) ); + ok ( n_sent == sizeof(buf), "UDP: sendto() sent wrong amount of data or socket error: %d\n", n_sent ); + } + + for ( i = 1; i < NUM_UDP_PEERS; i++ ) { + n_recv = recvfrom ( peer[0].s, buf, sizeof(buf), 0,(struct sockaddr *) &peer[0].peer, &ss ); + ok ( n_recv == sizeof(buf), "UDP: recvfrom() received wrong amount of data or socket error: %d\n", n_recv ); + ok ( memcmp ( &peer[0].peer.sin_port, buf, sizeof(peer[0].addr.sin_port) ) == 0, "UDP: port numbers do not match\n" ); + } +} + +static void WINAPI do_getservbyname( HANDLE *starttest ) +{ + struct { + char *name; + char *proto; + int port; + } serv[2] = { {"domain", "udp", 53}, {"telnet", "tcp", 23} }; + + int i, j; + struct servent *pserv[2]; + + ok ( WaitForSingleObject ( *starttest, TEST_TIMEOUT * 1000 ) != WAIT_TIMEOUT, "test_getservbyname: timeout waiting for start signal\n"); + + // ensure that necessary buffer resizes are completed + for ( j = 0; j < 2; j++) { + pserv[j] = getservbyname ( serv[j].name, serv[j].proto ); + } + + for ( i = 0; i < NUM_QUERIES / 2; i++ ) { + for ( j = 0; j < 2; j++ ) { + pserv[j] = getservbyname ( serv[j].name, serv[j].proto ); + ok ( pserv[j] != NULL, "getservbyname could not retreive information for %s: %d\n", serv[j].name, WSAGetLastError() ); + ok ( pserv[j]->s_port == htons(serv[j].port), "getservbyname returned the wrong port for %s: %d\n", serv[j].name, ntohs(pserv[j]->s_port) ); + ok ( !strcmp ( pserv[j]->s_proto, serv[j].proto ), "getservbyname returned the wrong protocol for %s: %s\n", serv[j].name, pserv[j]->s_proto ); + ok ( !strcmp ( pserv[j]->s_name, serv[j].name ), "getservbyname returned the wrong name for %s: %s\n", serv[j].name, pserv[j]->s_name ); + } + + ok ( pserv[0] == pserv[1], "getservbyname: winsock resized servent buffer when not necessary\n" ); + } +} + +static void test_getservbyname() +{ + int i; + HANDLE starttest, thread[NUM_THREADS]; + DWORD thread_id[NUM_THREADS]; + + starttest = CreateEvent ( NULL, 1, 0, "test_getservbyname_starttest" ); + + /* create threads */ + for ( i = 0; i < NUM_THREADS; i++ ) { + thread[i] = CreateThread ( NULL, 0, (LPTHREAD_START_ROUTINE) &do_getservbyname, &starttest, 0, &thread_id[i] ); + } + + /* signal threads to start */ + SetEvent ( starttest ); + + for ( i = 0; i < NUM_THREADS; i++) { + WaitForSingleObject ( thread[i], TEST_TIMEOUT * 1000 ); + } +} + static void test_WSAAddressToStringA() { INT ret; @@ -1191,6 +1298,10 @@ trace ( " **** TEST %d COMPLETE **** \n", i ); } + test_UDP(); + + test_getservbyname(); + test_WSAAddressToStringA(); test_WSAAddressToStringW();

1 0

World Of Warcraft
by cyrix12＠cox.net March 15, 2005

March 15, 2005

Hi, I'm the maintainer for World of Warcraft, and I've noticed a few things which have been pointed out before (on irc, bugzilla, mailing list) but have not really gotten any attention. As this is one of the most popular, if not THE most popular pc game at the moment, it seems as though it would be worthwhile to look into getting this to work if it does not require a complete rewrite of wine to do so. There are currently two things preventing operation of the game. Firstly, I'll start off by saying that there are two separate modes to run the game in. d3d9, and opengl. The d3d9 mode doesn't currently work since the support for this dll is not complete. I have been following it closely though, and I constantly find myself impressed with the amount of work being poured into it lately. It's really coming along, and I've even gotten it to run a few demos. Unfortunately, even with the latest patches it still comes up with a blank screen. I don't want to rush anything in this department since I know there's a massive transition from the d3d* architecture to wine3d, and I think it's a really great idea to funnel everything through opengl and only need one rendering library. It's hard for me to say as a WoW addict myself, but I would rather have a complete implementation of d3d9 than one that is only able to play WoW. So I guess what I'd like to say on this front is this: awesome work guys! As for the opengl mode, it crashes strangely just after the character loading screen, but before actually getting into the game. I'm not really sure exactly what is causing the crash. I've run several traces, and all that comes up is a large group of fixmes which look like this: fixme:thread:GetThreadTimes Cannot get kerneltime or usertime of other threads fixme:thread:NtQueryInformationThread info class 9 not supported yet The error I am able to get (when I change my winver to win2k) is an actual game error (not given by wine). This one looks like this: ERROR #0 (0x85100000) Program: C:\Program Files\World of Warcraft\WoW.exe File: C:\build\buildWoW\WoW\Source\Ui\MinimapFrame.cpp Line: 1287 Expr: !("CGMinimapFrame::Initialize(): can't get render target for minimap") I posted a bug about this on December 7, 2004 at this location: http://bugs.winehq.org/show_bug.cgi?id=2603 Nothing has happened yet with this bug except for someone else confirming it. I'd appreciate it if someone could give me one of two pieces of information (both would be spectacular!): 1) What exactly is causing the problem with the opengl version, and is it easy to fix? 2) Is there any sort of goal that the people working on d3d9 dlls have set as far as a date they would like to have it done by? Or is it just one of those "It will be done when it's done" sort of things? Thanks in advance, Darckness -- Stop searching forever. Happiness is unattainable.

14 57

Re: combo - implement GetComboBoxInfo
by Alexandre Julliard March 15, 2005

March 15, 2005

Steven Edwards <steven_ed4153(a)yahoo.com> writes: > @@ -2296,7 +2295,18 @@ > BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ > PCOMBOBOXINFO pcbi /* [in/out] combo box information */) > { > - FIXME("\n"); > - return FALSE; > + if (IsWindow(hwndCombo)) > + { > + LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongPtrW( hwndCombo, 0 ); The IsWindow check is useless, what you need is to verify that it's really a combobox. The right way to do that is probably to send a CB_GETCOMBOBOXINFO message instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Clipboard regression
by Stefan Dösinger March 15, 2005

March 15, 2005

Hello List, This patch from 2005/03/07 causes a Clipboard regression: http://www.winehq.org/hypermail/wine-cvs/2005/03/0111.html Whenever the clipboard is used the process crashes with an X error. To reproduce it just start notepad and right click into the text area: err:x11drv:error_handler X protocol error: serial=271, request_code=1 - breaking into debugger wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 In 32 bit mode. 0x4034e014 DebugBreak+0x4 [/windows/c/wine/dlls/kernel/debugger.c:307] in kernel32: popl %ebp Unable to open file '/windows/c/wine/dlls/kernel/debugger.c' Wine-dbg>bt Backtrace: =>1 0x4034e014 DebugBreak [/windows/c/wine/dlls/kernel/debugger.c:307] in kernel32 (0x4075f5f0) 2 0x40e46f38 error_handler(display=0x780c6938, error_evt=0x4075f654) [x11drv_main.c:194] in x11drv (0x4075f61c) 3 0x40ee33a4 ?? in libx11.so.6 (0x4075f6cc) 4 0x40ee18c3 ?? in libx11.so.6 (0x4075f70c) 5 0x40edc9f4 ?? in libx11.so.6 (0x4075f74c) 6 0x40edcab5 ?? in libx11.so.6 (0x4075f76c) 7 0x40edf0db ?? in libx11.so.6 (0x4075f79c) 8 0x40e11a0f thread_selection_wnd [/windows/c/sonstiges/wine/dlls/x11drv/x11drv.h:521] in x11drv (0x4075f7e0) 9 0x40e14185 X11DRV_CLIPBOARD_QueryAvailableData+0x55(lpcbinfo=0x4075f8e8) [/windows/c/sonstiges/wine/dlls/x11drv/clipboard.c:1636] in x11drv (0x4075f8a4) 10 0x40e12800 X11DRV_CLIPBOARD_UpdateCache(lpcbinfo=0x4075f8e8) [/windows/c/sonstiges/wine/dlls/x11drv/clipboard.c:801] in x11drv (0x4075f8c8) 11 0x40e15935 X11DRV_IsClipboardFormatAvailable+0x35(wFormat=0xd) [/windows/c/sonstiges/wine/dlls/x11drv/clipboard.c:2312] in x11drv (0x4075f914) 12 0x40a21bac IsClipboardFormatAvailable(wFormat=0xd) [/windows/c/sonstiges/wine/dlls/user/../../windows/clipboard.c:614] in user32 (0x4075f940) 13 0x40a6de38 EDIT_WM_ContextMenu+0x138(es=0x4023d968, x=0x2fb, y=0x17d) [/windows/c/sonstiges/wine/dlls/user/edit.c:3900] in user32 (0x4075f97c) 14 0x40a6660c EditWndProc_common+0x3fc(hwnd=0x10024, msg=0x7b, wParam=0x10024, lParam=0x17d02fb, unicode=0x1) [/windows/c/sonstiges/wine/dlls/user/edit.c:835] in user32 (0x4075f9f8) 15 0x40a6759f EditWndProcW(hWnd=0x10024, uMsg=0x7b, wParam=0x10024, lParam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/edit.c:1008] in user32 (0x4075fa14) 16 0x40a4b71f WINPROC_wrapper+0x17 in user32 (0x4075fa38) 17 0x40a4ba8d WINPROC_CallWndProc+0x7d(proc=0x40a67570, hwnd=0x10024, msg=0x7b, wParam=0x10024, lParam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4075fa74) 18 0x40a52b43 CallWindowProcW+0x103(func=0x40a67570, hwnd=0x10024, msg=0x7b, wParam=0x10024, lParam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:3283] in user32 (0x4075faa8) 19 0x40a8bb80 call_window_proc+0xe0(hwnd=0x10024, msg=0x7b, wparam=0x10024, lparam=0x17d02fb, unicode=0x1, same_thread=0x1) [/windows/c/sonstiges/wine/dlls/user/message.c:1518] in user32 (0x4075fb04) 20 0x40a8d9d1 SendMessageTimeoutW+0x161(hwnd=0x10024, msg=0x7b, wparam=0x10024, lparam=0x17d02fb, flags=0x0, timeout=0xffffffff, res_ptr=0x4075fb8c) [/windows/c/sonstiges/wine/dlls/user/message.c:2346] in user32 (0x4075fb68) 21 0x40a8dca1 SendMessageW+0x51(hwnd=0x10024, msg=0x7b, wparam=0x10024, lparam=0x17d02fb) [/windows/c/sonstiges/wine/dlls/user/message.c:2427] in user32 (0x4075fb94) 22 0x40a29ef6 DEFWND_DefWinProc+0x6a6(hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/defwnd.c:696]in user32 (0x4075fc38) 23 0x40a2acbd DefWindowProcW+0x9d(hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/defwnd.c:946] in user32 (0x4075fc68) 24 0x40a66f64 EditWndProc_common+0xd54(hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4, unicode=0x1) [/windows/c/sonstiges/wine/dlls/user/edit.c:405] in user32 (0x4075fce4) 25 0x40a6759f EditWndProcW(hWnd=0x10024, uMsg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/edit.c:1008] in user32 (0x4075fd00) 26 0x40a4b71f WINPROC_wrapper+0x17 in user32 (0x4075fd24) 27 0x40a4ba8d WINPROC_CallWndProc+0x7d(proc=0x40a67570, hwnd=0x10024, msg=0x205, wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4075fd60) 28 0x40a52b43 CallWindowProcW+0x103(func=0x40b006e8, hwnd=0x10024, msg=0x205,wParam=0x0, lParam=0x14c02f4) [/windows/c/sonstiges/wine/dlls/user/../../windows/winproc.c:3283] in user32 (0x4075fd94) 29 0x40a8f078 DispatchMessageW+0xe8(msg=0x4075fe64) [/windows/c/sonstiges/wine/dlls/user/message.c:2992] in user32 (0x4075fdc8) 30 0x40648c70 WinMain+0x2e0(hInstance=0x40640000, prev=0x0, cmdline=0x4020141b, show=0x1) [main.c:357] in notepad (0x4075fe90) 31 0x40646403 __wine_exe_main+0x13b in notepad (0x4075ff20) 32 0x4037d262 start_process+0xf2(arg=0x0) [/windows/c/sonstiges/wine/dlls/kernel/process.c:1047] in kernel32 (0x4075fff4) 33 0x4001ffa1 ?? +0x11 in libwine.so.1 (0x00000000) Wine-dbg>

1 0

Re: shell32: set %AllUsersProfile%, and fix shell folder registration
by Alexandre Julliard March 15, 2005

March 15, 2005

Juan Lang <juan_lang(a)yahoo.com> writes: > ChangeLog: > - %AllUsersProfile% was not getting set in the environment, spotted by > Vitaly Lipatov This should be done in wine.inf, not in the code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: make_ctests - convert make_ctests to C
by Steven Edwards March 15, 2005

March 15, 2005

Hi, --- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > That one contains DOS line endings (^M). I have asked Royce to make a version that creates the testlist.c file with Unix line endings by default and provides a command line option for dos line endings for people developing on Windows. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

[badpenguin79@hotmail.com: [Full-disclosure] [ZH2005-02SA] Insecure tmp file creation in Wine]
by Marcus Meissner March 15, 2005

March 15, 2005

Hi, >From full-disclosure, a security mailing list. Fix seems trivial, just use 0600. (untested, uncompiled ;) Ciao, Marcus Changelog: Temporary registries exported only user read/writeable to avoid information leaks. Index: server/registry.c =================================================================== RCS file: /home/wine/wine/server/registry.c,v retrieving revision 1.63 diff -u -r1.63 registry.c --- server/registry.c 10 Mar 2005 11:18:31 -0000 1.63 +++ server/registry.c 14 Mar 2005 16:38:54 -0000 @@ -1610,7 +1610,7 @@ for (;;) { sprintf( p, "reg%lx%04x.tmp", (long) getpid(), count++ ); - if ((fd = open( tmp, O_CREAT | O_EXCL | O_WRONLY, 0666 )) != -1) break; + if ((fd = open( tmp, O_CREAT | O_EXCL | O_WRONLY, 0600 )) != -1) break; if (errno != EEXIST) goto done; close( fd ); } Index: misc/registry.c =================================================================== RCS file: /home/wine/wine/misc/registry.c,v retrieving revision 1.149 diff -u -r1.149 registry.c --- misc/registry.c 25 Aug 2004 00:48:47 -0000 1.149 +++ misc/registry.c 14 Mar 2005 16:38:55 -0000 @@ -1227,7 +1227,7 @@ ret = _xmalloc(50); for (count = 0;;) { sprintf(ret,"/tmp/reg%lx%04x.tmp",(long)getpid(),count++); - if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0666)) != -1) break; + if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0600)) != -1) break; if (errno != EEXIST) { ERR("Unexpected error while open() call: %s\n",strerror(errno)); free(ret);

3 4

Re: dinput.diff
by Alexandre Julliard March 15, 2005

March 15, 2005

Tom Wickline <twickline(a)gmail.com> writes: > Changelog: increase the maximum number of devices to 16 Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Are mailslots implemented?
by Kuba Ober March 15, 2005

March 15, 2005

Hi, Is the one-way mailslot IPC implemented in wine? I'm getting fixme:sync:CreateMailslotW(...): stub messages. Is this a simple thing to implement, or would it require additions to the server protocol? Thanks, Kuba Ober

4 5

Re: make_ctests - convert make_ctests to C
by Andreas Mohr March 15, 2005

March 15, 2005

Hi, On Mon, Mar 14, 2005 at 08:35:19PM -0800, Steven Edwards wrote: > Convert make_ctests script to C That one contains DOS line endings (^M). Andreas Mohr

1 0

Re: [DSOUND] little patch
by Robert Reif March 15, 2005

March 15, 2005

Raphael wrote: >Hi > >Changelog: > - try to have better match caps with hw caps so games can active more hw >support > >Regards, >Raphael > > > >- This->lock.DebugInfo->Spare[1] = 0; >+ /*This->lock.DebugInfo->Spare[1] = 0;*/ > DeleteCriticalSection(&(This->lock)); > > You have to zero this out or DeleteCriticalSection will try to delete that static memory. >+ if (pDS->drvcaps.dwFlags | DSCAPS_PRIMARYMONO) pDS->pwfx->nChannels = 1; >+ if (pDS->drvcaps.dwFlags | DSCAPS_PRIMARY16BIT) pDS->pwfx->wBitsPerSample = 16; >+ pDS->pwfx->nBlockAlign = pDS->pwfx->wBitsPerSample * pDS->pwfx->nChannels / 8; >+ pDS->pwfx->nAvgBytesPerSec = pDS->pwfx->nSamplesPerSec * pDS->pwfx->nBlockAlign; >+ > You can't do this and be compatible with windows. > >+#ifndef __WINE_DSOUND_PRIVATE_H >+#define __WINE_DSOUND_PRIVATE_H > You can't include this more than once because there is only one .h file so it's not really necessary. >+#define WINE_SET_CS_NAME(cs, name) (cs)->DebugInfo->Spare[1] = (DWORD) name >+#define WINE_GET_CS_NAME(cs) (const char*) (cs)->lock.DebugInfo->Spare[1] > > This is a wine specific trick and should probably be put somewhere global so all users can be consistent. The name should have DEBUG in it somewhere.

3 5

Re: wine/ misc/registry.c documentation/samples/co ...
by Dimitrie O. Paun March 15, 2005

March 15, 2005

On Mon, Mar 14, 2005 at 11:18:40AM -0600, Alexandre Julliard wrote: > Log message: > Get rid of the remaining registry configuration parameters. Any plans on getting the global registry back? -- Dimi.

2 1

Problems with VirtualAlloc/Lock
by MIchael Ost March 15, 2005

March 15, 2005

There are major differences in the handling of virtual memory in Wine vs WinXP that are causing problems for my winelib application. Can someone provide background and/or workarounds for these issues? As near as I can tell the main differences are: * VirtualLock does nothing in Wine * Wine makes no distinction between MEM_RESERVE and MEM_COMMIT * Wine has no implementation of Windows' process working sets * Wine limits MEM_RESERVE to 1GB, but WinXP goes up to 2GB The above problems seem relatively harmless on systems with < 1GB RAM. But when our units go greater than 1GB we are seeing spectacular crash-and-burn failures. The code-only DLLs we are running on such systems are crashing at a stage when I suspect they are attempting to lock RAM. I suspect that they are confused by the report from GlobalMemoryStatus that more than 1GB of RAM is installed, but that they are only able to VirtualLock up to 1GB. And in this unexpected situation, they are crashing. Further, these DLLs are audio processing plugins. The apparent fact that VirtualLock doesn't _actually_ lock memory into RAM for real time processing is a disaster for our system, in that it causes audio glitches when a page fault is handled. But that is not a problem which crashes the system. Any suggestions on what to do? Is there any pending work on this area out there? I've attached a little table that describes what I found. It shows the differences in how Wine and WinXP handle memory related calls. I have also attached a simple program which can be run to see these differences. Thanks for any help... mo

4 4

Re: combo - implement GetComboBoxInfo
by Dimitrie O. Paun March 15, 2005

March 15, 2005

On Mon, Mar 14, 2005 at 08:02:00PM -0800, Steven Edwards wrote: > - FIXME("\n"); > - return FALSE; > + LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongA( hwndCombo, 0 ); Please use GetWindowLongW(), the combo box is fully Unicode. > + pcbi->hwndCombo = hwndCombo; > + pcbi->hwndList = lphc->hWndLBox; > + pcbi->hwndItem = lphc->hWndEdit; > + pcbi->rcItem = lphc->textRect; > + pcbi->rcButton = lphc->buttonRect; > + pcbi->stateButton = (DWORD) lphc->wState; Fancy formatting... Bit yucky, no? -- Dimi.

2 1

Re: combo - implement GetComboBoxInfo
by Dmitry Timoshkov March 15, 2005

March 15, 2005

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box */ > PCOMBOBOXINFO pcbi /* [in/out] combo box information */) > { > - FIXME("\n"); > - return FALSE; > + LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongA( hwndCombo, 0 ); > + > + pcbi->hwndCombo = hwndCombo; > + pcbi->hwndList = lphc->hWndLBox; > + pcbi->hwndItem = lphc->hWndEdit; > + pcbi->rcItem = lphc->textRect; > + pcbi->rcButton = lphc->buttonRect; > + pcbi->stateButton = (DWORD) lphc->wState; > > + return TRUE; > } Is it possible to do a check for lphc being NULL and keep indentation/spacing similar to the rest of the file? Also (DWORD) cast should not be needed. -- Dmitry.

1 0

Re: combo - implement GetComboBoxInfo
by Steven Edwards March 15, 2005

March 15, 2005

--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > Please use GetWindowLongW(), the combo box is fully Unicode. OK I will hack it for him. This guy is new to C programing and I should have caught that. He has a bunch of VB apps that he uses this function in. > > + pcbi->hwndCombo = hwndCombo; > > + pcbi->hwndList = lphc->hWndLBox; > > + pcbi->hwndItem = lphc->hWndEdit; > > + pcbi->rcItem = lphc->textRect; > > + pcbi->rcButton = lphc->buttonRect; > > + pcbi->stateButton = (DWORD) lphc->wState; > > Fancy formatting... Bit yucky, no? Argh. Welcome to the Visual Studio 2005 Beta1, It even fscks your formatting in all sorta nice new ways. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: MSN Webcam patch
by Jasper van Veghel March 15, 2005

March 15, 2005

I have to be off somewhere in a few minutes (hence me being up this early), so I'll make this quick ;-) I wrote a couple of patches for webcam support too a while back, and gave these to some people who were asking for them, so I thought I'd share them here now, to also provide some input on it - mind you that I haven't worked on this for a while now, so it's not really as fresh in my memory anymore, but with this rece- nt interest in it I guess I'll start looking into it again too. Of course MSN still crashes after it's signed in .. but that's beside the point here, really now ;-) Would be nice to get the webcam preview stuff working tho, and make some headway with V4L and Wine along the way. Some of the things that you've changed I've changed, but aren't in the patches below - I really should document what I change as I go along ;-) Most of the major changes are there though. I also got stuck at qcap, but ended up simply using a native DLL for that. Again, I was really just tinkering along, seeing how far I could go without having to implement some major interface, using both native and builtin DLLs. Anyway, I'll see if I can find some time tomorrow to look back into it; I did have a lot of fun hacking on Wine, and indespite of my inexperience regarding DirectX, I'll try to contribute back some more useful patches, hopefully ulti- mately getting that webcam support working. Kind regards, Jasper ----- Forwarded message from Jasper van Veghel <vanveghel(a)home.nl> ----- Date: Sat, 15 Jan 2005 14:18:47 +0100 From: Jasper van Veghel <vanveghel(a)home.nl> To: xerox_xerox2000(a)yahoo.co.uk, lgvlenders(a)yahoo.co.uk Subject: Re: video4linux - wine Hey Luis, Robbert, It's been a few weeks ago since I've worked on this stuff; I wrote some note- worthy patches and some hacks to get MSN working; I'll let you decide what's what ;-) In dlls/wininet/ I made the following two changes; The first is to get it to connect to MSN (not camera-related), as it tries to send text over SSL for some reason.. not sure if this is necessary (anymore) though, with rsabase and all: --- netconnection.c.old 2005-01-15 13:46:46.000000000 +0100 +++ netconnection.c 2004-12-14 22:38:19.000000000 +0100 @@ -104,7 +104,7 @@ void NETCON_init(WININET_NETCONNECTION *connection, BOOL useSSL) { - connection->useSSL = useSSL; + connection->useSSL = /*useSSL*/0; connection->socketFD = -1; if (connection->useSSL) { Note the date on those files by the way; they were taken from CVS around 12/14/04, so it's not a complete diff to the recent CVS. This one takes care of an unknown / undocumented optionId in InternetSetOptionAW that MSN uses in dlls/wininet/: --- internet.c.old 2005-01-15 13:55:56.000000000 +0100 +++ internet.c 2004-12-14 17:29:42.000000000 +0100 @@ -1962,6 +1962,9 @@ case INTERNET_OPTION_CONNECTED_STATE: FIXME("Option INTERNET_OPTION_CONNECTED_STATE: STUB\n"); break; + case 87: + FIXME("Undocumented option 87: STUB\n"); + break; default: FIXME("Option %ld STUB\n",dwOption); INTERNET_SetLastError(ERROR_INVALID_PARAMETER); Of more interest might be this change to dlls/devenum/createdevenum.c: --- createdevenum.c.old 2005-01-15 14:02:24.000000000 +0100 +++ createdevenum.c 2004-12-27 22:07:27.000000000 +0100 @@ -117,7 +117,8 @@ if (IsEqualGUID(clsidDeviceClass, &CLSID_AudioRendererCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_AudioInputDeviceCategory) || - IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory)) + IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory) || + IsEqualGUID(clsidDeviceClass, &CLSID_VideoInputDeviceCategory)) { hbasekey = HKEY_CURRENT_USER; strcpyW(wszRegKey, wszActiveMovieKey); @@ -142,7 +143,8 @@ { if (IsEqualGUID(clsidDeviceClass, &CLSID_AudioRendererCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_AudioInputDeviceCategory) || - IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory)) + IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory) || + IsEqualGUID(clsidDeviceClass, &CLSID_VideoInputDeviceCategory)) { HRESULT hr = DEVENUM_CreateSpecialCategories(); if (FAILED(hr)) @@ -411,6 +413,55 @@ CoTaskMemFree(pTypes); } } + + res = DEVENUM_CreateAMCategoryKey(&CLSID_VideoInputDeviceCategory); + if (SUCCEEDED(res)) { /* can register device(s) in this category */ + for (i = 0; i < 10; i++) { // the index can range from 0 thru 9 + WCHAR szDeviceName[80], szDeviceVersion[80]; + + if (capGetDriverDescriptionW ((WORD) i, + szDeviceName, sizeof (szDeviceName), + szDeviceVersion, sizeof (szDeviceVersion))) { + IMoniker * pMoniker = NULL; + + TRACE("\nSuccess !\n"); + + rfp2.nMediaTypes = 1; + pTypes = CoTaskMemAlloc(rfp2.nMediaTypes * + sizeof(REGPINTYPES)); + if (!pTypes) { + IFilterMapper2_Release(pMapper); + + return E_OUTOFMEMORY; + } + + /* FIXME: Not sure if these are correct */ + pTypes[0].clsMajorType = &MEDIATYPE_Video; + pTypes[0].clsMinorType = &MEDIASUBTYPE_RGB24; + + rfp2.lpMediaType = pTypes; + + res = IFilterMapper2_RegisterFilter(pMapper, + // &CLSID_VideoRenderer, + &CLSID_VfwCapture, + szDeviceName, + &pMoniker, + &CLSID_VideoInputDeviceCategory, + szDeviceName, + &rf2); + + /* FIXME: do additional stuff with IMoniker here, depending on what RegisterFilter does */ + + if (pMoniker) + IMoniker_Release(pMoniker); + + if (i == iDefaultDevice) + FIXME("Default device\n"); + + CoTaskMemFree(pTypes); + } + } + } } if (pMapper) And a small addition to devenum_private.h: --- devenum_private.h.old 2005-01-15 14:06:39.000000000 +0100 +++ devenum_private.h 2004-12-26 22:01:19.000000000 +0100 @@ -26,6 +26,7 @@ #include "windef.h" #include "winbase.h" +#include "wingdi.h" #include "winuser.h" #include "winreg.h" #include "winerror.h" @@ -38,6 +39,7 @@ #include "olectl.h" #include "wine/unicode.h" #include "uuids.h" +#include "vfw.h" /********************************************************************** * Dll lifetime tracking declaration for devenum.dll And the Makefile (dlls/devenum/Makefile.in): --- Makefile.in.old 2005-01-15 14:11:31.000000000 +0100 +++ Makefile.in 2005-01-15 14:13:36.000000000 +0100 @@ -3,7 +3,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = devenum.dll -IMPORTS = ole32 oleaut32 winmm user32 advapi32 kernel32 +IMPORTS = ole32 oleaut32 winmm avicap32 user32 advapi32 kernel32 EXTRALIBS = -lstrmiids -luuid C_SRCS = \ And so we add some to capGetDriverDescrptionAW aswell (dlls/avicap32/); I just added some static labels, not really getting these anywhere yet: --- avicap32_main.c.old 2005-01-15 14:15:43.000000000 +0100 +++ avicap32_main.c 2004-12-27 22:21:22.000000000 +0100 @@ -69,11 +69,22 @@ BOOL VFWAPI capGetDriverDescriptionA(WORD wDriverIndex, LPSTR lpszName, INT cbName, LPSTR lpszVer, INT cbVer) { - FIXME("(%d, %p, %d, %p, %d) stub!\n", wDriverIndex, lpszName, cbName, + FIXME("stub: (%d, %p, %d, %p, %d) stub!\n", wDriverIndex, lpszName, cbName, lpszVer, cbVer); - return FALSE; + + // FIXME: Make use of Video4Linux here + + strncpy (lpszName, "Logitech QuickCam Pro 4000", cbName); + strncpy (lpszVer, "Wine Video4Linux Driver", cbVer); + + return TRUE; } +WCHAR x1[] = {'L','o','g','i','t','e','c','h',' ','Q','u','i','c','k','c','a', + 'm',' ','P','r','o',' ','4','0','0','0',0}, + x2[] = {'W','i','n','e',' ','V','i','d','e','o','4','L','i','n','u','x', + ' ','d','r','i','v','e','r',0}; + /*********************************************************************** * capGetDriverDescriptionW (AVICAP32.@) */ @@ -82,5 +93,11 @@ { FIXME("(%d, %p, %d, %p, %d) stub!\n", wDriverIndex, lpszName, cbName, lpszVer, cbVer); - return FALSE; + + // FIXME: Make use of Video4Linux here + + lstrcpynW (lpszName, x1, cbName); + lstrcpynW (lpszVer, x2, cbVer); + + return TRUE; } And the dlls/avicap32/Makefile.in changes for the strcpy stuff: --- Makefile.in.old 2005-01-15 14:15:34.000000000 +0100 +++ Makefile.in 2004-12-26 22:55:13.000000000 +0100 @@ -3,7 +3,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = avicap32.dll -IMPORTS = ntdll +IMPORTS = unicows ntdll C_SRCS = avicap32_main.c Next up is dlls/quartz, which seemed to handle the DirectShow filter thingies; first off there's include/config.idl: --- control.idl.old 2005-01-15 15:07:23.000000000 +0100 +++ control.idl 2004-12-27 04:25:25.000000000 +0100 @@ -26,6 +26,7 @@ interface IBasicAudio; interface IBasicVideo; interface IVideoWindow; +interface IAMStreamConfig; interface IMediaEvent; interface IMediaEventEx; @@ -123,6 +124,22 @@ HRESULT IsCursorHidden( [out] long *CursorHidden ); } +/***************************************************************************** + * IAMStreamConfig interface + */ +[ + object, + uuid(c6e13340-30ac-11d0-a18c-00a0c9118956), + pointer_default(unique) +] +interface IAMStreamConfig : IUnknown +{ + HRESULT SetFormat( [in] AM_MEDIA_TYPE *pmt); + HRESULT GetFormat( [in] AM_MEDIA_TYPE **pmt); + HRESULT GetNumberOfCapabilities( [out] int *piCount, [out] int *piSize); + HRESULT GetStreamCaps( [in] int iIndex, [out] AM_MEDIA_TYPE **pmt, + [out] BYTE *pSCC); +} /***************************************************************************** * IBasicVideo interface And of course the generated interface from this, added to videorenderer.c, plus some partial implementation stuff (if someone could finish this, plus add an implementation for IKsPin, they'd probably be well on their way (provided that is that it's actually coupled to a capturing device, rather then have bogus data in it as I've done here)) --- videorenderer.c.old 2005-01-15 14:39:24.000000000 +0100 +++ videorenderer.c 2004-12-27 21:15:01.000000000 +0100 @@ -48,12 +48,14 @@ static IBasicVideoVtbl IBasicVideo_VTable; static IVideoWindowVtbl IVideoWindow_VTable; static const IPinVtbl VideoRenderer_InputPin_Vtbl; +static IAMStreamConfigVtbl IAMStreamConfig_VTable; typedef struct VideoRendererImpl { const IBaseFilterVtbl * lpVtbl; IBasicVideoVtbl * IBasicVideo_vtbl; IVideoWindowVtbl * IVideoWindow_vtbl; + IAMStreamConfigVtbl * IAMStreamConfig_vtbl; ULONG refCount; CRITICAL_SECTION csFilter; @@ -327,6 +329,7 @@ pVideoRenderer->lpVtbl = &VideoRenderer_Vtbl; pVideoRenderer->IBasicVideo_vtbl = &IBasicVideo_VTable; pVideoRenderer->IVideoWindow_vtbl = &IVideoWindow_VTable; + pVideoRenderer->IAMStreamConfig_vtbl = &IAMStreamConfig_VTable; pVideoRenderer->refCount = 1; InitializeCriticalSection(&pVideoRenderer->csFilter); @@ -378,6 +381,8 @@ *ppv = (LPVOID)&(This->IBasicVideo_vtbl); else if (IsEqualIID(riid, &IID_IVideoWindow)) *ppv = (LPVOID)&(This->IVideoWindow_vtbl); + else if (IsEqualIID(riid, &IID_IAMStreamConfig)) + *ppv = (LPVOID)&(This->IAMStreamConfig_vtbl); if (*ppv) { @@ -1556,3 +1561,172 @@ Videowindow_HideCursor, Videowindow_IsCursorHidden }; + + +/*** IAMStreamConfig methods ***/ +static HRESULT WINAPI AMStreamConfig_QueryInterface(IAMStreamConfig *iface, + REFIID riid, + LPVOID*ppvObj) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + + TRACE("(%p/%p)->(%s (%p), %p)\n", This, iface, debugstr_guid(riid), riid, ppvObj); + + // return AMStreamConfig_QueryInterface((IUnknown*)This, riid, ppvObj); + return S_OK; +} + +static ULONG WINAPI AMStreamConfig_AddRef(IAMStreamConfig *iface) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + + TRACE("(%p/%p)->()\n", This, iface); + + // return AMStreamConfig_AddRef((IUnknown*)This); + return S_OK; +} + +static ULONG WINAPI AMStreamConfig_Release(IAMStreamConfig *iface) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + + TRACE("(%p/%p)->()\n", This, iface); + + // return AMStreamConfig_Release((IUnknown*)This); + return S_OK; +} + +static HRESULT WINAPI AMStreamConfig_SetFormat(IAMStreamConfig *iface, + AM_MEDIA_TYPE *pmt) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + + TRACE("(%p/%p): stub !!\n", This, iface); + + return S_OK; +} + +static HRESULT WINAPI AMStreamConfig_GetFormat(IAMStreamConfig *iface, + AM_MEDIA_TYPE **pmt) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + + TRACE("(%p/%p): stub !!\n", This, iface); + + return S_OK; +} + +typedef struct _VIDEO_STREAM_CONFIG_CAPS { + GUID guid; + ULONG VideoStandard; + SIZE InputSize; + SIZE MinCroppingSize; + SIZE MaxCroppingSize; + int CropGranularityX; + int CropGranularityY; + int CropAlignX; + int CropAlignY; + SIZE MinOutputSize; + SIZE MaxOutputSize; + int OutputGranularityX; + int OutputGranularityY; + int StretchTapsX; + int StretchTapsY; + int ShrinkTapsX; + int ShrinkTapsY; + LONGLONG MinFrameInterval; + LONGLONG MaxFrameInterval; + LONG MinBitsPerSecond; + LONG MaxBitsPerSecond; +} VIDEO_STREAM_CONFIG_CAPS; + +static HRESULT WINAPI AMStreamConfig_GetNumberOfCapabilities(IAMStreamConfig *iface, + int *piCount, + int *piSize) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + + TRACE("((%p/%p): %p %p): semi-stub !!\n", This, iface, piCount, piSize); + + *piCount = 1; + *piSize = sizeof(VIDEO_STREAM_CONFIG_CAPS); + + return S_OK; +} + +static HRESULT WINAPI AMStreamConfig_GetStreamCaps(IAMStreamConfig *iface, + int iIndex, + AM_MEDIA_TYPE **pmt, + BYTE *pSCC) { + ICOM_THIS_MULTI(VideoRendererImpl, IAMStreamConfig_vtbl, iface); + VIDEOINFOHEADER *pvi; + VIDEO_STREAM_CONFIG_CAPS *vsc; + + TRACE("((%p/%p) %d %p %p): semi-stub !!\n", This, iface, iIndex, pmt, pSCC); + + // FIXME: Get actual stream information in here (IEnumMediaTypes ?) + + pmt[0] = CoTaskMemAlloc(sizeof (AM_MEDIA_TYPE)); + memcpy (&pmt[0]->formattype, &FORMAT_VideoInfo, sizeof (GUID)); + memcpy (&pmt[0]->majortype, &MEDIATYPE_Video, sizeof (GUID)); + memcpy (&pmt[0]->subtype, &MEDIASUBTYPE_RGB24, sizeof (GUID)); + pmt[0]->bTemporalCompression = 0; + pmt[0]->bFixedSizeSamples = 1; + pmt[0]->lSampleSize = 1; + + // FIXME: The stuff below is just there so it contains something + + pmt[0]->cbFormat = sizeof(VIDEOINFOHEADER); + pmt[0]->pbFormat = CoTaskMemAlloc(pmt[0]->cbFormat); + ZeroMemory(pmt[0]->pbFormat, pmt[0]->cbFormat); + pvi = (VIDEOINFOHEADER *)pmt[0]->pbFormat; + pvi->rcSource.right = 640; pvi->rcSource.bottom = 480; + pvi->rcTarget.right = 640; pvi->rcTarget.bottom = 480; + pvi->dwBitRate = 10; + pvi->dwBitErrorRate = 0; + pvi->AvgTimePerFrame = (LONGLONG)(10000000.0 / 25); // 25 is hardcoded + + // FIXME: The stuff below is just there so it contains something + + pvi->bmiHeader.biWidth = 640; + pvi->bmiHeader.biHeight = 480; + pvi->bmiHeader.biBitCount = 24; + pvi->bmiHeader.biCompression = BI_RGB; + pvi->bmiHeader.biSizeImage = 0; + pvi->bmiHeader.biXPelsPerMeter = 640; + pvi->bmiHeader.biYPelsPerMeter = 480; + pvi->bmiHeader.biClrUsed = 0; + pvi->bmiHeader.biClrImportant = 0; + + // FIXME: Blahblahblah + + vsc = (VIDEO_STREAM_CONFIG_CAPS *)pSCC; + memcpy (&vsc->guid, &FORMAT_VideoInfo, sizeof (GUID)); + vsc->VideoStandard = 0; + vsc->InputSize.cx = 640; vsc->InputSize.cy = 480; + vsc->MinCroppingSize.cx = 320; vsc->MinCroppingSize.cy = 240; + vsc->MaxCroppingSize.cx = 640; vsc->MaxCroppingSize.cy = 480; + vsc->CropGranularityX = 10; + vsc->CropGranularityY = 10; + vsc->CropAlignX = 0; + vsc->CropAlignY = 0; + vsc->MinOutputSize.cx = 320; vsc->MinOutputSize.cy = 240; + vsc->MaxOutputSize.cx = 640; vsc->MaxOutputSize.cy = 480; + vsc->OutputGranularityX = 10; + vsc->OutputGranularityY = 10; + vsc->StretchTapsX = 1; + vsc->StretchTapsY = 1; + vsc->ShrinkTapsX = 1; + vsc->ShrinkTapsY = 1; + vsc->MinFrameInterval = (LONGLONG)(10000000.0 / 25); + vsc->MaxFrameInterval = (LONGLONG)(10000000.0 / 25); + vsc->MinBitsPerSecond = 24; + vsc->MaxBitsPerSecond = 24; + + return S_OK; +} + +static IAMStreamConfigVtbl IAMStreamConfig_VTable = +{ + AMStreamConfig_QueryInterface, + AMStreamConfig_AddRef, + AMStreamConfig_Release, + AMStreamConfig_SetFormat, + AMStreamConfig_GetFormat, + AMStreamConfig_GetNumberOfCapabilities, + AMStreamConfig_GetStreamCaps +}; As for Quartz; there's been a lot of development over the last couple of weeks on this, especially on the FilterMapper, regsvr, AVI stuff, videorenderer, etc., so that aswell as future development might prove to be quite useful in getting this to work. Anyway, that's pretty much all there is; I wrote some other hacks to various DLLs, but eventually ended up using native DLLs instead as the hacking proved too extensive (sorry to say, my goal at that point was getting my webcam to work under MSN with Wine, not to add anything useful to Wine itself (though it would have been a nice side-effect)) Hopefully the patches were of some use to you, and perhaps someone can get V4L/VFW working under WINE. I, for one, would cer- tainly appreciate it :-) Best Regards, Jasper Robbert Xerox wrote: > Hi, i was wondering if you could post your > hacks/patches you talk about in the message (involving > this webcam/MSN messenger etc. stuff) either to the > wine developement mailinglist or to me. I would be > very gratefull as i really would like to have a look > at it, to see if i could get any further. Thanks in > advance, Robbert > > > > > > ___________________________________________________________ > ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com > ----- End forwarded message -----

1 0

Re: Re: [DMUSIC/DINPUT] includes fixes
by fenix＠club-internet.fr March 14, 2005

March 14, 2005

4 4

Automatic installation rev-eng utility
by Shachar Shemesh March 14, 2005

March 14, 2005

Hi all, I said this in a reply in one of the threads (the one about Windows registry), and got zero reply. I'm bringing the subject up again here. Back in 1996 (and until around 2000) I was project manager for a project called "GTFormat". This was a project used by the late Packard Bell, as well as NEC in Japan, to put the programs bundled with the machines on the hard disks shipped out to customers. The tools consist of a tool that understands what the original installation did, a database to do offline conflict resolution and other stuff, and a front end to perform a (silent) installation of the result. I have written most of the code in the last part of this project, and as I said before, managed the entire thing. We also had a tool the generated files for the last part directly from the first part, without going through the database. Now, the tool was written when I was an employee of the company that produced them (G.Tek Technologies, today called gteko), but I believe that given enough persuasion I can get their approval to either freely distribute or actually open source the detection and the installation tool. I believe most of the distinguishing value of the tool as far as Gteko is concerned is in the database, which is not relevant for Wine in any way. The tool is written mostly in C++ for Visual Studio 6. It may require pulling out a single proprietary library (compression), but should not pose a problem (zlib does a wonderful job, after all). The question, therefor, is this. Should I try? The tool has proven itself over a long period of time, and is fairly reliable (at least was back at the time). It CAN solve some of our installer related problems. Your opinions are welcome. So, what say you? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. Have you backed up today's work? http://www.lingnu.com/backup.html

2 2

Re: make mlang_test.exe loadable on NT 4.0 [resend, 3nd time]
by Alexandre Julliard March 14, 2005

March 14, 2005

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > Hi Alexandre, > > you have now ignore this patch three times :-( is anything wrong with it? or > does "wine-patches" have a hole ? There must be a hole somewhere yes, it's the first time I ever see that patch. Maybe my spam filter doesn't like you <g> -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [X11DRV] Fix X11 Device list leak
by Raphael March 14, 2005

March 14, 2005

Hi, > Thanks for submitting this patch. > These are exactly the fixes I was about to submit! Nothing :) > Your patch should should have a major impact on users of applications > which use the wintab library: They should all start to function to some > degree. i hope so, waiting for users report now :) > Apologies for not commenting on patch/ submitting a fix earlier.... > A major knee operation has put me out of action for the last few weeks. :( Have a good recovery > P.S. Please don't expect timely responses to mails for at least > another week. > I'll try my best to respond, but can't promise anything. > Regards, Raphael

1 0

Re: richedit patches by Phil Krylov
by Phil Krylov March 14, 2005

March 14, 2005

On Mon, 14 Mar 2005 19:31:25 +0100 Krzysztof Foltman <kfoltman(a)portal.onet.pl> wrote: > > ChangeLog: > > Initial implementation of EM_STREAMOUT and RTF writer. > > Nice to see this functionality implemented (I really didn't want to > implement it myself). Very good code too. Thanks. Thanks :) > The new function ME_FindItemAtOffset isn't really necessary, you can > achieve exactly the same thing with ME_RunOfsFromCharOfs (and I should > have used it in ME_GetTextW instead of reimplementing the same > functionality). I'm going to get rid of it later. Oh sorry, I haven't noticed that it already exists. > Now when both EM_STREAMIN and EM_STREAMOUT work, I can start > implementing the rest of the clipboard code. The RTF reader still has to be teached Unicode. Currently most of my existing .rtf documents are totally garbled. -- Ph.

1 0

Re: [patch] x86: fix ESP corruption CPU bug
by Stas Sergeev March 14, 2005

March 14, 2005

Hi, Linus Torvalds wrote: > Btw, Stas, one thing I'd really like to see is even a partial list of > anything that actually cares about this. Ie, if there is some known > Windows app where Wine works better or something like that, just adding I am not using Wine too much, but I've found this: http://cvs.winehq.org/cvsweb/~checkout~/wine/dlls/winedos/int31.c?rev=1.41&… --- /* due to a flaw in some CPUs (at least mine), it is best to mark stack segments as 32-bit if they can be used in 32-bit code. Otherwise, these CPUs may not set the high word of esp during a ring transition (from kernel code) to the 16-bit stack, and this causes trouble if executing 32-bit code using this stack. */ --- I added win-devel to CC, maybe people there can tell if that patch has any value for them or not. The reference to the original patch: http://www.uwsg.iu.edu/hypermail/linux/kernel/0503.1/1794.html Dosemu looks a little better on that, the whole chapter of the docs is dedicated to that problem: http://dosemu.sourceforge.net/docs/EMUfailure/t1.html#AEN55 There you can find a (relatively small) list of the programs that are affected, but I personally have the old Microsoft linker that crashes, and a few more DOS games. > Another way of saying the same thing: I absolutely hate seeing patches > that fix some theoretical issue that no Linux apps will ever care about. No, it is not theoretical, but it is mainly about a DOS games and an MS linker, as for me. The things I'd like to get working, but the ones you may not care too much about:) The particular game I want to get working, is "Master of Orion 2" for DOS. > So I'd like to have a bit more of a case for this patch, since I know what > the case against it is ;) Yep, and the informational leak it closes, looks also rather minor. So it is only a matter of how do you care about the dosemu and the DOS games under linux. Considering the amount of the dosemu-related code in vm86.c, I guess you care:) And uhm, adding the list of the DOS games to the comments of the Linux kernel code, doesn't sound like a good idea to me:)

6 7

Re: shlapi: Fixes for UrlIsW and UrlIsA
by Mike McCormack March 14, 2005

March 14, 2005

Troy Rollo wrote: > Testing under Windows shows that UrlIsW and UrlIsA should: Would you be able to write a conformance test using what you've found, to make sure it doesn't break again? Even just posting the test program to wine-patches so somebody could create a conformance test out of it would be great... Mike

2 1

richedit patches by Phil Krylov
by Krzysztof Foltman March 14, 2005

March 14, 2005

> ChangeLog: > Initial implementation of EM_STREAMOUT and RTF writer. Nice to see this functionality implemented (I really didn't want to implement it myself). Very good code too. Thanks. IMHO the patch can be applied without changes. The new function ME_FindItemAtOffset isn't really necessary, you can achieve exactly the same thing with ME_RunOfsFromCharOfs (and I should have used it in ME_GetTextW instead of reimplementing the same functionality). I'm going to get rid of it later. Now when both EM_STREAMIN and EM_STREAMOUT work, I can start implementing the rest of the clipboard code. > Added "generator" RTF destination handling. > Added missing PFA_JUSTIFY definition to richedit.h. Thanks for the fixes, I really didn't know how to get rid of the \generator. Maybe it will help me figure out how to ignore the rest of the RTF junk that I can't use anyway (\pgdsctbl and others). Krzysztof

3 3

Let's fix Steam!
by Scott Ritchie March 14, 2005

March 14, 2005

Steam has had a serious problem for quite some time, failing with a strange debug assertion error popup at the dreaded 27% mark. What's interesting, however, is that Steam works perfectly in Crossover 4.1 - since I don't think Steam is supported, this is not due to a special hack, and the failure in Steam therefore represents a serious regression in Wine. This, quite simply, will be a really cool app to get working again. Plus, we'll need it to try out Half Life 2 once you awesome Direct3D boys finish up your work :) So, where do we go about this? The installer demonstrating the error can be downloaded easily from http://www.steampowered.com/ - however, I'm not sure if it's plausible to run a regression analysis since there are no patches available against the direct crossover version of Wine. At this point, I'm not even sure which file has broken, although I do know that it's one we've had problems with in the past based off of IRC conversations. If anyone could follow up with more info, particularly about the specifics of the error, I'm sure we'd all appreciate it greatly. Thanks, Scott Ritchie

3 11

Re: Ptrace problem on amd64? (Was: Re: Warcraft III can't find cdrom)
by Mike Hearn March 14, 2005

March 14, 2005

T.J. Zeeman wrote: >>>Warcraft still complains about the CD-rom being MIA though :( I'll see >>>if I can dig up a few hints from the log this weekend. >> >>Make sure your kernel hsa the ptrace regression fixes in. > > > I guess you meant the problems refered to in WWN250 > (http://www.winehq.com/?issue=250) I checked and the patch there is > only for i386. I ported those to the x86_64 files (see attachments) and > tried again to no avail. > > I also tried the test app as posted by Linus Torvalds here: > http://www.winehq.com/hypermail/wine-devel/2004/11/0551.html > When trying that on amd64 with the ptrace patches it does not even want > to compile (not completely surprising). In the chroot it segfaults. > A strace showed the following: > > x5556c000 > access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or > directory) > open("/etc/ld.so.preload", O_RDONLY) = -1 ENOENT (No such file or > directory) > open("/etc/ld.so.cache", O_RDONLY) = 3 > fstat64(3, {st_mode=S_IFREG|0644, st_size=32850, ...}) = 0 > old_mmap(NULL, 32850, PROT_READ, MAP_PRIVATE, 3, 0) = 0x5556d000 > close(3) = 0 > access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or > directory) > open("/lib/tls/libc.so.6", O_RDONLY) = 3 > read(3, "\177ELF\1\1\1\0\0\0\0\0\0\0\0\0\3\0\3\0\1\0\0\0\360Y\1"..., > 512) = 512 > fstat64(3, {st_mode=S_IFREG|0644, st_size=1253924, ...}) = 0 > old_mmap(NULL, 1260140, PROT_READ|PROT_EXEC, MAP_PRIVATE, 3, 0) = > 0x55576000 > old_mmap(0x5569f000, 32768, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED, > 3, 0x129000) = 0x5569f000 > old_mmap(0x556a7000, 10860, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED| > MAP_ANONYMOUS, -1, 0) = 0x556a7000 > close(3) = 0 > old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, > -1, 0) = 0x556aa000 > set_thread_area({entry_number:-1 -> 11, base_addr:0x556aa2a0, > limit:1048575, seg_32bit:1, contents:0, read_exec_only:0, > limit_in_pages:1, seg_not_present:0, useable:1}) = 0 > munmap(0x5556d000, 32850) = 0 > rt_sigaction(SIGTRAP, {0x8048438, [TRAP], SA_RESTART}, {SIG_DFL}, 8) = 0 > mprotect(0x8048000, 4096, PROT_READ|PROT_WRITE) = 0 > --- SIGSEGV (Segmentation fault) @ 0 (0) --- > +++ killed by SIGSEGV +++ > > > I haven't been this deep into low level code in a long time (and that > was 8086 asm simulated on a sparc), but I thought this would work and > not segfault. Anybody around here that can comment on that? Or should I > take this to another forum to further investigate? If so, where would > you suggest I take it? I'm not sure, probably lkml would be best but I'm not subscribed to that. I'll CC wine-devel and maybe somebody there can help. I'd recommend pinging Linus and asking about whether the ptrace regressions still affect x86-64. thanks -mike > regards, > Thomas > > > > > ------------------------------------------------------------------------ > > --- /usr/src/kernel-source-2.6.10/arch/x86_64/kernel/ptrace.c 2004-12-24 22:34:30.000000000 +0100 > +++ ptrace.c 2005-03-01 20:32:29.713639136 +0100 > @@ -79,6 +79,28 @@ > return 0; > } > > +static void set_singlestep(struct task_struct *child) > +{ > + long eflags; > + > + set_tsk_thread_flag(child, TIF_SINGLESTEP); > + eflags = get_stack_long(child, EFL_OFFSET); > + put_stack_long(child, EFL_OFFSET, eflags | TRAP_FLAG); > + child->ptrace |= PT_DTRACE; > +} > + > +static void clear_singlestep(struct task_struct *child) > +{ > + if (child->ptrace & PT_DTRACE) { > + long eflags; > + > + clear_tsk_thread_flag(child, TIF_SINGLESTEP); > + eflags = get_stack_long(child, EFL_OFFSET); > + put_stack_long(child, EFL_OFFSET, eflags & ~TRAP_FLAG); > + child->ptrace &= ~PT_DTRACE; > + } > +} > + > /* > * Called by kernel/ptrace.c when detaching.. > * > @@ -86,11 +108,12 @@ > */ > void ptrace_disable(struct task_struct *child) > { > - long tmp; > +/* long tmp; > > clear_tsk_thread_flag(child, TIF_SINGLESTEP); > tmp = get_stack_long(child, EFL_OFFSET) & ~TRAP_FLAG; > - put_stack_long(child, EFL_OFFSET, tmp); > + put_stack_long(child, EFL_OFFSET, tmp); */ > + clear_singlestep(child); > } > > static int putreg(struct task_struct *child, > @@ -338,8 +361,6 @@ > break; > case PTRACE_SYSCALL: /* continue and stop at next (return from) syscall */ > case PTRACE_CONT: { /* restart after signal. */ > - long tmp; > - > ret = -EIO; > if ((unsigned long) data > _NSIG) > break; > @@ -347,12 +368,9 @@ > set_tsk_thread_flag(child,TIF_SYSCALL_TRACE); > else > clear_tsk_thread_flag(child,TIF_SYSCALL_TRACE); > - clear_tsk_thread_flag(child, TIF_SINGLESTEP); > child->exit_code = data; > /* make sure the single step bit is not set. */ > - tmp = get_stack_long(child, EFL_OFFSET); > - tmp &= ~TRAP_FLAG; > - put_stack_long(child, EFL_OFFSET,tmp); > + clear_singlestep(child); > wake_up_process(child); > ret = 0; > break; > @@ -394,34 +412,23 @@ > * exit. > */ > case PTRACE_KILL: { > - long tmp; > - > ret = 0; > if (child->exit_state == EXIT_ZOMBIE) /* already dead */ > break; > clear_tsk_thread_flag(child, TIF_SINGLESTEP); > child->exit_code = SIGKILL; > /* make sure the single step bit is not set. */ > - tmp = get_stack_long(child, EFL_OFFSET) & ~TRAP_FLAG; > - put_stack_long(child, EFL_OFFSET, tmp); > + clear_singlestep(child); > wake_up_process(child); > break; > } > > case PTRACE_SINGLESTEP: { /* set the trap flag. */ > - long tmp; > - > ret = -EIO; > if ((unsigned long) data > _NSIG) > break; > clear_tsk_thread_flag(child,TIF_SYSCALL_TRACE); > - if ((child->ptrace & PT_DTRACE) == 0) { > - /* Spurious delayed TF traps may occur */ > - child->ptrace |= PT_DTRACE; > - } > - tmp = get_stack_long(child, EFL_OFFSET) | TRAP_FLAG; > - put_stack_long(child, EFL_OFFSET, tmp); > - set_tsk_thread_flag(child, TIF_SINGLESTEP); > + set_singlestep(child); > child->exit_code = data; > /* give it a chance to run. */ > wake_up_process(child); > > > ------------------------------------------------------------------------ > > --- /usr/src/kernel-source-2.6.10/arch/x86_64/kernel/signal.c 2004-12-24 22:35:23.000000000 +0100 > +++ signal.c 2005-03-01 20:33:11.425298000 +0100 > @@ -205,8 +205,14 @@ > err |= __put_user(me->thread.trap_no, &sc->trapno); > err |= __put_user(me->thread.error_code, &sc->err); > err |= __put_user(regs->rip, &sc->rip); > + > + /* > + * Iff TF was set because the program is being single-stepped by a > + * debugger, don't save that information on the signal stack.. We > + * don't want debugging to change state. > + */ > eflags = regs->eflags; > - if (current->ptrace & PT_PTRACED) { > + if (current->ptrace & PT_DTRACE) { > eflags &= ~TF_MASK; > } > err |= __put_user(eflags, &sc->eflags); > @@ -324,12 +330,16 @@ > regs->rsp = (unsigned long)frame; > > set_fs(USER_DS); > + /* > + * Clear TF when entering the signal handler, but > + * notify any tracer that was single-stepping it. > + * The tracer may want to single-step inside the > + * handler too. > + */ > if (regs->eflags & TF_MASK) { > - if ((current->ptrace & (PT_PTRACED | PT_DTRACE)) == (PT_PTRACED | PT_DTRACE)) { > + regs->eflags &= ~TF_MASK; > + if (current->ptrace & PT_DTRACE) > ptrace_notify(SIGTRAP); > - } else { > - regs->eflags &= ~TF_MASK; > - } > } > > #ifdef DEBUG_SIG

6 14

Re: STI, device drivers and stuff
by Steven Edwards March 14, 2005

March 14, 2005

Hi, --- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > > 2. STI has kernel mode components to deal USB / SCSI / > > serial / parallel ports. Is there any attempt to bring > > kernel mode support into Wine (ReactOS/Wine merger?) > > any time soon? If not, should I implement USB support > > using libusb in user-space? > > Wine is purely user-space, so yes, use libusb I guess. CrossOver is using libusb for the iPod stuff. There is little chance of sharing much of the hardware support with ReactOS however the higher level stuff is being shared such as setupapi. Having a wineserver thread or something that acts like the umpnpmgr on Windows would allow us to share a bit more code as well. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

DOS interrupts in Wine
by Sam Lauber March 14, 2005

March 14, 2005

Does Wine correctly implement all the DOS Services and interrupts? Samuel Lauber -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

3 2

Re: MSI: add property IDs for MSI summary information
by Juan Lang March 14, 2005

March 14, 2005

--- Mike McCormack <mike(a)codeweavers.com> wrote: > Yes, it's really in MsiDefs.h from the Windows Platform SDK. Weird. > As far as I can tell, MSI also reimplements the property set storage > code, as it makes no calls to the ole storage implementation of > IPropertySetStorage. Perhaps there is some subtle difference between > the two implementations? Or maybe they did that because > IPropertySetStorage isn't available on earlier OLE implemenations? More likely the former, though I wouldn't hazard a guess as to why. MS allows you to reimplement these, they just provide a default impl. It's been around for quite a while, though, the best description I've found is from 1993-1995, well before MSI: http://msdn.microsoft.com/library/default.asp?url=/archive/en-us/dnarolegen… --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: MSI: add property IDs for MSI summary information
by Juan Lang March 14, 2005

March 14, 2005

Hi Mike, > +#define PID_DICTIONARY 0 > +#define PID_CODEPAGE 1 > +#define PID_TITLE 2 Is it really like this in the PSDK? Some of these are already defined in propidl.idl. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Zuma
by Juan Pablo Sousa March 14, 2005

March 14, 2005

Hi, I'm trying to make the game Zuma work you can get the demo from: http://www.popcap.com/launchpage.php?theGame=zuma i've tried setting version to both win98 and winxp, in both cases I get very similar results I don't know where to start, the last line gives me the idea it's even chrashing the debugger, any ideas? here are the last lines running with +relay: 0009:Ret ntdll.RtlAcquirePebLock() retval=00000000 ret=77b18896 0009:Call ntdll.RtlUnicodeStringToAnsiString(7792fa0c,77eff920,00000001) ret=77b188bd 0009:Ret ntdll.RtlUnicodeStringToAnsiString() retval=00000000 ret=77b188bd 0009:Call ntdll.RtlReleasePebLock() ret=77b188d4 0009:Ret ntdll.RtlReleasePebLock() retval=00000000 ret=77b188d4 0009:Call ntdll.RtlEnterCriticalSection(77bde3c0) ret=77b27ed0 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=77b27ed0 0009:Call ntdll.RtlLeaveCriticalSection(77bde3c0) ret=77b27f00 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=77b27f00 0009:Call ntdll.RtlEnterCriticalSection(77bde3c0) ret=77b27ed0 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=77b27ed0 0009:Call ntdll.RtlLeaveCriticalSection(77bde3c0) ret=77b27f00 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=77b27f00 0009:Call ntdll.NtCreateEvent(77bf0974,001f0003,00000000,00000001,00000000) ret=77b5ffb7 0009:Ret ntdll.NtCreateEvent() retval=00000000 ret=77b5ffb7 0009:Ret PE DLL (proc=0x77afdef0,module=0x77af0000 L"kernel32.dll",reason=PROCESS_ATTACH,res=0x1) retval=1 0009:Ret ntdll.LdrInitializeThunk() retval=00000000 ret=77b44b6b 0009:Call ntdll.RtlImageNtHeader(00400000) ret=77b44b79 0009:Ret ntdll.RtlImageNtHeader() retval=004000f8 ret=77b44b79 0009:Starting process L"C:\\Program Files\\PopCap Games\\Zuma Deluxe\\Zuma.exe" (entryproc=0x856000) wine_dbg_vprintf: debugstr buffer overflow (contents: '0009:Call kernel32.VxDCall0(0086e000,0000000a,00857cf4 "\x8b\\$\x0c\xeb\x03\xeb\xfc\xeb\xeb\x01\xeb\xff\x8b\xb0",7792ff38 L"\ffff\ffff\de98\77af\96b0\77b1\7928\77bc",00856030,77b44ba2,77eff6c0 "",00000009,77eff04c,00856000,ffffffff (invalid),77afde98 L"\25ff\f4e4\77bc\f689\25ff\f4e8\77bc\f689\25ff\f4ec\77bc\f689\25ff\f4f0\77bc\f689\25ff\f4f4\77bc\f689\25ff\f4f8\77bc\f689\25ff\f4fc\77bc\f689\25ff\f500\77bc\f689\25ff\f504\77bc\f689\25ff\f508\77bc\f689\25ff\f50c\77bc\f689\8955\53e5\ec83\e814\81d8\fffe\c381\9a2c\000c\7d83\010c\3175\bb83\6e5c\0001\7501\8b28"...,77b196b0,77bc7928,00000000,00000000,7792fff4,7792ff28,77b44b1a,00000001,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,77bc7928,00000000,00000000,00000000,b7fb6dd1,00000000,Exception frame is not in st') err:seh:EXC_DefaultHandling Exception frame is not in stack limits => unable to dispatch exception.

1 0

[advpack] Implement RegisterOCX and stub out DelNodeRunDLL32
by Matthew Mastracci March 14, 2005

March 14, 2005

This patch helps the IE6 installer get past the DLL registration stage. The DelNodeRunDLL32 function is stubbed out, but RegisterOCX will correctly register a COM DLL by calling its DllRegisterServer function. ChangeLog: * dlls/advpack/advpack.c Matthew Mastracci <mmastrac(a)canada.com> Implement RegisterOCX Stub for DelNodeRunDLL32 Index: dlls/advpack/advpack.c =================================================================== RCS file: /home/wine/wine/dlls/advpack/advpack.c,v retrieving revision 1.7 diff -u -r1.7 advpack.c --- dlls/advpack/advpack.c 20 Jan 2005 20:03:13 -0000 1.7 +++ dlls/advpack/advpack.c 14 Mar 2005 07:35:54 -0000 @@ -32,6 +32,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(advpack); +typedef HRESULT (*DLLREGISTER) (void); + /*********************************************************************** * DllMain (ADVPACK.@) @@ -172,3 +174,60 @@ return S_OK; } + +/*********************************************************************** + * RegisterOCX (ADVPACK.@) + */ +void WINAPI RegisterOCX( HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show ) +{ + WCHAR wszBuff[MAX_PATH]; + WCHAR* pwcComma = &wszBuff[0]; + HMODULE hm; + DLLREGISTER pfnRegister; + HRESULT hr; + + TRACE("(%s)\n", cmdline); + + MultiByteToWideChar(CP_ACP, 0, cmdline, strlen(cmdline), wszBuff, MAX_PATH); + while (!(*pwcComma == ',' ) && *pwcComma) + { + pwcComma++; + } + *pwcComma = '\0'; + + TRACE("Parsed DLL name (%s)\n", debugstr_w(wszBuff)); + + hm = LoadLibraryExW(wszBuff, 0, LOAD_WITH_ALTERED_SEARCH_PATH); + if (!hm) + { + ERR("Couldn't load DLL: %s\n", debugstr_w(wszBuff)); + return; + } + + pfnRegister = (DLLREGISTER)GetProcAddress(hm, "DllRegisterServer"); + if (pfnRegister == NULL) + { + ERR("DllRegisterServer entry point not found\n"); + } + else + { + hr = pfnRegister(); + if (hr != S_OK) + { + ERR("DllRegisterServer entry point returned %08lx\n", hr); + } + } + + TRACE("Successfully registered OCX\n"); + + FreeLibrary(hm); +} + +/*********************************************************************** + * DelNodeRunDLL32 (ADVPACK.@) + */ +void WINAPI DelNodeRunDLL32( HWND hWnd, HINSTANCE hInst, LPCSTR cmdline, INT show ) +{ + FIXME("(%s) FIXME: stub\n", cmdline); +} + Index: dlls/advpack/advpack.spec =================================================================== RCS file: /home/wine/wine/dlls/advpack/advpack.spec,v retrieving revision 1.5 diff -u -r1.5 advpack.spec --- dlls/advpack/advpack.spec 20 Jan 2005 20:03:13 -0000 1.5 +++ dlls/advpack/advpack.spec 14 Mar 2005 07:35:54 -0000 @@ -2,7 +2,7 @@ @ stub AdvInstallFile @ stub CloseINFEngine @ stub DelNode -@ stub DelNodeRunDLL32 +@ stdcall DelNodeRunDLL32(ptr ptr str long) @ stdcall DllMain(long long ptr) @ stdcall DoInfInstall(ptr) @ stub ExecuteCab @@ -23,10 +23,11 @@ @ stub RegRestoreAll @ stub RegSaveRestore @ stub RegSaveRestoreOnINF -@ stub RegisterOCX +@ stdcall RegisterOCX(ptr ptr str long) @ stub RunSetupCommand @ stub SetPerUserSecValues @ stub TranslateInfString @ stub TranslateInfStringEx @ stub UserInstStubWrapper @ stub UserUnInstStubWrapper

2 3

Window style problem with Steam
by Stefan Dösinger March 14, 2005

March 14, 2005

Hello! I had a look at the "no keyboard problem" with Steam. A little reseach showed that Steam creates its main Window with WS_SYSMENU set but WS_CAPTION not set. MSDN says that WS_CAPTION must be set if WS_SYSMENU is used: WS_SYSMENU Creates a window that has a window menu on its title bar. The WS_CAPTION style must also be specified. (from http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winu…) If I check for this case in WIN_CreateWindowEx and set WS_CAPTION, the Window is controlled by KWM and I can type in the Steam window. But KWM draws the normal Window boarder and it overlaps the rest of the Window and confuses the mouse. Furthermore the menu of the systray applet has a Caption. The solution I've found is to set the WS_EX_APPWINDOW flag in cs->dwExStyle. In this case Steam behaves as I'd expect it. But is this a correct solution? Any suggestions? Stefan

1 0

Scrollkeeper, the documentation, XML, and the way forward
by Scott Ritchie March 14, 2005

March 14, 2005

I wanted the Wine documentation to appear on the nice help menus, like other standard apps. I learned that the way to do this is to write an OMF file for each document, which scrollkeeper can then look at to find the metadata about where the document is and how to index it and such. The trouble is, Scrollkeeper and the Gnome help menus no longer support SGML, as XML is the current new and hip thing. The Wine documentation is in SGML. There are quite a few reasons to move forward. The Wine documentation is also a bit separate (requiring its own compiling, for example) from the main code, and this should change. This link: http://scrollkeeper.sourceforge.net/documentation/scrollkeeper_example2_man… has some good information about how Wine should look to play well with Scrollkeeper and modern distros. I propose we attack this in phases, and create the following plan of attack: 1) Create a new directory for all XML documentation at wine/doc. This will also bring us to be more standard. 2) When we convert old SGML documents to XML and move them there, we write an OMF file for them then and there (I'll do it if you like). We also make sure the build process is aware of this stuff and is installing the xml and omf files in the right place so scrollkeeper can find them when it runs after build time. 3) We follow the steps at the above link to add scrollkeeper into the configure scripts after we convert the first document to XML. I vote for the Wine User Guide, since I'm working on it. 4) We inform the packagers once scrollkeeper is working in a release, as there are sometimes little tricks for it (one for rpms is on the page) So, beyond that, the first step seems pretty simple: convert the sgml stuff into xml format and put it into the new doc folder. Can someone point me to some good tools to do this? Thanks, Scott Ritchie

6 8

Re: shlapi: Fixes for UrlIsW and UrlIsA
by Andreas Mohr March 14, 2005

March 14, 2005

Hi, On Mon, Mar 14, 2005 at 09:07:57PM +1100, Troy Rollo wrote: > Testing under Windows shows that UrlIsW and UrlIsA should: Since you already did testing under Windows, adding proper tests would make sense, I guess... Or in other words: I'm not sure whether your current patch would get applied. Andreas Mohr

1 0

Re: wine/ misc/registry.c documentation/samples/config
by Steven Edwards March 14, 2005

March 14, 2005

Hi, --- Mike McCormack <mike(a)codeweavers.com> wrote: > People would moan and complain, but in the end Wine and Wine users would > be better off, as they would no longer depend on anything but Wine to > run their Windows software. I have to agree. Short term being able to load the Windows registry and Windows system dlls helped Wine but long term it has led to stagnation. Most of the recent growth in Wine in past few years has been because we are being forced to not be dependant on a existing Windows install or Windows componates such as DCOM IE, MSI, etc which is a good thing. Thanks Steven __________________________________ Do you Yahoo!? Make Yahoo! your home page http://www.yahoo.com/r/hs

8 13

[ARTWORK] icon: "My Computer"
by egore March 14, 2005

March 14, 2005

Hi list, I drew a simple icon that COULD be used as a replacement for the current one. I don't know if anyone of you likes it, so please tell me what you think. Tell me if you like it, if you hate if, what could be done better, etc. The icon can be found in different sizes (and in a scalable format) at http://www.egore911.de/vype/wine/ Regards, Christoph Brill aka egore911

6 6

Re: Wine Start Menu in the Desktop Applications Menu
by Dan Kegel March 14, 2005

March 14, 2005

Jeff Waugh (jeff.waugh_at_ubuntu.com) wrote: >> The PowerPC version of the packages, however, is another issue. >> Obviously, we can't make Wine work with i386-compiled apps on PPC, > > (There's an awesome opportunity for qemu integration there...) Yeah, that's something the folks at http://darwine.opendarwin.org have been thinking about for some time, and to some extent trying. You might give them a shout... - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [X11DRV] Fix X11 Device list leak
by rob March 14, 2005

March 14, 2005

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Raphael fenix-at-club-internet.fr |Wine Mailing Lists| wrote: |Hi, | |Changelog: | - XListInputDevices spec say that device list should be freed using |XFreeDeviceList | - better robustness on X11DRV_AttachEventQueueToTablet | |I hope it helps to fix bug 2017 (http://bugs.winehq.org/show_bug.cgi?id=2017) | |Regards, |Raphael Thanks for submitting this patch. These are exactly the fixes I was about to submit! Your patch should should have a major impact on users of applications which use the wintab library: They should all start to function to some degree. Apologies for not commenting on patch/ submitting a fix earlier.... A major knee operation has put me out of action for the last few weeks. P.S. Please don't expect timely responses to mails for at least another week. I'll try my best to respond, but can't promise anything. Cheers ~ -Rob. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCNPgCKeDvIR8zB68RAgQ3AJ9BA00ZgtZd/HXWy0nOPa3xpWaO3QCfcvVJ RC2lSu6lgqZocJkohkYi/WE= =fFJD -----END PGP SIGNATURE-----

1 0

Re: Borland C++ Buildeer under Wine
by Oliver Stieber March 14, 2005

March 14, 2005

--- Andrew Neil Ramage <nrsc16850(a)blueyonder.co.uk> wrote: > It's an old version - 3 IIRC. It starts, but the > Borland window (menu > bar across top) flickers and no other windows open. > I'll see if I've got a copy on a cover disk. CBuilder defiantly used to work. > Andrew > > > > Oliver Stieber wrote: > > --- Andrew Neil Ramage > <nrsc16850(a)blueyonder.co.uk> > > wrote: > > > >>Below is the last three lines of error messages > >>printed when I tried to > >>run Borland C++ Builder under wine. (There were > >>pages and pages of > >>error messages after I hit Ctrl-C in the terminal > I > >>had started BCB.EXE > >>from.) > >> > >>Is this a known bug in Wine ? > >> > >>err:syslevel:_EnterSysLevel (0x40797840, level 2): > >>Holding 0x4083ccc0, > >>level 3. Expect deadlock! > >>err:syslevel:_CheckNotSysLevel Holding lock > >>0x4083ccc0 level 3 > >>err:seh:setup_exception stack overflow 176 bytes > in > >>thread 0009 eip > >>004078d5 esp 405b0f50 stack 0x405b0000-0x406b0000 > >>[andrew(a)zeus BIN]$ > >> > > > > The stack overflow looks like somethings got stuck > in > > a loop, which is problably why there were pages > and > > pages of messages. > > > > What version of CBuilder are you using, CBuilder > <=5 > > used to work. > > > > > http://www.borland.com/products/downloads/download_cbuilderx.html > > CBuilder X claims to run on linux OOTB. > > > > > > I've got standard on the shelf, > > > >>-- > >> > >>Andrew > >> > >>[hackcoughsniffle] > >>Internal Virus Database corrupt > >> > >> > > > > > > Send instant messages to your online friends > http://uk.messenger.yahoo.com > > > > > Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Re: Borland C++ Buildeer under Wine
by Oliver Stieber March 14, 2005

March 14, 2005

--- Andrew Neil Ramage <nrsc16850(a)blueyonder.co.uk> wrote: > It's an old version - 3 IIRC. It starts, but the > Borland window (menu > bar across top) flickers and no other windows open. > I'll see if I've got a copy on a cover disk. CBuilder defiantly used to work. > Andrew > > > > Oliver Stieber wrote: > > --- Andrew Neil Ramage > <nrsc16850(a)blueyonder.co.uk> > > wrote: > > > >>Below is the last three lines of error messages > >>printed when I tried to > >>run Borland C++ Builder under wine. (There were > >>pages and pages of > >>error messages after I hit Ctrl-C in the terminal > I > >>had started BCB.EXE > >>from.) > >> > >>Is this a known bug in Wine ? > >> > >>err:syslevel:_EnterSysLevel (0x40797840, level 2): > >>Holding 0x4083ccc0, > >>level 3. Expect deadlock! > >>err:syslevel:_CheckNotSysLevel Holding lock > >>0x4083ccc0 level 3 > >>err:seh:setup_exception stack overflow 176 bytes > in > >>thread 0009 eip > >>004078d5 esp 405b0f50 stack 0x405b0000-0x406b0000 > >>[andrew(a)zeus BIN]$ > >> > > > > The stack overflow looks like somethings got stuck > in > > a loop, which is problably why there were pages > and > > pages of messages. > > > > What version of CBuilder are you using, CBuilder > <=5 > > used to work. > > > > > http://www.borland.com/products/downloads/download_cbuilderx.html > > CBuilder X claims to run on linux OOTB. > > > > > > I've got standard on the shelf, > > > >>-- > >> > >>Andrew > >> > >>[hackcoughsniffle] > >>Internal Virus Database corrupt > >> > >> > > > > > > Send instant messages to your online friends > http://uk.messenger.yahoo.com > > > > > Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0