March 2005 - Wine-Devel - list.winehq.org

Re: ntdll: Add NtCreateKey tests
by Robert Shearman March 3, 2005

March 3, 2005

James Hawkins wrote: >On 03 Mar 2005 11:02:24 +0100, Alexandre Julliard <julliard(a)winehq.org> wrote: > > >>James Hawkins <truiken(a)gmail.com> writes: >> >> >> >>>I've been discerning the behavior of RegCreateKey and NtCreateKey when >>>creating a key directly under HKLM or HKU, and this test reveals that >>>NtCreateKey does check for this case and returns a >>>STATUS_INVALID_PARAMETER. >>> >>> >>This is going to break registry initialisation. Do you really have an >>app that depends on that? >> >> >> > >What are the steps I need to take to break registry initialisation? I >did wonder how anything in the real win32 registry could be created >though if you can't create a key directly under HKLM or HKU. If this >really does break initialisation, can we implement a different >create_key that has little restrictions and would only be used >internally, or would this just be scrapped entirely? > > It looks like Windows only uses RegLoadKey to create keys under HKLM and HKU. Maybe we should do the same. Rob

2 4

Re: Wine cabinet.dll FDI Conformance Test Patch
by Dimitrie O. Paun March 3, 2005

March 3, 2005

On Wed, Mar 02, 2005 at 03:41:21PM -0800, Rizwan Kassim wrote: Good stuff guys! Here are a few comments: +#ifndef STANDALONE +#include <wine/test.h> +#define ok2 ok +#else +/* To build outside Wine tree, compile with cl -DSTANDALONE -D_X86_ tvfs.c cabinet_fdi.c FDI.lib + These are only called if standalone are used, defining ok and START_TEST, which would normally be declared in winetree */ +#include <assert.h> +#include <stdio.h> +#define START_TEST(name) main(int argc, char **argv) +#define ok(condition, msg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__); \ + exit(1); \ + } } while(0) +#define ok2(condition, msg, arg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__, arg); \ + exit(1); \ + } } while(0) +#define todo_wine Please get rid of this. It is useless in the Wine tree. If you need it, just put it in a private header file, and include it there. +#ifndef DEBUG_ALLOC +FNALLOC(final_alloc) { + return malloc(cb); +} +FNFREE(final_free) { + free(pv); + return; +} +#else +FNALLOC(final_alloc) { + trace(" FNALLOC just called with %d\n",cb); + return malloc(cb); +} +FNFREE(final_free) { + trace(" FNFREE just called with %d\n",pv); + free(pv); + return; +} +#endif No need for this either. It's a test after all, there's no big deal if you have a memory leak... :) +#ifdef VERBOSE + trace(" FNFDINOTIFY real just called with %d, %d \n",fdint,pfdin); +#endif Don't do it this way. Define trace such that you can use it unconditionally. In general, try to avoid using the preprocessor in the code. + trace(" Cabinet Data : cbC %d cF %d cFi %d si %d iC %d fr %d hp %d hn %d\n", + cabinfo.cbCabinet, + cabinfo.cFolders , + cabinfo.cFiles , + cabinfo.setID, + cabinfo.iCabinet, + cabinfo.fReserve , + cabinfo.hasprev , + cabinfo.hasnext ); These should fit on 2-3 lines, no? + ok2 ( cabinfo.cbCabinet == TcbCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFolders == TcFolders, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFiles == TcFiles, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.setID == TsetID, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.iCabinet == TiCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.fReserve == TfReserve, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasprev == Thasprev, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasnext == Thasnext, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); Use ok() instead of ok2(). Also, it's probably better if the message contains the values of the variables that don't match, so we know why it failed. +#ifdef TVFS_DEBUG + trace("tvfs_create called with %s, %d, %d\n", fname, buf, len); +#endif Similar to the one above, do the test inside the body of trace(), not on every use. + switch(whither) { + case SEEK_SET: { + handles[h]->pos = whence; + break; + } + case SEEK_CUR: { + handles[h]->pos += whence; + break; + } This one needs a bit of indentation, no? +int tvfs_close(int h){ + int inode = handles[h]->inode; +#ifdef TVFS_DEBUG + trace("tvfs_close called with %d\n", h); +#endif + if (!files[inode]){ + return -1; + } + free(handles[h]); + /* Currently does NOT enabled open to reuse this handle */ + return 0; + } The formatting on this is funny. It needs indenting, spaces before '{', and the opening braket for the function on a new line. +main(){ Ditto. -- Dimi.

2 1

Re: MSI trouble with ALLUSERPROFILE
by Juan Lang March 3, 2005

March 3, 2005

> I get err with %ALLUSERPROFILE during install program: <snip> > Where I will set this env variable? (I know I can do it in shell, but > what is the right way?) Hm.. I never did get this quite right. For consistency, it should be in wine.inf. That's where USERPROFILE is: HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"USERPROFILE",,"%53%" But I don't think it can go here, because setupapi (which is what interprets those funny "%53" type strings) doesn't have a magic constant for this, and there isn't a CSIDL value for it. So maybe shell32 should set it in SHELL_RegisterShellFolders? --Juan __________________________________ Celebrate Yahoo!'s 10th Birthday! Yahoo! Netrospective: 100 Moments of the Web http://birthday.yahoo.com/netrospective/

1 0

Use of STLPort with winegcc
by Boaz Harrosh March 3, 2005

March 3, 2005

Winegcc will prepend any of the command line switches with "-I wine/include/msvcrt" if the "-no-cygwin" flag is specified. This breaks STLPort because STLPort must be first on the search path, before the regular c-runtime of the compiler. This way it can do it's tricks of what to use and what not to use from the standard c-runtime. What is the current way to solve it. I could remove the "-no-cygwin" flag and Manually add the "-I wine/include/msvcrt" and "-D__MSVCRT__". But how do I add the "-dmsvcrt" on the Winebuild command line, as it is all internal to winegcc. What would be the right way to do it? I would submit a patch, but what should I do? Just append the "-I .../msvcrt" instead of prepend, or maybe use "-isystem .../msvcrt". The docs for gcc say that "-isystem" folders will be searched before the default gcc folders but after any -I folders. Free Life Boaz

2 1

Re: MSI: Radio Buttons
by Dmitry Timoshkov March 3, 2005

March 3, 2005

"Ulrich Czekalla" <ulrich.czekalla(a)utoronto.ca> wrote: > + if (control->hwnd) > + { > + WNDPROC oldproc = (WNDPROC) SetWindowLongW(control->hwnd, GWLP_WNDPROC, > + (LONG)MSIRadioGroup_WndProc); I'd suggest to use SetWindowLongPtrW even it's just a macro in Win32 we still need to write 64-bit clean code. -- Dmitry.

1 0

Speach rec. on Wine
by wino＠piments.com March 3, 2005

March 3, 2005

Hi, I am trying to get Dragon Naturally Speaking to run under Wine. I have got it installed successfully from CD, now I need to get it running. I have wine-20050111 installed , a 2.6.10 kernel and a current version of IE6 since Dragon apparently needs IE installed . Some advice please. Is there any fundemental problems which make this a no-hoper, has anyone got this working so far? Any a-priori conditions or advice I should know, like what sound model to use on Linux. Where should I search for detailed info on debugging something like this? There seems to be very little detailed help for Wine which I find surprising. Maybe I have just missed it Any other advice that could save me wasting lots of time. TIA .

2 1

Re: Add all MIME types
by Mike Hearn March 3, 2005

March 3, 2005

On Wed, 02 Mar 2005 12:56:33 +0000, Mike Hearn wrote: > Oh my god, there are a lot of these! Wouldn't it be a better long term > solution to just get the desktop environments sorted out? They should be > sharing the same MIME database now right? So why are they not all > identifying EXEs as the same MIME type? By the way, that wasn't an objection to the patch. I think it should go in. It's trivial enough and doesn't have any bad consequences except slightly less "elegance" but we can fix that one day when all the desktops are fixed :)

1 0

http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz
by Grant Williamson March 3, 2005

March 3, 2005

Hi, I am just wondering how much does the wine source located on http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz differ from 20040716. I guess its codeweavers internal patched version, I see changes in there dating to January. Are there any restrictions on using this source?

3 3

Re: imagelist: style fixes
by Alexandre Julliard March 3, 2005

March 3, 2005

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > ChangeLog > Style fixes for consistent formatting. I knew I was going to regret applying Mike's indentation patches... Folks, please let's not start an indentation police, there's no reason to "fix" anything unless a file is really so messed up that it becomes unreadable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [user/tests/sysparams.c] Added more SetLastError(0)'s
by Dmitry Timoshkov March 3, 2005

March 3, 2005

"Paul Vriens" <Paul.Vriens(a)xs4all.nl> wrote: > as discussed a few times on wine-devel, there isa need to clear the > last error before calling a SPI_{GET|SET} routine. > > It appears that not every call resets the last error to 0 on succession > and thus errors will propagate and leave us in the dark. You have to set last error to some bogus value (usually 0xdeadbeef) in order to test whether an API really has changed it. -- Dmitry.

3 2

Re: MSI: Radio Buttons
by Alexandre Julliard March 3, 2005

March 3, 2005

Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes: > const static WCHAR szStatic[] = { 'S','t','a','t','i','c',0 }; > +const static WCHAR szButton[] = { 'B','U','T','T','O','N', 0 }; > + > +const static WCHAR szButtonData = { 0 }; Did you really intend to use an empty string here for the button property? That doesn't seem right; though if you really need to redefine the winproc it would be much cleaner IMO to define a proper window class. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20 and test app
by Mike McCormack March 3, 2005

March 3, 2005

Hi Krzysztof, Krzysztof Foltman wrote: > This is an attempt at starting a RichEdit 2.0 clone, plus a test app for > it (which I, for some reason, decided to call Wine WordPad). Cool. Looks like you've done alot of good work. > It lacks most essential functionality, and source formatting is not > exactly standard, but it has enough functionality to make a couple of > Wine developers convince me to release it now. Or weeks ago. Well, you wrote it, so you get to choose the formatting. I like that you've used lots of small functions, rather than monolithic 200 line globs. I like the asserts too. > The test app uses the Mike McCormack's test snippet to fill the control > with some fancy formatted text. > > Hope the patch is OK. Adding new DLL's and EXE's isn't an easy process. OK, now some suggestions: * submitting riched20 and the new wordpad program seperately would be a good idea. The bigger the patch, the longer it tends to hang round before it's committed. * instead of #ifndef __WINESRC__ ... printf ... #endif, how about using wine's debug macros TRACE, ERR, etc? Then you can just #define TRACE to printf when __WINESRC__ isn't defined * instead of XXXFK how about FIXME? * you probably should get rid of the _int3 macro in wrap.c, and replace it with DebugBreak() * ME_DumpParaStyle isn't used... maybe change it to use MESSAGE() rather than a message box. You can dump stuff by checking the condition WINE_TRACE_ON(richedit). You'll need to declare a WINE_DEFAULT_DEBUG_CHANNEL for that.. * maybe you want to add LGPL licenses on your header files? * keep the formatting in your Makefile.in the same as the other dlls. Julliard's a bit fussy about that, so he's probably going to change it anyway. Might as well save him the time. Mike

1 0

World of Warcraft - crash in game
by Alex Woods March 3, 2005

March 3, 2005

Hi, World of Warcraft is working beautifully now apart from a crash that occurs seemingly randomly. The application is catching the crash, and giving a message like this: This application has encountered a critical error: ERROR #132 (0x85100084) Program: C:\Program Files\World of Warcraft\WoW.exe Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557102CD EAX=00000000 EBX=55BDFCA8 ECX=00000000 EDX=55BDFBB8 ESI=5E320308 EDI=00000000 EBP=55BDFC08 ESP=55BDFB9C EIP=557102CD FLG=00010212 CS =0023 DS =002B ES =002B SS =002B FS =005B GS=0063 I know this isn't really much use on it's own. I've tried turning on +relay logging, but it's proved futile - it seems to end up freezing up my system before a crash occurs. One thing that might be useful is that the access violation always seems to be around the same small area of memory each time, eg: Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557103CD Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:5571025D Over the course of 13 (unlucky for me ;)) crashes, these are the only 3 addresses it has given. My question is what can I do to debug this? +relay logging is probably infeasible, but I'd be happy to hack around to get it to only log certain things - I'm not sure what I'd need to log. Also, the last time it crashed, I was lucky enough to have it leave me in winedbg, which I've left open. Is there anything worth my while poking around with in there while I have the chance? I guess I'll be running memtest on my machine too, but I'd like to do what I can in winedbg first ;) Cheers. -- Alex

4 6

%Fp printf format specifier
by Uwe Bonnes March 3, 2005

March 3, 2005

Hallo, http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore98/H… uses a "%Fp" format spezifier. Running with native msvcrt, this seems to be the same as "%p". However builtin msvcrt stumbles about the "superfluous" 'F". Does anybody know what the meaning of the "F" is? I didn't find anything on the net. And b.t.w., how do I get Google to not ignore the '%' in a search for "%Fp"? And mingw/malloc.h has the definitions of _USEDENTRY and _FREEENTRY excahnged and misses more entries... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

6 12

MSI trouble with ALLUSERPROFILE
by Vitaly Lipatov March 3, 2005

March 3, 2005

I get err with %ALLUSERPROFILE during install program: trace:msi:MSI_FormatRecordW (L"[%ALLUSERSPROFILE]") trace:msi:deformat_string_internal Starting with L"[%ALLUSERSPROFILE]" trace:msi:find_next_outermost_key Found Key L"%ALLUSERSPROFILE" trace:msi:deformat_string_internal Current (null) .. L"%ALLUSERSPROFILE" err:msi:deformat_environment Unknown environment variable trace:msi:deformat_string_internal after everything (null) Where I will set this env variable? (I know I can do it in shell, but what is the right way?) -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Use IsWindowVisible instead of GetWindowLong(GWL_STYLE) & WS_VISIBLE as a test for desktop visibility
by Ferenc Wagner March 3, 2005

March 3, 2005

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > let's see if IsWindowVisible() better detects a not visible desktop. Ah, fine, this may put some momentum into the situation! -- Feri.

3 2

Printing in Wine (using "ttydrv" device)...
by Juergen Hammelmann March 3, 2005

March 3, 2005

Hi All, we are developing a windows/wine app for automation of MS Word (serial printing in background to PS files with the WINEPS driver on SuSE 9.2 platform, wine-20050211). We want to run this application and Word in background as server, no graphical output should occur in this environment, we don't like to install a X11-/VNC-Server on the server: Using "ttydrv" device I found out that all graphical output is disabled and wine can run without a X11 Server / VNC Server, this is prefered: but here graphical output of printing is disabled, too! The PS files created are blank! Is there any way to configure functioning printing with "ttydrv" device? Ferenc Wagner told me, that printing and graphical output is done through GDI both, so ttydrv as GDI backend disable this all!? Is this the right explanation? Is there any way to enable this for printing again? Best Regards, Jürgen

1 0

Visual C++ 6.0 as a Winelib IDE?
by Ira Krakow March 3, 2005

March 3, 2005

I have Visual C++ 6.0 running under Crossover Office 4.1, which of course means it's running under Wine. For one of the examples in the Wine/Winelib book, I decided to take the code produced by the VC++ Win32 "Hello World" wizard and see how to port it to Wine. Turns out, it's almost trivial. Create an empty directory, copy the *.c, *.rc, *.h, and *.ico files to it. VC++ produces tons of other files, but they're either used to maintain the Visual Studio environment, or are intermediate compilation files that aren't needed. Then run: $ winemaker . The Makefile that Winemaker generates _almost_ works. You need to delete the references to the mfc library and mfc.dll. After doing that, running make generates the .so file. Wine runs it flawlessly. I got to thinking - can I convert the code from the MFC application as easily? Seems like it's doable, because the generated code runs in VC++/Crossover Office 4.1. I tried the same steps as before, with Winemaker, but I couldn't figure out what Makefile modifications were needed. All of this got me to thinking - could Wine running Visual C++ be a viable IDE for porting? Maybe just linking VC++ with the Winelib libraries would do it. Maybe after tweaking Winemaker and publishing a HOWTO we could show that this is a viable path? It's certainly easier than for Visual Studio developers and could help attract them to Wine. Another benefit - we could use the Visual C++ sample programs as tests for Wine. The programs might exercise areas that haven't been tested thoroughly. What do you think? Ira

5 6

wine-user.pdf feedback
by Dan W. March 2, 2005

March 2, 2005

I think I have the answer why feedback to the wine-user.pdf has so far been disappointing: It's too well written. No questions to ask, almost. Actually, probably 90% of users try to get by without reading it. I saw a posting somwhere today, someone advising someone else about running the wine install, without mentioning uninstalling any old versions. The blind leading the blind. You need to put a big README!!!.TXT file somewhere, where it should say: "You choose: Spend 1 day reading wine-user.pdf, and another day setting it up; or spend a week trying to set it up, a month asking questions at the forums, a year in depression, then finally a day reading wine-user.pdf, and another day setting it up." But probably, the lucky 10% who read it never have any questions, so you don't hear from them. In my case, though, combining a high IQ and being a complete helpless newbie to Linux, is a powerful combination that produces questions out of nowhere. In the chapter about installing and un-installing, one small detail got left out: "How does one KNOW whether wine is installed, and if so what version it is?" I'm sure it must sound like typical newbie crap questions to you, but to me it's a solid and tangible one. Well, I do know that I do have wine installed, because when I installed Fedora Core 2, I said "install everything". Besides, I tried.. "wine /mnt/C/windows/notepad.exe" and it worked!!!! :-) :-) :-) But as for the version of wine I have, I have no idea how to find out. In Windows, I'd check the Add/remove programs, to see if it mentions the version, or I'd look in the installation folder for a readme.txt file. In Linux, not so easy: Even after doing a file search for "wine", I still can't tell what folder it is installed in, if indeed it is installed in ONE folder, and not many. Looks like many, by the looks of it... Or at least two: One under /usr/local, which only contains two files, another for documentation, elsewhere, and I saw a folder somewhere with alotof.dll.so files. Anyways, thank you for the great work you've done and are doing. Some day Historians will remember you like today we remember Leonardo, or whoever: How Humanity rid itself of a great monopoli threat. As newbie as I am in Linux, I'm the expert here at work. If I can get our Windows apps to run on Linux, I might succeed at having the company switch over. Wish me luck.

3 2

vartest.c - major pain in the build process
by Krzysztof Foltman March 2, 2005

March 2, 2005

Is there any reason for gcc 3.3.1 to spend several minutes on compiling dlls/oleaut32/tests/vartest.c ? I guess it can be explained by optimization stage going nuts on compiling long functions with many branches (contained in the macros), but there must be a way to speed this up. It's barely tolerable now, and upgrading gcc is not an option for everyone. Krzysztof

9 23

user/tests/sysparams.c : test_SPI_SETKEYBOARDPREF on win98
by Paul Vriens March 2, 2005

March 2, 2005

Hi, I saw this test was recently added. It fails partly on my win98 box as this registry has the values in a different place. WinXP: [HKEY_CURRENT_USER\Control Panel\Accessibility\Keyboard Preference] "On"="0" Win98: [HKEY_CURRENT_USER\Control Panel\Accessibility] "Keyboard Preference"="0" What's the best(tm) way to cater for both? Just use: SPI_SETKEYBOARDPREF_REGKEY and SPI_SETKEYBOARDPREF_WIN98_REGKEY for example and have the test check the windows version? Or change test_reg_key to cope with 2 different sets? Cheers, Paul.

1 0

Re: Dump HeapWalk entries
by Dimitrie O. Paun March 2, 2005

March 2, 2005

On Wed, Mar 02, 2005 at 05:52:45PM +0100, Uwe Bonnes wrote: > + if ((entry->wFlags & PROCESS_HEAP_ENTRY_BUSY ) > + && (entry->wFlags & PROCESS_HEAP_ENTRY_MOVEABLE)) > + { > + /* Treat as block */ > + DPRINTF( "BLOCK->hMem\t\t:%08lx\n", (DWORD)entry->u.Block.hMem); > + } Please don't introduce _another_ style of brackets, just use the one that's used in the file. Should be either: if (....) { .... } or if (....) { .... } -- Dimi.

1 0

DPLAYX_ConstructData error during tools/wineinstall
by Paul Vriens March 2, 2005

March 2, 2005

Hi, I don't know when it started and if found I wasn't able to reproduce, but this is the message I sometimes get during a tools/wineinstall on a clean cvs install: Configuring Wine for a no-windows install in /data/wine-c... err:dplay:DPLAYX_ConstructData : unable to map static data into process memory space (487) /home/paul/.wine updated successfully. I can only say that I noticed this the last few (3?) weeks or so and haven't before. The first time I saw it, I did some regression testing, but as said, I wasn't able to reproduce at will. Is this a problem or can it be ignored (although it's an err). Or better yet, what could be the cause. Cheers, Paul.

1 0

CVS SERVER OUT OF SPACE?
by Oliver Stieber March 2, 2005

March 2, 2005

Hi, It looks like cvs server has run out of diskspace. cvs update reports. cvs server: Updating . cvs server: failed to create lock directory for `/home/wine/wine' (/home/wine/wine/#cvs.lock): No space left on device cvs server: failed to obtain dir lock in repository `/home/wine/wine' cvs [server aborted]: read lock failed - giving up Send instant messages to your online friends http://uk.messenger.yahoo.com

4 5

Re: [winedbg] Get expressions working again.
by Pouech Eric DMI AEI CAEN March 2, 2005

March 2, 2005

I don't think this patch should go in as it is: - I don't think it's a good idea to have two ways to express a pointer type in the debugger (one being the standard dbghelp's SymTagPointerType, the other one the new deref count you've introduced). It would be better to add dynamic winedbg types (in the contrary to the static one's we already use dbg_itype_*), when we cannot find one in a module. - the returned string (for internal types' name) should be HeapAllocate:d, not a static buffer - please, use the current style for parenthesis, braces... and don't add a new one A+ > Message du 01/03/05 18:28 > De : "Oliver Stieber" > A : wine-patches(a)winehq.com > Copie à : > Objet : [winedbg] Get expressions working again. > > Hi, > This patch starts to get expressions working again and > also allows derefrencing where there is no explicit > type for that dereference. e.g. > > (short)0x12356 now returns the correct value instead > of an error > > *((int *)0x23467) is now a valid expression. > and > ***((int ***)0x23467) should also work properly. > > This should also fix watches with expressions but I > haven't given it much testing. > > Send instant messages to your online friends http://uk.messenger.yahoo.com > > [ winedbg_expressions_os_1.patch (18.4 Ko) ]

2 1

Re: Add all MIME types
by Mike Hearn March 2, 2005

March 2, 2005

Scott Ritchie wrote: > -MimeType=application/x-ms-dos-executable > +MimeType=application/x-ms-dos-executable;application/x-msdos-program;application/x-msdownload;application/exe;application/x-exe;application/dos-exe;vms/exe;application/x-winexe;application/msdos-windows;application/x-msdos-program;application/x-zip-compressed > NoDisplay=true Oh my god, there are a lot of these! Wouldn't it be a better long term solution to just get the desktop environments sorted out? They should be sharing the same MIME database now right? So why are they not all identifying EXEs as the same MIME type? thanks -mike

1 0

Re: Ignore msi/version.res
by Alexandre Julliard March 2, 2005

March 2, 2005

Francois Gouget <fgouget(a)codeweavers.com> writes: > Francois Gouget <fgouget(a)codeweavers.com> > Ignore version.res. version.res is no longer generated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Help with winebuild/winegcc
by Ivan Leo Puoti March 2, 2005

March 2, 2005

Hello, I'm trying to get a program in the programs/ directory to export symbols, I've added -shared path/to/spec/spec.c to the linker command, but I now get a segmentation fault at startup. Can someone knowledgeable about winegcc/winebuild give me a suggestion/solution? I'm really stuck because of this and can't get on with safedisc support. Ivan.

2 2

re: gcov and Wine (was: Re: Wine cabinet.dll FDI Conformace Test Patch)
by Dan Kegel March 2, 2005

March 2, 2005

Mike Hearn wrote: > By the way, I talked to Alexandre about the GCOV stuff, basically he wants > us to find out why arc profiling borks the preloader. Then the idea is it > can be enabled just using CFLAGS. (You're confusing the UCLA guys with the Harvey Mudd guys, Mike!) Here's what aarvey(a)cs.hmc.edu wrote when he ran into the problem: > make[1]: Entering directory `/home/aarvey/winefromwinehqcvs/wine.patched/loader' > gcc -o wine-preloader -static -nostartfiles -nodefaultlibs -Wl,-Ttext=0x78000000 preloader.o -L../libs/port -lwine_port > preloader.o(.text+0x1929): In function `_GLOBAL__I_wld_startGCOV': > /home/aarvey/winefromwinehqcvs/wine.patched/loader/preloader.c:955: undefined reference to `__bb_init_func' > collect2: ld returned 1 exit status > make[1]: *** [wine-preloader] Error 1 > make[1]: Leaving directory > `/home/aarvey/winefromwinehqcvs/wine.patched/loader' > make: *** [loader] Error 2 > > I can compile the preloader just dandy as long as I get rid of the extra > compile flags (-ftest-coverage and -fprofile-arcs). You could provide a dummy implementation of __bb_init_func in the preloader, but that's uglier IMHO than just not passing those options when compiling the preloader. Mike also asked: > Until that happens though are you generating lcov output anywhere? Not yet, but I'll ask them to start doing periodic LCOV runs and putting them up on the web. I'd like to see this be a regular feature at winehq.org, not sure what the logistics would be. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Re: Add new "nrelay" debug channel - useful for debugging GPFs in target applications
by Andreas Mohr March 2, 2005

March 2, 2005

Hi, On Wed, Mar 02, 2005 at 04:09:36PM +1100, Troy Rollo wrote: > The nrelay ("native relay") debug channel acts to limit the output of the > relay debug channel, and only works if the relay debug channel is also on. > When "nrelay" is on, "relay" will not log calls made from one built-in > library to another built-in library, or within a built-in library. Thus each > call logged is a call made directly by the target application or by one of > the native DLLs it depends on. Yay!! Thanks a lot! This one is VERY important, since developer confusion by overwhelmingly big and mostly less useful relay logs in recent years has grown a lot, I'd say. One suggestion: maybe make *only* logging external relays the default, and add a wrelay channel to add back the logging of Wine inter-dll calls? This might make more sense even, since you're often not interested at all in Wine interactions, but what the target app does. Any suggestions about the average percentage where people are interested in app-only calls as opposed to a full relay log? That would then tell us which way to implement this limiting. I'm not sure about the percentage, since I haven't done much development in recent years. Andreas Mohr

2 1

Re: USER32: Sysparams unit tests fixes and additions
by Paul Vriens March 2, 2005

March 2, 2005

On Tue, 2005-03-01 at 05:53, jchevrier(a)nexicom.net wrote: > Changelog: > > * Created SPI_{GET,SET}KEYBOARDPREF and SPI_{GET,SET}SCREENREADER unit tests > * Removed a trace that shouldn't have been there > * Add return checking to SPI_{GET,SET}WHEELSCROLLLINES and > SPI_{GET,SET}MENUSHOWDELAY unit tests so they no longer run on Windows 95 > where they aren't supported > * Changed minimum hovertime in SPI_{GET,SET}MOUSEHOVERTIME to 10 as Windows XP > defaults to 10 any value below that Hi, the extra trace was my doing :-(. I've added this and after that I realized that SPI_{GET|SET} doesn't clean the LastError after a correct call. That's why I think it's necessary to do a SetLastError(0) before every check of GetLastError. That's the reason I had these failures on win98 and SPI_GETICONTITLEWRAP. The Error was still set by one of the previous called functions (I think a ..W call, the ..A call was fine). That still leaves us with the questions, whether it would be good to check for ERROR_CALL_NOT_IMPLEMENTED after each call? Cheers, Paul Vriens.

2 1

Re: [wined3d] texture interface separation.
by Oliver Stieber March 2, 2005

March 2, 2005

> wrote: > > > > Hi, > > > > This patch start to separate the interfaces > in > > > > wine3d3. Complete separation requires > > > queryInterface > > > > support which I'll send through soon, this > patch > > > has > > > > no dependencies but provides the final > interface > > > > needed by later revisions. > > > > > > > Hi Oliver, > > > > > > this patch couldn't be applied cleanly to CVS. > Just > > > to let you know, I > > > didn't check further. > > > > > > I'm wondering if AJ will have many comments on > the > > > patches. I hope not > > > as your work is going to make a lot of people > happy. > > It's a diff against CVS. But I think you need a diff > against CVS + your > previous patch. Or am I missing something ? > The patches aren't incremental, that way one can fail but it shouldn't affect the rest being merged. I have another couple of discrete patches to send in then the patches become dependant on some of the interface changes, but hopefully not the underlying functionality changes. I also don't have enough HDD space to keep incremental versions and check that they compile/work especially with all the interface/include changes. If anyone knows of a good tool for managing patches let me know (not cerversa!), there's a surprising lack of tools available. at the moment I'm using the following... #!/bin/bash #given a file, replace the first path with a new path #diff the two files stripedpath=$(echo $1 | grep -o "/.*") kdiff3 $1 "$2/$stripedpath"& kwrite $1 & kwrite "$2/$stripedpath"& -- diffdueo clean/wine/.... working Very 21st century. A tool for merging would be good too, e.g. merge patch1.patch patch2.patch > patch_merged.patch. if one doesn't exist I'll write it and put it on my site. Send instant messages to your online friends http://uk.messenger.yahoo.com

2 6

Re: [PATCH] Added 2 functions to shell32
by Jacek Caban March 1, 2005

March 1, 2005

> I doubt shell32 function on windows does this check, also original windows shell32 > function is a lot more complicated and longer, I've compared the results between > real and my code and they are correct. I wrote a small test for this function showing that your implementation is almost correct. It failes in two cases: 1. If a path ends with '\' and is compared with one that doesn't, then it's length is less than the other one, but both are the same paths. 2. If a path doesn't end with '\' and is compared with a longer one that has the same first len chars, but is not the same, ex: c:\test c:\test123 Changelog: Added test for PathIsEqualOrSubFolder Index: dlls/shell32/tests/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shellpath.c,v retrieving revision 1.6 diff -u -p -r1.6 shellpath.c --- dlls/shell32/tests/shellpath.c 10 Feb 2005 19:19:35 -0000 1.6 +++ dlls/shell32/tests/shellpath.c 28 Feb 2005 21:19:31 -0000 @@ -871,6 +871,55 @@ static void testNonExistentPath(void) userShellFolders); } +typedef BOOL (WINAPI*fnPathIsEqualOrSubFolder)(LPCWSTR path1, LPCWSTR path2); + +static void test_PathIsEqualOrSubFolder() +{ + fnPathIsEqualOrSubFolder pPathIsEqualOrSubFolder; + BOOL ret; + static const WCHAR path1[] = {'c',':','\\','t','e','s','t',0}; + static const WCHAR path2[] = {'c',':','\\','t','e','s','t','\\','t','e','s','t',0}; + static const WCHAR path3[] = {'c',':','\\','t','e','s','t','1','2','3',0}; + static const WCHAR path4[] = {'c',':','\\','t','e','s','t','\\',0}; + static const WCHAR path5[] = {'c',':','\\','t','e','s','t','\\','t','e','s','t','2', + '\\','.','.','\\','t','e','s','t',0}; + + pPathIsEqualOrSubFolder = GetProcAddress(hShell32, (LPSTR)755); + if(!pPathIsEqualOrSubFolder) + return; + +#define TEST_PATH(p1, p2, r) \ + ret = pPathIsEqualOrSubFolder(p1, p2); \ + ok(ret == r, "PathIsEqualOrSubFolder(" #p1 " " #p2 ") failed, expected: %x\n", r); + + TEST_PATH(path1, path1, TRUE); + TEST_PATH(path1, path2, TRUE); + TEST_PATH(path1, path3, FALSE); + TEST_PATH(path1, path4, TRUE); + TEST_PATH(path2, path1, FALSE); + TEST_PATH(path2, path2, TRUE); + TEST_PATH(path2, path3, FALSE); + TEST_PATH(path2, path4, FALSE); + TEST_PATH(path3, path1, FALSE); + TEST_PATH(path3, path2, FALSE); + TEST_PATH(path3, path3, TRUE); + TEST_PATH(path3, path4, FALSE); + TEST_PATH(path4, path1, TRUE); + TEST_PATH(path4, path2, TRUE); + TEST_PATH(path4, path3, FALSE); + TEST_PATH(path4, path4, TRUE); + TEST_PATH(path5, path1, FALSE); + TEST_PATH(path5, path2, FALSE); + TEST_PATH(path5, path3, FALSE); + TEST_PATH(path5, path4, FALSE); + TEST_PATH(path5, path5, TRUE); + TEST_PATH(NULL, path1, FALSE); + TEST_PATH(path1, NULL, FALSE); + TEST_PATH(NULL, NULL, FALSE); + +#undef TEST_PATH +} + START_TEST(shellpath) { if (!init()) return; @@ -892,5 +941,6 @@ START_TEST(shellpath) testWinDir(); testSystemDir(); testNonExistentPath(); + test_PathIsEqualOrSubFolder(); } }

3 2

New uninstaller
by Jonathan Ernst March 1, 2005

March 1, 2005

As requested, I'm trying to make a new uninstaller using a dialog instead of a window. It's my first windows program and I have something working but there are still some issues. If someone could help with some of the following problems, I'd be very thanfull. 1) Strange problem with UpdateWindow uninstaller.c, line 264 I implemented a search/filter field and I want to repaint the window after each input in the EDITTEXT control. However, when I call UpdateWindow on this line, the value returned is 1 so that a WM_PAINT message should be sent right ? But strangly no message is sent and I have to make something else (like moving the dialog) to force the window to repaint and filter the entries. The funny thing is that UpdateWindow on line 279 works just fine. I guess it's a bug in my code and not in Wine so I'd be glad if you could help me. 2) Improve filter code Currently I filter the entries that match exactly the filter string. I would like to at least make a case insensitive strstr on the string. What's the best way to do it (See uninstaller.c, line 235) 3) Stringtables a)Is there a way to load localized strings without having to guess beforehand the size of the string in each language ? b)Is there a way to not call LoadString for each string ? c)Where is the best place to load every string of a stringtable ? in main(), just before calling DialogBox() ? 4) Please tell me if you see things that are bad in the attached code, so that I'll fix it before submitting a patch. Thanks you for your help

7 13

Regression in Rebar
by Maxime Bellengé March 1, 2005

March 1, 2005

Hello This patch is causing a regression in emule, the rebar simply does not display. a+ Maxime Modified files: dlls/comctl32 : rebar.c Log message: Robert Shearman <rob(a)codeweavers.com> - Make row number be zero-based. - Improvements to dumping functions to not dump out fields that may not have been filled in.

2 4

Tools for identifying what a DLL provides?
by David D. Hagood March 1, 2005

March 1, 2005

I have a DLL from a manufacturer that I don't have the source for, nor do I have the header or the import library for. Since Wine developers frequently have to reverse engineer what a given DLL provides, does anybody have a good recommendation for a tool that can scan the DLL and report what functions it exports, and their arg types and return types?

4 4

Re: [wined3d] texture interface separation.
by Oliver Stieber March 1, 2005

March 1, 2005

2 1

Re: Wine cabinet.dll FDI Conformace Test Patch
by Daniel Kegel March 1, 2005

March 1, 2005

Andreas wrote: > It's an unspoken rule that preprocessor directives (#ifdef, ...) > always start at the very beginning of a line to make sure one recognizes > immediately which parts of the code are being processed and which ones aren't. Good point. I should have caught that style violation when I reviewed their code for them this weekend. > AFAICS you're not using wine test suite infrastructure, e.g. ok() etc. > > Using printf() directly strikes me as being quite bad, too... I think they're using the wine test infrastructure properly everywhere. The only exception is the disabled self-test in tvfs.c, but I think that's fine. It's not even built, it was just used while developing the test harness. > Apart from that it appears to be very good. Cool! - Dan

2 1

Re: winedbg questions
by Pouech Eric DMI AEI CAEN March 1, 2005

March 1, 2005

> I'm trying to use winedbg to run the direct sound regression > tests and have two questions: > > Execution stops when starting the first dsound.dll thread. Is > this normal? Is the stack trace with no symbol information > normal? no, because of this in your trace Couldn't initiate DbgHelp the only reason this fails is because dbghelp cannot get to the wine-loader in the running programm try to set the env var WINELOADER to the {pk}loader (full path) you're using and check again A+

1 0

winedbg questions
by Robert Reif March 1, 2005

March 1, 2005

I'm trying to use winedbg to run the direct sound regression tests and have two questions: Execution stops when starting the first dsound.dll thread. Is this normal? Is the stack trace with no symbol information normal? Typing c continues to the exception I am interested in but the stack trace has no symbolic information. This is with a modified dsound.dll that does zeroing of memory before freeing. An unmodified dsound.dll stops at the start but does not get the second exception. This is with a standard RH9 with up to date erratas and this mornings cvs. typescript log attached. Why is winedbg stopping at the first thread creation? Why is there no symbolic stack information? [wine(a)dell tests]$ WINEDEBUG=+wave,+dsound,+tid winedbg "dsound_test.exe.so dsound" WineDbg starting on pid 0xa Couldn't initiate DbgHelp 000b:trace:wave:OSS_WaveInit () 000b:trace:wave:OSS_WaveOutInit (0x41765960) /dev/dsp 000b:trace:wave:OSS_OpenDevice (0x41765960,1,(nil),0,-1,-1,ffffffff) ... 000b:warn:wave:OSS_RawOpenDevice Couldn't open /dev/dsp5 (No such device) 000b:trace:wave:OSS_widMessage (0, DRVM_INIT, 00000000, 00000000, 00000000); 000b:trace:wave:OSS_widMessage (0, WIDM_GETNUMDEVS, 00000000, 00000000, 00000000); 000b:trace:wave:OSS_wodMessage (0, DRVM_INIT, 00000000, 00000000, 00000000); 000b:trace:wave:OSS_wodMessage (0, WODM_GETNUMDEVS, 00000000, 00000000, 00000000); 000b:trace:dsound:DllMain (0x40870000 0x1 0x1) 000b:trace:dsound:DllMain DLL_PROCESS_ATTACH 000f:trace:dsound:DllMain (0x40870000 0x2 (nil)) 000f:trace:dsound:DllMain DLL_THREAD_ATTACH In 32 bit mode. 0x40471f77: pushl %esi Wine-dbg>bt Backtrace: =>1 0x40471f77 (0x4085fff4) 2 0x400298f5 (0x00000000) Wine-dbg>c dsound.c:167:Testing IDirectSound 000b:trace:dsound:DSOUND_DllGetClassObject ({47d4d946-62e8-11cf-93bc-444553540000},{00000001-0000-0000-c000-000000000046},0x4085fe30) 000b:trace:dsound:DSCF_AddRef (0x408a586c) ref was 1 000b:trace:dsound:DSCF_CreateInstance (0x408a586c)->((nil),{279afa83-4981-11ce-a521-0020af0be560},0x4085fe6c) 000b:trace:dsound:DSOUND_Create ((null),0x4085fe6c,(nil)) ... 000b:trace:wave:wodOpen OSS_OpenDevice returned this format: 22050x8x2 000b:trace:wave:wodOpen got 32 2048 byte fragments (46 ms/fragment) 000b:trace:wave:wodOpen fd=16 fragstotal=32 fragsize=2048 BufferSize=65536 001a:trace:wave:wodPlayer_ProcessMessages calling ExitThread() 001a:trace:dsound:DllMain (0x40870000 0x3 (nil)) 001a:trace:dsound:DllMain DLL_THREAD_DETACH First chance exception: page fault on read access to 0x00000000 in 32-bit code (0x401a0d88). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0033 GS:005f EIP:401a0d88 ESP:419d4528 EBP:419d4540 EFLAGS:00210293( - 00 RISA1C) EAX:00000008 EBX:401d63c4 ECX:00000001 EDX:402f0038 ESI:00000000 EDI:00010000 Stack dump: 0x419d4528: 00000000 00000000 00000000 401d63c4 0x419d4538: 402f0000 00010000 419d456c 401a1819 0x419d4548: 402f0000 00010000 419d455c 00000000 0x419d4558: 402f0000 00000000 405036c8 00010000 0x419d4568: 00000000 419d4584 40457b3a 402f0000 0x419d4578: 00000002 00010000 405036c8 419d45b0 Backtrace: =>1 0x401a0d88 (0x419d4540) 2 0x401a1819 (0x419d456c) 3 0x40457b3a (0x419d4584) 4 0x404561d7 (0x419d45b0) 5 0x404562bd (0x419d45d0) 6 0x404918f5 (0x419d45e4) 7 0x4045ace9 (0x419d45fc) 8 0x4045b07b (0x419d4608) 9 0x4043a0e8 (0x419d4638) 10 0x401a2c9a (0x419d4650) 11 0x401a3dd3 (0x419d46c0) 12 0x401a41a3 (0x419d46e8) 13 0x40486c8f (0x419d47b8) 14 0x401ba077 (0x419d4ff4) 15 0x401116c7 (0x00000000) 0x401a0d88: movl 0x0(%esi),%eax Wine-dbg>q WineDbg terminated on pid 0xa

1 0

Re: wine/dlls/comctl32 status.c
by Thomas Weidenmueller March 1, 2005

March 1, 2005

Alexandre Julliard wrote: >Log message: > Filip Navara <navaraf(a)reactos.com> > Implement SB_SETBORDERS. > > Just FYI: Win95, 98, 98SE, ME, NT4, NT5.0, NT5.1 and later do not support this message even though MS Office might try to use them. Best Regards, Thomas

1 0

Re: Patch for wsock32 conformance test
by Alexandre Julliard March 1, 2005

March 1, 2005

Thomas Kho <thomaskho(a)gmail.com> writes: > We're working on a set of tests for wsock32.dll with guidance from Dan > Kegel. So far we've > completed a test of blocking network I/O with multiple threads. > Attached is a patch from our efforts. We look forward to suggestions. This stuff should be merged with the other winsock tests in dlls/winsock/tests/sock.c (assuming it does something that the current tests don't, I haven't checked this). There is no point in having duplicate tests for wsock32 since it just forwards everything to ws2_32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [programs/regedit] Use Favorit* instead of Favourit*
by Robert Shearman March 1, 2005

March 1, 2005

Paul Vriens wrote: >Hi, > >Our regedit displays Favourites in the menu. This patch changes that to >use Favorites. The patch also changes the variables with FAVOURITE in >the name. The reasoning is: > >a. Windows uses Favorite(s) all over the place. >b. We do too. > >That's the only reasoning and not if either one is better (UK/US etc..) > >No functional changes btw. > >Changelog > Change Favourite(s) into Favorite(s) > > Fair enough for strings in the English, US resources, as long as the strings in the English, Neutral resources are still spelt correctly. > Change variables containing FAVOURITE into FAVORITE > > Why do this? Rob

2 1