June 2005 - Wine-Devel - list.winehq.org

List settings
by Robert Lunnon June 7, 2005

June 7, 2005

It appears the mailing list isn't quite right. When I reply-all I seem to get the list twice, once as recipient and once as CC, can this be fixed ? This seems to be affecting more than just me. Bob

5 6

Re: ViaVoice (98) in Wine
by René Rebe June 7, 2005

June 7, 2005

Hi, On Tuesday 07 June 2005 02:37, you wrote: > >No problem - a log with my normal setup, and one without the module for > > the 10 channel card loaded attached (I wanted to see for myself if that > > makes a significant difference in the behaviour of Wine). > > > >Yours, > > OSS thinks your sound card doesn't support volume control on the input. > Not much you can do about that. I assume this is OSS on ALSA? Then it's > an ALSA OSS emulation issue (assuming the card really does support it). > The peak meter issue is not a problem because most drivers don't support > it. > > Does the software really refuse to work because of no record volume > control? That shouldn't be a fatal error. Maybe - since ViaVoice is quite agressive to tweak the microphone gain ... Have you seen the invalid handle in the log? trace:msacm:acmDriverDetailsA ((nil), 0x504840, 00000000) trace:msacm:acmDriverDetailsW ((nil), 0x77a7eebc, 00000000) trace:msacm:acmDriverOpen (0x77a7e3e4, (nil), 00000000) warn:msacm:acmDriverOpen invalid handle trace:msacm:acmDriverOpen (0x504c94, (nil), 00000000) warn:msacm:acmDriverOpen invalid handle Maybe via voice fails due to that ... at least it matches what I found in the speech engines log (oh - I mistyped the wine list address of the mail containing this information, yesterday - resent it now): AudMME: Set Audio Input --------------------------------- [Jun 06 12:29:1 2005] Using record device # 0 which is a Analog Devices AD1980 AUDMME will use device # 0 for recording AUDMME will use device # 0 for playback PCM Device WAV Audio Adapter Default Record Device WAV Audio Default Playback Device WAV Audio Adapter acmDriverDetails failed, rc = 5 acmDriverOpen failed, rc = 5 acmDriverDetails failed, rc = 5 acmDriverOpen failed, rc = 5 Alphabet/Language/Codepage: R Gr_GR 850 a returncode of 5 seems to be: #define MMSYSERR_INVALHANDLE (MMSYSERR_BASE + 5) Yours, -- René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany) http://www.exactcode.de | http://www.t2-project.org +49 (0)30 255 897 45

2 1

ViaVoice (98) in Wine
by René Rebe June 7, 2005

June 7, 2005

Hi all, over the weekend I tried to get ViaVoice (98) running in Wine (20050524). The installation goes smooth - even the embedded videos how to handle the microsfone, etc. are displayed ,-) However after the installation some "audio setup" tool is run to adjust the mixer level and maybe more like capture channel. This tools does just print an error that it can not find "mixer elements / devices" (translation from the german text I had on screen). I tried a few install and wine config variations, including switching from OSS to ALSA - however without success. I then tried to copy my trained profile from a real Windows box in order to skip this audio setup stuff. However the real applications then also complain about no mixer found. Capturing from my mic with some "proof of concept" and tiny audio recorder as shipped with ViaVoice (snwave.exe IIRC) did work. Injecting all the windows partition content into the wine folder did also not help. Are there some holes in some kind of mixer interface implementation? Is there some kind of tracing I can enable in order to take a look what kind of call did fail? Any help appreciated. Yours, -- René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany) http://www.exactcode.de | http://www.t2-project.org +49 (0)30 255 897 45

4 8

SetTextJustification() fix
by Keith Dunwoody June 7, 2005

June 7, 2005

Hi, A little while ago I sent a fix for bug #50 (PrgWin95: Text justification needs beefing up), in which SetTextJustification() wasn't spacing text lines out properly. I was wondering why my patch was rejected. Thanks, -- Keith __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 3

Re: Resubmit SetWindowTextA() patch
by Mike McCormack June 7, 2005

June 7, 2005

Jason Campbell wrote: > +/* > FIXME( "cannot set text %s of other process window %p\n", > debugstr_a(lpString), hwnd ); > SetLastError( ERROR_ACCESS_DENIED ); > return FALSE; > +*/ > + FIXME( "not allowed by MSDN but some apps programmed this way" ); > } > return (BOOL)SendMessageA( hwnd, WM_SETTEXT, 0, (LPARAM)lpString ); > } Hi Jason, I think the fixme is not Wine enforcing a limitation imposed by MSDN, but preventing a problem from occuring because it's not supported properly by Wine, so though the above may work for a few applications, it doesn't seem like a solution that will work for everything. To do this the "right way" you'd need to write a test case to show what happens on Windows when somebody tries to set the title of another window. If this now works, you shouldn't just comment out the code in the if() statement, but instead remove the if() statement and FIXME all together. I suspect that it won't work correctly if the window has a visible caption bar. Mike

2 2

Summer of Code applications so far
by Dan Kegel June 6, 2005

June 6, 2005

Google hasn't sent out any applications to the mentoring organizations (e.g. Wine) yet, but they did just release a breakdown of the number of proposals recieved for each project. The count for Wine is at 77! No idea how many of those will make it through the selection process, but at least a few ought to be good. Here's the full breakdown from http://groups-beta.google.com/group/summer-discuss/msg/fd9e7ed643a3514d : 424 google 263 asf 213 gnome 209 gaim 204 other 156 psf 156 mono 126 ubuntu 90 freebsd 84 nmap 78 gallery 77 wine <------ 58 mambo 53 kde 49 svn 40 tpl 39 internet2 37 oo 35 fedoracore 33 lj 32 drupal 31 mozdev 29 handhelds 26 blender 25 winlibre 23 netbsd 23 codehaus 21 samba 21 jxta 18 xwiki 16 inkscape 15 plg 15 horde 14 semedia 13 jabber 12 asterisk 10 lispnyc 7 monotone 5 psu 5 oscar 5 ohiolink 5 bricolage TOTAL: 2795 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [QUARTZ] More fixes
by Robert Shearman June 6, 2005

June 6, 2005

Christian Costa wrote: >Index: dlls/quartz/parser.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/parser.c,v >retrieving revision 1.16 >diff -u -r1.16 parser.c >--- dlls/quartz/parser.c 6 Jun 2005 19:50:36 -0000 1.16 >+++ dlls/quartz/parser.c 6 Jun 2005 20:48:12 -0000 >@@ -221,6 +221,8 @@ > > TRACE("()\n"); > >+ if (This->state == State_Stopped) return S_OK; >+ > EnterCriticalSection(&This->csFilter); > { > hr = PullPin_StopProcessing(This->pInputPin); >@@ -239,6 +241,8 @@ > > TRACE("()\n"); > >+ if (This->state == State_Paused) return S_OK; >+ > EnterCriticalSection(&This->csFilter); > { > bInit = (This->state == State_Stopped); > > > These changes aren't thread safe. You should do the comparisons inside of the critical section. -- Rob Shearman

1 0

[RESEND] [d3d] Light management API test cases
by Antoine Chavasse June 6, 2005

June 6, 2005

ChangeLog: - Test cases for the direct3d7 light api. Index: dlls/ddraw/tests/.cvsignore =================================================================== RCS file: /home/wine/wine/dlls/ddraw/tests/.cvsignore,v retrieving revision 1.3 diff -u -p -r1.3 .cvsignore --- dlls/ddraw/tests/.cvsignore 30 May 2005 11:11:34 -0000 1.3 +++ dlls/ddraw/tests/.cvsignore 6 Jun 2005 18:13:18 -0000 @@ -1,4 +1,5 @@ Makefile ddrawmodes.ok dsurface.ok +d3d7light.ok testlist.c Index: dlls/ddraw/tests/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/ddraw/tests/Makefile.in,v retrieving revision 1.4 diff -u -p -r1.4 Makefile.in --- dlls/ddraw/tests/Makefile.in 30 May 2005 11:11:34 -0000 1.4 +++ dlls/ddraw/tests/Makefile.in 6 Jun 2005 18:13:18 -0000 @@ -3,11 +3,12 @@ TOPOBJDIR = ../../.. SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = ddraw.dll -IMPORTS = ddraw user32 gdi32 kernel32 +IMPORTS = ddraw dxguid user32 gdi32 kernel32 CTESTS = \ ddrawmodes.c \ - dsurface.c + dsurface.c \ + d3d7light.c @MAKE_TEST_RULES@ --- /dev/null 1970-01-01 01:00:00.000000000 +0100 +++ dlls/ddraw/tests/d3d7light.c 2005-06-06 20:10:12.998103616 +0200 @@ -0,0 +1,185 @@ +/* + * Some unit tests for direct3d7 light functions + * + * Copyright (C) 2005 Antoine Chavasse (a.chavasse(a)gmail.com) + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <assert.h> +#include "wine/test.h" +#include "ddraw.h" +#include "d3d.h" + +static LPDIRECTDRAW7 lpDD = NULL; +static LPDIRECT3D7 lpD3D = NULL; +static LPDIRECTDRAWSURFACE7 lpDDS = NULL; +static LPDIRECT3DDEVICE7 lpD3DDevice = NULL; + +static void CreateDirect3D() +{ + HRESULT rc; + DDSURFACEDESC2 ddsd; + + rc = DirectDrawCreateEx(NULL, (void**)&lpDD, + &IID_IDirectDraw7, NULL); + ok(rc==DD_OK, "DirectDrawCreateEx returned: %lx\n", rc); + + rc = IDirectDraw_SetCooperativeLevel(lpDD, NULL, DDSCL_NORMAL); + ok(rc==DD_OK, "SetCooperativeLevel returned: %lx\n", rc); + + rc = IDirectDraw7_QueryInterface(lpDD, &IID_IDirect3D7, (void**) &lpD3D); + ok(rc==DD_OK, "QueryInterface returned: %lx\n", rc); + + memset(&ddsd, 0, sizeof(ddsd)); + ddsd.dwSize = sizeof(ddsd); + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; + ddsd.ddsCaps.dwCaps = DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE; + ddsd.dwWidth = 256; + ddsd.dwHeight = 256; + rc = IDirectDraw7_CreateSurface(lpDD, &ddsd, &lpDDS, NULL); + ok(rc==DD_OK, "CreateSurface returned: %lx\n", rc); + + rc = IDirect3D7_CreateDevice(lpD3D, &IID_IDirect3DTnLHalDevice, lpDDS, + &lpD3DDevice); + ok(rc==D3D_OK, "CreateDevice returned: %lx\n", rc); +} + +static void ReleaseDirect3D() +{ + if (lpD3DDevice != NULL) + { + IDirect3DDevice7_Release(lpD3DDevice); + lpD3DDevice = NULL; + } + + if (lpDDS != NULL) + { + IDirectDrawSurface_Release(lpDDS); + lpDDS = NULL; + } + + if (lpD3D != NULL) + { + IDirect3D7_Release(lpD3D); + lpD3D = NULL; + } + + if (lpDD != NULL) + { + IDirectDraw_Release(lpDD); + lpDD = NULL; + } +} + +static void LightTest() +{ + HRESULT rc; + D3DLIGHT7 light; + D3DLIGHT7 defaultlight; + BOOL bEnabled = FALSE; + + + /* Set a few lights with funky indices. */ + memset(&light, 0, sizeof(light)); + light.dltType = D3DLIGHT_DIRECTIONAL; + light.dcvDiffuse.r = 0.5f; + light.dcvDiffuse.g = 0.6f; + light.dcvDiffuse.b = 0.7f; + light.dvDirection.y = 1.f; + + rc = IDirect3DDevice7_SetLight(lpD3DDevice, 5, &light); + ok(rc==D3D_OK, "SetLight returned: %lx\n", rc); + rc = IDirect3DDevice7_SetLight(lpD3DDevice, 10, &light); + ok(rc==D3D_OK, "SetLight returned: %lx\n", rc); + rc = IDirect3DDevice7_SetLight(lpD3DDevice, 45, &light); + ok(rc==D3D_OK, "SetLight returned: %lx\n", rc); + + + /* Try to retrieve a light beyond the indices of the lights that have + been set. */ + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 50, &light); + ok(rc==DDERR_INVALIDPARAMS, "GetLight returned: %lx\n", rc); + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 2, &light); + ok(rc==DDERR_INVALIDPARAMS, "GetLight returned: %lx\n", rc); + + + /* Try to retrieve one of the lights that have been set */ + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 10, &light); + ok(rc==D3D_OK, "GetLight returned: %lx\n", rc); + + + /* Enable a light that have been previously set. */ + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 10, TRUE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + + + /* Enable some lights that have not been previously set, and verify that + they have been initialized with proper default values. */ + memset(&defaultlight, 0, sizeof(D3DLIGHT7)); + defaultlight.dltType = D3DLIGHT_DIRECTIONAL; + defaultlight.dcvDiffuse.r = 1.f; + defaultlight.dcvDiffuse.g = 1.f; + defaultlight.dcvDiffuse.b = 1.f; + defaultlight.dvDirection.z = 1.f; + + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 20, TRUE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + memset(&light, 0, sizeof(D3DLIGHT7)); + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 20, &light); + ok(rc==D3D_OK, "GetLight returned: %lx\n", rc); + ok(!memcmp(&light, &defaultlight, sizeof(D3DLIGHT7)), + "light data doesn't match expected default values\n" ); + + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 50, TRUE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + memset(&light, 0, sizeof(D3DLIGHT7)); + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 50, &light); + ok(rc==D3D_OK, "GetLight returned: %lx\n", rc); + ok(!memcmp(&light, &defaultlight, sizeof(D3DLIGHT7)), + "light data doesn't match expected default values\n" ); + + + /* Disable one of the light that have been previously enabled. */ + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 20, FALSE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + + /* Try to retrieve the enable status of some lights */ + /* Light 20 is supposed to be disabled */ + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 20, &bEnabled ); + ok(rc==D3D_OK, "GetLightEnable returned: %lx\n", rc); + ok(!bEnabled, "GetLightEnable says the light is enabled\n"); + + /* Light 10 is supposed to be enabled */ + bEnabled = FALSE; + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 10, &bEnabled ); + ok(rc==D3D_OK, "GetLightEnable returned: %lx\n", rc); + ok(bEnabled, "GetLightEnable says the light is disabled\n"); + + /* Light 80 has not been set */ + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 80, &bEnabled ); + ok(rc==DDERR_INVALIDPARAMS, "GetLightEnable returned: %lx\n", rc); + + /* Light 23 has not been set */ + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 23, &bEnabled ); + ok(rc==DDERR_INVALIDPARAMS, "GetLightEnable returned: %lx\n", rc); +} + +START_TEST(d3d7light) +{ + CreateDirect3D(); + LightTest(); + ReleaseDirect3D(); +}

1 0

[RESEND] [d3d] Light management API fix to handle an unlimited number of lights
by Antoine Chavasse June 6, 2005

June 6, 2005

Resend of http://www.winehq.org/hypermail/wine-patches/2005/06/0103.html, adapted to Christian's reorganisation of ddraw directory, and as attachment to avoid gmail word-wrapping the patch :) ChangeLog: - Rewrote the light management API to allow for an unlimited amount of lights to be set, and only a subset of them to be enabled.

1 0

Re: Google "Summer of Code"
by Jesse Allen June 6, 2005

June 6, 2005

Mike Hearn said: We need more people working on app compatibility! :) Maybe we can choose some apps that are "nearly there" and get people to solve the last few bugs or alternatively make one of the projects "Bring any 3 apps up to Gold status in the appdb". Stefan DÃ¶singer said: I've a few app suggestions: Half-Life 1 (+Mods like Counter-Strike) Star Wars Jedi Knight Jedi Academy Star Wars Jedi Knight Jedi Outcast Warcraft III Microsoft Visual Basic Microsoft Visual C++ UltraISO Quicktime player Anno 1602 I am a super maintainer for Warcraft III. I *know* everything that needs to be fixed. In fact, I have been working on it for a long time. I just need a little more motivation to get the last major issues fixed. Now here's the deal. I need something to do this summer, and my job at IBM may be going away. I'm also a student at a local college here, and have been itching to do something. I've helped wine a bit before so I'm not a total new-comer. I know C, but can use more practice. So I'm willing to work to get three applications to gold status. Jedi Acadamy is probably doable as well, from what I've seen. But if anyone has suggestions I'm willing to look. I could help Ivan to get Safedisc to work too. So maybe if I can get a list of goals to reach, I will apply for it. Jesse

6 13

Re: [include/winternl.h #7] SYSTEM_PROCESS_INFORMATION
by Alexandre Julliard June 6, 2005

June 6, 2005

Paul Vriens <Paul.Vriens(a)xs4all.nl> writes: > I removed the __WINESRC__ bit as it will never be used and it makes the > (coming) tests look better (no private structure needed). > The Windows struct part in SYSTEM_PROCESS_INFORMATION is wrong anyway > (both by size and members). Actually in most cases the non __WINESRC__ case is the one you want to keep, since it comes from the Microsoft headers. You can replace the Reserved things with better names but you should keep at least the fields that have explicit names in the MS headers. If you have to change the layout more than that something is seriously wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Delete version sniffing logic
by Stefan Dösinger June 6, 2005

June 6, 2005

> The rationale for this change is simple: the version sniffing > code is unreliable and gets it wrong frequently. Out of the box, > you can't run "WINEDLLOVERRIDES=msi,msiexec.exe=n wine InstMsiA.exe" > because of this code. You just get silence. It turns out that even > though this is the Win98 version of the installer, it's detected > as a Windows XP binary. > > It's a lot simpler to have a single, sane default. This makes it > easier for users to understand, easier for us to control, and avoids > the case where different processes in the same program get different > version information. > > This patch defaults us to Win98 mode. Shouldn't we default to WinXP? I know no apps except Win98 specific system files like InstMsiA.exe and dcom98.exe which fail with Winver=winxp. Contrary many apps need winver=winxp(or win2k or nt40) to work, like the setup programs for MS Visual Studio and Microsoft Office 2003. Anyone who has an app which doesn't work with winver=winxp but works with real Windows XP? I think we should at least target Winver=winxp and fix broken apps. Stefan

4 4

Re: Wine on Sparc
by Chuck Hall June 6, 2005

June 6, 2005

> Chuck Hall wrote: >> Well it looks good. I did get a few failures on the patching, but it >> wnet >> through 'make depend' without a problem. >> >> Now I run into the problem in kthread.c: >> sed -e 's,@bindir\@,/usr/local/bin,g' -e >> 's,@dlldir\@,/usr/local/lib/wine,g' -e 's,@PACKAGE_STRING\@,Wine >> 20050524,g' ./wine.man.in >wine.man || (rm -f wine.man && false) >> gcc -c -I. -I. -I../include -I../include -Wall -pipe >> -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o kthread.o >> kthread.c >> kthread.c:322:3: #error You must implement wine_pthread_init_current_teb >> for your platform >> kthread.c:361:3: #error wine_pthread_get_current_teb not defined for >> this >> architecture >> kthread.c: In function `wine_pthread_get_current_teb': >> kthread.c:340: warning: 'ret' might be used uninitialized in this >> function >> *** Error code 1 >> make: Fatal error: Command failed for target `kthread.o' >> Current working directory /tmp/wine-20050524/loader >> *** Error code 1 >> The following command caused the error: >> cd loader && make >> make: Fatal error: Command failed for target `loader' >> >> Guess this is the next problem to work on :) > > Sounds like configure isn't detecting things properly. It should be > detecting '_lwp_create' and '_lwp_self', thus defining HAVE__LWP_CREATE > and HAVE__LWP_SELF (in addition to HAVE_SYS_LWP_H). Check your > config.log to see what's going on. > > I did have problems with this stuff in older versions of wine, and I > actually hacked the configure scripts to use wine-pthread instead of > wine-kthread. I don't recall the exact reasons, but it wine-kthread > seems to be working fine for me now. Started to go through this and found something intresting. lwp.h does exist and is found, so HAVE_SYS_LWP_H is defined. The test for _lwp_create fails. Looking a bit deeper I found that the lwp.h for Solaris 9 is different from the one in Solaris 10 (which is what I am using). Based on this and something I read awhile ago, I belive that Sun is attempting to phase out the lwp stuff on Solaris. It looks like a workaround will need to be created for _lwp_create. I will look into this and see what is the "official" way to write the code now, if any. Also a workaround will need to be made for all other _lwp_* calls that no longer exist. Have Fun! Chuck Hall

3 3

Re: [OLE #94] Correctly marshal NULL ppUnk refptrs in NdrPointerMarshall
by Robert Shearman June 6, 2005

June 6, 2005

Mike Hearn wrote: >This corrects an attempt to demarshal garbage during InstallShield10 >startup. For full InstallShield 10 support we need a stdole2.tlb > >Mike Hearn <mh(a)codeweavers.com> >Correctly marshal NULL ppUnk refptrs in NdrPointerMarshall > >Index: dlls/rpcrt4/ndr_marshall.c >=================================================================== >RCS file: /home/wine/wine/dlls/rpcrt4/ndr_marshall.c,v >retrieving revision 1.24 >diff -u -p -d -u -r1.24 ndr_marshall.c >--- dlls/rpcrt4/ndr_marshall.c 1 Jun 2005 11:04:03 -0000 1.24 >+++ dlls/rpcrt4/ndr_marshall.c 5 Jun 2005 22:03:11 -0000 >@@ -575,19 +575,19 @@ void WINAPI PointerMarshall(PMIDL_STUB_M > TRACE("(%p,%p,%p,%p)\n", pStubMsg, Buffer, Pointer, pFormat); > TRACE("type=0x%x, attr=", type); dump_pointer_attr(attr); > pFormat += 2; >+ > if (attr & RPC_FC_P_SIMPLEPOINTER) desc = pFormat; > else desc = pFormat + *(const SHORT*)pFormat; >+ > if (attr & RPC_FC_P_DEREF) { >+ if (!Pointer) >+ RpcRaiseException(RPC_X_NULL_REF_POINTER); > Pointer = *(unsigned char**)Pointer; > TRACE("deref => %p\n", Pointer); > } > > switch (type) { >- case RPC_FC_RP: /* ref pointer (always non-null) */ >-#if 0 /* this causes problems for InstallShield so is disabled - we need more tests */ >- if (!Pointer) >- RpcRaiseException(RPC_X_NULL_REF_POINTER); >-#endif >+ case RPC_FC_RP: /* ref pointer (always non-null but may point to null) */ > break; > case RPC_FC_UP: /* unique pointer */ > case RPC_FC_OP: /* object pointer - same as unique here */ > > > This looks wrong. A ref pointer shouldn't be treated as a unique pointer in any circumstances AFAIK. I'll add this case to my mini test suite to confirm or deny this hypothesis. -- Rob Shearman

2 3

Re: spi.pszProcessName should be UNICODE_STRING
by Paul Vriens June 6, 2005

June 6, 2005

On Mon, 2005-06-06 at 12:15, Felix Nawothnig wrote: > This lets the taskname appear in WinXP's taskmgr.exe. > > ChangeLog: > Make SYSTEM_THREAD_INFORMATION.pszProcessName an UNICODE_STRING > > ______________________________________________________________________ Thanks for the fix. The change is however done to the SYSTEM_PROCESS_INFORMATION struct :-). The process name now shows nicely in Process Explorer as well. I saw it's committed so I'll build on that one. Paul.

1 0

Re: Temp fix for SetWindowTextA()
by Christoph Frick June 6, 2005

June 6, 2005

On Sun, Jun 05, 2005 at 02:26:40PM -0400, Jason Campbell wrote: > A possible better patch may be to see if D2 is a child of the D2 bot > (since most bots can load D2) and allow the title change if it is and > not allow it if it's not a parent/child. there are no stupid questions, so i ask: i doubt that windows has there some "if d2 bot, then remove restrictions"... either this software overwrites this data in the process it spawns (many trainers or actually even mods (Grand Prix Legends) work this way. or windows allows changing the title for the spaning process. so the best thing to do is write a test for this, try it in windows and wine and do the correct thing then? -- cu

1 0

Re: [msvcrt] Implement %I types for printf
by Dmitry Timoshkov June 6, 2005

June 6, 2005

"Jesse Allen" <the3dfxdude(a)gmail.com> wrote: > + if( flags->IntegerLength == 'I' ) > + { > + sprintf(p, "l"); > + p++; > + } > + if( flags->IntegerSize == INTEGERSIZE_LONGLONG ) > + { > + sprintf(p, "l"); > + p++; > + } sprintf is very inefficient here, why not use simple strcpy instead? -- Dmitry.

2 1

Half Life 2 error -- err:mmio:MMIO_ParseExtA
by J. Grant June 6, 2005

June 6, 2005

Hello, I am getting this error when trying to run Half Life2 in err:mmio:MMIO_ParseExtA. Could someone tell me if this is a problem in in WINE, or a problem in my setup? Or not an error at all..? Also if there is already a document on setting up Half Life2 could someone direct me to it please, I could not find one already. $ wcmd Invoking /usr/lib/wine/wine.bin wcmd.exe ... WCMD Version 0.17 Z:\home\now3d>cd C:\opt\games\steam\ C:\opt\games\steam>C:\opt\games\steam\Steam.exe -applaunch 220 C:\opt\games\steam>err:dc:CreateDCW no driver found for L"WINEPS" fixme:winspool:AddPrinterW DocumentPropertiesW on printer 'L"deskjet930c"' fails err:dc:CreateDCW no driver found for L"WINEPS" err:dc:CreateDCW no driver found for L"WINEPS" fixme:winspool:AddPrinterW DocumentPropertiesW on printer 'L"hp930c"' fails err:dc:CreateDCW no driver found for L"WINEPS" err:mmio:MMIO_ParseExtA No . in szFileName: "" err:mmio:MMIO_ParseExtA No . in szFileName: "C:\\opt\\games\\steam\\" You need to install the Mozilla ActiveX control to use Wine's builtin CLSID_WebBrowser from SHDOCVW.DLL fixme:ole:CoCreateInstance no instance created for interface {00000000-0000-0000-c000-000000000046} of class {8856f961-340a-11d0-a96b-00c04fd705a2},hres is 0x80040111 fixme:debug_buffer:RtlCreateQueryDebugBuffer (0, 0): stub fixme:debug_buffer:RtlCreateQueryDebugBuffer (96, 0): returning 0x40473b08 fixme:debug_buffer:RtlQueryProcessDebugInformation (11, 80000001, 0x40473b08): stub fixme:debug_buffer:RtlDestroyQueryDebugBuffer (0x40473b08): stub C:\opt\games\steam> C:\opt\games\steam> C:\opt\games\steam>Shutting down. . . 30client callback thread error C:\opt\games\steam>STEAM.exe "steam://open/registerproduct/220" C:\opt\games\steam>err:mmio:MMIO_ParseExtA No . in szFileName: "" err:mmio:MMIO_ParseExtA No . in szFileName: "C:\\opt\\games\\steam\\" fixme:sync:CreateIoCompletionPort (0xffffffff, (nil), 00000000, 00000000): stub. fixme:crypt:CRYPT_VerifyImage (rsaenh.dll, 0x4046b9a0): not verifying image Shutting down. . . 1completionportmanager.cpp (28) : Assertion Failed: m_hIOCP C:\opt\games\steam>exit -- Homepage: http://jguk.org/ Blog: http://jguk.org/blog.rss Radio: http://jguk.org/#radio

4 7

Re: shell32: BindToObject should fail, if called with empty pidl
by Uwe Bonnes June 6, 2005

June 6, 2005

>>>>> "Michael" == Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: Michael> This fixes the problem in DVD Shrink's SHBrowseForFolder Michael> dialog, reported by Wolfgang Scherer. Can you perhaps provide a testcase? I pays off the long term... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

WWN #277 correction.
by Chuck Hall June 6, 2005

June 6, 2005

In the WWN #277 there is mention that I am using Solaris 9 while attempting to get Wine to work. I am actually using Solaris 10 not Solaris 9. What I did was compare what was different between Solaris 9 and Solaris 10 so I could figure out what the problem is/was. -- Have Fun! Chuck Hall

1 0

Re: wine/ include/wine/server.h dlls/ntdll/server. ...
by Robert Shearman June 5, 2005

June 5, 2005

Alexandre Julliard wrote: >Index: wine/include/wine/server.h >diff -u -p wine/include/wine/server.h:1.21 wine/include/wine/server.h:1.22 >--- wine/include/wine/server.h:1.21 Sun Jun 5 20:45:53 2005 >+++ wine/include/wine/server.h Sun Jun 5 20:45:53 2005 >@@ -55,6 +55,7 @@ extern void wine_server_send_fd( int fd > extern int wine_server_fd_to_handle( int fd, unsigned int access, int inherit, obj_handle_t *handle ); > extern int wine_server_handle_to_fd( obj_handle_t handle, unsigned int access, int *unix_fd, int *flags ); > extern void wine_server_release_fd( obj_handle_t handle, int unix_fd ); >+extern void DECLSPEC_NORETURN wine_server_exit_thread( int status ); > > /* do a server call and set the last error code */ > inline static unsigned int wine_server_call_err( void *req_ptr ) > >Index: wine/dlls/ntdll/server.c >diff -u -p wine/dlls/ntdll/server.c:1.21 wine/dlls/ntdll/server.c:1.22 >--- wine/dlls/ntdll/server.c:1.21 Sun Jun 5 20:45:53 2005 >+++ wine/dlls/ntdll/server.c Sun Jun 5 20:45:53 2005 >@@ -119,6 +119,40 @@ static void fatal_perror( const char *er > > > /*********************************************************************** >+ * wine_server_exit_thread (NTDLL.@) >+ */ >+void wine_server_exit_thread( int status ) >+{ >+ struct wine_pthread_thread_info info; >+ ULONG size; >+ >+ RtlAcquirePebLock(); >+ RemoveEntryList( &NtCurrentTeb()->TlsLinks ); >+ RtlReleasePebLock(); >+ >+ info.stack_base = NtCurrentTeb()->DeallocationStack; >+ info.teb_base = NtCurrentTeb(); >+ info.teb_sel = wine_get_fs(); >+ info.exit_status = status; >+ >+ size = 0; >+ NtFreeVirtualMemory( GetCurrentProcess(), &info.stack_base, &size, MEM_RELEASE | MEM_SYSTEM ); >+ info.stack_size = size; >+ >+ size = 0; >+ NtFreeVirtualMemory( GetCurrentProcess(), &info.teb_base, &size, MEM_RELEASE | MEM_SYSTEM ); >+ info.teb_size = size; >+ >+ sigprocmask( SIG_BLOCK, &block_set, NULL ); >+ close( NtCurrentTeb()->wait_fd[0] ); >+ close( NtCurrentTeb()->wait_fd[1] ); >+ close( NtCurrentTeb()->reply_fd ); >+ close( NtCurrentTeb()->request_fd ); >+ wine_pthread_exit_thread( &info ); >+} >+ >+ >+/*********************************************************************** > * server_abort_thread > */ > void server_abort_thread( int status ) > >Index: wine/dlls/ntdll/ntdll.spec >diff -u -p wine/dlls/ntdll/ntdll.spec:1.182 wine/dlls/ntdll/ntdll.spec:1.183 >--- wine/dlls/ntdll/ntdll.spec:1.182 Sun Jun 5 20:45:53 2005 >+++ wine/dlls/ntdll/ntdll.spec Sun Jun 5 20:45:53 2005 >@@ -1027,6 +1027,7 @@ > @ cdecl wine_server_handle_to_fd(long long ptr ptr) > @ cdecl wine_server_release_fd(long long) > @ cdecl wine_server_send_fd(long) >+@ cdecl wine_server_exit_thread(long) > > # Codepages > @ cdecl __wine_init_codepages(ptr ptr ptr) > >Index: wine/dlls/kernel/thread.c >diff -u -p wine/dlls/kernel/thread.c:1.23 wine/dlls/kernel/thread.c:1.24 >--- wine/dlls/kernel/thread.c:1.23 Sun Jun 5 20:45:53 2005 >+++ wine/dlls/kernel/thread.c Sun Jun 5 20:45:53 2005 >@@ -24,7 +24,6 @@ > #include <assert.h> > #include <fcntl.h> > #include <stdarg.h> >-#include <signal.h> > #include <sys/types.h> > #ifdef HAVE_SYS_TIMES_H > #include <sys/times.h> >@@ -238,45 +237,8 @@ void WINAPI ExitThread( DWORD code ) /* > } > else > { >- struct wine_pthread_thread_info info; >- sigset_t block_set; >- ULONG size; >- > LdrShutdownThread(); >- RtlAcquirePebLock(); >- RemoveEntryList( &NtCurrentTeb()->TlsLinks ); >- RtlReleasePebLock(); >- >- info.stack_base = NtCurrentTeb()->DeallocationStack; >- info.teb_base = NtCurrentTeb(); >- info.teb_sel = wine_get_fs(); >- info.exit_status = code; >- >- size = 0; >- NtFreeVirtualMemory( GetCurrentProcess(), &info.stack_base, &size, MEM_RELEASE | MEM_SYSTEM ); >- info.stack_size = size; >- >- size = 0; >- NtFreeVirtualMemory( GetCurrentProcess(), &info.teb_base, &size, MEM_RELEASE | MEM_SYSTEM ); >- info.teb_size = size; >- >- /* block the async signals */ >- sigemptyset( &block_set ); >- sigaddset( &block_set, SIGALRM ); >- sigaddset( &block_set, SIGIO ); >- sigaddset( &block_set, SIGINT ); >- sigaddset( &block_set, SIGHUP ); >- sigaddset( &block_set, SIGUSR1 ); >- sigaddset( &block_set, SIGUSR2 ); >- sigaddset( &block_set, SIGTERM ); >- sigprocmask( SIG_BLOCK, &block_set, NULL ); >- >- close( NtCurrentTeb()->wait_fd[0] ); >- close( NtCurrentTeb()->wait_fd[1] ); >- close( NtCurrentTeb()->reply_fd ); >- close( NtCurrentTeb()->request_fd ); >- >- wine_pthread_exit_thread( &info ); >+ wine_server_exit_thread( code ); > } > } > > > > Couldn't wine_server_exit_thread be merged into LdrShutdownThread to avoid this Wine-specific export? -- Rob Shearman

2 1

Regression : Current CVS gives me a Segmentation Fault
by Paul Vriens June 5, 2005

June 5, 2005

Hi, the current cvs (2005/06/05 14:19:50) gives me a Segmentation Fault on a simple 'wine' command. Regression testing is not ended yet, but the problem wasn't there this morning (with Saturday's CVS). It appears to be http://cvs.winehq.org/patch.py?id=17949 but I'm not a 100% sure on that one yet. Any ideas, or does someone have the same problem ? Cheers, Paul.

3 2

Re: [d3d] Light management API fix to handle an unlimited number of lights
by Christian Costa June 5, 2005

June 5, 2005

Antoine Chavasse wrote: >Direct3D allows to set any number of light, and limits the number of >lights that can be active at the same time. > >The current wine code allows to setup only 16 lights. It made Anarchy >Online crash, because it tried to setup more lights than that and >didn't like to get returned an error when doing so. > >This patch is a rewrite of the d3d light management api and some related code. > >Another patch with test cases for the light api will follow. > >ChangeLog: > - Rewrote the light management API to allow for an unlimited amount >of lights to be set, > and only a subset of them to be enabled. > > > Hi Antoine, May I ask you to wait a little until I finish reorganizing the DDraw directory? This task involves file renaming so if your patch is aplly later, we can save the history of your modifications. :-) Bye, Christian

2 1

Re: [OLE #93] Disconnect IRemUnknown proxy after the others (resend)
by Robert Shearman June 5, 2005

June 5, 2005

Mike Hearn wrote: >On Sun, 05 Jun 2005 11:32:14 -0500, Robert Shearman wrote: > > >>The IRemUnknown proxy shouldn't be disconnected at all. Can you try this >>patch for me? >> >> > >Yes, that works too. This patch is simpler and equivalent though? > > > Yes it is. -- Rob Shearman

1 0

Re: [OLE #93] Disconnect IRemUnknown proxy after the others (resend)
by Robert Shearman June 5, 2005

June 5, 2005

Mike Hearn wrote: >Oops, I forgot to unapply various patches that aren't ready yet or will >be submitted separately. Here it is on its own. > >This fixes the FunFlash Polaroid installer. > >ChangeLog: >Disconnect IRemUnknown proxy after the others. Add some tracing. > > The IRemUnknown proxy shouldn't be disconnected at all. Can you try this patch for me? Changelog: Don't disconnect proxies flagged with SORFP_NOLIFETIMEMGMT. It makes no sense and only causes trouble for proxies that depend on these proxies being available. -- Rob Shearman

1 0