June 2005 - Wine-Devel - list.winehq.org

Question about deadlock in winmm
by Vitaliy Margolen June 30, 2005

June 30, 2005

Lately I'm seeing a lot of deadlocks in wine's sound system. Most notably winealsa. But the code in question affects all (in my case oss since it's working better for me then others). I'm not sure what exactly happens (deadlock because of race condition or else) but code bellow deadlocks with other heap functions (like GetHeap). Removing HeapValidate didn't cause any problems for as of yet. And I haven't seen a single deadlock here at all. Is there are reasons we perform this heap validation here? Could someone comment on this? If someone interested I could reproduce backtrace of the deadlock. -- Best regards, Vitaliy Index: dlls/winmm/lolvldrv.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/lolvldrv.c,v retrieving revision 1.68 diff -u -p -r1.68 lolvldrv.c --- dlls/winmm/lolvldrv.c 22 Jun 2005 11:59:43 -0000 1.68 +++ dlls/winmm/lolvldrv.c 29 Jun 2005 14:54:42 -0000 @@ -441,7 +441,7 @@ LPWINE_MLD MMDRV_Get(HANDLE _hndl, UINT hndl = hndl & ~0x8000; if (hndl < sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0])) { mld = MM_MLDrvs[hndl]; - if (!mld || !HeapValidate(GetProcessHeap(), 0, mld) || mld->type != type) + if (!mld || mld->type != type) mld = NULL; } hndl = hndl | 0x8000;

1 0

Re: Fix ntdll compilation in Darwin
by Dmitry Timoshkov June 30, 2005

June 30, 2005

"Phil Krylov" <phil(a)newstar.rinet.ru> wrote: > Index: dlls/ntdll/cdrom.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v > retrieving revision 1.59 > diff -p -u -r1.59 cdrom.c > --- dlls/ntdll/cdrom.c 29 Jun 2005 19:18:54 -0000 1.59 > +++ dlls/ntdll/cdrom.c 30 Jun 2005 11:27:41 -0000 > @@ -75,6 +75,11 @@ > # include <sys/scsiio.h> > #endif > > +#ifdef __APPLE__ > +# include <IOKit/IOKitLib.h> > +# include <IOKit/scsi/SCSICmds_REQUEST_SENSE_Defs.h> > +#endif > + > #define NONAMELESSUNION > #define NONAMELESSSTRUCT > #include "ntstatus.h" > @@ -1418,6 +1423,8 @@ static NTSTATUS CDROM_ScsiPassThroughDir > > #ifdef SENSEBUFLEN > if (pPacket->SenseInfoLength > SENSEBUFLEN) > +#elif defined( __APPLE__ ) > + if (pPacket->SenseInfoLength > kSenseDefaultSize) > #else > if (pPacket->SenseInfoLength > sizeof(struct request_sense)) > #endif Please do not introduce even more platform dependent #ifdefs into cdrom.c, currently it already has enough mess with all that #if defined(linux)/(__FreeBSD__)/ (__NetBSD__). Add proper configure checks for headers and structures your platform needs. -- Dmitry.

2 2

Delays in FileOpen
by Uwe Bonnes June 30, 2005

June 30, 2005

Hallo (Michael?), File Open Dialogs for me have some noticable initial delay when starting up. For example, try in internet explorer "Save under". I don't remember seeing that delay some time before. Dif recent shfolder changes cause that delay? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests
by Ivan Leo Puoti June 30, 2005

June 30, 2005

Saulius Krasuckas wrote: >>ChangeLog: Fix bug that left mouse buttons swapped after tests >> >>Ivan. > > > I think your patch causes test to fail on Wine, Ivan. My try goes next. Maybe that isn't a bad thing, the results from the latest build of winetest shows this test fails on windows 2000, windows nt, windows me, and windows 98se, so I somewhat doubt the wine behaviour is correct. Ivan.

2 1

Fwd: Anybody looking for a pet Wine project?
by Vijay Kiran Kamuju June 30, 2005

June 30, 2005

---------- Forwarded message ---------- From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Jun 30, 2005 3:42 PM Subject: Re: Anybody looking for a pet Wine project? To: Mike McCormack <mike(a)codeweavers.com> typelib info of hhctrl.ocx of winxp (used pe explorer) -------------------------------------------------------------------------- //HHCtrl 4.0 Type Library //Version: 4.0 HHCTRLLib; GUID = {ADB880A2-D8FF-11CF-9377-00AA003B7A11}; //Event interface for HHCtrl Dispatch _HHCtrlEvents; GUID = {ADB880A3-D8FF-11CF-9377-00AA003B7A11}; function Click(out ParamString: BSTR); stdcall; //HHCtrl Class CoClass HHCtrl; GUID = {52A2AAAE-085D-4187-97EA-8C30DB990436}; //IHHCtrl Interface Dispatch IHHCtrl; GUID = {ADB880A1-D8FF-11CF-9377-00AA003B7A11}; function QueryInterface(riid: ^GUID; out ppvObj: ^^VOID); stdcall; function AddRef: UI4; stdcall; function Release: UI4; stdcall; function GetTypeInfoCount(out pctinfo: ^UINT); stdcall; function GetTypeInfo(itinfo: UINT; lcid: UI4; out pptinfo: ^^VOID); stdcall; function GetIDsOfNames(riid: ^GUID; rgszNames: ^^I1; cNames: UINT; lcid: UI4; out rgdispid: ^I4); stdcall; function Invoke(dispidMember: I4; riid: ^GUID; lcid: UI4; wFlags: UI2; pdispparams: ^DISPPARAMS; out pvarResult: ^Variant; out pexcepinfo: ^EXCEPINFO; out puArgErr: ^UINT); stdcall; property-put Image(: BSTR); stdcall; property-get Image: BSTR; stdcall; //Click method function Click; stdcall; //Click method function HHClick; stdcall; //Print method function Print; stdcall; //syncURL method function syncURL(out pszUrl: BSTR); stdcall; //TCard method function TCard(out wParam: UINT_PTR; out lParam: LONG_PTR); stdcall; //Text Popup method function TextPopup(out pszText: BSTR; out pszFont: BSTR; out horzMargins: INT; out vertMargins: INT; out clrForeground: UI4; out clrBackground: UI4); stdcall; Alias UINT_PTR; UI4 Alias LONG_PTR; I4 //Deprecated HHCtrl Class 2 CoClass OldHHCtrl2; GUID = {41B23C28-488E-4E5C-ACE2-BB0BBABE99E8}; //Deprecated HHCtrl Class 1 CoClass OldHHCtrl1; GUID = {ADB880A6-D8FF-11CF-9377-00AA003B7A11}; On 6/30/05, Mike McCormack <mike(a)codeweavers.com> wrote: > > Hi All, > > If anybody is looking for a small project, I've got just the thing for you! > > hh.exe and hhctrl.ocx are two components of the Microsoft HTML help > engine. hh.exe is a small wrapper around hhctrl.ocx, which is the HTML > help viewer. > > hhctrl.ocx embeds IE and feeds it HTML documents decoded from .chm files > with itss.dll (the Infotech storage system). Implementing hhctrl.ocx > would make an excellent test case for IE embedding that Jacek is working > on, and for itss.dll. > > So most of the components are already in place (or will be soon) to make > HTML help work... any takers to fill in the dots? > > The reward is, like most of Wine code, to say "I made that work" :) > > Let me know if you're interested. > > Mike > > >

1 0

Using ReactOS Registry format
by James Liggett June 30, 2005

June 30, 2005

Brad, Last night Martin Fuchs suggested that we look into using ReactOS's registry format in order to be compatible with Windows registry databases. I have the latest release of ReactOS running on QEMU on my box, so I checked it out. Basically, they're using the same regedit program from Wine, missing find command and all (Which I too feel is a pain in the neck). I looked at the config stuff, and I found what looked like some binary database files for each of the main registry sections. Unfortunately, there's no documentation at all on any of this on their website. If we decide to go this route, we may be in for a hell of a lot of work. But, I do agree with all of your points. I think the current system could use some improvement, especially in the area of searching. Let me know what you think of all this. Kind Regards, James Liggett

8 11

Re: [MSXML] : add declarations for XMLDOM
by Mike McCormack June 30, 2005

June 30, 2005

Hi Vijay, Vijay Kiran Kamuju wrote: > I am sending a new patch for th XMLDOM stuff > ChangeLog > ---------------- > add definitions and declarations for XMLDOM stuff Thanks for sending the patch in. After looking through it, here are my notes: * try cut it up into small bits, the smaller the better. Alexandre checks every line before applying a patch, so if you reduce the size of you patches, you'll reduce Alexandre's work and increase the chance that they go into Wine. So I'd suggest cut this patch up into two patches, one to add the DISPIDs and one to add the interface code. * you should add your own copyright line, instead of adding to the end of mine. eg. * Copyright (C) 2005 Mike McCormack * Copyright (c) 2005 Vijay Kiran Kamuju looks like good, Mike

1 0

Re: Fix libGL.a check on configure
by Alexandre Julliard June 30, 2005

June 30, 2005

Anderson Lizardo <andersonlizardo(a)yahoo.com.br> writes: > Hi, > > Changelog: > > Fixed the libGL.a configure check for systems where > /usr/X11R6/lib/libGL.so is a symbolic link. > > > PS.: I've not used a simple "test -e" because > http://www.winehq.org/hypermail/wine-patches/2002/01/0206.html says this > does not work on Solaris. My guess is that if test -e doesn't work, test -L won't work either... -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: ntdll: Fix add_access_ace
by Mike McCormack June 30, 2005

June 30, 2005

Hi James, James Hawkins wrote: > These changes make the advapi32 tests pass as well. > > Changelog > * Fix calculation of generic pointers. > * Minor cleanups. Thanks for the fixes. This makes Office 2003 work again for me. > if ((DWORD)(pAceHeader + dwAceSize) > (DWORD)(pAcl + pAcl->AclSize)) > return STATUS_ALLOTTED_SPACE_EXCEEDED; I think you might have missed one here. The above pointer arithmetic seems like it will make the wrong calculation. Maybe something like the following would work better: if ( &((char*)pAceHeader)[dwAceSize] > &((char*)pAcl)[pAcl->AclSize] ) Mike

1 0

[Bugzilla/AppDB] www.winehq.org/appview.php -> appdb.winehq.org/appview.php
by Jonathan Ernst June 30, 2005

June 30, 2005

3 2

[Fwd: QUARTZ: initialize AM_MEDIA_TYPE to prevent crash]
by Alex Villacís Lasso June 29, 2005

June 29, 2005

I am (still) trying to run a Japanese RPG program in Wine, and it requires 1) the Indeo video codecs, fortunately downloadable, and 2) this patch, to prevent crashing on an attempt to IUnknown_Release on a bogus interface. Second attempt - first one never appeared on the mail list. Changelog: * Initialize mtCurrent structure to NULL to prevent calling IUnknown_Release on an uninitialized interface

2 1

Re: MSHTML: Implemented res protocol
by Juan Lang June 29, 2005

June 29, 2005

Hi Jacek, > +/* FIXME: What does it mean? */ > +#define UNKNOWN_RES_ERR1 0x8007007E This is HRESULT_FROM_WIN32(ERROR_MOD_NOT_FOUND). Any 0x8007* error code is an HRESULT_FROM_WIN32 of a Win32 error. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Modifying windows registry
by Serge NOEL June 29, 2005

June 29, 2005

Hello, i' am searching a way to change windows registry from Linux (not the copy but the real windows registry) Has someone an idea on how to do this ? Serge

1 0

Re: implement EM_GETTEXTEX in riched20
by Marcus Meissner June 29, 2005

June 29, 2005

On Wed, Jun 29, 2005 at 09:02:34AM -0500, Aric Stewart wrote: > implementation for EM_GETTEXTEX in riched20 > Index: dlls/riched20/editor.c > =================================================================== > RCS file: /home/wine/wine/dlls/riched20/editor.c,v > retrieving revision 1.32 > diff -u -r1.32 editor.c > --- dlls/riched20/editor.c 21 Jun 2005 20:53:14 -0000 1.32 > +++ dlls/riched20/editor.c 29 Jun 2005 14:00:17 -0000 > @@ -845,7 +845,6 @@ > UNSUPPORTED_MSG(EM_GETRECT) > UNSUPPORTED_MSG(EM_GETREDONAME) > UNSUPPORTED_MSG(EM_GETSCROLLPOS) > - UNSUPPORTED_MSG(EM_GETTEXTEX) > UNSUPPORTED_MSG(EM_GETTEXTLENGTHEX) > UNSUPPORTED_MSG(EM_GETTEXTMODE) > UNSUPPORTED_MSG(EM_GETTYPOGRAPHYOPTIONS) > @@ -1184,6 +1183,30 @@ > return RichEditANSIWndProc(hWnd, EM_GETTEXTRANGE, 0, (LPARAM)&tr); > } > case EM_GETSELTEXT: > + case EM_GETTEXTEX: > + { I do not think this is what you want. You now have both cases in one ... Ciao, Marcus

1 0

shell32/tests: ILFree is not exported on all versions
by Saulius Krasuckas June 29, 2005

June 29, 2005

Vitaliy, I have been messing around shell32/tests some day ago, and stuck upon a MSDN, which states that SHGetMalloc() is obsolete. It says we must should stick with CoTaskMemFree() and CoTaskMemAlloc() instead. Would you take a thought on this?

2 3

Re: [AppDB] Redisplay the input form and display the errors take 2
by Paul van Schayck June 29, 2005

June 29, 2005

Hey, On 6/29/05, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: > Chris and I talked on IRC and it turns out that magic_quotes_gpc are > turned "on" in php.ini on the production server and not on mine so we > needed a stripslashes() on the version description. They are supposed to be off! Check our .htaccess: http://cvs.winehq.org/cvsweb/~checkout~/appdb/.htaccess?rev=1.3&content-typ… Our database query compile functions are also adding slashes and I don't see slashes appear in other recent database entries. In other words there we have no magic quotes added. So either the php overrule settings are recently changes or the slashes in appsubmit.php are comming from a different place. Paul

2 1

MSCMS: testing with no support for color management
by Saulius Krasuckas June 29, 2005

June 29, 2005

MSCMS tests fails on my box: | [s2(a)katleriai wine]$ wine dlls/mscms/tests/mscms_test.exe.so 2>&1 | head -n 6 | This version of Wine was compiled without support for color management | functions. This means many color functions are empty stubs and you should | expect your application to fail. To enable Wine to use LittleCMS for color | management please install a liblcms development package version 1.13 or | higher and rebuild Wine. | http://www.littlecms.com I want to fix this by avoiding to upgrade my liblcms and install dev-pkg. Would it be OK to put some #ifdef-s in some unimplemented function, let say EnumColorProfilesA(), and to SetLastError(ERROR_CALL_NOT_IMPLEMENTED)? Then at the start of the test we could check this and return from the test when GetLastError() return ERROR_CALL_NOT_IMPLEMENTED. Is this way OK?

2 3

Re: [MSXML] : add declarations for XMLDOM #1
by Alexandre Julliard June 29, 2005

June 29, 2005

Vijay Kiran Kamuju <infyquest(a)gmail.com> writes: > This is part-1 of the patch that adds necessary defines for XMLDOM interfaces > for msxml These belong to msxml2did.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/dlls/advapi32/tests security.c
by Robert Shearman June 29, 2005

June 29, 2005

Alexandre Julliard wrote: >ChangeSet ID: 18501 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2005/06/28 08:52:01 > >Modified files: > dlls/advapi32/tests: security.c > >Log message: > Mark as todo a couple of tests that currently fail. > >Patch: http://cvs.winehq.org/patch.py?id=18501 > >Old revision New revision Changes Path > 1.20 1.21 +3 -3 wine/dlls/advapi32/tests/security.c > > This patch is wrong. The failures are caused by the following patch: >ChangeSet ID: 18498 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2005/06/28 05:54:29 > >Modified files: > dlls/ntdll : sec.c > >Log message: > James Hawkins <truiken(a)gmail.com> > Forward RtlAddAccess* to add_access_ace. > >Patch: http://cvs.winehq.org/patch.py?id=18498 > >Old revision New revision Changes Path > 1.62 1.63 +6 -58 wine/dlls/ntdll/sec.c > > James, the SD in the tests seems to be filled with random data. Can you have a go at fixing this? -- Rob Shearman

2 1

Re: lostwages: fix link to ICM documentation
by Tom Wickline June 29, 2005

June 29, 2005

On 6/26/05, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > ChangeLog: > Saulius Krasuckas <saulius.krasuckas(a)ieee.org> > Link to Image Color Management (ICM) Reference instead of > irrelevant MSCMS Publishing API docs. > > > Index: templates/en/status_dlls.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/status_dlls.template,v > retrieving revision 1.27 > diff -u -p -u -r1.27 status_dlls.template > --- templates/en/status_dlls.template 23 Jun 2005 22:29:56 -0000 1.27 > +++ templates/en/status_dlls.template 26 Jun 2005 20:18:25 -0000 > @@ -229,7 +229,7 @@ > </tr> > <tr> > <td>mscms.dll</td> > - <td class="adequate"><a href="http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cmsccapi/P…">MSDN: MSCMS Publishing API</a></td> > + <td class="adequate"><a href="http://msdn.microsoft.com/library/default.asp?url=/library/en-us/icm/icm_3j…">MSDN: ICM Reference</a></td> > <td>None</td> > <td class="pct25">25% complete</td> > <td>Hans Leidekker</td> > > I was looking over some of our current links to MSDN and looked at the link that you provide. Wouldn't this link be even better? http://msdn.microsoft.com/library/default.asp?url=/library/en-us/icm/icm_20… It covers ICM as well as CMMs Cheers, -Tom

4 5

Re: MSHTML: THIS macros clean up
by Dimi Paun June 28, 2005

June 28, 2005

----- Original Message ----- From: "Jacek Caban" <jack(a)itma.pwr.wroc.pl> > @@ -78,29 +77,35 @@ static HRESULT WINAPI PersistMoniker_IsD > static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL fFullyAvailable, > IMoniker *pimkName, LPBC pibc, DWORD grfMode) > { > - FIXME("(%p)->(%x %p %p %08lx)\n", iface, fFullyAvailable, pimkName, pibc, grfMode); > + PERSISTMON_THIS > + FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName, pibc, grfMode); > return S_OK; > } This code looks weird. It should still look like C code, even if we use a macro. I would suggest something like this: static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL fFullyAvailable, IMoniker *pimkName, LPBC pibc, DWORD grfMode) { HTMLDocument *This = PERSISTMON_THIS(iface); FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName, pibc, grfMode); return S_OK; } It's a bit more verbose, but a lot more readable. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Google Earth
by Jonathan Ernst June 28, 2005

June 28, 2005

Hello, I just wanted to let you know that the new Google Earth application is working quite well under Wine. There is only an issue with the menus disappearing under the pictures but it is very promising. I wrote a message to google to let them know about it (they might want to add that their application can work on other OSes than Windows). Links: http://earth.google.com http://appdb.winehq.org/appview.php?appId=2292 http://slashdot.org/articles/05/06/28/1733229.shtml?tid=217&tid=95&tid=159 Regards. -- Jonathan Ernst <Jonathan(a)ErnstFamily.ch>

1 0

Re: Move Notification Window (aka systray) To A Separate Process
by Dimi Paun June 28, 2005

June 28, 2005

From: "Robert Shearman" <rob(a)codeweavers.com> > Changelog: > Move notification window (aka systray) to a separate process. > --- /dev/null 2005-06-27 03:50:51.210644768 -0500 > +++ programs/winesystray/Makefile.in 2005-06-26 08:34:07.000000000 -0500 Cool, but I wan't the plan to have only one external process (a wineexplorer or somesuch) that would handle desktop mode, systray, etc? This could be it, but then the naming (winesystray) seems a bit off... -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

Follow up to Google's Summer of Code
by Jeremy White June 28, 2005

June 28, 2005

Hi folks, As I'm sure you all know, Google has now accepted 6 students to work on projects for Wine. Alexandre, Dan Kegel, Lionel Ulmer, Dimi O'Paun and I worked on the Wine committee that reviewed the applications, and we were all impressed by the depth and quality of the applications, and we're excited to have 6 fresh new workers on Wine. We're working right now on connecting these 6 students with their mentors; we hope to announce more details once we've made those connections. To be honest, we're running a bit behind here; I think Google jumped into this without being as prepared as you might otherwise hope, and there have been challenges in figuring this all out. (We're still largely clueless about the responsibilities of mentors from Googles perspective, for example). So, thanks to everyone that submitted a proposal. I'd particularly like to thank those people that submitted a great proposal and were not accepted. To be quite honest, we were disappointed that Google only selected 6 applicants; we put forward 18 different applications that we thought were all worthy of funding. So, thanks again to everyone, and most of all, thanks to Google for spurring Wine development! Cheers, Jeremy

1 0

MSHTML and spyware
by Scott Ritchie June 28, 2005

June 28, 2005

While poking around the forums today I discovered that some windows sysadmins disable permissions for mshtml.dll as a sort of hack to prevent spyware infestation due to problems with Internet Explorer. There's some work being done on mshtml now - if we are coding a truly drop-in replacement using Mozilla, would it be possible for these sysadmins to use the Wine version instead? That would be pretty nifty. Thanks, Scott Ritchie

2 1