September 2005 - Wine-Devel

Re: dinput force feedback header detection
by Daniel Remenak Sept. 5, 2005

Sept. 5, 2005

The patch to fix that error is at http://www.winehq.org/pipermail/wine-patches/attachments/20050903/636b08f6/… The headers are correctly detected but the use of the constants was not protected. --Daniel Remenak On 9/5/05, Jesse Allen <the3dfxdude(a)gmail.com> wrote: > Hi I got this compile error from current cvs: > > make[2]: Entering directory `/home/jesse/.local/build/wine/dlls/dinput' > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 > -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o > joystick_linuxinput.o joystick_linuxinput.c > joystick_linuxinput.c: In function `alloc_device': > joystick_linuxinput.c:305: error: `FF_STATUS_STOPPED' undeclared > (first use in this function) > joystick_linuxinput.c:305: error: (Each undeclared identifier is > reported only once > joystick_linuxinput.c:305: error: for each function it appears in.) > joystick_linuxinput.c: In function `joy_polldev': > joystick_linuxinput.c:726: error: `EV_FF_STATUS' undeclared (first use > in this function) > joystick_linuxinput.c: In function `JoystickAImpl_EnumEffects': > joystick_linuxinput.c:1182: warning: unused variable `dei' > joystick_linuxinput.c: In function `JoystickWImpl_EnumEffects': > joystick_linuxinput.c:1266: warning: unused variable `dei' > make[2]: *** [joystick_linuxinput.o] Error 1 > make[2]: Leaving directory `/home/jesse/.local/build/wine/dlls/dinput' > make[1]: *** [dinput] Error 2 > make[1]: Leaving directory `/home/jesse/.local/build/wine/dlls' > make: *** [dlls] Error 2 > > > Apparently the linux/input.h version 2.4.31 does not have support for > force feedback. I've installed headers for 2.6.12.5 and now have it > compiled. So something might need to be done to improve detection, > else others still running 2.4 will get this error. > > Jesse > > >

1 0

dinput force feedback header detection
by Jesse Allen Sept. 5, 2005

Sept. 5, 2005

Hi I got this compile error from current cvs: make[2]: Entering directory `/home/jesse/.local/build/wine/dlls/dinput' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o joystick_linuxinput.o joystick_linuxinput.c joystick_linuxinput.c: In function `alloc_device': joystick_linuxinput.c:305: error: `FF_STATUS_STOPPED' undeclared (first use in this function) joystick_linuxinput.c:305: error: (Each undeclared identifier is reported only once joystick_linuxinput.c:305: error: for each function it appears in.) joystick_linuxinput.c: In function `joy_polldev': joystick_linuxinput.c:726: error: `EV_FF_STATUS' undeclared (first use in this function) joystick_linuxinput.c: In function `JoystickAImpl_EnumEffects': joystick_linuxinput.c:1182: warning: unused variable `dei' joystick_linuxinput.c: In function `JoystickWImpl_EnumEffects': joystick_linuxinput.c:1266: warning: unused variable `dei' make[2]: *** [joystick_linuxinput.o] Error 1 make[2]: Leaving directory `/home/jesse/.local/build/wine/dlls/dinput' make[1]: *** [dinput] Error 2 make[1]: Leaving directory `/home/jesse/.local/build/wine/dlls' make: *** [dlls] Error 2 Apparently the linux/input.h version 2.4.31 does not have support for force feedback. I've installed headers for 2.6.12.5 and now have it compiled. So something might need to be done to improve detection, else others still running 2.4 will get this error. Jesse

1 0

Delphi edit control created in Unicode instead of ANSI mode
by Michael Kaufmann Sept. 5, 2005

Sept. 5, 2005

Hi Frank, One of your theming patches ( http://www.winehq.org/hypermail/wine-cvs/2005/08/0313.html ) has caused a problem in many Delphi applications. The edit controls of Delphi applications are now created in Unicode mode. I hope you have an idea why this happens... Of course Delphi applications are ANSI and expect ANSI controls in their windows. If you believe that this is a real problem, you won't need to read the rest of this email :-) Because the Delphi edit controls are now in Unicode mode, the messages sent to them have to be translated from ANSI to Unicode and back. When a program reads the "Text" property of a TEdit control, Delphi sends a WM_GETTEXTLENGTH message. Wine doubles the return value when translating back from Unicode to ANSI because of double-byte character sets. (dlls/user/winproc.c) Now Delphi gets the doubled text size (should be no problem because WM_GETTEXTLENGTH only returns an upper limit of the text size, but Delphi doesn't regard this fact). Because Delphi does NOT use zero-terminated strings, Delphi will return a string that has twice the size of the text in the edit control and contains a '\0' character. If the application then concatenates this string with another string and passes the result to a Windows API function, the API function will only see the first string because of the '\0' character. I've discovered the problem because installers created by InnoSetup ( http://www.innosetup.com/ ) are now failing. You may use my simple Delphi demo program to test the bug: http://www.michael-kaufmann.ch/WINE/DelphiEdit.zip Regards Michael

2 6

Re: http://cvs.winehq.org/patch.py?id=19897 (shlfolder.c test)
by Paul Vriens Sept. 5, 2005

Sept. 5, 2005

Hi, this change to shell32/tests/shlfolder.c fails on Win98/WinNT and W2KProf because ILFindLastID is not exported on those platforms. I tried to change shlfolder.c to test for the export, but that shows that it's not exported on Wine either ? The .spec file says different. Apart from that, 2 todo_wine's can be removed: shlfolder.c:452: Test succeeded inside todo block: SFGAO_FILESYSTEM attribute is not set for MyDocuments! shlfolder.c:461: Test succeeded inside todo block: RegOpenKeyEx failed! result: 00000000 But I'd like to leave that to the person how fixes the first problem :-). Cheers, Paul.

4 6

Re: http://cvs.winehq.org/patch.py?id=19897 (shlfolder.c test)
by Paul Vriens Sept. 5, 2005

Sept. 5, 2005

On Sun, 2005-09-04 at 16:17 +0300, Saulius Krasuckas wrote: > * On Sat, 3 Sep 2005, Saulius Krasuckas wrote: > > * On Sat, 3 Sep 2005, Paul Vriens wrote: > > > > > > this change to shell32/tests/shlfolder.c fails on Win98/WinNT and > > > W2KProf because ILFindLastID is not exported on those platforms. > > > > > > I tried to change shlfolder.c to test for the export, but that shows > > > that it's not exported on Wine either ? The .spec file says different. > > > > I have made pretty trivial change and it worksforme. See below. > > I believe the test works a lot better now. Still I tried upgrading my RH8 > glibc to one of FC4 and now I sit even w/o XF. :-/ > > > Log message: > Saulius Krasuckas <saulius.krasuckas(a)ieee.org> > SHELL32.dll.ILFindLastID is exported by an ordinal on an older platforms. ... > /* This test shows that Windows doesn't allocate a new pidlLast, but returns a pointer into > * pidlTestFile (In accordance with MSDN). */ > - todo_wine{ok (ILFindLastID(pidlTestFile) == pidlLast, > + todo_wine{ok (pILFindLastID(pidlTestFile) == pidlLast, > "SHBindToParent doesn't return the last id of the pidl param!\n");} Shouldn't we (for consistency sake) surround the call to pILFindLastID with a: if (pILFindLastID) Cheers, Paul.

2 1

Possible regression in CVS wine
by Pavel Troller Sept. 5, 2005

Sept. 5, 2005

Hi! I've just upgraded wine on my son's computer by today's CVS. He tried some games and one of them stopped working. It's hind95 and the game bails out on an illegal instruction - outb, jumping into winedbg. Backtrace shows just 3 levels of game code itself, no dlls involved. I understand that user code cannot perform direct hardware I/O, but the game worked just before the upgrade (on wine about 1 month old). I don't know whether wine is normally intercepting and emulating these instructions, and the CVS version doesn't, or whether a new wine caused that another code path has been activated in the game code, leading to such a problem. There is also native w2k version of the game (hind.exe) but it still doesn't work in wine: it very sllllooooowwwwwllllyyyy renders the splash screen and then sits there and does nothing more. The game can be freely downloaded from www.abandonia.com; just search "hind" in the title page. There is probably a dynamic download URL used so I'm not posting it there. With regards, Pavel Troller

2 2

Problems with winecfg and theming
by Ron Jensen Sept. 5, 2005

Sept. 5, 2005

On Wed Aug 31 14:19:53 CDT 2005, Kevin DeKorte wrote: >On Wednesday 31 August 2005 01:03 pm, Paul Vriens wrote: >> Hi, >> >> I'm not able to use winecfg and theming. If I select to add a theme I >> get an exception after selecting the file and clicking OK. >> >> the .msstyles files seems to have been copied to the right place. When I >> however start winecfg again and go to the Appearance tab I get a new >> exception. Remove everything under Resources/Themes 'fixes' this so >> there must be something wrong with the enumeration. >> >> Anybody else experiencing this? >> >> Paul. > > Yes, I can duplicate this crash as well. > > Kevin I was playing with theming after pulling from CVS on the 27th. I tried to use theming today after pulling from CVS on Sep 1. The Appearance tab worked before, it doesn't work now. Removing all the msstyles files from windows\resources\themes\*\ stops the crashing. I reversed patches 19901 and 19915 but that didn't seem to help. Ron

2 1

Re: DINPUT: protect FF_STATUS usage
by Marcelo Duarte Sept. 4, 2005

Sept. 4, 2005

Now it compiles... Thank you! Daniel Remenak escreveu: >Changelog: >Protect FF_STATUS usage to avoid compile errors on machines with old >linux/input.h > >This patch should fix Marcelo Duarte's reported compile error on FC2. > >This patch was made against a copy of joystick_linuxinput.c that >already had "linuxinput axis enumeration fixes" and "allow the >creation of an effect while unacquired" applied to it, but it should >apply to an earlier revision. > >--Daniel Remenak > > >------------------------------------------------------------------------ > >--- ../wine2/dlls/dinput/joystick_linuxinput.c 2005-09-03 14:29:30.000000000 -0700 >+++ dlls/dinput/joystick_linuxinput.c 2005-09-03 23:00:35.000000000 -0700 >@@ -302,7 +302,9 @@ > newDevice->ref = 1; > newDevice->joyfd = -1; > newDevice->dinput = dinput; >+#ifdef HAVE_STRUCT_FF_EFFECT_DIRECTION > newDevice->ff_state = FF_STATUS_STOPPED; >+#endif > memcpy(&(newDevice->guid),rguid,sizeof(*rguid)); > for (i=0;i<ABS_MAX;i++) { > newDevice->wantmin[i] = -32768; >@@ -723,9 +725,11 @@ > break; > } > break; >+#ifdef HAVE_STRUCT_FF_EFFECT_DIRECTION > case EV_FF_STATUS: > This->ff_state = ie.value; > break; >+#endif > default: > FIXME("joystick cannot handle type %d event (code %d)\n",ie.type,ie.code); > break; > > >------------------------------------------------------------------------ > > > >

1 0

MMIO error
by Matthew D'Asaro Sept. 4, 2005

Sept. 4, 2005

Hi, I have been trying to get a professional Audio restoration program, DCart32, to work in wine. Everything goes well until you try to run one of the "filters." These process wav files to remove clicks, hiss etc. The filter runs OK, but when it comes time to write the wav file modified in memory back to disk, it fails saying "The file contains a format not supported by DCart." At this point wine gives the error err:mmio:MMIO_ParseExtA No . in szFileName: "", which I have taken to mean that their is a problem in wine's implementation of the MMIO api. I have tried a native winmom.dll, but naturally that does not work at all; wine crashes on load. I have heard through another mailing list that this is an ancient regression, that this used to work. It is true that the filters work in Cedega, but run their DCart has so many graphical, and other problems, it is not usable. Any other suggestions or hints as to where I could start diffing code would be much appreciated. Thanks, Matthew D'Asaro

1 0

mail address
by Eric Pouech Sept. 4, 2005

Sept. 4, 2005

Hi folks, please note my new email address: eric.pouech(a)wanadoo.fr A+ -- Eric Pouech

3 3