January 2006 - Wine-Devel - list.winehq.org

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

re: What operating systems will Winelib run on non-x86 systems?
by Dan Kegel Nov. 21, 2006

Nov. 21, 2006

Hi Wei Li, last year, you asked in http://www.winehq.org/hypermail/wine-users/2004/06/0086.html > I could not find the info regarding what operating systems > (such as AIX 5L v5.2, HP-UX 11i, Solaris Release Level > 9) will Winelib run on non-x86 machines. I'll really > appreciate it if someone can provide my related link or > info. I can only find the following link regarding the > supporting OS but it does not provide Winelib's supporting > OS info: > http://www.winehq.org/site/docs/wine-faq/index 3.1. > Under what hardware > platform(s) and operating system(s) will Wine(Lib) run? I'm sorry nobody got back to you -- the wine-devel mailing list might have been a better place to ask. I believe winelib runs on the following non-x86 operating systems: Linux, Solaris, Mac OS X, and FreeBSD. There's no reason in principle it couldn't run on AIX or HP/UX. Some work has been done on an HP/UX port, but some assembly would be required to complete it: http://www.winehq.com/site/?issue=241#HP-UX%20Port Cheers, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

re: Wine-wiki broken by design
by Dan Kegel Nov. 16, 2006

Nov. 16, 2006

Maybe the wine wiki could publish a machine-readable sitemap; see http://www.xml-sitemaps.com/ http://www.google.com/webmasters/sitemaps/docs/en/about.html That would put less load on the server than letting Yahoo and Google crawl the wiki themselves. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 3

comctl32.dll: Running siap and modules under wine, first steps
by Maximiliano Curia June 12, 2006

June 12, 2006

Hi, I'm trying to use a program called "siap"[1] under wine. It's the required program to pay taxes that the Argentinian government uses. So, it's quite important for the free software community in Argentina to be able to use it in a free software environment. However, I haven't heard of any real success on it, so far. I've been trying to make it run using winetools[2], and differents versions of wine. The furthest I've gone, has been with version 20050310 and all the "plugins" that winetools provides, installed. Only then, could I install the application, run it, switch between the different modules (although it worked only sometimes), but I can't really use it. There are a couple of important widgets that seem to be incompatible with wine. But as I'm not an expert neither in Windows nor in wine, the one I could really track down is a TreeView widget (from comctl32.dll) (from the main window of the program), that is not fully implemented in wine, and by using a native comctl32.dll (I tried using the win98, winme, win2k libraries) the widget would work but some of the other stuff, like switching to one of the modules wouldn't. I made a screenshot to make this clearer, the wine version[3] and the w2k version[4]. So, what should I do next? Is there some documentation of how to implement a certain Windows widget in wine? Is anybody working in this dll, or has worked on this widget? I'd appreciate any comments. Thanks, [1] http://www.afip.gov.ar/programas/siap_main.asp (spanish only) [2] http://www.von-thadden.de/Joachim/WineTools/ [3] http://gnuservers.com.ar/~maxy/wine/siap-wine.png [4] http://gnuservers.com.ar/~maxy/wine/siap-w2k.png -- Saludos, /\/\ /\ >< `/

4 8

Grand Theft Auto... requires mscoree?
by Ivan Gyurdiev March 9, 2006

March 9, 2006

Grand Theft Auto... the never ending struggle to get it working. First I thought it was broken because of OLE...subsequently found out the installer was freezing, because of hidden message boxes. Now I've managed to install it in Desktop mode, but it dies when ran, with no output of any kind... Investigating shows: 000b:Call kernel32.SetUnhandledExceptionFilter(2027f1a8) ret=0115fbe9 000b:Ret kernel32.SetUnhandledExceptionFilter() retval=0115fb7c ret=0115fbe9 000b:Call kernel32.GetModuleHandleA(015459f4 "mscoree.dll") ret=0115ae6b 000b:Call ntdll.RtlInitAnsiString(7fcaf528,015459f4 "mscoree.dll") ret=2018d4fc 000b:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=2018d4fc 000b:Call ntdll.RtlAnsiStringToUnicodeString(7fffcbf8,7fcaf528,00000000) ret=2018d55b 000b:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=2018d55b 000b:Call ntdll.RtlInitUnicodeString(7fcaf52c,7fffcc00 L"mscoree.dll") ret=201a554d 000b:Ret ntdll.RtlInitUnicodeString() retval=00000018 ret=201a554d 000b:Call ntdll.LdrGetDllHandle(00000000,00000000,7fcaf52c,7fcaf534) ret=201a555b 000b:Ret ntdll.LdrGetDllHandle() retval=c0000135 ret=201a555b 000b:Call ntdll.RtlNtStatusToDosError(c0000135) ret=201a558a 000b:Ret ntdll.RtlNtStatusToDosError() retval=0000007e ret=201a558a 000b:Ret kernel32.GetModuleHandleA() retval=00000000 ret=0115ae6b 000b:Call kernel32.ExitProcess(00000001) ret=0115ae8f 000b:Call ntdll.LdrShutdownProcess() ret=201b03bd Looks like it doesn't like the missing mscoree.dll. I thought the .NET framework was not a core windows dll? Why would it require it? Also, installing a native dll doesn't seem to help...

2 3

PATCH/RFC: imagelist rewrite to use N x M grid
by Marcus Meissner Feb. 17, 2006

Feb. 17, 2006

Hi, This patch is a rewrite of the imagelist handling to not use a Nx1 grid, but a NxM grid with M definable in the source (currently 4). I have tested against winrar, "file open" and "make check". It is not completely regression tested, so I am not wanting to submit it right now. But I welcome comments. :) Ciao, Marcus Index: dlls/comctl32/imagelist.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/imagelist.c,v retrieving revision 1.101 diff -u -r1.101 imagelist.c --- dlls/comctl32/imagelist.c 14 Nov 2005 11:20:10 -0000 1.101 +++ dlls/comctl32/imagelist.c 28 Nov 2005 06:21:43 -0000 @@ -55,6 +55,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(imagelist); +#define PER_ROW 4 #define MAX_OVERLAYIMAGE 15 @@ -84,6 +85,12 @@ return himl && himl->magic == IMAGELIST_MAGIC; } +static DWORD index2x(INT index, INT cx) { return cx*(index/PER_ROW); } +static DWORD index2y(INT index, INT cy) { return cy*(index%PER_ROW); } + +static DWORD count2x(INT count, INT cx) { + return cx*((count+PER_ROW-1)/PER_ROW); +} /************************************************************************* * IMAGELIST_InternalExpandBitmaps [Internal] @@ -93,6 +100,8 @@ * PARAMS * himl [I] handle to image list * nImageCount [I] number of images to add + * cx [I] width of image + * cy [I] height of image * * RETURNS * nothing @@ -113,21 +122,22 @@ if (cy == 0) cy = himl->cy; nNewCount = himl->cCurImage + nImageCount + himl->cGrow; - nNewWidth = nNewCount * himl->cx; + nNewWidth = count2x(nNewCount,himl->cx); - TRACE("Create expanded bitmaps : himl=%p x=%d y=%d count=%d\n", himl, nNewWidth, cy, nNewCount); + TRACE("Create expanded bitmaps : himl=%p x=%d y=%d count=%d\n", himl, + nNewWidth, cy*PER_ROW, nNewCount); hdcBitmap = CreateCompatibleDC (0); - hbmNewBitmap = ImageList_CreateImage(hdcBitmap, himl, nNewWidth, cy); + hbmNewBitmap = ImageList_CreateImage(hdcBitmap, himl, nNewWidth, cy*PER_ROW); if (hbmNewBitmap == 0) - ERR("creating new image bitmap (x=%d y=%d)!\n", nNewWidth, cy); + ERR("creating new image bitmap (x=%d y=%d)!\n", nNewWidth, cy*PER_ROW); if(himl->cCurImage) { hbmNull = SelectObject (hdcBitmap, hbmNewBitmap); - BitBlt (hdcBitmap, 0, 0, himl->cCurImage * himl->cx, cy, - himl->hdcImage, 0, 0, SRCCOPY); + BitBlt (hdcBitmap, 0, 0, count2x(himl->cCurImage,himl->cx), + cy*PER_ROW, himl->hdcImage, 0, 0, SRCCOPY); SelectObject (hdcBitmap, hbmNull); } SelectObject (himl->hdcImage, hbmNewBitmap); @@ -136,7 +146,7 @@ if (himl->flags & ILC_MASK) { - hbmNewBitmap = CreateBitmap (nNewWidth, cy, 1, 1, NULL); + hbmNewBitmap = CreateBitmap (nNewWidth, cy*PER_ROW, 1, 1, NULL); if (hbmNewBitmap == 0) ERR("creating new mask bitmap!\n"); @@ -144,8 +154,8 @@ if(himl->cCurImage) { hbmNull = SelectObject (hdcBitmap, hbmNewBitmap); - BitBlt (hdcBitmap, 0, 0, himl->cCurImage * himl->cx, cy, - himl->hdcMask, 0, 0, SRCCOPY); + BitBlt (hdcBitmap, 0, 0, count2x(himl->cCurImage,himl->cx), + cy*PER_ROW, himl->hdcMask, 0, 0, SRCCOPY); SelectObject (hdcBitmap, hbmNull); } SelectObject (himl->hdcMask, hbmNewBitmap); @@ -179,7 +189,7 @@ { HDC hdcBitmap; INT nFirstIndex, nImageCount; - INT nStartX; + INT i; BITMAP bmp; HBITMAP hOldBitmap; @@ -192,43 +202,42 @@ IMAGELIST_InternalExpandBitmaps (himl, nImageCount, bmp.bmWidth, bmp.bmHeight); - nStartX = himl->cCurImage * himl->cx; - hdcBitmap = CreateCompatibleDC(0); - hOldBitmap = SelectObject(hdcBitmap, hbmImage); - /* Copy result to the imagelist - */ - BitBlt (himl->hdcImage, nStartX, 0, bmp.bmWidth, bmp.bmHeight, - hdcBitmap, 0, 0, SRCCOPY); - - if(himl->hbmMask) - { - HDC hdcTemp; - HBITMAP hOldBitmapTemp; - - hdcTemp = CreateCompatibleDC(0); - hOldBitmapTemp = SelectObject(hdcTemp, hbmMask); + for (i=himl->cCurImage;i<himl->cCurImage+nImageCount;i++) { + /* Copy result to the imagelist */ + BitBlt (himl->hdcImage, index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, hdcBitmap, himl->cx*(i-himl->cCurImage), 0, SRCCOPY); - BitBlt (himl->hdcMask, - nStartX, 0, bmp.bmWidth, bmp.bmHeight, - hdcTemp, - 0, 0, - SRCCOPY); + if(himl->hbmMask) + { + HDC hdcTemp; + HBITMAP hOldBitmapTemp; - SelectObject(hdcTemp, hOldBitmapTemp); - DeleteDC(hdcTemp); + hdcTemp = CreateCompatibleDC(0); + hOldBitmapTemp = SelectObject(hdcTemp, hbmMask); - /* Remove the background from the image - */ - BitBlt (himl->hdcImage, - nStartX, 0, bmp.bmWidth, bmp.bmHeight, - himl->hdcMask, - nStartX, 0, - 0x220326); /* NOTSRCAND */ + BitBlt (himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, + hdcTemp, + himl->cx*(i-himl->cCurImage), 0, + SRCCOPY); + + SelectObject(hdcTemp, hOldBitmapTemp); + DeleteDC(hdcTemp); + + /* Remove the background from the image + */ + BitBlt (himl->hdcImage, + index2x(i,himl->cx), index2y(i,himl->cy), + bmp.bmWidth, bmp.bmHeight, + himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + 0x220326); /* NOTSRCAND */ + } } - SelectObject(hdcBitmap, hOldBitmap); DeleteDC(hdcBitmap); @@ -278,12 +287,12 @@ INT WINAPI ImageList_AddMasked (HIMAGELIST himl, HBITMAP hBitmap, COLORREF clrMask) { - HDC hdcMask, hdcBitmap; - INT nIndex, nImageCount, nMaskXOffset=0; + HDC hdcBitmap; + INT nIndex, nImageCount; BITMAP bmp; HBITMAP hOldBitmap; - HBITMAP hMaskBitmap=0; COLORREF bkColor; + int i; TRACE("himl=%p hbitmap=%p clrmask=%lx\n", himl, hBitmap, clrMask); if (!is_valid(himl)) @@ -292,6 +301,8 @@ if (!GetObjectA (hBitmap, sizeof(BITMAP), &bmp)) return -1; + TRACE("bitmap is %d x %d, himl is %d x %d\n", + bmp.bmWidth, bmp.bmHeight, himl->cx, himl->cy); if (himl->cx > 0) nImageCount = bmp.bmWidth / himl->cx; else @@ -304,67 +315,55 @@ hdcBitmap = CreateCompatibleDC(0); - hOldBitmap = SelectObject(hdcBitmap, hBitmap); - if(himl->hbmMask) - { - hdcMask = himl->hdcMask; - nMaskXOffset = nIndex * himl->cx; - } - else - { - /* - Create a temp Mask so we can remove the background of - the Image (Windows does this even if there is no mask) - */ - hdcMask = CreateCompatibleDC(0); - hMaskBitmap = CreateBitmap(bmp.bmWidth, bmp.bmHeight, 1, 1, NULL); - SelectObject(hdcMask, hMaskBitmap); - nMaskXOffset = 0; - } + /* create monochrome image to the mask bitmap */ bkColor = (clrMask != CLR_DEFAULT) ? clrMask : GetPixel (hdcBitmap, 0, 0); - SetBkColor (hdcBitmap, bkColor); - BitBlt (hdcMask, - nMaskXOffset, 0, bmp.bmWidth, bmp.bmHeight, - hdcBitmap, 0, 0, - SRCCOPY); - SetBkColor(hdcBitmap, RGB(255,255,255)); - /*Remove the background from the image - */ - /* - WINDOWS BUG ALERT!!!!!! - The statement below should not be done in common practice - but this is how ImageList_AddMasked works in Windows. - It overwrites the original bitmap passed, this was discovered - by using the same bitmap to iterate the different styles - on windows where it failed (BUT ImageList_Add is OK) - This is here in case some apps rely on this bug - */ - BitBlt(hdcBitmap, - 0, 0, bmp.bmWidth, bmp.bmHeight, - hdcMask, - nMaskXOffset, 0, - 0x220326); /* NOTSRCAND */ - /* Copy result to the imagelist - */ - BitBlt (himl->hdcImage, - nIndex * himl->cx, 0, bmp.bmWidth, bmp.bmHeight, - hdcBitmap, - 0, 0, - SRCCOPY); + for (i=nIndex; i<himl->cCurImage; i++) { + if (himl->hbmMask) { + SetBkColor (hdcBitmap, bkColor); + + BitBlt (himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, + hdcBitmap, himl->cx*(i-nIndex), 0, + SRCCOPY); + + SetBkColor(hdcBitmap, RGB(255,255,255)); + /*Remove the background from the image + */ + /* + WINDOWS BUG ALERT!!!!!! + The statement below should not be done in common practice + but this is how ImageList_AddMasked works in Windows. + It overwrites the original bitmap passed, this was discovered + by using the same bitmap to iterate the different styles + on windows where it failed (BUT ImageList_Add is OK) + This is here in case some apps rely on this bug + */ + BitBlt(hdcBitmap, + himl->cx*(i-nIndex), 0, himl->cx, himl->cy, + himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + 0x220326); /* NOTSRCAND */ + } + /* Copy result to the imagelist + */ + BitBlt (himl->hdcImage, + index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, + hdcBitmap, + himl->cx*(i-nIndex), 0, + SRCCOPY); + } + /* Clean up */ + SelectObject(hdcBitmap, hOldBitmap); DeleteDC(hdcBitmap); - if(!himl->hbmMask) - { - DeleteObject(hMaskBitmap); - DeleteDC(hdcMask); - } - return nIndex; } @@ -478,19 +477,20 @@ /* image */ SelectObject (hdcBmp, hbmTempImage); StretchBlt (hdcBmp, 0, 0, himlSrc->cx, himlSrc->cy, - himlDst->hdcImage, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - SRCCOPY); + himlDst->hdcImage, index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), + himlDst->cx, himlDst->cy, SRCCOPY); /* mask */ SelectObject (hdcBmp, hbmTempMask); StretchBlt (hdcBmp, 0, 0, himlSrc->cx, himlSrc->cy, - himlDst->hdcMask, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - SRCCOPY); + himlDst->hdcMask, index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), + himlDst->cx, himlDst->cy, SRCCOPY); /* copy (and stretch) source to destination */ /* image */ - StretchBlt (himlDst->hdcImage, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - himlSrc->hdcImage, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, - SRCCOPY); + StretchBlt (himlDst->hdcImage, index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), + himlDst->cx, himlDst->cy, + himlSrc->hdcImage, index2x(iSrc,himlSrc->cx), index2y(iSrc,himlSrc->cy), + himlSrc->cx, himlSrc->cy, SRCCOPY); /* mask */ StretchBlt (himlDst->hdcMask, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, himlSrc->hdcMask, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, @@ -511,13 +511,17 @@ } else { /* copy image */ - StretchBlt (himlDst->hdcImage, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - himlSrc->hdcImage, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, + StretchBlt (himlDst->hdcImage, + index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), himlDst->cx, himlDst->cy, + himlSrc->hdcImage, + index2x(iSrc,himlSrc->cx), index2y(iSrc,himlSrc->cy), himlSrc->cx, himlSrc->cy, SRCCOPY); /* copy mask */ - StretchBlt (himlDst->hdcMask, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - himlSrc->hdcMask, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, + StretchBlt (himlDst->hdcMask, + index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), himlDst->cx, himlDst->cy, + himlSrc->hdcMask, + index2x(iSrc,himlSrc->cx), index2y(iSrc,himlSrc->cy), himlSrc->cx, himlSrc->cy, SRCCOPY); } @@ -597,15 +601,15 @@ himl->uBitsPixel = (UINT)GetDeviceCaps (himl->hdcImage, BITSPIXEL); if (himl->cMaxImage > 0) { - himl->hbmImage = ImageList_CreateImage(himl->hdcImage, himl, cx * himl->cMaxImage, cy); + himl->hbmImage = ImageList_CreateImage(himl->hdcImage, himl, + count2x(himl->cMaxImage,cx), cy*PER_ROW); SelectObject(himl->hdcImage, himl->hbmImage); } else himl->hbmImage = 0; if ((himl->cMaxImage > 0) && (himl->flags & ILC_MASK)) { - himl->hbmMask = - CreateBitmap (himl->cx * himl->cMaxImage, himl->cy, - 1, 1, NULL); + himl->hbmMask = CreateBitmap (count2x(himl->cMaxImage,himl->cx), + himl->cy * PER_ROW, 1, 1, NULL); if (himl->hbmMask == 0) { ERR("Error creating mask bitmap!\n"); goto cleanup; @@ -1053,7 +1057,7 @@ */ BOOL WINAPI -ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) +ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) { INT cx, cy, lx, ly, nOvlIdx; DWORD fState, dwRop; @@ -1068,8 +1072,8 @@ if (!is_valid(himl)) return FALSE; if ((pimldp->i < 0) || (pimldp->i >= himl->cCurImage)) return FALSE; - lx = himl->cx * pimldp->i + pimldp->xBitmap; - ly = pimldp->yBitmap; + lx = index2x(pimldp->i,himl->cx) + pimldp->xBitmap; + ly = index2y(pimldp->i,himl->cy) + pimldp->yBitmap; fState = pimldp->cbSize < sizeof(IMAGELISTDRAWPARAMS) ? ILS_NORMAL : pimldp->fState; fStyle = pimldp->fStyle & ~ILD_OVERLAYMASK; @@ -1187,10 +1191,11 @@ if ( (nOvlIdx >= 1) && (nOvlIdx <= MAX_OVERLAYIMAGE)) { nOvlIdx = himl->nOvlIdx[nOvlIdx - 1]; if ((nOvlIdx >= 0) && (nOvlIdx < himl->cCurImage)) { - const INT ox = himl->cx * nOvlIdx + pimldp->xBitmap; + const INT ox = index2x(nOvlIdx,himl->cx) + pimldp->xBitmap; + const INT oy = index2y(nOvlIdx,himl->cy) + pimldp->yBitmap; if (himl->hbmMask && !(fStyle & ILD_IMAGE)) - BitBlt (hImageDC, 0, 0, cx, cy, hMaskListDC, ox, ly, SRCAND); - BitBlt (hImageDC, 0, 0, cx, cy, hImageListDC, ox, ly, SRCPAINT); + BitBlt (hImageDC, 0, 0, cx, cy, hMaskListDC, ox, oy, SRCAND); + BitBlt (hImageDC, 0, 0, cx, cy, hImageListDC, ox, oy, SRCPAINT); } } @@ -1259,11 +1264,13 @@ if (himlDst) { - BitBlt (himlDst->hdcImage, 0, 0, himlSrc->cCurImage * himlSrc->cx, himlSrc->cy, + BitBlt (himlDst->hdcImage, 0, 0, + count2x(himlSrc->cCurImage,himlSrc->cx), himlSrc->cy*PER_ROW, himlSrc->hdcImage, 0, 0, SRCCOPY); if (himlDst->hbmMask) - BitBlt (himlDst->hdcMask, 0, 0, himlSrc->cCurImage * himlSrc->cx, himlSrc->cy, + BitBlt (himlDst->hdcMask, 0, 0, + count2x(himlSrc->cCurImage,himlSrc->cx), himlSrc->cy*PER_ROW, himlSrc->hdcMask, 0, 0, SRCCOPY); himlDst->cCurImage = himlSrc->cCurImage; @@ -1421,7 +1428,9 @@ hOldDstBitmap = SelectObject (hdcDst, ii.hbmMask); if (himl->hbmMask) { BitBlt (hdcDst, 0, 0, himl->cx, himl->cy, - himl->hdcMask, i * himl->cx, 0, SRCCOPY); + himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + SRCCOPY); } else PatBlt (hdcDst, 0, 0, himl->cx, himl->cy, BLACKNESS); @@ -1429,7 +1438,8 @@ /* draw image*/ SelectObject (hdcDst, ii.hbmColor); BitBlt (hdcDst, 0, 0, himl->cx, himl->cy, - himl->hdcImage, i * himl->cx, 0, SRCCOPY); + himl->hdcImage, + index2x(i,himl->cx), index2y(i,himl->cy), SRCCOPY); /* * CreateIconIndirect requires us to deselect the bitmaps from @@ -1531,11 +1541,10 @@ pImageInfo->hbmImage = himl->hbmImage; pImageInfo->hbmMask = himl->hbmMask; - pImageInfo->rcImage.top = 0; - pImageInfo->rcImage.bottom = himl->cy; - pImageInfo->rcImage.left = i * himl->cx; - pImageInfo->rcImage.right = (i+1) * himl->cx; - + pImageInfo->rcImage.top = index2y(i,himl->cy); + pImageInfo->rcImage.bottom = index2y(i,himl->cy)+himl->cy; + pImageInfo->rcImage.left = index2x(i,himl->cx); + pImageInfo->rcImage.right = index2x(i,himl->cx)+himl->cx; return TRUE; } @@ -1566,11 +1575,10 @@ if ((i < 0) || (i >= himl->cCurImage)) return FALSE; - lpRect->left = i * himl->cx; - lpRect->top = 0; + lpRect->left = index2x(i,himl->cx); lpRect->right = lpRect->left + himl->cx; - lpRect->bottom = himl->cy; - + lpRect->top = index2y(i,himl->cy); + lpRect->bottom = lpRect->top + himl->cy; return TRUE; } @@ -1724,7 +1732,6 @@ HIMAGELIST himlDst = NULL; INT cxDst, cyDst; INT xOff1, yOff1, xOff2, yOff2; - INT nX1, nX2; TRACE("(himl1=%p i1=%d himl2=%p i2=%d dx=%d dy=%d)\n", himl1, i1, himl2, i2, dx, dy); @@ -1768,25 +1775,29 @@ if (himlDst) { - nX1 = i1 * himl1->cx; - nX2 = i2 * himl2->cx; + int x1, x2, y1, y2; + + x1 = index2x(i1,himl1->cx); + y1 = index2y(i1,himl1->cy); + x2 = index2x(i2,himl2->cx); + y2 = index2y(i2,himl2->cy); /* copy image */ BitBlt (himlDst->hdcImage, 0, 0, cxDst, cyDst, himl1->hdcImage, 0, 0, BLACKNESS); if (i1 >= 0 && i1 < himl1->cCurImage) - BitBlt (himlDst->hdcImage, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcImage, nX1, 0, SRCCOPY); + BitBlt (himlDst->hdcImage, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcImage, x1, y1, SRCCOPY); if (i2 >= 0 && i2 < himl2->cCurImage) { - BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask , nX2, 0, SRCAND); - BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcImage, nX2, 0, SRCPAINT); + BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask , x2, y2, SRCAND); + BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcImage, x2, y2, SRCPAINT); } /* copy mask */ BitBlt (himlDst->hdcMask, 0, 0, cxDst, cyDst, himl1->hdcMask, 0, 0, WHITENESS); if (i1 >= 0 && i1 < himl1->cCurImage) - BitBlt (himlDst->hdcMask, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcMask, nX1, 0, SRCCOPY); + BitBlt (himlDst->hdcMask, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcMask, x1, y1, SRCCOPY); if (i2 >= 0 && i2 < himl2->cCurImage) - BitBlt (himlDst->hdcMask, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask, nX2, 0, SRCAND); + BitBlt (himlDst->hdcMask, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask, x2, y2, SRCAND); himlDst->cCurImage = 1; } @@ -1862,6 +1873,7 @@ nheight = cy; nRows = (height/cy); + FIXME("nwidth %d, nheight %d, cy %d\n", nwidth, nheight, cy); if (bitsperpixel==1) hbitmap = CreateBitmap(nwidth,nheight,1,1,NULL); else @@ -2048,36 +2060,36 @@ for (nCount = 0; nCount < MAX_OVERLAYIMAGE; nCount++) himl->nOvlIdx[nCount] = -1; - hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, himl->cMaxImage * himl->cx, himl->cy); + hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, + count2x(himl->cMaxImage,himl->cx), himl->cy*PER_ROW); SelectObject (himl->hdcImage, hbmNewImage); DeleteObject (himl->hbmImage); himl->hbmImage = hbmNewImage; if (himl->hbmMask) { - hbmNewMask = CreateBitmap (himl->cMaxImage * himl->cx, himl->cy, + hbmNewMask = CreateBitmap (count2x(himl->cMaxImage,himl->cx), himl->cy*PER_ROW, 1, 1, NULL); SelectObject (himl->hdcMask, hbmNewMask); DeleteObject (himl->hbmMask); himl->hbmMask = hbmNewMask; } - } - else { + } else { /* delete one image */ TRACE("Remove single image! %d\n", i); /* create new bitmap(s) */ nCount = (himl->cCurImage + himl->cGrow - 1); - cxNew = nCount * himl->cx; + cxNew = count2x(nCount , himl->cx); TRACE(" - Number of images: %d / %d (Old/New)\n", himl->cCurImage, himl->cCurImage - 1); TRACE(" - Max. number of images: %d / %d (Old/New)\n", himl->cMaxImage, himl->cCurImage + himl->cGrow - 1); - hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, cxNew, himl->cy); + hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, cxNew, himl->cy*PER_ROW); if (himl->hbmMask) - hbmNewMask = CreateBitmap (cxNew, himl->cy, 1, 1, NULL); + hbmNewMask = CreateBitmap (cxNew, himl->cy*PER_ROW, 1, 1, NULL); else hbmNewMask = 0; /* Just to keep compiler happy! */ @@ -2085,31 +2097,45 @@ /* copy all images and masks prior to the "removed" image */ if (i > 0) { - TRACE("Pre image copy: Copy %d images\n", i); + int n = count2x(i,1); - SelectObject (hdcBmp, hbmNewImage); - BitBlt (hdcBmp, 0, 0, i * himl->cx, himl->cy, - himl->hdcImage, 0, 0, SRCCOPY); - - if (himl->hbmMask) { - SelectObject (hdcBmp, hbmNewMask); - BitBlt (hdcBmp, 0, 0, i * himl->cx, himl->cy, - himl->hdcMask, 0, 0, SRCCOPY); + TRACE("Pre image copy: Copy %d images\n", i); + if (n) { /* copy started rows */ + SelectObject (hdcBmp, hbmNewImage); + BitBlt (hdcBmp, 0, 0, n * himl->cx, himl->cy * PER_ROW, + himl->hdcImage, 0, 0, SRCCOPY); + + if (himl->hbmMask) { + SelectObject (hdcBmp, hbmNewMask); + BitBlt (hdcBmp, 0, 0, n * himl->cx, himl->cy * PER_ROW, + himl->hdcMask, 0, 0, SRCCOPY); + } } + /* this might copy some images more. But we will + * overwrite them right afterwards */ } /* copy all images and masks behind the removed image */ if (i < himl->cCurImage - 1) { + int j; + TRACE("Post image copy!\n"); - SelectObject (hdcBmp, hbmNewImage); - BitBlt (hdcBmp, i * himl->cx, 0, (himl->cCurImage - i - 1) * himl->cx, - himl->cy, himl->hdcImage, (i + 1) * himl->cx, 0, SRCCOPY); + + /* copy the post-i images one-by-one */ + SelectObject (hdcBmp, hbmNewImage); + for (j=i;j<himl->cCurImage -1;j++) + BitBlt (hdcBmp, index2x(j,himl->cx), index2y(j,himl->cy), himl->cx, himl->cy, + himl->hdcImage, index2x(j+1,himl->cx), index2y(j+1,himl->cy), SRCCOPY); if (himl->hbmMask) { SelectObject (hdcBmp, hbmNewMask); - BitBlt (hdcBmp, i * himl->cx, 0, - (himl->cCurImage - i - 1) * himl->cx, - himl->cy, himl->hdcMask, (i + 1) * himl->cx, 0, SRCCOPY); + for (j=i;j<himl->cCurImage -1;j++) + BitBlt (hdcBmp, + index2x(j,himl->cx), index2y(j,himl->cy), + himl->cx, himl->cy, + himl->hdcMask, + index2x(j+1,himl->cx), index2y(j+1,himl->cy), + SRCCOPY); } } @@ -2290,12 +2316,16 @@ SetBkColor (himl->hdcImage, RGB(255,255,255)); hbmOldSrc = SelectObject (hdcImage, ii.hbmColor); - StretchBlt (himl->hdcImage, nIndex * himl->cx, 0, himl->cx, himl->cy, - hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, SRCCOPY); + StretchBlt (himl->hdcImage, + index2x(nIndex,himl->cx), index2y(nIndex,himl->cy), + himl->cx, himl->cy, + hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, SRCCOPY); if (himl->hbmMask) { SelectObject (hdcImage, ii.hbmMask); - StretchBlt (himl->hdcMask, nIndex * himl->cx, 0, himl->cx, himl->cy, + StretchBlt (himl->hdcMask, + index2x(nIndex,himl->cx), index2y(nIndex,himl->cy), + himl->cx, himl->cy, hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, SRCCOPY); }

2 1

re: What would most aid WINE development?
by Daniel Kegel Feb. 16, 2006

Feb. 16, 2006

Susheel Daswani wrote: > For my 'Antitrust & IP' course this semester I am writing a brief > about why I think the remedy in the Microsoft antitrust case was > inadequate. Back in the day, I wrote an essay about this; it's online at http://kegel.com/remedy/ in particular, http://www.usdoj.gov/atr/cases/ms_tuncom/major/mtc-00028571.htm I now think my essay was naive, but hey, I was young :-) It would be interesting to see the complaints sent to the Technical Committee ( http://www.thetc.org/ ) but I doubt they're public. You might also want to read http://www.lessig.org/content/testimony/msft/msft.pdf if you haven't already. > So my question for the WINE developers is "What materials from > Microsoft would most aid the development of WINE"? The Windows API is > of course public, so my guess is that isn't a huge bar to creating > WINE. So what are the bars? Is it simply the scope of the project? > Is there information that MS could divulge that would greatly aid the > WINE effort? Would open sourcing part of Windows help? As others have noted, the Windows API is not completely public nor particularly well-defined. This makes things harder, but it's not really the main obstacle. Here are a few things a judge could order Microsoft to do that would help Wine: * order them to break up into two companies, one for operating systems and .net, one for everything else * donate gobs of cash to Wine * offer a perpetual, transferrable, royalty-free, GPL-compatible license for its protocols and data formats * support ODF in Microsoft Office That last item is kind of indirect. It would make it much easier for everybody to switch to OpenOffice, which would make it much easier for everybody to switch to Linux, which is the whole point of Wine. - Dan -- Wonder why Aunt Tilly still won't use Linux? See http://kegel.com/linux/comfort

9 12

Re: WINE 0.9.3 and Photoshop 7 & CS
by Aleksey Feb. 16, 2006

Feb. 16, 2006

The patch has been found that breaks Photoshop, but 0.9.6 still brakes PS. On 1/6/06, Aleksey <anime4christ(a)gmail.com> wrote: > Great! Thanks! > > On 1/1/06, Elvis Pranskevichus <elprans(a)gmail.com> wrote: > > Aleksey wrote: > > > Yesterday I upgraded to WINE 0.9.3, and then tried running Photoshop > > > 7. Photoshop gave me a hardware error. I thought, no problem, I'll > > > just reinstall it, same result. Then I reconfigured WINE using > > > winetools and tried again, same thing. Here is what I got in the > > > Terminal when running Photoshop 7: > > > > > > fixme:actctx:QueryActCtxW stub! > > > fixme:font:WineEngRemoveFontResourceEx :stub > > > fixme:win:EnumDisplayDevicesW ((null),0,0x7fa7de2c,0x00000000), stub! > > > fixme:win:EnumDisplayDevicesW > > > (L"\\\\.\\DISPLAY1",0,0x7fa7de2c,0x00000000), stub! > > > fixme:mscms:EnumColorProfilesA ( (nil), 0x7fa7e694, 0x7fa7e1ac, > > > 0x7fa7e6f4, 0x7fa7e704 ) stub > > > fixme:win:EnumDisplayDevicesW ((null),0,0x7fa7de34,0x00000000), stub! > > > fixme:win:EnumDisplayDevicesW > > > (L"\\\\.\\DISPLAY1",0,0x7fa7de34,0x00000000), stub! > > > fixme:mscms:EnumColorProfilesA ( (nil), 0x7fa7e69c, 0x7fa7e1b4, > > > 0x7fa7e6fc, 0x7fa7e70c ) stub > > > err:shell:HCR_GetFolderAttributes HCR_GetFolderAttributes should be > > > called for simple PIDL's only! > > > fixme:font:WineEngRemoveFontResourceEx :stub > > > fixme:font:WineEngRemoveFontResourceEx :stub > > > > > > Then I tried installing Photoshop CS, knowing that it worked fine with > > > 0.9.2. Photoshop CS told me that certain required files was missing, > > > but I forgot to get down the results from the Terminal. After that I > > > downgraded to WINE 0.9.2 and both versions of Photoshop work great. > > > > > > A little side note: ImageReady 7 works great under 0.9.3, I did not > > > test ImageReady CS. ImageReady 7 works great under 0.9.2 also, but > > > ImageReady CS crashes. > > > > > > God Bless. > > > - Aleksey > > > > > > > > > > Hi, > > > > I've found the patch that breaks the thing. GIT commit-ish is 0b17529332b0ef5ee57873afd4ded6f359e76781. (http://source.winehq.org/git/?p=wine.git;a=commit;h=0b17529332b0ef5ee57873a…) > > > > I haven't looked at it deeply, just done some git bisect's. > > > > -- > > Elvis Pranskevichus - elprans(a)gmail.com > > > > >

3 6

Startup time of OOo2, Firefox 1.5. Some surprises.
by Dan Kegel Feb. 15, 2006

Feb. 15, 2006

To see how reasonable it might be to use OOo 2.0.1 and Firefox 1.5 under Wine routinely, I benchmarked their startup time on a Fedora Core 5 test 2 system under four conditions: native vs. with wine from cvs, and with 416MB RAM vs. 96 MB RAM (by booting with mem=96M; this was to simulate running on one of those cheapo 128MB boxes that uses shared video RAM). This was on a zippy Compaq Presario 3000 Athlon 64 3000+. All apps were downloaded from openoffice.org and mozilla.com. Results for first run of app after booting (1st column is startup time): 5 Firefox run1 native 416MB 12 Firefox run1 wine 416MB 11 Firefox run1 native 96MB 15 Firefox run1 wine 96MB 11 ooo run1 native 416MB 15 ooo run1 wine 416MB 60 ooo run1 native 96MB 37 ooo run1 wine 96MB So wine is 1.4 to 2.5 times slower at app startup generally, but when ram is really short, win32 openoffice starts up with wine 1.5 times *faster* than the native linux version! (Maybe because the Microsoft tools are better at avoiding I/O or relocations during loading?) I then measured how long it took to start up the app the second time, when the cache was nice and hot: 3 Firefox run2 native 416MB 4 Firefox run2 wine 416MB 4 ooo run2 native 416MB 6 ooo run2 wine 416MB 4 Firefox run2 native 96MB 6 Firefox run2 wine 96MB 36 ooo run2 native 96MB 28 ooo run2 wine 96MB The times are uniformly faster on the second run, but the patter holds, i.e. wine is 1.4-1.5 times slower than native generally, but win32 openoffice under wine is 1.5 times *faster* than the native version when starved for RAM. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 12

Re: Small CVS-Update-Script
by Christian Lachner Feb. 12, 2006

Feb. 12, 2006

I know that there is something like my script out there but i did (again) spend some time on rewriting my own one since i like it better ;). This one is compeltely different from my first one - it works the same, but does some checks before doing anything , the code is written nicer and cleaner and the output is also very nice now :D. Have fun with this piece of code! On 10/2/05, Andreas Schneider <andreas.schneider(a)linux-gamers.net> wrote: > Hi gladiac, > > take a look at > > http://winecvs.linux-gamers.net/ > > Cheers, > > -- andreas > > Gladiac Spark wrote: > > This is nothing special but may be useful for some people out there > > having problems updating their cvs-trees or being lazy writing some > > commands in their console. Copy the 'getwinecvs' to /usr/src or wherever > > you want (don't forget to edit the SRC=Variable if you're doing so) and > > chmod it to give you x-rights. (e.g.: 'chmod 750 getwinecvs' without quotes) > > > > By running it, it will search for an existing wine-tree... if there is > > one, it will be cleaned and then updated; if not, the complete tree will > > be downloaded. > > When using -c as parameter for getwinecvs, it will automatically begin > > to compile after getting all the updates and then install. > > To see what it exactly does, have a look at the source. > > > > Even if it is called General CVS-Updater by gladiac it has been written > > FOR wine. I hope it is helpful for others. I know it's not very nerdy > > but.... who cares ;). > > > > > > ------------------------------------------------------------------------ > > > > > > -- > http://www.linux-gamers.net - your online gaming resource > >

3 9

StretchDIBits function problem.
by Cyril Margorin Feb. 10, 2006

Feb. 10, 2006

Hello, I've discovered, that using of GetDIBits after StretchDIBits doesn't return correct data. More then - all pixels that it returns are black. In attachment the test function. Changelog: Cyril Margorin <comargo(a)gmail.com> add test of StretchDIBits()/GetDIBits() bunch to gdi/test/bitmap.c -- Cyril Margorin

4 4

Regression problems in app - help with debugging?
by Dr J A Gow Feb. 9, 2006

Feb. 9, 2006

Hello All, I have some regression problems relating to Wine in a commercial ECAD app 'Easy-PC' version 9.0, available from http://www.numberone.com The application was quite usable on Crossover Office 4.2, with just some minor dialog corruption. Alpha versions of Wine available at the same time (can not exactly remember which ones) could also run it successfully. However, under the latest Wine 0.9.6, Wine CVS and CXO 5.0.1 it does not work. Note that it does not crash, it errors out cleanly with a dialog box message. I have been debugging the problems in this app for some time now. It is a critical app for me as I use it in a production environment, but I do not want to pay Microsoft for the privilege of exposing my machine to malware. I am thus prepared to help debug Wine to get this application running. However, my Windows programming experience is limited to device drivers, not apps (although fluent C/C++ systems programming on other platforms), I have hit a brick wall, possibly due to my limited knowledge of how the Windows API works and I will need some help with this. If anyone would like to help me debug this app (hope springs eternal!), a demo version of the app is available free of charge from the web site address above, and this version exhibits the same problems as the full version. Background ------------- The system: Dual physical processor (not dual core) Opteron running SuSE 10.0 x86_64 SMP. Wine: Latest 0.9.6 release, up to CVS grabbed a week or so ago. The application installs OK and when run, puts up a GUI as expected. However, when you try to create a new PCB or schematic, an error dialog box is displayed indicating that the app can not read the technology file Default.stf (schematic) or Default.ptf (pcb). This is _not_ a permissions problem, all files are actually present and the same install will work under CXO 4.2. I generated and analyzed several hundred MB of logfiles over many days, added extra debug statements to the Wine code and analyzed the application's operation. The problem actually appears to have two causes, and this is what I have come up with so far. Problem 1 ----------- Application calls StgOpenStorage with a grfMode flag of 0x10020 (STGM_TRANSACTED | STGM_SHARE_DENY_WRITE). Immediately afterwards it calls StorageBaseImpl_OpenStream with a grfMode of 0x12 (STGM_SHARE_EXCLUSIVE | STGM_READWRITE). This second call fails with an access denied error code, after which the logs show an easily traced error handling sequence leading to display of the error dialog mentioned above: 0009:Call ole32.StgOpenStorage(59693db0 L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.ptf",00000000,00010020,00000000,00000000,5821f850) ret=1022e7f0 ... ... trace:storage:StgOpenStorage <-- 00000000, IStorage 0x5b3465f8 0009:Ret ole32.StgOpenStorage() retval=00000000 ret=1022e7f0 ... ... trace:storage:StorageBaseImpl_OpenStream (0x5b3465f8, L"\0005FileType", (nil), 12, 0, 0x5821f848) fixme:storage:StorageBaseImpl_OpenStream STORAGE ACCESS DENIED - parent 0, this 2 Note that the last fixme is one I added to find out exactly what was going on here. Now, logic would dictate that the grfMode of the OpenStream method call is indeed incompatible with that of its parent storage object. However, I would have thought that the application coders would most likely have hard-coded the grfMode flags in the application. If so, it would seem that the app is buggy, yet this application works on Windows! Either the app is buggy and the Win32 OLE32 implementation behaves differently, or I am missing something here. Ok, so with no obvious solution to this problem, I decided to bypass it. I modified the storage32.c implementation in the following way to bypass the grfMode check: parent_grfMode = STGM_ACCESS_MODE( This->ancestorStorage->base.openFlags ); *if* ( STGM_ACCESS_MODE( grfMode ) > STGM_ACCESS_MODE( parent_grfMode ) ) { FIXME("StorageBase_OpenStream called with grfMode mismatch - parent %d, this %d\n", parent_grfMode,STGM_ACCESS_MODE(grfMode)); ///res = STG_E_ACCESSDENIED;/ ///goto end;/ } Obviously not a viable fix, but a hack to get it working. After implementing this, the OpenStream call succeeded, as did subsequent stream access. However, the app _still_ errored out in exactly the same manner and at the same time. After more log searching, this led to the discovery of the second problem. Problem 2 ----------- During its loading and setup, the application repeatedly calls StgOpenStorage on the .stf/.ptf files in question, calls OpenStream, reads from the stream, and then finally closes the storage. I placed tell-tales in useful locations in the file open/close handlers in the wineserver, and could clearly see the files being opened and subsequently closed. This open/read/close occurs correctly and in sequence up to a certain point. At this point in the execution, the app calls StgOpenStorage on the technology file, with the following call. It is opened correctly, with grfMode of STGM_TRANSACTED | STGM_SHARED_DENY_WRITE | STGM_READWRITE: 0009:Call ole32.StgOpenStorage(5821f754 L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.ptf",00000000,00010022,00000000,00000000,5821f7f4) ret=7c17eabc trace:storage:StgOpenStorage (L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.ptf", (nil), 10022, (nil), 0, 0x5821f7f4) ... ... ... trace:storage:StorageBaseImpl_AddRef (0x5b3465f8) AddRef to 1 trace:storage:StgOpenStorage <-- 00000000, IStorage 0x5b3465f8 0009:Ret ole32.StgOpenStorage() retval=00000000 ret=7c17eabc Almost immediately, the app opens three streams in this object and starts to access them, all successfully. There follows a whole slew of logging statements, all of which appear sensible However, what is strange about this access is that soon we seem to be frantically increasing the storage object's reference pointer. This sequence appears frequently in the code, closely spaced but interspersed with what seems quite logical and successful calls to seek functions and memory allocation functions: 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000030) ret=584e498b 0009:Ret ntdll.RtlAllocateHeap() retval=55926480 ret=584e498b trace:storage:StorageBaseImpl_AddRef (0x5b3465f8) AddRef to 9 trace:storage:StorageImpl_ReadProperty storage name: L"\0005SummaryInformation" 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000008) ret=584e7ab3 0009:Ret ntdll.RtlAllocateHeap() retval=5594d108 ret=584e7ab3 The storage object's reference pointer is so incremented up to 19: 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000030) ret=584e498b 0009:Ret ntdll.RtlAllocateHeap() retval=559250f8 ret=584e498b trace:storage:StorageBaseImpl_AddRef (0x5b3465f8) AddRef to 19 trace:storage:StorageImpl_ReadProperty storage name: L"\0005SummaryInformation" 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000008) ret=584e7ab3 0009:Ret ntdll.RtlAllocateHeap() retval=55925130 ret=584e7ab3 Finally, the code executes a trace:storage:StgStreamImpl_Destroy (0x5b34b7e0) trace:storage:StorageBaseImpl_Release (0x5b3465f8) ReleaseRef to 18 There follows a lot more log file, mostly concerned with set up and so on. What I am highligting here is that between this point, and the point of actual failure which I am going to describe shortly, there appears to be no attempt to close the Default.ptf file, unlike the attempts further up the logs closer to program start. I am wondering about this: is the reference counter being incorrectly incremented here, preventing the 'Release' function from destroying the storage object and thus closing the file? I am not sufficiently familiar with the COM storage object stuff in Windows to know what _should_ happen here. Anyway. I will now describe the point of failure. Further down the log, there are several more successful opens/closes of the technology file, with the correct mode flags. Then, finally, the app tries to re-open the technology file with a grfMode of STGM_TRANSACTED | STGM_SHARE_DENY_WRITE. This call fails with a sharing violation (remember it had been left open from the previous call) 0009:Call ole32.StgOpenStorage(5971bec8 L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.stf",00000000,00010020,00000000,00000000,5821e69c) ret=1022e7f0 .... .... 0009:Ret kernel32.CreateFileW() retval=ffffffff ret=584edc8b trace:storage:StgOpenStorage <-- 80030020, IStorage (nil) There then follows the same error handling sequence leading to display of the dialog. I then thought about a simple test. I overrode the sharing mode detection in fd.c/check_sharing() in the wineserver (again, not a real solution). Note there are some minor differences in the code - I used a return code so I could easily check it: /// if ((access & FILE_UNIX_READ_ACCESS) && !(existing_sharing & FILE_SHARE_READ))/ /// rc=0;/ /// if ((access & FILE_UNIX_WRITE_ACCESS) && !(existing_sharing & FILE_SHARE_WRITE))/ /// rc=0;/ /// if ((existing_access & FILE_UNIX_READ_ACCESS) && !(sharing & FILE_SHARE_READ)) rc=0;/ /// if ((existing_access & FILE_UNIX_WRITE_ACCESS) && !(sharing & FILE_SHARE_WRITE)) rc=0;/ *if* (fd->closed->unlink[0] && !(existing_sharing & FILE_SHARE_DELETE)) rc=0; *if* (unlink && !(sharing & FILE_SHARE_DELETE)) rc=0; *if*(rc==0) { fprintf(stderr,"FILEDESC - sharing mode invalid\n"); rc=1; } *return* rc; and the application worked! Not only worked, but worked perfectly! The minor dialog corruption of previous versions had completely gone! I would like to thank the hard working people who have been working to correct problems in Wine, and in doing so had fixed this minor dialog problem. The only issue of note then is that the top-right hand buttons of a maximized MDI child window do not appear until you resize the frame. This is a minor issue though, and not of importance here. However, what I did does not represent a real solution - I just hacked around the problem, which itself seems subtle in nature. I looked closely at the Microsoft documentation and the logic in check_sharing(), even writing a program in Windows to check that at the CreateFile level that the sharing logic in Wine is correct. It seems to be. I am now stumped, I would really like to get this app working properly under Wine, without bad hacks. I would appreciate any guidance from those more experienced with the user-land Windows API. If you got this far, many thanks for taking the time to read this long message. I have provided only small excerpts from logs, but I can provide other parts of the files on request if necessary. John.

2 3

dx9 and shaders
by Coleman Kane Feb. 9, 2006

Feb. 9, 2006

Hi, What is the status on Shader support for DX9 in the latest WINE cvs, and the future projections of support in this area? I am working on a transition project, and am curious how far off support for this is in the WINE project, and perhaps where work needs to be done. Are there any people organizing this effort here? -- Coleman Kane

8 15

gethostbyname call with 0 length arg
by Phil Goss Feb. 8, 2006

Feb. 8, 2006

Hi, Is it a bug in the WINE gethostbyname (WS_gethostbyname) implementation, where if the arg name is of string length 0, then it returns unsuccessful. I have experience this issue with a Windows program (Onkyo Nettune) where the hostname passed to gethostbyname is of length 0. (This seems to be a bug in the program itself). However, the program works okay in native Windows. There seems to be a check in the gethostbyname for a NULL arg name ... if(!name) ... But no check for ... if(!strlen(name)) .... I have tested the strlen check and it seems to work and satisfies the Windows program. Does the above make sense, as I am not a programmer? Not sure if this s bug in wine even though it implementation should be matching Windows native. Thanks, Phil -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

4 9

*** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so',
by Rainer Dorsch Feb. 7, 2006

Feb. 7, 2006

Hello, I compiled the last few wine releases. 0.9.6 gives me a compile error: make[2]: Entering directory `/home/rd/SW.nobackup/wine-0.9.6/programs/winetest' make[2]: *** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so', needed by `d3d9_test.exe.so'. Stop. Any hints are welcome. Thanks, Rainer

5 9

Win32HandleToDosFileHandle / DosFileHandleToWin32Handle
by Derek Fawcus Feb. 5, 2006

Feb. 5, 2006

I'm looking to do some changes to the wine vdm - or more accurately to the winedos dll to make the handling for some DOS applications more useful. This is mainly driven from a desire to run DOS apps without a wineconsole, so using the unix stdin/stdout/stderr as the DOS file handles. i.e. ala the BSD doscmd program; mind it also has similar issues (plus I'd have to port it :) There are a few things I'll have to alter wrt to the existing console handling (within winedos), but the main part will be using the JFT within the PSP/PDB and creating SFTs. i.e. in effect fleshing out dlls/kernel/file.c:dos_handles to be a pseudo-SFT. I think I've figured out more or less where I need to hack^h^h^h^hcode. Looking at what's done at the moment, I see the above two functions being used. Now really, what I'd like to have available is Win32HandleToDosSFT and DosSFTToWin32Handle; so I'll have to create something along those lines. So a few questions : a) Is the behaviour of the above two functions correct? i.e. should they be DosFileHandle <-> Win32Handle conversion routines? Or is this just an artifact of how the DOS file handles are currently implemented? b) Do any real apps (that anyone knows of) depend upon calling them? I do see that they are used in a number of places for the existing 16 bit routines. If the behaviour is correct, then I guess I'll have to adjust them so that they involve a lookup of the current PSP/PDB and hence indirect through the JFT. Does anyone know if there is already a defined set of functions for SFT handling at the NT abstraction level? I'd have expected that the NT vdm would have used it if such was available. DF

2 5

linux/capi.h: present but cannot be compiled
by Joshua Crawford Feb. 3, 2006

Feb. 3, 2006

(I'm not on the devel list, so please Cc: replies either to me or the users list.) After recently upgrading my distro (from Slackware 10.1 to Slackware 10.2 with Freerock GNOME), configure (current CVS) now reports configure: WARNING: linux/capi.h: present but cannot be compiled configure: WARNING: linux/capi.h: check for missing prerequisite headers? configure: WARNING: linux/capi.h: see the Autoconf documentation configure: WARNING: linux/capi.h: section "Present But Cannot Be Compiled" configure: WARNING: linux/capi.h: proceeding with the preprocessor's result configure: WARNING: linux/capi.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## It seems linux/capi.h requires linux/compiler.h (for __user). I tried simply putting linux/compiler.h above linux/capi.h in the AC_CHECK_HEADERS list, but that did't work, so I'll have to leave the fix to someone who actually knows something about autoconf. This is the relevant section from config.log: configure:7159: checking linux/capi.h usability configure:7171: gcc -c -g -O2 conftest.c >&5 In file included from conftest.c:76: /usr/include/linux/capi.h:80: error: variable or field `__user' declared void /usr/include/linux/capi.h:80: error: syntax error before '*' token /usr/include/linux/capi.h:115: error: syntax error before "capi_manufacturer_cmd" /usr/include/linux/capi.h:117: error: syntax error before '}' token configure:7177: $? = 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "Wine" | #define PACKAGE_TARNAME "wine" | #define PACKAGE_VERSION "0.9.6" | #define PACKAGE_STRING "Wine 0.9.6" | #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" | #ifdef __cplusplus | extern "C" void std::exit (int) throw (); using std::exit; | #endif | #define YYTEXT_POINTER 1 | #define HAVE_GETHOSTBYNAME 1 | #define HAVE_CONNECT 1 | #define HAVE_INET_ATON 1 | #define STDC_HEADERS 1 | #define HAVE_SYS_TYPES_H 1 | #define HAVE_SYS_STAT_H 1 | #define HAVE_STDLIB_H 1 | #define HAVE_STRING_H 1 | #define HAVE_MEMORY_H 1 | #define HAVE_STRINGS_H 1 | #define HAVE_INTTYPES_H 1 | #define HAVE_STDINT_H 1 | #define HAVE_UNISTD_H 1 | #define HAVE_ALSA_ASOUNDLIB_H 1 | #define HAVE_ARPA_INET_H 1 | #define HAVE_ARPA_NAMESER_H 1 | #define HAVE_ASM_TYPES_H 1 | #define HAVE_CUPS_CUPS_H 1 | #define HAVE_CURSES_H 1 | #define HAVE_DLFCN_H 1 | #define HAVE_ELF_H 1 | #define HAVE_FLOAT_H 1 | #define HAVE_GETOPT_H 1 | #define HAVE_GIF_LIB_H 1 | #define HAVE_JPEGLIB_H 1 | #define HAVE_LBER_H 1 | #define HAVE_LCMS_H 1 | #define HAVE_LDAP_H 1 | #define HAVE_LINK_H 1 | /* end confdefs.h. */ | #include <stdio.h> | #if HAVE_SYS_TYPES_H | # include <sys/types.h> | #endif | #if HAVE_SYS_STAT_H | # include <sys/stat.h> | #endif | #if STDC_HEADERS | # include <stdlib.h> | # include <stddef.h> | #else | # if HAVE_STDLIB_H | # include <stdlib.h> | # endif | #endif | #if HAVE_STRING_H | # if !STDC_HEADERS && HAVE_MEMORY_H | # include <memory.h> | # endif | # include <string.h> | #endif | #if HAVE_STRINGS_H | # include <strings.h> | #endif | #if HAVE_INTTYPES_H | # include <inttypes.h> | #else | # if HAVE_STDINT_H | # include <stdint.h> | # endif | #endif | #if HAVE_UNISTD_H | # include <unistd.h> | #endif | #include <linux/capi.h> configure:7199: result: no configure:7203: checking linux/capi.h presence configure:7213: gcc -E conftest.c configure:7219: $? = 0 configure:7239: result: yes configure:7252: WARNING: linux/capi.h: present but cannot be compiled configure:7254: WARNING: linux/capi.h: check for missing prerequisite headers? configure:7256: WARNING: linux/capi.h: see the Autoconf documentation configure:7258: WARNING: linux/capi.h: section "Present But Cannot Be Compiled" configure:7260: WARNING: linux/capi.h: proceeding with the preprocessor's result configure:7262: WARNING: linux/capi.h: in the future, the compiler will take precedence configure:7274: checking for linux/capi.h configure:7281: result: yes -- Joshua 'bruce' Crawford ... http://www.geocities.com/mortarn The early bird may get the worm, but the second mouse gets the cheese.

2 2

Re: Repackaging Mozilla ActiveX control to include MSVCP60.DLL? [FIXED]
by Tony Lambregts Feb. 1, 2006

Feb. 1, 2006

I dont normally top post ;^) but this time it makes sense to. This (replied to) email is not archived in the Piper Mail archive correctly although it looks fine here. In the pipermail archive there is only a pgp signature. This is not the first time I have seen this, it seems that Piper Mail grabs the pgp signature and does not archive the patch which makes the archive less usefull. If you ask me this is what I would call a bug in pipermail. http://www.winehq.org/pipermail/wine-patches/2006-January/023490.html Between this bug and the lack of dates in the archive I really getting to despise pipermail. So... I went looking at the alternative and thought of GMANE and it turns out that this patch is not archived there at all. In fact the last patch by Jonathan Ernst that was archived by GMANE is 2005-12-19 16:28:02 GMT and I know that there are more after that date. http://search.gmane.org/?query=&email=Jonathan+Ernst&group=gmane.comp.emula… So now I'm really starting to get upset because we have no reliable archive and that just sucks. Has anyone got any ideas on how to fix this. -- Tony Lambregts Jonathan Ernst wrote: > Le dimanche 15 janvier 2006 à 07:40 -0800, Dan Kegel a écrit : > >>On 1/15/06, Ge van Geldorp <gvg(a)reactos.org> wrote: >> >>>>The Mozilla ActiveX control download feature is cool and all, >>>>but until we repackage the sucker to include MSVCP60.DLL to fix >>>>http://bugs.winehq.org/show_bug.cgi?id=4064 ... >>>>I could have sworn I saw somebody post a note saying they had >>>>done said repackaging, but I can't find it now... >>> >>>http://www.winehq.org/pipermail/wine-patches/2005-December/022795.html >>>Instructions on how to repackage can be found at >>>svn://svn.reactos.org/trunk/tools/MozillaControl/ >> >>Thanks! I've updated bug 4064. Now can somebody >>update winehq.org's copy of the control so we can close that bug? >>- Dan >> >>-- >>Wine for Windows ISVs: http://kegel.com/wine/isv >> >> >> > > > Le lundi 16 janvier 2006 à 14:30 +0100, Filip Navara a écrit : > >>Jonathan Ernst wrote: >> >> >>>// Exact size of the file: >>>$iFileSize = 4771240; >>> >> >>Shouldn't you change the file size too? >> >>- Filip >> > > > Sure, thanks for spotting it ;-) > > Changelog: > - use repackaged Mozilla ActiveX control from ReactOS > > > > > ------------------------------------------------------------------------ > > Index: mozactivex.php > =================================================================== > RCS file: /home/wine/tools/mozactivex.php,v > retrieving revision 1.1 > diff -u -p -r1.1 mozactivex.php > --- mozactivex.php 19 Oct 2005 16:17:09 -0000 1.1 > +++ mozactivex.php 16 Jan 2006 14:02:33 -0000 > @@ -14,31 +14,27 @@ > > > // Name of the file > -$sFileName = "MozillaControl1712.exe"; > +$sFileName = "MozillaControl1712-ReactOS.exe"; > > // Exact size of the file: > -$iFileSize = 4771240; > +$iFileSize = 4735160; > > // List of locations > -$aList = array("http://www.iol.ie/~locka/mozilla/", > - "http://osdn.dl.sourceforge.net/sourceforge/wine/", > - "http://nchc.dl.sourceforge.net/sourceforge/wine/", > - "http://easynews.dl.sourceforge.net/sourceforge/wine/", > - "http://mesh.dl.sourceforge.net/sourceforge/wine/", > - "http://puzzle.dl.sourceforge.net/sourceforge/wine/", > - "http://citkit.dl.sourceforge.net/sourceforge/wine/", > - "http://umn.dl.sourceforge.net/sourceforge/wine/", > - "http://cogent.dl.sourceforge.net/sourceforge/wine/", > - "http://jaist.dl.sourceforge.net/sourceforge/wine/", > - "http://surfnet.dl.sourceforge.net/sourceforge/wine/", > - "http://peterhost.dl.sourceforge.net/sourceforge/wine/", > - "http://ufpr.dl.sourceforge.net/sourceforge/wine/", > - "http://optusnet.dl.sourceforge.net/sourceforge/wine/", > - "http://keihanna.dl.sourceforge.net/sourceforge/wine/", > - "http://heanet.dl.sourceforge.net/sourceforge/wine/", > - "http://switch.dl.sourceforge.net/sourceforge/wine/", > - "http://internap.dl.sourceforge.net/sourceforge/wine/", > - "http://ovh.dl.sourceforge.net/sourceforge/wine/" > +$aList = array("http://switch.dl.sourceforge.net/sourceforge/reactos/", > + "http://surfnet.dl.sourceforge.net/sourceforge/reactos/", > + "http://citkit.dl.sourceforge.net/sourceforge/reactos/", > + "http://keihanna.dl.sourceforge.net/sourceforge/reactos/", > + "http://heanet.dl.sourceforge.net/sourceforge/reactos/", > + "http://easynews.dl.sourceforge.net/sourceforge/reactos/", > + "http://ovh.dl.sourceforge.net/sourceforge/reactos/", > + "http://jaist.dl.sourceforge.net/sourceforge/reactos/", > + "http://puzzle.dl.sourceforge.net/sourceforge/reactos/", > + "http://nchc.dl.sourceforge.net/sourceforge/reactos/", > + "http://switch.dl.sourceforge.net/sourceforge/reactos/", > + "http://kent.dl.sourceforge.net/sourceforge/reactos/", > + "http://optusnet.dl.sourceforge.net/sourceforge/reactos/", > + "http://mesh.dl.sourceforge.net/sourceforge/reactos/", > + "http://internap.dl.sourceforge.net/sourceforge/reactos/" > ); > > > > > ------------------------------------------------------------------------ > >

5 10

Re: wined3d: Fixed render states
by H. Verbeet Feb. 1, 2006

Feb. 1, 2006

On 31/01/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > wined3d: Fixed up render states POINTSCALEENABLE, POINTSPRITENABLE, > EDGEANTIALIAS, MULTISAMPLEANTIALIAS You probably want to split the patch up in smaller pieces. > + if(This->stateBlock->renderState[D3DRS_POINTSCALEENABLE]) { > + att[0] = *((float*)&This->stateBlock->renderState[D3DRS_POINTSCALE_A]) / > + (This->stateBlock->viewport.Height * This->stateBlock->viewport.Height); > + att[1] = *((float*)&This->stateBlock->renderState[D3DRS_POINTSCALE_B]) / > + (This->stateBlock->viewport.Height * This->stateBlock->viewport.Height); > + att[2] = *((float*)&This->stateBlock->renderState[D3DRS_POINTSCALE_C]) / > + (This->stateBlock->viewport.Height * This->stateBlock->viewport.Height); > + } You're not supposed to use D3DRS_ stuff in wined3d, rather use the respective WINED3DRS_ defines, as the original code did. > + if(GL_SUPPORT(ARB_POINT_PARAMETERS)) { Same problem as with your patch for d3d8, wined3d doesn't currently check for ARB_POINT_PARAMETERS support (in IWineD3DImpl_FillGLCaps). > - /* Doesn't work with GL_POINT_SMOOTH on on my ATI 9600, but then ATI drivers are buggered! */ > - glDisable(GL_POINT_SMOOTH); Did you verify that this isn't required anymore? Otherwise that's a potential regression. > + checkGLcall("glEnable(Gl_LINE_SMOOTH)"); > + checkGLcall("glDisable(Gl_LINE_SMOOTH)"); That should probably say Gl_LINE_SMOOTH, but it's not really critical.

4 5

New developer
by Segin Feb. 1, 2006

Feb. 1, 2006

Hello! I am new to developing Wine, however, I am not new to using it (I know quite a bit about it already). I want to know what resources would I want to look at, please nothing obvious (bugzilla, MSDN, etc.), and what I can do to contribute. Thanks.

2 1

Re: opengl: Sync a dibsection to its pixmap before drawing to it via opengl
by Lionel Ulmer Jan. 31, 2006

Jan. 31, 2006

On Fri, Jan 27, 2006 at 03:48:00PM +0000, Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > opengl: Sync a dibsection to its pixmap before drawing to it via opengl Was some benchmarks done to see if this change negatively impacted the performance of applications doing only 'in-window' drawings (e.g. games) and not 'in-dib' drawings ? Lionel (in catch-up mode after coming back from vacation so sorry if this point was already raised later in the week :-) ) -- Lionel Ulmer - http://www.bbrox.org/

2 1

Wine and Font rendering
by Roland Kaeser Jan. 31, 2006

Jan. 31, 2006

Hello all I noticed a very strange font problem in Corel Draw using wine. On some systems (all SuSE 10) rotated fonts became invisible. An other problem is with text boxes on some systems text boxes (with floating text) are very strange rendered (the text appears multiple times, the cursor is not at the position where the character is printed while writing, some text is invisible while editing) Can somebody tell me which routines (system and wine) are responsible for font rendering in wine. Based on that all machines have the same graphics card and driver version, I'm pretty sure its not a driver or graphics card related problem but on some systems, online updates are made. If I could know about the internal work of font rendering in wine, I probably can figure out where this problem cames from. Many thanks Roland Kaeser

1 0

Re: keyboard: fix the keyboard problem when using UTF-8 locales
by Dmitry Timoshkov Jan. 31, 2006

Jan. 31, 2006

On Tue, 2006-01-31 at 13:11 +0200, Fatih Aşıcı wrote: > When using UTF-8 locale, I can't type some Turkish characters. > I don't know whether it works with other languages. > But it works at least in Turkish locale. > + have_chars = XLookupString(&e2, bufC, 2, &keysym, NULL); > + if(have_chars > 1){ > + MultiByteToWideChar(CP_UNIXCP, 0, bufC, -1, bufW, -1); > + WideCharToMultiByte(CP_ACP, 0, bufW, -1, &ckey[i], 1, NULL, NULL); > + } Probably it works for Turkish locale but it won't work in general. Code pages often have characters which could not be be represented in other code pages and therefore will be lost. -- Dmitry.

2 2

Re: user: fix DrawTextExA/W on empty strings.
by Juan Lang Jan. 31, 2006

Jan. 31, 2006

Hi Rein, - if (!str) return 0; + if (!str || count == 0) return 0; if (count == -1) count = strlenW(str); - if (count == 0) return 0; + if (count == 0) { + if( flags & DT_CALCRECT) { + rect->right = rect->left; + rect->bottom = rect->top; + } + return 0; + } This block will never be reached because of the if (!str || count == 0) test above. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

5 6

Direct3D 8/9 status?
by Roderick Colenbrander Jan. 31, 2006

Jan. 31, 2006

Hi, Recently various people in the wine channels wanted to work on wine's direct3d8/9 code. Some just wanted to get their game working, others wanted to do performance tweaks and today some guy wanted to port d3d8 over to wined3d (he didn't know that oliver is/was working on it). We don't really know what to tell these people as we don't know the status of the direct3d8/9 work and we want to avoid code duplication. We know that Oliver is/was (?) working on moving direct3d8 over to wined3d and that he is working on optimizations. What's the status on all this and what areas of wined3d are safe to touch? Regards, Roderick

2 2

Re: Fix Bug#: 4396: floating MFC-ToolBars get managed and can't be re-docked
by Robert Shearman Jan. 31, 2006

Jan. 31, 2006

Tobias Loew wrote: >Changelog: > dlls/x11drv/window.c > > Tobias Loew <tobi(a)die-loews.de> > Fix Bug#: 4396: floating MFC-ToolBars get managed and can't be re-docked > don't manage top-level windows having the style WS_EX_TOOLWINDOW and WS_CAPTION > >Tobias Loew > > Hi Tobias, I'm afraid this patch isn't likely to be applied. The reason is that moving around the rules for being a managed window or not is likely to cause regressions. Alexandre has stated that the only real solution is to be able to switch between managed and non-managed on the fly and add new (and better) dynamic rules to control this. -- Rob Shearman

1 0

wine and xscanimage
by Roland Kaeser Jan. 31, 2006

Jan. 31, 2006

Hello I recently tried to get a sane-scanner work with wine and noticed hat the xscanimage mostly is no longer part of the shipped sane frontends by actual distributions. It becomes harder and harder to get a update to date version of xscanimge. Wouldn't it be better to choose an other sane-frontend for the wine twain/sane integration? Kind regards Roland Kaeser

1 0

Re: PATCH: Wine Turkish translations
by Mike McCormack Jan. 31, 2006

Jan. 31, 2006

Fatih Aşıcı wrote: > Turkish resources for wine > > Changelog: > Fatih Asici <fasici(a)linux-sevenler.org> > - Turkish translations (includes all wine resources) Thanks for translating all these. Before Alexandre applies them, it's likely you'll need to split the patch up into smaller chunks, and submit them one per email. This makes it easier for reviewers to spot problems, and for Alexandre to apply the patches. eg. The following two patches should be sent together in one email: diff -Nur oldwine/dlls/commdlg/rsrc.rc wine/dlls/commdlg/rsrc.rc diff -Nur oldwine/dlls/commdlg/cdlg_Tr.rc wine/dlls/commdlg/cdlg_Tr.rc thanks, Mike

1 0

Fun with VB6. Crashes in OLE gunk...
by Dan Kegel Jan. 31, 2006

Jan. 31, 2006

I finally broke down and bought a copy of VB6 Pro. To install it, I had to pick "win98" mode in winecfg, and ignore a few errors. While playing around with it, running a test app, I got Wine to crash on a COM problem of some sort. In several ways. Here's one: fixme:ole:OleLoadPictureEx (0x7d5216b4,0,0,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=16,y=16,f=0,0x7fe7c2c0), partially implemented. fixme:ole:OleLoadPictureEx (0x7d5216b4,0,0,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=16,y=16,f=0,0x7fe7c428), partially implemented. fixme:ole:OLEFontImpl_IPersistStreamInit_InitNew (0x7cb055bc), stub! err:ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_VARIANT|VT_BYREF from VT_BSTR|VT_BYREF fixme:ole:OLEPictureImpl_get_hPal unimplemented for type 3. Returning 0 palette. fixme:ole:OLEPictureImpl_get_hPal unimplemented for type 3. Returning 0 palette. fixme:ole:OLEPictureImpl_Render Not quite correct implementation of rendering icons... fixme:ole:MSFT_ReadValue BSTR length = -1? fixme:ole:MSFT_ReadValue BSTR length = -1? fixme:ole:ITypeLib2_fnGetDocumentation2 (0x7baa2fb0) index -1 lcid 0 half implemented stub! fixme:typelib2:ICreateTypeLib2_fnSetHelpContext (0x7bac0ee8,280000), stub! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:font:WineEngCreateFontInstance Untranslated charset 255 fixme:ole:DllDebugObjectRPCHook stub wine: Unhandled page fault on read access to 0x00000000 at address 0x7f700844 (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7f700844). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7f700844 ESP:7fb1f5bc EBP:7fb1f5d4 EFLAGS:00210202( - 00 - -RI1) EAX:00000000 EBX:7f751784 ECX:00000000 EDX:7baeb278 ESI:7baeb268 EDI:00000000 Stack dump: 0x00000000: 00000000 00000000 00000000 00000000 0x00000010: 00000000 00000000 00000000 00000000 0x00000020: 00000000 00000000 00000000 00000000 0x00000030: 00000000 00000000 00000000 00000000 0x00000040: 00000000 00000000 00000000 00000000 0x00000050: 00000000 00000000 00000000 00000000 Backtrace: =>1 0x7f700844 OLEFontImpl_put_Name+0x64(iface=0x7baeb268, name=0x0) [/home/dank/wine/dlls/oleaut32/../../include/winbase.h:2069] in oleaut32 (0x7f700844) 2 0x7f702a99 OLEFontImpl_IPersistPropertyBag_Load(iface=0x7baeb278, pPropBag=0x7e7d4924, pErrorLog=0x0) [/home/dank/wine/dlls/oleaut32/olefont.c:1922] in oleaut32 (0x7f702a99) err:dbghelp:pe_load_dbg_file -Unable to peruse .DBG file VB6.dbg ("VB6.dbg") 3 0x0044c9e2 in vb6 (+0x4c9e2) (0x0044c9e2) 4 0x004106f9 in vb6 (+0x106f9) (0x004106f9) ... -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

[frick@sc-networks.de: wined3d: support for WINED3D_A8B8G8R8]
by Christoph Frick Jan. 31, 2006

Jan. 31, 2006

hiho, could someone enlighten me, what is wrong with that patch? -- cu

2 1

Re: [COMCTL32] Listview: Store DC before calling PREPAINT
by Robert Shearman Jan. 30, 2006

Jan. 30, 2006

Maarten Lankhorst wrote: > Some applications like to use PREPAINT to set fonts, nothing wrong > with that, only DC is never restored, resulting in drawing glitches. > > Changelog: > Save and restore DC on every listview item drawn. I don't think native would do this. SaveDC / RestoreDC seems like an overkill. It would seem better to just call SelectObject to save and restore the font each time. You should then also test for the CDRF_NEWFONT flag and act appropriately. -- Rob Shearman

1 0

Text Object Model and Richedit?
by Dan Kegel Jan. 30, 2006

Jan. 30, 2006

I stumbled across the doc for the "Text Object Model", which looks like the COM interface to Richedit and anything like it: http://windowssdk.msdn.microsoft.com/library/en-us/shellcc/platform/commctl… Is anyone poking around at adding this interface to our Richedit? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: D3D8: Fixed D3DRS fixes
by H. Verbeet Jan. 30, 2006

Jan. 30, 2006

On 30/01/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > + if(GL_SUPPORT(ARB_POINT_PARAMETERS)) { ARB_POINT_PARAMETERS is defined in d3dcore_gl.h, but never checked for in directx.c. That means the check should always return false.

1 0

Wine-wiki broken by design
by Molle Bestefich Jan. 30, 2006

Jan. 30, 2006

GuruLounge - MailLists wrote: > err:seh:setup_exception stack overflow 40 bytes in thread 000c Exception loop. Covered to some extent in: http://wiki.winehq.org/Debugging_'Wild_Metal_Country' For some reason, all pages in the Wine Wiki (like the above) is _fucking_ impossible to find with Google. I don't know why, but I think it might be because all the pages have "index: nofollow", which means that subpages are never found. GRR. Very unhelpful to newbies. Very tragic that fine Wiki documentation is available but that noone can find it because Google is disabled for the entire Wiki. And very annoying that I've had to answer this question 3 times now, when it should obviously be a top hit for "seh:setup_exception" on Google. SO, could someone *PLEASE* fix the Wiki so Google can index it??? Pretty please *smile* :-).

2 4

<DEL> key is sending an extra char when NumLock is ON
by penna＠bb.com.br Jan. 30, 2006

Jan. 30, 2006

Hi, I was looking at an old problem I have with wine and saw some record at the wine-devel and wine-users lists that I think are related with the same problem. Look at: http://www.winehq.org/hypermail/wine-users/2004.03.txt (look for "get a comma on the place" in your browser) and also at: http://www.winehq.org/hypermail/wine-devel/2000.10.txt (look for "but then it inserts" in your browser) When the NumLock is ON wine is sending an extra key. Wine deletes the corresponding char but also send a period (.) or a comma (,) <- it depends on the type of the keyboard. In my case, which is a brazilian ABNT2, it sends an extra comma _only_ if the NumLock is ON. It does not mater if I press the <del> key at the numeric key pad or at the "island" that contais the <del> <ins> <home> <end> ... stuff. I am going to open a bug at bugzilla and send the WINEDEBUG=+key (just the piece where the stuff happens). wine=0.9.6 for Mandriva 2006 pre-built by Ivan keyboard=brazilian abnt2 Thanks. --------------------------------------------------------- Ulisses de Sousa Penna Analista Consultor - Banco do Brasil Fone: +55-61-3310-6320 Fax: +55-61-3310-6435 ---------------------------------------------------------

2 1

Corel Draw and Printing
by Roland Kaser Jan. 30, 2006

Jan. 30, 2006

Hy all There is, since a longer time ago, a wine bug #3599 about Corel Draw and printing. Its a very strange behaviour. I can configure what ever I want, I always uses the wine passthrough and sends the postscript code, of Corel Draw directly to the printer instead of spooling it first through the cups driver. I've readt all known documentations about wine and printing but cannot get one step ahead. Can somebody tell me the wine internal reason of this behaviour? I would really like to have this feature working. Why didn't wine spool everything first through the cups spooler (as the default behaviour) unless an other, explicity specified configuration tells wine to passthrough the spool output. The other question is, why shows wine a postscript printer to corel draw? I know, I know, on Linux all printer interfaces are postscript, but Corel takes this info literally and explicitly creates postscript code (by itself) and not uses the windows printer api to create the printer-document. Roland Kaeser

3 3

make check fails in iphlapi
by Marcus Meissner Jan. 30, 2006

Jan. 30, 2006

Hi, make check here fails in dlls/iphlapi/tests with: make[1]: Entering directory `/home/marcus/projects/wine/dlls/iphlpapi/tests' ../../../tools/runtest -q -P wine -M iphlpapi.dll -T ../../.. -p iphlpapi_test.exe.so iphlpapi.c && touch iphlpapi.ok [..] trace:iphlpapi:GetAdaptersInfo pAdapterInfo (nil), pOutBufLen (nil) trace:iphlpapi:GetAdaptersInfo returning 87 trace:iphlpapi:GetAdaptersInfo pAdapterInfo (nil), pOutBufLen 0x55c2fae8 trace:iphlpapi:GetAdaptersInfo returning 111 trace:iphlpapi:GetAdaptersInfo pAdapterInfo 0x7c0097f0, pOutBufLen 0x55c2fae8 fixme:iphlpapi:GetAdaptersInfo table->numind 4, numnonloopback 4, ipaddrtab->numents 3, numipaddresses 3 trace:iphlpapi:GetAdaptersInfo returning 0 *** glibc detected *** free(): invalid next size (normal): 0x7c0096d8 *** The test is testGetAdaptersInfo() and I guess the GetAdaptersInfo() call overwrites the end of the malloc()ed buffer. I don't really know whats broken there. the values of the interesting parameters: table->numIndexes is 4 numNonLoopbackInterfaces is 4 ipAddrTable->dwNumEntries 3 numIPAddresses 3 Ciao, Marcus

1 0

Re: shell32/shellpath [3/3]: (RESEND) Create symlinks to $HOME based directories during SHELL_RegisterFolders.
by Michael Jung Jan. 30, 2006

Jan. 30, 2006

On Sunday 29 January 2006 10:38, Michael Jung wrote: > ChangeLog: > Create $HOME targeted symbolic links during SHELL_RegisterFolders. I've just realized that unixfs has a problem with the symlink stuff. It evaluates symbolic links in UNIXFS_get_unix_path and then doesn't find a DOS path for /home/mjung in GetDisplayNameOf (If there's no drive mapped to '/', that is.) The symlink evaluation is done to get rid of the '/home/mjung/.wine/dosdevices/c:' prefixes in unix paths. I guess we should get rid of the generic symlink evaluation in unixfs and implement something especially targeted at those prefixes? I guess this should be considered a bug in unixfs, so in my opinion it would be ok to apply the shellpath-patches. In a standard setup with Z:\ mapped to /, everything is fine. And even if it's removed, it's still better than with the current solution. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

sudo vs su in wineinstall
by Tom Spear (Dustin Booker, Dustin Navea) Jan. 30, 2006

Jan. 30, 2006

Hi guys, bug 4439 describes a problem where a machine (running ubuntu) does not install wine when using wineinstall due to the fact that su dos not work.. Just a couple of questions: Is this the case (su not working) on all Ubuntu machines, or just something broken on that users' machine? If it is the case on all Ubuntu machines, the user has mentioned that sudo does work. sudo does require configuration prior to being used, but we could always add into the wineinstall script to configure sudo for the user, or we could ask the user to configure it themself, OR we could fall back to using su if the user answers no to having used sudo.. see below: ./tools/wineinstall Warning: the wineinstall script installs wine using the sudo command. Have you ever used sudo on this machine before? if (yes) continue as normal else # either of these could work # option 1 Would you like to have us try to configure sudo for you? # option 2 User has not used or configured sudo, falling back to su WARNING: su may be broken on your machine, and therefore wine may be built but not installed. If you are unable to run wine after this script completes, please login as root, and do 'make install' then login as your user again. Of course we could always just add a configure check to see if su works, and if it doesnt, die with a warning about wineinstall not working because of that. What do you think guys? Tom

4 5

re: sudo vs su in wineinstall
by Dan Kegel Jan. 30, 2006

Jan. 30, 2006

Let's simply delete the wineinstall script. It's not really needed anymore, it was just there for compatibility. People have been talking about doing it for some time: http://winehq.org/site/?issue=227#Nuking%20Wineinstall perhaps now's the time. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: [patch] updated riched20 conformance test
by Phil Krylov Jan. 29, 2006

Jan. 29, 2006

On Tue, 24 Jan 2006 12:23:09 -0800 Thomas Kho <tkho(a)ucla.edu> wrote: > Attached is a small patch to add a riched20 conformance test. I think it's a good test, but I'd add "flags %08x",...flags to the failing test messages, because all these failures are due to unimplemented flags. And probably the message names should be printed as well... -- Ph.

1 0

re: Regression problems in app - help with debugging?
by Dan Kegel Jan. 29, 2006

Jan. 29, 2006

Smashing analysis! You might want to repost your note as a bug report at http://bugs.winehq.org. Set the 'component' field of the report to wine-ole, and put 'download' in the 'keyword' field. This will get the attention of the right folks somewhat more reliably than a post to wine-devel. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Sweet sassy molassy, OOo2.0.1 and OOo testtool run!
by Dan Kegel Jan. 29, 2006

Jan. 29, 2006

OK, OpenOffice 2.0.1 does indeed seem to run with yesterday's cvs, as does the corresponding automated test tool! I haven't tried running any real tests with the test tool yet, but seems like that ought to be a rich source of regression information for us going forward. The curious can try it out themselves fairly easily, it's at http://qa.openoffice.org/qatesttool/ - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

DLL Help Database on microsoft.com
by Detlef Riekenberg Jan. 29, 2006

Jan. 29, 2006

Just found the DLL Help Database (with Details on Product, Version, Exports, Dependencies) on microsoft.com. General Search: http://support.microsoft.com/dllhelp/ Search a dll by Filename (Language is en_US): http://support.microsoft.com/dllhelp/?dlltype=file&l=55&S=1&alpha= You can add the dllname to the end of the url. Example: http://support.microsoft.com/dllhelp/?dlltype=file&l=55&S=1&alpha=winspool.… -- By By ... ... Detlef

1 0

The Dogfood Challenge: use Wine to run your web browser, etc.
by Dan Kegel Jan. 29, 2006

Jan. 29, 2006

Say, if we're expecting people to use Wine for real work, maybe we should start doing that ourselves. Firefox-1.5 runs pretty well on Wine. How many Wine developers use it on Wine as their main web browser? Maybe we could raise that number from zero to somewhere around ten, and flush out a couple bugs. Speaking of flushing out bugs, OpenOffice 1.1 was said to work well under wine a couple years ago (though I don't think I ever saw it do so myself). Sadly, although OpenOffice 1.1.5 seems to install fine under current wine, it crashes quickly on startup, so I guess we have a bit of work to do first. The extra payoff would be being able to use http://qa.openoffice.org/qatesttool/ to run OpenOffice's automated test suite as an automated regression test for wine. One complication in all this is having to teach yourself to not automatically blow away your ~/.wine directory when trying a new app! OK, baby's waking up, time to go. Cheers, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: MSI: Implementation of the MsiVerifyDiskSpace function
by Thomas Weidenmueller Jan. 29, 2006

Jan. 29, 2006

MattK wrote: > ChangeLog: > Implementation of the MsiVerifyDiskSpace function > > dlls/msi/msiquery.c | 32+- > 1 files changed, 32 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > This patch doesn't look right. 1. GetDiskFreeSpace is called with a uninitialized buffer 2. GetDiskFreeSpaceEx should be used to support big partitions 3. missing error checks lead to bogus calculations 4. calculating whether there's enough space is completely wrong - Thomas

2 1

NetUserEnum
by suppandi Jan. 29, 2006

Jan. 29, 2006

Hi, I was trying to run notes7 and it was crashing because NetUserEnum() was not implemented. So i tried writing a simple implementation. Could anybody have a look at this, and tell me whats wrong. Now notes just crashes without any doc. unfortunately i amn't a windows programmer to write a simple program to make the call. NetUserEnum(LPCWSTR servername, DWORD level, DWORD filter, LPBYTE* bufptr, DWORD prefmaxlen, LPDWORD entriesread, LPDWORD totalentries, LPDWORD resume_handle) { struct USER_INFO_20 { LPWSTR usri20_name; LPWSTR usri20_full_name; LPWSTR usri20_comment; DWORD usri20_flags; DWORD usri20_user_id; }; switch(level) { case 20: { struct USER_INFO_20 *data; char user[]={'t','e','s','t'}; NetApiBufferAllocate(sizeof(struct USER_INFO_20), (LPVOID *) bufptr); data = (struct USER_INFO_20 *)malloc(sizeof(struct USER_INFO_20)); data->usri20_name = (LPWSTR)malloc(20); memcpy((void*)data->usri20_name,user,4); data->usri20_full_name = (LPWSTR)malloc(20); memcpy((void*)data->usri20_full_name,user,4); data->usri20_comment = (LPWSTR)malloc(20); memcpy((void*)data->usri20_comment,user,4); data->usri20_flags = UF_NORMAL_ACCOUNT; data->usri20_user_id = 1000; *entriesread = *totalentries = 1; return 0; } break; default: FIXME("(%s,%ld, 0x%ld,%p,%ld,%p,%p,%p) stub!\n", debugstr_w(servername), level, filter, bufptr, prefmaxlen, entriesread, totalentries, resume_handle); return ERROR_ACCESS_DENIED; break; } }

2 1

Re: Fix: tab-control flickering
by Vitaliy Margolen Jan. 28, 2006

Jan. 28, 2006

Saturday, January 28, 2006, 4:21:21 AM, Tobias Loew wrote: > Changelog: > dlls/comctl32/tab.c > Tobias Loew <tobi(a)die-loews.de> > Fix: tab-control flickering; tab-control redraws itself after a call to SetCurSel also > when the selection doesn't change > Tobias Loew > Index: dlls/comctl32/tab.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/tab.c,v > retrieving revision 1.122 > diff -u -p -r1.122 tab.c > --- dlls/comctl32/tab.c 8 Nov 2005 12:52:35 -0000 1.122 > +++ dlls/comctl32/tab.c 28 Jan 2006 10:25:40 -0000 > @@ -261,9 +261,11 @@ static inline LRESULT TAB_SetCurSel (TAB > if (iItem >= 0 && iItem < infoPtr->uNumItem) { > prevItem=infoPtr->iSelected; - infoPtr->>iSelected=iItem; > - TAB_EnsureSelectionVisible(infoPtr); > - TAB_InvalidateTabArea(infoPtr); + if (infoPtr->>iSelected != iItem) { + infoPtr->>iSelected=iItem; > + TAB_EnsureSelectionVisible(infoPtr); > + TAB_InvalidateTabArea(infoPtr); > + } > } > return prevItem; > } Please follow the same formatting as the rest of the file/function. In this case it is 4 spaces indent. Vitaliy Margolen

1 0

Re: NetUserEnum
by Vijay Kiran Kamuju Jan. 28, 2006

Jan. 28, 2006

Hi, If you could also post the FIXME message or the winedebug trace it would be helpful. It would help us to locate if its a regression or unimplemented case. Thanks, VJ On 1/28/06, suppandi <suppandi(a)gmail.com> wrote: > Hi, > > I was trying to run notes7 and it was crashing because NetUserEnum() was not > implemented. So i tried writing a simple implementation. Could anybody have > a look at this, and tell me whats wrong. Now notes just crashes without any > doc. unfortunately i amn't a windows programmer to write a simple program > to make the call. > > NetUserEnum(LPCWSTR servername, DWORD level, DWORD filter, LPBYTE* bufptr, > DWORD prefmaxlen, LPDWORD entriesread, LPDWORD totalentries, > LPDWORD resume_handle) > { > struct USER_INFO_20 > { > LPWSTR usri20_name; > LPWSTR usri20_full_name; > LPWSTR usri20_comment; > DWORD usri20_flags; > DWORD usri20_user_id; > }; > > switch(level) > { > case 20: > { > struct USER_INFO_20 *data; > char user[]={'t','e','s','t'}; > NetApiBufferAllocate(sizeof(struct USER_INFO_20), > (LPVOID *) bufptr); > data = (struct USER_INFO_20 *)malloc(sizeof(struct USER_INFO_20)); > data->usri20_name = (LPWSTR)malloc(20); > memcpy((void*)data->usri20_name,user,4); > data->usri20_full_name = (LPWSTR)malloc(20); > memcpy((void*)data->usri20_full_name,user,4); > data->usri20_comment = (LPWSTR)malloc(20); > memcpy((void*)data->usri20_comment,user,4); > data->usri20_flags = UF_NORMAL_ACCOUNT; > data->usri20_user_id = 1000; > *entriesread = *totalentries = 1; > return 0; > } > break; > default: > FIXME("(%s,%ld, 0x%ld,%p,%ld,%p,%p,%p) stub!\n", > debugstr_w(servername), level, > filter, bufptr, prefmaxlen, entriesread, totalentries, > resume_handle); > > return ERROR_ACCESS_DENIED; > break; > } > } > > > > >

1 0