January 2006 - Wine-Devel - list.winehq.org

commdlg patch
by Turkin, Andrey Jan. 25, 2006

Jan. 25, 2006

Hi! Here is quick&dirty (TM :) patch (against wine-0.9.6) that changes explorer-like Open/Save file dialogs to be more 3.11-like dialog/Windows compatible: 1) set view window control id to 1121 2) set inner list window control id to 1 instead of 2000 (anyone know why 2000 was chosen?) This patch is really not very good because of my 1) implementation, but it fixes Macromedia Director cast import! I've done 1) by placing SetWindowLong(hwndView,GWLP_ID, lst2) after each IShellBrowser_BrowseObject call. Better approach is to set view vindow's control id inside of IShellBrowser_BrowseObject but I don't sure if it safe. Regards, Andrey Turkin. diff -cr wine-0.9.6/dlls/commdlg/filedlg.c wine-0.9.6p/dlls/commdlg/filedlg.c *** wine-0.9.6/dlls/commdlg/filedlg.c 2006-01-19 17:13:54.000000000 +0300 --- wine-0.9.6p/dlls/commdlg/filedlg.c 2006-01-25 19:37:26.000000000 +0300 *************** *** 1486,1491 **** --- 1486,1492 ---- /* Browse to the initial directory */ IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser,pidlItemId, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); /* Free pidlItem memory */ COMDLG32_SHFree(pidlItemId); *************** *** 1997,2002 **** --- 1998,2004 ---- if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent, fodInfos->ShellInfos.pidlAbsCurrent)) { IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidlCurrent, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); } else if( nOpenAction == ONOPEN_SEARCH ) { *************** *** 2260,2265 **** --- 2262,2268 ---- NULL, SBSP_PARENT))) { + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); return TRUE; } *************** *** 2282,2287 **** --- 2285,2291 ---- SHGetSpecialFolderLocation(0,CSIDL_DESKTOP,&pidl); hres = IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidl, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); COMDLG32_SHFree(pidl); return SUCCEEDED(hres); *************** *** 2758,2763 **** --- 2762,2768 ---- tmpFolder->pidlItem, SBSP_ABSOLUTE))) { + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); return TRUE; } *************** *** 3435,3440 **** --- 3440,3446 ---- ' ','n','o','t',' ','e','x','i','s','t',0}; MessageBoxW( hwnd, notexist, fodInfos->title, MB_OK | MB_ICONEXCLAMATION ); } + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); bBrowseSelFolder = TRUE; SendCustomDlgNotificationMessage(hwnd,CDN_FOLDERCHANGE); } diff -cr wine-0.9.6/dlls/shell32/shlview.c wine-0.9.6p/dlls/shell32/shlview.c *** wine-0.9.6/dlls/shell32/shlview.c 2006-01-19 17:14:17.000000000 +0300 --- wine-0.9.6p/dlls/shell32/shlview.c 2006-01-25 19:37:45.000000000 +0300 *************** *** 146,152 **** #define IDM_VIEW_IDW (FCIDM_SHVIEWFIRST + 0x501) #define IDM_MYFILEITEM (FCIDM_SHVIEWFIRST + 0x502) ! #define ID_LISTVIEW 2000 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111 --- 146,152 ---- #define IDM_VIEW_IDW (FCIDM_SHVIEWFIRST + 0x501) #define IDM_MYFILEITEM (FCIDM_SHVIEWFIRST + 0x502) ! #define ID_LISTVIEW 1 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111

1 0

Fwd: Re: Fwd: MBR was destroyed
by Oliver Stieber Jan. 25, 2006

Jan. 25, 2006

> On Sun, Nov 20, 2005 at 05:30:39PM +0100, seorge wrote: > > Hi, > > > > Since I'm not a developerr and therefore can't take part in any discussion > > here may I ask you to discuss the bug I reported, because Dustin Navea asked > > me to join this list. Or if nobody really need my presence here, please let > > me know and I will unsubscribe. > > If you run WINE only as user (not as root) this just cannot happen. > > Did you run WINE as root? I've just tried at it appears to have wiped my MBR logged in as a normal User in wheel group. If this is the problem then I purchsed a new drive because of it last month. Oliver. > > Ciao, Marcus > > > > > > > ___________________________________________________________ > Yahoo! Model Search 2005 - Find the next catwalk superstars - > http://uk.news.yahoo.com/hot/model-search/ > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

11 21

Can't compile with vc7: oleauto.h(229) : error C2719: 'function-parameter': formal parameter with __declspec(align('8')) won't be aligned
by Dan Kegel Jan. 25, 2006

Jan. 25, 2006

A UCLA student trying to compile wine conformance tests on Windows ran into this: > [Compiling wine tests with VC7 or > the server 2003 sdk gets] this error when compiling. > > ..\..\..\include\oleauto.h(229) : error C2719: 'function-parameter': > formal parameter with __declspec(align('8')) won't be aligned (See http://msdn2.microsoft.com/en-us/library/373ak2y1.aspx ) Examining oleauto.h line 229, I saw the bad parameter was of type DOUBLE. I then went looking for the typedef for DOUBLE: ~/wine/include$ grep 'typedef.*DOUBLE' *.h The interesting hit was: wtypes.h:typedef double DECLSPEC_ALIGN(8) DOUBLE; The patch that introduced the change was http://www.winehq.com/hypermail/wine-cvs/2004/05/0027.html I told him to try replacing DOUBLE and DATE with double and date in the formal parameters in oleauto.h for now. Is that generally the right thing to do? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

CVS build error
by Peter Åstrand Jan. 25, 2006

Jan. 25, 2006

I can't build the CVS version anymore, I get: gcc -g -O2 -o widl client.o hash.o header.o proxy.o server.o typegen.o typelib.o utils.o widl.o write_msft.o parser.tab.o lex.yy.o -L../../libs -lwpp -lwine_port -lfl ../../libs/libwpp.a(lex.yy.o)(.text+0x624): In function `_yy_dummy_uses_of_static_functions_b2f4_517d_02ff_b30c_3e5a_47d7_aaa3_3b5d_': /home/peter/wine/libs/wpp/lex.yy.c:3357: multiple definition of `_yy_dummy_uses_of_static_functions_b2f4_517d_02ff_b30c_3e5a_47d7_aaa3_3b5d_' lex.yy.o(.text+0x58c):/home/peter/wine/tools/widl/lex.yy.c:1796: first defined here collect2: ld returned 1 exit status make[2]: *** [widl] Error 1 make[2]: Leaving directory `/home/peter/wine/tools/widl' Any ideas? -- Peter Åstrand ThinLinc Chief Developer Cendio www.cendio.se Teknikringen 3 583 30 Linköping Phone: +46-13-21 46 00

2 1

Re: d3d8: CreateDevice should try the parent if the current window fails
by H. Verbeet Jan. 25, 2006

Jan. 25, 2006

On 24/01/06, Jan Zerebecki <jan.wine(a)zerebecki.de> wrote: > Changelog: > d3d8: CreateDevice should try the parent if the current window fails > because it doesn't have the property __wine_x11_whole_window . > Fixes bug #4341 . Does that happen in wined3d as well? If so, it's probably usefull to fix wined3d as well, considering the idea is to make d3d8 use wined3d eventually.

2 1

Problems with references to drive Z: in registry's User Shell Folders
by Michael Jung Jan. 25, 2006

Jan. 25, 2006

Hi, when shell32.dll is registered during wineprefixcreate, it puts a lot of paths based on Z:\ in HKLM/HKCU Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders. This is due to resolving CIDL_PERSONAL to the DOS path corresponding to $HOME. If people remove the Z: drive afterwards, this leads to a lot problems (One being that the Desktop shellfolder won't initialize any more, which breaks the complete shell namespace and thus the file dialogs). I'm proposing to add two more environment variables: %PERSONAL%, which would be expanded to the DOS path corresponding to $HOME if this exists, or to %USERPROFILE%\\My Documents if not (with "My Documents" resource based, of course). And %DESKTOP%, which would be expanded to DOS_PATH_OF($HOME)\\Desktop if existent and to %USERPROFILE%\\Desktop, if not. Does someone see a problem with this approach? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

[Lostwages] Re: lostwages/templates/en download.template
by Tony Lambregts Jan. 24, 2006

Jan. 24, 2006

Jeremy Newman wrote: > ChangeSet ID: 22527 > CVSROOT: /opt/cvs-commit > Module name: lostwages > Changes by: jnewman(a)winehq.org 2006/01/24 14:26:23 > > Modified files: > templates/en : download.template > > Log message: > based on patch from: Sven Paschukat <Sven.Paschukat(a)t-online.de> > add a note to the WineTools link > > Patch: http://cvs.winehq.org/patch.py?id=22527 > > Old revision New revision Changes Path > 1.72 1.73 +8 -3 lostwages/templates/en/download.template > > Index: lostwages/templates/en/download.template > diff -u -p lostwages/templates/en/download.template:1.72 lostwages/templates/en/download.template:1.73 > --- lostwages/templates/en/download.template:1.72 24 Jan 2006 20:26:23 -0000 > +++ lostwages/templates/en/download.template 24 Jan 2006 20:26:23 -0000 > @@ -122,13 +122,18 @@ for post-installation instructions.</b>< > </a> > </td> > <td align=left bgcolor="#ffffff"> > - > <b><a href="http://www.von-thadden.de/Joachim/WineTools/">Wine Tools</a></b> - > WineTools is a menu driven installer for installing Windows programs. > This software lets you install the following Windows software: DCOM98, > IE6, Windows Core Fonts, Windows System Software, Office & Office Viewer, > - Adobe Photoshop 7, Illustrator 9 and many other programs. > - By <a href="http://www.von-thadden.de/Joachim/WineTools/">Joachim von Thadden</a>. > + Adobe Photoshop 7, Illustrator 9 and many other programs.<br /> > + By <a href="http://www.von-thadden.de/Joachim/WineTools/">Joachim von > + Thadden</a>.<br /> > + <div style="margin: 10px; padding: 5px; border: 1px solid #C0C0C0; background-color: #F0F0F0;"> > + <b>Note:</b> WineTools only recommended if installation or operability of > + Windows software failed on pure Wine or because the Wine developers need > + your feedback from testing. > + </div> > </td> > </tr> > </table> > > > Wine developers do not want feed back of bugs in programs with winetools installed Change Log: update note to the WineTools link Files Changed: lostwages/templates/en download.template Index: templates/en/download.template =================================================================== RCS file: /home/wine/lostwages/templates/en/download.template,v retrieving revision 1.73 diff -u -r1.73 download.template --- templates/en/download.template 24 Jan 2006 20:26:23 -0000 1.73 +++ templates/en/download.template 25 Jan 2006 03:27:01 -0000 @@ -131,8 +131,9 @@ Thadden</a>.<br /> <div style="margin: 10px; padding: 5px; border: 1px solid #C0C0C0; background-color: #F0F0F0;"> <b>Note:</b> WineTools only recommended if installation or operability of - Windows software failed on pure Wine or because the Wine developers need - your feedback from testing. + Windows software failed on pure Wine. Since winetools radically alters your + Wine configuration please do not report bugs in programs with WineTools + installed. </div> </td> </tr>

1 0

Re: [Fwd: WineTools is in need of some major house cleaning!]
by Joachim von Thadden Jan. 24, 2006

Jan. 24, 2006

Dear developers and all others reading this list, from Sven Paschukat I was informed about the discussion of removing the WineTools link from the winehq website. I read all remarks made to that hotly discussed topic and I am willing to tell you all a bit about the purpose and history of WineTools as well as I will answer the questions made by Tom Wickline. So this will be a little longish mail and I beg your pardon for that and hope you have enough patience to read it all. To start from the beginning, I took over the remainings of a project winetools initially started by Frank Hendriksen <frank(a)frankscorner.org> which was somehow orphaned. The very reason I did that was that in autumn 2004 I had to write an article in the well known German computer magazine c't. After fiddling with wine for a long time only to install a stable IE6 or Office, I found that it was so absolute complicated to describe all the steps needed only to install the IE6 (which is much better now) and that also following these steps was very erroneous, that I started to rewrite the winetools script for the readers of this article. I never meant it to become so famous and wide spread, but the download statistics after only two month showed me that there was a massive demand for such a tool. So this is how it started and it shows very clearly that it was always an installer to make certain important applications easily usable under Linux. It was never meant for testing or developing. It was always meant for the end user being able to use his software. At the time of the first releases it was almost impossible to install or work with many applications without using native DCOM and/or many of the builtin DLLs that come with the IE6. To find a configuration for as many apps as possible was one of the goals. Not to force users (with very low skills) to have many different wine installations *and* many wine user directories was a second goal. So this is the reason why, until now, everything in WineTools is based on this native M$ software (DCOM, IE6). And believe me, no one would be more happy to wipe this DCOM, IE6 and MSI stuff completely from his harddisk than me! So as so many programs rely on parts of M$ software (MFC, VB and MDAC are other important examples) and because to install and use this software leads to so many restrictions in the wine usage, I had to pin wine to the emulation of Win98 and also had to massively tamper around with DLLOverrides. The goal was to built up an environment, that can install and use as many Windows programs as possible. This did in no way regard to the fact that it is not very helpful for the wine developers. It was just a practical decision. >From time to time, Sven Paschukat and me are testing wine versions to figure out, whether we can skip some of the M$ stuff. We have not been very successful with that until now, so this is why there are so many remainings of the first start of the project in the concept. But again: This tool is for the average windows user. And believe me, I tested this with my brothers, who are just normal users. And they never ever got a piece of windows software running with wine without my heavy intervention. With WineTools they just need to click on some buttons and got their software downloaded, installed and configured. With an amount of many thousand downloads a month, not calculating the distribution inclusions of WineTools, I get almost the same number of direct mails about problems with the software as are coming into the list. And I get massive positive resonance from users who were for a long time trying to get their stuff running with plain wine and are now happy that it just works with WineTools. I must admit, that there raise problems out of the fact, that the same users are trying to install not WineTools-tested software with the setup of WineTools and coming then to the list. And your are right that this is an undebuggable situation. The only way around that is to smoothly migrate WineTools to more and more builtin features as long as this does not make the programs uninstallable or unusable. > Betreff: WineTools is in need of some major house cleaning! > Datum: Fri, 30 Dec 2005 03:31:43 -0500 > Von: Tom Wickline <twickline(a)gmail.com> > An: wine-devel <wine-devel(a)winehq.org> > > Hello Everyone, > > Anyone who reads the posting on this list already knows that I stood up for > the wineTools project and almost made a couple enemies... But me and Vitaliy > came to a half way agreement on whether or not we should keep the link > on our downloads page to WineTools.... > > I feel I need to ask a couple questions here about the future of WineTools. > > 1) Are the concerns that Vitaliy brought up being looked into? Sven Paschukat suggested to implement a mode for WineTools to install without native components and without that tampering in the registry. This allows automatic installations *and* insight for developers if something goes wrong. We can also add a debugging mode to enable the logging of wines debug channels, to make a mailable report of bugs. Also the other suggested corrections will be looked over and changed if applicable. > 2) On sourceforge there are still downloads of version 1.30 from > December 3, 2003 why is this? and do you plan to cancel this project > or at least update it? > sourceforge site: > http://sourceforge.net/project/showfiles.php?group_id=61341 > > 3 )Freshmeat list WineTools latest version at 2.1.0 and last updated 1 > year, 4 months ago > do you plan to update this site and list new versions as there released? > http://freshmeat.net/projects/winetools/?branch_id=51159&release_id=164227 I personally had never anything to do with these versions. The one on Sourceforge is Frank Hendriksen's. He was already contacted by Sven Paschukat to remove the project, but Sourceforge does not allow to remove projects. So instead he already pointed a link to the official WineTools site. I don't see what we can do more here. The one on Freshmeat was taken over and is maintained by Sven Paschukat. Also Freshmeat does not allow the removal of projects. But Sven will update the versions there and we will try to keep it uptodate. We might also move the whole download section to Freshmeat to unburden my download server. > 4) Could the maintainers of WineTools help new users in #winehq on > irc? or start a new channel #wine-tools (or something to that effect) > and help WineTools users? Can you list either the #winehq channel or a > new channel on your site and ask experienced users to help new users? I am very astonished about this request. If you look through the mailing list you will find, that Sven and me are already giving support on the wine-users mailing list. That we will not and can not maintain a channel should be clear as we are not earning our money by looking at channels. Also the demand by Vitaly to provide rapid fixes to requests on such a channel or the list is something that can be only meant as a joke!!! If Vitaly is a man of independent means it is nice for him but we are a free time project and can only work for WineTools, as the name suggests, in our *free* time. And we have also a family, friends, mistresses and other hobbies... > I am not trying to be critical..... I hope winehq keeps the link to > your project but you guys may need help more on winehq, and also keep > information sites more up to date for this to take place. and also > look in to Vitaliy's concerns. Well, we also do not like winehq to remove the project's link. As for the support I already wrote a line above about that. Note that there is a massive amount of users using Wine via WineTools. Almost all users coming from Windows are using this software if they like to use their programs. This might lead to more and more end user questions on the list. As a possible solution for that, if you think this gets the upper hand, I would suggest to have a new mailing list wine-winetools and to redirect all users to that one. We will propagate then this list in the readmes and on the WineTools sites. And for sure we will sit on this list like spiders lurking for our prey... At least I want to thank all wine developers for their absolute fantastic work! In my opinion this is one of the most interesting and most ambitious projects in the community of open source software. And it really works astonishingly good. Regards Joachim von Thadden -- "Never touch a running system! Never run a touching system? Never run a touchy system!!!"

3 3

Should the AppDB make public the number of unique page views each app gets?
by Scott Ritchie Jan. 24, 2006

Jan. 24, 2006

This was an idea we discussed in IRC for a short bit, and I think it would be good to bring it up here. Essentially, if the AppDB displayed the number of page views each app got it would go a long way towards estimating the demand for particular applications, whether they work or not. It seems fair to say that someone looking an app up in the AppDB either wants to run it in Wine or wants to know if it's doable should he switch to Wine. Coincidentally, this also helps solve the voting problem - since votes for gold apps are supposed to be replaced with votes for apps that work should be done on, we now have a mechanism to sort the Gold list other than by votes. Sorting the gold list by page views would also greatly help navigation from the front page of the AppDB, as it would place the most popular applications at the top. Then again, maybe there's something I've overlooked. Thoughts? -Scott Ritchie

4 3

Re: [Fwd: WineTools is in need of some major house cleaning!]
by Juan Lang Jan. 24, 2006

Jan. 24, 2006

Hm. Felt I needed to offer a counterpoint to Vitaliy's rather enthusiastic response. I support winetools, though I don't use it myself. Not only as a matter of principle (this is open source we're talking about, and one of the beauties is we don't get to constrain how it's used.) Also because it's in line with the aims of the Wine project: run Windows apps. Wine is nice in that it doesn't require you to have any MS license to run Windows apps, but it can use MS software if you have a licensed copy. So winetools offers folks with MS licenses a relatively easy way to get apps to run. Still, while that's nice for the users, it's not so nice for us Wine developers, because it's hard to get widespread testing of things we're improving if they're not being widely used. So, as Vitaliy suggested, it would be nice for us if you guys, who know what problems you encounter running with builtin DLLs, could file bug reports in bugzilla for us. That way at least we have a chance to say, hey, that problem's now fixed, consider using builtin OLE (or whatever) in the next release of winetools. Now for specifics. For instance, you use native advpack in all cases, but that's seen some more work recently. What bugs do you encounter if you use builtin instead? Same with ole32. Ideally, each of the apps that has a native override should have a bug report associated with it, what goes wrong if you use the builtin version instead. Also, the default override, "*"="native,builtin" seems wrong. If we don't have a DLL at all, we use a native version of course. I don't think it should be the policy to assume the Wine version isn't up to snuff by default. This could even cause problems, e.g. I don't believe any native version of netapi32.dll will work on Wine, yet you don't specify to use the builtin version. Also, you direct users to http://winehq.org/site/forums. That's fine since this is community support anyway, and it is often the case that winetools knowledgeable people are around (like you guys.) But it would be nicer if you could be clearer about it. Like, that we developers had nothing to do with it, and may be unfriendly to it if we're in a bad mood, or it's a Tuesday :) It'd also be nice (for us, even though no one actually reads anything these days) if you could be clearer about what it does. That it installs MS components, that it uses these instead of the builtin versions sometimes, that you can change how it does this using winecfg, etc. That'd make it easier for us to help folks that have only used winetools that want support, because often the first question we ask is, what version of wine, and what DLLs are you using? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2