October 2006 - Wine-Devel - list.winehq.org

Re: msi [3/3]: Set the USERNAME and COMPANYNAME properties when initializing a package
by Mike McCormack Oct. 17, 2006

Oct. 17, 2006

James Hawkins wrote: > + WCHAR user[MAX_PATH]; > + > + size = MAX_PATH; > + type = REG_SZ; > + user[0] = '\0'; > + res = RegQueryValueExW( hkey, szRegisteredUser, NULL, &type, (LPBYTE)user, &size ); > + MSI_SetPropertyW( package, szUSERNAME, user ); How about: LPWSTR user = msi_reg_get_val_str( hkey, szRegisteredUser ). MSI_SetPropertyW( package, szUserName, user ); msi_free( user ); (All upper case is usually for macros...) Mike

2 1

Re: comctl32: rebar: don't return rectangles with negative width or height in NCCalcSize (fixes bug #3797)
by Vitaliy Margolen Oct. 17, 2006

Oct. 17, 2006

Mikołaj Zalewski wrote: > CreateWindow doesn't like them > > if (infoPtr->dwStyle & WS_BORDER) { > - InflateRect((LPRECT)lParam, -GetSystemMetrics(SM_CXEDGE), > - -GetSystemMetrics(SM_CYEDGE)); > + rect->left = min(rect->left + GetSystemMetrics(SM_CXEDGE), rect->right); > + rect->right = max(rect->right - GetSystemMetrics(SM_CXEDGE), rect->left); > + rect->top = min(rect->top + GetSystemMetrics(SM_CXEDGE), rect->bottom); > + rect->bottom = max(rect->bottom - GetSystemMetrics(SM_CXEDGE), rect->top); Looks like a typo to me. You used SM_CXEDGE 4 times Vitaliy

1 0

Re: msi [2/3]: Run SetProperty events before all other events no matter what the order is
by Mike McCormack Oct. 17, 2006

Oct. 17, 2006

Yey! More msi fixes! :) James Hawkins wrote: > + copy = MSI_CopyRecord( rec ); Why not just do a msiobj_addref( &ref->hdr ) rather than copying the record? > + /* move SetProperty events to the front of the list */ > + reprioritize_set_prop_events( &events ); How about just running over the list twice, setting the properties the first time, and doing anything else the second time? Mike

1 0

[wined3d] GetFrontBufferData
by Karsten Elfenbein Oct. 16, 2006

Oct. 16, 2006

Hi, this is the patch that allows EVE online to capture ingame screenshots. (fixes the start coordinates for glReadPixels and turns the output upside down again) It works with the login screen (running as managed window) and in fullscreen. (when desktop is 32bit) Is there much more stuff needed or would cleaning up the code and replacing the 4 with the size of a pixel do the trick for the tree? Karsten

2 1

Re: user: add GetRawInputDeviceList stub
by Vitaliy Margolen Oct. 16, 2006

Oct. 16, 2006

L. Rahyen wrote: > Add missing stub to user32.dll.so - without it some games (like Postal 2 and > some others) cannot run. It seems that GetRawInputDeviceList is useless thing > in most cases because all these games works almost perfectly with this stub. > Thank you for sending patch. Here are few problems with it you need to fix: > +/**************************************************************************** > + * GetRawInputDeviceList (USER32.@) > + */ > +typedef struct tagRAWINPUTDEVICELIST { > + HANDLE hDevice; > + DWORD dwType; > +} RAWINPUTDEVICELIST, *PRAWINPUTDEVICELIST; All the definitions should go into headers. This particular one should go into winuser.h > + > +UINT WINAPI GetRawInputDeviceList(PRAWINPUTDEVICELIST pRawInputDeviceList, > PUINT puiNumDevices, UINT cbSize) This line is wrapped. > +{ > + FIXME("user: GetRawInputDeviceList stub"); No need to include function name, it will already be printed by FIXME. Also you missing newline. So this should be something like: FIXME("stub\n"); > + return NULL; > +} Return type is UINT not pointer. You should return 0. But you also need to set *puiNumDevices to 0. > > /****************************************************************** > * GetLastInputInfo (USER32.@) > --- dlls/user/user32.spec 2006-10-02 18:06:21.000000000 +0000 > +++ dlls/user/user32.spec~ 2006-10-02 18:09:01.000000000 +0000 > @@ -304,6 +304,7 @@ > @ stdcall GetKeyboardType(long) > @ stdcall GetLastActivePopup(long) > @ stdcall GetLastInputInfo(ptr) > +@ stdcall GetRawInputDeviceList(ptr long long) There is already that entry in the spec file. Please search it and replace. Don't add duplicate. Vitaliy

2 1

Re: winedbg: remove duplicated bare address in backtrace
by Eric Pouech Oct. 16, 2006

Oct. 16, 2006

Peter Oberndorfer wrote: >the bare address is printed at the beginning of the line and at the end in ( ) >like "2 0xb7eccf3b wine_switch_to_stack+0x17 in libwine.so.1 (0xb7eccf3b)" > > actually, it's the frame address that's supposed to be printed so it should read print_bare_address(&dbg_curr_thread->frames[dbg_curr_thread->curr_frame].addr_frame);

1 0

Re: user32[2/3]: send a WM_MOUSELEAVE even if another window calls TrackMouseEvent before the timer proc is called
by Alexandre Julliard Oct. 16, 2006

Oct. 16, 2006

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > @@ -949,6 +954,12 @@ TrackMouseEvent (TRACKMOUSEEVENT *ptme) > } > } > } else { > + /* In our implementation it's possible that another window will receive a > + * WM_MOUSEMOVE and call TrackMouseEvent before TrackMouseEventProc is > + * called. In such a situation post the WM_MOUSELEAVE now */ > + if (tracking_info.tme.hwndTrack != NULL) > + check_mouse_leave(hwnd, hittest); > + Shouldn't you check for TME_LEAVE first? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Fix compilation with gcc 2.95.
by Alexandre Julliard Oct. 16, 2006

Oct. 16, 2006

Francois Gouget <fgouget(a)free.fr> writes: > @@ -786,10 +787,10 @@ static inline void print_matrix( > const char* name, const D3DMATRIX* matrix) { > > trace("%s Matrix = {\n", name); > - trace(" %f %f %f %f\n", matrix->m[0][0], matrix->m[1][0], matrix->m[2][0], matrix->m[3][0]); > - trace(" %f %f %f %f\n", matrix->m[0][1], matrix->m[1][1], matrix->m[2][1], matrix->m[3][1]); > - trace(" %f %f %f %f\n", matrix->m[0][2], matrix->m[1][2], matrix->m[2][2], matrix->m[3][2]); > - trace(" %f %f %f %f\n", matrix->m[0][3], matrix->m[1][3], matrix->m[2][3], matrix->m[3][3]); > + trace(" %f %f %f %f\n", matrix->u.m[0][0], matrix->u.m[1][0], matrix->u.m[2][0], matrix->u.m[3][0]); > + trace(" %f %f %f %f\n", matrix->u.m[0][1], matrix->u.m[1][1], matrix->u.m[2][1], matrix->u.m[3][1]); > + trace(" %f %f %f %f\n", matrix->u.m[0][2], matrix->u.m[1][2], matrix->u.m[2][2], matrix->u.m[3][2]); > + trace(" %f %f %f %f\n", matrix->u.m[0][3], matrix->u.m[1][3], matrix->u.m[2][3], matrix->u.m[3][3]); You have to use the U(x) macros in tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Delorme AAA Map N Go 6 install fail - maybe COM related?
by David D. Hagood Oct. 16, 2006

Oct. 16, 2006

I am getting a crash when I try to install Delorme AAA MapNGo 6 under a fresh build of Wine (CVS as of 15 Oct 2006). The crash leads me to believe there is a problem with Wine's COM system (Delorme is about the most COM-happy company I have seen - I think they would make every pixel a COM object if they could). The thing that jumps out to me is the "fixme:typelib:SLTG_DoVars unhandled flags = 08" error - I wonder if this is causing an error passing a pointer-ish object, which later gets dereferenced and boom. Do I need to force some aspect of Wine (e.g. a DLL or TLB) to be registered? ./Setup.exe libGL warning: 3D driver claims to not support visual 0x4c libGL warning: 3D driver claims to not support visual 0x4c libGL warning: 3D driver claims to not support visual 0x4c libGL warning: 3D driver claims to not support visual 0x4c [wowbaggr(a)surfer d:]$ libGL warning: 3D driver claims to not support visual 0x4c libGL warning: 3D driver claims to not support visual 0x4c fixme:setupapi:SetupDefaultQueueCallbackW notification 262144 params 33f9ac,0 err:setupapi:SetupDefaultQueueCallbackW copy error 0 L"C:\\windows\\temp\\IXP000.TMP\\OLEAUT32.DLL" -> L"c:\\windows\\system32\\OLEAUT32.DLL" fixme:ole:DllRegisterServer stub fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 fixme:typelib:SLTG_DoVars unhandled flags = 08 wine: Unhandled page fault on read access to 0x0156018b at address 0x610d6468 (thread 000e), starting debugger... fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\mpr.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\winedos.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\midimap.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\msacm32.drv fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\msacm32.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\winealsa.drv fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\uxtheme.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\imm32.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\winex11.drv fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\lz32.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\ole32.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\iphlpapi.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\winspool.drv Unhandled exception: page fault on read access to 0x0156018b in 32-bit code (0x610d6468). err:dbghelp:pe_load_dbg_file -Unable to peruse .DBG file oleaut32.dbg ("\xb8\xf74") Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:610d6468 ESP:0034e444 EBP:0034e5cc EFLAGS:00010216( - 00 -RIAP1) EAX:0000ffff EBX:6111d708 ECX:0155018c EDX:012a1238 ESI:012a11f0 EDI:012a1264 Stack dump: 0x0034e444: 00110000 00000000 00000010 ffffffff 0x0034e454: 012a1238 00000010 00000000 611235f0 0x0034e464: 611137b8 611235f0 611137b8 008228d6 0x0034e474: 01283370 0155018c 012a11bc 01550c14 0x0034e484: 006b2330 00000010 012a11f0 00000001 0x0034e494: 495f5456 286e0032 00293033 000002d8 fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000119 Backtrace: =>1 0x610d6468 in oleaut32 (+0x36468) (0x610d6468) 2 0x610d7b01 in oleaut32 (+0x37b01) (0x610d7b01) 3 0x610df741 in oleaut32 (+0x3f741) (0x610df741) 4 0x610e006f in oleaut32 (+0x4006f) (0x610e006f) err:dbghelp:pe_load_dbg_file -Unable to peruse .DBG file dao3032.DBG ("\x01") 5 0x04730f6b in dao3032 (+0x30f6b) (0x04730f6b) 6 0x00436904 in _ins5576._mp (+0x36904) (0x00436904) 7 0x00436b56 in _ins5576._mp (+0x36b56) (0x00436b56) 8 0x00416890 in _ins5576._mp (+0x16890) (0x00416890) 9 0x00415733 in _ins5576._mp (+0x15733) (0x00415733) 10 0x00414fe8 in _ins5576._mp (+0x14fe8) (0x00414fe8) 11 0x00414ded in _ins5576._mp (+0x14ded) (0x00414ded) 12 0x00414af8 in _ins5576._mp (+0x14af8) (0x00414af8) 13 0x00414949 in _ins5576._mp (+0x14949) (0x00414949) 14 0x00414129 in _ins5576._mp (+0x14129) (0x00414129) 15 0x0041039f in _ins5576._mp (+0x1039f) (0x0041039f) 16 0x00421273 in _ins5576._mp (+0x21273) (0x00421273) 17 0x00421d5f in _ins5576._mp (+0x21d5f) (0x00421d5f) 18 0x0043ce59 in _ins5576._mp (+0x3ce59) (0x0043ce59) 19 0x0043d165 in _ins5576._mp (+0x3d165) (0x0043d165) 20 0x00437457 in _ins5576._mp (+0x37457) (0x00437457) 21 0x004379bd in _ins5576._mp (+0x379bd) (0x004379bd) 22 0x004769af in _ins5576._mp (+0x769af) (0x004769af) 23 0x6038999c (0x6038999c) 24 0x60007fb7 (0x60007fb7) 0x610d6468: movl 0x0(%eax,%ecx,1),%eax Modules: Module Address Debug info Name (24 modules) PE 380000-3a3000 Deferred a5f PE 3b0000-3bd000 Deferred a62 PE 3c0000-3d0000 Deferred _wutl951 PE 400000-491000 Export _ins5576._mp PE 4000000-410d000 Deferred msjt3032 PE 41d0000-41e0000 Deferred msjint32 PE 41e0000-41ec000 Deferred msjter32 PE 4700000-4773000 Export dao3032 PE 10000000-10014000 Deferred zdatai51 PE 60280000-60283000 Deferred ntdll PE 60330000-6037e000 Deferred kernel32 PE 60450000-60461000 Deferred user32 PE 60580000-60583000 Deferred advapi32 PE 60610000-60614000 Deferred gdi32 PE 606c0000-6071b000 Deferred comdlg32 PE 60770000-607c8000 Deferred shell32 PE 60850000-60855000 Deferred shlwapi PE 60940000-60943000 Deferred rpcrt4 PE 609b0000-609c1000 Deferred comctl32 PE 60a80000-60a83000 Deferred version PE 60ab0000-60af4000 Deferred winmm PE 61000000-61045000 Deferred msvcrt20 PE 61030000-61034000 Deferred msvcrt PE 610a0000-61132000 Export oleaut32 Threads: process tid prio (all id:s are in hex) 0000000f 00000010 0 0000000d (D) C:\windows\temp\_ISTMP3.DIR\_INS5576._MP 0000000e 0 <== 0000000a 0000000c 0 0000000b 0

3 4

Appdb as application regression finder
by Dan Kegel Oct. 16, 2006

Oct. 16, 2006

The appdb has a "browse by ratings" page, e.g. you can see all apps that have at least one Gold-rated version at http://appdb.winehq.org/browse_by_rating.php?sRating=Gold This can serve as a kind of poor man's application regression finder; look at each app on that page, and look for apps whose latest version is rated lower than gold. For instance, WinZip is listed on the Gold page. WinZip 9 is indeed rated gold, but winzip 10 is only silver. Likesize, Sametime Connect has an old version rated gold, and a new one rated garbage. If nothing else, it would be great for someone to look at all such 'regressions', test them with current wine, and update the appdb and bugzilla with what they find. Who knows, maybe we can clear a few of these up without too much effort. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 11