October 2006 - Wine-Devel - list.winehq.org

Re: opengl32: Correctly size and position opengl child windows
by Roderick Colenbrander Oct. 11, 2006

Oct. 11, 2006

Hi, The plan is to get all the X-specific opengl code into winex11.drv and to get rid of things like ExtEscape. I also want to avoid using WineGLContext in opengl32.dll as I plan to change this too. A call like SyncCurrentDrawable should in the end be placed inside winex11.drv. I haven't looked into solutions to the window rendering bug. Based on old discussions solutions are to use pbuffers (but those are 'slow' compared to directly rendering to a window), FBOs, creation of a subwindow and the Scissors hack which you did. The scissors hack might work correctly for a number of programs but what do you plan to do with glReadPixels and friends? My work will first consist of routing some remaining wgl calls through gdi32 to winex11.drv. When that is done (which will hopefully be today or else this weekend) I want to get rid of ExtEscape calls and rewrite the WineGLContext code. There's no need for much win32-specific stuff inside winex11.drv Roderick > This patch override glViewport and glScissor to correctly position and > size > opengl child windows. > > I've only tested this patch with Google Earth and Google Sketchup so I'd > like to get some feedback to see if this solves the problem for your > application. > > Roderick: I realize you're currently reworking opengl32 so let me know if > this conflicts with what you are doing. > > Thanks, > > /Ulrich > -- GMX DSL-Flatrate 0,- Euro* - Überall, wo DSL verfügbar ist! NEU: Jetzt bis zu 16.000 kBit/s! http://www.gmx.net/de/go/dsl

3 4

Cursor patches
by H. Verbeet Oct. 11, 2006

Oct. 11, 2006

Regenerated against git HEAD for whoever cares about these. Changes since last time: - user: format warning fixes - user: initialise cursor16 to 0 in destroy_cursor() - user: fix a small compile problem in the 6th patch, caused by splitting things up. (The 8th patch removes the relevant block) - server: remove redundant NULL checks before free() - server: fix a memory leak in destroy_cursor()

1 0

Re: winedump: Cast-qual warnings fix
by Dmitry Timoshkov Oct. 11, 2006

Oct. 11, 2006

"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote: > #define IMAGE_FIRST_SECTION(ntheader) \ > - ((PIMAGE_SECTION_HEADER)((LPBYTE)&((PIMAGE_NT_HEADERS)(ntheader))->OptionalHeader + \ > - ((PIMAGE_NT_HEADERS)(ntheader))->FileHeader.SizeOfOptionalHeader)) > + ((PIMAGE_SECTION_HEADER)((LPBYTE)&((PIMAGE_NT_HEADERS)(UINT32)(ntheader))->OptionalHeader + \ > + ((PIMAGE_NT_HEADERS)(UINT32)(ntheader))->FileHeader.SizeOfOptionalHeader)) UINT32 is not a 64-bit safe type. Please use ULONG_PTR instead. -- Dmitry.

3 5

Re: [PATCH] SPI_GETFONTSMOOTHINGORIENTATION and SPI_SETFONTSMOOTHINGORIENTATION are kown actions
by James Hawkins Oct. 11, 2006

Oct. 11, 2006

On 10/11/06, Christian Gmeiner <christian.gmeiner(a)students.fhv.at> wrote: > dlls/user/sysparams.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/user/sysparams.c b/dlls/user/sysparams.c > index 35be4fa..921c4f6 100644 > --- a/dlls/user/sysparams.c > +++ b/dlls/user/sysparams.c > @@ -2249,6 +2249,8 @@ #define WINE_SPI_WARN(x) \ > WINE_SPI_FIXME(SPI_SETFOCUSBORDERWIDTH); /* 0x200F _WIN32_WINNT > >= 0x510 */ > WINE_SPI_FIXME(SPI_GETFOCUSBORDERHEIGHT); /* 0x2010 > _WIN32_WINNT >= 0x510 */ > WINE_SPI_FIXME(SPI_SETFOCUSBORDERHEIGHT); /* 0x2011 > _WIN32_WINNT >= 0x510 */ > + WINE_SPI_FIXME(SPI_GETFONTSMOOTHINGORIENTATION); /* 0x2012 */ > + WINE_SPI_FIXME(SPI_SETFONTSMOOTHINGORIENTATION) /* 0x2013 */ > > default: > FIXME( "Unknown action: %u\n", uiAction ); > Have you tried to compile this? You're missing a semicolon. Make sure you run make on your changes, and look over your patches carefully before sending them in. -- James Hawkins

1 0

Red Hat Enterprise 3 packages for Wine?
by Dan Kegel Oct. 11, 2006

Oct. 11, 2006

The page http://www.winehq.com/site/download-rh is great, but nobody's built these packages since 0.9.2. Can someone whip out a White Box Enterprise Linux 3.0 build of 0.9.22? Thanks, Dan

1 0

Re: comctl32: toolbar[1/5]: don't send NM_CUSTOMDRAW for separators (fixes bug #5572)
by James Hawkins Oct. 11, 2006

Oct. 11, 2006

On 10/11/06, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > Windows doesn't send them. > I believe you, but it would be nice if you sent in a test with the change. -- James Hawkins

1 0

Cursor patches
by H. Verbeet Oct. 11, 2006

Oct. 11, 2006

Regenerated against git HEAD for whoever cares about these things. Changes since last time: - user: format warning fixes - user: initialise cursor16 to 0 in destroy_cursor() - user: fix a small compile problem in the 6th patch, caused by splitting things up. (The 8th patch removes the relevant block) - server: remove redundant NULL checks before free() - server: fix a memory leak in destroy_cursor()

1 0

Re: [PATCH] Set window type in winex11.drv
by Alexandre Julliard Oct. 11, 2006

Oct. 11, 2006

"Nickolay V. Shmyrev" <nshmyrev(a)yandex.ru> writes: > While waiting for review I suggest a bit more advanced patch. It sets > dialog type for dialog and reorders call sequence. I don't think reordering the calls is useful, and it makes it harder to see what you are really changing. Please avoid that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Make all windows moveable by default
by Vitaliy Margolen Oct. 11, 2006

Oct. 11, 2006

Dmitry Timoshkov wrote: > Hello, > > an app I'm working on creates a top level window without a caption, > and returns HTCAPTION on WM_NCHITTEST to make the window moveable by > dragging its client area. The app's window currently is not moveable > under Wine because we don't set MWM_FUNC_MOVE WM hint for captionless > windows. This patch makes my app's main window moveable. This patch broke some full screen programs for me on KDE. Now their caption is always visible and doesn't move off the screen. It might be some additional magic going on with KDE to detect full-screen windows. Vitaliy

2 7

re: Add IRunnableObject stub implementation
by Dan Kegel Oct. 11, 2006

Oct. 11, 2006

> On 10/10/06, Huw Davies <huw at codeweavers.com> wrote: > > On Tue, Oct 10, 2006 at 04:45:40PM -0400, Vijay Kiran Kamuju wrote: > > > Add IRunnableObject stub implementation, > > > > It's not at all clear to me what this interface should do in this > > context. Could you at least add a test that shows that the domdoc > > object should expose IRunnableObject? > > Check the bug# 6341 [http://bugs.winehq.org/show_bug.cgi?id=6341 ] > previously I sent a patch > http://www.winehq.org/pipermail/wine-patches/2006-September/030659.html > No response, so I thought its noway getting into the main tree, so no tests. > Well I sent this one to the list so that it does not get lost. Vijay, tests are exactly what you need to get things into the tree! And adding the test Huw suggests is very easy, go ahead and do that, and repost your patch with the test added (after verifying that the test passes on real windows). Thanks for working on some of these msxml problems! - Dan

3 4