November 2006 - Wine-Devel - list.winehq.org

Re: Regression: broken locale in 0.9.25
by Kirill K. Smirnov Nov. 10, 2006

Nov. 10, 2006

As glibc manual http://www.cs.utah.edu/dept/old/texinfo/glibc-manual-0.02/library.html says: QUOTE When you read the current locale for category LC_ALL, the value encodes the entire combination of selected locales for all categories. In this case, the value is not just a single locale name. In fact, we don't make any promises about what it looks like. But if you specify the same "locale name" with LC_ALL in a subsequent call to setlocale, it restores the same combination of locale selections. END OF QUOTE So, any calls setlocale(LC_ALL, *) with analyzing the return value should be eliminated. Moreover, variable LC_ALL may be absent (my case). Quick solution: diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c index 9a72a4c..1ac2b4c 100644 --- a/dlls/kernel32/locale.c +++ b/dlls/kernel32/locale.c @@ -512,7 +512,10 @@ static LCID get_env_lcid( UINT *unix_cp, char *buf, *lang,*country,*charset,*dialect,*next; LCID ret = 0; - if ((lang = setlocale( category, NULL )) && *lang) + if (category == LC_ALL) lang = getenv("LC_ALL"); + else lang = setlocale(category, NULL); + if (!lang || !*lang) lang = getenv("LANG"); + if (lang && *lang) { if (!strcmp(lang,"POSIX") || !strcmp(lang,"C")) goto done;

1 0

Regression: broken locale in 0.9.25
by Kirill K. Smirnov Nov. 10, 2006

Nov. 10, 2006

Hi, all! The following patch: http://www.winehq.org/pipermail/wine-cvs/2006-November/027599.html breaks locale with wine. I get several messages: Warning: Language 'LC_CTYPE=ru_RU' was not recognized, defaulting to English. Warning: Language 'LC_CTYPE=ru_RU' was not recognized, defaulting to English. and, as result, fonts are broken too. The reason is in the following piece of patch: - if (((lang = getenv( "LC_ALL" )) && *lang) || - (env_str && (lang = getenv( env_str )) && *lang) || - ((lang = getenv( "LANG" )) && *lang) || - ((lang = user_locale) && *lang)) + if ((lang = setlocale( category, NULL )) && *lang) LC_ALL variable contains single locale, e.g. "ru_RU.KOI8-R", but function setlocale(LC_ALL, NULL) returns: LC_CTYPE=ru_RU.KOI8-R;LC_NUMERIC=ru_RU.KOI8-R;LC_TIME=ru_RU.KOI8-R;LC_COLLATE=C;LC_MONETARY=ru_RU.KOI8-R;LC_MESSAGES=ru_RU.KOI8-R;LC_PAPER=ru_RU.KOI8-R;LC_NAME=ru_RU.KOI8-R;LC_ADDRESS=ru_RU.KOI8-R;LC_TELEPHONE=ru_RU.KOI8-R;LC_MEASUREMENT=ru_RU.KOI8-R;LC_IDENTIFICATION=ru_RU.KOI8-R which is incorrectly parsed. -- Kirill K. Smirnov

1 0

What about improve D3D in wine?
by Mirek Nov. 10, 2006

Nov. 10, 2006

Hi i have found Nvidia SDK programs and demos, i can install it in wine and some D3D demos can even run, but almost all are someway broken, in Nvidia SDK there are even source codes for those demos, what about start improving Direct3D in wine with help of this demos? It should be easy to track what is wrong and what is right. Here is link: http://www.nvidia.com/object/sdk_home.html Mirek

2 1

Re: server: Avoid accessing free'd thread pointers.
by Eric Pouech Nov. 10, 2006

Nov. 10, 2006

IMO this should be fixed by rewriting correctly the _SAFE version of the list macros, which are to blame here. I have this somewhere, I'll send it later on. 2006/11/10, Mike McCormack <mike(a)codeweavers.com>: > > --- > server/process.c | 28 ++++++++++++++++++++++++---- > 1 files changed, 24 insertions(+), 4 deletions(-) > > > > > > > -- Eric Pouech

4 10

Regression: bug #6560
by Kirill K. Smirnov Nov. 10, 2006

Nov. 10, 2006

Hi! The following patch: http://www.winehq.org/pipermail/wine-cvs/2006-September/025991.html [ 106156cb7597cf6f077b6f4e9d7562d8932fd766 is first bad commit commit 106156cb7597cf6f077b6f4e9d7562d8932fd766 Author: Robert Shearman <rob(a)codeweavers.com> Date: Mon Sep 11 11:14:25 2006 +0100 ole32: Remove some assertions in the stuctured storage code by returning error codes to the caller and by handling the error condition. :040000 040000 a17e245c7e40f15678aa2a78709ec927fb456d40 e25ebc1996d61a0d34658b4c09434705e9245512 M dlls ] caused the bug #6560 I do not understand the true reasons. The reason of it lurks somewhere in installation process (installation of Office), but no reasonable messages on console. Any ideas? -- Kirill K. Smirnov

1 0

Regression in patch: OpenGL32: remove glx context
by Mirek Nov. 10, 2006

Nov. 10, 2006

This patch broke nvidia SDK opengl demos, i cant run it with this patch. Here is some small report from terminal: cvswine glsl_bump_mapping.exe err:wgl:process_attach X11DRV or GDI32 not loaded. Cannot create default context. err:module:LdrInitializeThunk "opengl32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"G:\\usr\\games\\nvidiaSDK\\DEMOS\\OpenGL\\bin\\Release\\glsl_bump_mapping.exe" failed, status c0000142 Mirek Roderick Colenbrander napsal(a): > Hi, > > This patch removes creation of a GLX context at opengl32 startup. > > The old code created a GLX context at startup, so that programs could call glGet* functions like glGetString before creating an OpenGL context. The OpenGL standards don't allow this and I verified this on winxp/win98 and as expected calling glGet* before creating a context returns NULL as documented everywhere. > > The the code was originally added for a game called Homeworld which called wglGet* before creating a context. Atleast the first version of the game made this call but I haven't seen this behaviour in the source code of the game (which is public). Most likely it was a bug in the first version of the game. > > Regards, > Roderick Colenbrander > > > ------------------------------------------------------------------------ > > --- dlls/opengl32/wgl.c 2006-11-03 22:35:06.000000000 +0100 > +++ dlls/opengl32/wgl.c 2006-11-03 16:47:33.000000000 +0100 > @@ -74,9 +74,6 @@ > void (*wine_tsx11_lock_ptr)(void) = NULL; > void (*wine_tsx11_unlock_ptr)(void) = NULL; > > -static GLXContext default_cx = NULL; > -static Display *default_display; /* display to use for default context */ > - > static HMODULE opengl32_handle; > > static char internal_gl_disabled_extensions[512]; > @@ -107,17 +104,6 @@ > return; > } > > -/* retrieve the X display to use on a given DC */ > -inline static Display *get_display( HDC hdc ) > -{ > - Display *display; > - enum x11drv_escape_codes escape = X11DRV_GET_DISPLAY; > - > - if (!ExtEscape( hdc, X11DRV_ESCAPE, sizeof(escape), (LPCSTR)&escape, > - sizeof(display), (LPSTR)&display )) display = NULL; > - return display; > -} > - > /*********************************************************************** > * wglCreateLayerContext (OPENGL32.@) > */ > @@ -635,19 +621,12 @@ > creating a rendering context.... */ > static BOOL process_attach(void) > { > - XWindowAttributes win_attr; > - Visual *rootVisual; > - int num; > - XVisualInfo template; > - HDC hdc; > - XVisualInfo *vis = NULL; > - Window root = (Window)GetPropA( GetDesktopWindow(), "__wine_x11_whole_window" ); > HMODULE mod = GetModuleHandleA( "winex11.drv" ); > HMODULE mod_gdi32 = GetModuleHandleA( "gdi32.dll" ); > DWORD size = sizeof(internal_gl_disabled_extensions); > HKEY hkey = 0; > > - if (!root || !mod || !mod_gdi32) > + if (!mod || !mod_gdi32) > { > ERR("X11DRV or GDI32 not loaded. Cannot create default context.\n"); > return FALSE; > @@ -661,40 +640,6 @@ > /* Interal WGL function */ > wine_wgl.p_wglGetIntegerv = (void *)wine_wgl.p_wglGetProcAddress("wglGetIntegerv"); > > - hdc = GetDC(0); > - default_display = get_display( hdc ); > - ReleaseDC( 0, hdc ); > - if (!default_display) > - { > - ERR("X11DRV not loaded. Cannot get display for screen DC.\n"); > - return FALSE; > - } > - > - ENTER_GL(); > - > - /* Try to get the visual from the Root Window. We can't use the standard (presumably > - double buffered) X11DRV visual with the Root Window, since we don't know if the Root > - Window was created using the standard X11DRV visual, and glXMakeCurrent can't deal > - with mismatched visuals. Note that the Root Window visual may not be double > - buffered, so apps actually attempting to render this way may flicker */ > - if (XGetWindowAttributes( default_display, root, &win_attr )) > - { > - rootVisual = win_attr.visual; > - } > - else > - { > - /* Get the default visual, since we can't seem to get the attributes from the > - Root Window. Let's hope that the Root Window Visual matches the DefaultVisual */ > - rootVisual = DefaultVisual( default_display, DefaultScreen(default_display) ); > - } > - > - template.visualid = XVisualIDFromVisual(rootVisual); > - vis = XGetVisualInfo(default_display, VisualIDMask, &template, &num); > - if (vis != NULL) default_cx = glXCreateContext(default_display, vis, 0, GL_TRUE); > - if (default_cx != NULL) glXMakeCurrent(default_display, root, default_cx); > - XFree(vis); > - LEAVE_GL(); > - > internal_gl_disabled_extensions[0] = 0; > if (!RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\\OpenGL", &hkey)) { > if (!RegQueryValueExA( hkey, "DisabledExtensions", 0, NULL, (LPBYTE)internal_gl_disabled_extensions, &size)) { > @@ -703,9 +648,6 @@ > RegCloseKey(hkey); > } > > - if (default_cx == NULL) { > - ERR("Could not create default context.\n"); > - } > return TRUE; > } > > @@ -714,8 +656,6 @@ > > static void process_detach(void) > { > - glXDestroyContext(default_display, default_cx); > - > HeapFree(GetProcessHeap(), 0, internal_gl_extensions); > } > > > > ------------------------------------------------------------------------ > >

3 2

[FYI] Wiki down
by Dimi Paun Nov. 10, 2006

Nov. 10, 2006

Folks, We are experiencing some hardware problems on wiki.winehq.org. I have taken the wiki down until we work through the issues to protect the data. We are working to fix it, and to provide better failover in the future. We are hoping to have it back up by the end of the day. I am sorry about the downtime, and I apologize for any inconvenience caused by it. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 1

Qcap questions
by Andrew Talbot Nov. 9, 2006

Nov. 9, 2006

In qcap/pin.c, the function OutputPin_GetDeliveryBuffer() shows the parameters tStart and tStop as being of type const REFERENCE_TIME *. Looking at the SDK web site, I see a function called CBaseOutputPin::GetDeliveryBuffer() that has similar parameters that are non-const. May I deconstify these parameters in our function, in order to avoid some cast-qual warnings, or are they constrained? Thanks, -- Andy.

1 0

dlls/user/hook.c HOOK_CallHooks() help
by Phil Lodwick Nov. 9, 2006

Nov. 9, 2006

Hi, I have an application that is hitting the assert in HOOK_CallHooks. ------ trace:hook:HOOK_CallHooks calling hook in thread 0113 WH_CALLWNDPROC code 0 wp 0 lp 7fbef984 err:hook:HOOK_CallHooks Unknown hook id 4 wine-pthread: hook.c:381: HOOK_CallHooks: Assertion `0' failed. ------ Basically I have a call stack that looks like this: 4 0x7f886b31 HOOK_CallHooks+0x251(id=0x4, code=0x0, wparam=0x0, lparam=0x7fbef984, unicode=0x0) [dlls/user/hook.c:381] in user32 (0x7fbef944) 5 0x7f8a4e8c call_window_proc+0x9c(hwnd=0x0, msg=0x0, wparam=0x0, lparam=0x0, unicode=0x0, same_thread=0x0) [dlls/user/message.c:1512] in user32 (0x7fbef9a0) 6 0x7f8a5dca peek_message(msg=0x7fbefcd0, hwnd=0x0, first=0x0, last=0xffffffff, flags=0x1) [dlls/user/message.c:2053] in user32 (0x7fbefca8) 7 0x7f8a7a16 PeekMessageW(msg_out=0x7fbefe10, hwnd=0x0, first=0x0, last=0x0, flags=0x1) [dlls/user/message.c:2694] in user32 (0x7fbefcfc) 8 0x7f8a7cc9 GetMessageW+0x109(msg=0x7fbefe10, hwnd=0x0, first=0x0, last=0x0) [dlls/user/message.c:2764] in user32 (0x7fbefdb0) 9 0x7f8a7e67 GetMessageA+0x37(msg=0x7fbefe10, hwnd=0x0, first=0x0, last=0x0) [dlls/user/message.c:2804] in user32 (0x7fbefdd0) ------------------- The WH_CALLWNDPROC is usually filtered out by the HOOK_IsHooked() call, but not in this case. I don't have source code available for the application. I was hoping somebody might have a good suggestion for the next step in debugging this problem. Right now I am going to start looking at GetMessageA and follow that code down to call_window_proc and see if I see something obvious. Thanks, Phil

2 4

mscoree: Graphical notice
by Segin Nov. 9, 2006

Nov. 9, 2006

Is it a wise idea to add a graphical warning to mscoree that Wine doesn't support running .NET applications directly yet? I was thinking about using a MessageBox() to deliver the warning. I also wanted the popup to be displayed conditionally, in which if Wine was started from the commandline, the box isn't displayed at all. Since most DEs spawn programs that, although their output reaches the tty that 'startx' was called from, they aren't attached to that tty. Evidence this by starting "tty" from within KDE or GNOME, then switch to the virtual console that you started your X session from. You should note a line near the bottom that says "not a tty". From a program's perspective, you can check for this by calling isatty(1) (file descriptor 1 is usually standard output, and I belive that POSIX mandates this behaviour) and checking if the return value is one (or not, in which display the GUI warning). Is using OS-level file descriptors in conjunction with functions such as isatty() safe programming practice with Wine? I wasn't to sure, and wanted to know. -- The real problem with C++ for kernel modules is: the language just sucks. -- Linus Torvalds

2 1

Re: oledlg: Cast-qual warnings fix
by Huw Davies Nov. 9, 2006

Nov. 9, 2006

On Wed, Nov 08, 2006 at 09:56:54PM +0000, Andrew Talbot wrote: > @@ -666,16 +672,20 @@ > if(psA->cPasteEntries > 0) > { > UINT i; > - for(i = 0; i < psA->cPasteEntries; i++) > + > + for(i = psA->cPasteEntries; i != 0;) Was there any need for this? Huw.

2 1

Re: kernel32: Add basic OpenProcess test, make it pass under Wine
by Alexandre Julliard Nov. 8, 2006

Nov. 8, 2006

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > diff -up a/server/protocol.def b/server/protocol.def > --- a/server/protocol.def 2006-11-06 18:35:52.000000000 +0800 > +++ b/server/protocol.def 2006-11-06 21:57:22.000000000 +0800 > @@ -335,6 +335,7 @@ struct token_groups > /* Retrieve information about a process */ > @REQ(get_process_info) > obj_handle_t handle; /* process handle */ > + unsigned int access; /* wanted access rights */ > @REPLY > process_id_t pid; /* server process id */ > process_id_t ppid; /* server process id of parent */ Enforcing the proper access rights for a given operation is the server's job, it doesn't make sense to allow the client to specify its own access rights. -- Alexandre Julliard julliard(a)winehq.org

1 0

DIBs with negative width/height
by Damjan Jovanovic Nov. 8, 2006

Nov. 8, 2006

Hi Does anyone know (or know where to find) what it means for biWidth and/or biHeight for a DIB section's BITMAPINFOHEADER to be negative? It seems largely undocumented. The MSDN says a negative biHeight is a top-down bitmap (the normal positive biHeight is bottom-up), so does a negative biWidth mean scanlines run from right to left? Thank you Damjan

1 0

subclass test for comctl32
by Paul Vriens Nov. 8, 2006

Nov. 8, 2006

Hi, There are no tests run on Wine (or win98/nt4/w2K) when running the subclass tests for comctl32. test.winehq.org shows that tests are run for XP and W2K3. It look like SetWindowSubclass, RemoveWindowSubclass and DefSubclassProc are exported by name on XP and W2K3 and by ordinal on the other ones. How should/can we deal with this? Should we export by name as well? (get rid of the -noname). Or do we need to change the test to first try by name and then by ordinal (or only by ordinal)? Cheers, Paul.

2 1

Re: usp10 #1/2: create HandleTables to keep track of memory allocation.
by Jeff L Nov. 8, 2006

Nov. 8, 2006

Rob, as the HandleTable was your suggestion, could you provide a comment on whether these patches are a practical way forward? Jeff Latimer Jeff Latimer wrote: > These 2 patches implement HandleTables for tracking memory usage for > the SCRIPT_STRING_ANALYSIS pointer. The problem is that the ssa can > be copied to another pointer and NULL'ing the pointer is not a > reliable means of de-allocating the pointer. The use of HandleTables > looks like a solution to the problem but it depends on whether storing > a handle in the ssa pointer is acceptable. The table is of fixed size > which is another potential problem but tests indicate that the number > of handles in use will remain relatively small by comparison to the > table size. > > Advice is welcome. > > Jeff Latimer > > Changelog: > Create HandleTables to keep track of memory allocation > --- > dlls/usp10/Makefile.in | 2 + > dlls/usp10/usp10.c | 71 > +++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 70 insertions(+), 3 deletions(-) > ------------------------------------------------------------------------ > > diff --git a/dlls/usp10/Makefile.in b/dlls/usp10/Makefile.in > index 9d716d5..edef33a 100644 > --- a/dlls/usp10/Makefile.in > +++ b/dlls/usp10/Makefile.in > @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = usp10.dll > IMPORTLIB = libusp10.$(IMPLIBEXT) > -IMPORTS = gdi32 kernel32 > +IMPORTS = gdi32 ntdll kernel32 > > C_SRCS = \ > usp10.c > diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c > index 9fd6c1e..4b15047 100644 > --- a/dlls/usp10/usp10.c > +++ b/dlls/usp10/usp10.c > @@ -30,6 +30,7 @@ #include "wingdi.h" > #include "winuser.h" > #include "winnls.h" > #include "usp10.h" > +#include "winternl.h" > > #include "wine/debug.h" > > @@ -73,17 +74,83 @@ typedef struct scriptcache { > HDC hdc; > } Scriptcache; > > +typedef struct _CACHE_HANDLE > +{ > + RTL_HANDLE RtlHandle; > + void * Cache_Address; > +} CACHE_HANDLE; > + > +DWORD TlsIndex; /* Adress of shared memory */ > + > /*********************************************************************** > * DllMain > * > + * In this DllMain storage is allocated to each thread so that a HandleTable can > + * be created and maintained thread safe. > + * > + * NOTES > + * The Tls functions (TlsAlloc, TlsSetValue, TlsGetValue and TlsFree) provide > + * access to the local thread storage. > + * > + * LocalAlloc and LocalFree are used as in the Microsoft examples to access > + * local thread storage. > + * > + * RtlInitializeHandleTable initialises the handle table to a fixed size of > + * entries to contain the addresses of the cache pointers used in the > + * ScriptString... functions. This function is fairly light weight as the > + * space for the handle table entries is not allocated at this time but waits > + * until the first RtlAllocateHandle call. Hence only the functions that need > + * the handles incur the additional expense. > */ > BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) > { > + RTL_HANDLE_TABLE *Cache_HandleTable; > + BOOL Return_flag; > + > switch(fdwReason) { > + /* > + * When the dll is loaded obtain a TlsIndex so that the HandleTable > + * pointer can be stored there uniquely for each thread. > + */ > case DLL_PROCESS_ATTACH: > - DisableThreadLibraryCalls(hInstDLL); > - break; > + if ((TlsIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES) > + return FALSE; > + /* Fall though to THREAD_ATTACH as loading a DLL only drives > + * DLL_PROCESS_ATTACHand not DLL_THREAD_ATTACH. Here we allocate space > + * for the HandleTable from the thread local storage, save the pointer in > + * the Tls and intialise the table. > + */ > + case DLL_THREAD_ATTACH: > + Cache_HandleTable = LocalAlloc(LPTR, sizeof(RTL_HANDLE_TABLE)); > + if (Cache_HandleTable) > + { > + Return_flag = TlsSetValue(TlsIndex, Cache_HandleTable); > + RtlInitializeHandleTable(0x3FFF, sizeof(CACHE_HANDLE), Cache_HandleTable); > + } > + break; > + /* > + * At exit from a thread, clean up HandleTable which includes freeing the > + * associated memory for handles and the HandleTable. > + */ > + case DLL_THREAD_DETACH: > + Cache_HandleTable = TlsGetValue(TlsIndex); > + if (Cache_HandleTable) > + { > + RtlDestroyHandleTable(Cache_HandleTable); > + LocalFree(Cache_HandleTable); > + } > + break; > + /* > + * As for DLL_THREAD_DETACH but includes freeing the TlsIndex. > + */ > case DLL_PROCESS_DETACH: > + Cache_HandleTable = TlsGetValue(TlsIndex); > + if (Cache_HandleTable) > + { > + RtlDestroyHandleTable(Cache_HandleTable); > + LocalFree(Cache_HandleTable); > + } > + TlsFree(TlsIndex); > break; > } > return TRUE; > > > ------------------------------------------------------------------------ > > >

1 0

Big regressions in latest CVS version
by Mirek Nov. 8, 2006

Nov. 8, 2006

Hi, there is big regression in latest CVS version, i dont know which patch caused it, but it was ok in release 0.9.24. The first regression is in 3DMarks (i tried only 2005 and 2006), startup logo is completly broken, and selection of tests too, second bigger regression is in nvidia SDK demos, all opengl demos are not working now with log like this: athlon64:/usr/games/nvidiaSDK/DEMOS/OpenGL/bin/Release# cvswine glsl_physics.exe err:wgl:process_attach X11DRV or GDI32 not loaded. Cannot create default context. err:module:LdrInitializeThunk "opengl32.dll" failed to initialize, aborting err:module:LdrInitializeThunk Main exe initialization for L"G:\\usr\\games\\nvidiaSDK\\DEMOS\\OpenGL\\bin\\Release\\glsl_physics.exe" failed, status c0000142 athlon64:/usr/games/nvidiaSDK/DEMOS/OpenGL/bin/Release# Tomorow i am going to try find which patch caused such regression. Mirek

4 4

Re: [PATCH 2/2] comctl32: Switch to a Nx4 tiling.
by Kirill K. Smirnov Nov. 7, 2006

Nov. 7, 2006

> This patch breaks http://angusj.com/sudoku/ This patch breaks toolbars in almost every application, e.g. comdlg32.GetOpenFileName. But Winword 97 was not affected though.

2 1

Re: [PATCH 5/5] winspool.drv: Associate a printer driver with each printer, rather than share a common one between all printers.
by Detlef Riekenberg Nov. 7, 2006

Nov. 7, 2006

On Di, 2006-11-07 at 14:43 +0000, Huw Davies wrote: > + dep_file[] = "<dependend files?>" REG_MULTI_SZ need a second '\0', but I prefer to remove the Junk and use an empty string. (I have no Idea, if a NULL works on windows, because I have no tests for the AddDriver* - Functions yet) -- By by ... Detlef

1 0

Re: [PATCH 4/5] winspool.drv: Fix AddPrinterDriverA so that the strings actually get written.
by Detlef Riekenberg Nov. 7, 2006

Nov. 7, 2006

On Di, 2006-11-07 at 14:37 +0000, Huw Davies wrote: > RegSetValueExA(hkeyName, "Dependent Files", 0, REG_MULTI_SZ, > + (LPBYTE) di3.pDependentFiles, > lstrlenA(di3.pDependentFiles) + 1); Hi Huw. Thanks for working on winspool.drv again, but: "lstrlenA(di3.pDependentFiles) + 1" is not correct for REG_MULTI_SZ I suggest: LPSTR ptr; DWORD total; .... total = 0; ptr = di3.pDependentFiles; if (ptr) { while (ptr[0]) { len = lstrlenA(ptr) + 1; /* actual string */ total += len; ptr += len; } total++; /* extra '\0' for REG_MULTI_SZ - termination */ } -- By by ... Detlef

1 0

Re: wined3d: Use width while converting surfaces.
by Stefan Dösinger Nov. 7, 2006

Nov. 7, 2006

Hi, > - for (x = 0; x < pitch / 2; x++ ) { > + for (x = 0; x < width / 2; x++ ) { This is not quite correct. pitch / 2 was used because in D3DFMT_R5G6B5 pitch = 2* width(Used to be, before my alignment patches). So this line should be for (x = 0; x < width; x++ ) {

1 0

Re: Executing wine over make segfaults.
by Lee Harr Nov. 7, 2006

Nov. 7, 2006

># wine --version >Works! > >But: > >Makefile >--------- >test: > wine --version >--------- > >Then run: >#make test > >Wine will segfault! I am having the same problem. I use wine to run a compiler from a Makefile. A few months ago, it worked fine, but recently it stopped working. I even downgraded to versions that had worked before, but without success. I have a few older systems that rarely get updated and are working fine, so I was not too concerned about it, but when I saw that 0.9.24 worked, I thought I was back in business.... except it doesn't work from make. The system is gentoo linux (2.6.18-gentoo-r1) wine compiled like this: ./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --sysconfdir=/etc/wine --without-curses --without-opengl --with-x --disable-trace --disable-debug --build=i686-pc-linux-gnu >Do you have any special kernel compile options in use? It's gentoo, so everything is custom compiled, but I try to keep it pretty vanilla. I don't think I have stack-protector on unless that is the default for gcc-4.1.1 I could try installing an older version of gcc or an older kernel and see if that helps. Any other ideas? Thanks for your time. _________________________________________________________________ FREE pop-up blocking with the new MSN Toolbar - get it now! http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/

8 20

toolbar buttons bug
by Kirill K. Smirnov Nov. 7, 2006

Nov. 7, 2006

Hi! Today, Nov 7 13:05:46 MSK 2006 I've build current wine git. Something evil happened to toolbar buttons - most of them are black. This bug appears in every application I use. Has anybody have the same problem? (If so, then regression testing awaits us :-() -- Kirill K. Smirnov

1 0

Re: Patch for opengl32.dll.so
by Roderick Colenbrander Nov. 7, 2006

Nov. 7, 2006

> Roderick Colenbrander wrote : > >> On 11/1/06, Bertrand Coconnier <bcoconni(a)club-internet.fr> wrote: > >>> Hi, > >>> > >>> The last release of Wine 0.9.24 contains an error in the code of > >> opengl32.dll.so > >>> under X11 : Wine tries to get the address of "wglGetIntegerv" (line > 608 > >> of > >>> dlls/opengl32/wgl.c) before the extensions of WGL have actually been > >> loaded > >>> (i.e. before X11DRV_WineGL_LoadExtensions() is called). The reading of > >> the > >>> wglGetIntegerv address fails and afterwards, whenever > >> internal_glGetIntegerv() > >>> is called, wine_wgl.p_wglGetIntegerv is NULL and a Fatal Exception is > >> raised. > >> > >> > >> This is probably already fixed in the git tree. See the commit: > >> winex11.drv: Fixed the prototype of many OpenGL functions. > >> > >> Jesse > > > > Else if the problem still happens something strange is going as the > extensions are registered at x11drv startup. > > > > Roderick > > Yes, the problem still happens because the function process_attach() (line > 582 > of dlls/opengl32/wgl.c) is called before the x11drv startup. The comment > of > process_attach is very clear : "/* This is for brain-dead applications > that use > OpenGL functions before even creating a rendering context.... */". It is > clear > that process_attach is a workaround for *brain-dead* apps :) and among > other > things it gets the address of wglGetIntegerv. This operation used to > succeed as > long as GetProcAddress() was used but now since x11drv is needed to upload > the > wglGetIntegerv address there is some kind of race condition and the > operation > fails hence the bug. > > Bertrand. Compared to 0.9.23 I changed the way wglGetIntegerv is loaded before it was directly loaded using GetProcAddress from winex11.drv now it is still loaded from winex11.drv but then using wglGetProcAddress from gdi32. At wine startup (I'm not sure at which stage but I believe directly when you use gdi stuff or perhaps even earlier) winex11.drv is initialized and during this initialization my opengl code is initialized aswell. I wonder what causes the race as I haven't seen it happening for other users yet. I want to avoid a patch like yours as I plan to do similar things for some other functions. Perhaps something goes wrong in wglGetProcAddress itself. Try running wine using: WINEDEBUG=+wgl,+opengl wine wow.exe -opengl &> log. If it is correct you'll see some opengl information (gl version, loading of extensions) before stuff happens in opengl32.dll. Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

6 10

Re: [PATCH 2/2] comctl32: Switch to a Nx4 tiling.
by Robert Reif Nov. 7, 2006

Nov. 7, 2006

Mike McCormack wrote: > --- > This fixes bug #3573. The only functions left that depend on Nx1 are > ImageList_Read and ImageList_Write, and they need a good rewriting... This patch breaks http://angusj.com/sudoku/

1 0

re: oleaut32: variant - allow conversion of VT_DISPATCH into VT_BSTR in VarCat
by Dan Kegel Nov. 6, 2006

Nov. 6, 2006

Alex wrote: > While reviewing a tax application, I found out that this app tries to > VarCat(VT_BSTR, VT_DISPATCH) and viceversa. By allowing this conversion, > the application proceeds normally until the next step. Please include a change to the conformance test to test this case. Also, if you have a minute, please file a bug report at http://bugs.winehq.org so we know what tax application it is, etc. Thanks! - Dan (the guy who asked Benjamin do all those VarCat fixes...) -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0