November 2006 - Wine-Devel - list.winehq.org

Re: [PATCH] Implement GetShellSecurityDescriptor and test for it
by Francois Gouget Nov. 6, 2006

Nov. 6, 2006

On Mon, 6 Nov 2006, Andrey Turkin wrote: [...] > The patch also adds 2 structures definitions to include/shlwapi.h. > According to MSDN, one of these structures should be placed into > include/shlobj.h, The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID, SHELL_USER_PERMISSION or GetShellSecurityDescriptor(). So they should be defined in a private shlwapi header, not in include/shlobj.h or include/shlwapi.h. > but I think it is bad idea to include shlobj.h from > shlwapi.h (at least at the moment). It would certainly be a bad idea since the PSDK's shlwapi.h header does not include shlobj.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

2 3

WineD3D: heap corruption in d3dfmt_convert_surface
by Markus Amsler Nov. 6, 2006

Nov. 6, 2006

I have (finally!) found the heap corruption in bf1942: Small surfaces have a pitch of 4 and a width <4. This results in pitch*4 > outpitch in IWineD3DSurfaceImpl_LoadTexture:1844. Afterwards the heap gets corrupted in d3dfmt_convert_surface:1654. The attached patch fixes the problem. I'm quite sure this fix is ugly, Suggestions? Markus

2 1

Re: kernel32: Add basic OpenProcess test, make it pass under Wine
by Robert Shearman Nov. 6, 2006

Nov. 6, 2006

Dmitry Timoshkov wrote: > Hello, > > Changelog: > kernel32: Add basic OpenProcess test, make it pass under Wine. > > @@ -1960,7 +1961,7 @@ NTSTATUS WINAPI NtFlushVirtualMemory( HA > NTSTATUS status = STATUS_SUCCESS; > void *addr = ROUND_ADDR( *addr_ptr, page_mask ); > > - if (!is_current_process( process )) > + if (!is_current_process( process, PROCESS_VM_OPERATION )) > { > ERR("Unsupported on other process\n"); > return STATUS_ACCESS_DENIED; > > Does this fix a real application or is it something that could just as easily be deferred until these remote operations are supported? -- Rob Shearman

2 1

WineD3D: heap corruption patch
by Markus Amsler Nov. 6, 2006

Nov. 6, 2006

Oops, forgot to attach diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index d0f44cf..45972c4 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -1841,8 +1841,7 @@ static HRESULT WINAPI IWineD3DSurfaceImp int height = This->glRect.bottom - This->glRect.top; /* Stick to the alignment for the converted surface too, makes it easier to load the surface */ - outpitch = width * bpp; - outpitch = (outpitch + 3) & ~3; + outpitch = pitch * 4; mem = HeapAlloc(GetProcessHeap(), 0, outpitch * height); if(!mem) {

1 0

Re: Cast-qual warning fix
by Dmitry Timoshkov Nov. 6, 2006

Nov. 6, 2006

"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote: > -typedef void *MSIITERHANDLE; > +typedef void *MSIITERHANDLE; > +typedef const void *MSICITERHANDLE; Personally I don't like MSICITERHANDLE typedef at all. It' not obvious that 'C' in the name marks constness of the object. Using 'const' explicitly such as 'const MSIITERHANDLE *handle' is much more clear and readable IMO. -- Dmitry.

3 2

Re: ntdll: implement RtlMakeHandleAllocated to mark handles as vailid
by Robert Shearman Nov. 6, 2006

Nov. 6, 2006

Jeff Latimer wrote: > This patch automates the marking of a handle as allocated as part of > RtlAllocateHandle. I can't see any reason for not providing a > complete function handle as part of allocating it. > > Changelog: > Mark handle as valid as part of RtlAllocateHandle. From my vague memory of writing the tests, I don't think Windows does this (or I wouldn't have written the code in the tests to make the handle valid). -- Rob Shearman

1 0

exception in MsiDatabaseOpenViewW
by Stefan Leichter Nov. 6, 2006

Nov. 6, 2006

Hello, when installing MS VC 2005 i get an exception in MsiDatabaseOpenViewW. Is anyone interested ? Bye Stefan

1 0

Re: select() on sockets considered harmful, use poll() instead?
by Juan Lang Nov. 6, 2006

Nov. 6, 2006

Dan wrote: > The suspect statements are: > > dinput/joystick_linux.c: if (1>select(This->joyfd+1,&readfds,... > dinput/joystick_linuxinput.c: if (1>select(This->joyfd+1,&readfds,... > icmp/icmp_main.c: while ((res=select(icp->sid+1,&fdr,... > netapi32/nbt.c: r = select(fd + 1, &fds, ... > wininet/internet.c: if (select(nSocket+1,&infd,... > wininet/netconnection.c: if (select(connection->socketFD+1,&infd,... These, at least, are safe: they poll on a single file descriptor. > ws2_32/socket.c: if( (highfd = select(highfd + 1, p_read, p_write, p_except, timeoutaddr)) This is the only potentially problematic one, but I didn't look at it closely enough to know for sure. --Juan __________________________________________________________________________________________ Check out the New Yahoo! Mail - Fire up a more powerful email and get things done faster. (http://advision.webevents.yahoo.com/mailbeta)

3 2

Linux with Wine is faster than windowsXP?
by ErV Nov. 5, 2006

Nov. 5, 2006

Hello. I've got a computer with two OS'es installed - ASPLinux11 and WindowsXP SP2. I've tested recently a super_pi mod 1.4(pi caltulation) on both operating systems (I've used same Win32 binary file) . It looks like it works faster under Linux, while it crashes under windowsXP at certain conditions. What's going on? My friend tried same trick on his computer(taht is much more powerful). He got slightly different results. IN his case program works fastr under windows, when calculations aren't very complicated (pi with 16K digits), but it works faster under linux when calculating "pi" with 1M digits. What's going on? I just want to know if this is a proof of WindowsXP being slower, or does that mean that there is some timer-related bug? ASPLinux claims their wine version is 9.5 while there is mention only about 9.24 version on this site. Here are timing results and links to original program: link to the program: http://www.techpowerup.com/downloads/126/mirrors.php checksum of result can be checked (if provided) at: http://www.xtremesystems.com/pi/ My configuration: 1. AMD Athlon (Thunderbird) 900 Mhz 2. 3x128 Мб DIMM SDRam 3. DFI AK75-EC /OCtect Rhino KT133A-ASP motherboard WindowsXP timinig: 16К - 1.199 s. 32K - 2.727 s 64K - 6.433 s 128K and more - crashes with an accessviolation. ASPLinux11 (via Wine) timinig: 16K - 01.199s 32K - 02.339s 64K - 04.676s 128K - 12.409s 256K - 31.005s 512K - 1m 17.630s 1M - 2m 53.044s results with checksum: ASPLinux11: 64K time 4.703s checksum 06874B42 WindowsXP: 64K time 06.461s checksum 72955C87 My friend's configuration and results (unfortunately he didn't provide any checksum): configuration: GigabitP4Titan 845PE/Cel2400/1Gb/WXPSp2 WindowsXP: 16K - 0.922s 32K - 1.828s 64K - 3.437s 128K - 9.266s 256K - 26.453s 512K - 1m 07.391s 1M - 2m 43.078s ASPLinux11: 16K - 1.511s 32K - 2.318s 64K - 4.372s 128K - 9.156s 256K - 23.454s 512K - 1m 3.082s 1M - 2m 07.937s Victor "ErV" Eremin.

4 5

explorer: Build on Darwin versions prior to 8.0
by Phil Krylov Nov. 5, 2006

Nov. 5, 2006

Hello, In Darwin versions prior to 8.0, the DiskArbitration framework was a private framework, that is, the headers were not included in SDK and the API was changing in every version. This patch fixes the build in these OS versions. -- Ph.

1 1

Re: msvfw32: Cast-qual warning fix
by Andrew Talbot Nov. 5, 2006

Nov. 5, 2006

Francois Gouget wrote: > Actually they are in recent PSDKs (for instance the Windows 2003 SP2 > PSDK). > > So this patch should not be applied. > Acknowledged with thanks to Dmitry and yourself. -- Andy.

1 0

Re: msvfw32: Cast-qual warning fix
by Francois Gouget Nov. 5, 2006

Nov. 5, 2006

On Sat, 4 Nov 2006, Andrew Talbot wrote: > The last formal argument of MCIWndCreate() is not const-qualified in the SDK. Actually they are in recent PSDKs (for instance the Windows 2003 SP2 PSDK). So this patch should not be applied. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0

Re: msvfw32: Cast-qual warning fix
by Dmitry Timoshkov Nov. 5, 2006

Nov. 5, 2006

"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote: > The last formal argument of MCIWndCreate() is not const-qualified in the SDK. It is in my version of the PSDK headers, but it is not in the PSDK docs. -- Dmitry.

2 1

Flickering bug for World of Warcraft
by Bertrand Coconnier Nov. 4, 2006

Nov. 4, 2006

Hi, After investigating a bit in the Wine code, it seems that the flickering bug of WoW in OpenGL mode is due to wglGetPbufferDCARB that returns a DC which type is OBJ_MEMDC while it should return a DC which type is OBJ_DC. And since in the current git tree, the DC type of a Pbuffer is OBJ_MEMDC then the code located in lines 1394-1395 of dlls/winex11.drv/opengl.c is executed : the Pbuffer is copied to the screen each time the GL context is made current to the Pbuffer hence the flickering (WoW bounds the GL context alternatively to the screen and to the Pbuffer). The expected behaviour is not to copy the Pbuffer content to the screen since WoW does it itself. The easiest workaround for this bug would be to make X11DRV_wglGetPbufferDCARB to return the Pbuffer's object->hdc (this fixes the flickering bug). However, I have made some tests with Windows XP and it appears that wglGetPbufferDCARB returns a HDC different from the HDC passed when wglCreatePbufferARB was called. So such a patch would be a dirty hack not a real fix. I am not familiar enough with Wine to submit a patch so I leave the gurus out there find an elegant solution. Attached is the code that I used to perform a few tests about Pbuffers on Windows XP (code of interest is located from line 293 to line 298). Regards, Bertrand. /* * This Code Was Created By Jeff Molofee 2000 * A HUGE Thanks To Fredric Echols For Cleaning Up * And Optimizing This Code, Making It More Flexible! * If You've Found This Code Useful, Please Let Me Know. * Visit My Site At nehe.gamedev.net */ #include <windows.h> // Header File For Windows #include <gl\gl.h> // Header File For The OpenGL32 Library #include <gl\glu.h> // Header File For The GLu32 Library #include <gl\glaux.h> // Header File For The Glaux Library HDC hDC=NULL; // Private GDI Device Context HGLRC hRC=NULL; // Permanent Rendering Context HWND hWnd=NULL; // Holds Our Window Handle HINSTANCE hInstance; // Holds The Instance Of The Application bool keys[256]; // Array Used For The Keyboard Routine bool active=TRUE; // Window Active Flag Set To TRUE By Default bool fullscreen=TRUE; // Fullscreen Flag Set To Fullscreen Mode By Default LRESULT CALLBACK WndProc(HWND, UINT, WPARAM, LPARAM); // Declaration For WndProc DECLARE_HANDLE(HPBUFFERARB); typedef HPBUFFERARB (APIENTRY * wglCreatePbufferARB_t)(HDC hDC, int iPixelFormat, int iWidth, int iHeight, const int *piAttribList); typedef HDC (APIENTRY * wglGetPbufferDCARB_t)(HPBUFFERARB hPbuffer); typedef int (APIENTRY * wglReleasePbufferDCARB_t)(HPBUFFERARB hPbuffer, HDC hDC); typedef BOOL (APIENTRY * wglDestroyPbufferARB_t)(HPBUFFERARB hPbuffer); wglCreatePbufferARB_t wglCreatePbufferARB = NULL; wglGetPbufferDCARB_t wglGetPbufferDCARB = NULL; wglReleasePbufferDCARB_t wglReleasePbufferDCARB = NULL; wglDestroyPbufferARB_t wglDestroyPbufferARB = NULL; GLvoid ReSizeGLScene(GLsizei width, GLsizei height) // Resize And Initialize The GL Window { if (height==0) // Prevent A Divide By Zero By { height=1; // Making Height Equal One } glViewport(0,0,width,height); // Reset The Current Viewport glMatrixMode(GL_PROJECTION); // Select The Projection Matrix glLoadIdentity(); // Reset The Projection Matrix // Calculate The Aspect Ratio Of The Window gluPerspective(45.0f,(GLfloat)width/(GLfloat)height,0.1f,100.0f); glMatrixMode(GL_MODELVIEW); // Select The Modelview Matrix glLoadIdentity(); // Reset The Modelview Matrix } int InitGL(GLvoid) // All Setup For OpenGL Goes Here { glShadeModel(GL_SMOOTH); // Enable Smooth Shading glClearColor(0.0f, 0.0f, 0.0f, 0.5f); // Black Background glClearDepth(1.0f); // Depth Buffer Setup glEnable(GL_DEPTH_TEST); // Enables Depth Testing glDepthFunc(GL_LEQUAL); // The Type Of Depth Testing To Do glHint(GL_PERSPECTIVE_CORRECTION_HINT, GL_NICEST); // Really Nice Perspective Calculations return TRUE; // Initialization Went OK } int DrawGLScene(GLvoid) // Here's Where We Do All The Drawing { glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); // Clear Screen And Depth Buffer glLoadIdentity(); // Reset The Current Modelview Matrix return TRUE; // Everything Went OK } GLvoid KillGLWindow(GLvoid) // Properly Kill The Window { if (fullscreen) // Are We In Fullscreen Mode? { ChangeDisplaySettings(NULL,0); // If So Switch Back To The Desktop ShowCursor(TRUE); // Show Mouse Pointer } if (hRC) // Do We Have A Rendering Context? { if (!wglMakeCurrent(NULL,NULL)) // Are We Able To Release The DC And RC Contexts? { MessageBox(NULL,"Release Of DC And RC Failed.","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); } if (!wglDeleteContext(hRC)) // Are We Able To Delete The RC? { MessageBox(NULL,"Release Rendering Context Failed.","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); } hRC=NULL; // Set RC To NULL } if (hDC && !ReleaseDC(hWnd,hDC)) // Are We Able To Release The DC { MessageBox(NULL,"Release Device Context Failed.","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); hDC=NULL; // Set DC To NULL } if (hWnd && !DestroyWindow(hWnd)) // Are We Able To Destroy The Window? { MessageBox(NULL,"Could Not Release hWnd.","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); hWnd=NULL; // Set hWnd To NULL } if (!UnregisterClass("OpenGL",hInstance)) // Are We Able To Unregister Class { MessageBox(NULL,"Could Not Unregister Class.","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); hInstance=NULL; // Set hInstance To NULL } } /* This Code Creates Our OpenGL Window. Parameters Are: * * title - Title To Appear At The Top Of The Window * * width - Width Of The GL Window Or Fullscreen Mode * * height - Height Of The GL Window Or Fullscreen Mode * * bits - Number Of Bits To Use For Color (8/16/24/32) * * fullscreenflag - Use Fullscreen Mode (TRUE) Or Windowed Mode (FALSE) */ BOOL CreateGLWindow(char* title, int width, int height, int bits, bool fullscreenflag) { GLuint PixelFormat; // Holds The Results After Searching For A Match WNDCLASS wc; // Windows Class Structure DWORD dwExStyle; // Window Extended Style DWORD dwStyle; // Window Style RECT WindowRect; // Grabs Rectangle Upper Left / Lower Right Values WindowRect.left=(long)0; // Set Left Value To 0 WindowRect.right=(long)width; // Set Right Value To Requested Width WindowRect.top=(long)0; // Set Top Value To 0 WindowRect.bottom=(long)height; // Set Bottom Value To Requested Height fullscreen=fullscreenflag; // Set The Global Fullscreen Flag hInstance = GetModuleHandle(NULL); // Grab An Instance For Our Window wc.style = CS_HREDRAW | CS_VREDRAW | CS_OWNDC; // Redraw On Size, And Own DC For Window. wc.lpfnWndProc = (WNDPROC) WndProc; // WndProc Handles Messages wc.cbClsExtra = 0; // No Extra Window Data wc.cbWndExtra = 0; // No Extra Window Data wc.hInstance = hInstance; // Set The Instance wc.hIcon = LoadIcon(NULL, IDI_WINLOGO); // Load The Default Icon wc.hCursor = LoadCursor(NULL, IDC_ARROW); // Load The Arrow Pointer wc.hbrBackground = NULL; // No Background Required For GL wc.lpszMenuName = NULL; // We Don't Want A Menu wc.lpszClassName = "OpenGL"; // Set The Class Name HPBUFFERARB pBuffer = NULL; #define WGL_PBUFFER_LARGEST_ARB 0x2033 int attrib[] = {WGL_PBUFFER_LARGEST_ARB, 0, 0}; BOOL success; HDC pBufferHDC; DWORD type1 = 0; DWORD type2 = 0; int result = 0xdeadbeef; if (!RegisterClass(&wc)) // Attempt To Register The Window Class { MessageBox(NULL,"Failed To Register The Window Class.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } if (fullscreen) // Attempt Fullscreen Mode? { DEVMODE dmScreenSettings; // Device Mode memset(&dmScreenSettings,0,sizeof(dmScreenSettings)); // Makes Sure Memory's Cleared dmScreenSettings.dmSize=sizeof(dmScreenSettings); // Size Of The Devmode Structure dmScreenSettings.dmPelsWidth = width; // Selected Screen Width dmScreenSettings.dmPelsHeight = height; // Selected Screen Height dmScreenSettings.dmBitsPerPel = bits; // Selected Bits Per Pixel dmScreenSettings.dmFields=DM_BITSPERPEL|DM_PELSWIDTH|DM_PELSHEIGHT; // Try To Set Selected Mode And Get Results. NOTE: CDS_FULLSCREEN Gets Rid Of Start Bar. if (ChangeDisplaySettings(&dmScreenSettings,CDS_FULLSCREEN)!=DISP_CHANGE_SUCCESSFUL) { // If The Mode Fails, Offer Two Options. Quit Or Use Windowed Mode. if (MessageBox(NULL,"The Requested Fullscreen Mode Is Not Supported By\nYour Video Card. Use Windowed Mode Instead?","NeHe GL",MB_YESNO|MB_ICONEXCLAMATION)==IDYES) { fullscreen=FALSE; // Windowed Mode Selected. Fullscreen = FALSE } else { // Pop Up A Message Box Letting User Know The Program Is Closing. MessageBox(NULL,"Program Will Now Close.","ERROR",MB_OK|MB_ICONSTOP); return FALSE; // Return FALSE } } } if (fullscreen) // Are We Still In Fullscreen Mode? { dwExStyle=WS_EX_APPWINDOW; // Window Extended Style dwStyle=WS_POPUP; // Windows Style ShowCursor(FALSE); // Hide Mouse Pointer } else { dwExStyle=WS_EX_APPWINDOW | WS_EX_WINDOWEDGE; // Window Extended Style dwStyle=WS_OVERLAPPEDWINDOW; // Windows Style } AdjustWindowRectEx(&WindowRect, dwStyle, FALSE, dwExStyle); // Adjust Window To True Requested Size // Create The Window if (!(hWnd=CreateWindowEx( dwExStyle, // Extended Style For The Window "OpenGL", // Class Name title, // Window Title dwStyle | // Defined Window Style WS_CLIPSIBLINGS | // Required Window Style WS_CLIPCHILDREN, // Required Window Style 0, 0, // Window Position WindowRect.right-WindowRect.left, // Calculate Window Width WindowRect.bottom-WindowRect.top, // Calculate Window Height NULL, // No Parent Window NULL, // No Menu hInstance, // Instance NULL))) // Dont Pass Anything To WM_CREATE { KillGLWindow(); // Reset The Display MessageBox(NULL,"Window Creation Error.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } static PIXELFORMATDESCRIPTOR pfd= // pfd Tells Windows How We Want Things To Be { sizeof(PIXELFORMATDESCRIPTOR), // Size Of This Pixel Format Descriptor 1, // Version Number PFD_DRAW_TO_WINDOW | // Format Must Support Window PFD_SUPPORT_OPENGL | // Format Must Support OpenGL PFD_DOUBLEBUFFER, // Must Support Double Buffering PFD_TYPE_RGBA, // Request An RGBA Format bits, // Select Our Color Depth 0, 0, 0, 0, 0, 0, // Color Bits Ignored 0, // No Alpha Buffer 0, // Shift Bit Ignored 0, // No Accumulation Buffer 0, 0, 0, 0, // Accumulation Bits Ignored 16, // 16Bit Z-Buffer (Depth Buffer) 0, // No Stencil Buffer 0, // No Auxiliary Buffer PFD_MAIN_PLANE, // Main Drawing Layer 0, // Reserved 0, 0, 0 // Layer Masks Ignored }; if (!(hDC=GetDC(hWnd))) // Did We Get A Device Context? { KillGLWindow(); // Reset The Display MessageBox(NULL,"Can't Create A GL Device Context.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } if (!(PixelFormat=ChoosePixelFormat(hDC,&pfd))) // Did Windows Find A Matching Pixel Format? { KillGLWindow(); // Reset The Display MessageBox(NULL,"Can't Find A Suitable PixelFormat.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } if(!SetPixelFormat(hDC,PixelFormat,&pfd)) // Are We Able To Set The Pixel Format? { KillGLWindow(); // Reset The Display MessageBox(NULL,"Can't Set The PixelFormat.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } if (!(hRC=wglCreateContext(hDC))) // Are We Able To Get A Rendering Context? { KillGLWindow(); // Reset The Display MessageBox(NULL,"Can't Create A GL Rendering Context.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } if(!wglMakeCurrent(hDC,hRC)) // Try To Activate The Rendering Context { KillGLWindow(); // Reset The Display MessageBox(NULL,"Can't Activate The GL Rendering Context.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } wglCreatePbufferARB = (wglCreatePbufferARB_t)wglGetProcAddress("wglCreatePbufferARB"); wglGetPbufferDCARB = (wglGetPbufferDCARB_t)wglGetProcAddress("wglGetPbufferDCARB"); wglReleasePbufferDCARB = (wglReleasePbufferDCARB_t)wglGetProcAddress("wglReleasePbufferDCARB"); wglDestroyPbufferARB = (wglDestroyPbufferARB_t)wglGetProcAddress("wglDestroyPbufferARB"); pBuffer = wglCreatePbufferARB(hDC, PixelFormat, width, height, attrib); pBufferHDC = wglGetPbufferDCARB(pBuffer); type1 = GetObjectType(hDC); type2 = GetObjectType(pBufferHDC); result = wglReleasePbufferDCARB(pBuffer, pBufferHDC); success = wglDestroyPbufferARB(pBuffer); ShowWindow(hWnd,SW_SHOW); // Show The Window SetForegroundWindow(hWnd); // Slightly Higher Priority SetFocus(hWnd); // Sets Keyboard Focus To The Window ReSizeGLScene(width, height); // Set Up Our Perspective GL Screen if (!InitGL()) // Initialize Our Newly Created GL Window { KillGLWindow(); // Reset The Display MessageBox(NULL,"Initialization Failed.","ERROR",MB_OK|MB_ICONEXCLAMATION); return FALSE; // Return FALSE } return TRUE; // Success } LRESULT CALLBACK WndProc( HWND hWnd, // Handle For This Window UINT uMsg, // Message For This Window WPARAM wParam, // Additional Message Information LPARAM lParam) // Additional Message Information { switch (uMsg) // Check For Windows Messages { case WM_ACTIVATE: // Watch For Window Activate Message { if (!HIWORD(wParam)) // Check Minimization State { active=TRUE; // Program Is Active } else { active=FALSE; // Program Is No Longer Active } return 0; // Return To The Message Loop } case WM_SYSCOMMAND: // Intercept System Commands { switch (wParam) // Check System Calls { case SC_SCREENSAVE: // Screensaver Trying To Start? case SC_MONITORPOWER: // Monitor Trying To Enter Powersave? return 0; // Prevent From Happening } break; // Exit } case WM_CLOSE: // Did We Receive A Close Message? { PostQuitMessage(0); // Send A Quit Message return 0; // Jump Back } case WM_KEYDOWN: // Is A Key Being Held Down? { keys[wParam] = TRUE; // If So, Mark It As TRUE return 0; // Jump Back } case WM_KEYUP: // Has A Key Been Released? { keys[wParam] = FALSE; // If So, Mark It As FALSE return 0; // Jump Back } case WM_SIZE: // Resize The OpenGL Window { ReSizeGLScene(LOWORD(lParam),HIWORD(lParam)); // LoWord=Width, HiWord=Height return 0; // Jump Back } } // Pass All Unhandled Messages To DefWindowProc return DefWindowProc(hWnd,uMsg,wParam,lParam); } int WINAPI WinMain( HINSTANCE hInstance, // Instance HINSTANCE hPrevInstance, // Previous Instance LPSTR lpCmdLine, // Command Line Parameters int nCmdShow) // Window Show State { MSG msg; // Windows Message Structure BOOL done=FALSE; // Bool Variable To Exit Loop // Ask The User Which Screen Mode They Prefer if (MessageBox(NULL,"Would You Like To Run In Fullscreen Mode?", "Start FullScreen?",MB_YESNO|MB_ICONQUESTION)==IDNO) { fullscreen=FALSE; // Windowed Mode } // Create Our OpenGL Window if (!CreateGLWindow("NeHe's OpenGL Framework",640,480,16,fullscreen)) { return 0; // Quit If Window Was Not Created } while(!done) // Loop That Runs While done=FALSE { if (PeekMessage(&msg,NULL,0,0,PM_REMOVE)) // Is There A Message Waiting? { if (msg.message==WM_QUIT) // Have We Received A Quit Message? { done=TRUE; // If So done=TRUE } else // If Not, Deal With Window Messages { TranslateMessage(&msg); // Translate The Message DispatchMessage(&msg); // Dispatch The Message } } else // If There Are No Messages { // Draw The Scene. Watch For ESC Key And Quit Messages From DrawGLScene() if (active) // Program Active? { if (keys[VK_ESCAPE]) // Was ESC Pressed? { done=TRUE; // ESC Signalled A Quit } else // Not Time To Quit, Update Screen { DrawGLScene(); // Draw The Scene SwapBuffers(hDC); // Swap Buffers (Double Buffering) } } if (keys[VK_F1]) // Is F1 Being Pressed? { keys[VK_F1]=FALSE; // If So Make Key FALSE KillGLWindow(); // Kill Our Current Window fullscreen=!fullscreen; // Toggle Fullscreen / Windowed Mode // Recreate Our OpenGL Window if (!CreateGLWindow("NeHe's OpenGL Framework",640,480,16,fullscreen)) { return 0; // Quit If Window Was Not Created } } } } // Shutdown KillGLWindow(); // Kill The Window return (msg.wParam); // Exit The Program }

3 12

preloader: Setup a fake thread-local storage block pointed to by %gs. breaks RH9
by Robert Reif Nov. 4, 2006

Nov. 4, 2006

This last commit: http://www.winehq.org/pipermail/wine-cvs/2006-November/027508.html totally breaks wine on Red Hat 9. Red Hat 9 has been partially broken since 2.4 kernel support has been dropped a while back but this patch makes it totally unusable. It is unfortunate that 2.4 kernel support has been removed from wine because in "The Real World" (large enterprise and dedicated or embedded systems) users don't have the option of upgrading the OS to the latest and greatest. Some systems will never be upgraded once deployed. Dropping 2.4 support is a regression.

2 1

Re: wined3d: Respect ARB_VERTEX_BUFFER_OBJECT in loadVertexData.
by Markus Amsler Nov. 4, 2006

Nov. 4, 2006

Stefan Dösinger wrote: > Am Samstag 28 Oktober 2006 16:44 schrieben Sie: > >> Its a Radeon Mobility M7 LW, with direct rendering. It has a RV200 core >> which is a R100 with the memory controller from R200. And it looks like >> the R100 doesn't support vertex_buffer_objects (couldn't find precise >> specs). >> > How well does bf1942 work without vertex buffers? My experiance with my M9 is > that it got a 100% performance boost with vbos. > It's playable (~10-15fps), perhaps 1/3-1/5 of w2k performance. > That were rather the vertex fixups, not the vbos themselves. I think you can > get most of that gain by improving the vertex buffer code to be able to do > vertex fixups without VBOs > Thanks for the tip. I will have a look at it.

2 2

Re: WineD3D: Scissor rect corrections
by Alexandre Julliard Nov. 4, 2006

Nov. 4, 2006

Stefan Dösinger <stefan(a)codeweavers.com> writes: > + GetWindowRect(((IWineD3DSwapChainImpl *)This->swapchains[0])->win_handle, &windowRect); > + /* Warning: glScissor uses window coordinates, not viewport coordinates, so our viewport correction does not apply > + * Warning2: Even in windowed mode the coords are relative to the window, not the screen > + */ Wouldn't GetClientRect be more appropriate? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: secur32: [4/3]Test and fix DecryptMessage for multiple data buffers.
by Dmitry Timoshkov Nov. 4, 2006

Nov. 4, 2006

"Kai Blin" <kai.blin(a)gmail.com> wrote: > --- a/dlls/secur32/ntlm.c > +++ b/dlls/secur32/ntlm.c > @@ -1345,22 +1345,32 @@ static SECURITY_STATUS SEC_ENTRY ntlm_Ve > if(helper->neg_flags & NTLMSSP_NEGOTIATE_SIGN) > { > SecBufferDesc local_desc; > - SecBuffer local_buff[2]; > + SecBuffer local_buff[pMessage->cBuffers]; This construct is not portable, you need to use HeapAlloc to dynamically allocate buffers. -- Dmitry.

1 0

Please commit my lostwages patch
by Scott Ritchie Nov. 3, 2006

Nov. 3, 2006

Hey, I'm not sure who is responsible for it, but could someone please get my lostwages patch committed today? I've been getting a bunch of emails about Ubuntu Edgy because the website hasn't been updated yet. Thanks, Scott Ritchie

1 0

Tracking memory allocation
by Jeff L Nov. 3, 2006

Nov. 3, 2006

I am looking at how to track whether memory has been allocated or freed. The SCRIPT_STRING_ANALYSIS opaque point in usp10 can be freed in a number of places. It seems that Windows handles this by checking a list of allocated storage as the passed value of a SCRIPT_STRING_ANALYSIS could be invalid. An obvious problem is where SCRIPT_STRING_ANALYSIS pointer is passed or copied to another pointer. At best one pointer could be NULLed but not both. I have seen this behaviour. It seems that this would not be a unique problem in wine, is there a standard way to handle memory tracking so that if memory is freed, at a later time we can check to see if the pointer is still valid? Jeff Latimer

2 7

oleaut32: fix regression at MSFT typelib parsing
by a_villacis＠palosanto.com Nov. 3, 2006

Nov. 3, 2006

Finally, I managed to figure out the proper fix for the crash on regsvr32 msvbvm60.dll (and probably some other DLLs too). It turns out that the field from which TLBFuncDesc->Entry is filled is supposed to indicate the function entry point that implements the function described in the typelib. The roper interpretation of the entry is right there as a comment: BSTR Entry; /* if its Hiword==0, it numeric; -1 is not present*/ What this means is that if TLBFuncDesc->Entry has a high word of 0, it is supposed to be a DLL function ordinal. Otherwise, it is an offset of the function name (for lookup-by-name in the DLL). When this field was directly copied from the binary block (and the block kept around, with a memory leak), everything worked as expected. However, the patch to allocate space for the function name in the Entry-as-funcname case broke the Entry-as-ordinal case, since the ordinal value is not a proper pointer, and therefore it is incorrect to use it as such (like calling SysAllocString on it). This patch fixes the regression by copying the ordinal value when indicated by the FKCCIC flag, and checking the HIWORD before trying to free the allocated string in the Entry-as-funcname case. BTW, could any of you please comment on the previous patch for removing the use of CreateCompatibleDC in the implementation of GetDIBits() ? I sent it a few days ago, but it seems to have been ignored (no commit, no critique on why it is being rejected). Otherwise I will send it again in the assumption that it slipped through the cracks somewhere. Changelog: * Fix regression on MSFT typelib parsing of function records by allocating a string copy only when indicated by FKCCIC flag, and preserving the meaning of value as function ordinal otherwise. Alex Villacís Lasso

2 2

Re: missing locale resources
by Kirill K. Smirnov Nov. 3, 2006

Nov. 3, 2006

> If you are adding multiple strings then the easiest is to start a new > block. Otherwise if it's a single string, or it logically belongs to > an existing block, then yes you have to add it everywhere if you want > a fallback. Thanks for solution!

1 0

Re: Missing locale resources
by Kirill K. Smirnov Nov. 3, 2006

Nov. 3, 2006

> Strings are stored by blocks of 16, so if others strings in the same > block are defined for Russian the resource loader won't fall back to > English even if individual strings are missing. So, what is the right way to add new string? 1) Add to every resource Bg,Cs,Da etc... untranslated to be sure that string will be loaded. 2) Add to En and Ru only. Then check return value of LoadString and if zero do LoadStringEx(...LANG_ENGLISH/SUBLANG_NEUTRAL) 3) other way? Thanks in advance -- Kirill K. Smirnov

3 2

winex11.drv: Bug#6501. XIM problem with XInitThreads().
by Byeong-Sik Jeon Nov. 3, 2006

Nov. 3, 2006

http://www.winehq.org/pipermail/wine-cvs/2006-October/026680.html > winex11.drv: Give XInitThreads another chance. > > --- > > dlls/winex11.drv/x11drv_main.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c > index 0403b5d..95f9d10 100644 > --- a/dlls/winex11.drv/x11drv_main.c > +++ b/dlls/winex11.drv/x11drv_main.c > @@ -383,6 +383,8 @@ static BOOL process_attach(void) > > /* Open display */ > > + if (!XInitThreads()) ERR( "XInitThreads failed, trouble ahead\n" ); > + > if (!(display = XOpenDisplay( NULL ))) return FALSE; > Hi, This patch makes the Bug #6501. Also Korean XIM(nabi, scim) have the same problem. Please fix this problem.

3 3

Missing locale resources
by Kirill K. Smirnov Nov. 3, 2006

Nov. 3, 2006

Hi! I want to add a new string resource to winhelp program. I've modified only English-localized .rc file. My locale is Ru. When I trying to load this string, LoadString() function returns 0 and GetLastError() returns 0 too. I expect English string to be loaded, but no string is loaded. When I explicitly set locale LC_ALL=C winhelp then string is loaded OK (nothing else expected). So, the question: is this behaviour of resource loader correct? Should it fallback to LANG_ENGLISH SUBLANG_DEFAULT if localized string not found and LANG_NEUTRAL/SUBLANG_NEUTRAL is requested (as LoadString does)? Thanks in advance -- Kirill K. Smirnov

2 1