November 2006 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

Updated version of Wine-0.9.18 RPMs with ntoskrnl for SuSE 10.1
by Vitaliy Margolen Feb. 19, 2007

Feb. 19, 2007

Same as before. Just recompiled with new version. http://www.kievinfo.com/wine-0.9.18-1.2.i586.rpm http://www.kievinfo.com/wine-0.9.18-1.2.src.rpm -- Best regards, Vitaliy

3 3

Font issue - workaround found
by Timm Feb. 18, 2007

Feb. 18, 2007

My one win app that makes me a devotee of WINE is TablEdit (demo at www.tabledit.com/download/tabled32.exe) has a custom font , tef260.ttf, that has failed to display since somewhere after ver 9.6. The program installs the font into c:\windows\font, but can not display it within the program, instead displaying for the most part, empty squares. I tried putting/removing tef260.ttf into /usr/local/share/wine/fonts, /usr/local/share/fonts, and the wine windows/fonts directories in all permutations. The only way I got it to display was to remove ALL fonts from these three directories and install tef260.ttf into an X11 font directory along with other win ttf fonts. This forces WINE to build a cachedmetrics file like it used to, and the font is displayed properly in the program. Hope this is a clue for some developer, as I merely lurk here, looking for clues about wine behavior. I can't do a regression back to ver 9.6 (the version I was using that last worked) because my upgrades to freetype cause it to complain of missing functions. current (pertinent ? ) specs libfreetype.so.6.3.7 ] built from source libfontconfig.so.1.0.4 ] built from source fontforge 20060715 ] built from source WINE 0.9.20 ] built from source kernel 2.6.17.11 Slack current (10.2, with upgrades from "current" tree) -- Timm

3 2

windows web server app fails to send more than 11680 bytes !?
by [IDC]Dragon Dec. 30, 2006

Dec. 30, 2006

Hello, I'm testing a windows app I'd very much like to run under Wine (using v0.9.22), being in touch with the author. This is a small web server app based on a Microsoft MFC sample app. It happily works under Windows, but that'd be the wrong thing for running it 24/7. ;-) It's not yet working under Wine, fails to serve larger files, but we've pretty much narrowed down the problem by adding logs to the app and using ethereal. For example, the app tries to write 25017 bytes to the socket, but the socket only allows 11680 bytes at a time, and the TCP stack fragments this in 8 packets of 1460 bytes, presumably because it only has 8 buffers reserved. So far so good. We see them being sent on the Ethernet and the ACK's are coming in, but after these 8 packets there should be a signal to trigger the OnSend function of the app so it can send the next part of data, but this never happens... The reselection of the socket did not return an error. Given the reselection is ok, and at the Ethernet level messages are consistently sent and ACK's received, the conclusion is that there might be a bug in Wine. So here we are stuck. Given that Wine successfully runs real big application such as MS Internet Explorer, I can't imagine it to have such a fundamental problem. Is there something I overlooked, like a configuration issue? If it really gets interesting, I can ask the developer for a more detailed report, including the Ethereal log snippet, in case somebody wants to actually look into it. First I'd like to find out if this is the right place, or if I should "bury" it into bugzilla. Thank you for your time and help, Jörg -- GMX DSL-Flatrate 0,- Euro* - Überall, wo DSL verfügbar ist! NEU: Jetzt bis zu 16.000 kBit/s! http://www.gmx.net/de/go/dsl

5 9

A wine success story
by Dan Kegel Dec. 18, 2006

Dec. 18, 2006

I admit, I cruise new blog posts just to see what people are writing about Wine. Today I saw one ( http://www.ubuntux.org/shockwave-player-ubuntu-linux ) that says "I have discovered a way to get Shockwave working under Linux. I am using Ubuntu 6.06 (Dapper Drake), Wine 0.99.22, Firefox 1.5.0.7, and Shockwave 10.1.4.020. 1. Install Wine. ... Wine will automatically associate .exe files with itself. More information on Wine is available at http://www.winehq.com . 2. Download the Windows version of Firefox and install. Wine will ensure the installer functions correctly. 3. Install the Windows version of Shockwave for Mozilla. I downloaded and installed it manually (slim install). After these steps, I had a working Shockwave player from within Firefox. " Now that's the kind of user story I like to see! - Dan

7 8

Call to all packagers (especially Debian)
by Vitaliy Margolen Dec. 16, 2006

Dec. 16, 2006

It seems there is no end to how far will packagers go to brake Wine by trying to make it better I thought it's been fixed a long time ago, but it seems not. Wine packages for Debian split important Wine parts into separate packages: - wine - fonts, few not essential programs, symlinks and _premade_ content of ~/.wine directory (with ~/.wine/c as default c: drive)!!! - libwine - all the builtin dlls - wine-utils:(explorer, winecfg, winepath, cmd.exe, iexplore, winedbg) and many other packages. Also as default it's using "winelauncher" instead of standard "wine" binary. That makes it that much more complicated to troubleshoot any problems that users might have. So in case anyone having problems with Debian or Debian based distro, please check that all the "*wine*" packages installed. Also is there a way we can request packagers to follow some standard to how they package Wine? Can we ask packagers to package all parts of Wine into one single package? If they prefer, they can package optional sound drivers separately (arts, esd, jack, nas). Same for documentation, and development headers. However everything else is essential to Wine and most programs that ran under it. Also can packagers keep default method of starting Wine the same without using any additional scripts for starting Wine? And of course, if any alterations has been made, state so in the distro specific readme file. Of course I realize that this is open source and anyone can do whatever they pleased. But please, that's make it more supportable. It's such a huge PITA to waste several hours trying to find the reason why something doesn't work to realize that person doesn't have explorer. Needless to say that lots of things won't work right. Vitaliy.

6 6

Re: oleaut32: use setlocale() around sprintfW to force use of period as decimal separator (RESEND)
by Alexandre Julliard Dec. 14, 2006

Dec. 14, 2006

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > @@ -4159,7 +4161,9 @@ > { > WCHAR buff[256]; > > + setlocale(LC_ALL, "C"); > sprintfW( buff, szFloatFormatW, fltIn ); > + setlocale(LC_ALL, ""); > return VarDecFromStr(buff, LOCALE_EN_US, 0, pDecOut); You can't do that, setlocale() affects the whole process. In any case we shouldn't need to go through a string to convert a float to a decimal. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: OpenAL32.dll thunk and OpenAL winmm driver
by Stefan Dösinger Dec. 11, 2006

Dec. 11, 2006

Am Sonntag 26 November 2006 00:25 schrieb Nick Burns: > dlls/openal32/openal.c: main thunk file > dlls/openal32/Makefile.in: simple thunk makefile > dlls/openal32/openal32.spec: openal+alut spec file > dlls/winmm/wineopenal/audio.c: main winmm driver file > dlls/winmm/wineopenal/Makefile.in: simple winmm makefile > dlls/winmm/wineopenal/openal.c: simple interface > dlls/winmm/wineopenal/openal.h: simple header for simple interface > dlls/winmm/wineopenal/wineopenal.drv.spec: winmm spec file I think you should send the thunk and winmm driver in 2 seperate patches

11 18

Re: [winetest] Make sure we can send larger files
by Dimi Paun Dec. 5, 2006

Dec. 5, 2006

On Thu, November 30, 2006 1:01 pm, Paul Vriens wrote: > I'm hitting the 1MB limit already with my win98 tests. Most other tests > are about to reach that threshold as well. I'd make it 2MB, what's 1MB these days... :) -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 2

Re: make check_no_exec() work reliable
by Peter Beutner Dec. 4, 2006

Dec. 4, 2006

Peter Beutner wrote: > Before starting to make this whole noexecute override behaviour configurable, > it first must work reliable. In its current form there is no guarantee that > the check_no_exec() function is actually called, because any other installed > exception handler might decide to handle the exception itself. > And as seen by the number of failing applications, this seems to happen > quite a lot. > This patch therefore makes check_no_exec() to be called before any other > exception handler. > > --- Any comments what is wrong with this one?

2 7

Call for DirectPlay captures
by Kai Blin Dec. 4, 2006

Dec. 4, 2006

Hi folks, As you might know, I'm currently toying with figuring out the MS DirectPlay protocol. I've been making some progress with my wireshark dissector over the weekend, and would be interested in some additional games to get more different data on some of this stuff. Here's what I would like you to do (if you want to help out): Fire up a network sniffer that dumps to libpcap format. Grab TCP and UDP packets. Start a game that uses DirectPlay for networking and start a network game. Start the game on another box and connect to the game. Now, in the game lobby, use the chat to say something from both games. Then, change a setting or two and start the game. After a few moments of playing (or more, your pick), leave the game. After both games are closed, you can stop the capture, zip it up and send it to me. Thanks in advance, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

4 6

One more go at fixing GetCursorPos()
by Vitaliy Margolen Dec. 3, 2006

Dec. 3, 2006

Here is one more shot at fixing GetCursorPos() to make it usable in dinput. This time I used a refcount of sorts. Because the problem appears only during processing of hook chain. Just to remind about what is the problem: when hook handler calls GetCursorPos() position returned is the "old" position. While hook parameters contain "new" coordinates. This is on windows. On Wine returned position queried directly from X and might be even "newer" then position in hook parameters. Attached are two tests (out of lots more that I've used to find and fix the problem). test_msg.c - tests major problem that Alexandre pointed out about last fix attempt. Application in question does not process messages while calling GetCursorPos(). It still works properly with proposed patch. di_mouse_2th.c - 2 threads showing that there are no extra thread local position involved (if there is such a thing). Cached cursor position is global to all threads. (Last numbers should stay at dt(0 0) at all times). Inside hook handler d(x y) should show relative mouse move delta. If anyone has any objections, comment, suggestions, please do send them. Vitaliy Margolen. #define COBJMACROS #define _WIN32_WINNT 0x0501 #include <windows.h> #include <windowsx.h> #include <stdio.h> static HANDLE event1, event2; static HINSTANCE g_hInstance; static POINT pt_global; LRESULT CALLBACK hook_proc( int code, WPARAM wparam, LPARAM lparam ) { MSLLHOOKSTRUCT *hook = (MSLLHOOKSTRUCT *)lparam; POINT pt; GetCursorPos(&pt); if (code == HC_ACTION) { fprintf(stderr, "Hook: code=%d w=%x [(%ld %ld) %lx %lx %lx] cur(%ld %ld) d(%ld %ld) ", code, wparam, hook->pt.x, hook->pt.y, hook->mouseData, hook->flags, hook->dwExtraInfo, pt.x, pt.y, hook->pt.x - pt.x, hook->pt.y - pt.y); pt_global = pt; SetEvent(event1); WaitForSingleObject(event2, INFINITE); } return CallNextHookEx( 0, code, wparam, lparam ); } static DWORD CALLBACK thread_proc(LPVOID arg) { while (WaitForSingleObject(event1, INFINITE) == WAIT_OBJECT_0) { POINT pt; GetCursorPos(&pt); fprintf(stderr, "Th: (%ld %ld) dt(%ld %ld)\n", pt.x, pt.y, pt.x - pt_global.x, pt.y - pt_global.y); SetEvent(event2); } return 0; } static DWORD wnd_proc(void) { MSG msg; while (GetMessage(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessage(&msg); } return msg.wParam; } #define SEND(x,y) \ i.mi.time = GetCurrentTime(); \ i.mi.dx = x; i.mi.dy = y; \ SendInput(1, &i, sizeof(INPUT)); void send_input(void) { INPUT i; POINT ptorg, pt; GetCursorPos(&ptorg); fprintf(stderr, "Cur pos: %ld %ld\n", ptorg.x, ptorg.y); i.type = INPUT_MOUSE; i.mi.dwFlags = MOUSEEVENTF_MOVE; i.mi.dwExtraInfo = 0; i.mi.mouseData = 0; SEND(-4, -4) GetCursorPos(&pt); fprintf(stderr, "%ld %ld\n", pt.x, pt.y); SetCursorPos(ptorg.x, ptorg.y); Sleep(250); fprintf(stderr, "***DONE***\n"); } void test1(HWND hwnd) { HANDLE thread; HHOOK hook; MSG msg; event1 = CreateEvent(NULL, FALSE, FALSE, NULL); event2 = CreateEvent(NULL, FALSE, FALSE, NULL); thread = CreateThread(NULL, 0, thread_proc, NULL, 0, NULL); Sleep(250); hook = SetWindowsHookExA(WH_MOUSE_LL, hook_proc, g_hInstance, 0); Sleep(250); // send_input(); wnd_proc(); while (PeekMessage( &msg, 0, 0, 0, PM_REMOVE )) DispatchMessage( &msg ); UnhookWindowsHookEx(hook); CloseHandle(event1); CloseHandle(event2); CloseHandle(thread); Sleep(250); } LRESULT CALLBACK WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) { switch (message) { case WM_DESTROY: PostQuitMessage(0); return 0; } return DefWindowProc(hWnd, message, wParam, lParam); } int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { WNDCLASSEX wcex; HWND hwnd; g_hInstance = hInstance; wcex.cbSize = sizeof(WNDCLASSEX); wcex.style = CS_HREDRAW | CS_VREDRAW; wcex.lpfnWndProc = (WNDPROC)WndProc; wcex.cbClsExtra = 0; wcex.cbWndExtra = 0; wcex.hInstance = hInstance; wcex.hIcon = NULL; wcex.hCursor = LoadCursor(NULL, IDC_ARROW); wcex.hbrBackground = (HBRUSH)(COLOR_WINDOW+1); wcex.lpszMenuName = NULL; wcex.lpszClassName = "MainWindow"; wcex.hIconSm = NULL; RegisterClassEx(&wcex); hwnd = CreateWindow("MainWindow", "Title", WS_OVERLAPPEDWINDOW, 10, 10, 200, 200, NULL, NULL, NULL, NULL); ShowWindow(hwnd, SW_SHOW); test1(hwnd); DestroyWindow(hwnd); return 0; } #include <windows.h> #include <stdio.h> int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { LONG started = GetTickCount(); POINT pt, pt_org; HWND hwnd; MSG msg; hwnd = CreateWindow("static", "Title", WS_OVERLAPPEDWINDOW | WS_VISIBLE, 10, 10, 200, 200, NULL, NULL, NULL, NULL); GetCursorPos(&pt_org); while (PeekMessage( &msg, 0, 0, 0, PM_REMOVE )) DispatchMessage( &msg ); while (started + 10000 > GetTickCount()) { GetCursorPos(&pt); if ((pt.x - pt_org.x) || (pt.y - pt_org.y)) printf("(%ld %ld)\n", pt.x - pt_org.x, pt.y - pt_org.y); pt_org = pt; } DestroyWindow(hwnd); return 0; }

2 2

Re: user32: Factorize graphics driver's WindowCreate and ShowWindow in user32.
by Dmitry Timoshkov Dec. 1, 2006

Dec. 1, 2006

"Pierre d'Herbemont" <pdherbemont(a)free.fr> wrote: > At the same time ShowWindow gets factorized because WindowCreate and > ShowWindow share both the use of WINPOS_MinMaximize, so it is easier to > factorize both functions in a single patch. In fact ShowWindow is > removed entirely from the drivers as it is driver independant. > > To properly factorize WindowCreate we have to export 3 new functions > from the graphics driver which are SetIconicState, SyncWindowStyle, > SystrayDockWindow. I'd suggest to leave ShowWindow in the driver's interface. You already have created 3 new entry points to replace its partial functionality, but still miss ShowWindow functionality for at least SW_RESTORE and SW_MAXIMIZE. Also did you run 'make test' after this patch? -- Dmitry.

2 3

How to embed wine into swt?
by Cloudor Pu Dec. 1, 2006

Dec. 1, 2006

Hi, all I am developing an swt app only for gtk. I want to embed IE into this app. I can create a SWT.EMBEDDED composite and get its embededHandle (an integer). Then, how to do next? Thanks in advace! regards, cloudor

3 3

Re: msi: Add handling for the StartServices action [try2]
by Robert Shearman Nov. 30, 2006

Nov. 30, 2006

James Hawkins wrote: > + scm = OpenSCManagerW(NULL, NULL, SC_MANAGER_ALL_ACCESS); This can be just SC_MANAGER_CONNECT instead. -- Rob Shearman

1 0

Re: msi: Add handling for the StartServices action
by Alexandre Julliard Nov. 30, 2006

Nov. 30, 2006

"James Hawkins" <truiken(a)gmail.com> writes: > + p = args; > + do > + { > + if ((q = strstrW(p, separator))) *q = '\0'; > + > + (*numargs)++; > + vector = msi_realloc(vector, *numargs * sizeof(LPWSTR)); > + vector[*numargs - 1] = p; > + } while (q); This won't work for more than one arg. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemenubuilder: Look for supported color depths icons only. [resend]
by Frank Richter Nov. 30, 2006

Nov. 30, 2006

On 30.11.2006 01:54, Vitaliy Margolen wrote: > Remove all the code simplification. This patch fixes icon extraction for > most steam games. All HL2 based games have .ico file with 32-bit colors. > Since we don't support those, Or write the icons as PNGs. -f.r.

2 4

Re: [AppDB] Allow maintainer request on app submission
by Chris Morgan Nov. 29, 2006

Nov. 29, 2006

On Wednesday 29 November 2006 1:58 pm, Alexander Nicolaysen Sørnes wrote: > New and improved version. > > > Regards, > > Alexander N. Sørnes Looks a lot better. + // Allow user to apply as super maintainer if this is a new app + if(!$this->iAppId or $this->iAppId == "/") + { + if($this->bSuperMaintainerRequest) Why are you comparing the iAppId against a string containing a forward slash? + /* Approve automatically if submitted by an admin */ + if($_SESSION['current']->AppCreatedMustBeQueued()) + $this->sQueued = 'true'; + else + $this->sQueued = 'false'; + We probably want to make a new interface function here like MaintainerCreatedMustBeQueued() so we don't overload the meaning of this function. Today we aren't very particular about user roles but adding user roles is something we should do and keeping these privilages finely grained is useful. Also, the unit tests don't pass after this change. I suspect something related to the queueing changes: test_user_update_password() starting test_user_update_password() passed test_maintainer_getMaintainerCountForUser() starting test_maintainer_getMaintainerCountForUser() passed test_maintainer_getAppsMaintained() starting aAppsMaintained is null, we expected a non-null return value!<------------- test_maintainer_getAppsMaintained() failed! test_query_parameters() starting test_query_parameters() passed You can run these by going into the appdb/unit_test/ directory and executing ./run_tests from the command line. Make sure you don't have sendmail configured or you may end up sending emails around. We should really disable emailing at the start of the unit tests... Chris

1 0

Re: [AppDB] Allow maintainer request along with app submission
by Chris Morgan Nov. 29, 2006

Nov. 29, 2006

On Wednesday 29 November 2006 10:08 am, Alexander Nicolaysen Sørnes wrote: > Allow the user to submit a maintainer request along with an application, by > ticking a checkbox. > If the application is accepted, the maintainer request is accepted as well; > and if it is deleted or marked as a duplicate, the request is deleted. > These maintainer requests are not displayed in the queue. > > Also, maintainer requests submitted by an administrator are now > automatically approved. > > > Regards, > > Alexander N. Sørnes + if($hResultMaint) + { + $oMaintainer = mysql_fetch_row($hResultMaint); + $oMaintainer = new Maintainer($oMaintainer[0]); + } We don't want to overload the $oMaintainer variable here. Also, we want to use the name of the field you are accessing and not the index so we aren't asking ourselves what $oMaintainer[0] means. Also you'll want to check that mysql_fetch_row() actually returns a row prior to creating a new maintainer based upon it. This logic isn't quite right: + /* Reject super maintainer request if app is deleted or a duplicate */ + if(($aClean['sSub'] == "Reject" || $aClean['sSub'] == "Delete") && $hResultMaint) + { + $oMaintainter->reject("Deleting super maintainer request along with application entry."); + } + Rejecting an application doesn't mean deleting it so we don't want to delete or reject the maintainer request right there. Users can modify and resubmit applications after they have been rejected. The application class already handles the case where an application is deleted by calling Maintainer::deleteMaintainersForApplication() from Application::Delete(). In application.php: + if(makesafe($_REQUEST['bSmaintainerRequest'])) We should make the variable explicit, bSuperMaintainerRequest makes the purpose of this variable more clear. It's probably better to add a new variable to the class that we document as being used during application creation. That way we can modify Application::GetOutputEditorValues() to retrieve the value from the $aValues array passed in. This avoids having to makesafe() a $_REQUEST value, something that we really don't want to do anymore because eventually I think we'll want to clear out all non-standard entries in $_REQUEST as an additional protection against attacks from poorly checked input. The text here in the queries is too specific: "AND queued = '?' AND maintainReason != 'This user submitted the application; auto-queued.' ORDER by submitTime"; The query will fail if the text changes and we should assume it will. We need to do something like: select count(*) as queued_maintainers from appMaintainers, appFamily where appFamily.queued = 'true' and appMaintainers.queued = 'true' and appMaintainers.appId = appFamily.appId and appMaintainers.iSubmitterId != appMaintainers.iUserId; We also need to add a comment to getQueuedMaintainerCount() and to the sql to note that we are excluding queued maintainers that have applications queued as we will automatically submit them when the application is submitted. Chris

1 0

Re: mlang: Make user32 a delay load import
by Alexandre Julliard Nov. 29, 2006

Nov. 29, 2006

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > the only import from user32 which mlang uses is wsprintfW, and it's only used > by the DllRegisterServer code, so it's reasonable to move user32 to delay load > imports. As long as mlang imports ole32 which imports user32, there is nothing to gain by not importing user32 directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d [1]: Remove AddRef from IWineD3DDevice_GetVertexDeclaration.
by H. Verbeet Nov. 29, 2006

Nov. 29, 2006

On 28/11/06, Markus Amsler <markus.amsler(a)oribi.org> wrote: > The following patches remove refcounting in wined3d Getters. The > Setters/Creaters refcounting can't be removed right now, because of the > way implicit surfaces are currently handled. > > The idea is to simplify the d3dx<->wined3d refcount relation. Ideally > every wined3d object gets created with refcount=1, never AddRef'ed and > destroyed with the first Release call. Rob mentioned this violates COM > rules, but wined3d is wine internal. > > The GetParent patch doesn't remove wined3d refcounting, it seperates > d3dx and wined3d refcounting (Which was the reason I started to remove > AddRefs). > --- I think this is a bad idea, if only for consistency with other COM objects. I don't think wined3d being wine internal is a very good reason to violate COM rules. IMO if we're going to use COM we should stick to its rules. Also see my other mail.

4 10

Mozilla Sunbird install - Mystery bug #6613
by Mike McCormack Nov. 29, 2006

Nov. 29, 2006

Anybody have time to help triage an install problem? Sunbird (and FireFox 2) installs run in an endless loop for some people. If you have time to try the install out and see if it works on your system, then comment on bug 6613, it would help out. http://bugs.winehq.org/show_bug.cgi?id=6613 I'm interested in which distro you're using, which filesystem, free disk space, locale, timezone, CPU (64bit or 32 bit?), etc. Mike

2 1

Re: ws2_32: Implement SO_GET_MAX_MSG_SIZE for getsockopt.
by Dmitry Timoshkov Nov. 28, 2006

Nov. 28, 2006

"Kai Blin" <kai.blin(a)gmail.com> wrote: > +static void test_extendedSocketOptions() > +{ > + WSADATA wsa; > + SOCKET sock; > + struct sockaddr_in sa; > + int sa_len = sizeof(struct sockaddr_in); > + ULONG optval, optlen = sizeof(ULONG); Why to use ULONG if what you later cast it to is 'int *', and according to the docs (and your implementation) SO_MAX_MSG_SIZE expects sizeof(int) for the optval? ... > + if(bind(sock, (struct sockaddr *) &sa, (int)sa_len) < 0){ There is not need for a cast, sa_len has the type 'int'. > + trace("Failed to bind socket: 0x%08x\n", WSAGetLastError()); > + closesocket(sock); > + WSACleanup(); > + exit(1); This kills the whole process instead of terminating gracefully just this particular test. > + } > + > + ret = getsockopt(sock, SOL_SOCKET, SO_MAX_MSG_SIZE, (char *)&optval, (int *)&optlen); -- Dmitry.

2 1

Re: d3d [8]: Remove AddRef from IWineD3D*_QueryInterface. This also removes the implicit AddRef in IWineD3D*_GetContainer.
by H. Verbeet Nov. 28, 2006

Nov. 28, 2006

I thought we discussed on IRC why this is a bad idea? Anyway, you can't do this. Removing the AddRef in QueryInterface is a pretty blatant violation of COM specs, and is pretty sure to cause problems somewhere. The caller of that function won't always know if the object it's called on is a wined3d object or not, and will depend on the behaviour of QueryInterface as defined by COM. Another thing is that know we get a situation where wined3d objects behave differently from all other COM objects. Also, if, as you stated earlier, the idea of these patches is *not* to get rid of COM in wined3d, I think they're a bad idea. Because in that case all it will do is make wined3d violate COM rules.

3 3

Re: [2/8] wined3d: Select the right shader backend when creating the device
by Ivan Gyurdiev Nov. 28, 2006

Nov. 28, 2006

H. Verbeet wrote: > Changelog: > - Select the right shader backend when creating the device Imho there should be either ps_selected/vs_selected flags, or shader_backend flag, but definitely not both [ does not make sense ]. I'd opt for allowing different backends on pshader vs vshader. Maybe the current drawprim code is implemented to use ARB or GLSL for both, but that's not a good reason to disallow capability by writing future code as if the backend was unified. More importantly, you should be able to mix software shaders, with the other backends. I'm also not sure replacing all if statements with a function table is a good idea - restructuring code is dangerous, better not to do it unless new features are being added, or the code is being rewritten, or it's completely unmaintainable (I think that's a bit hard to argue).

3 9

Re: Vitaliy Margolen : wineshelllink: Use FreeDesktop standard to create Wine menu structure.
by Marcus Meissner Nov. 28, 2006

Nov. 28, 2006

On Mon, Nov 27, 2006 at 12:51:03PM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: da3676229722eb76c8a91bf8165b09cc9e58455c > URL: http://source.winehq.org/git/wine.git/?a=commit;h=da3676229722eb76c8a91bf81… > > Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> > Date: Fri Nov 24 13:53:29 2006 -0700 > > wineshelllink: Use FreeDesktop standard to create Wine menu structure. Umm. This means we (distributor) need to supply xdg utils also for all old distros, right? Ciao, Marcus

1 0

Re: ddraw/device.c: Fixed Thunk_IDirect3DDeviceImpl_1_AddViewport
by Stefan Dösinger Nov. 28, 2006

Nov. 28, 2006

Am Montag 27 November 2006 11:23 schrieb Christoph Bumiller: > This is my first "patch" - I was trying an old game with wine > (Starfleet Academy), which crashed when using D3D, and I got the > following trace messages: > > trace:ddraw_thunk:Thunk_IDirect3DDeviceImpl_1_AddViewport > (0x1b440c)->(0x1f44f0) thunking to IDirect3DDevice3 interface. > trace:ddraw_thunk:Thunk_IDirect3DDeviceImpl_2_GetStats > (0x1b4408)->(0x1f44f0) thunking to IDirect3DDevice3 interface. > fixme:d3d7:IDirect3DDeviceImpl_3_GetStats (0x1b4408)->(0x1f44f0): Stub! > > This looks like Thunk_IDirect3DDeviceImpl_1_AddViewport called the > GetStats thunk > which called GetStats with the viewport as argument, where it set some > fields to > 0, which resulted in a segfault in IDirect3DViewportImpl_SetBackground > because IDirect3DViewportImpl->ddraw was NULL. Good catch, yeah, your patch is correct. I blamed native d3drm.dll of calling GetStats with a viewport, but it turns out that it was my fault in the end :-)

1 0

Re: riched20: Make ME_StreamIn create undos properly
by Matt Finnicum Nov. 28, 2006

Nov. 28, 2006

I retract my claim of fixing that bug, but the patch still fixes the test / crashes / has great merit otherwise. --Matt On 11/27/06, Matt Finnicum <mattfinn(a)gmail.com> wrote: > This fixes an occasional crash/assertion in richedit that has been > around for a while. It also fixes a conformance test. I also believe > it fixed bug 6005 but I'll wait for the submitter to check it since I > found testing it confusing. > > Changelog: > Make ME_StreamIn create undos properly > --- > dlls/riched20/editor.c | 20 ++++++++++---------- > dlls/riched20/tests/editor.c | 2 -- > 2 files changed, 10 insertions(+), 12 deletions(-) > > >

1 0

Re: [Module] winex11.drv A new function.
by Dmitry Timoshkov Nov. 28, 2006

Nov. 28, 2006

"Anatoly" <vostok(a)etersoft.ru> wrote: > +static struct codepair { > +unsigned short keysym; > + unsigned short ucs; > +} keysymtab[] = { Nothing prevents to make the keysymtab[] a const data. -- Dmitry.

1 0

Re: [winex11.drv/keyboard.c] Fix
by Dmitry Timoshkov Nov. 28, 2006

Nov. 28, 2006

"Anatoly" <vostok(a)etersoft.ru> wrote: > --- x11drv.h 8 Nov 2006 20:14:19 -0000 1.10 > +++ x11drv.h 24 Nov 2006 09:38:39 -0000 > @@ -19,6 +19,8 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > +#include <config.h> You can't do that, a comment 2 lines further in that file explains what you need to do instead. -- Dmitry.

1 0

Re: mscoree [1/2]: Add missing stubs to the spec file
by Paul Chitescu Nov. 28, 2006

Nov. 28, 2006

On Wed, 11 Oct 2006, James Hawkins wrote: > Hi, > > Changelog: > * Add missing stubs to the spec file. > > dlls/mscoree/mscoree.spec | 125 +++++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 120 insertions(+), 5 deletions(-) Interesting - what mscoree version are those ordinals from? I got mines from XP Home SP2. Paul Chitescu

3 8

Re: msxml3: Implement createProcessingInstruction with a stub PI object.
by Lei Zhang Nov. 28, 2006

Nov. 28, 2006

domdoc.c:domdoc_createProcessingInstruction() uses xmlNewDocPI() from libxml2. This feature was added in libxml2 version 2.6.15. (released about 2 years ago) Anyone using an older distro with an outdated libxml2 (e.x. RHEL 3) will not be able to compile this code. On 11/16/06, Huw Davies <huw(a)codeweavers.com> wrote: > --- > dlls/msxml3/Makefile.in | 1 > dlls/msxml3/domdoc.c | 19 +- > dlls/msxml3/msxml_private.h | 1 > dlls/msxml3/pi.c | 544 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 563 insertions(+), 2 deletions(-) > > > > > >

1 1

Re: [3/8] wined3d: Create a separate function for sampling a texture
by Ivan Gyurdiev Nov. 27, 2006

Nov. 27, 2006

H. Verbeet wrote: > There are a couple of instructions that have to sample from a texture, > right now most of them duplicate that code, and hardcode the texture > type. > > Changelog: > - Create a separate function for sampling a texture You should continue to use "add_param" or "get_register_name". There should be a single point in the code where register names are constructed, adding another one is a bad idea. This function is specifically tasked with naming registers, and taking into account things like relative addressing, so that when samplers support relative addressing in the future, changing the naming scheme would be trivial.

2 3

Re: [4/8] wined3d: Fix the texm3x3tex instruction to sample properly
by Mirek Nov. 27, 2006

Nov. 27, 2006

Wow, I am impressed those patches fixed almost all tests in 3DMark 2003, test4 (mother nature), vertex shader and Ragtroll without any regression in other apps. Perfect work! Mirek H. Verbeet napsal(a): > The current code for texm3x3tex doesn't handle projected textures, and > actually uses the wrong argument to determine the sampler type. This > patch fixes the turtle in the 4th game test in 3DMark03. > > Changelog: > - Fix the texm3x3tex instruction to sample properly > > > ------------------------------------------------------------------------ > > --- > > dlls/wined3d/arb_program_shader.c | 6 ++++-- > dlls/wined3d/glsl_shader.c | 23 ++++++----------------- > 2 files changed, 10 insertions(+), 19 deletions(-) > > diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c > index 9f2be9b..7c73fd4 100644 > --- a/dlls/wined3d/arb_program_shader.c > +++ b/dlls/wined3d/arb_program_shader.c > @@ -781,13 +781,15 @@ void pshader_hw_texm3x3tex(SHADER_OPCODE > DWORD reg = arg->dst & WINED3DSP_REGNUM_MASK; > SHADER_BUFFER* buffer = arg->buffer; > SHADER_PARSE_STATE* current_state = &This->baseShader.parse_state; > + char dst_str[8]; > char src0_name[50]; > > pshader_gen_input_modifier_line(buffer, arg->src[0], 0, src0_name); > shader_addline(buffer, "DP3 TMP.z, T%u, %s;\n", reg, src0_name); > > - /* Cubemap textures will be more used than 3D ones. */ > - shader_addline(buffer, "TEX T%u, TMP, texture[%u], CUBE;\n", reg, reg); > + /* Sample the texture using the calculated coordinates */ > + sprintf(dst_str, "T%u", reg); > + shader_hw_sample(arg, reg, dst_str, "TMP"); > current_state->current_row = 0; > } > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 6be71bb..39ad693 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -1560,33 +1560,22 @@ void pshader_glsl_texm3x2tex(SHADER_OPCO > } > > /** Process the WINED3DSIO_TEXM3X3TEX instruction in GLSL > - * Perform the 3rd row of a 3x3 matrix multiply, then sample the texture using the calculate coordinates */ > + * Perform the 3rd row of a 3x3 matrix multiply, then sample the texture using the calculated coordinates */ > void pshader_glsl_texm3x3tex(SHADER_OPCODE_ARG* arg) { > - > + char dst_str[8]; > char src0_str[100]; > char src0_name[50]; > char src0_mask[6]; > - char dimensions[5]; > DWORD reg = arg->dst & WINED3DSP_REGNUM_MASK; > - DWORD src0_regnum = arg->src[0] & WINED3DSP_REGNUM_MASK; > - DWORD stype = arg->reg_maps->samplers[src0_regnum] & WINED3DSP_TEXTURETYPE_MASK; > IWineD3DPixelShaderImpl* This = (IWineD3DPixelShaderImpl*) arg->shader; > SHADER_PARSE_STATE* current_state = &This->baseShader.parse_state; > - > - switch (stype) { > - case WINED3DSTT_2D: strcpy(dimensions, "2D"); break; > - case WINED3DSTT_CUBE: strcpy(dimensions, "Cube"); break; > - case WINED3DSTT_VOLUME: strcpy(dimensions, "3D"); break; > - default: > - strcpy(dimensions, ""); > - FIXME("Unrecognized sampler type: %#x\n", stype); > - break; > - } > > shader_glsl_add_param(arg, arg->src[0], arg->src_addr[0], TRUE, src0_name, src0_mask, src0_str); > shader_addline(arg->buffer, "tmp0.z = dot(vec3(T%u), vec3(%s));\n", reg, src0_str); > - shader_addline(arg->buffer, "T%u = texture%s(Psampler%u, tmp0.%s);\n", > - reg, dimensions, reg, (stype == WINED3DSTT_2D) ? "xy" : "xyz"); > + > + /* Sample the texture using the calculated coordinates */ > + sprintf(dst_str, "T%u", reg); > + shader_glsl_sample(arg, reg, dst_str, "tmp0"); > current_state->current_row = 0; > } > > > > ------------------------------------------------------------------------ > >

1 0

WineD3D state management
by Stefan Dösinger Nov. 27, 2006

Nov. 27, 2006

Hi, In the past days I've been hacking on implementing my state management ideas, and I think I've come to a state where I don't have to be completely ashamed of my patches :-) First, what the code does NOT do yet: * Pixel Shaders, GLSL shaders: I only had my notebook with the M9 available, so I had no chance to implement them. Expect anything from broken graphics to the sudden release of Duke Nukem Forever if you try to use them. * Stateblocks * Register combiners: Disabled right now * Offscreen rendering: Causes random rendering garbage * 2D Blits: Commented out I have described the basic ideas in earlier mails(http://www.winehq.org/pipermail/wine-devel/2006-October/051868.html), so I don't describe them here again. I pretty much followed the original plan. Performance: One of the aims was to get better performance, since we apparently lost performance due to exessive state changes which eat CPU time and may require CPU-GPU syncs. My patches improve performance, but not as much as I originally hoped. I mainly have performance figures on the M9, and some basic testing on a gf7600. * Billboard dx8 sdk demo: got from 56fps to 107 fps :-) * Half-Life 1: Quite an improvement here too. 110->150 fps in one of my timedemos. The d3d renderer now outperforms the opengl renderer(140 fps). Both the billboard demo and hl1 hit a special rendering case(no stream source or fvf changes), this is nicely optimized by my changes. The gl renderer in hl1 uses immediate mode drawing while wined3d can use VBOs and array drawing, thus beeing faster on today's cards. * Battlefield 1942: Slight improvement too, 32->37 fps on my testing scene(spawn point on a u.s. carrier(a)full graphics). BF1942 exceeded the usual linux/windows driver performance ratio already before, so I assume I'm pretty much at the limit of my M9 here. * 3DMark2000: Unfortunately my driver crashes it before showing the scores, so I can only watch the in-test counter. Seems to get +5 to +10 fps in the low detail helicopter test(resolution independent). Native msvcrt.dll gets another +5 fps. I did only a short testing on my geforce7600: * 3dmark2000: gets 11500 3dmarks, with forcing drawStridedFast 14500. This is I believe the windows performance. However, the benchmark is too old to be meaningful. Before my state patches drawStridedFast scroe was around 13500 if I remember correctly, have to retest. * 3dmark2001: Low detail tests run at 150-300 fps, too fast for a meaningful result. high detail tests are slow and partially broken due to offscreen rendering. * Battlefield 1942: Runs at steady 100fps, but it did that already before So it seems that the state patches improve one bottleneck, but we have still many others(offscreen rendering, drawStridedSlow) left. The nvidia profiling driver may help here. Where to go from here: The state management was also planned to make implementing other features easier: * Multithreading: Make the dirty states list per context, and the helpers stored in the device too. Before applying the states activate the correct ctx for the thread. * Stateblocks: Basic idea is to record a display list and call it: glNewList(stateblock->listname, GL_COMPILE); for(i = 1; i <= STATE_HIGHEST; i++) { States[i].func(i, stateblock); } glEndList(); To apply the stateblock: glCallList(stateblock->listname); Ok, we need to split the list to apply only partial states, and the for loop can be improved to create a more efficient list. When the stateblock is altered we have to recreate the list. Thats the basic idea... * Offscreen rendering: Depends on wether we need seperate contexts for pbuffers. If yes, include it with the multithreading ctx finding, then apply the states, otherwise I think we can make selecting the pbuffer/fbo a state like all others. Has interactions with the viewport(I think) and the projection matrix(render_offscreen for upside down rendering) * sRGB textures: Dirtifies the sampler. All textures have now information about how many samplers they are bound to, and the number of one of the samplers. Phil? * Vertex samplers: Ivan said he'd need the state management for them. My idea is to build a d3d sampler - gl sampler mapping in SetTexture, which will be needed for register combiners too. Based on that we can bind vtf samplers in gl. I have no clean patches right now(45 chaotic patches), so I decided to share my wined3d directory. However, this is even compressed a bit big for a mailing list, so I uploaded it to http://stud4.tuwien.ac.at/~e0526822/wined3d-statemgmt.tar.bz2 Stefan

4 9

[wiki] multi language FrontPage
by Karsten Elfenbein Nov. 27, 2006

Nov. 27, 2006

Hi, could a wiki admin please delete StartSeite on the wiki. According to http://wiki.winehq.org/HelpOnLanguages the wiki would use the english FrontPage if StartSeite doesn't exist. The german FrontPage isn't needed as the users don't get any information about wine there. Karsten

1 0

re: wineshelllink: Use FreeDesktop standard to create Wine menu structure.
by Dan Kegel Nov. 27, 2006

Nov. 27, 2006

Vitaly wrote: > [xdg-utils] can not handle files with spaces in them. If that's true, it's a bug, and should be fixed. > Also they don't allow installing icons without specifying size. ? http://portland.freedesktop.org/xdg-utils-1.0/xdg-desktop-icon.html doesn't seem to talk about sizes at all. > [We can't just check the scripts into the wine source tree > and require their installation.] Why not? If they save effort and work well, let's do it. - Dan

7 6

Re: WineD3D state management
by Stefan Dösinger Nov. 27, 2006

Nov. 27, 2006

Am Montag 27 November 2006 13:36 schrieben Sie: > Here is log from 3DMark 2005, some new games are not working with those > patches, 3DMark 2001 works but very bad in high details tests. 05 fails because of pixel shaders / glsl, and I know that 2001 is broken because my patch doesn't care for offscreen rendering yet. The mail was mainly to show what the code looks like, rather than doing extensive testing. Its time for testing once pshaders, glsl and offscreen rendering are in. Sorry - Should have mentioned that in my original mail

3 4

Re: sfd2ttf - modify buglist entry
by theun.wine.mail＠planet.nl Nov. 27, 2006

Nov. 27, 2006

----- Oorspronkelijk bericht ----- Van: Markus Amsler <markus.amsler(a)oribi.org> Datum: zaterdag, november 25, 2006 11:05 pm Onderwerp: Re: sfd2ttf > theun.wine.mail(a)planet.nl wrote: > > Hi, > > > >>From the buglist I gather that the fontforge dependency is still > an issue. > > > > I've taken a look at the sources and I think a can strip it down to > > about 5 to 10 pages of code without a major rewrite. > > > > If this is acceptable, I'd be happy to spend my time. > > > > Are you sure? > > The problem is TTF generation. There's no library and it's not > trivial. > With 5 to 10 pages its impossible to generate a valid, non-empty > TTF file. > > I tried it once with dropping all unnecesary features (Apple > Advanced > Typography, Codpages, ...) and managed to get it down to 500 KB. > Without > Code obfuscation or comment dropping my guessed minimum was around > 350 > KB which would be around 150-200 pages of code. And we agreed > that's too > much, so I stopped my efforts. > You can download my latest version from [1]. There was also a > sfd2ttf > thread some time ago. > > So sfd2ttf is not feasible, and AJ wonn't commit TTF files so I > think we > could resolve this bug as WONTFIX. > > Markus > > [1] http://oribi.org/download/sfd2ttf.tar.gz > > Obviously, you've already put quite a bit of effort in sfd2ttf and the result is there. Since it also clear that the sfd2ttf entry in the buglist in far from up to date, I think it's a good idea to modify the entry to reflect the current status. Hopefully, this will prevent other potential contributers from wasting their time. Thanks, Theun van der Veen.

1 0

Yet another Wine success story: the CD-ROM in today's LA Times runs ok
by Dan Kegel Nov. 27, 2006

Nov. 27, 2006

The Sunday Los Angeles Times had a CD-ROM insert today (a promo from Vonage about upcoming Hollywood films, go figure). With some trepidation, I tried it out with Wine... and it worked flawlessly (OK, maybe there was one audio stutter). It was a Flash 8 executable, and played very smoothly on my beefy Athlon laptop. Congratulations again to Team Wine... - Dan

1 0

Re: [AppDB] (resend) Add basic rating logic checking
by Chris Morgan Nov. 26, 2006

Nov. 26, 2006

On Sunday 26 November 2006 12:49 pm, Alexander Nicolaysen Sørnes wrote: > Add basic rating logic checking, by asking the user to correct the error if > > - Installs? = No and the rating is Platinum > - Runs? is not 'yes' and rating is not Garbage > > > Regards, > > Alexander N. Sørnes When the erorr occurs is the users data retained so they can correct the error and continue without re-entering it? Chris

1 0

Re: [6/6] Add a partial COFF library support to the winedump
by Eric Pouech Nov. 26, 2006

Nov. 26, 2006

Dmitry Timoshkov a écrit : > Hello, > > this implementation is able to parse imports libraries from the PSDK > and hopefully should help interested parties to check/synchronize ordinal > imports between Wine and Windows. > > The dumper is not able (yet) to parse import libraries with the long format > described in Portable Executable and Common Object File Format Specification > and uuid.lib. > > I think it's a bad idea to "force" the kind of file on the command line for dumping I'd rather see winedump guess the file format based on the file header, as we do for .exe, .dll, .mdmp, .pdb, .dbg... we didn't do it for emf and lnk because it seems they don't have a simple header to find it out, but .lib files definitively have you should also provide support for the -C option (symbol demangling) BTW, I have a couple of patches for debug files dumping (.pdb, .dbg...), that should help the dumping of debug information from a coff file (when needed) A+

2 3

sfd2ttf
by theun.wine.mail＠planet.nl Nov. 25, 2006

Nov. 25, 2006

Hi, >From the buglist I gather that the fontforge dependency is still an issue. I've taken a look at the sources and I think a can strip it down to about 5 to 10 pages of code without a major rewrite. If this is acceptable, I'd be happy to spend my time. Theun van der Veen

2 1

Re: wineshelllink: Use FreeDesktop standard to create Wine menu structure.
by Vitaliy Margolen Nov. 25, 2006

Nov. 25, 2006

Jeremy White wrote: > I would strongly recommend that this be done instead with > xdg-utils: > > http://portland.freedesktop.org/wiki/XdgUtils Sure, but they can not handle files with spaces in them. Also they don't work as-is with Wine's winemenubuilder. Which will require at least one more wrapper script. Also they don't allow installing icons without specifying size. And all in all it will be 4 large scripts instead of 1 small. > That will allow us to avoid the pain of maintaining our own > implementation, and allow distro vendors to make their distro > work with Wine just by supplying a working version of xdg-utils. It's been discussed multiple times here. And last time I remember agreement was not to introduce any additional dependencies. I have also checked, and not a single distro had those installed. I do not want to depend on something that's no one has, and no way to distribute it to users either. > The trick is whether or not we can persuade Alexandre and/or all > of the Wine packagers to include xdg-utils by default in distributions. That's not his call but packagers. And the problem will remain the same. Vitaliy.

2 1

Extending the testframe to cope with different windows versions
by Paul Vriens Nov. 25, 2006

Nov. 25, 2006

Hi, after my last patch to yet 'remove' another test I had another look at tests.winehq.org. With the arrival of IE7 and of course a lot of changes to dll's (not even mentioning Vista) it looks like Windows versions are starting to behave not even close to similar. How can we deal with these differences? Several tests we have already include checks against a lot of possible return values or errorcodes. It's a shame when we have to stop running a test because it fails on 1 or more versions of Windows. If the end-result is that we start excluding more-and-more tests, then we should start doubting the usefulness of the regression tests. Any ideas ? Cheers, Paul.

4 5

Re: winex11.drv: Cast-qual warning fix + remove superfluous HeapFree()
by Paul Vriens Nov. 25, 2006

Nov. 25, 2006

On Sat, 2006-11-25 at 12:41 +0000, Andrew Talbot wrote: > Changelog: > winex11.drv: Cast-qual warning fix + remove superfluous HeapFree(). > > diff -urN a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c > --- a/dlls/winex11.drv/clipboard.c 2006-10-09 20:06:04.000000000 +0100 > +++ b/dlls/winex11.drv/clipboard.c 2006-11-25 12:37:27.000000000 +0000 > @@ -511,7 +511,8 @@ > { > LPWINE_CLIPFORMAT lpFormat; > LPWINE_CLIPFORMAT lpNewFormat; > - > + LPWSTR new_name; > + > /* allocate storage for new format entry */ > lpNewFormat = HeapAlloc(GetProcessHeap(), 0, sizeof(WINE_CLIPFORMAT)); > > @@ -521,14 +522,13 @@ > return NULL; > } > > - if (!(lpNewFormat->Name = HeapAlloc(GetProcessHeap(), 0, (strlenW(FormatName)+1)*sizeof(WCHAR)))) > + if (!(new_name = HeapAlloc(GetProcessHeap(), 0, (strlenW(FormatName)+1)*sizeof(WCHAR)))) > { > WARN("No more memory for the new format name!\n"); > - HeapFree(GetProcessHeap(), 0, lpNewFormat); > return NULL; > } > > - strcpyW((LPWSTR)lpNewFormat->Name, FormatName); > + lpNewFormat->Name = strcpyW(new_name, FormatName); > lpNewFormat->wFlags = 0; > lpNewFormat->wFormatID = GlobalAddAtomW(lpNewFormat->Name); > lpNewFormat->drvData = prop; > > Just out of curiosity. Why is the HeapFree superfluous? It is allocated a few lines above and not free-ed in this fail condition. Cheers, Paul.

2 3

Re: wineshelllink: Use FreeDesktop standard to create Wine menu structure.
by Jeremy White Nov. 24, 2006

Nov. 24, 2006

I would strongly recommend that this be done instead with xdg-utils: http://portland.freedesktop.org/wiki/XdgUtils That will allow us to avoid the pain of maintaining our own implementation, and allow distro vendors to make their distro work with Wine just by supplying a working version of xdg-utils. The trick is whether or not we can persuade Alexandre and/or all of the Wine packagers to include xdg-utils by default in distributions. Cheers, Jeremy Vitaliy Margolen wrote: > Change Log: > wineshelllink: Use FreeDesktop standard to create Wine menu structure. > > The major changes include: > - Use WM independent paths for all generated files. > - Dynamically build .menu and .directory files to create menu structure. > - Store icons in local icon store using their "cryptic" names to avoid conflicts. > - Number of other changes required for compatibility. > Note: .desktop links are still stored in a directory structure representing > Start Menu. This is done for possible future expansion. > > This new approach should work with KDE, Gnome and other XDG compliant managers. > I have verified this with recent versions of KDE and Gnome on several distros. > > However there are might be some problems with some custom changes some distros > might have. As an example SuSE has special feature that doesn't work right: > https://bugzilla.novell.com/show_bug.cgi?id=188110 > > The question of removing these links after programs have been uninstalled still open. > There are number of possible ways to solve it. The simplest would be symlinking > directories containing .desktop files. However that might brake whole menu structure. > --- > tools/wineshelllink | 258 ++++++++++++++++++++++---------------------------- > 1 files changed, 114 insertions(+), 144 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/tools/wineshelllink b/tools/wineshelllink > index db65efa..5d91afc 100755 > --- a/tools/wineshelllink > +++ b/tools/wineshelllink > @@ -4,6 +4,7 @@ > # This is used by the IShellLink interface > # > # Copyright 2000 Alexandre Julliard > +# Copyright 2006 Vitaliy Margolen > # > # This library is free software; you can redistribute it and/or > # modify it under the terms of the GNU Lesser General Public > @@ -22,8 +23,7 @@ > > # Note that the link is a relative unix-style path name. Since the / character > # is not valid in Windows filenames it is an adequate separator to show the > -# menu structure. (This program may need to split the menu structure out for > -# implementing xdg-style menus) > +# menu structure. > > mode="" > args="" > @@ -82,176 +82,146 @@ if [ -z "$link" ] ; then > usage > fi > > -kde_entry() > +desktop_entry() > { > - xname=`basename "$link"` > - cat <<EOF > -# KDE Config File > -[KDE Desktop Entry] > -Name=$xname > -Exec=wine '$path' $args > -Type=Application > -Comment=$descr > -EOF > - [ -z "$workdir" ] || echo "Path=\"$workdir\"" > - [ -z "$xpmicon" ] || echo "Icon=$xpmicon" > -} > - > -gnome_entry() > -{ > - xname=`basename "$link"` > cat <<EOF > [Desktop Entry] > -Name=$xname > +Name=$linkname > Exec=wine "$path" $args > Type=Application > -Comment=$descr > EOF > + [ -z "$descr" ] || echo "Comment=$descr" > [ -z "$workdir" ] || echo "Path=$workdir" > [ -z "$xpmicon" ] || echo "Icon=$xpmicon" > } > > -mdk_entry() > +directory_entry() > { > - base=`basename "$link"` > - section=`dirname "$link"` > - [ -z "$icon" ] || xicon="icon=\"$xpmicon\"" > - pathmenu=`echo "$path" | sed 's+\\\\+\\\\\\\\+g'` > - echo "?package(local.Wine):needs=x11 section=\"/Wine/$section\" title=\"$base\" longtitle=\"$descr\" command=\"wine '$pathmenu' $args\" $xicon" > + cat <<EOF > +[Desktop Entry] > +Type=Directory > +EOF > + if [ "$1" == "wine" ] ; then > + echo "Name=Wine" > + echo "Icon=wine" > + else > + echo "Name=$1" > + echo "Icon=folder" > + fi > } > > # copy the icon file to a specified dir and set xpmicon to the resulting path > copy_icon() > { > - dir="$1" > - mkdir -p "$dir" > - mkdir -p "$dir/""`dirname "$link"`" || true > - if [ -f "$icon" ] > - then > - cp "$icon" "$dir/$link.xpm" > - xpmicon="$dir/$link.xpm" > - else > - xpmicon="" > - fi > + if [ -f "$icon" ] > + then > + xpmicon=`basename "$icon" .xpm` > + > + mkdir -p "$1" > + cp "$icon" "$1/$xpmicon.xpm" > + else > + xpmicon="" > + fi > } > > -# Debian/Mandrake > - > -type update-menus > /dev/null 2>&1 > -if [ $? = 0 -a $mode = "menu" ] > -then > - iconname="`basename "$link"`.xpm" > - dir="$HOME/.menu/icons" > - if [ -f "$icon" ] > - then > - mkdir -p "$dir" > - cp "$icon" "$dir/$iconname" > - xpmicon="$dir/$iconname" > - else > - xpmicon="" > - fi > - mdk_entry >> "$HOME/.menu/wine" > - if [ -d "/usr/lib/menu" ] && [ -w "/usr/lib/menu" ] > - then > - mdk_entry >> "/usr/lib/menu/wine" > - fi > - update-menus > /dev/null 2>&1 > -fi > +# XDG > > -# KDE > +xdg_config_dir="$XDG_CONFIG_HOME" > +[ -n "$xdg_user_dir" ] || xdg_config_dir="$HOME/.config" > +xdg_config_dir="$xdg_config_dir/menus/applications-merged" > > -if [ -d "$HOME/.kde" ] > -then > - kdeversion=0 > - if type kde-config >/dev/null 2>&1 > - then > - kdeversion=`kde-config -v | grep KDE: | sed -n "s/^KDE: $[^.]*$\..*$/\1/p"` > - fi > +xdg_data_dir="$XDG_DATA_HOME" > +[ -n "$xdg_data_dir" ] || xdg_data_dir="$HOME/.local/share" > > - if [ $kdeversion -ge 2 ] > - then > - copy_icon "$HOME/.kde/share/applnk/Wine" > - if [ $mode = "menu" ] > - then > - gnome_entry > "$HOME/.kde/share/applnk/Wine/$link.desktop" > - elif [ -d "$HOME/Desktop" ] > - then > - gnome_entry > "$HOME/Desktop/$link.desktop" > +# Create common directories > +mkdir -p "$xdg_config_dir" > +mkdir -p "$xdg_data_dir/desktop-directories" > + > +get_menu_entries() > +{ > + tmp="$xdg_config_dir/$1.menu" > + > + if [ -r "$tmp" ] ; then > + awk ' > +BEGIN { RS="<" } > +/^Filename/ { > + if (match($0,/>/)) { > + print substr($0,RSTART+1) > + } > +}' $tmp > fi > - else > - copy_icon "$HOME/.kde/share/applnk/Wine" > - if [ $mode = "menu" ] > - then > - kde_entry > "$HOME/.kde/share/applnk/Wine/$link.kdelnk" > +} > > - # KDE 1.x kludge. Wake up KDE, if we can find kpanel running > - type kwmcom >/dev/null 2>/dev/null && \ > - ps u -C kpanel >/dev/null 2>/dev/null && \ > - kwmcom kpanel:restart > +# Input > +# menu file name > +# new item > +write_menu_file() > +{ > + tmpfile=`mktemp` > + ( > + echo '<!DOCTYPE Menu PUBLIC "-//freedesktop//DTD Menu 1.0//EN"' > + echo '"http://www.freedesktop.org/standards/menu-spec/menu-1.0.dtd">' > + echo '<Menu>' > + echo ' <Name>Applications</Name>' > + > + IFS="-" > + > + fullname='wine' > + for i in $1; do > + echo " <Menu>" > + echo " <Name>$fullname-$i</Name>" > + echo " <Directory>$fullname-$i.directory</Directory>" > + > + dir_file_name="$xdg_data_dir/desktop-directories/$fullname-$i.directory" > + if [ ! -f "$dir_file_name" ] ; then > + directory_entry "$i" > "$dir_file_name" > + fi > + test "$i" = "wine" || fullname="$fullname-$i" > + done > + > + echo " <Include>" > + > + IFS=" > +" > + for i in $(get_menu_entries "$1"); do > + test "$i" = "$2" && continue > + echo " <Filename>$i</Filename>" > + done > + > + # New record > + echo " <Filename>$2</Filename>" > + echo " </Include>" > + > + IFS='-' > + for i in $1; do > + echo " </Menu>" > + done > + echo '</Menu>' > + ) > $tmpfile > + chmod 0600 $tmpfile > + > + mv -f $tmpfile "$xdg_config_dir/$1.menu" > +} > > - elif [ -d "$HOME/Desktop" ] > - then > - kde_entry > "$HOME/Desktop/$link.kdelnk" > - # KDE 1.x kludge: wake up KDE, if we can find kfm running... > - type kfmclient >/dev/null 2>/dev/null && \ > - ps u -C kfm >/dev/null 2>/dev/null && \ > - kfmclient refreshDesktop > - fi > - fi > -fi > > -if [ -d "$HOME/.kde2" ] > -then > - copy_icon "$HOME/.kde2/share/applnk/Wine" > - if [ $mode = "menu" ] > - then > - gnome_entry > "$HOME/.kde2/share/applnk/Wine/$link.desktop" > - else > - if [ -d "$HOME/Desktop2" ] > - then > - gnome_entry > "$HOME/Desktop2/$link.desktop" > - fi > - if [ -d "$HOME/Desktop" ] > - then > - gnome_entry > "$HOME/Desktop/$link.desktop" > - fi > - fi > -fi > +copy_icon "$xdg_data_dir/icons" > > -if [ -d "$HOME/.kde3/share/applnk" ] > -then > - copy_icon "$HOME/.kde3/share/applnk/Wine" > - if [ $mode = "menu" ] > - then > - gnome_entry > "$HOME/.kde3/share/applnk/Wine/$link.desktop" > - else > - if [ -d "$HOME/Desktop3" ] > - then > - gnome_entry > "$HOME/Desktop3/$link.desktop" > - fi > - if [ -d "$HOME/Desktop2" ] > - then > - gnome_entry > "$HOME/Desktop2/$link.desktop" > - fi > - if [ -d "$HOME/Desktop" ] > - then > - gnome_entry > "$HOME/Desktop/$link.desktop" > +linkname=`basename "$link"` > + > +if [ $mode = "menu" ] ; then > + mkdir -p "$xdg_data_dir/applications/wine/`dirname "$link"`" > + > + linkpath=`dirname "$link" | sed 's!/!-!g'` > + if [ "$linkpath" == "." ] ; then > + linkpath="" > + else > + linkpath="-$linkpath" > fi > - fi > -fi > > -# Gnome > - > -if [ -d "$HOME/.gnome" ] > -then > - copy_icon "$HOME/.gnome/apps/Wine" > - if [ $mode = "menu" ] > - then > - gnome_entry > "$HOME/.gnome/apps/Wine/$link.desktop" > - elif [ -d "$HOME/.gnome-desktop" ] > - then > - gnome_entry > "$HOME/.gnome-desktop/$link.desktop" > - fi > + desktop_entry > "$xdg_data_dir/applications/wine/$link.desktop" > + write_menu_file "wine$linkpath" "wine$linkpath-$linkname.desktop" > +else > + desktop_entry > "$HOME/Desktop/$linkname.desktop" > fi > > exit 0 > > > > ------------------------------------------------------------------------ > >

2 1

WM_SETFONT support
by Jing Li Nov. 24, 2006

Nov. 24, 2006

Hi, I am building a dialog box which is used to display the license agreement information. I create my dialog template with the dialog editor. The dialog box contains the "Microsoft Rich Textbox Control" (ActiveX control). When the function DialogBox() is called to display the dialog box, the command "WM_SETFONT" is sent to my dialog procedure and the dialog box does not pop up at all. Do you know how to deal with this problem? The only information I've got from MSDN is "The dialog box procedure is responsible for saving the font handle passed with the WM_SETFONT message and selecting the handle into the display device context whenever it writes text to the window." Thanks a lot for your response and help. Regards, Jing

2 1