December 2006 - Wine-Devel - list.winehq.org

Re: winex11.drv: Only try to initialize OpenGL if the display has the GLX extension.
by Roderick Colenbrander Dec. 24, 2006

Dec. 24, 2006

Hi, I'm not sure if checking for the GLX extension is such a good idea as it is possible to use OpenGL without having the GLX extension. For instance when plain Mesa is used. Regards, Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

3 5

Re: [Winmm/winealsa] Don't use asynchronous callbacks in dsound any more
by Tomas Carnecky Dec. 24, 2006

Dec. 24, 2006

Maarten Lankhorst wrote: > Instead of using asynchronous callbacks that uses signals, use a > seperate thread that can be cancelled, this prevents deadlock issues. > > Basically we use snd_pcm_wait() that tells us when enough room is free > to commit another buffer, then we commit the previous buffer and make > the next buffer ready. > > Since snd_pcm_wait() uses poll(), we don't have signals in winealsa any > more. > Correct me if I'm wrong, but doesn't your code create and destroy the thread in ::Play() and ::Stop()? It would be better to destroy it together with the DirectSoundBuffer object (whether you create the thread when the object is created or the first time ::Play() is called is not so important, but I've been told the CreateFrame() overhead is big so that we should try to minimize its use). but I would suggect to create teh thread when the DSB object is created, as the CreateThread() in ::Play() may have side-effects (delay in the sound etc). tom

1 0

Re: [SPAM] [Winmm/winealsa] Don't use asynchronous callbacks in dsound any more
by a_villacis＠palosanto.com Dec. 24, 2006

Dec. 24, 2006

> Instead of using asynchronous callbacks that uses signals, use a > seperate thread that can be cancelled, this prevents deadlock issues. > > Basically we use snd_pcm_wait() that tells us when enough room is free > to commit another buffer, then we commit the previous buffer and make > the next buffer ready. > > Since snd_pcm_wait() uses poll(), we don't have signals in winealsa any > more. > > This patch causes a hang in the interactive dsound tests: bash$ cd wine-0.9.28-cvs-patch/dlls/dsound/tests bash$ WINETEST_INTERACTIVE=1 wine dsound_test.exe.so dsound ... fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. ds3d.c:655: Test failed: The sound played for 835 ms instead of 1000 ms dsound.c:602: Testing a primary buffer at 48000x8x1 with a secondary buffer at 11025x16x2 ds3d.c:447: Playing 1 second 440Hz tone at 11025x16x2 fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. ds3d.c:655: Test failed: The sound played for 371 ms instead of 1000 ms dsound.c:602: Testing a primary buffer at 48000x8x2 with a secondary buffer at 11025x16x2 ds3d.c:447: Playing 1 second 440Hz tone at 11025x16x2 fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. ds3d.c:655: Test failed: The sound played for 834 ms instead of 1000 ms dsound.c:602: Testing a primary buffer at 48000x16x1 with a secondary buffer at 11025x16x2 ds3d.c:447: Playing 1 second 440Hz tone at 11025x16x2 fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. ds3d.c:655: Test failed: The sound played for 767 ms instead of 1000 ms dsound.c:602: Testing a primary buffer at 48000x16x2 with a secondary buffer at 11025x16x2 ds3d.c:447: Playing 1 second 440Hz tone at 11025x16x2 fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. dsound.c:602: Testing a primary buffer at 96000x8x1 with a secondary buffer at 11025x16x2 ds3d.c:447: Playing 1 second 440Hz tone at 11025x16x2 fixme:wave:DBSB_MMAPStart Can't access sound driver's buffer directly. (then silent hang) kernel 2.6.19 wine 0.9.28 Fedora Core 5, snd_via82xx module

1 0

Re: user32: fix return value in DialogBoxParamA if no resource can befound + simple test
by Dmitry Timoshkov Dec. 24, 2006

Dec. 24, 2006

Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > --- a/dlls/user32/dialog.c > +++ b/dlls/user32/dialog.c > @@ -800,7 +800,12 @@ INT_PTR WINAPI DialogBoxParamA( HINSTANC > HRSRC hrsrc; > LPCDLGTEMPLATEA ptr; > > - if (!(hrsrc = FindResourceA( hInst, name, (LPSTR)RT_DIALOG ))) return 0; > + if (!(hrsrc = FindResourceA( hInst, name, (LPSTR)RT_DIALOG ))) > + { > + SetLastError(ERROR_RESOURCE_NAME_NOT_FOUND); > + ERR("FindResource %s failed, returning -1\n",debugstr_a(name)); > + return -1; > + } Most likely the last error should be set by FindResource itself, not a more high level DialogBoxParam call. If that's not the case it should be fixed there. -- Dmitry.

1 0

re: fonts:add "framework" for tahoma font
by Dan Kegel Dec. 24, 2006

Dec. 24, 2006

Louis wrote: > [Here's a start at a tahoma-compatible font. Works with Steam...] Does it fix http://bugs.winehq.org/show_bug.cgi?id=4449 ? - Dan

3 3

comctl monthcalendar help
by Vijay Kiran Kamuju Dec. 23, 2006

Dec. 23, 2006

Hi, I am trying to fix visual bug in comctl monthcalendar control. When I am using the control spy v2.0 for comctl5.0, I can see that current date is highled with grey background on windows xp. (similar to when we click a day in the calendar) But on wine its not happening. I am trying to find out, how we draw that highlighting. And also how we draw the default calendar. Thanks, VJ

2 2

Re: d3d8: Don't report Shader Model 2.0 or higher
by H. Verbeet Dec. 23, 2006

Dec. 23, 2006

On 23/12/06, Chris Robinson <chris.kcat(a)gmail.com> wrote: > D3D8 never reports anything above SM 1.x. Does this fix something?

2 1

WineLib porting project for small Windows application
by Eric Rhodes Dec. 22, 2006

Dec. 22, 2006

Hi Wine developers, My name is Eric Rhodes and I work for Schmap, Inc. (www.schmap.com) I'm posting this message to find out if any of you would be interested in working with us on a Mac "porting" project for a small Windows application (using Wine). A full project description is set forth below. Please feel free to contact me directly at 919-246-0186 (or via email at <mailto:eric.rhodes(a)schmap.com>eric.rhodes(a)schmap.com) if you are interested in this project, or if you would like to refer someone else that might be. Thanks and happy holidays, Eric Rhodes ++++++++++++++++++++++++++++++++ Our Company Schmap is a media and technology company with a focus on developing client and server based consumer mapping solutions with a geospatial twist - see www.schmap.com. The Project We are seeking a senior engineer with strong C++ (preferably MS C++) to assist us with a self-contained WineLib porting project, working alongside two engineers who helped develop the Windows application to be ported. Mac programming experience is desired but not absolutely necessary. Specific Responsibilities Initial consultation and project setup; project planning (liasing with the CTO to develop a plan for the port); general code porting (outside of the consultancy role, you'll also be expected to get your hands dirty with some coding once the port gets underway); reporting on progress to the CTO. Duration Initial 4 to 8 week contract, with potential for extension depending on how the work progresses. Location One week onsite in Beijing, China required (beginning mid January 2007); remainder offsite. Must be eligible for Chinese visa. In addition to the fees for this project, we will fly you to Beijing and put you up in comfortable accommodations at our expense.

2 1

State of demoscene productions under wine.
by Wojciech 'arab' Arabczyk Dec. 22, 2006

Dec. 22, 2006

Hello So, i've been holding back with writing this mail for the last three releases of wine. Im pleased to infrom the whole wine team that almost every demoscene prod i keep a warm place for in my hearth is now (since 0.9.27) working with wine. The list with corresponding links below (all downloads are freeware or public domain): - Kewlers with "Variform" (working perfectly since i remember) http://www.pouet.net/prod.php?which=7138 - Kewlers and Mfx with "1995" (working since last [0.9.27] version, some strange slowdowns occur) http://www.pouet.net/prod.php?which=25783 - Kewlers with Protozoa (working since 0.9.23 i think, some strange slowdowns occur) - Farbrausch with fr-08 (working since 0.9.18 tho minor graphic glitches occur, between 0.9.21 and 0.9.22 occured a regression that does not allow the demo to finish. I'll do some regression test as soon as i'll have some time for it) http://www.pouet.net/prod.php?which=1221 - Farbrausch with fr-025 (working since last release [0.9.27] yet still some strange bugs [on-screen buffers that should not be displayed?] occur) http://www.pouet.net/prod.php?which=9450 - Kasparov from Elitegroup (some effects missing) http://www.pouet.net/prod.php?which=374 - Iconoclast by ASD (working since last [0.9.27] release, some strange slowdowns occur just as in 1995 by Kewlers and MFX and Protozoa by Kewlers [maybe a race condition?]) I hope the list is interesting? I could do some screenshot comparisions with effects/graphics problems or differences between the demos runing natively under windows and under wine. Also please note that the list is incomplete. I could add at least a donzen of demos still not working (i just thot i'll focus this time on those i like most). -- Best regards Wojciech Arabczyk

1 0

Re: dinput: AddRef and Release parent DirectInput class.
by Alexandre Julliard Dec. 22, 2006

Dec. 22, 2006

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > This fixes bug 6918. > --- > dlls/dinput/joystick_linuxinput.c | 5 +++++ > dlls/dinput/keyboard.c | 8 ++++++++ > dlls/dinput/mouse.c | 5 +++++ > 3 files changed, 18 insertions(+), 0 deletions(-) It fails make test: ../../../tools/runtest -q -P wine -M dinput.dll -T ../../.. -p dinput_test.exe.so keyboard.c && touch keyboard.ok keyboard.c:159: Test failed: IDirectInput_Release() reference count = 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

WineAlsa mmap patch
by Maarten Lankhorst Dec. 21, 2006

Dec. 21, 2006

This changes the winealsa dsound driver to stop using asynchronous callbacks and use snd_pcm_wait instead, I'm welcoming testing. For me this fixes the mmap_crst deadlock. I don't know what caused the deadlock in the first place, but this seems to have fixed it somehow. My test was basically running max payne 2 on my old pc, for some reason it's prone to this bug. With this patch I didn't have this problem. Detlef Riekenberg helped me testing first (buggy version) and now I hopefully fixed all issues that were found in it. It's not entirely ready yet I think, I'm not satisfied with latency for non-direct hw access. Basically it is the same loop as for direct hardware access at the moment. That means increased latency, which I think is noticable. Welcoming all comments on it and experiences with it. Maarten

1 0

Re: libwine: Fix some typos
by Alexandre Julliard Dec. 21, 2006

Dec. 21, 2006

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > I believe these identifiers are POSIX ones (from <sys/stat.h>), so they should > not possess one leading underscore (unlike the similar ones in "msvcrt"). These defines are meant for Windows, where they do have underscores. -- Alexandre Julliard julliard(a)winehq.org

2 3

STLPort 5.1 and winegcc / winelib
by gendo＠cox.net Dec. 21, 2006

Dec. 21, 2006

I was wondering if anyone had tried STLPort 5 with winelib. From searching the archives it seems you need to swap out gcc/c++ for winegcc/wineg++ and pass the -mno-cygwin option. Doing that gives me these errors. make -f gcc.mak all wineg++ -pthread -mno-cygwin -fexceptions -fident -fPIC -O2 -fuse-cxa-atexit -D_REENTRANT -D_GNU_SOURCE -I../../stlport -c -o obj/gcc/so/dll_main.o ../../src/dll_main.cpp /usr/include/../include/stdlib.h:469: error: expected ‘;’ before ‘*’ token /usr/include/../include/stdlib.h:470: error: expected ‘;’ before ‘*’ token /usr/include/../include/stdlib.h:471: error: expected ‘;’ before ‘*’ token /usr/include/../include/stdlib.h:475: error: expected ‘;’ before ‘*’ token /usr/include/../include/stdlib.h:479: error: ‘int32_t’ has not been declared winegcc: g++ failed. make: *** [obj/gcc/so/dll_main.o] Error 2 Anyway these are probably from grabbing the system headers which I have read you should not have happen, but if I try to use a -isystem/usr/include/wine/msvcrt or -Isystem/usr/include/wine/msvcrt and -nostdinc++ you then get tons of errors about the stl headers missing exception, cstring, etc. I was wondering if anyone had any thoughts or ideas on how to get this compiled so it is usable is porting applications. Thanks

3 3

Re: msxml.dll: nextNode and reset functions
by Colin Pitrat Dec. 21, 2006

Dec. 21, 2006

OK, I finally managed to cross-compile and run this test under windows and under wine. The patch (test and functions) works well. Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.com Colin Pitrat wrote: > New version of this patch, including corrections suggested by Huw > Davies, a correction and the addition of a test case. > However, I didn't run the test case under Windows because I have a > problem when I run make crosstest : > Undefined reference to _IID_IXMLDOMDocument > and other similar messages with _IID_IXMLDOMNode, _IID_IXMLDOMElement... > > Maybe this error is related to a previous one when running make > crosstest in top directory, occuring for advpack : > Can't find -lcabinet > > Change Log: > Add an iterator to _xmlnodemap struct > Implement nextNode function that give nodes one by one > Implement resetNode that reset the iterator > Add a test case for these functions > > Colin Pitrat (Bull Services Telco) > Bull, Architect of an Open World (TM) > Tél : +33 (0) 1 30 80 72 93 > www.bull.com > > > Colin Pitrat wrote: >> Change Log: >> Add an iterator to _xmlnodemap struct >> Implement nextNode function that give nodes one by one >> Implement resetNode that reset the iterator >> >> It's my first patch, so please tell me if something is wrong. I saw on >> http://www.winehq.com/site/sending_patches that I should write a test >> case, but I don't know how to do this (do I need windows ? because I >> don't have it). >> >> >> ------------------------------------------------------------------------ >> >> diff --git a/dlls/msxml3/nodemap.c b/dlls/msxml3/nodemap.c >> index 0797436..ead0138 100644 >> --- a/dlls/msxml3/nodemap.c >> +++ b/dlls/msxml3/nodemap.c >> @@ -44,6 +44,7 @@ typedef struct _xmlnodemap >> const struct ISupportErrorInfoVtbl *lpSEIVtbl; >> LONG ref; >> IXMLDOMNode *node; >> + long iterator; >> } xmlnodemap; >> >> static inline xmlnodemap *impl_from_IXMLDOMNamedNodeMap( >> IXMLDOMNamedNodeMap *iface ) >> @@ -297,15 +298,47 @@ static HRESULT WINAPI xmlnodemap_nextNod >> IXMLDOMNamedNodeMap *iface, >> IXMLDOMNode** nextItem) >> { >> - FIXME("\n"); >> - return E_NOTIMPL; >> + xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); >> + xmlNodePtr node; >> + xmlAttrPtr curr; >> + long attrIndex; >> + >> + TRACE("%p %ld\n", This, This->iterator); >> + >> + *nextItem = NULL; >> + >> + node = xmlNodePtr_from_domnode( This->node, 0 ); >> + curr = node->properties; >> + >> + for (attrIndex = 0; attrIndex < This->iterator; attrIndex++) { >> + if (curr->next == NULL) >> + return S_FALSE; >> + else >> + curr = curr->next; >> + } >> + >> + if (curr->next == NULL) >> + return S_FALSE; >> + else >> + curr = curr->next; >> + >> + This->iterator++; >> + + *nextItem = create_node( (xmlNodePtr) curr ); >> + >> + return S_OK; >> } >> >> static HRESULT WINAPI xmlnodemap_reset( >> IXMLDOMNamedNodeMap *iface ) >> { >> - FIXME("\n"); >> - return E_NOTIMPL; >> + xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); >> + >> + TRACE("%p %ld\n", This, This->iterator); >> + >> + This->iterator = 0; >> + >> + return S_OK; >> } >> >> static HRESULT WINAPI xmlnodemap__newEnum( >> > > ------------------------------------------------------------------------ > > diff --git a/dlls/msxml3/nodemap.c b/dlls/msxml3/nodemap.c > index 0797436..5458542 100644 > --- a/dlls/msxml3/nodemap.c > +++ b/dlls/msxml3/nodemap.c > @@ -44,6 +44,7 @@ typedef struct _xmlnodemap > const struct ISupportErrorInfoVtbl *lpSEIVtbl; > LONG ref; > IXMLDOMNode *node; > + long iterator; > } xmlnodemap; > > static inline xmlnodemap *impl_from_IXMLDOMNamedNodeMap( IXMLDOMNamedNodeMap *iface ) > @@ -258,8 +259,8 @@ static HRESULT WINAPI xmlnodemap_get_len > > first = node->properties; > if (first == NULL) { > - *listLength = 0; > - return S_OK; > + *listLength = 0; > + return S_OK; > } > > curr = first; > @@ -297,15 +298,42 @@ static HRESULT WINAPI xmlnodemap_nextNod > IXMLDOMNamedNodeMap *iface, > IXMLDOMNode** nextItem) > { > - FIXME("\n"); > - return E_NOTIMPL; > + xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); > + xmlNodePtr node; > + xmlAttrPtr curr; > + long attrIndex; > + > + TRACE("%p %ld\n", This, This->iterator); > + > + *nextItem = NULL; > + > + node = xmlNodePtr_from_domnode( This->node, 0 ); > + curr = node->properties; > + > + for (attrIndex = 0; attrIndex < This->iterator; attrIndex++) { > + if (curr->next == NULL) > + return S_FALSE; > + else > + curr = curr->next; > + } > + > + This->iterator++; > + > + *nextItem = create_node( (xmlNodePtr) curr ); > + > + return S_OK; > } > > static HRESULT WINAPI xmlnodemap_reset( > IXMLDOMNamedNodeMap *iface ) > { > - FIXME("\n"); > - return E_NOTIMPL; > + xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); > + > + TRACE("%p %ld\n", This, This->iterator); > + > + This->iterator = 0; > + > + return S_OK; > } > > static HRESULT WINAPI xmlnodemap__newEnum( > @@ -389,6 +417,7 @@ IXMLDOMNamedNodeMap *create_nodemap( IXM > nodemap->lpSEIVtbl = &support_error_vtbl; > nodemap->node = node; > nodemap->ref = 1; > + nodemap->iterator = 0; > > IXMLDOMNode_AddRef( node ); > /* Since we AddRef a node here, we don't need to call xmldoc_add_ref() */ > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index a2824fd..d8f08ac 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -114,7 +114,10 @@ static void test_domdoc( void ) > r = CoCreateInstance( &CLSID_DOMDocument, NULL, > CLSCTX_INPROC_SERVER, &IID_IXMLDOMDocument, (LPVOID*)&doc ); > if( r != S_OK ) > + { > + printf("CoCreateInstance failed : %d\n",r); > return; > + } > > /* try some stupid things */ > r = IXMLDOMDocument_loadXML( doc, NULL, NULL ); > @@ -411,7 +414,7 @@ todo_wine > ok( node == NULL, "getNamedItem should have returned NULL\n"); > SysFreeString( str ); > > - /* test indexed access of attributes */ > + /* test indexed access of attributes */ > r = IXMLDOMNamedNodeMap_get_length( map, &count ); > ok ( r == S_OK, "get_length wrong code\n"); > ok ( count == 1, "get_length != 1\n"); > @@ -434,6 +437,23 @@ todo_wine > r = IXMLDOMNode_get_nodeName( node, NULL ); > ok ( r == E_INVALIDARG, "get_nodeName (NULL) wrong code\n"); > > + /* test sequential access of attributes */ > + node = NULL; > + r = IXMLDOMNamedNodeMap_nextNode( map, &node ); > + ok ( r == S_OK, "nextNode (first time) wrong code\n"); > + ok ( node != NULL, "nextNode, should be attribute\n"); > + > + r = IXMLDOMNamedNodeMap_nextNode( map, &node ); > + ok ( r != S_OK, "nextNode (second time) wrong code\n"); > + ok ( node == NULL, "nextNode, there is no attribute\n"); > + > + r = IXMLDOMNamedNodeMap_reset( map ); > + ok ( r == S_OK, "reset should return S_OK\n"); > + > + r = IXMLDOMNamedNodeMap_nextNode( map, &node ); > + ok ( r == S_OK, "nextNode (third time) wrong code\n"); > + ok ( node != NULL, "nextNode, should be attribute\n"); > + > /* content doesn't matter here */ > str = SysAllocString( szNonExistentFile ); > r = IXMLDOMNode_get_nodeName( node, &str ); >

1 0

[dinput] regression c17e06d5c0e456d3052a1b6de688956f87c59d3e: No need to copy default constant format. Use already defined static instead
by Christoph Frick Dec. 21, 2006

Dec. 21, 2006

hiho with that patch: commit c17e06d5c0e456d3052a1b6de688956f87c59d3e Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Dec 10 14:15:08 2006 -0700 dinput: No need to copy default constant format. Use already defined static instead. :100644 100644 c5a35a1... 369c26d... M dlls/dinput/joystick_linuxinput.c The game Richard Burns Rally does no longer get any events. The game worked after some patches some month ago from me. As i had no intention on that pages to make things right but to make the game work i might have not picked the optimal solution. But this patches fixed all the apps, that worked with their own DataFormat. So the problem is like that: The old code copied the default constant format and applied caclulate_ids on it. So the dwTypes where set with proper MAKEINSTANCE(...) calls. So an app, that requested later its own data format with SetDataFormat using the data from EnumObjects. After the change now the default const has ANY_INSTANCE all over the place but the app request a certain instance - so on SetDataFormat there are no matches. So the big question is: is our SetDataFormat wrong or is this patch wrong? Please advice. -- cu

2 3

Re: gdi32: Extract the constituent TrueType files from Mac suitcase fonts into the user's caches directory and use these instead of the original suitcase.
by Pierre d'Herbemont Dec. 21, 2006

Dec. 21, 2006

> +#ifdef WORDS_BIGENDIAN > +#define GET_BE_WORD(x) (x) > +#else > +#define GET_BE_WORD(x) ((((x) & 0xff) << 8) | (((x) & 0xff00) >> 8)) > +#endif This could be replaced by CoreFoundation's CFSwapInt16BigToHost, which might be a bit more efficient... Pierre.

1 0

Re: gdi32: Extract the constituent TrueType files from Mac suitcase fonts into the user's caches directory and use these instead of the original suitcase.
by Alexandre Julliard Dec. 21, 2006

Dec. 21, 2006

Huw Davies <huw(a)codeweavers.com> writes: > + ret = malloc(sizeof(*ret)); > + if(!ret) > + { > + CloseResFile(res_ref); > + return NULL; > + } > + list_init(ret); It's better to avoid using malloc() in Wine. Also it seems to me it would be cleaner to return an array of char*, instead of a struct list that forces the caller to make assumptions about the type of the list elements. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d9: Add a render target test
by Ivan Gyurdiev Dec. 20, 2006

Dec. 20, 2006

H. Verbeet wrote: > On 20/12/06, H. Verbeet <hverbeet(a)gmail.com> wrote: >> This time as part of the device.c test. >> >> Changelog: >> - Add a render target test >> > Use the attached patch instead, the previous version doesn't apply. This test really belongs in stateblock.c, along with every other set <--> get test if you ask me, that's what the framework there was written for. It might be kind of a pain to get this particular one to work though, since changing the rendertarget is currently considered an "event", across which all other set/get tests are ran, but I'm sure it's possible. The question of whether stateblocks track render targets should be answered eventually...

1 0

Re: setupapi: Use GetSystemDirectory() rather than hardcoding 'system32'.
by Alexandre Julliard Dec. 20, 2006

Dec. 20, 2006

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -87,13 +87,13 @@ static HINF search_for_inf(LPCVOID InfSpec, DWORD SearchControl) > HINF hInf = INVALID_HANDLE_VALUE; > WCHAR inf_path[MAX_PATH]; > > + static const WCHAR bslashW[] = {'\\',0}; > static const WCHAR infW[] = {'\\','i','n','f','\\',0}; > - static const WCHAR system32W[] = {'\\','s','y','s','t','e','m','3','2','\\',0}; > > if (SearchControl == INFINFO_REVERSE_DEFAULT_SEARCH) > { > - GetWindowsDirectoryW(inf_path, MAX_PATH); > - lstrcatW(inf_path, system32W); > + GetSystemDirectoryW(inf_path, MAX_PATH); > + lstrcatW(inf_path, bslashW); It's really supposed to hardcode system32, at least according to MSDN. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10: impelment ScriptStringGetLogicalWidths
by Alexandre Julliard Dec. 20, 2006

Dec. 20, 2006

Clinton Stimpson <cjstimpson(a)utwire.net> writes: > This patch implements ScriptStringGetLogicalWidths. > Update usp10.spec so it isn't a stub anymore. > Also added a test for this function. The test fails for me: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:1297: Test failed: ScriptStringGetLogicalWidths should return index 4 = 10, not 5 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: gdi32: Improve the fontconfig filtering hack so that Mac suitcase fonts get through.
by Paul Vriens Dec. 20, 2006

Dec. 20, 2006

On Tue, 2006-12-19 at 21:21 +0000, Huw Davies wrote: > + if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) > AddFontFileToList(file, NULL, ADDFONT_EXTERNAL_FONT); Hi, this patch was committed but I don't think this 'if' statement is correct as it will never be entered. No clue if it's just changing '&&' into '||'. Cheers, Paul.

2 2

Re: kernel32: suppress an unneeded warning (try 3)
by Alexandre Julliard Dec. 20, 2006

Dec. 20, 2006

Juan Lang <juan_lang(a)yahoo.com> writes: > This time I added a test. It wouldn't have failed before, it would merely > produce a useless fixme. This suppresses that fixme by removing comments > before checking whether the read string overflows the buffer. > > ChangeLog: remove comments from string read in GetPrivateProfileIntW There is nothing special about ';' in values, other characters will terminate the number conversion too. It's probably safe to simply remove the FIXME, or maybe make it a WARN. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32: ws_sockaddr_u2ws should zero the WS_sockaddr before using it.
by Francois Gouget Dec. 20, 2006

Dec. 20, 2006

On Wed, 20 Dec 2006, Kai Blin wrote: @@ -946,6 +946,9 @@ static int ws_sockaddr_u2ws(const struct { int res; + /* Zero the ws_sockaddr structure before using */ + memset(wsaddr, 0, *wsaddrlen); Are you sure this is needed in ws_sockaddr_u2ws() or should it rather be done by getsockname() (as your test indicates). Also, do we know of a real-world application that needs this? Finally, this memset() makes the one in the AF_UNSPEC case redundant, and may itself be redundant with some of the memcpy()s... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 1

Re: [5/5] d3d9: Add a render target test
by Alexandre Julliard Dec. 20, 2006

Dec. 20, 2006

"H. Verbeet" <hverbeet(a)gmail.com> writes: > Test if the stuff I just sent works. > > Changelog: > - Add a render target test > --- > > dlls/d3d9/tests/Makefile.in | 1 > dlls/d3d9/tests/rendertarget.c | 156 ++++++++++++++++++++++++++++++++++++++++ Could you please merge the test into one of the existing files, like device.c? We don't want to create new files for every test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemenubuilder: Write truecolor icons as PNGs
by Francois Gouget Dec. 19, 2006

Dec. 19, 2006

On Wed, 6 Dec 2006, Frank Richter wrote: > When libpng is available, support for writing out 24 and 32bpp icons is > added, which are written out as PNGs. Also changed wineshelllink to > support both xpm and png extensions for icons. > > Some parts based on an older patch by Vitaliy Margolen. The thing that blocked this patch from being applied last time is that, if I remember correctly, Alexandre would like the PNG functionality to be added to the IPicture implementation in dlls/oleaut32/olepicture.c. Then winemenubuilder would use this interface to save the icon into the proper format. It's easy to see where the code should go to extend this interface to support loading PNG files as it already supports loading Gif and Jpeg files. However I'm fuzzy on how one would use this interface to specify the format to use for saving. Maybe by defining Wine-specific PICTYPE_XXX values? But that would not work on Windows... The other semi-related part would be to use ExtractAssociatedIcon() instead of extract_icon32(), though I'm not sure that's compatible with trying to select the 'best' icon size/color depth. I'm pretty sure my memory mangled some of this. Hopefully Alexandre will clarify things. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux

2 2