December 2006 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

Updated version of Wine-0.9.18 RPMs with ntoskrnl for SuSE 10.1
by Vitaliy Margolen Feb. 19, 2007

Feb. 19, 2007

Same as before. Just recompiled with new version. http://www.kievinfo.com/wine-0.9.18-1.2.i586.rpm http://www.kievinfo.com/wine-0.9.18-1.2.src.rpm -- Best regards, Vitaliy

3 3

Font issue - workaround found
by Timm Feb. 18, 2007

Feb. 18, 2007

My one win app that makes me a devotee of WINE is TablEdit (demo at www.tabledit.com/download/tabled32.exe) has a custom font , tef260.ttf, that has failed to display since somewhere after ver 9.6. The program installs the font into c:\windows\font, but can not display it within the program, instead displaying for the most part, empty squares. I tried putting/removing tef260.ttf into /usr/local/share/wine/fonts, /usr/local/share/fonts, and the wine windows/fonts directories in all permutations. The only way I got it to display was to remove ALL fonts from these three directories and install tef260.ttf into an X11 font directory along with other win ttf fonts. This forces WINE to build a cachedmetrics file like it used to, and the font is displayed properly in the program. Hope this is a clue for some developer, as I merely lurk here, looking for clues about wine behavior. I can't do a regression back to ver 9.6 (the version I was using that last worked) because my upgrades to freetype cause it to complain of missing functions. current (pertinent ? ) specs libfreetype.so.6.3.7 ] built from source libfontconfig.so.1.0.4 ] built from source fontforge 20060715 ] built from source WINE 0.9.20 ] built from source kernel 2.6.17.11 Slack current (10.2, with upgrades from "current" tree) -- Timm

3 2

Re: Bug 50
by Pedro Araújo Chaves Jr. Feb. 13, 2007

Feb. 13, 2007

I've been trying to get the lpDx array to be properly calculated, but unfortunately to no avail. I did find, though, that GetTextExtentExPointW is never called with a maxExt value other than zero, and thus nfit is not calculated. Regarding that, would any of you know where I should look for the proper method of calculating the maximum width (maxExt) of a formatted string? I'm somewhat puzzled... neither lprect nor dc->BoundsRect seem to hold the proper values for getting that value [1], or (more likely, I guess) I'm just looking at it the wrong way. Btw, I'd add that I've been testing this in Lotus Notes R5, just in case it helps, and no, I haven't found a link to download a trial. [2] [3] Cheers, Pedro. [1] I'm investigating the SetTextJustification, ExtTextOutW, GetTextExtentPointW, GetTextExtentPoint32W, GetTextExtentExPointW, and WineEngGetTextExtentExPoint functions from gdi32 (the latter in freetype.c, the rest in font.c). I am yet to look into their *I counterparts, where applicable. [2] http://appdb.winehq.org/viewbugs.php?bug_id=50 [3] http://bugs.winehq.org/show_bug.cgi?id=7016

2 3

Re: configure: add ncursesw detecting [try 2]
by Alexandre Julliard Jan. 12, 2007

Jan. 12, 2007

Vitaly Lipatov <lav(a)etersoft.ru> writes: > Try 2, with ncursesw/ncurses detecting > In order to build wineconsole run properly in utf8 locale, we use ncursesw, > which can handle wchar strings. Why would you need wchar strings if you use utf-8? Have you configured your locale properly? -- Alexandre Julliard julliard(a)winehq.org

4 14

Looking for sound testers
by Maarten Lankhorst Jan. 11, 2007

Jan. 11, 2007

Hi all, I've forward ported the old patches of Davin McCall (dsound.patch). With them I have no more sound underruns etc, I'm therefore looking for other people to test them as well. I'm welcoming comments on how it works and possible issues with it. I also attached my patch to alsa, I'm aware of the things I need to fix for that, but I thought it might be good to test dsound with winealsa, to see if other things still need to be fixed. Cheers, Maarten

6 5

appdb rating inflation
by Dan Kegel Jan. 6, 2007

Jan. 6, 2007

The appdb says "Only applications which install and run flawlessly on an out-of-the-box Wine installation make it to the Platinum list" But several platinum-rated apps seem to deserve a silver or bronze rating. For instance, Call to Duty, http://appdb.winehq.org/appview.php?iVersionId=3603 has all sorts of caveats: - Punkbuster enabled Multiplayer will not work - Sound out of sync. - Runs without crashes, but only if installed as root - requires whacky third-party Loki installer; real installer fails on cd change (http://bugs.winehq.org/show_bug.cgi?id=6594) - "with alsa, the sound lags ~ 1 second behind the game.... if i choose oss i got the 166 sound files missing error" And Diablo II, http://appdb.winehq.org/appview.php?iVersionId=49, also has lots of complaints / caveats / complicated howto's. Should we impose some standards on appdb ratings? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

19 39

Re: systray icon questions
by Kirill K. Smirnov Jan. 2, 2007

Jan. 2, 2007

> Unfortunately, yes. The way the helper window is currently implemented, > if you remove the WS_CAPTION style, the icon won't be centered when it > gets docked (in GNOME at least.) I tried that when I put together the > systray tooltips patch. Ultimately it caused more problems than it > solved, so I gave up on it. But, it would be really great if you could > figure it out. :) I've tried kde, fluxbox and xfce4 (and fvwm, but it lacks systray). Now I can see that xfce4 suffers from it. I did not noticed that before. So, I suppose a new patch (attached). Does it work correct with GNOME? In xfce is OK. Thanks for pointing the path! -- Kirill K. Smirnov

2 1

Reason for some process failures in kernel32 tests
by Paul Vriens Jan. 1, 2007

Jan. 1, 2007

Hi, I've been trying to tackle some of the issues we have when trying to run some process tests (through winetest.exe, see also http://test.winehq.org/data) process.c:775: Test failed: CreateProcess (./kernel32_test.exe tests/process.c C:\TEMP\wt44.tmp "a\"b\\" c\" d) failed : 2 process.c:777: Test failed: Child process termination process.c:781: Test failed: Arguments:argvA0 expected './kernel32_test.exe', got '(null)' process.c:790: Test failed: CreateProcess (.\kernel32_test.exe tests/process.c C:\TEMP\wt45.tmp "a\"b\\" c\" d) failed : 2 process.c:792: Test failed: Child process termination process.c:796: Test failed: Arguments:argvA0 expected '.\kernel32_test.exe', got '(null)' process.c:810: Test failed: CreateProcess (..\wct12/kernel32_test.exe tests/process.c C:\TEMP\wt46.tmp "a\"b\\" c\" d) failed : 2 process.c:812: Test failed: Child process termination process.c:816: Test failed: Arguments:argvA0 expected '..\wct12/kernel32_test.exe', got '(null)' The reason for this particular one is that I'm running winetest.exe started from a command-file on my desktop. This means that the current directory is the desktop directory. The winetest gui shows that the working directory is (in this case) c:\temp\wct12. This value is however not passed to the tests when CreateProcess is run: main.c: 291 if (!CreateProcessA (NULL, cmd, NULL, NULL, TRUE, 0, 292 NULL, NULL, &si, &pi)) { The above means that the kernel32_test.exe has a working directory that is not c:\temp\wct12 (in this case again) and thus cannot find the executable when referenced relatively. All the test-results that are shown on http://test.winehq.org show more-or-less the same behavior. How can I retrieve the correct working directory (as shown in the winetest gui) and pass that to the single tests? (I think that would solve these particular issues). Cheers and thanks for any pointers, Paul.

3 5

OpenGL as child windows
by Chris Robinson Dec. 31, 2006

Dec. 31, 2006

The topic of getting OpenGL to show and use more visuals/pixel formats than just the one the main window uses came up on IRC, and I was told to make a post here. One of the ideas was to create a child window of the main X window (which can be given a different visual) and have OpenGL use that for drawing. A simple test program I wrote (using X) seems to behave well. The child window stays relative to the parent, it remains fully connected (even with the wobbly effects of compositors like Beryl), and it can use a different visual. Since wgl is now a part of x11drv, it should be possible to make an X11 child window. Are there any problems with using this approach in Wine?

7 9

Re: Resend: user32: fix return value in DialogBoxParamA if no resourcecan be found + simple test (try 2)
by Dmitry Timoshkov Dec. 31, 2006

Dec. 31, 2006

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > As Dmitry Timoshkov (thanks for that) the SetLastError was not necessary. > Here's updated patch. Probably the problem is that you need also handle both FindResourceW and LoadResource failures the same way by returning -1, and change 'return -1;' later to 'return 0;' (for invalid parent) as MSDN suggests. All that needs to be tested as well. Also DialogBoxParamW needs to be fixed as well. Probably other dialaog APIs (like DialogBoxIndirectParamAorW) need a review regarding that. -- Dmitry.

1 0

Re: ntdll: Map ESPIPE to STATUS_ILLEGAL_FUNCTION
by Andreas Mohr Dec. 31, 2006

Dec. 31, 2006

Hi, On Sun, Dec 31, 2006 at 05:28:23PM +0800, Dmitry Timoshkov wrote: > Hello, > > Running RedAlert demo spits a lot of FIXMEs about converting errno 29 > (ESPIPE) to STATUS_UNSUCCESSFUL. In Linux /usr/include/asm/errno.h has > a comment /* Illegal seek */ for ESPIPE, so STATUS_ILLEGAL_FUNCTION seems > to be the best choice. > > Changelog: > ntdll: Map ESPIPE to STATUS_ILLEGAL_FUNCTION. The STATUS_ILLEGAL_FUNCTION name was rather misleading to me since it doesn't indicate at all that it's supposed to be pipe-related (however it's within the numeric range of many other pipe status codes!). So, given that this is mainly a pipe status code after all I'd say that's the best we can achieve right now. Of course, what really matters is what the receiving Win32 side *usually* expects after we encountered ESPIPE, and this might turn out to differ from your conversion ;). (is there any indication that RedAlert checks for a specific status code??) Andreas Mohr

2 1

Re: X11DRV: remove DesktopDoubleBuffered option
by Dmitry Timoshkov Dec. 31, 2006

Dec. 31, 2006

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> wrote: > This patch removes the DesktopDoubleBuffered option. Support for this option should be removed from winecfg simultaneously with this change. -- Dmitry.

1 0

problems with installed wine
by Corey McClymonds Dec. 31, 2006

Dec. 31, 2006

for almost a week now, wine has been acting weird. I compile wine and using it from the wine source tree, everything works perfectly. But if I make install it, then try to use it, all I get is a black screen that I have to alt-tab to get out of. On a note, it works fine if I run as root. I have blown away my .wine directory, it doesn't help. I compile from git. Corey McClymonds

2 1

Re: Resend: msxml.dll: nextNode and reset functions
by James Hawkins Dec. 30, 2006

Dec. 30, 2006

On 12/28/06, Colin Pitrat <colin.pitrat(a)bull.net> wrote: > Hi, > > here is a patch I sent a few weeks ago implementing two functions in > msxml.dll, and the corresponding test. > I suggest sending the tests in one patch first, then send each function in a separate patch afterwards. -- James Hawkins

1 0

Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlighting of current date.
by Duane Clark Dec. 30, 2006

Dec. 30, 2006

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: c5b8df481f2bb0362b57188a8c7df423030ba8b0 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5b8df481f2bb0362b57188a8… > > Author: Vijay Kiran Kamuju <infyquest(a)gmail.com> > Date: Sun Dec 24 13:31:56 2006 +0530 > > comctl32: MonthCalendar - Fix highlighting of current date. That does highlight the current date on startup. But I notice that when I click another date, the current date doesn't get unhighlighted.

5 6

Re: riched20: block recursive notification
by Matt Finnicum Dec. 30, 2006

Dec. 30, 2006

On 12/30/06, Clinton Stimpson <cjstimpson(a)utwire.net> wrote: > > This patch blocks riched20 from recursivly sending an EN_CHANGE > notification. > Fixes bug 6985. > > Thanks, > Clinton Stimpson > > ChangeLog > Block recursive EN_CHANGE notifications. If you're adding a new variable to the ME_TextEditor structure then you should probably also initialize it in ME_MakeEditor. Naming the variable "notify" is somewhat ambiguous, and there seems to be an established convention of naming int's with the 'n' prefix, like nNotifiy. You should probably comment to explain what the variable is for or attempt to name it something more self evident. Maybe a BOOL would be more appropriate, unless you're intending to extend this to other notify calls as well. Lastly, I don't see why this patch is needed - it only prevents the ME_SendOldNotify (which just calls SendMessageA) from triggering another call of that same EN_CHANGE notification. I don't see why calling SendMessageA would cause ME_UpdateRepaint to be called. Maybe the application you're working with, in processing the EN_CHANGE message, is sending another message to which we wrongly are sending an EN_CHANGE notification - so thus we should fix our message handling of that. A quick look at MSDN shows that "The EN_CHANGE notification message is sent when the user has taken an action that may have altered text in an edit control." - it seems that we may be sending them whenever any action (user or not) has altered text in the control. We really could use some tests to see what should generate EN_CHANGE messages. Another possibility is that we don't handle the case where (again, from MSDN) "The EN_CHANGE notification is not sent when the ES_MULTILINE style is used and the text is sent through WM_SETTEXT." - perhaps your application has ES_MULTILINE set and uses a WM_SETTEXT in response to the EN_CHANGE notification? Thanks for your help with richedit, --Matt Finnicum

1 0

Re: wine-patch OleIconToCursor function
by Marcus Meissner Dec. 30, 2006

Dec. 30, 2006

On Sat, Dec 30, 2006 at 04:49:27AM +0100, Bernard Ladenthin wrote: > Hello, > in the attachment is a small patch for the OleIconToCursor function. > The function works with this. I hope i can help with this and get a > response mail that this mail have received. I haven't any experiences > with git so it's a simply patch. > > I have tested it with the "Lexware Buchhalter 2005". > You can download it from http://server.ladenthin.net/bh2005.zip to see > that it works. Start with wine the "LxStart.exe" and turn over the > Text and Icon with the mouse, the icon is now the cursor. > > Best regards from Germany, > Bernard Ramon Ladenthin In general you do no need to edit Changelog yourself. Just add a note above the patch. Otherwise it looks fine to my eyes (and perhaps Alexandres too), thanks! Ciao, Marcus > diff --git a/ChangeLog b/ChangeLog > index 3b536b5..9723401 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2006-12-30 Bernard Ramon Ladenthin <bernard(a)ladenthin.net> > + > + * dlls/oleaut32/oleaut.c, dlls/oleaut32/stubs.c: > + oleaut32: Implement the function OleIconToCursor and remove the stub. > + > 2006-12-22 Dmitry Timoshkov <dmitry(a)codeweavers.com> > > * dlls/user32/tests/msg.c, dlls/winex11.drv/winpos.c: > diff --git a/dlls/oleaut32/oleaut.c b/dlls/oleaut32/oleaut.c > index d6a08a9..65a4174 100644 > --- a/dlls/oleaut32/oleaut.c > +++ b/dlls/oleaut32/oleaut.c > @@ -837,3 +837,19 @@ BOOL WINAPI DllMain(HINSTANCE hInstDll, > > return TRUE; > } > + > +/*********************************************************************** > + * OleIconToCursor (OLEAUT32.415) > + */ > +HCURSOR WINAPI OleIconToCursor( HINSTANCE hinstExe, HICON hIcon) > +{ > + FIXME("(%p,%p), (olepro32.dll), partially implemented.\n",hinstExe,hIcon); > + if (hIcon) > + return CopyCursor(hIcon); > + else > + return NULL; > + > + /* FIXME > + make a extended conversation from HICON to HCURSOR > + */ > +} > diff --git a/dlls/oleaut32/stubs.c b/dlls/oleaut32/stubs.c > index ac2d494..d87e76e 100644 > --- a/dlls/oleaut32/stubs.c > +++ b/dlls/oleaut32/stubs.c > @@ -33,15 +33,6 @@ > WINE_DEFAULT_DEBUG_CHANNEL(ole); > > /*********************************************************************** > - * OleIconToCursor (OLEAUT32.415) > - */ > -HCURSOR WINAPI OleIconToCursor( HINSTANCE hinstExe, HICON hicon) > -{ > - FIXME("(%p,%p), not implemented (olepro32.dll)\n",hinstExe,hicon); > - return S_OK; > -} > - > -/*********************************************************************** > * OleCreatePropertyFrameIndirect (OLEAUT32.416) > */ > HRESULT WINAPI OleCreatePropertyFrameIndirect( LPOCPFIPARAMS lpParams) >

2 1

Re: USB
by Damjan Jovanovic Dec. 30, 2006

Dec. 30, 2006

On 12/30/06, Andrew Neil Ramage <nrsc16850(a)blueyonder.co.uk> wrote: > A franklin eBookMan using the provided Windows Software. (By the way, it's bad practice to top-post bottom-posted emails.) What interface does the device provide? Is it a mass-storage device? Or some vendor-specific protocol? Do "lsusb -v" and see the class and subclass -if they're 0xFF (vendor-specific), you're probably out of luck, because: If the Windows software includes .SYS files, wine can't load those yet (although wine's NTOSKRNL.EXE is coming soon, right?) Since wine is largely designed for running Windows applications on Linux, a lot of the hardware support infrastructure (SETUPAPI, CFGMGR, ...) is still missing. At present, a Windows app cannot directly access the hardware, only indirectly (for example, it can save a file to a mass-storage device supported by Linux, or communicate through a USB ethernet controller supported by Linux). Now in Windows, applications don't access USB directly either (Windows only allows USB control packets from user-space, not bulk, interrupt or isochronous, and no app I know uses that interface anyway). What apps usually do is open a .SYS device driver (eg. \\.\USBSCAN0\2) and use ReadFile to send bulk data, WriteFile to receive bulk data, and DeviceIoControl for everything else. So in theory if you figure out the interface between the application and the driver in Windows, you can write a kernel module for Linux that does the same, and your app can communicate with the hardware. Wine currently doesn't do this at all, although I've written a semi-complete implementation of STI and USBSCAN.SYS this way, and it works with native TWAIN drivers. Damjan > Andrew > > > On 12/30/06, Andrew Neil Ramage <nrsc16850(a)blueyonder.co.uk> wrote: > >> How do you get a Windows program access to the USB port ? > > > > What are you trying to do? What device are you accessing? > > > >> Andrew > > > > Damjan > > > > > > > -- > Andrew Ramage > > >

1 0

USB
by Andrew Neil Ramage Dec. 30, 2006

Dec. 30, 2006

How do you get a Windows program access to the USB port ? -- Andrew "Oh, bother," said the Borg. "We've assimilated Pooh."

2 1

windows web server app fails to send more than 11680 bytes !?
by [IDC]Dragon Dec. 30, 2006

Dec. 30, 2006

Hello, I'm testing a windows app I'd very much like to run under Wine (using v0.9.22), being in touch with the author. This is a small web server app based on a Microsoft MFC sample app. It happily works under Windows, but that'd be the wrong thing for running it 24/7. ;-) It's not yet working under Wine, fails to serve larger files, but we've pretty much narrowed down the problem by adding logs to the app and using ethereal. For example, the app tries to write 25017 bytes to the socket, but the socket only allows 11680 bytes at a time, and the TCP stack fragments this in 8 packets of 1460 bytes, presumably because it only has 8 buffers reserved. So far so good. We see them being sent on the Ethernet and the ACK's are coming in, but after these 8 packets there should be a signal to trigger the OnSend function of the app so it can send the next part of data, but this never happens... The reselection of the socket did not return an error. Given the reselection is ok, and at the Ethernet level messages are consistently sent and ACK's received, the conclusion is that there might be a bug in Wine. So here we are stuck. Given that Wine successfully runs real big application such as MS Internet Explorer, I can't imagine it to have such a fundamental problem. Is there something I overlooked, like a configuration issue? If it really gets interesting, I can ask the developer for a more detailed report, including the Ethereal log snippet, in case somebody wants to actually look into it. First I'd like to find out if this is the right place, or if I should "bury" it into bugzilla. Thank you for your time and help, Jörg -- GMX DSL-Flatrate 0,- Euro* - Überall, wo DSL verfügbar ist! NEU: Jetzt bis zu 16.000 kBit/s! http://www.gmx.net/de/go/dsl

5 9

Budgetdedicated mirror down
by Kai Blin Dec. 30, 2006

Dec. 30, 2006

Hi folks, at the time of writing, I'm unable to get a page back from the budgetdedicated mirror. Could someone who has access to that box take a look at that? Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: [user32][msgbox] Disable IDCANCEL for some MessageBoxs
by Dmitry Timoshkov Dec. 30, 2006

Dec. 30, 2006

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > @@ -129,9 +132,11 @@ static HFONT MSGBOX_OnInit(HWND hwnd, LP > ShowWindow(GetDlgItem(hwnd, IDCANCEL), SW_HIDE); > ShowWindow(GetDlgItem(hwnd, IDYES), SW_HIDE); > ShowWindow(GetDlgItem(hwnd, IDNO), SW_HIDE); > + bUseCancel = FALSE; > break; > case MB_YESNO: > ShowWindow(GetDlgItem(hwnd, IDCANCEL), SW_HIDE); > + bUseCancel = FALSE; It would be much simpler to use IsWindowVisible(GetDlgItem(hwnd, IDCANCEL)) where appropriate instead of introducing bUseCancel. > /* fall through */ > case MB_YESNOCANCEL: > ShowWindow(GetDlgItem(hwnd, IDOK), SW_HIDE); > @@ -147,6 +152,11 @@ static HFONT MSGBOX_OnInit(HWND hwnd, LP > ShowWindow(GetDlgItem(hwnd, IDNO), SW_HIDE); > break; > } > + if(!bUseCancel) > + { > + SetWindowLongW(hwnd,GWL_STYLE,GetWindowLongW(hwnd,GWL_STYLE)&~(WS_SYSMENU)); > + } > + SetPropA(hwnd, "WINE_MSGBOX_BUSECANCEL", (HANDLE)bUseCancel); What is the purpose of removing WS_SYSMENU? In any case this change requires a test case. -- Dmitry.

1 0

Building a full win32 winetest.exe
by Paul Vriens Dec. 29, 2006

Dec. 29, 2006

Hi, any pointers how to build a winetest.exe I can run on Windows? All tests (but crypt32 and hlink) can be cross compiled (MinGW) but only give me the single test executable for that dll. Cheers, Paul.

3 4

Removing unused functions and variables
by Andrew Talbot Dec. 29, 2006

Dec. 29, 2006

Hi, I am intending to send in a few patches to remove some unused Wine variables and functions from the dlls. Please accept that my good faith is tempered by a degree of ignorance, and advise me of suitable markup if any seemingly redundant piece of code I seek to remove must remain for a legitimate reason. Thanks, -- Andy.

1 0

[4/4] wined3d: Create samplers for *all* 1.x instructions that sample
by Christoph Bumiller Dec. 29, 2006

Dec. 29, 2006

Note that WINED3DSIO_TEXDP3TEX, WINED3DSIO_TEXM3x3VSPEC, WINED3DSIO_TEXM3x3SPEC are already handled in the 2 else if branches below, they should probably be removed somewhere. > @@ -295,8 +295,15 @@ HRESULT shader_get_registers_used( > if > (WINED3DSHADER_VERSION_MAJOR(This->baseShader.hex_version) == 1 && > (WINED3DSIO_TEX == curOpcode->opcode || > WINED3DSIO_TEXBEM == curOpcode->opcode || > + WINED3DSIO_TEXBEML == curOpcode->opcode || > + WINED3DSIO_TEXDP3TEX == curOpcode->opcode || > WINED3DSIO_TEXM3x2TEX == curOpcode->opcode || > - WINED3DSIO_TEXM3x3TEX == curOpcode->opcode)) { > + WINED3DSIO_TEXM3x3SPEC == curOpcode->opcode || > + WINED3DSIO_TEXM3x3TEX == curOpcode->opcode || > + WINED3DSIO_TEXM3x3VSPEC == curOpcode->opcode || ... } else if (WINED3DSHADER_VERSION_MAJOR(This->baseShader.hex_version) == 1 && (WINED3DSIO_TEXM3x3SPEC == curOpcode->opcode || WINED3DSIO_TEXM3x3VSPEC == curOpcode->opcode)) {

2 1

Solution to Bug 3023
by Michael Gardiner Dec. 29, 2006

Dec. 29, 2006

http://bugs.winehq.org/show_bug.cgi?id=3023 I have been fiddling with Orcad 9.2 Capture and have found the cause of the problem behind its inability to place parts, text etc. It is caused by the window that the object is to be placed in temporarily losing focus (or maybe activation) after the dialog box for entering the object's properties is closed. This temporary loss of focus causes the window to "lose its grip" on the object being placed. Removing the line that calls WINPOS_ActivateOtherWindow in dlls/user32/dialog.c in the EndDialog function fixes this problem - the focus seems to immediately return to the correct window and the object can be placed. The removal of this WINPOS_ActivateOtherWindow call does not seem to have any visible side-effects in this particular instance - does it have a purpose? (In this instance I traced its call to see what it activated - it does not find a valid window to activate, so reaches the end and calls SetActiveWindow(0)).

1 0

Re: sane.ds: Remove unused WINE_DEFAULT_DEBUG_CHANNEL
by Marcus Meissner Dec. 28, 2006

Dec. 28, 2006

On Thu, Dec 28, 2006 at 09:08:51PM +0000, Andrew Talbot wrote: > Changelog: > sane.ds: Remove unused WINE_DEFAULT_DEBUG_CHANNEL. > > diff -urN a/dlls/sane.ds/ui.c b/dlls/sane.ds/ui.c > --- a/dlls/sane.ds/ui.c 2006-05-23 13:48:34.000000000 +0100 > +++ b/dlls/sane.ds/ui.c 2006-12-28 20:49:16.000000000 +0000 > @@ -37,8 +37,6 @@ > #include "wine/debug.h" > #include "resource.h" > > -WINE_DEFAULT_DEBUG_CHANNEL(twain); > - > #ifdef HAVE_SANE NAK, this code has 1 TRACE() some way below. Just move it below #ifdef HAVE_SANE. Ciao, Marcus

1 0

systray icon questions
by Kirill K. Smirnov Dec. 28, 2006

Dec. 28, 2006

Hi, all! I was playing around systray icons in various modes 1) "allow the window manager to control the windows"="on" "emulate a virtual desktop"="off" As result, systray icon is OK. 2) In other combination of these parameters, the icon is drawn with window title. I've tried to investigate the problem and created the patch (attached). But it solves the problem only in non-desktop modes. In desktop modes only window title is drawn. So the questions: 1) Does systray icon helper window really need to be created with WS_CAPTION style? 2) What does "managed" mode mean? 3) When I select "desktop" mode, should we disable the "managed" checkbox? Thanks in advance, -- Kirill K. Smirnov

2 1

Re: Building a full win32 winetest.exe
by Hans Leidekker Dec. 28, 2006

Dec. 28, 2006

On Monday 25 December 2006 11:22, Paul Vriens wrote: > These are the MinGW packages I'm currently using: > > mingw-binutils-2.16.91-9hl > mingw-w32api-3.6-18hl > mingw-gcc-core-3.4.5-13hl > mingw-runtime-3.9-18hl I think I'll get around to building a new set of RPMs this week. Lets go for a Wine 1.0 release without any failing test on XP. -Hans

1 1

Re: [1/4] wined3d: Where possible, avoid using D3DCOLORTOGLFLOAT4
by Stefan Dösinger Dec. 28, 2006

Dec. 28, 2006

Am 28.12.2006 um 03:12 schrieb H. Verbeet: > Most of the places that use D3DCOLORTOGLFLOAT4 can handle GLint's > just as well. > > Changelog: > - Where possible, avoid using D3DCOLORTOGLFLOAT4 > <wined3d_d3dcolor.diff.txt> > This patch causes a regression in Battlefield 1942, a lot of geometry is missing(ships, planes, parts of trees).

1 0

re: comctl32: MonthCalendar - Fixhighlightingof current date.
by Dan Kegel Dec. 28, 2006

Dec. 28, 2006

Dmitry wrote: > "Vijay Kiran Kamuju" <infyquest at gmail.com> wrote: >> What do we need to setup, if we want a test framework for messages in >> comctl32 similar to user32? > >Some kind of a message queue is needed and a mechanism to check what >has been gathered with an expected sequence. I'd suggest to not invent >a wheel and copy existing parts from dlls/user32/tests/msg.c. Yeah. Also I think James Hawkins is doing this now for comctl, might check with him first. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: WGL: fix wglGetProcAddress bug
by Roderick Colenbrander Dec. 28, 2006

Dec. 28, 2006

Vitaly just pointed out that the previous version added some extra spaces. This one fixes that. Roderick > Hi, > > This patch fixes a nasty wglGetProcAddress bug. In case the name of an > unknown GL extension (one which is not in wine yet) was passed to > wglGetProcAddress it was assumed that it was a WGL extension. > > WGL extensions are in the end looked up in winex11.drv. The > wglGetProcAddress function in winex11.drv can return WGL extensions but it can also > return native GL functions. This ability is used in order to fill the opengl32 > thunks (win32 GL -> native GL). > > The problem was that unknown extensions were also passed to the > winex11.drv code. This resulted that code to look up a native GL functions (the > winex11.drv code returns wgl extensions if the function name starts with 'wgl' > and else it calls glXGetProcAddress). > > In the end this patch makes sure that only functions which start with a > 'w' are passed to the winex11.drv code in the other cases a warning is > printed that the function wasn't found. > > Regards, > Roderick Colenbrander -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

function_grep.pl - idutils
by Claudio Fontana Dec. 27, 2006

Dec. 27, 2006

Hello, I noticed that you are using function_grep.pl to search for a certain function. Have you considered GNU idutils? They can do that and more (and faster): http://www.gnu.org/software/idutils It is as simple as $ cd $WINE_SRC_PATH $ mkid (generate ID database, takes about 4 seconds on my machine for wine) $ gid -r PATTERN Claudio

1 0

kernel32 console bug?
by Robert Reif Dec. 27, 2006

Dec. 27, 2006

I get an error when running a windows console program on wine. It appears that in wine, GetStdHandle(STD_INPUT_HANDLE) doesn't return a handle to a console so GetConsoleMode() on that handle fails. The actual programs that fail are at: http://simh.trailing-edge.com/ Here is a simple patch to kernel32/tests/console.c to demonstrate the problem: diff -p -u -r1.2 console.c --- dlls/kernel32/tests/console.c 10 Oct 2006 18:19:57 -0000 1.2 +++ dlls/kernel32/tests/console.c 20 Dec 2006 07:20:06 -0000 @@ -552,12 +552,31 @@ static void testCtrlHandler(void) ok(GetLastError() == ERROR_INVALID_PARAMETER, "Bad error %u\n", GetLastError()); } +static void test(void) +{ + HANDLE std_input; + DWORD saved_mode; + + std_input = GetStdHandle(STD_INPUT_HANDLE); + ok(std_input != INVALID_HANDLE_VALUE, + "GetStdHandle(STD_INPUT_HANDLE) returned INVALID_HANDLE_VALUE\n"); + + if (std_input != INVALID_HANDLE_VALUE) + { + BOOL status; + status = GetConsoleMode(std_input, &saved_mode); + ok(status != FALSE, "GetConsoleMode() failed: %08x\n", GetLastError()); + } +} + START_TEST(console) { HANDLE hConIn, hConOut; BOOL ret; CONSOLE_SCREEN_BUFFER_INFO sbi; + test(); + /* be sure we have a clean console (and that's our own) * FIXME: this will make the test fail (currently) if we don't run * under X11

4 6

adding a data point to ALSA vs Wine sound discussion
by Molle Bestefich Dec. 27, 2006

Dec. 27, 2006

Adding a data point to the ALSA and Wine sound discussion. ALSA has a general problem with: * Doubling volume * Playing sound bites two times when it doesn't receive data fast enough from an application. I tried playing a video file over a network using a non-wine player, then paused the network stream. The sound paused. Then restarted the network stream. The volume now doubles for the next sound bite (always), and the next sound bite is played twice (sometimes). So, just in case anyone is hearing the above two effects, they may actually be bugs in ALSA occuring when samples are delivered slower than expected, rather than bugs in Wine.

2 1

make test failure
by Kai Blin Dec. 27, 2006

Dec. 27, 2006

Hi folks, over christmas, I decided to give make test another try. I'm running this on an openSUSE 10.1 box, ati radeon mobility x300 with open source drivers. (Probably unimportant for the errors I'm getting) My procedure to get the tests setup were: export WINEPREFIX=~/.wine-test rm -rf $WINEPREFIX wineprefixcreate winecfg (set to emulate virtual desktop, nothing else touched) make test This fails in user32, with the attached error message: Any thoughts? Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 3

Re: ole32: Marshal the ORPCTHAT structure prefixed to the server data.
by Dmitry Timoshkov Dec. 27, 2006

Dec. 27, 2006

"Robert Shearman" <rob(a)codeweavers.com> wrote: > + *hook_count = 0; > + *extension_count = 0; > + > + EnterCriticalSection(&csChannelHook); > + > + LIST_FOR_EACH_ENTRY(entry, &channel_hooks, struct channel_hook_entry, entry) > + (*hook_count)++; > + > + if (hook_count) > + *data = HeapAlloc(GetProcessHeap(), 0, *hook_count * sizeof(struct channel_hook_buffer_data)); > + else > + *data = NULL; Perhaps 'if (hook_count)' should be 'if (*hook_count)' ? Is that a typo? -- Dmitry.

2 1

Re: oleaut32: Fix failing VarMod tests in WinXP, fix VarMod(VT_DECIMAL) in Wine
by Robert Shearman Dec. 27, 2006

Dec. 27, 2006

a_villacis(a)palosanto.com wrote: > In a preparation for a possible implementation of IDispatch > tests in oleaut32, I decided to clean up the failing tests in > Windows XP: > Great, thanks for fixing this. I was about to do this myself. It's about time we get the number of failing tests on XP as close to zero as possible. -- Rob Shearman

3 2

Re: [Winmm/winealsa] Don't use asynchronous callbacks in dsound any more
by Eric Pouech Dec. 26, 2006

Dec. 26, 2006

Maarten, nice work on Alsa (which is definitively needed !!) a couple of comments: - I know the winmm code (and drivers) is crippled by bad synchronisation tricks (like cleaning a field in a structure to signal a thread). This is bad (TM). So I'd suggest using here a real synchronisation object. - I wonder if it's a good idea to create another thread for this... but before merging all existing drivers' threads into a single one, I'd suggest using the fd oriented functions & poll (see snd_pcm_poll_descriptors and friends) instead of snd_pcm_wait, that'll ease up the future work. Maarten Lankhorst a écrit : > Instead of using asynchronous callbacks that uses signals, use a > seperate thread that can be cancelled, this prevents deadlock issues. > > Basically we use snd_pcm_wait() that tells us when enough room is free > to commit another buffer, then we commit the previous buffer and make > the next buffer ready. > > Since snd_pcm_wait() uses poll(), we don't have signals in winealsa > any more. > ------------------------------------------------------------------------ > > diff --git a/dlls/winmm/winealsa/audio.c b/dlls/winmm/winealsa/audio.c > index 6043680..e1676ed 100644 > --- a/dlls/winmm/winealsa/audio.c > +++ b/dlls/winmm/winealsa/audio.c > @@ -6,6 +6,7 @@ > * Copyright 2002 Eric Pouech > * 2002 Marco Pietrobono > * 2003 Christian Costa : WaveIn support > + * 2006 Maarten Lankhorst > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -70,11 +71,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(wave); > > #ifdef HAVE_ALSA > > -/* internal ALSALIB functions */ > -/* FIXME: we shouldn't be using internal functions... */ > -snd_pcm_uframes_t _snd_pcm_mmap_hw_ptr(snd_pcm_t *pcm); > - > - > /* state diagram for waveOut writing: > * > * +---------+-------------+---------------+---------------------------------+ > @@ -2627,7 +2623,6 @@ #undef EXIT_ON_ERROR > snd_pcm_hw_params_free(wwo->hw_params); > wwo->hw_params = hw_params; > > - > return wodNotifyClient(wwo, WOM_OPEN, 0L, 0L); > > errexit: > @@ -3045,11 +3040,8 @@ struct IDsDriverBufferImpl > DWORD mmap_buflen_bytes; > snd_pcm_uframes_t mmap_buflen_frames; > snd_pcm_channel_area_t * mmap_areas; > - snd_async_handler_t * mmap_async_handler; > snd_pcm_uframes_t mmap_ppos; /* play position */ > - > - /* Do we have a direct hardware buffer - SND_PCM_TYPE_HW? */ > - int mmap_mode; > + HANDLE mmap_thread; > }; > > static void DSDB_CheckXRUN(IDsDriverBufferImpl* pdbi) > @@ -3076,71 +3068,66 @@ static void DSDB_CheckXRUN(IDsDriverBuff > } > } > > -static void DSDB_MMAPCopy(IDsDriverBufferImpl* pdbi, int mul) > +/** > + * The helper thread for DirectSound > + * > + * Basically it does an infinite loop until it is told to die > + * > + * snd_pcm_wait() is a call that polls the sound buffer and waits > + * until there is at least 1 period free before it returns. > + * > + * We then commit the buffer filled by the owner of this > + * IDSDriverBuffer */ > +static DWORD CALLBACK DBSB_MMAPStart(LPVOID data) > { > + IDsDriverBufferImpl* pdbi = (IDsDriverBufferImpl*)data; > WINE_WAVEDEV * wwo = &(WOutDev[pdbi->drv->wDevID]); > - snd_pcm_uframes_t period_size; > - snd_pcm_sframes_t avail; > - int err; > - int dir=0; > - > + snd_pcm_uframes_t frames, wanted, ofs; > const snd_pcm_channel_area_t *areas; > - snd_pcm_uframes_t ofs; > - snd_pcm_uframes_t frames; > - snd_pcm_uframes_t wanted; > > - if ( !pdbi->mmap_buffer || !wwo->hw_params || !wwo->pcm) > - return; > - > - err = snd_pcm_hw_params_get_period_size(wwo->hw_params, &period_size, &dir); > - avail = snd_pcm_avail_update(wwo->pcm); > + TRACE("\n"); > > - DSDB_CheckXRUN(pdbi); > - > - TRACE("avail=%d, mul=%d\n", (int)avail, mul); > - > - frames = pdbi->mmap_buflen_frames; > - > - EnterCriticalSection(&pdbi->mmap_crst); > + if (areas != pdbi->mmap_areas || areas->addr != pdbi->mmap_areas->addr) > + FIXME("Can't access sound driver's buffer directly.\n"); > > - /* we want to commit the given number of periods, or the whole lot */ > - wanted = mul == 0 ? frames : period_size * 2; > + while (pdbi->mmap_thread) > + { > + snd_pcm_wait(wwo->pcm, -1); > + wanted = frames = pdbi->mmap_buflen_frames; > + DSDB_CheckXRUN(pdbi); > > - snd_pcm_mmap_begin(wwo->pcm, &areas, &ofs, &frames); > - if (areas != pdbi->mmap_areas || areas->addr != pdbi->mmap_areas->addr) > - FIXME("Can't access sound driver's buffer directly.\n"); > - > - /* mark our current play position */ > - pdbi->mmap_ppos = ofs; > - > - if (frames > wanted) > - frames = wanted; > - > - err = snd_pcm_mmap_commit(wwo->pcm, ofs, frames); > - > - /* Check to make sure we committed all we want to commit. ALSA > - * only gives a contiguous linear region, so we need to check this > - * in case we've reached the end of the buffer, in which case we > - * can wrap around back to the beginning. */ > - if (frames < wanted) { > - frames = wanted -= frames; > + EnterCriticalSection(&pdbi->mmap_crst); > snd_pcm_mmap_begin(wwo->pcm, &areas, &ofs, &frames); > snd_pcm_mmap_commit(wwo->pcm, ofs, frames); > - } > > - LeaveCriticalSection(&pdbi->mmap_crst); > + /* mark our current play position */ > + pdbi->mmap_ppos = ofs; > + > + /* Check to make sure we committed all we want to commit. ALSA > + * only gives a contiguous linear region, so we need to check this > + * in case we've reached the end of the buffer, in which case we > + * can wrap around back to the beginning. */ > + if (frames < wanted) { > + frames = wanted - frames; > + snd_pcm_mmap_begin(wwo->pcm, &areas, &ofs, &frames); > + snd_pcm_mmap_commit(wwo->pcm, ofs, frames); > + } > + LeaveCriticalSection(&pdbi->mmap_crst); > + } > + TRACE("Destroyed MMAP thread\n"); > + return 0; > } > > -static void DSDB_PCMCallback(snd_async_handler_t *ahandler) > +/** > + * Cancel running MMAP thread */ > +static void DBSB_MMAPStop(IDsDriverBufferImpl* This) > { > - int periods; > - /* snd_pcm_t * handle = snd_async_handler_get_pcm(ahandler); */ > - IDsDriverBufferImpl* pdbi = snd_async_handler_get_callback_private(ahandler); > - TRACE("callback called\n"); > - > - /* Commit another block (the entire buffer if it's a direct hw buffer) */ > - periods = pdbi->mmap_mode == SND_PCM_TYPE_HW ? 0 : 1; > - DSDB_MMAPCopy(pdbi, periods); > + HANDLE Thread; > + TRACE("Destroying MMAP thread\n"); > + if (This->mmap_thread == NULL) return; > + Thread = This->mmap_thread; > + This->mmap_thread = NULL; > + WaitForSingleObject(Thread, INFINITE); > } > > /** > @@ -3158,21 +3145,47 @@ static int DSDB_CreateMMAP(IDsDriverBuff > unsigned int bits_per_sample; > unsigned int bits_per_frame; > int err; > + int mmap_mode; > + > + mmap_mode = snd_pcm_type(wwo->pcm); > + pdbi->mmap_thread = NULL; > + > + /* If we have a software buffer, change buffer size to only get 2 > + * > + * Why 2? We want a small number so that we don't get ahead of the > + * DirectSound mixer. But we don't want to ever let the buffer get > + * completely empty - having 2 periods gives us time to commit another > + * period when the first expires. > + * > + * The potential for buffer underrun is high, but that's the reality > + * of using a translated buffer (the whole point of DirectSound is > + * to provide direct access to the hardware). > + */ > > - err = snd_pcm_hw_params_get_format(wwo->hw_params, &format); > - err = snd_pcm_hw_params_get_buffer_size(wwo->hw_params, &frames); > - err = snd_pcm_hw_params_get_channels(wwo->hw_params, &channels); > - bits_per_sample = snd_pcm_format_physical_width(format); > - bits_per_frame = bits_per_sample * channels; > - pdbi->mmap_mode = snd_pcm_type(wwo->pcm); > - > - if (pdbi->mmap_mode == SND_PCM_TYPE_HW) { > + if (mmap_mode == SND_PCM_TYPE_HW) { > TRACE("mmap'd buffer is a hardware buffer.\n"); > } > else { > + snd_pcm_uframes_t psize; > + err = snd_pcm_hw_params_get_period_size(wwo->hw_params, &psize, NULL); > + /* Set only a buffer of 2 period sizes, to decrease latency */ > + if (err >= 0) > + err = snd_pcm_hw_params_set_buffer_size_near(wwo->pcm, wwo->hw_params, &psize); > + > + > + psize *= 2; > + if (err < 0) { > + ERR("Errno %d (%s) occured when setting buffer size\n", err, strerror(errno)); > + } > TRACE("mmap'd buffer is an ALSA emulation of hardware buffer.\n"); > } > > + err = snd_pcm_hw_params_get_format(wwo->hw_params, &format); > + err = snd_pcm_hw_params_get_buffer_size(wwo->hw_params, &frames); > + err = snd_pcm_hw_params_get_channels(wwo->hw_params, &channels); > + bits_per_sample = snd_pcm_format_physical_width(format); > + bits_per_frame = bits_per_sample * channels; > + > if (TRACE_ON(wave)) > ALSA_TraceParameters(wwo->hw_params, NULL, FALSE); > > @@ -3208,19 +3221,13 @@ static int DSDB_CreateMMAP(IDsDriverBuff > InitializeCriticalSection(&pdbi->mmap_crst); > pdbi->mmap_crst.DebugInfo->Spare[0] = (DWORD_PTR)"WINEALSA_mmap_crst"; > > - err = snd_async_add_pcm_handler(&pdbi->mmap_async_handler, wwo->pcm, DSDB_PCMCallback, pdbi); > - if ( err < 0 ) > - { > - ERR("add_pcm_handler failed. reason: %s\n", snd_strerror(err)); > - return DSERR_GENERIC; > - } > - > return DS_OK; > } > > static void DSDB_DestroyMMAP(IDsDriverBufferImpl* pdbi) > { > TRACE("mmap buffer %p destroyed\n", pdbi->mmap_buffer); > + DBSB_MMAPStop(pdbi); > pdbi->mmap_areas = NULL; > pdbi->mmap_buffer = NULL; > pdbi->mmap_crst.DebugInfo->Spare[0] = 0; > @@ -3254,6 +3261,7 @@ static ULONG WINAPI IDsDriverBufferImpl_ > > if (refCount) > return refCount; > + IDsDriverBuffer_Stop(iface); > if (This == This->drv->primary) > This->drv->primary = NULL; > DSDB_DestroyMMAP(This); > @@ -3372,29 +3380,13 @@ static HRESULT WINAPI IDsDriverBufferImp > err = snd_pcm_prepare(wwo->pcm); > state = snd_pcm_state(wwo->pcm); > } > - if ( state == SND_PCM_STATE_PREPARED ) > + if ( state == SND_PCM_STATE_PREPARED && This->mmap_thread == NULL) > { > - /* If we have a direct hardware buffer, we can commit the whole lot > - * immediately (periods = 0), otherwise we prime the queue with only > - * 2 periods. > - * > - * Why 2? We want a small number so that we don't get ahead of the > - * DirectSound mixer. But we don't want to ever let the buffer get > - * completely empty - having 2 periods gives us time to commit another > - * period when the first expires. > - * > - * The potential for buffer underrun is high, but that's the reality > - * of using a translated buffer (the whole point of DirectSound is > - * to provide direct access to the hardware). > - * > - * A better implementation would use the buffer Lock() and Unlock() > - * methods to determine how far ahead we can commit, and to rewind if > - * necessary. > - */ > - int periods = This->mmap_mode == SND_PCM_TYPE_HW ? 0 : 2; > - > - DSDB_MMAPCopy(This, periods); > - err = snd_pcm_start(wwo->pcm); > + err = snd_pcm_start(wwo->pcm); > + This->mmap_thread = CreateThread(NULL, 0, DBSB_MMAPStart, (LPVOID)(DWORD)This, 0, NULL); > + if (This->mmap_thread == NULL) > + return DSERR_GENERIC; > + SetThreadPriority(This->mmap_thread, THREAD_PRIORITY_TIME_CRITICAL); > } > return DS_OK; > } > @@ -3419,6 +3411,8 @@ static HRESULT WINAPI IDsDriverBufferImp > return DS_OK; > } > > + DBSB_MMAPStop(This); > + > if ( ( err = snd_pcm_drop(wwo->pcm)) < 0 ) > { > ERR("error while stopping pcm: %s\n", snd_strerror(err)); > > ------------------------------------------------------------------------ > > >

2 2

window managment bug
by Clinton Stimpson Dec. 26, 2006

Dec. 26, 2006

Does bug #6006 fall under window management? When buttons are turned invisible, the invalidated area in the parent window is not repainted, so it looks like the button is still there. Also, there's two invisible buttons that seem to repaint themselves when the parent window resizes, clicking on them does nothing. Any ideas where I can go to track this down? Thanks, Clinton

1 0

Re: oleaut32: preliminary support for VT_DISPATCH as parameters to VarAdd (and other 2-operand operations) (try 3)
by Alexandre Julliard Dec. 26, 2006

Dec. 26, 2006

a_villacis(a)palosanto.com writes: > This is another attempt to add IDispatch support to several 2-operand > functions. Now the macro was removed and the VT_DISPATCH handling was > copied to every affected function. Thanks, it's better that way. Still, it seems to me you don't always clean the variants properly, you should do some sort of "goto end" in all cases instead of simply returning. Also renaming the function parameters in most cases is not necessary. I'd also suggest to do a separate patch for each function, especially since in some functions a bit of restructuring will be needed to cleanup properly on error. -- Alexandre Julliard julliard(a)winehq.org

1 0

dlls/kernel32/tests: test failure in locale.c
by Claudio Fontana Dec. 26, 2006

Dec. 26, 2006

Hello, while tweaking other things in kernel32, I noticed that latest version fails a test in locale.c: $ cd dlls/kernel32/tests $ make test ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so locale.c && touch locale.ok locale.c:1990: Test failed: Enumerated grp locale 1084 not valid locale.c:1990: Test failed: Enumerated grp locale 1170 not valid locale.c:1990: Test failed: Enumerated grp locale 1171 not valid locale.c:1990: Test failed: Enumerated grp locale 2108 not valid locale.c:1990: Test failed: Enumerated grp locale 3132 not valid make: *** [locale.ok] Error 5 Hope this helps. Claudio

2 1

more meaningful traces?
by Lei Zhang Dec. 26, 2006

Dec. 26, 2006

Hi, I noticed several files in dlls/winmm have a getMessage() function to translate message numbers to message names. This is extremely helpful for debug traces, where one can immediately see the name of the messages sent, instead of wondering what 0x105 is. So my question is, why is winmm the only component translating its message? Is there some downside to having message names in the traces? Happy Holidays! - Lei

1 0

Re: [2/2] wined3d: Restore texture bindings in the FBO code
by Stefan Dösinger Dec. 25, 2006

Dec. 25, 2006

Am 25.12.2006 um 17:12 schrieb H. Verbeet: > Previously all textures were (re)bound each DrawPrimitive call. With > the new state management only dirty textures are bound, so we need to > restore the texture binding if we change it. > > Changelog: > - Restore texture bindings in the FBO code > <wined3d_fbo_texture_binding.diff.txt> Why are you not using glPushAttrib / glPopAttrib?

2 1

Re: [comctl32] MonthCalendar - Fix wrong date selected when clicknext/prev months day (#6967)
by Dmitry Timoshkov Dec. 25, 2006

Dec. 25, 2006

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > - retval = *daypos + (7 * *weekpos) - firstDay; > + retval = *daypos + ((7 * *weekpos) - firstDay); > return retval; > } This change doesn't make any difference, neither in functionality, nor in readability IMO. Please avoid this kind of changes, it only clutters the patch, making it hard to see what is the real change. > - lpht->st.wDay = MONTHCAL_MonthLength(lpht->st.wMonth,lpht->st.wYear) -day; > + lpht->st.wDay = day+MONTHCAL_MonthLength(lpht->st.wMonth,lpht->st.wYear) ; A couple of spaces around '+' won't hurt, and a space before ';' doesn't match an existing code style. > - return TRUE; > + /*return TRUE;*/ If you are not sure that the return should be removed, it's a sign that you need a test case, just commenting it out without any explanation is not a solution. Same comment to all other similar cases. > + MONTHCAL_CopyTime(&infoPtr->minSel,&nmsc.stSelStart); > + MONTHCAL_CopyTime(&infoPtr->maxSel,&nmsc.stSelEnd); > nmsc.nmhdr.hwndFrom = infoPtr->hwndSelf; > nmsc.nmhdr.idFrom = GetWindowLongPtrW(infoPtr->hwndSelf, GWLP_ID); > nmsc.nmhdr.code = MCN_SELCHANGE; > - MONTHCAL_CopyTime(&infoPtr->minSel,&nmsc.stSelStart); > - MONTHCAL_CopyTime(&infoPtr->maxSel,&nmsc.stSelEnd); This change is not needed. -- Dmitry.

2 2

kernel32 (profile.c): current section and key implementation
by Claudio Fontana Dec. 25, 2006

Dec. 25, 2006

Hello all, I posted previously a patch to wine-patches here: http://www.winehq.org/pipermail/wine-patches/2006-December/034022.html However, I now understand that although it solves the issue I had with the specific program, the change is incomplete, since in several other places, sections and keys are only considered meaningful when not equal to the empty string. In the Microsoft implementation, the unnamed section is valid, as are zero length keys. Thus, I think a broader scope change is required. Before I start working on a new patch, do you acknowledge that the current implementation is incorrect, and a patch fixing it by not requiring name[0] to be != '\0' is likely to be accepted? (btw, I've noticed you switched to git, so I will be using that instead now). Thanks, Claudio Fontana

2 2

Re: ntdll: Added stubs for the Rtl*GenericTable* functions
by Vitaliy Margolen Dec. 25, 2006

Dec. 25, 2006

Is there are any reason why do you need this functions at all? According to ddk they are part of "Installable File System Drivers". This is a kernel level thing only and no user app should use these routines. Especially stabbing them won't do you any good if something actually using them. But that something has no place to run in Wine yet. Vitaliy.

2 5