March 2006 - Wine-Devel - list.winehq.org

Fwd: Hi
by Hans Leidekker March 14, 2006

March 14, 2006

Hi list, I'm forwarding a question from someone at Microsoft(!). I could recommend grep, winedump and Linux of course but I was wondering if anyone on this list has a good suggestion for this guy? Don't believe it? I didn't either, but look at the headers, this mail was accepted from a mailserver in the microsoft.com domain: Return-Path: <a-gaolap(a)microsoft.com> Received: from mail.vu.nl (IDENT:MU9AWzJpIWdhZlkI0e97gBGdUUEagQyZ(a)mail.vu.nl [130.37.129.161]) by mail.it.vu.nl (8.11.6/8.11.6) with ESMTP id k2DHsnL15211 for <hans(a)mail.it.vu.nl>; Mon, 13 Mar 2006 18:54:49 +0100 Received: from mail1.microsoft.com (mail1.microsoft.com [131.107.3.125]) by mail.vu.nl (8.11.6/8.11.6) with ESMTP id k2DHsjW13651 for <hans(a)it.vu.nl>; Mon, 13 Mar 2006 18:54:46 +0100 Received: from mailout1.microsoft.com ([157.54.1.117]) by mail1.microsoft.com with Microsoft SMTPSVC(6.0.3790.2499); Mon, 13 Mar 2006 09:54:41 -0800 Received: from RED-MSG-50.redmond.corp.microsoft.com ([157.54.61.146]) by mailout1.microsoft.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 13 Mar 2006 09:54:41 -0800 And here's the line from our mailserver log: Mar 13 18:54:46 nath sendmail[13651]: k2DHsjW13651: from=<a-gaolap(a)microsoft.com>, size=6136, class=0, nrcpts=1, msgid=<22DDEC51216B404E8C056F8F5198E9270616976E(a)RED-MSG-50.redmond.corp.microsof…>, proto=ESMTP, daemon=MTA, relay=mail1.microsoft.com [131.107.3.125] -Hans ---------- Forwarded Message ---------- Subject: Hi Date: Monday 13 March 2006 18:54 From: "Gaolai Peng \(Volt\)" <a-gaolap(a)microsoft.com> To: hans(a)it.vu.nl Hi Hans, My name is Gaolai. I am working on antivirus software for MS exchange. One of our customers gets following error when he opened our product, "the ordinal 319 could not be located in the Dynamic link library wldap32.dll, "initialization of dll msrd2x40.dll terminated". For sure our product doesn't need ordinal 319, ldap_create_vlv_control. His environment is NT 4.0 SP 6. I looked up the msdn, func ldap_create_vlv_control requires Windows Vista or Windows XP. So I figured the user must have installed some software that needs at least XP or Vista? >From http://source.winehq.org/source/ChangeLog, I found out you were the first person who implemented this function. Can you give some suggestion about how do I find out what software needs ordinal 319? What I am supposed to do to fix this without suggesting the user to install XP? Thanks. Gaolai -------------------------------------------------------

2 1

Re: wglMakeCurrent
by Wino Rojo March 13, 2006

March 13, 2006

Hi guys, Thanks a lot for all your replies... After further inspection, it seems the problem is when I try to share display lists from one context to another. I've attached the program and the source code, so you can try it. As you can see, I first create a context and then I create a second context but sharing the display lists of the first one. If you run this program, you'll see the BadMatch error I was reporting in my first email. However, if you don't share display lists (that is, change the line Context.Create(0, 0, true) to Context.Create(0, 0, false)), everything works ok. Jesse, I've made the changes proposed in those patches, but it didn't work :-( By the way, I'm using wine .9.9. Cheers, Wino _________________________________________________________________ MSN® Calendar keeps you organized and takes the effort out of scheduling get-togethers. http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht… Start enjoying all the benefits of MSN® Premium right now and get the first two months FREE*.

1 0

wglMakeCurrent
by Wino Rojo March 13, 2006

March 13, 2006

Hi I'm pretty new to wine, and this is my first post to the wine-devel list....I hope this is the correct place to send my question I'm having problems with wglMakeCurrent. I wrote a small OpenGL test program, but it's not working under wine (it works perfectly on Windows). When I call wglMakeCurrent, wine outputs this error: X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 144 (GLX) Minor opcode of failed request: 5 (X_GLXMakeCurrent) Serial number of failed request: 120 Current serial number in output stream: 120 I activated the debug output for opengl, and I can see that the problem is a mismatch between the default visual ID and my program visual ID. At the top of the debug output, I see this: trace:opengl:X11DRV_setup_opengl_visual Visual ID 21 Chosen and later, when I create my OpenGl context: trace:opengl:X11DRV_SetPixelFormat - VISUAL_ID 0x23 Obviously, the problem is that my visual ID doesn't match with the X-Window's default, but I need to work using my visual (because I need alpha planes) Any known workaround or is this a bug on wine's implementation of wglMakeCurrent? Thanks Wino _________________________________________________________________ Take advantage of powerful junk e-mail filters built on patented Microsoft® SmartScreen Technology. http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=ht… Start enjoying all the benefits of MSN® Premium right now and get the first two months FREE*.

4 3

Re: x11drv: One more fix for "stuck" ctrl, shift & alt.
by Vitaliy Margolen March 13, 2006

March 13, 2006

Anything wrong with this patch? It does fix the "stuck alt" problem for games I use alt+tab on. Vitaliy Margolen Tuesday, February 21, 2006, 10:30:39 PM, Vitaliy Margolen wrote: > ChangeLog: > x11drv: One more fix for "stuck" ctrl, shift & alt. > DInput needs scan code with each event - make sure we send one. > Also don't loose key state change events in mouse.c > I tested this with Keyboard DInput sample from DXSDK. It clearly showed > that we are loosing these events when focus is being changed. > dlls/x11drv/keyboard.c | 10 +++++----- > dlls/x11drv/mouse.c | 6 ++++-- > dlls/x11drv/x11drv.h | 2 ++ > 3 files changed, 11 insertions(+), 7 deletions(-)

3 2

Re: dlls: Move the call to MODULE_DllThreadAttach from kernel32 code to NTDLL code
by Alexandre Julliard March 13, 2006

March 13, 2006

Robert Shearman <rob(a)codeweavers.com> writes: > ChangeLog: > Move the call to MODULE_DllThreadAttach from kernel32 code to NTDLL code. The problem with this is that the call is no longer inside the exception handler, so it would prevent debugging crashes that happen during thread attach. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: Can't run DirectX games on x86_64 biarch Linux
by Jason Green March 13, 2006

March 13, 2006

On 3/8/06, Willie Sippel <willie(a)zeitgeistmedia.net> wrote: > [...] > I also build Wine on an amd64 system (running gentoo/ amd64), no problems. But > there's one thing I noticed a while ago: Wine continues to compile and > install even if some of the DLLs won't compile. I had this a few times in the > past, and ended up with a basically working Wine install that missed a few > DLLs, mostly OpenGL-related stuff. Maybe something like that happens to you? > Just check that all DLLs are built and in place, and make sure there were no > errors during compile (like I said, with some DLLs, Wine just continues to > build even though errors appear)... Correct, wine will compile and run without a lot of features and never warn you that they don't exist. See this wiki page for an example of what your include/config.h file should probably look like: http://wiki.winehq.org/Recommended_Packages I just added the Fedora Core 5 and Ubuntu Dapper sections yesterday, and I believe that they are at least 95% accurate, although I might have missed one somewhere. If someone can add the package names required for a gentoo build (or possibly create and maintain wine-cvs packages with all of the necessary deps???), it would probably help out many users trying to compile from source.

3 2

Re: GDI32: using the embeded bitmap in antialias mode
by Byeong-Sik Jeon March 12, 2006

March 12, 2006

2006-03-13 (월), 04:10 +0900, Byeong-Sik Jeon 쓰시길: > If format == WINE_GGO_GRAY16_BITMAP at the "WineEngGetGlyphOutline()", > set on "FT_LOAD_NO_BITMAP". > I mistake. When format == WINE_GGO_GRAY16_BITMAP, skip that set on "FT_LOAD_NO_BITMAP".

1 0

ddraw design flaw
by Tomas Carnecky March 12, 2006

March 12, 2006

I have found a design flaw in ddraw and described it in my 'World of Warcraft 0.10 Public Test Real (PTR)' thread. Why has nobody adressed this issue? In my eyes it is a severe design flaw if an application can't unload ddraw.dll without side effects (especially if this side-effect is that all opengl/directx applications are unusable after that). So please, will someone explain me why nobody wants to fix this? It's nothing bad now, but if WoW still loads Survey.dll (and thus ddraw.dll) in the final public release many people will demand a fix. Very few people play on the PTR, but there are quite a lot who play WoW under wine.. and they will not be happy if they can't play anymore. tom

2 2

Re: [Bugzilla] Add note to not paste logs and back traces.
by Rein Klazes March 12, 2006

March 12, 2006

On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: >Change Log: Add note to attach and not paste logs and back traces. > >Files changed: template/en/default/bug/edit.html.tmpl >template/en/default/bug/create/create.html.tmpl Not pasting back traces will make following the bug list by email rather useless. IMO what people are currently posting in bugzilla do not require such recommendations. Rein.

5 6

RFC: Make SetThreadContext work properly
by Dimi Paun March 12, 2006

March 12, 2006

Hi Alexandre, >From a quick look at the code, it seems that you've already fixed the problem addressed by Mike's patch: http://wiki.winehq.org/Make_SetThreadContext_work_properly revision 1.53 date: 2006/01/11 20:36:17; author: julliard; state: Exp; lines: +38 -24 Alexandre Julliard <julliard(a)winehq.org> ntdll: Handle NtSetContextThread on the client side (as far as possible) when setting the context of the current thread. Just checking so I can remove the patch from the wiki if it's no longer relevant. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

My guess why Munich doesn't like Wine
by Dan Kegel March 12, 2006

March 12, 2006

After poking at the apps they tested with, the conclusion is: they wanted something that could run Access and Oracle client apps, and Wine just wasn't there yet. It still isn't, judging by my quick tests. Given that the world kind of treats this as a must, perhaps it could be added as a criterion for a 1.0 release. Say, where's the existing page describing our release criteria? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Oracle Express Client under Wine - install fails in advapi.CreateService
by Dan Kegel March 12, 2006

March 12, 2006

At the risk of posting too much information, here's another roadblock faced by an important potential user. keeptool.com's hora.exe (one of the apps needed by the european government desktop migration) is an Oracle DBA helper tool, and testing it means connecting to an Oracle database. That means, I think, installing the Oracle client library under Wine. Sadly, this fails during install; the installer claims that advapi.CreateService is crashing. ( See http://bugs.winehq.org/show_bug.cgi?id=4802 ) Somebody with a little free time could probably learn more by adding more trace statements in CreateService. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

spss can't even install...
by Dan Kegel March 12, 2006

March 12, 2006

I heard that SPSS was one of the apps governments like (so they crunch statistics -- who knew? :-), so I tried running the free eval. It wouldn't even install. The problems were already described in http://bugs.winehq.org/show_bug.cgi?id=4700 Looks like an msi problem, but there might be something more general wrong; all wine apps hang for about twenty seconds at a certain point during the install, which is pretty strange. - Dan p.s. one downside of using wine to run firefox as your main browser is it's a bit more dangerous to do the rm -rf ~/.wine needed to do a really clean install of a test app :-) so this test was done with a fairly cluttered fake wine directory. But it seems to match the results in the PR. -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

"IE5 or higher required". Grr.
by Dan Kegel March 11, 2006

March 11, 2006

I heard KeepTool was an app used by some government developers, so I tried installing the free trial from http://keeptool.com. Sadly, the installer complained I needed IE5 or later. The registry key trick I've been using, [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" didn't seem to do the trick this time. Any suggestions on how to get past that? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 8

Can't run DirectX games on x86_64 biarch Linux
by Christian Schneider March 11, 2006

March 11, 2006

Hi all. About half a year ago I replaced my old desktop by an AMD64 box and my previous x86 Linux from Scratch (LFS) installation by a x86_64 multilib LFS. And since then I'm not able to run any DirectX title anymore that used to work before. This is the way I usually compile wine (GCC 3.4.4): ./configure --prefix=/opt/wine-CVS20060307 \ --x-libraries=/usr/X11R6/lib && make depend && make && su -c "make install" Here are some games that used to work on my old LFS, their behaviour and the error messages. I've also attached a short log of each game to this messages. All these logs have been recorded with the CVS version of wine from 2006/03/05. Age of Empires 2 starts up, I can hear sound. When I click on "Single Player", the game hangs with the following message: err:seh:setup_exception stack overflow 24 bytes in thread 0009 eip 55726262 esp 55ca0fe8 stack 0x55ca1000-0x55db0000 Backgammon Pro is an older (7 years or so) backgammon game, quite simple and 2D, but uses DirectDraw. It crashes at startup: err:ntdll:RtlpWaitForCriticalSection section 0x5574d040 "directory.c: dir_section" wait timed out in thread 000b, blocked by 000c, retrying (60 sec) err:seh:raise_exception Unhandled exception code c0000194 flags 0 addr 0x55701230 Diablo 2 VidTest (D2VidTest.exe) runs fine and suggests Direct3D for rendering. When I click on the ok-button to quit, it keeps hanging: err:ntdll:RtlpWaitForCriticalSection section 0x6ffa0730 "?" wait timed out in thread 0009, blocked by 000a, retrying (60 sec) Diablo 2 crashes at startup after some time: err:ntdll:RtlpWaitForCriticalSection section 0x5574d6c0 "virtual.c: csVirtual" wait timed out in thread 0010, blocked by 0000, retrying (60 sec) err:seh:raise_exception Unhandled exception code c0000194 flags 0 addr 0x55701230 Half-Life crashes at startup: err:seh:setup_exception nested exception on signal stack in thread 0009 eip 55725f43 esp 55589c90 stack 0x55ca1000-0x55db0000 Monkey Island 4 (OpenGL-mode) crashes at startup: err:seh:setup_exception stack overflow 240 bytes in thread 0009 eip 557013e6 esp 55ca0f10 stack 0x55ca1000-0x55db0000 StarCraft starts to the title menu, but clicking on "Single Player" crashes it: err:seh:setup_exception stack overflow 276 bytes in thread 0009 eip 557013e6 esp 55ca0eec stack 0x55ca1000-0x55db0000 WarCraft 3 (OpenGL-mode) doesn't show up anything, just hangs silently. As you can see, the most common errors are err:seh:setup_exception and err:ntdll:RtlpWaitForCriticalSection. I've also done some more tests with other games like Revolt, Anno 1503, Half-Life 2, and the errors all look alike. I have tried the following things to solve the problem: * Deleted my ~/.wine, over and over again ;-) * Compiled wine without any optimization flags * Compiled wine on a x86 Debian box and copied the installation over * Copied my ~/.wine to that Debian box, where most of the games run fine * Tried different wine versions, starting with pre-0.9 versions, ending with the latest CVS version * Used winetools to setup an environment with many native DLLs. Installation of most of the software including IE worked fine, but did not help though. * Searched this mailing list archive and the web for similar errors Something is definitely going wrong with this. Anybody an idea? I would appreciate any help. Cheers, Christian Schneider

4 7

GL_STENCIL-related build failures in dlls/wined3d/device.c
by Gerald Pfeifer March 11, 2006

March 11, 2006

The recent changes to dlls/wined3d/device.c cause the following build failures for me on FreeBSD 5.4, though I assume this is in fact not related to FreeBSD but to xorg 6.8.2 or libglut 6.4.1 on this system. device.c: In function `IWineD3DDeviceImpl_SetRenderState': device.c:3776: error: `GL_STENCIL_BACK_FAIL' undeclared (first use in this function) device.c:3776: error: (Each undeclared identifier is reported only once device.c:3776: error: for each function it appears in.) device.c:3777: error: `GL_STENCIL_BACK_PASS_DEPTH_FAIL' undeclared (first use in this function) device.c:3778: error: `GL_STENCIL_BACK_PASS_DEPTH_PASS' undeclared (first use in this function) gmake[2]: *** [device.o] Error 1 gmake[2]: Leaving directory `/.amd_mnt/nashira/files5/test/wine/dlls/wined3d' gmake[1]: *** [wined3d] Error 2 The most straightforward patch would be the one below, but it leaves three "variable may be used uninitialized" warnings in the first of the two affected spots. Gerald Index: device.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/device.c,v retrieving revision 1.145 diff -u -3 -p -r1.145 device.c --- device.c 4 Mar 2006 17:10:57 -0000 1.145 +++ device.c 5 Mar 2006 08:35:52 -0000 @@ -3226,9 +3226,15 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetRen GLint action = StencilOp(Value); +#ifdef GL_STENCIL_FAIL glGetIntegerv(GL_STENCIL_FAIL, &stencilFail); +#endif +#ifdef GL_STENCIL_PASS_DEPTH_FAIL glGetIntegerv(GL_STENCIL_PASS_DEPTH_FAIL, &depthFail); +#endif +#ifdef GL_STENCIL_PASS_DEPTH_PASS glGetIntegerv(GL_STENCIL_PASS_DEPTH_PASS, &stencilPass); +#endif if(WINED3DRS_STENCILFAIL == State) { stencilFail = action; @@ -3773,9 +3779,15 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetRen GLint action = StencilOp(Value); +#ifdef GL_STENCIL_BACK_FAIL glGetIntegerv(GL_STENCIL_BACK_FAIL, &stencilFail); +#endif +#ifdef GL_STENCIL_BACK_PASS_DEPTH_FAIL glGetIntegerv(GL_STENCIL_BACK_PASS_DEPTH_FAIL, &depthFail); +#endif +#ifdef GL_STENCIL_BACK_PASS_DEPTH_PASS glGetIntegerv(GL_STENCIL_BACK_PASS_DEPTH_PASS, &stencilPass); +#endif if(WINED3DRS_CCW_STENCILFAIL == State) { stencilFail = action;

1 1

AlphaImageLoader - tranparent pngs 4 IE
by Axel Huizinga March 10, 2006

March 10, 2006

Hi! Did anybody get DXImageTransform.AlphaImageLoader working to render transparent png in IE on wine? Cordially, Axel

4 3

Re: winegdb: Fix crash in empty first command
by Eric Pouech March 10, 2006

March 10, 2006

Vitor T. Sessak wrote: > 2006/3/7, Eric Pouech > >> >> 2006/3/6, Vitor T. Sessak <vitor.sessak at m4x.org >> <http://www.winehq.org/mailman/listinfo/wine-patches>>: >> >>> / > > />>/ Changelog: > />>/ winegdb: Fix crash in empty first command > />>/ > />>/ Winedbg crashes when pressing enter as its first command. > /> > >> >> this is wrong as the last_line will be HeapFree'd when the next >> command is >> keyed in. > > > You are right. I've changed it and fixed the FIXME too. your new code leaks the lines (you never free them) A+ -- Eric Pouech

1 1

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT
by Alexandre Julliard March 10, 2006

March 10, 2006

Lei Zhang <leiz(a)ucla.edu> writes: > --- dlls/riched20/editstr.h 2 Mar 2006 11:18:19 -0000 1.27 > +++ dlls/riched20/editstr.h 5 Mar 2006 06:36:50 -0000 > @@ -29,6 +29,7 @@ > #include <stdarg.h> > #include <stdio.h> > #include <stdlib.h> > +#include <wctype.h> You can't use anything from wctype.h in Wine. Use the functions from wine/unicode.h instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WINED3D: Color fixups for vertex shaders
by Roderick Colenbrander March 10, 2006

March 10, 2006

> Direct3D stores vertex color data in BGRA order, OpenGL stores it in > RGBA order. This causes red and blue to be swapped in d3d applications > when run under wine. This patch fixes this problem for vertex shaders > by enabling the flag that causes red and blue to be swapped in > vshader_program_add_input_param_swizzle, when appropriate. > > Changelog: > - Enable color fixups for vertex shaders > In my local tree I have some simple d3d8 shaders working. (See for instance http://roderick.student.utwente.nl/dolphin1.png and dolphin2.png on windows; there's some color issue but apart from that it works). This patch causes in combination with the other vshader patch you sent some drawing issues. Check http://roderick.student.utwente.nl/dolphin3.png Regards, Roderick -- "Feel free" mit GMX FreeMail! Monat f�r Monat 10 FreeSMS inklusive! http://www.gmx.net

2 5

DDraw->WineD3D refcounting hack
by Stefan Dösinger March 10, 2006

March 10, 2006

Hello, I have a a question regarding some code that might be rejected by Alexandre when I submit it. The problem is that I have to do an refcount hack in my new ddraw code to destroy textures properly. I CC this mail to AJ because it's him who has the last word ;) WineD3D and Direct3D7 have different ideas about handling mipmap textures. In d3d7 they are complex surfaces - a bunch of surfaces with a root and sublevels. All surfaces in the compound have their own refcount, but they are all destroyed when the root is destroyed. In WineD3D there's the texture as a container, and the surfaces in the container have their refcount linked to the container(See the patch H. Verbeet sent a few days ago). In d3d7 the application destroys the first surface to release the whole texture. My first idea was to Release the WineD3DTexture. It would then call the Release method of all the sublevel ddraw surfaces, which would destroy them. This works for a correctly written application, but applications call GetAttachedSurface for the sublevels, which addrefs, and many do not Release the sublevels after GetAttachedSurface(). This leaves the sublevel surfaces with a refcount of 2 or more when the root is destroyed. To make sure that they are destroyed, I set their refcount to 1 when the root is destroyed. When the last reference to the WineD3D Texture is released, wineD3D will destroy the sublevel surfaces. Is such a thing acceptable for Wine? Does anyone have a better solution? If you need some code to look at, I'll upload an updated patch to my homepage later. Thanks, Stefan

2 2

Trying to fix bug 2400 - delete and comma
by agaro agaro March 10, 2006

March 10, 2006

Hi all, I'm trying to fix bug 2400 - removes one char and puts comma simultaneously. My guess: this old bug is in dlls/x11drv/keyboard.c or dlls/user/message.c, something about dead keys implementation. Can somebody help me with a little explanation or documentation? I don't know what scancode, keycode and vkey mean. Thanks, agaro

4 4

Re: Use a property for the colour dialog's information.
by Robert Shearman March 10, 2006

March 10, 2006

Mike McCormack wrote: >@@ -1217,7 +1220,7 @@ static INT_PTR CALLBACK ColorDlgProc( HW > DeleteDC(lpp->hdcMem); > DeleteObject(lpp->hbmMem); > HeapFree(GetProcessHeap(), 0, lpp); >- SetWindowLongPtrW(hDlg, DWLP_USER, 0); /* we don't need it anymore */ >+ SetPropW( hDlg, szColourDialogProp, lpp ); > > SetPropW( hDlg, szColourDialogProp, lpp ) should be SetPropW( hDlg, szColourDialogProp, NULL ). -- Rob Shearman

2 1

Re: dinput: Create single thread for mouse and keyboard hook procs. [try 3]
by Vitaliy Margolen March 10, 2006

March 10, 2006

Any problems with this patch? I have not received any additional comments. And it does fix at least two games in question (see bug reports). And I have not seen any side-affects from it either. Vitaliy Margolen Wednesday, February 22, 2006, 8:10:16 AM, Vitaliy Margolen wrote: > ChangeLog: > dinput: Create single thread for mouse and keyboard hooks. > Put keyboard & mouse hook callbacks into separate thread. > Move few global variables into object. Delete no longer used crit section. > For hooks to work properly hook callback have to be in a thread > with message loop. Some games create separate threads just to handle > mouse and/or keyboard events that do not have message loop. This patch fixes > such games (Bug 4264) - mouse and (Bug 2981) - keyboard. > Try#2 (based on suggestions from Alexandre): > Using a message window in a dedicated thread with normal message loop. > Hooks are installed and removed using SendMessage to this window. > Only one mouse and one keyboard hook is permitted. > Hook handles are managed by dedicated thread and not given back to > caller. > Try#3 (with Robs suggestions) > Use critical section. > dlls/dinput/device.c | 132 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/dinput/device_private.h | 2 + > dlls/dinput/keyboard.c | 130 > ++++++++++++++++------------------------- > dlls/dinput/mouse.c | 33 ++++------- > 4 files changed, 195 insertions(+), 102 deletions(-)

1 0

Re: x11drv: Fix one case of "glXChooseFBConfig returns NULL" problem.
by Vitaliy Margolen March 10, 2006

March 10, 2006

Anything wrong with this patch? According to MSDN ChoosePixelFormat should pick closest mode, but not fail. Vitaliy Margolen Saturday, March 4, 2006, 10:27:11 PM, Vitaliy Margolen wrote: > ChangeLog: > x11drv: Fix one case of "glXChooseFBConfig returns NULL" problem. Using alpha bits >> 8 makes this function fail, while it should not. > dlls/x11drv/opengl.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-)

1 0