March 2006 - Wine-Devel - list.winehq.org

OLEAUT32: bug 4502 - request for comment before trying to fix
by Alex Villacís Lasso March 15, 2006

March 15, 2006

I would like to draw attention to bug 4502. This bug can cause any VB application to crash when the DatePicker control is used, and an attempt is made to assign a date value in VB code. Even though I found this bug while testing an application I wrote, this might not be specific to this application. It is only recently that I have some time to dedicate to this bug, but I would like somebody to comment on this. When the sample application is run with WINEDEBUG=ole,variant, the failing invocation looks like this: trace:ole:ITypeInfo_fnInvoke (0x7fdd5440)(0x7fd9f61c,id=20,flags=0x00000004,0x7fa3ee8c,(nil),0x7fa3ee6c,0x7fa3ee9c) trace:ole:dump_DispParms args=1 named args=1 trace:ole:dump_Variant 0x7fa3eef4->{VT_DATE(38788,0x7fa3ec7c) trace:variant:VarUdateFromDate (38788,0x00000000,0x7fa3ec36) trace:ole:dump_Variant ,2006/03/12 00:00:00} trace:ole:ITypeInfo_fnInvoke invoking: L"Value"(1) parm0: L"Value" memid is 00000014 Param 0: tdesc.vartype 12 (VT_VARIANT) u.paramdesc.wParamFlags PARAMFLAG_FIN u.paramdesc.lpex (nil) funckind: 1 (pure virtual) invkind: 4 (property put) callconv: 4 (stdcall) oVft: 224 cParamsOpt: 0 wFlags: 3c elemdescFunc (return value type): tdesc.vartype 25 (VT_HRESULT) u.paramdesc.wParamFlags PARAMFLAGS_NONE u.paramdesc.lpex (nil) helpstring: L"Returns/sets the current date." entry: (null) trace:ole:ITypeInfo_fnInvoke changing args trace:ole:dump_Variant 0x7fa3eef4->{VT_DATE(38788,0x7fa3ec7c) trace:variant:VarUdateFromDate (38788,0x00000000,0x7fa3ec36) trace:ole:dump_Variant ,2006/03/12 00:00:00} trace:variant:VariantChangeTypeEx (0x7fdd5520->(VT_DATE),0x7fa3eef4->(VT_DATE),0x00000400,0x0000,VT_VARIANT) trace:variant:VariantClear (0x7fa3ec40->(VT_EMPTY)) trace:variant:VariantClear (0x7fa3ec30->(VT_EMPTY)) trace:variant:VariantCopyInd (0x7fa3ec30->(VT_EMPTY),0x7fa3eef4->(VT_DATE)) trace:variant:VariantCopy (0x7fa3ec30->(VT_EMPTY),0x7fa3eef4->(VT_DATE)) trace:variant:VariantClear (0x7fa3ec30->(VT_EMPTY)) trace:variant:VARIANT_Coerce (0x7fa3ec40->(VT_EMPTY),0x00000400,0x0000,0x7fa3ec30->(VT_DATE),VT_VARIANT) trace:variant:VariantClear (0x7fa3ec40->(VT_EMPTY)) trace:variant:VariantClear (0x7fa3ec30->(VT_DATE)) trace:variant:VariantChangeTypeEx returning 0x80020005, 0x7fdd5520->(VT_DATE) err:ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_VARIANT from VT_DATE trace:ole:ITypeInfo_fnInvoke -- 0x80020005 The Property Put seems to be declared as taking one VT_VARIANT parameter, and the VB code supplies a VT_DATE value. Therefore, an attempt is made to coerce VT_DATE --> VT_VARIANT. However, VariantChangeTypeEx() does not support conversion of *any* kind of variant into VT_VARIANT, so the call fails, and this brings down the application. I was on half a mind to add the VT_VARIANT conversion to VariantChangeTypeEx() myself, but then I checked the tests for this operation, and it seems that the absence of support for VT_VARIANT is actually expected (unless I am misreading the code). Therefore, one of the following two things is happening: 1) There is some error in the reading of the typelib, since a Property Put should not have a VT_VARIANT parameter in the first place. 2) ITypeInfo::Invoke should do the VT_VARIANT conversion itself, precisely because VariantChangeTypeEx() won't do it. I am inclined to the second option, but I want to hear some comment before attempting to create a patch. Alex Villacís Lasso

2 3

Re: opengl32: make the old code before the "sync the dibsection to its pixmap" patch be selectable at runtime.
by Huw D M Davies March 15, 2006

March 15, 2006

On Sun, Mar 12, 2006 at 05:44:57PM +0100, Leon Freitag wrote: > The patch > http://source.winehq.org/git/?p=wine.git;a=commit;h=13268261bbe0d4013937a6a… > has introduced an annoying performance regression which affected all opengl > games. (see http://bugs.winehq.org/show_bug.cgi?id=4499) Does this help? Huw. -- Huw Davies huw(a)codeweavers.com diff --git a/dlls/opengl32/wgl.c b/dlls/opengl32/wgl.c index 56c8ad1..aecba9c 100644 --- a/dlls/opengl32/wgl.c +++ b/dlls/opengl32/wgl.c @@ -78,6 +78,7 @@ static char* internal_gl_extensions = NU typedef struct wine_glcontext { HDC hdc; + DWORD type; Display *display; XVisualInfo *vis; GLXFBConfig fb_conf; @@ -106,7 +107,7 @@ void enter_gl(void) ctx = get_context_from_GLXContext(gl_ctx); wine_tsx11_unlock_ptr(); /* unlock before calling GDI apis */ - if(ctx && GetObjectType(ctx->hdc) == OBJ_MEMDC) + if(ctx && ctx->type == OBJ_MEMDC) ExtEscape(ctx->hdc, X11DRV_ESCAPE, sizeof(escape), (LPCSTR)&escape, 0, NULL); wine_tsx11_lock_ptr(); @@ -250,6 +251,7 @@ HGLRC WINAPI wglCreateContext(HDC hdc) ret = alloc_context(); LEAVE_GL(); ret->hdc = hdc; + ret->type = GetObjectType(hdc); ret->display = display; ret->fb_conf = cur_cfg; /*ret->vis = vis;*/ @@ -673,7 +675,7 @@ BOOL WINAPI wglShareLists(HGLRC hglrc1, if (org->ctx == NULL) { ENTER_GL(); describeContext(org); - org->ctx = glXCreateContext(org->display, org->vis, NULL, GetObjectType(org->hdc) == OBJ_MEMDC ? False : True); + org->ctx = glXCreateContext(org->display, org->vis, NULL, org->type == OBJ_MEMDC ? False : True); LEAVE_GL(); TRACE(" created a delayed OpenGL context (%p) for Wine context %p\n", org->ctx, org); } @@ -681,7 +683,7 @@ BOOL WINAPI wglShareLists(HGLRC hglrc1, ENTER_GL(); describeContext(dest); /* Create the destination context with display lists shared */ - dest->ctx = glXCreateContext(org->display, dest->vis, org->ctx, GetObjectType(org->hdc) == OBJ_MEMDC ? False : True); + dest->ctx = glXCreateContext(org->display, dest->vis, org->ctx, org->type == OBJ_MEMDC ? False : True); LEAVE_GL(); TRACE(" created a delayed OpenGL context (%p) for Wine context %p sharing lists with OpenGL ctx %p\n", dest->ctx, dest, org->ctx); return TRUE;

3 5

Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef. (more better patch)
by Mike McCormack March 15, 2006

March 15, 2006

Saveliy Tretiakov wrote: > +typedef: tTYPEDEF m_attributes type pident_list { > + attr_t *a = $2; > + int public = 0; > + while(a){ > + switch(a->type) > + { > + case ATTR_CONTEXTHANDLE: > + case ATTR_STRING: > + case ATTR_HANDLE: > + case ATTR_SWITCHTYPE: > + case ATTR_TRANSMITAS: > + case ATTR_POINTERTYPE: > + case ATTR_IGNORE: > + break; > + case ATTR_PUBLIC: > + public = 1; > + break; > + default: > + yyerror("Inapplicable attribute\n"); How about changing the grammar to define something like: attributes: td_attribs | tCONTEXTHANDLE | tSTRING | ... /* other things that can't be a typedef */ ; td_attribs: tAGGREGATABLE | ... /* other things in the existing attributes rule */ ; typedef: tTYPEDEF td_attribs type pident_list .... That way the parser can deal with the problem. Mike

1 0

Re: GDI32: using the embeded bitmap in antialias mode
by Huw D M Davies March 15, 2006

March 15, 2006

On Mon, Mar 13, 2006 at 04:10:20AM +0900, Byeong-Sik Jeon wrote: > ChangeLog: > Using the embeded bitmap in the antialias mode. > > > PS2. FT_Bitmap_Convert() is simple, but I used it. > "ftbitmap.h" is define FT_Bitmap_Embolden(), and I will use it in the > furure. Looks like FT_Bitmap_Convert is a relatively new function - I don't have it in fc4. You're going to need to provide a fallback or simply ignore it completely and code it yourself. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: ntdll: test to get and set junctions
by Mike McCormack March 15, 2006

March 15, 2006

I don't have alot of time to look over your code at the moment, but: tkho(a)ucla.edu wrote: > dlls/ntdll/tests/Makefile.in | 1 > dlls/ntdll/tests/file.c | 165 +++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/tests/ntifs.h | 66 +++++++++++++++++ This is one patch, and you should roll ntifs.h into file.c > include/ntifs.h | 63 ++++++++++++++++ This should be a separate patch, and it may be better to put it in the include/ddk directory, since it doesn't seem to exist in the Windows SDK. > include/winnt.h | 4 + This is another separate patch, which should be easy enough to get accepted on its own. Mike

1 0

Re: GDI32: Using the FT_Sfnt_Name for font FamilyName
by Huw D M Davies March 15, 2006

March 15, 2006

On Mon, Mar 13, 2006 at 04:10:36AM +0900, Byeong-Sik Jeon wrote: > ChangeLog: > Using the FT_Sfnt_Name for font FamilyName Hi, This one could be broken down too. Start off with a patch that moves FontSubst to using the struct list stuff. Then try sending a patch that uses FT_Sfnt_Name. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.
by Robert Shearman March 15, 2006

March 15, 2006

Saveliy Tretiakov wrote: > Sorry, previous patch was broken. > > ChangeLog: > Saveliy Tretiakov <saveliyt(a)mail.ru> > Add missing ignore attribute. > Check for inapplicable attributes in typedef. > Register type in typelibrary only when ATTR_PUBLIC is set. Please respect the indentation style in the files you are editing. Also, the attribute lists are all sorted to make it easier to find a given attribute in it. Therefore, please add the attribute in the correct place. >+ break; >+ default: >+ yyerror("Inapplicable attribute\n"); >+ } >+ a = NEXT_LINK(a); >+ } >+ typeref_t *tref = uniq_tref($3); > You can't mix variable declarations in between statements as it won't compile on some compilers. -- Rob Shearman

1 0

Dogfood status
by Dan Kegel March 15, 2006

March 15, 2006

I've been dogfooding Wine with Firefox for some time. It's totally usable and good looking now. The four open bugs, http://bugs.winehq.org/show_bug.cgi?id=4523 (copy/paste problem) http://bugs.winehq.org/show_bug.cgi?id=4528 (too tall) http://bugs.winehq.org/show_bug.cgi?id=4762 (flash crash) http://bugs.winehq.org/show_bug.cgi?id=4829 (jerky animations) while serious, do not prevent me from getting work done. A new problem is that apps have been crashing with X Error of failed request: BadAtom (invalid Atom parameter) Major opcode of failed request: 17 (X_GetAtomName) Atom id in failed request: 0x0 every day. This is on Ubuntu 5.10 with updates, and might be a problem with the X server. I'll try updating to Ubuntu 6.04 flight 5 and see if that makes it go away. Anyway, since Firefox is in fairly good good shape, I'm now running putty under wine instead of using linux's built-in ssh. Works fine. Three annoyances: 1) takes a while (ten seconds) to open up session after clicking 'open'. 2) every keystroke yields the console message fixme:imm:ImmReleaseContext (0xb014e, 0x7fdbee18): stub 3) It took me a while to figure out how to copy and paste in putty, since Linux doesn't have the 'copy / paste' items in the upper left corner menu. (ctrl-insert and shift-insert work fine.) But that's a linux window manager issue, not a wine issue. Overall, I'm productive and happy. Success! Since those are the *only two gui apps I use* on Linux, I'm running out of things to dogfood! Oh, once in a while I need an image editor. Maybe I'll dogfood windows gimp next (quadruple yuck)... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 5

Updated DDraw over WineD3D patch
by Stefan Dösinger March 14, 2006

March 14, 2006

Hi, I've uploaded anothe update of my DDraw->WineD3D patch to http://stud4.tuwien.ac.at/~e0526822/. It fixes some refcounting issues and the D3D renderer of the Half-Life 1 Steam version works. It also takes the merged header patches into account ;) I am quite busy the next time, so I won't be able to do a lot ddraw development. I'll continue to send patches, but only header changes, no added functionality. I'll keep myself up to date and anser feedback mails, but I don't think I've the time to do intensive development. I expect I can continue in April. Have fun playing, Stefan

2 2

Free mirror for .deb APT repository (forwarded correspondance)
by Scott Ritchie March 14, 2006

March 14, 2006

Hey guys. For the past few days I've been corresponding with Pieter de Bruijn, who has graciously offered us a huge amount of bandwidth to host the APT repository for our .deb packages, rather than having to put it in the sourceforge webspace where it is rather slow and times out a lot. By my estimates, we get about 800 downloads of Wine from the APT repository per day, which is about 10 gigabytes. All other package downloads from sourceforge combined constitute about 4000 downloads, so roughly 20% of our package downloads are using the APT repository. As for what percentage of our user base uses current .debs, I don't know, because more or less up to date Wine packages derived from mine can be also grabbed from the Ubuntu backports server, the Ubuntu development server, and likely some other place I don't know of. It wouldn't surprise me if over half our users were on Ubuntu at this point, though. One important advantage of Peter's offer is that it allows us much more storage space, possibly including multiple APT repositories for different distributions. This would be far preferable to the ~100 megs or so we get on Sourceforge, which can barely fit one package. Anyway, I'd like to inform everyone about the hosting offer and gather some additional feedback, if you have any comments about the change. Thanks, Scott Ritchie

1 0