April 2006 - Wine-Devel - list.winehq.org

setupapi.dll updated by reactos
by Detlef Riekenberg April 11, 2006

April 11, 2006

Hi. Hervé Poussineau (hpoussin) anounced today on #winehackers, that he did some updates (LGPL) on our "setupapi.dll" - codebase for reactos. So when you have an Installer / Application, that needs more from "setupapi.dll", this hint my help. -- By By ... ... Detlef

2 1

Re: crypt32: fix a typo
by Juan Lang April 11, 2006

April 11, 2006

> Why ruin perfectly good formatting? This eliminates a line-wrap in my 80-col editor, and makes it consistent with the rest of the file, and indeed with the rest of the DLL. Plus, it's my file. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 2

Re: WineD3D: Add a resource dumper
by Stefan Dösinger April 11, 2006

April 11, 2006

Hi, Just a question: Why are the signatures of some of the mails I send to wine-patches broken? It doesn't happen with all mails, approx. every fifth signature is incorrect. The signatures of the same mails in the sent mail folder are correct. Is there something that modifies some mails, but not all? I can't find any modifications in the contents of the mails, so I don't think it's an attack. Stefan

1 0

Re: winspool: [3/4] Implement AddMonitor
by Alexandre Julliard April 11, 2006

April 11, 2006

Detlef Riekenberg <wine.dev(a)web.de> writes: > + if (RegOpenKeyExW(hroot, mi2w->pName, 0, KEY_READ, &hentry) == ERROR_SUCCESS) { > + TRACE("monitor %s already exists\n", debugstr_w(mi2w->pName)); > + /* NT: ERROR_PRINT_MONITOR_ALREADY_INSTALLED (3006) > + 9x: ERROR_ALREADY_EXISTS (183) */ > + SetLastError(ERROR_PRINT_MONITOR_ALREADY_INSTALLED); > + goto addmW_cleanup; > + } > + else > + { > + if(RegCreateKeyW(hroot, mi2w->pName, &hentry) == ERROR_SUCCESS) { > + INT len; > + len = (lstrlenW(mi2w->pDLLName) +1) * sizeof(WCHAR); > + res = (RegSetValueExW(hentry, DriverW, 0, > + REG_SZ, (LPBYTE) mi2w->pDLLName, len) == ERROR_SUCCESS); > + } > + } There's a race here, you should use RegCreateKeyExW and check the returned disposition. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: WLDAP32: improve error handling in create_page_control()
by Alexandre Julliard April 11, 2006

April 11, 2006

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog > Improve error handling in create_page_control(). This doesn't build for me (LDAP_MAXINT is not defined). -- Alexandre Julliard julliard(a)winehq.org

1 0

CJK Font aren´t shown properly
by vikas goswami April 11, 2006

April 11, 2006

I am facing problems when i used chinese system with wine the text on dialog boxes or menus... are not shown properly.. --- Vikas Goswami __________________________________________________________ Yahoo! India Matrimony: Find your partner now. Go to http://yahoo.shaadi.com

1 0

Re: crypt32: fix a typo
by Dimi Paun April 11, 2006

April 11, 2006

On Mon, 2006-04-10 at 21:05 -0700, Juan Lang wrote: > - ret = CryptGetProvParam(hProv, PP_CONTAINER, (BYTE *)szContainer, > - &size, 0); > + ret = CryptGetProvParam(hProv, PP_CONTAINER, > + (BYTE *)szContainer, &size, 0); > if (ret) > { > len = MultiByteToWideChar(CP_ACP, 0, szContainer, -1, > @@ -761,7 +761,8 @@ > > if (szProvider) > { > - ret = CryptGetProvParam(hProv, PP_NAME, (BYTE *)szProvider, &size, 0); > + ret = CryptGetProvParam(hProv, PP_NAME, (BYTE *)szProvider, > + &size, 0); > if (ret) Why ruin perfectly good formatting? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: coverity: fix some pseudoleaks
by Dimi Paun April 11, 2006

April 11, 2006

On Mon, 2006-04-10 at 21:21 -0700, Juan Lang wrote: > Oops, should have looked at the other error reports too. This fixes > the others it reports in winegcc, and supercedes my last email. I'm afraid this is a waste of time. winegcc 'leaks' memory by design, it's a short lived program, there's no point in worrying to much about it. For example, strmake() allocates memory every time, and we almost never free it. And no, we shouldn't fix that -- it would clutter the code quite a bit for zero-benefit. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: exdisp.idl: Added missing attributes.
by Robert Shearman April 10, 2006

April 10, 2006

Jacek Caban wrote: >+ >+ [id(0x60020004), hidden, helpstring("Register a pending open with the list")] >+ HRESULT RegisterPending( >+ [in] long lThreadId, >+ [in] VARIANT *pvarloc, >+ [in] VARIANT *pvarlocRoot, >+ [in] int swClass, >+ [out] long *plCookie); >+ >+ [id(0x60020005), hidden, helpstring("Remove a window from the list")] >+ HRESULT Revoke([in] long lCookie); >+ >+ [id(0x60020006), hidden, helpstring("Notifies the new location")] >+ HRESULT OnNavigate([in] long lCookie, [in] VARIANT *pvarLoc); >+ >+ [id(0x60020007), hidden, helpstring("Notifies the activation")] >+ HRESULT OnActivated([in] long lCookie, [in] VARIANT_BOOL fActive); >+ >+ [id(0x60020008), hidden, helpstring("Find the window based on the location")] >+ HRESULT FindWindowSW( >+ [in] VARIANT *pvarLoc, >+ [in] VARIANT *pvarLocRoot, >+ [in] int swClass, >+ [out] long *phwnd, >+ [in] int swfwOptions, >+ [out, retval] IDispatch **ppdispOut); >+ >+ [id(0x60020009), hidden, helpstring("Notifies on creation and frame name set")] >+ HRESULT OnCreated([in] long lCookie, [in] IUnknown *punk); >+ >+ [id(0x6002000a), hidden, helpstring("Used by IExplore to register different processes")] >+ HRESULT ProcessAttachDetach([in] VARIANT_BOOL fAttach); > } > Are these helpstrings an exact copy of what is in native? If so, I don't think we want them in Wine (and they are only useful to VB programmers anyway). Also, IDs with the 0x60000000 flag are ones generated by the IDL compiler, hence they don't need to be added in the IDL. -- Rob Shearman

2 1

Re: [WINED3D] Map D3DFMT_L16, D3DFMT_A16B16G16R16 to OpenGL formats
by Jason Green April 10, 2006

April 10, 2006

On 4/10/06, Ivan Gyurdiev <ivg2(a)cornell.edu> wrote: > Map: > > D3DFMT_L16 -> GL_LUMINANCE16_EXT > D3DFMT_A16B16G16R16 -> GL_RGBA16_EXT > as Raphael suggested. Assuming this mapping is correct, you should also add these formats here: http://source.winehq.org/git/?p=wine.git;a=blob;h=056c6fb76dd770c03655b7973… (though, that whole part of the file could use some work) And, possibly here: http://source.winehq.org/git/?p=wine.git;a=blob;h=f1868cdb3de16e9bb49f11706…

2 1

Re: Alexandre Julliard : twain_32: Renamed the dlls/twain directory to dlls/ twain_32.
by Dimi Paun April 10, 2006

April 10, 2006

On Mon, 2006-04-10 at 13:47 -0500, Alexandre Julliard wrote: > twain_32: Renamed the dlls/twain directory to dlls/twain_32. Cool! I guess we're only left with the big 3: gdi/kernel/user. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 3

DirectDraw status
by Stefan Dösinger April 10, 2006

April 10, 2006

Hello, I thought I'd give an overview of the status of the ddraw merge. Well, basically it's progressing nicely, and the first huge part of the merge has been done. The necessary type changes were made to include/wine/wined3d_types.h and include/wine/wined3d_interface.h, so ddraw can now use the wined3d interface header. I have uploaded an updated patch against Wine from yesterday, 23:30 to my website( http://stud4.tuwien.ac.at/~e0526822/ ). It contains a few fixes, like yet another refcounting cleanup( Ihope that this works fine now :) ), and the performance issue on my radeon card, as well as the mipmap issues(all cards) are fixed :) What is next? I will send patches which create the new WineD3D methods needed for ddraw. These patches won't contain the implementation, but just the entry in the vtable and a stub function. So if someone disagrees with a method, then we don't have to discuss about the bare existance of a method and it's implementation at the same time :) Additionally, I will now start writing a lot of test cases for all DirectX versions, with an eye for reference counting, in hope that we can fix the refcounting crashes finally. I have a test for some unimplemented functions in my local tree too, like ProcessVertices. Once the function stabs are in, and the tests show where we have to go to, I'll send the implementation of the functions. After that, all that is left is to merge the ddraw.dll code, but first some regression testing has to be done. I'll ask then for some testing help here and at wine-users, so we can catch regressions before they can occur :) Thanks for all the help with testing and coding so far :) Stefan

4 4

Re: [PATCH] [WineDump]: fake dlls
by Alexandre Julliard April 10, 2006

April 10, 2006

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > - now that setupapi generates fake DLLs, add the recognition of > those in winedump I think this should go in pe_dump, it's really PE-specific, the generic code doesn't need to know about it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Missing fonts
by Vitaliy Margolen April 10, 2006

April 10, 2006

Sunday, April 9, 2006, 4:15:22 PM, Alexander N. Sørnes wrote: > Hello, > I have found some font problems recently with Wine. First of all, the > text of most richedit objects started displaying as rectangles since > around Wine 0.9.9, and now, with current CVS, no text is displayed in > applications witht the standard Windows interface (like winecfg, > wordpad, message boxes etc.) on some systems. [skip] I'm sorry, but are you reading this mailing list at all? To sum it up: 1. You need fontforge. 2. You need _working_ fontforge. 3. You need Wine's fonts made with working fontforge. Same thing for freetype. Vitaliy

8 19

Wine tarball patched with DDraw/DX7 over WineD3D patches
by Alexander N. Sørnes April 10, 2006

April 10, 2006

I have made a tarball with Wine CVS patched with the DirectDraw/DirectX 7 over WineD3D patches so it is easier to test/use. Feel free to link to the page. http://www.thehandofagony.com/alex/wine-wd3dp/ The patches fixes the redrawing problems for Warlords Battlecry, and the animations in Stronghold: Crusader are now smooth instead of jerky. Screenshot from Warlords Battlecry http://appdb.winehq.org/screenshots.php?appId=2686&versionId=3913 Regards, Alexander N. Sørnes

3 2

Re: [PATCH 1/3] winedos: better MSCDEX emulation
by Petr Tesarik April 10, 2006

April 10, 2006

Hi everyone, has this patch been rejected? If so, could anyone tell me why? Yes, I know that neither the API, nor the include files are ideal yet, but fixing it would produce a really huge patch, which is AFAIK something you don't like at all. Anyway, with this patch and my other patches applied (including one to the Linux kernel, which was accepted in 2.6.15), I can now run Kindler Literaturlexikon with Wine. And I'd enjoy adding that application to the appdb. Petr Dne 03/31/06 v 14:29:38 (+0200), Petr Tesarik napsal(a): > Hi, > > while I was trying to make Kindler Literaturlexikon work in Wine, I > found out that this program uses a DOS program to access the CDROM, > and that it requires a real working MSCDEX device driver (and not only > that, the driver has to reside in a different segment than the DOS > core). > > To make the patches as small as possible, I've split the patch into > several parts. > > This part just moves some declarations from devices.c to dosexe.h, so > that the code in devices.c can be used from other source files. > > ChangeLog: > > * dlls/winedos/devices.c, dlls/winedos/dosexe.h: > winedos: move some declarations to the header file

2 3

Patch submission
by n1iic Jason Greene April 10, 2006

April 10, 2006

Greetings. I am a new Linux user, and I would like to request a patch addition to add functionality for a game. The information can be found at http://wiki.minegoboom.com/index.php/Running_Continuum_under_Wine I think for the people that want to learn Linux, applying the patch is a great exercise, like I found. Unfortunately, it is long and involved and might scare off those that have less confidence or don't have a guru handy, but still want to try. I originally sent this to the wine-patches list and the owner recommended that I send it here. Thanks Jason

3 2

Wine tarball patched with DDraw/DX7 over WineD3D patches
by Alexander Nicolaysen Sørnes April 10, 2006

April 10, 2006

I have made a tarball with Wine CVS patched with the DirectDraw/DirectX 7 over WineD3D patches so it is easier to test/use. Feel free to link to the page. http://www.thehandofagony.com/alex/wine-wd3dp/ The patches fixes the redrawing problems for Warlords Battlecry, and the animations in Stronghold: Crusader are now smooth instead of jerky. Screenshot from Warlords Battlecry http://appdb.winehq.org/screenshots.php?appId=2686&versionId=3913 Regards, Alexander N. Sørnes

1 0

Re: Missing fonts
by Alexander N. Sørnes April 10, 2006

April 10, 2006

Vitaliy Margolen skrev: >Sunday, April 9, 2006, 4:15:22 PM, Alexander N. Sørnes wrote: > > > >I'm sorry, but are you reading this mailing list at all? To sum it up: >1. You need fontforge. >2. You need _working_ fontforge. >3. You need Wine's fonts made with working fontforge. > >Same thing for freetype. > >Vitaliy > > First of all, I am very sorry if I sent a message in ignorance. But wasn't the FontForge stuff introduced before 0.9.11? Compiling and running 0.9.11 works fine, but doing the same for CVS does not. > > > > >

1 0

DDraw over WineD3D - Indexed colour visuals
by Adam Luchjenbroers April 10, 2006

April 10, 2006

I've been using and tracking Stefan Dossinger's work re: DDraw over WineD3D and decided try and find out if IWineD3DSurface was far enough along to be able to be used in place of IWineX11Surface for 2d applications (Hopefully to eliminate depth conversion issues). Short answer, no. Long answer, Screen displays blank, trace log shows that glReadPixels at line 615 in wined3d\surface.c (LockRect) is failing with error GL_INVALID_OPERATION. Further investigation reveals that this is because glFormat is GL_COLOR_INDEX, yet the display is an RGB visual (presumably because an indexed colour visual was not available, and this buffer is connected directly to the screen). I figured I'd look to the people already familiar with the WineD3D\DDraw codebase before I tried to figure out my own solution. -- "Most people would rather die than think; in fact, they do so." - Bertrand Russell (1872 - 1970)

3 5

DirectX 7
by Dimi Paun April 10, 2006

April 10, 2006

Hi folks, I am not up-to-date with the latest DirectX news, can someone please tell me if we have any support for DirectX 7? I have a screensaver (Marine Aquarium) that I would like to run, but it requires DirectX 7. Is there any trick to get it to run? Thanks! -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

4 4

Re: Missing fonts
by Felix Möller April 9, 2006

April 9, 2006

Hi, > I have found some font problems recently with Wine. First of all, the > text of most richedit objects started displaying as rectangles since > around Wine 0.9.9, and now, with current CVS, no text is displayed in > applications witht the standard Windows interface (like winecfg, > wordpad, message boxes etc.) on some systems. > While the first issue occurs on all systems I have tested, the second > one does not. On a system with only the free corefonts installed, the > text is missing; while on a system with all Windows/MS Office fonts, it > is displayed fine. > What are the new default fonts? Is the first system misconfigured, or > does Wine only use non-downloadable Windows fonts now? I think I have the same problem since arround wine 0.9.9. I am trying to use Derive 6.10. The text in the input field is not displayed correctly any more. But in the textarea it gets displayed correct again. I uploaded a screenshot at http://hebbelabi06.de/derive.png. Sadly I do not have the time to investigate this at the moment. I do have fontforge installed: # rpm -qa | grep fontforge fontforge-20050803-2 HTH Felix Möller

1 0

Re: Missing fonts
by Segin April 9, 2006

April 9, 2006

Alexander N. Sørnes wrote: > Hello, > > I have found some font problems recently with Wine. First of all, the > text of most richedit objects started displaying as rectangles since > around Wine 0.9.9, and now, with current CVS, no text is displayed in > applications witht the standard Windows interface (like winecfg, > wordpad, message boxes etc.) on some systems. > While the first issue occurs on all systems I have tested, the second > one does not. On a system with only the free corefonts installed, the > text is missing; while on a system with all Windows/MS Office fonts, > it is displayed fine. > What are the new default fonts? Is the first system misconfigured, or > does Wine only use non-downloadable Windows fonts now? > > > Regards, > > Alexander N. Sørnes > > > I found a solution, not very good but it works: open regedit Delete HKEY_CURRENT_CONFIG\\Fonts\\ Delete HKEY_USERS\\S-1-5-4\\Software\\Wine\\Fonts\\External Fonts\\ An indication that it works is that the following doesn't come up as all blocks: wineconsole --backend=user wcmd

1 0

[x11drv] Fix two clipboard bugs. Fixes BadAtom crash (bug 4601)
by Dan Kegel April 9, 2006

April 9, 2006

[Is it safe to call intern_atoms() inside the event handler like this?] Changelog: Fix two clipboard problems that caused BadAtom crashes (bug 4601) and caused some clipboard formats to not be exported properly Patch also at http://kegel.com/wine/badatom3.patch if this gets mangled by gmail. dlls/x11drv/clipboard.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) Index: dlls/x11drv/clipboard.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/clipboard.c,v retrieving revision 1.51 diff -d -u -r1.51 clipboard.c --- dlls/x11drv/clipboard.c 22 Feb 2006 21:31:52 -0000 1.51 +++ dlls/x11drv/clipboard.c 9 Apr 2006 21:25:15 -0000 @@ -1784,6 +1784,10 @@ if (names) { wine_tsx11_lock(); + /* FIXME: we're at the mercy of the app sending the event here. + * Currently if they send a bogus atom, we will crash. + * We should handle BadAtom errors gracefully in this call. + */ XGetAtomNames( display, atoms, nb_atoms, names ); wine_tsx11_unlock(); for (i = 0; i < nb_atoms; i++) @@ -2790,6 +2794,13 @@ LPWINE_CLIPFORMAT lpFormats; LPWINE_CLIPDATA lpData; + /* Create X atoms for any clipboard types which don't have atoms yet. + * This avoids sending bogus zero atoms. + * Without this, copying might not have access to all clipboard types. + * FIXME: is it safe to call this here? + */ + intern_atoms(); + /* * Count the number of items we wish to expose as selection targets. */ @@ -2804,7 +2815,7 @@ while (lpFormats) { if ((lpFormats->wFormatID == lpData->wFormatID) && - lpFormats->lpDrvExportFunc) + lpFormats->lpDrvExportFunc && lpFormats->drvData) cTargets++; lpFormats = lpFormats->NextFormat; @@ -2832,8 +2843,15 @@ while (lpFormats) { if ((lpFormats->wFormatID == lpData->wFormatID) && - lpFormats->lpDrvExportFunc) - targets[i++] = lpFormats->drvData; + lpFormats->lpDrvExportFunc) { + /* Don't send zeroes, lest receiver choke on XGetAtomName() */ + if (lpFormats->drvData) { + assert(i < cTargets); + targets[i++] = lpFormats->drvData; + } else { + WARN("bug: ignoring zero atom...\n"); + } + } lpFormats = lpFormats->NextFormat; } @@ -2841,6 +2859,7 @@ lpData = lpData->NextData; } while (lpData != ClipData); + assert(i == cTargets); wine_tsx11_lock(); @@ -2849,7 +2868,10 @@ unsigned int i; for ( i = 0; i < cTargets; i++) { - if (targets[i]) + /* intern_atoms() should make these nonzero. + * We checked before adding them to the array, just to be safe. + */ + assert(targets[i]); { char *itemFmtName = XGetAtomName(display, targets[i]); TRACE("\tAtom# %d: Property %ld Type %s\n", i, targets[i], itemFmtName); -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Coverity doing scans of Wine codebase!
by Dan Kegel April 9, 2006

April 9, 2006

See http://scan.coverity.com/ They say they've found 830 potential bugs - that's quite a few. I haven't seen 'em yet, still waiting for my registration to come through. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

15 27