June 2006 - Wine-Devel - list.winehq.org

Re: [Wine] Re: wine-0.9.15 & winetools problems.
by Rick Romero June 13, 2006

June 13, 2006

On Tue, 2006-06-13 at 21:47 +0200, Peter Åstrand wrote: > On Tue, 13 Jun 2006, Jonathan Ernst wrote: > > > BTW, as I used to maintain this entry, > > If you consider yourself an inactive maintainer, perhaps you should let > someone else takeover? > > > > I updated it with current > > informations. I don't have time to test the runtime settings so I'd be > > glad if you could fill the missing part and send me the details so I'll > > update the entry http://appdb.winehq.org/appview.php?versionId=469 > > Thanks for the update. A few comments: > > * I think the reference to WineTools and Sidenet should be removed. Wine > version 20050725 is quite old. I think we should focus on having the > latest AppDb pages document the latest Wine, rather than old stuff. > > * The manual installation still doesn't work for me (see bug 5409 etc), > but let's get back to that. > > * I think it would be nice if you could include my command lines for > fetching & extracting inseng.dll, for those users without a Windows > installation nearby: > > $ wget http://download.microsoft.com/download/ie6sp1/finrel/6_sp1/W98NT42KMeXP/EN-… > $ cabextract -L IE_S5.CAB > $ cabextract -L -F inseng.dll ie_5.cab > $ rm -rf ~/.wine ie_5.cab IE_S5.CAB > $ wineprefixcreate > $ cp inseng.dll ~/.wine/drive_c/windows/system32/ > $ wget http://download.microsoft.com/download/ie6sp1/finrel/6_sp1/W98NT42KMeXP/EN-… > $ wine ie6setup.exe > Interestingly I _JUST_ decided to go through this myself on a raw wine install of .9.15 So I did the following (Some relate this Subject, some just FYI): 1. Ok, RPM installed. Now what? I need IE. 2. run winecfg, create new Wine install. (Icon says 'Add Application', thought it was for installing applications :/ ) Exit. 2. Read Install/Config HowTo http://www.winehq.org/site/howto 3. Follow link to appdb 4. type 'Internet Explorer' in search 5. Click Internet Explorer link 6. Click 6.0 7. Look confused for a moment, then scroll down far enough to see there's a HOWTO with a dark green background that's hard to see in Opera. 8. 'Install dll?' Screw that, follow link to IE6 at MS. 9. Download IE6SP1 ie6setup.exe 500k. 10. wine ie6setup.exe 11. Error. Go back to Appdb, get dll from link at dlldump.com 12. wine ie6setup.exe 13. Error. "The download location information is damaged" WTF? 14. Ok, maybe I should choose custom install.. Did I get the option? wine ie6setup.exe No options, installs complete. 15. wine IEXPLORE.EXE White Page. Not good. 16. Search for 'Could not load Mozilla' 17. Install ActiveX Control and learn it's re-written and not done yet. So I did all this to test some 'web' VoiceChat, http://www.univoice.us/demo/ that installs from a cab file through IE. Is this functionality lost with this migration from IE to internal rendering? Rick > Regards, > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users

3 2

wined3d: GLSL Patch feedback requested
by Jason Green June 13, 2006

June 13, 2006

The current cumulative patch is located here: http://cmhousing.net/wine/glsl_cumul.diff (This includes the recently submitted "Split constant loading out of drawPrim()" patch, which hasn't been applied to git yet) Before submitting, I plan to fix the following things: - Fix relative addressing (it was working correctly, then I lost some stuff when my hard drive got corrupted, and now it's using R0 instead of A0 as the address register for some reason) - Switch the shader_reg_maps.constantsF[] to a CHAR array instead of a BOOL array (maybe even a bitmap(?)) This whole patchset should be a no-op for normal users, unless they have the UseGLSL registry key enabled. Here's a list of the changelogs that this cumulative patch entails, somewhat in the order that I'll be sending them: [already sent] Move constant loading out of DrawPrimDrawStrided() - DrawPrim is just too big of a function. This separates the passing of constants to the shader into new functions. - Fixes an off-by-one error when loading vertex declaration constants (should be <, not <=) - Adds a function for GLSL loading of constants (aka Uniforms) - Adds a GLSL program variable to the stateblock and sets it to 0 (a future patch will actually create this program) Add GLSL helper functions to device.c - Adds functions to attach & detach shader objects, create and delete programs, and maintain the list of programs. - Adds a list of GLSL shader programs to the device which is initialized on Init3D(), and deleted on Release() Add the bulk of the GLSL string generation functions - Add a new file glsl_shader.c which contains almost every GLSL specific function we'll need - Move print_glsl_info() into glsl_shader.c - Move the shader_reg_maps struct info into the private header, and make it part of SHADER_OPCODE_ARG. - Create a new shared ps/vs register map for float constants (future patch will make ARB programs use this, too) - This is a big patch, but none of the new functions in glsl_shader.c are being called yet. This just sets them up. Unified float constant register mapping between ARB pixel and vertex shaders. - Got rid of the separate constant maps. - Side effect of this is that the map is a bit larger for pixel shaders than it needs to be. - Will make this dynamic in a future patch. Added more declarations to GLSL in generate_glsl_declarations() - Declare more variable names for GLSL programs. - Correct output name for pixel shaders (gl_FragColor instead of glFragColor) Map pixel shader instructions to GLSL generating functions. - Also, delete the GLSL program when the refcount hits 0 Map vertex shader instructions to GLSL generating functions. - Also, delete the GLSL program when the refcount hits 0 Allow drawPrim to create and use the GLSL program - Now that we can fully create a GLSL program, this patch lets us actually use it. I would have submitted these all separate for review, but I have some janitorial git cleanup to do first to get all of this in the right order.

5 8

WINED3D: Bug 5418
by H. Verbeet June 13, 2006

June 13, 2006

http://bugs.winehq.org/show_bug.cgi?id=5418 The code in question does look a bit dodgy. Bad merge perhaps?

2 1

Re: Martin Fuchs : shell32: SHELL32_GetItemAttributes()
by Rein Klazes June 13, 2006

June 13, 2006

Hallo Martin. This patch is giving me trouble: >Author: Martin Fuchs <martin-fuchs(a)gmx.net> >Date: Sat Feb 11 12:16:56 2006 +0100 > >shell32: SHELL32_GetItemAttributes() >- correct documentation which incorrectly claimed not to set any > attribute bits >- retrieve file attributes using SHGetPathFromIDListW() when they are > not already present in the internal PIDL structures >- add test case to show the previously wrong folder attributes when > using absolute PIDLs >- fix some memory leaks in the tests in a couple of wine configurations that I use this leads to an infinite lop when the openfile dialog is called. The call sequence is SHELL32_GetItemAttributes->SHGetPathFromIDListW->ISF_Desktop_fnGetAttributesOf->SHELL32_GetItemAttributes which repeats until the stack overflows. Here is a part of a back trace: | 13 0x7b8533ed SHELL32_GetItemAttributes+0x2dd(psf=0x7bc6bc28, pidl=0x7bc5e058, pdwAttributes=0x7ba5ae54) [/usr/home/projects/wine/mywine/dlls/shell32/shlfolder.c:430] in shell32 (0x7b8533ed) | 14 0x7b83fcb8 ISF_Desktop_fnGetAttributesOf+0x148(iface=0x7bc6bc28, cidl=0x1, apidl=0x7ba5ae5c, rgfInOut=0x7ba5ae54) [/usr/home/projects/wine/mywine/dlls/shell32/shfldr_desktop.c:459] in shell32 (0x7b83fcb8) | 15 0x7b8288cd SHGetPathFromIDListW+0x7d(pidl=0x7bc5e058, pszPath=0x7ba5b0c0) [/usr/home/projects/wine/mywine/dlls/shell32/pidl.c:1273] in shell32 (0x7b8288cd) | 16 0x7b8533ed SHELL32_GetItemAttributes+0x2dd(psf=0x7bc6bbb8, pidl=0x7bc5e058, pdwAttributes=0x7ba5b334) [/usr/home/projects/wine/mywine/dlls/shell32/shlfolder.c:430] in shell32 (0x7b8533ed) | 17 0x7b83fcb8 ISF_Desktop_fnGetAttributesOf+0x148(iface=0x7bc6bbb8, cidl=0x1, apidl=0x7ba5b33c, rgfInOut=0x7ba5b334) [/usr/home/projects/wine/mywine/dlls/shell32/shfldr_desktop.c:459] in shell32 (0x7b83fcb8) | 18 0x7b8288cd SHGetPathFromIDListW+0x7d(pidl=0x7bc5e058, pszPath=0x7ba5b5a0) [/usr/home/projects/wine/mywine/dlls/shell32/pidl.c:1273] in shell32 (0x7b8288cd) | 19 0x7b8533ed SHELL32_GetItemAttributes+0x2dd(psf=0x7bc6dd70, pidl=0x7bc5e058, pdwAttributes=0x7ba5b814) [/usr/home/projects/wine/mywine/dlls/shell32/shlfolder.c:430] in shell32 (0x7b8533ed) A +relay,+shell log of one loop is attached below. Running wineprefixcreate or reinstalling wine.inf does not help. On a clean new installation there is no problem (but I like to keep using the old stuff with a hundred or so of installed windows programs). Any idea? Rein.

3 4

Re: riched20 patch
by James Hawkins June 13, 2006

June 13, 2006

On 6/12/06, Clinton Stimpson <clinton(a)elemtech.com> wrote: > > Second attempt (seems my last one email with this patch dropped through > the cracks ??): > > Attached is a patch to fix a crash when EM_SETTEXTEX is called with a > NULL lParam. > Return values and behavior has been verified and found equivalent to an > app on Windows. > This will have a much better chance getting accepted if you provide a test case for this behavior. -- James Hawkins

1 0

Wine's Mozilla Control - Very old
by Boaz Harrosh June 13, 2006

June 13, 2006

For any it might concern! The Mozilla ActiveX Control recommended for download by Wine is based on a pre FireFox 1.0 gecko engine and is missing support for many web standards! I was doing development in Windows and needed an Embedded browser. I wanted to also support Mozilla engine and was Quickly downloading the ActiveX from wine download page. (My installed FireFox does not supply one). My work involved embedding the FCKEditor (http://FCKEditor.sourceforge.net) So I installed and change the source code to use the Mozilla GUID and oops FCKEditor does not work. After some investigation I found that even though the Control's package is from Q4/2005 the engine included is much older and belongs to Mozilla 1.6 or something. Since then the Mozilla package did not include a new Control and Has eventually stopped been released. (Do to FireFox replacing it). The New (Mozilla 1.8) Control can only be found in the new SeaMonkey 1.0.x package, which is what I got. And with this control every thing works grate. (Even better than IE). Now SeaMonkey (http://www.mozilla.org/projects/seamonkey) is a very large package and is not something a user would be Happy to be forced with. I did Package a one time Installation of the new Control, stripping down from SeaMonkey anything I could guess does not belong. But this is a one time Job and I'm not sure is the right solution. Maybe we should contact the Sea-Monkey maintainers and ask them to Also produce an "on the side" extra package for our sake. I have not done that yet ... Any body in contact with Mozilla.org? Free Life Boaz

1 0

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW
by Juan Lang June 13, 2006

June 13, 2006

Hi Christian, thanks for working on setupapi, it could use some help. Huw already commnented on your patch, I have a couple more: + if (!list) { + goto cleanup; + } The style in this file has opening braces on lines of their own, e.g.: if (hInf == INVALID_HANDLE_VALUE) { return FALSE; } Please stick with that. + if (MachineName != NULL) { You should probably just fail if the machine name isn't NULL, since you don't use it and you don't connect to a remote machine anyway. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Crash in XOpenIM in wine 0.9.15
by Daniel Skorka June 13, 2006

June 13, 2006

Hello, I want to bring an issue that has appeared on wine-users to your attention. The issue is basically this: Any time a process in wine tries to execute another process, wine will crash following a call to XOpenIM. For details please look here [1]. I'm sure Leigh is willing to provide any additional info required. regards, Daniel [1] http://www.winehq.org/pipermail/wine-users/2006-June/021973.html

2 1

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW
by Huw Davies June 13, 2006

June 13, 2006

On Tue, Jun 13, 2006 at 03:42:22PM +0200, Christian Gmeiner wrote: > diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c > index f402f00..c24ae1e 100644 > --- a/dlls/setupapi/devinst.c > +++ b/dlls/setupapi/devinst.c > HDEVINFO WINAPI > -SetupDiCreateDeviceInfoListExW(const GUID *ClassGuid, > - HWND hwndParent, > - PCWSTR MachineName, > - PVOID Reserved) > +SetupDiCreateDeviceInfoListExW( > + const GUID *ClassGuid, > + HWND hwndParent, > + PCWSTR MachineName, > + PVOID Reserved) Please avoid these unnecessary whitespace changes, they just make the patch bigger. > diff --git a/dlls/setupapi/setupapi_private.h b/dlls/setupapi/setupapi_private.h > index bce05cb..77e4fb0 100644 > --- a/dlls/setupapi/setupapi_private.h > +++ b/dlls/setupapi/setupapi_private.h > +struct DeviceInfoSet > +{ > + DWORD magic; /* if is equal to SETUP_DEVICE_INFO_SET_MAGIC struct is okay */ > + GUID ClassGuid; > + PWSTR MachineName; > + HWND hwndParent; > +}; > + Is this struct going to be used by functions outside devinst.c? If not then this should be moved into that file. Also please include a test with your patch and, in this case, I think it makes sense to include the appropiate Destroy function too, that way it's easy to check that you haven't introduced a memory leak. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: What is needed to get more sites with a winetest executable
by Paul Vriens June 13, 2006

June 13, 2006

> Am Montag, 12. Juni 2006 20:22 schrieb Paul Vriens: >> Hi, >> >> in the last months we've experienced several times that there was no winetest.exe available at the usual location >> (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. >> >> What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? >> >> Cheers, >> >> Paul. > Hi, > > not the answer to your question, but some thoughts about the topic. > > As long as the automatic build of Paul Millar works, there is not reason to > have a second winetest binary for nearly the same git/cvs source of the tests. One binary a day is enough. If you check > http://test.winehq.org/data/ > you will see that we miss often tests results for some windows platforms. > > If building the winetest binary fails. Someone needs to look into the reason > anyway. In almost all cases its a missing import in a library the test ist linked against. So first "our mingw environment" needs to be fixed. Just running another automatic build will fail with the same error as the build of > Paul. > > Its not hard for me to do the manual build. I just need some webspace to put > the stuff on. And i need to know what needs to be modified in the source before the build (somehow the build date need to be patched into the source). > Also the question is how the new build is announce to the public (hope that > it si not the case that it appears on astro.gla.ac.uk). > > Bye Stefan > Hi, exactly my point. I know Paul Millar fixes stuff all the time by patches of you I think and Hans Leidekker (and others). But he is only one person, with of course a limited amount of time. Maybe we should have a few sites generating the winebuild and using a different path to publish stuff at test.winehq.org/data/[site]. We don't want to mix the output of different executables in one view (apples and pears). Another thing what we could is just use a well-known-url for the winetest.exe like we did with the Mozilla ActiveX component. This url should of course point to the latest available on all site (don't know if that's feasible). Cheers, Paul.

2 2

Re: msvcrt[1/2]: add initial tests for dlls/msvcrt/data.c
by Alexandre Julliard June 13, 2006

June 13, 2006

Andrew Ziem <ahziem1(a)mailbolt.com> writes: > +typedef void (*_INITTERMFUN)(void); > +unsigned int (WINAPI *p_initterm)(_INITTERMFUN *,_INITTERMFUN *); Msvcrt functions are not WINAPI. And why don't you simply call the function directly instead of loading it dynamically? -- Alexandre Julliard julliard(a)winehq.org

2 2

Vertex Buffer Objects for WineD3D
by Stefan Dösinger June 13, 2006

June 13, 2006

Hi, In the last days I've been working on using the OpenGL vertex buffer objects extension for IWineD3DVertexBuffer. The aims of this were: * Store geometry data in the hardware for more efficient rendering * Convert the colors and rhw values on upload and get rid of drawStridedSlow The result is in this diff, and it basically works, although not as good as I've hoped. It gives a nice performance boost to Battlefield 1942, and is an improvement for Half-Life 2, but it is not perfect yet. The main shortcomings are: * Shader support: I'm afraid that the conversion code at this points breaks shaders. I've tested with battlefield 1942. The vertex shaders in this game don't work correctly yet, the hands of soldiers are missing and there are some incorrect planes with odd colors. However, with this patch the hands are drawn as apparently random vertices all over the screen. I think I'll need a little help from the shader people for that. * The vertex conversion is slow, and it turned out that if the app Locks the Buffer every frame then drawStridedSlow is faster Converting + drawStridedSlow. Because of that VBOs and the conversion aren't used for vertex buffers in system memory and vbs with WINED3DUSAGE_DYNAMIC are not loaded into a vbo. * In Direct3D7 there is no way for the app to specify a range of vertices to be locked. Because of that DX7 apps are generally slower if they update the vertices regularily. To avoid that drawback there is no VBO created for DX7 apps if they have vertex data that needs conversion. The geometry in DX7 apps is usually quite simple, so DrawStridedSlow isn't a big performance hit in those apps. Stefan

3 4

What is needed to get more sites with a winetest executable
by Paul Vriens June 13, 2006

June 13, 2006

Hi, in the last months we've experienced several times that there was no winetest.exe available at the usual location (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? Cheers, Paul.

2 1

wined3d: Another GLSL shader status update
by Jason Green June 13, 2006

June 13, 2006

Well, I've fixed the speed issues with using GLSL (it's now just as fast as ARB shaders for the ones that actually work correctly) and gotten a few other things to work correctly. However, I'm still having issues with certain pixel/vertex shader combinations. Ohsix caught on that it may have to do with sampler limits on graphics cards and how sampling/textures are handled different in GLSL that with ARB. I'm not sure at the moment and could use some help. http://cmhousing.net/wine/glsl_hack6.diff is the diff against the most recent git tree. There are still some ugly hacks lying around in there. Note that I've separated out most of the GLSL functions into a new file "glsl_shader.c". Once again, to use GLSL instead of ARB shaders, you'll have to apply this patch, have a graphics card that's capable of GLSL, and add the following case senstive registry key: HKCU\Software\Wine\Direct3D\UseGLSL = "enabled" (String value)

6 13

comctl32.dll: Running siap and modules under wine, first steps
by Maximiliano Curia June 12, 2006

June 12, 2006

Hi, I'm trying to use a program called "siap"[1] under wine. It's the required program to pay taxes that the Argentinian government uses. So, it's quite important for the free software community in Argentina to be able to use it in a free software environment. However, I haven't heard of any real success on it, so far. I've been trying to make it run using winetools[2], and differents versions of wine. The furthest I've gone, has been with version 20050310 and all the "plugins" that winetools provides, installed. Only then, could I install the application, run it, switch between the different modules (although it worked only sometimes), but I can't really use it. There are a couple of important widgets that seem to be incompatible with wine. But as I'm not an expert neither in Windows nor in wine, the one I could really track down is a TreeView widget (from comctl32.dll) (from the main window of the program), that is not fully implemented in wine, and by using a native comctl32.dll (I tried using the win98, winme, win2k libraries) the widget would work but some of the other stuff, like switching to one of the modules wouldn't. I made a screenshot to make this clearer, the wine version[3] and the w2k version[4]. So, what should I do next? Is there some documentation of how to implement a certain Windows widget in wine? Is anybody working in this dll, or has worked on this widget? I'd appreciate any comments. Thanks, [1] http://www.afip.gov.ar/programas/siap_main.asp (spanish only) [2] http://www.von-thadden.de/Joachim/WineTools/ [3] http://gnuservers.com.ar/~maxy/wine/siap-wine.png [4] http://gnuservers.com.ar/~maxy/wine/siap-w2k.png -- Saludos, /\/\ /\ >< `/

4 8

Re: Gnome and KDE wine configuration tools
by Yuriy June 12, 2006

June 12, 2006

> > > Guidance : > --------------- > Its not completely wine configuration utility, but a general > purpose system configuration utility for KDE. It now has got some > module for configuring WINE also. I got this news from > http://dot.kde.org/1150047999/. I havent tested it, but it can be got > from here http://www.simonzone.com/software/guidance/ > > Conclusion, its for you all to decide which is the best tool. And not > to forget give some valuable inputs to the developers to improve. > > Thanks, > Vijay > Hi, I'm the one making that. There's nothing much to test yet (need to get busier!), and it's not on the site, it's in SVN. Input is good of course. ~Yuriy

1 0

Re: Alexandre Julliard : riched20: Fix an uninitialized variable bug.
by Marcus Meissner June 12, 2006

June 12, 2006

On Mon, Jun 12, 2006 at 10:02:35AM -0500, Alexandre Julliard wrote: > Module: wine > Branch: refs/heads/master > Commit: fe4c4780eb0a047f09a2e536eeaa1f51434b4b61 > URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=fe4c4780eb0a047f09a2e53… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Jun 12 16:09:50 2006 +0200 > > riched20: Fix an uninitialized variable bug. > > Mark todo a test that depended on the bug to succeed. And I wondered if only I was seeing this bug ;) Ciao, Marcus

1 0

re: WM_GETICON patch
by Dan Kegel June 12, 2006

June 12, 2006

Mike Hearn wrote: > ... obviously WM_GETICON > requires inter-process bitmaps to be supported in some fashion, which is a > fair bit of work. Maybe for efficiency reasons even requiring the dreaded > remote thread creation/service thread :) Adding support for remote thread creation is on Tommy Kho's to-do list. (Probably just for linux and nptl initially.) - Dan

1 0

WM_GETICON patch
by Chris June 12, 2006

June 12, 2006

Here's a patch I'm trying to make to implement the WM_GETICON message, which programs like GeoShell (a Win32 taskbar replacement) would use to get a taskbar icon for the running processes. I'm not quite sure if it's proper or not, though. Originally GeoShell would show no icon on the taskbar and print a lot of fixme messages about it being unsupported. With this patch it now (always) shows the Wine glass icon for programs, with no such fixme messages. Since I'm unable to try it on a real Windows machine, I don't know if it's the right behavior for it to always show the generic icon like that. Feedback and help would be appreciated.

2 5

Gnome and KDE wine configuration tools
by Vijay Kiran Kamuju June 12, 2006

June 12, 2006

Hi, I was just looking at browsing net for some linux stuff. I just happend to see some news related to wine Wine-doors : ------------------ Its just a wine installation utility for GNOME with preliminary(very basic and primitive) wine configuration.It has support for multiple installations, from screenshots i think so. I got this news from here http://gnomedesktop.org/node/2689, and more information can be got from its web site http://www.wine-doors.org/ Guidance : --------------- Its not completely wine configuration utility, but a general purpose system configuration utility for KDE. It now has got some module for configuring WINE also. I got this news from http://dot.kde.org/1150047999/. I havent tested it, but it can be got from here http://www.simonzone.com/software/guidance/ Conclusion, its for you all to decide which is the best tool. And not to forget give some valuable inputs to the developers to improve. Thanks, Vijay

2 1

x11drv: set window manager icon hints correctly
by Juris Smotrovs June 12, 2006

June 12, 2006

Currently, for many applications the generic Wine icon or a class default icon is used in window manager caption or taskbar instead of the application icon set with WM_SETICON. See, for instance, Bug 3370. What actually happens is this: the application icon is correctly set when processing WM_SETICON, but a bit later, when window is mapped, X11DRV_set_wm_hints resets it back to class default (or to none, leading to Wine icon). It seems that X11DRV_set_wm_hints has been designed to be called only when creating a window: it alocates WM hints -- XAllocWMHints() -- instead of checking for existing ones with XGetWMHints(...), and sets class default icon, instead of checking whether another icon has been set in the meantime. However, calls to X11DRV_set_wm_hints have been added at mapping a window and changing window style (see x11drv/winpos.c). Thus, Wine currently allocates WM hints anew and resets icon at every mapping and style change of a window. I attach a patch to X11DRV_set_wm_hints correcting this issue: 1) it checks for existing WM hints before allocating new ones, 2) it resets icon to class default only if no icon hint has been set earlier. Please, let me know if you see anything wrong with this patch. Cheers, Juris

1 0

Re: winmm: Add support for "open new" commands.
by Eric Pouech June 12, 2006

June 12, 2006

Peter Åstrand wrote: > > ChangeLog: > winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) A+

3 3

Re: WineD3D: Fog fixes, try 2
by Stefan Dösinger June 12, 2006

June 12, 2006

Hi, Apply this patch instead, the old patch had some sloppiness error(setting FOGSTART as FOGEND when restoring z-based fog). The problem is corrected in this patch. It also doesn't add a senseless space at the begin of the file and sets the fog to GL_FASTEST for vertex fog and GL_NICEST for table / pixel fog. ChangeLog: Stefan Dösinger(for CodeWeavers): Correct vertex fog for transformed vertices and correctly handle non-vertex, non-table fog

3 3

uxtheme efforts (wanted/needed ?)
by Paul Vriens June 12, 2006

June 12, 2006

Hi, I've sent 2 emails that are (for now) silently ignored: http://www.winehq.org/pipermail/wine-patches/2006-June/027253.html http://www.winehq.org/pipermail/wine-patches/2006-June/027350.html They both have to do with uxtheme and were meant as a starter for conformance tests and of course the fixes to it. I first wanted to start with input/return paramater and value testing before I touch any functional part (maybe not mutually exclusive). Was there anything wrong with the patches? How can I improve or what do I have to change? Cheers, Paul

2 1

Re: Broken FC5 packages - stay clear.
by Hans Leidekker June 12, 2006

June 12, 2006

On Monday 12 June 2006 12:04, Andreas Bierfert wrote: > > Good, but shouldn't zlib-devel be pulled in like that too then? > > Oh... don't even mention discussions on what should be in the minimal build > root and what shouldn't ;) I'm not, this isn't about the minimal build system. zlib-devel should be pulled in through whatever package depends on it. > It is :) gphoto2 is pulled in by sane? I believe... anyway last time I > checked (0.9.14) it was pulled in :) Right, but gphoto2 is a direct Wine dependency, so it would be better IMO to support it as such. It's also more flexible, i.e this way a user could choose to install gphoto2 but not sane support. -Hans

1 0

Re: Broken FC5 packages - stay clear.
by Hans Leidekker June 12, 2006

June 12, 2006

On Monday 12 June 2006 11:37, Andreas Bierfert wrote: > Why is there no BuildRequires for freetype? gphoto2? We also have > >These two are pulled in by other dependencies and thus don't need an explicit >listing (e.g. freetype by fontconfig-devel). Good, but shouldn't zlib-devel be pulled in like that too then? > zlib-devel on the other hand is not in the minimal buildroot :) Like Marcus said, freetype-devel is probably missing a dependency on zlib-devel. Wine doesn't directly depend on zlib-devel AFAICT. And it would be nice if you could add gphoto2 support. -Hans

1 0

Re: iphlpapi: forward Icmp* functions to icmp.dll
by Steven Edwards June 12, 2006

June 12, 2006

On 6/11/06, Simon Kissane <skissane(a)gmail.com> wrote: > In WinXP, these functions are implemented in iphlpapi.dll as well as > icmp.dll (Win2000). > They are already in Wine's icmp.dll, so forward the iphlpapi to icmp.dll Being its a small amount of code in icmp.dll I think we should just duplicate it. Our dependancies should really match windows and the last time I looked iphlpapi did not depend on icmp.dll in win2k. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

Re: DDraw: New ddraw lib
by Jesse Allen June 11, 2006

June 11, 2006

On 6/9/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > This is a resend of my ddraw rewrite, with some modifications Alexandre asked > for. I removed the whitespace fixes from the files which are taken from the > old ddraw code(light.c, material.c, clipper.c, viewport.c, executebuffer.c, > ddcomimpl.h, ddraw_thunks, surface_thunks). There are no functional changes > compared to the old patch, except a small change to forward the SYSTEMMEM and > WRITEONLY flags for vertexbuffers to WineD3D. > > The other files which have the same name as in the old code(main.c, > vertexbuffer.c): Those are rewrites(file deleted and re-created), so I won't > get a useful diff for them, no matter what I do. > > ChangeLog: > Stefan Dösinger: Use WineD3D for DDraw > I just want to state, the patch is very helpful when you can't use DGA. I just ran a test with Starcraft in multiplayer last night. Using OpenGL is noticibly faster than non-DGA. So I hope that it will get applied for 0.9.16. Jesse

2 6

Icmp* functions in iphlpapi.dll
by Simon Kissane June 11, 2006

June 11, 2006

Hi In Win2000, the ICMP functions exist in icmp.dll In WinXP, they are still there, but they have also been duplicated into iphlpapi.dll How would one go about adding them to iphlpapi? Does one just duplicate all the code in the second DLL, or is there a way to have some function implemented once & then exported by multiple DLLs? (I'm a Wine newbie...) Suppose one was to add code to iphlpapi's LibMain which did LoadLibrary & GetProcAddress to get the addresses of the functions in icmp.dll, and then the iphlpapi implementations just called the icmp.dll implementations? (I'm assuming doing a static import would result in some kind of name collission?) Cheers Simon

4 3

My new hero...
by Dan Kegel June 11, 2006

June 11, 2006

Qingdao is my new hero. He's really on a roll: http://www.winehq.org/pipermail/wine-cvs/2006-June/023427.html fixes a Visual Basic safearray redim bug, http://bugs.winehq.org/show_bug.cgi?id=5217 and he has two other fixes in unrelated areas this month. Mike, what was that you were saying about there not being any wine hackers who fixed problems all around the wine tree anymore? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER (FIXED)
by Andrey Turkin June 11, 2006

June 11, 2006

Andrew Ziem wrote: > Please use this patch instead of previous "user3.patch". Thanks to > Andrey Turkin for catching the uninitialized variable. > > changelog: > user: handle special cases for SPI_SETDESKWALLPAPER > > The special cases remove the wallpaper or set it to default. > Previously, these cases were ignored, so Wine would crash. > > > > ------------------------------------------------------------------------ > > > > - if (filename == (LPSTR)-1) > + if ((LPCSTR)SETWALLPAPER_DEFAULT == filename || (LPCSTR)NULL == filename || '\0' == filename[0]) > { > - GetProfileStringA( "desktop", "WallPaper", "(None)", buffer, 256 ); > - filename = buffer; > + /* set default wallpaper or remove wallpaper*/ > + if (hbitmapWallPaper) > + DeleteObject( hbitmapWallPaper ); > + return TRUE; > } > hdc = GetDC( 0 ); According to MSDN, if - pvParam==SETWALLPAPER_DEFAUL || pvParam==NULL, then wallpaper will be set to default one - pvParam[0]=='\0', then wallpaper will be removed. I cannot see any signs of such distinction in your code :)

2 1

Re: getuname: add stub implementation [try 4]
by Dmitry Timoshkov June 10, 2006

June 10, 2006

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Add WINE_PREATTACH and correct numer of params for GetUName > Try4: Export functions by name (@), fix warning in FIXME > > Changelog > add minimal implementation for getuname dll and GetUName function Just curious, what application besides charmap.exe uses getuname.dll? -- Dmitry.

2 2

msi: sql parsing
by Joris Huizer June 10, 2006

June 10, 2006

Hello, As somebody asked me whether I could try to use MSN Beta 8, I decided to give it a try; The installer quits at some point, caused by an unhandled SQL command "ALTER TABLE `Registry` HOLD" I decided to have a look at this, but I'm not familiar with msi, and my SQL knowledge isn't very big either; anyway, I added a few lines to the parser; now -- how could I find how to implement something for this? Regards, Joris diff --git a/dlls/msi/sql.y b/dlls/msi/sql.y index 86ebe30..f8c9f40 100644 --- a/dlls/msi/sql.y +++ b/dlls/msi/sql.y @@ -79,7 +79,7 @@ static struct expr * EXPR_wildcard( void int integer; } -%token TK_ABORT TK_AFTER TK_AGG_FUNCTION TK_ALL TK_AND TK_AS TK_ASC +%token TK_ABORT TK_AFTER TK_ALTER TK_AGG_FUNCTION TK_ALL TK_AND TK_AS TK_ASC %token TK_BEFORE TK_BEGIN TK_BETWEEN TK_BITAND TK_BITNOT TK_BITOR TK_BY %token TK_CASCADE TK_CASE TK_CHAR TK_CHECK TK_CLUSTER TK_COLLATE TK_COLUMN %token TK_COMMA TK_COMMENT TK_COMMIT TK_CONCAT TK_CONFLICT @@ -127,7 +127,7 @@ static struct expr * EXPR_wildcard( void %type <column_list> selcollist column column_and_type column_def table_def %type <column_list> column_assignment update_assign_list constlist %type <query> query from fromtable selectfrom unorderedsel -%type <query> oneupdate onedelete oneselect onequery onecreate oneinsert +%type <query> oneupdate onedelete oneselect onequery onecreate oneinsert onealter %type <expr> expr val column_val const_val %type <column_type> column_type data_type data_type_l data_count %type <integer> number @@ -156,6 +156,7 @@ onequery: | oneinsert | oneupdate | onedelete + | onealter ; oneinsert: @@ -235,6 +236,14 @@ onedelete: } ; +onealter: + TK_ALTER TK_TABLE table TK_HOLD + { + FIXME("Unimplemented: ALTER TABLE, HOLD\n"); + $$ = NULL; + } + ; + table_def: column_def TK_PRIMARY TK_KEY selcollist { @@ -807,7 +816,7 @@ UINT MSI_ParseSQL( MSIDATABASE *db, LPCW sql.len = 0; sql.view = phview; sql.mem = mem; - + r = SQL_parse(&sql); TRACE("Parse returned %d\n", r); diff --git a/dlls/msi/tokenize.c b/dlls/msi/tokenize.c index 05c3cda..9b628c0 100644 --- a/dlls/msi/tokenize.c +++ b/dlls/msi/tokenize.c @@ -45,6 +45,7 @@ struct Keyword { static const Keyword aKeywordTable[] = { { "ABORT", TK_ABORT }, { "AFTER", TK_AFTER }, + { "ALTER", TK_ALTER }, { "ALL", TK_ALL }, { "AND", TK_AND }, { "AS", TK_AS },

1 0

awwww
by Dan Kegel June 10, 2006

June 10, 2006

Hey, I wanted to see if my computer could run Vista, but: $ ~/wine/programs/msiexec/msiexec /i VistaUpgradeAdvisor.msi fixme:msi:MsiInstallProductW L"VistaUpgradeAdvisor.msi" (null) err:msidb:load_string_table string table corrupt? err:msidb:load_string_table string table load failed! (000218f3 != 000047ef) Filed as http://bugs.winehq.org/show_bug.cgi?id=5395

5 6

Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER
by Andrey Turkin June 10, 2006

June 10, 2006

I cannot see where emptyW initialized. Andrew Ziem wrote: > The special cases remove the wallpaper or set it to default. > Previously, these cases were ignored, so Wine would crash. > <snip> > + if (NULL == pvParam || SETWALLPAPER_DEFAULT == pvParam) > + { > + static const WCHAR emptyW[1]; > + if (!SetDeskWallPaper( (LPSTR)pvParam )) > + return FALSE; > + SYSPARAMS_Save(SPI_SETDESKWALLPAPER_REGKEY, SPI_SETDESKWALLPAPER_VALNAME, emptyW, fWinIni); > + } > + else > + { > + if (!SetDeskWallPaper( (LPSTR) pvParam )) > + return FALSE; > + } > + break; >

2 1

Re: user[2/5]: implement A version of SPI_GETDESKWALLPAPER
by Andrey Turkin June 10, 2006

June 10, 2006

Andrew Ziem wrote: > Previously, SPI_GETDESKWALLPAPER was handled by default: in the > switch, so the function (an A- function) would return a W string. > > ------------------------------------------------------------------------ > > > 5e4b86d689c899fc896d2870efaca9c335f01da0 > diff --git a/dlls/user/sysparams.c b/dlls/user/sysparams.c > index 5fed316..fb54b3b 100644 > --- a/dlls/user/sysparams.c > +++ b/dlls/user/sysparams.c > @@ -2496,6 +2496,16 @@ BOOL WINAPI SystemParametersInfoA( UINT > break; > } > > + case SPI_GETDESKWALLPAPER: /* 115 */ > + { > + WCHAR buffer[MAX_PATH]; > + ret = SystemParametersInfoW( SPI_GETDESKWALLPAPER, uiParam, buffer, fuWinIni ); > + if (!WideCharToMultiByte(CP_ACP, 0, buffer, -1, pvParam, uiParam, NULL, NULL)) > + ret = FALSE; > + else > + pvParam = buffer; > + } > + > default: > ret = SystemParametersInfoW( uiAction, uiParam, pvParam, fuWinIni ); > break; > > > ------------------------------------------------------------------------ > > > I think break is needed after case. Also, for what else pvParam = buffer; need for?

1 0

Recording with "Lexia" (mci "open new")
by Peter Åstrand June 10, 2006

June 10, 2006

Hi, I've patched Wine to make recordings work in "Lexia" (http://www.lexia.just.nu/, currently down). When I started out, recordings didn't work, and I was getting traces like: trace:mci:mciSendStringW (L"open new type waveaudio alias capture", 0x7db2ebc8, 128, (nil)) fixme:mci:mciSendStringW 'new': NIY as device name trace:mci:mciSendStringW (L"set capture time format milliseconds bitspersample 16 samplespersec 22050 channels 1 bytespersec 44100 alignment 4", 0x7db92fa8, 128, (nil)) trace:mci:mciSendStringW (L"open capture wait", (nil), 0, (nil)) trace:mci:MCI_LoadMciDriver wDevID=0001 fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini trace:mci:mciSendStringW (L"record capture", 0x7db2ebc8, 128, (nil)) trace:mci:mciSendStringW (L"open capture wait", (nil), 0, (nil)) trace:mci:MCI_LoadMciDriver wDevID=0001 fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini I created the patch below, but eventually, it turned out that it's sufficient to add this to system.ini: [mci] CAPTURE=mciwave.dll In other words: With this change, recordings works despite mciSendStringW returning MCIERR_MISSING_DEVICE_NAME. Strange but true. To summarize: 1) I believe the mciwave.c patch below makes sense in any case, right? Without it freed memory is used. 2) Any ideas why "open new" works, even though MCIERR_MISSING_DEVICE_NAME is returned? 3) Most importantly: Why is it necessary to add CAPTURE to system.ini? Perhaps the "alias" argument isn't correctly handled? The patch: Index: dlls/winmm/mci.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/mci.c,v retrieving revision 1.69 diff -u -r1.69 mci.c --- dlls/winmm/mci.c 23 May 2006 12:48:57 -0000 1.69 +++ dlls/winmm/mci.c 8 Jun 2006 12:53:43 -0000 @@ -1283,10 +1283,9 @@ /* case dev == 'new' has to be handled */ if (!strcmpW(dev, wszNew)) { - FIXME("'new': NIY as device name\n"); - dwRet = MCIERR_MISSING_DEVICE_NAME; - goto errCleanUp; - } + /* FIXME: Use temp file name. Remove after use. */ + dev = MCI_strdupAtoW("mcitemp.wav"); + } /* otherwise, try to grab devType from open */ if (!strcmpW(verb, wszOpen)) { Index: dlls/mciwave/mciwave.c =================================================================== RCS file: /home/wine/wine/dlls/mciwave/mciwave.c,v retrieving revision 1.2 diff -u -r1.2 mciwave.c --- dlls/mciwave/mciwave.c 23 May 2006 12:48:10 -0000 1.2 +++ dlls/mciwave/mciwave.c 8 Jun 2006 12:53:43 -0000 @@ -409,18 +409,19 @@ fn = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(filename) + 1) * sizeof(WCHAR)); if (!fn) return MCIERR_OUT_OF_MEMORY; strcpyW(fn, filename); + /* Note: Frees filename as well */ HeapFree(GetProcessHeap(), 0, (void*)wmw->openParms.lpstrElementName); wmw->openParms.lpstrElementName = fn; - if (strlenW(filename) > 0) { + if (strlenW(fn) > 0) { /* FIXME : what should be done if wmw->hFile is already != 0, or the driver is playin' */ - TRACE("MCI_OPEN_ELEMENT %s!\n", debugstr_w(filename)); + TRACE("MCI_OPEN_ELEMENT %s!\n", debugstr_w(fn)); - wmw->hFile = mmioOpenW((LPWSTR)filename, NULL, + wmw->hFile = mmioOpenW((LPWSTR)fn, NULL, MMIO_ALLOCBUF | MMIO_DENYWRITE | MMIO_READ); if (wmw->hFile == 0) { - WARN("can't find file=%s!\n", debugstr_w(filename)); + WARN("can't find file=%s!\n", debugstr_w(fn)); dwRet = MCIERR_FILE_NOT_FOUND; } else Regards, -- Peter Åstrand ThinLinc Chief Developer Cendio http://www.cendio.se Teknikringen 3 583 30 Linköping Phone: +46-13-21 46 00

2 4

riched20 bug 4452 fix still not merged?
by Dan Kegel June 10, 2006

June 10, 2006

Hi Matt, can you add http://bugs.winehq.org/show_bug.cgi?id=4452 to your list of riched20 bugs to look at? This one even has a fix, but for some reason the fix hasn't been merged yet. Thanks, Dan

1 0

Re: notepad patches (search/replace, etc)
by Vitaliy Margolen June 10, 2006

June 10, 2006

Thursday, June 8, 2006, 6:40:33 PM, Anoni Moose wrote: > This is my first patch to an open source project... if anyone has any comments/suggestions, please tell me. :) > These patches add full search, search next, replace, and goto line functionality to notepad. Too bad I missed the 0.9.15 release! > Changelog: > * programs/notepad/main.c, programs/notepad/dialog.c, > programs/notepad/main.h, programs/notepad/notepad_res.h, > programs/notepad/dialog.h: > notepad: Add/call functions to load/save globals settings (including font info) to registry. > -Added full Search/Search Next functionality. > -Added full Replace functionality. > -Added full Goto Line functionality. > -Load/Save to registry whether we want to wrap long lines or not. Please one patch per email. You should combine all of your changes into one patch if that's one logical change and can be applied by itself. Of course resultant code should compile and work. > @@ -638,6 +641,8 @@ > Globals.hFont=CreateFontIndirect( &lf ); > Globals.lfFont=lf; > SendMessage( Globals.hEdit, WM_SETFONT, (WPARAM)Globals.hFont, (LPARAM)TRUE ); > + SETTINGS_SaveSettings(); > + Please respect indentation. Don't just copy&paste stuff all over the file. > VOID DIALOG_Search(VOID) > { > + > + if (Globals.find.hwndOwner == NULL) { > ZeroMemory(&Globals.find, sizeof(Globals.find)); > + } > Globals.find.lStructSize = sizeof(Globals.find); > Globals.find.hwndOwner = Globals.hMainWnd; Pretty much the same here: don't just insert stuff, indent it properly. And please no extra blank lines nor needles curly brackets. > + if (Globals.replace.hwndOwner == NULL) { > + ZeroMemory(&Globals.replace, sizeof(Globals.replace)); > + } Respect indentation and style of the file you changing. In this case 4-spaces not 2. > + Globals.hFindReplaceDlg = ReplaceText(&Globals.replace); > + assert(Globals.hFindReplaceDlg != 0); > +} Please don't use assert. Do a proper error checking instead. > + if (result == -1) { /* text not found. */ > + MessageBoxA(Globals.hEdit, "Cannot find text.", NULL, MB_OK | MB_ICONINFORMATION); > + } else { You should put all the text into resource files. > +WCHAR *GrabWindowTextW(HWND hWnd, DWORD *nbytes) { > + > + static WCHAR *data = NULL; > + DWORD _nbytes = 0; > + > + if (nbytes == NULL) nbytes = &_nbytes; > + > + *nbytes = (*nbytes == 0 ? GetWindowTextLengthW(hWnd) + 1 : *nbytes); > + data = HeapAlloc(GetProcessHeap(), 0, (*nbytes) * sizeof(WCHAR)); > + GetWindowTextW(hWnd, data, (*nbytes)+1); > + return data; > +} Why do you need static if you return allocated buffer? nbytes is misleading - it should be nchars. (*nbytes)+1 is incorrect. You allocated enough memory for *nbytes only. > +int SearchText(HWND hWnd, LPFINDREPLACE find, int pos); Please use windows types so they would work right on 64-bit platforms. > + "^R", CMD_REPLACE Native notepad has it as ctrl+H. Vitaliy Margolen

3 4

Re: netapi32: Improve NetUserGetInfo function
by Joris Huizer June 10, 2006

June 10, 2006

Simon Kissane wrote: > netapi32: Improve NetUserGetInfo function > * Implemented support for all levels documented by MSDN > * Corrected error codes for nonexistent levels > * Now works with empty string as server name > > I have also attached a C program (which can be compiled with MINGW), > which tests the NetUserGetInfo functionality. > Perhaps you could write unit tests based on the test program, to show correctness of the current code - this helps avoiding regressions HTH, Joris

1 0

kernel32.VerSetConditionMask present
by Vitaly Lipatov June 10, 2006

June 10, 2006

VerSetConditionMask function is introduced in kernel32 science Windows 2000. Some broken applications check VerSetConditionMask present via GetProcAddress for check version of running Windows. What is the preferable method to disable export VerSetConditionMask from kernel32 when we have win98 version? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: svrapi: add stub implementation [try 2]
by Robert Shearman June 10, 2006

June 10, 2006

Vitaly Lipatov wrote: >+1 stub NetAccessAdd >+2 stub NetAccessCheck >+3 stub NetAccessDel >+4 stub NetAccessEnum >+5 stub NetAccessGetInfo >+6 stub NetAccessGetUserPerms >+7 stub NetAccessSetInfo >+8 stub NetConnectionEnum >+9 stub NetFileClose2 >+10 stub NetFileEnum >+11 stub NetSecurityGetInfo >+12 stub NetServerGetInfo >+13 stub NetSessionDel >+14 stub NetSessionEnum >+15 stub NetSessionGetInfo >+16 stub NetShareAdd >+17 stub NetShareDel >+18 stdcall NetShareEnum(str long ptr long ptr ptr) >+19 stub NetShareGetInfo >+20 stub NetShareSetInfo > > These should all be just exported by name (@) not also by ordinal judging by the fact that they are in alphabetical order. -- Rob Shearman

1 0

Re: WineD3D: Fog fixes
by Jesse Allen June 10, 2006

June 10, 2006

On 6/9/06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch corrects a few issues with fog on transformed vertices, and > non-pixel-non-vertex fog. > > If WINED3DRS_FOGENABLE is TRUE, but WINED3RS_FOGVERTEXMODE and > WINED3DRS_FOGTABLEMODE are D3DFOG_NONE, then, according to the msdn, the > alpha channel specular color vertex color contains a pre-calculated fog > value. The same applied to transformed vertices if Vertexfog is enabled. This > patch uses glFogCoord to pass it to GL if GL_EXT_fog_coord is supported, and > disables GL fog if it isn't to minimize rendering issues. > > This patch makes Swat3 and Battlezone 2 happy, and the fog in Prince of Persia > 3D looks more correct now. I hoped that patch might solve the disappearing > objects problem in Half-Life 2, but unfortunately it doesn't, this seems not > to be fog-related :-( > > ChangeLog: > Stefan Dösinger(for CodeWeavers): Fog fixes > > This patch doesn't work with the latest fglrx saying missing symbol for glFogCoordf. Mesa is ok though. Jesse

2 1

winspool/tests: Tests for GetPrintProcessorDirectory (resend for current HEAD)
by Detlef Riekenberg June 9, 2006

June 9, 2006

Am Freitag, den 02.06.2006, 00:11 +0200 schrieb Detlef Riekenberg: > Changelog: > - winspool/tests: Tests for GetPrintProcessorDirectory > Resend for current HEAD -- By By ... ... Detlef

1 0

Re: Yet another round of redundand NULL checks before HeapFree (found by Smatch).
by Michael Stefaniuc June 9, 2006

June 9, 2006

Please disregard this patch as a false positive crept in. Michael Stefaniuc wrote: > hopefully this should be the last round of redundand NULL checks before > HeapFree removals. I know, famous last words. But this time i have > extended the redundant_null_check.pl Smatch script to find all non-null > variables from arbitrary complex if-expressions and check that any of > them dosn't get HeapFree'd on the truth path. > diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c > index e537bc4..bec3526 100644 > --- a/dlls/msacm32/driver.c > +++ b/dlls/msacm32/driver.c > @@ -587,7 +587,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVE > return MMSYSERR_NOERROR; > gotError: > WARN("failed: ret = %08x\n", ret); > - if (pad && !pad->hDrvr) > + if (!pad->hDrvr) nice NULL pointer dereference. > HeapFree(MSACM_hHeap, 0, pad); > return ret; > } bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 2

Re: user: Added specific winproc functions for calling dialog procedures.
by James Hawkins June 9, 2006

June 9, 2006

Hey Alexandre, As of the following commit: Commit: 397bf3c2b133fe36529efcc4c1906bac1aac2da8 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=397bf3c2b133fe36529efcc… Author: Alexandre Julliard <julliard at winehq.org> Date: Tue May 9 20:33:11 2006 +0200 user: Added specific winproc functions for calling dialog procedures. The VB/VC++ 6 installers crash pretty early in the setup sequence. Two things to keep in mind are that the installer works correctly if I set the win version to win98, or I revert the following part of the patch: @@ -447,14 +441,8 @@ LRESULT WINAPI DefDlgProcA( HWND hwnd, U SetWindowLongPtrW( hwnd, DWLP_MSGRESULT, 0 ); - if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) - { - /* Call dialog procedure */ - result = CallWindowProcA( dlgproc, hwnd, msg, wParam, lParam ); - /* 16 bit dlg procs only return BOOL16 */ - if( WINPROC_GetProcType( dlgproc ) == WIN_PROC_16 ) - result = LOWORD(result); - } + if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) /* Call dialog procedure */ + result = WINPROC_CallDlgProcA( dlgproc, hwnd, msg, wParam, lParam ); if (!result && IsWindow(hwnd)) { I've done a fair bit of digging around on this bug, and I've noticed some things that are probably obvious to you, but might help put light on the situation for others. The order of the calls before the patch is applied is: DefDlgProcA -> CallWindowProcA -> WINPROC_CallWndProc and after the patch is applied: DefDlgProcA -> WINPROC_CallDlgProcA -> WINPROC_CallWndProc I've added debug printf's in these functions to see when they're called and what certain pointers contain. With the patch applied and and win version set to win98, the debug output is the same: DefDlgProcA CallWindowProcA func: 0xffff0027 CallWindowProcA proc: 0x40a5e1ac WINPROC_CallWndProc proc: 0x403020 CallWindowProcA func: 0x41ea2020 CallWindowProcA handle_to_proc returned NULL WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 CallWindowProcA func: 0x41ea2020 CallWindowProcA handle_to_proc returned NULL WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 and the installer goes on as usual (we know this because of a richedit trace from the richedit control on the next install screen). Here is the debug output with the patch applied and version set to win2000: DefDlgProcA DefDlgProcA dlgproc: 0xffff0026 WINPROC_CallDlgProcA func: 0xffff0026 WINPROC_CallDlgProcA proc: 0x40a5e1f8 WINPROC_CallDlgProcA proc->thunk.proc: 0x412020 WINPROC_CallWndProc proc: 0x412020 wine: Unhandled page fault on read access to 0x00000000 at address 0x411799 (thread 0009), starting debugger... Any insight you can provide about this bug would be greatly appreciated. -- James Hawkins

1 0

Re: [WINED3D 2/9] Add the bulk of the GLSL string generation functions
by H. Verbeet June 9, 2006

June 9, 2006

Is making the distinction between rgba and xyzw really needed? xyzw / rgba / stpq should be equivalent and the distinction is mostly for readability if you know the variable type. However, since you can't decided that purely based on whether something is a vertex shader or a pixel shader, the way it's currently done might be misleading in some cases.

2 1

Re: [WINED3D 9/9] Allow drawPrim to create and use the GLSL program
by H. Verbeet June 9, 2006

June 9, 2006

Does this reset the currently used program to 0 when fixed function is supposed to be used again? I think we should just do glUseProgramObjectARB(programId), since when fixed function is supposed to be used the program id will be 0. That also mean you don't have to do an explicit glUseProgramObjectARB(0) at a later stage, which saves an extra shader switch, in particular if the same shader is used in the next DrawPrimitive call.

1 0

Re: Update the progress control while installing.
by Dmitry Timoshkov June 9, 2006

June 9, 2006

"Mike McCormack" <mike(a)codeweavers.com> wrote: > --- a/dlls/msi/dialog.c > +++ b/dlls/msi/dialog.c > @@ -62,6 +62,8 @@ struct msi_control_tag > HICON hIcon; > LPWSTR tabnext; > HMODULE hDll; > + float progress_current; > + float progress_max; Is it really necessary to use float instead of long? -- Dmitry.

1 0

Re: notepad patches (search/replace, etc)
by Andreas Mohr June 9, 2006

June 9, 2006

Hi, On Thu, Jun 08, 2006 at 08:40:33PM -0400, Anoni Moose wrote: > This is my first patch to an open source project... if anyone has any > comments/suggestions, please tell me. :) I can't help but say that your parents must have been giving you a rather "funny" name... Or, IOW, do we have any guidelines about "Anoni Moose" submissions to our project? Are they ok, not ok, ok? Loves me, loves me not, ... Anyway, thanks for a very nice collection of patches! Andreas Mohr

3 3

Re: notepad: settings saving code
by Robert Shearman June 9, 2006

June 9, 2006

Anoni Moose wrote: >/* This table is used to save all of the needed font settings in Notepad. > * It looks quite messy, when in fact it _hugely_ eases loading/setting of settings. Really. ;) > * It is layed out as follows: > * > * [n][0] == pointer to registry subkey name (WCHAR) > * [n][1] == type of registry entry > * [n][2] == pointer to buffer to store setting > * [n][3] == size of data returned > * [n][4] == default value to use if subkey was not found > * [n][5] == registry path to open (ANSI, not including root (HKEY_CURRENT_USER, etc)) > */ >DWORD settings_data[15][6] = { > { (DWORD)&heightW, REG_DWORD, (DWORD)&Globals.lfFont.lfHeight, > sizeof(REG_DWORD), -10, (DWORD)&FONT_SETTINGS_REG_PATH }, > > You should define a proper structure to put this data in rather than casting the values to DWORD (which won't work in 64-bit mode). -- Rob Shearman

1 0

Re: regedit: bug fixes/feature
by Robert Shearman June 9, 2006

June 9, 2006

Anoni Moose wrote: > These patches save current node on click, and remove items before > opening keys, so if a node has no keys/is invalid, no keys show, which > can lead to problems. Changelog: > > * programs/regedit/main.c, programs/regedit/childwnd.c: > regedit: Save current node to registry on change; load again after > regedit is reopened. > -Don't UpdateWindow() in InitInstance() (unneeded, adds > flicker). > -Delete all items from listview before opening key, so if > key open fails, no items display. > This patch looks good, but I'm not sure about removing the UpdateWindow call. I think it is still necessary, although it might be better to move it to after the getting of the default path, which should remove the flicker. -- Rob Shearman

1 0

Re: regedit: Refresh also refresh registry keys in listview
by James Hawkins June 8, 2006

June 8, 2006

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > These patches allow for refreshing of registry keys in listview, when > Refresh menu item is selected. > > Changelog: > > * programs/regedit/framewnd.c, programs/regedit/treeview.c: > regedit: Uncomment RefreshListView() call, comment TVM_SELECTITEM call, > to > let "Refresh" menu item/key also refresh registry values being > shown > in treeview. > One patch per email please. Same goes for all your other submissions. -- James Hawkins

1 0

Re: edit: Fix crashing, bugs
by James Hawkins June 8, 2006

June 8, 2006

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > This patch fix an unhandled page fault with MS notepad and Wine Notepad when > loading/editing large files, and some other bugs shown in the Changelog: > > * dlls/user/edit.c: > user: Fixed unhandled page-fault when text length exceeded buffer size. > -Don't gradually continue to highlight text if mouse button is > held in and > it's position moves out of the edit window, and doesn't move while > outside. > -Scroll up/down if mouse is outside of window and moving up/down. > -If a button was clicked in a dialog, therefore setting the focus > to it, and then > an application sent a SETFOCUS message to an editbox, it would > keep the focus on > the button. > You need to submit one fix per patch, one patch per email. -- James Hawkins

1 0

Re: str*casecmpW functions
by Vitaliy Margolen June 8, 2006

June 8, 2006

Thursday, June 8, 2006, 6:57:36 PM, Anoni Moose wrote: > This patch adds some functions for comparison of WCHAR strings, while ignoring case. Changelog: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. BTW what's wrong with strncmpiW? Vitaliy Margolen

1 0

Re: server: use getopt
by Mike McCormack June 8, 2006

June 8, 2006

Anoni Moose wrote: > This patch let's the server code use getopt to parse arguments. + while ((optchr = getopt(argc, argv, "d:fhk:p:vw")) != -1 && + optind < argc) { /* 'Tis possible we might have a variable declaration... */ + + switch (optchr) { + case 'd': - if (isdigit(argv[i][2])) debug_level = atoi( argv[i] + 2 ); + if (isdigit(optarg[0])) debug_level = atoi( optarg ); else debug_level++; break; Using getopt() doesn't really gain us anything here. Also, changing the indent and brace style to suit yourself (especially in wineserver) isn't appreciated. Mike

1 0

Re: wcmd: some features/bug fixes
by Mike McCormack June 8, 2006

June 8, 2006

Anoni Moose wrote: > * programs/wcmd/builtins.c, programs/wcmd/wcmdmain.c, > programs/wcmd/wcmd.h: > wcmd: Clear terminal screen using escape code. > -Fix infinite file-read loop with TYPE command. > -TITLE command use terminal escape code. > -Added FREEDISK command. Please send one patch per email. The patch should be standalone. + /* Clear the _terminal_ screen by giving the correct terminal escape code. */ + printf("%cc", 0x1B); You can't assume that you'll be using any sort of terminal here. If the backend is wineconsole or a non-xterm/vt100 terminal, then this won't work. You have to use the Win32 API. Mike

1 0

Re: str*casecmpW functions
by Mike McCormack June 8, 2006

June 8, 2006

Anoni Moose wrote: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. You've added a dependency on user32.tolowerW, which cannot be linked from all the places that unicode.h is used. Mike

1 0

Re: notepad: settings saving code
by Mike McCormack June 8, 2006

June 8, 2006

Anoni Moose wrote: > The following files allow saving and loading of notepad's settings to > the registry. No patch needed... new files. Changelog: Always send a patch, and make sure to create it from your wine/ directory so that the full path of the file that you're modifying is specified. These files won't be compiled unless you add something to the Makefile.in, and can't be used without some kind of change to the existing code. Mike

1 0

xlldrv/keyboard.c: Report of typos
by Andrew Talbot June 8, 2006

June 8, 2006

I believe there are numerous typos in this file. Starting at line 310, there seem to be several missing double quotes; they break compilation if -Wwrite-strings is specified. I was going to assume the missing quotes to be the only factor and fix things myself. But as there are some non-printing characters in there that I don't understand, I thought I would mention it here, instead, so that someone who knows about keyboard layouts might fix these arrays properly. -- Andy.

3 3

Prospects of an OpenAL audio driver...
by Nick Burns June 8, 2006

June 8, 2006

I have started work on an openal driver for wine... So far I have playback and recording working (with minor issues) (for some reason the DSound HEL is unhappy with my driver) OpenAL seems to have enough functionality to do the job. Are there any problems with using OpenAL for such a purpose? - Nick

3 7

Feedback requested for Mac OSX x86 stack patch
by Nick Burns June 8, 2006

June 8, 2006

(notes are at the top of the patch) I would like some feedback on my stack fix patch I do not know how it interacts with linux -- no access to a linux box This has been confirmed to fix numerous app issues (due to stack alignment) I am starting to think it would be better to have these options configured at config time -- e.g. If Mac OSX x86 -- then use mstackrealign + force_align_arg_pointer Any ideas/thoughts? - Nick

3 12

Feedback requested for Mac OSX x86 stack patch -- #2
by Nick Burns June 8, 2006

June 8, 2006

Ok I have fixed up my Mac OSX stack patch a bit as per the feedback -- thanks much This only patches windef.h There still needs to be some solution for msvcrt AND any other api entry points that are not denoted with __stdcall or __cdecl or WINAPI or WINAPIV.... This means that Morrowwind (uses msvcrt:pow just cause) will crash on OSX atm (bad alignment) - Nick

2 2

Feedback requested on an OpenAL audio driver patch -- #2
by Nick Burns June 8, 2006

June 8, 2006

Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff 2. configure.ac now checks for AL/al.h (which is where OpenAL should be) 3. dlls/Makefile.in should patch correctly now (I did not hand edit it this time -- still crossing fingers) 4. FIXME's -> ERR's for the legit OpenAL errs 5. alcCloseDevice in OpenAL 1.0 (no return value) in 1.1 it returns a boolean -- .: I dont check the boolean anymore -- meaning this error is now slient - Nick

2 2

Re: Linux noob
by Molle Bestefich June 8, 2006

June 8, 2006

Peter Beutner wrote: > Because it is the defacto standard to store settings > under ~/.<appname>. Only for stuff that's thought to be generally uninteresting. Your KDE desktop, for example, resides under ~/Desktop. > And with enough applications installed that use this "standard" > you probably will be glad that these directories are hidden so that > you don't have to scroll through them every time you open > your filemanager ;). I'm annoyed that .wine is inaccessible through KDE and Gnome apps. Not through the file manager, but often in various applications. It's not wine's fault per se that those apps lack a "show hidden folders" option, but it would be nice to make wine visible, as it contains useful stuff that you'll often mangle with. (I personally have a symlink from "wine" to ".wine"...) I do agree that there's too many applications dumping various .xxxxxx folders in my home directory. The least they could do is to put those files somewhere where they don't interfere with my user data, someplace sane like ~/Application Data/xxxxxx, or a more unixy ~/appdata/xxxxx... (Never cared much for hidden folders - they're a symptom that you're being too careless with your directory structure.)

6 13

Re: [MAPI32 2/3] interface IProfAdmin & its 12 methods, function MAPIAdminProfiles implemented
by Alexandre Julliard June 8, 2006

June 8, 2006

argentum(a)office.etersoft.ru writes: > +/************************************************************************** > + * IProfAdmin_GetLastError > + * > + * PARAMS > + * hResult [I] HRESULT data type containing the error value > + * generated in the previous method call. > + * lppMAPIError [O] Pointer to a pointer to the MAPIERROR structure > + * containing version, component, and context information > + * for the error. The lppMAPIError parameter can be set > + * to NULL if there is no MAPIERROR structure to return. > + * ulFlags [I] Bitmask of flags that controls the type of the string > + * pointed to by lpszProfileName. The following flag can be set: > + * 0 The strings in the structure returned in the pointer parameter > + * are in ANSI format > + * MAPI_UNICODE The structure's strings are in Unicode format. > + * RETURNS > + * S_OK The call succeeded and has returned the expected value or values. > + * MAPI_E_BAD_CHARWIDTH Either the MAPI_UNICODE flag was set and the implementation > + * does not support Unicode, or MAPI_UNICODE was not set and the > + * implementation only supports Unicode. > + */ Copying text from MSDN is not acceptable. If you are going to write documentation you have to do it in your own words, without looking at MSDN. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Feedback requested on an OpenAL audio driver patch -- #2
by Nick Burns June 8, 2006

June 8, 2006

(the elusive attachment) It helps when I hit the attach button (sorry) - Nick

1 0

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag June 8, 2006

June 8, 2006

P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon

3 2

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag June 7, 2006

June 7, 2006

> AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ > AudioUnit/AudioUnit.h \ > CoreAudio/CoreAudio.h \ > IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Suse 10.1) puts openal headers to AL/ instead of al/ and so configure with the patch as-is doesn't find files on my system. Also patching dlls/makefile.in fails. Had to patch it manually. Leon

2 1

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag June 7, 2006

June 7, 2006

My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal version is 1.0.20051129) 2) It'd be better to convert ALC errors from FIXMEs to ERRs. 3) You don't link the driver to openal somewhy (there's no -lopenal switch passed to gcc). Perhaps it's related to the configure.in hack I made, but I had to modify dlls/winmm/wineopenal/Makefile.in and add openal there too. 4) You check for al/al.h and OpenAL/al.h within the configure script but you include AL/al.h and OpenAL/al.h. This doesn't work on Linux, since Linux filesystems are case sensitive. Leon

2 1

Feedback requested on an OpenAL audio driver patch
by Nick Burns June 7, 2006

June 7, 2006

I finally figured out my dsound HEL problem (was making too many buffers) -- now I wait and only use a few buffers. It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) Remove the disable 'OPENAL_DISABLE_IN' to test wavein. (Forced off due to some issues of my OpenAL framework (I could only record at 44k -- could not figure out how to force 44k only for wavein) -- others may have better luck) So here is my patch -- It adds it to winecfg, the makefile.in, configure.ac And it adds the new files (the actual driver why not) I would like any feedback ppl out there may have. (It is missing a ChangeLog thingy -- that would look like the below) ---- 2006-06-04 Nick Burns <adger44(a)hotmail.com> * configure.ac: Added checks for OpenAL (Mac OSX and linux). * dlls/Makefile.in: Added OpenAL to build thingy. * include/config.h.in: Added OpenAL to config -- using autoheader (may not be needed). * programs/winecfg/audio.c: Added OpenAL to winecfg for choosing. * dlls/winmm/wineopenal/openal.c, dlls/winmm/wineopenal/openal.h, dlls/winmm/wineopenal/audio.c, dlls/winmm/wineopenal/wineopenal.drv.spec, dlls/winmm/wineopenal/Makefile.in: Initial checkin of OpenAL driver. ---- - Nick

2 2

Re: [KERNEL 1/2] changed test for function FindFirstFileA to find dosdevices
by Vitaliy Margolen June 7, 2006

June 7, 2006

Wednesday, June 7, 2006, 9:03:43 AM, Konstantin Petrov wrote: > changed test for function FindFirstFileA to find dosdevices. > As function FindFirstFile must accept such paths as > "c:\\windows\\win.ini" > "c:\\NUL", > "c:\\COM1", > "c:\\LPT1", > "c:\\LPT9", > "c:\\COM9", > "c:\\CON", > "c:\\AUX", > "c:\\PRN" > and mustn't accept paths: > "\\\\.\\CON", > "c:\\COM0", > "", > "c:\\LPT0", That's because you have only one serial and one parallel port. The special name is the special name. It's different how win9x and winNT handles them. Which system have you ran these tests on? Vitaliy Margolen

1 0

Re: shell32: Write-strings warning fix
by Robert Shearman June 7, 2006

June 7, 2006

Andrew Talbot wrote: >Changelog: > shell32: Write-strings warning fix. > >diff -urN a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c >--- a/dlls/shell32/shlview.c 2006-05-23 17:24:50.000000000 +0100 >+++ b/dlls/shell32/shlview.c 2006-06-07 19:37:41.000000000 +0100 >@@ -779,7 +779,9 @@ > */ > > static void ShellView_MergeViewMenu(IShellViewImpl * This, HMENU hSubMenu) >-{ MENUITEMINFOA mii; >+{ >+ MENUITEMINFOA mii; >+ static CHAR mii_type_data[] = "View"; > > TRACE("(%p)->(submenu=%p)\n",This,hSubMenu); > >@@ -791,7 +793,7 @@ > mii.cbSize = sizeof(mii); > mii.fMask = MIIM_SUBMENU | MIIM_TYPE | MIIM_DATA; > mii.fType = MFT_STRING; >- mii.dwTypeData = "View"; >+ mii.dwTypeData = mii_type_data; > mii.hSubMenu = LoadMenuA(shell32_hInstance, "MENU_001"); > InsertMenuItemA(hSubMenu, FCIDM_MENU_VIEW_SEP_OPTIONS, FALSE, &mii); > } > Sorry, this is wrong. If InsertMenuItemA writes to the string then it will be corrupted and will display the wrong thing for further uses in the process. It is therefore better to cast it from a "const char *" into a "char *" or to make it a non-static array at the top of the function. I think the first choice of keeping it a "const char *" is the best choice in this case. -- Rob Shearman

2 2

re: lstrlen(A/W) patch
by Dan Kegel June 7, 2006

June 7, 2006

Clinton wrote: >> Does the Richedit control return an error, or clear itself when passed >> EM_SETTEXTEX with lParam = NULL? >On Windows, it returns 1 and clears itself. Unless the ST_SELECTION >flag is set, in which case it returns 0, and actually replaces the text >with nothing. >My patch to wine results in the same behavior. I'll send it to >wine-patches. Great! Any chance you could include a conformance test in your patch? Thanks, Dan

1 0

Re: [uxtheme/tests] Add initial tests (Second try)
by Paul Vriens June 7, 2006

June 7, 2006

On Wed, 2006-06-07 at 08:44 +0200, Paul Vriens wrote: > Hi, > > I've added the framework and some initial (simple) tests. No > functionality tests (yet), only parameter and return-value checking. > > This one also 'fixes' the tests for Wine when theming is enabled. > > Changelog > Added framework and initial tests > > Cheers, > > Paul. Anything I can do to improve? This patch will of course be followed up by fixes. Cheers, Paul.

1 0

Hal and functions in setupapi
by Christian Gmeiner June 7, 2006

June 7, 2006

Hi all... at the momemt i am reading into functions to get some informations about e.g. cdrom drives. At the moment i am loking into SetupDiGetClassDevsW to support GUID_DEVINTERFACE_CDROM and later USB devices. My overall goal is it to get Line 6 software for my guitart effect board (USB) working with wine. Now i thought about a way to get all informations about a singe cdrom device. And i thought that I could use HAL perfectly for this. I thought about this way of doing it: Add hal.c file to setupapi dll, which contains function to get infromations about all needed hardware. This should work very nicly for this case. But as I want to programm RegisterDeviceNotification also we need a central way to handle hal stuff. So how should I go on? Use some own hal.c in setupapi or add an global wine way to interact with hal? Thanks, Christian

3 2

Re: libunicode: Add some more code page tables that are available for download from ftp.unicode.org, most notably the table for the us-ascii encoding, which is quite common.
by Alexandre Julliard June 7, 2006

June 7, 2006

Robert Shearman <rob(a)codeweavers.com> writes: > libs/unicode/Makefile.in | 3 > libs/unicode/c_1361.c | 5138 > ++++++++++++++++++++++++++++++++++++++++++++++ > libs/unicode/c_20000.c | 3587 ++++++++++++++++++++++++++++++++ > libs/unicode/c_20127.c | 683 ++++++ > libs/unicode/cpmap.pl | 3 > libs/unicode/cptable.c | 8 This won't work, the source files are not in the expected format, so the resulting tables contain garbage. You'll need to teach cpmap.pl to parse these files correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Avoid unnecessary casts
by Detlef Riekenberg June 7, 2006

June 7, 2006

Am Mittwoch, den 07.06.2006, 16:45 +0900 schrieb Dmitry Timoshkov: > - psh.u3.ppsp = (LPCPROPSHEETPAGEW) & psp; > + psh.u3.ppsp = psp; Where is the "&" ? -- By By ... ... Detlef

1 0

Re: [WINED3D 2/3] Fix missing light recording
by Michael Stefaniuc June 7, 2006

June 7, 2006

Ivan Gyurdiev wrote: > >> >From nobody Mon Sep 17 00:00:00 2001 >> > > Please delete this line in case the patch is corrupt.. missed it The patch is not corrupted as it starts only with the '---' line. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: lstrlen(A/W) patch
by Mike McCormack June 6, 2006

June 6, 2006

Clinton Stimpson wrote: > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" The inline lstrlenW is used only internally by Wine code, and we want it to crash when passed a NULL pointer. In this case, you should fix the Wine code calling lstrlenW to not use a NULL pointer. Mike

2 3

Re: D3D9: Add a test for setting / getting vertex shader constants
by Raphael June 6, 2006

June 6, 2006

On Tuesday 06 June 2006 23:17, H. Verbeet wrote: > This is a test for Ivan's patch for shader constants > (http://source.winehq.org/git/?p=wine.git;a=commit;h=5f5969b3c5bd237277b8f2 >f1eaa4ddacce5fb63b) > > Changelog: > - Add a test for setting / getting vertex shader constants Simple testing :) can you add border tests in future: hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 4, bool_in, 4); hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 2, bool_in, 4); I'm interested to see how windows handle that :) Regards, Raphael

3 3

winedbg - setting breakpoint
by Stephen Clark June 6, 2006

June 6, 2006

Hello List, I am trying to get classic Myst to run again under wine. How do I set a breakpoint in it when it run by winevdm. Thanks, Steve -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson)

2 1

re: Hal and functions in setupapi
by Dan Kegel June 6, 2006

June 6, 2006

Christian wrote: > as I want to programm RegisterDeviceNotification also we > need a central way to handle hal stuff. > > So how should I go on? Use some own hal.c in setupapi or > add an global wine way to interact with hal? I think programs/explorer already registers for device notification with hal. You should look at that before you go on. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: APPDB patch
by Tony Lambregts June 6, 2006

June 6, 2006

EA Durbin wrote: > fixed typographical errors. > > > ------------------------------------------------------------------------ > > ? patch.diff > Index: TODO > =================================================================== > RCS file: /home/wine/appdb/TODO,v > retrieving revision 1.22 > diff -u -p -r1.22 TODO > --- TODO 12 Jun 2005 02:50:18 -0000 1.22 > +++ TODO 6 Jun 2006 02:19:34 -0000 > @@ -7,7 +7,7 @@ WineHQ Application Database TODO List > AppDB Todo: > > * Improve application/version submission process > - Currently a user submits an application/version and a admin reviews it and > + Currently a user submits an application/version and an admin reviews it and > either makes changes to it and accepts it or writes a comment and rejects it. Upon > rejection the submission is deleted > > There is no sense in keeping our todos in two places. We should probabably just point to the wiki in this file. http://wiki.winehq.org/AppdbInfo Tony Lambregts

1 0

Re: lstrlen(A/W) patch
by Andreas Mohr June 6, 2006

June 6, 2006

Hi, On Mon, Jun 05, 2006 at 09:24:24PM -0600, Clinton Stimpson wrote: > > I encountered a crash when using PAF 5.2. > > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" MSDN documentation says many things... most of them wrong. ;-) (only slightly exaggerated, given Wine's experience with MSDN "correctness" over the years) IOW, I severely doubt that this is indeed the way Windows behaves, otherwise it'd have been fixed in Wine a long time ago already since apps would rely on and fully expect this behaviour of such a central and important function. Most likely you encountered application misbehaviour (feeding a NULL parameter to a function expecting non-NULL) due to a different Wine bug which thus caused the app to mis-step. Would be interesting to figure out why this happened (e.g. via +relay trace). Andreas Mohr

1 0

Wine updated in Fedora Extras!
by Neal Gompa June 6, 2006

June 6, 2006

Wine has been updated to 0.9.14 on May 30, 2006! So, this release took 6 days... Still, generally 3-5 days is pretty good estimation...

1 0

Re: winedbg: remove unneeded states from grammar (take 2)
by Alexandre Julliard June 6, 2006

June 6, 2006

Juan Lang <juan_lang(a)yahoo.com> writes: > Oops, last one had a missing brace. Sorry about that. > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them Won't that make it impossible to use command keywords as identifiers in commands that accept them, like disass? Come to think of it, your previous NOCMD patch probably has the same issue. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: wined3d: Another GLSL shader status update
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >A: wine-devel(a)winehq.com >De: Mike Hearn <mike(a)plan99.net> >Date: Tue, 06 Jun 2006 12:31:06 +0100 >Sujet: Re: wined3d: Another GLSL shader status update > >On Sun, 04 Jun 2006 12:04:21 -0400, Jason Green wrote: >> > This is an elaborate scheme with linked lists in each shader - is that >> > really necessary? >> > I'm very confused after reading the code (but maybe that's just me :) >> >> If we link the programs together every time the Set__Shader() is called, >> it brings performance to a halt (that what my glsl_hack4.diff did). > >Re: the recent discussion on code commenting and documentation, it'd be >nice if the patch explained this somewhere. It'd be even nicer still if at >some point one of you guys could take a break from the codeface and write >a chapter for the Wine Developer Guide on shaders and how all this works >... it seems incredibly opaque and the last thing we want is a re-run of >the DCOM situation where the only people who understood it left or hacked >on other things for a while and we lost the knowledge of how it worked. I Aggree that adding more comments about current architecture (at least on http://wiki.winehq.com/DirectX-Shaders and http://wiki.winehq.com/WineD3D) can help to better understand for non-d3d introduced wine hackers :) I was the first who delivered that code and it's my fault for the initial poor comments about architecture (who was understandable for opengl/directx hackers). We'll try to improve it (maybe beginning with "WineD3D for dummies" :) ) Anyway we are many who understand this code (and reviewing the flood of wined3d patches) so "DCOM situation" cannot happen :) >thanks -mike Regards, Raphael

1 0

Re: Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >Date: Tue, 06 Jun 2006 04:54:17 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: fenix(a)club-internet.fr >Copie à: wine-devel(a)winehq.org >Sujet: Re: [WINED3D 5/5] Remove constant type field in stateblock. > >Hi Raphael, > >Strange, your email shows up as an attachment. Yes it's my webmail who have strange behaviors :( > > + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start > > + 1)); > > should be: > > if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; > > UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); > > > as count and start are UINT (better to avoid ugliy > > unsigned/signed bugs). > >The current code checks if cnt < 0 later on. Yes but it was buggy :) MAX_VSHADER_CONSTANTS - (start + 1) can result on an unsigned overflow > > Anyway what windows do if (start + count > > > MAX_VSHADER_CONSTANTS) ? > > The code seems handle this case truncating the input > >It's possible that this is buggy [ I always thought it was off by one ], >or not handling this case properly. However, I've just copied the code >that was already there - unrolled the existing SetConstant function into >its callers, and made the change I was interested in. Fixing other bugs >would go into a separate patch. Ok, fine for me Waiting for more patches to review :) I'm really waiting to get my new GC to test last impressive work on shaders. Regards, Raphael

1 0

To K&R or not
by Molle Bestefich June 6, 2006

June 6, 2006

EA Durbin wrote: > >K&R style brack placements > > They are an eyesore and make things difficult to read. Highly subjective. I think K&R has distinct advantages, namely it unites the scope begin token with the relevant control statement. For me, this makes code easier and faster to read, since I can follow the indentation and arrive immediately at the relevant control statement. Also I think that K&R is nice in that it saves screen real estate, which again for me makes code easier to read because I can see more of it at once. I personally consider non-K&R style an eyesore because of this. CMIIW, but the only thing that non-K&R has going for it is that you can visually make out whether you've made the correct number of opening versus closing braces. I don't think that's much of an advantage, especially considering that any modern source code editor will highlight the starting brace or relevant control statement for you. That said, I don't care what people do, I can read both... In my perfect world though, my SCM client would convert source code to my preferred format on checkout, and to whatever universal format the repository uses on checkin. Ho hum...

7 11

Re: Re: Linux noob
by Mike Hearn June 6, 2006

June 6, 2006

On Tue, 06 Jun 2006 03:27:52 +0000, NikNot wrote: > Indeed! This is something that I found infuriating since I first > used wine. What possible reason would there be to make this > a "hidden" directory? From whom exactly should it be hidden > and why? Historical reasons. I'm switching this thread to wine-devel as TransGaming do in fact make the virtual C drive visible by default and it's maybe something we should do too. On the other hand, it might just be wallpapering over other usability problems (lack of menu integration, most obviously). How often does average jack need to go poking around C:\Program Files in real Windows? thanks -mike

1 0

re: acad 2004 license file bug
by Dan Kegel June 6, 2006

June 6, 2006

Jaap wrote: >The autocad installer indicated that I needed internet explorer 6.0, >so I installed that using winetools. Don't use winetools, please. As you noticed, it does bad things to your ~/.wine. Or, if you do use it, please report problems to the winetools developer, not here. > (can wine fake internet explorer, >so i don't need to install the real thing?) Yes. Here's what I do: # Fake IE per workaround in http://bugs.winehq.org/show_bug.cgi?id=3453 wineserver -k cat >> $HOME/.wine/system.reg <<"_EOF_" [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" _EOF_ - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

DirectX blitter bug
by Mike Hearn June 6, 2006

June 6, 2006

Lords of Magic works perfectly EXCEPT that rendering is corrupted when it is using DirectX "fast blitting"; they provide a software emulated workaround for some truly ancient cards (Matrox Mystique anyone?) and the game works well in this mode. But it should work properly in DirectX accelerated mode too. The kind of corruption varies but it appears as, for instance, mouse trails which to me suggests some kind of co-ordinate system problem. The demo is here: ftp://ftp.sierra.com/pub/sierra/lordsofmagic/demos/si_lordsofmagic_demo.exe and it installs cleanly on the master branch. If any DirectDraw gurus want to take a look, please do! I bet this problem affects other games too.... thanks -mike

2 2

Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >Date: Tue, 06 Jun 2006 02:46:59 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: wine patch <wine-patches(a)winehq.org> >Sujet: [WINED3D 5/5] Remove constant type field in stateblock. > >It is wrong to maintain a mapping from a constant index to a type field, >because different constant types do not share an index - boolean >constant 0 is supposed to co-exist with floating point constant 0, not >replace it. Drawprim and other code using the type array to decide >whether to look up a constant in bools, floats, or ints is wrong - you >can't make that decision based on the index. > >To do this: >========== >- split .set and .changed stateblock arrays for constants into >individual arrays for F, B, and I constants >- don't use shared SetConstant/GetConstant function in device.c, unroll >that into its callers, and make them use separate .set and .changed >arrays. Remove old SetConstant/GetConstant functions, not enough is >shared to justify them. Remove SetConstantN, it's not used anymore. >- change stateblock to not use the type array >- change drawprim to use the .set array, instead of a type array to >check if constants need to be loaded > Hi Ivan, just one comment: + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); should be: if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); as count and start are UINT (better to avoid ugliy unsigned/signed bugs). Anyway what windows do if (start + count > MAX_VSHADER_CONSTANTS) ? The code seems handle this case truncating the input Best Regards, Raphael

2 1

Re: winedbg: remove unneeded states from grammar
by Eric Pouech June 6, 2006

June 6, 2006

I'm not sure they are unneeded. for example, with your changes, b down would be seen by the grammar as tBREAKPOINT tDOWN which is not what we want. A+ 2006/6/6, Juan Lang <juan_lang(a)yahoo.com>: > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them > > --Juan > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > > > > > > -- Eric Pouech

1 0

GetDIBits() with a bitmap that is selected in a device context
by Michael Kaufmann June 6, 2006

June 6, 2006

The application "Fritz 5.32" calls GetDIBits() with a bitmap that is still selected in a device context (see bug 3893). The bitmap has a color table. GetDIBits() creates a memory DC, selects the bitmap into this DC, and calls GetDIBColorTable(). But this fails, because Wine can't select this bitmap in a memory device context again. According to MSDN, calling GetDIBits with a bitmap that is selected in a device context is not allowed. But surprisingly it works on Windows. Does anybody have an idea how to solve this problem? Regards, Michael

2 3

re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]
by Dan Kegel June 5, 2006

June 5, 2006

James wrote: > Is there anything wrong with this patch? Well, it doesn't have a conformance test... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 4

[Fwd: Re: msi patch submission - cond.y]
by Dominic Wise June 5, 2006

June 5, 2006

I may be wrong, but I feel it might be useful for a naive outsider to enter this discussion, even if it does mean I get burnt to a crisp. I'm neither a Wine nor a parser developer (though I do have a few years C/++ experience) and fully accept that I may be flamed to a tiny cinder for my comments, but from what I can ascertain, cond.y is a composite file, containing C and bison code. As far as I can tell (not quite brave enough to say AFAICT) the file is first read by the bison processor, which reads the bison parser rules and C code and generates compilable files for the C compiler. Having read what bison is (I think) supposed to do, the tokens declared DO look is if they might be wrong [having looked up 'tilde' and MSI on Google, it looks as though COND_I* actually relates to strings, as it seems that the tilde means 'case insensitive', but I wonder if it has been inadvertently used on integer comparisons by some installers]. It also looks as if the tests in compare_int() for COND_LE and COND_ILE may be wrong, unless there is some kind of (uncommented) logic inversion somewhere. However, uppermost in my mind is Mike McCormack's statement that 'Unfortunately cond.y has nothing to do with SQL.'. If this is indeed the case then everything I have said amounts to nought because I have assumed (very likely incorrectly) that the parser code in cond.y, being part of the MSI dll, relates to the parsing of SQL statements in MSI. If this is the case I fully expect to burn in newbie-land, and apologise for my presumption. Torch me if you want. Just trying to help, and open the discussion :)

1 0

Re: msi patch submission - cond.y
by Mike McCormack June 5, 2006

June 5, 2006

EA Durbin wrote: > fixed various SQL errors in COND_GetOperator() and compare_int() Unfortunately cond.y has nothing to do with SQL. Mike

3 3

re: Wine VM86 exception handling bug?
by Dan Kegel June 5, 2006

June 5, 2006

Andrey wrote: > My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86 > would restore vm86 registers correctly. I think i know what is the > problem; however, I lack experience to fix it myself :) > I need help; any hints would be appreciated. How about writing a conformance test that demonstrates the problem? That will help focus discussion and energy on it, and keep it from coming back. Thanks! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

7 11