June 2006 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

re: What operating systems will Winelib run on non-x86 systems?
by Dan Kegel Nov. 21, 2006

Nov. 21, 2006

Hi Wei Li, last year, you asked in http://www.winehq.org/hypermail/wine-users/2004/06/0086.html > I could not find the info regarding what operating systems > (such as AIX 5L v5.2, HP-UX 11i, Solaris Release Level > 9) will Winelib run on non-x86 machines. I'll really > appreciate it if someone can provide my related link or > info. I can only find the following link regarding the > supporting OS but it does not provide Winelib's supporting > OS info: > http://www.winehq.org/site/docs/wine-faq/index 3.1. > Under what hardware > platform(s) and operating system(s) will Wine(Lib) run? I'm sorry nobody got back to you -- the wine-devel mailing list might have been a better place to ask. I believe winelib runs on the following non-x86 operating systems: Linux, Solaris, Mac OS X, and FreeBSD. There's no reason in principle it couldn't run on AIX or HP/UX. Some work has been done on an HP/UX port, but some assembly would be required to complete it: http://www.winehq.com/site/?issue=241#HP-UX%20Port Cheers, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

re: Wine-wiki broken by design
by Dan Kegel Nov. 16, 2006

Nov. 16, 2006

Maybe the wine wiki could publish a machine-readable sitemap; see http://www.xml-sitemaps.com/ http://www.google.com/webmasters/sitemaps/docs/en/about.html That would put less load on the server than letting Yahoo and Google crawl the wiki themselves. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 3

Re: [Tools/Wine.inf] Set Internet Explorer version
by Sven Paschukat Oct. 8, 2006

Oct. 8, 2006

Maarten Lankhorst schrieb: > Windows seems to set internet explorer only during a new installation or > upgrade of internet explorer, so I put it in wine.inf, which seemed > appropriate. > > Changelog: > Set version strings for Internet Explorer so programs dependent on it > can install. This breaks installation of real IE. Setting version to IE 5.5 would give the users a chance to install at least version 6.0. BTW, you should fix the typo in the third line. Sven

7 8

Freetype configure checks are backward
by Gerald Pfeifer July 25, 2006

July 25, 2006

I believe the Freetype configure checks are backward. First we check for the library being present, and only then do we check for the freetype-config problem: AC_SUBST(FREETYPELIBS,"") AC_SUBST(FREETYPEINCL,"") AC_CHECK_LIB(freetype,FT_Init_FreeType,ft_lib=yes,ft_lib=no,$X_LIBS) if test "$ft_lib" = "no" then wine_cv_msg_freetype=no else AC_CHECK_PROG(ft_devel,freetype-config,freetype-config,no) This fails to work when Freetype is installed somewhere outside of /usr/ such as /usr/local/ with /usr/local/bin in the path. freetype-config would of course know where to look for the library, but we perform the check for the library first, without taking the output of freetype-config into concern. Wouldn't it make sense to revert these two changes? Gerald

1 1

Link or rename wcmd.exe to cmd.exe?
by Thomas Kho July 6, 2006

July 6, 2006

I'd like to restart this old thread <http://www.winehq.com/hypermail/wine-users/2005/05/index.html#165> which brings up the point that there are applications that hard-code cmd.exe and (sometimes intentionally) ignore COMSPEC. One example is Perl, which has the following comment in win32/win32.c: /* we don't use COMSPEC here for two reasons: * 1. the same reason perl on UNIX doesn't use SHELL--rampant and * uncontrolled unportability of the ensuing scripts. * 2. PERL5SHELL could be set to a shell that may not be fit for * interactive use (which is what most programs look in COMSPEC * for). */ I'm currently looking into what would be required for something like a symlink to wcmd.exe, but at the same time I'm wondering the historical reasons for choosing 'wcmd' and if it should be changed to just 'cmd'. Thomas Kho

3 3

Re: [PATCH 10/11] server: add calls to get/set menu item info
by H. Verbeet July 6, 2006

July 6, 2006

On 29/06/06, Thomas Kho <tkho(a)ucla.edu> wrote: > +(a)REQ(get_menu_item_info) > + user_handle_t handle; > + unsigned int pos; > +(a)REPLY > + unsigned int required_size; > + > + unsigned int type; > + unsigned int state; > + unsigned int id; > + user_handle_t submenu; > + user_handle_t checkbit; > + user_handle_t uncheckbit; > + void* text; > + unsigned long itemdata; > + void* typedata; > + user_handle_t bmpitem; > + > + rectangle_t rect; > + unsigned int xTab; > + dimension_t bmpsize; > + > + VARARG(text,unicode_str); > +(a)END HBITMAPs aren't technically user handles, and afaik you can't pass GDI handles between processes like that. At least, not on Windows.

4 9

indented relay traces
by James Hawkins July 5, 2006

July 5, 2006

Hey guys, I don't know if you've ever wished the relay traces were indented by the level of the call, so you can get a better feel for who calls what from where, but I thought it would be nifty. I've attached a patch for dlls/ntdll/relay.c that gives you this. You see the call level next to the thread id, then twice that number of spaces, then the usual relay information. I'd paste an example, but it would just get line wrapped, so patch your tree and give it a shot! -- James Hawkins

6 6

wine and serial port - again
by Pavel Troller July 5, 2006

July 5, 2006

Hi! From time to time, complaints can be heard about functionality of the serial port implementation in wine. Just now I have one of examples of the serial communication problem. There is a very simple program, called ft or softjump, intended to dump or modify some particular addresses of an EEPROM of an amateur radio. It uses a serial port in non-canonical mode, writing always 5 binary chars into it and reading (also binary) reply. I've run this program under wine but there were problems - the program never dumped any data. The source is included in the program archive; it was about 30 minutes of work to convert it for Linux. After successfull compilation, I've run the resulting Linux program (pure Linux, not winelib) and it worked as expected. For the testing purposes, I've then compiled the original windows version using winegcc. I was able to run the program, but the results were identical to those with original windows binary (no data). The windows binary output shows this: patrol(a)arcus:~/ft817$ wine ft.exe ft.exe by Peter May, VK2JCG, vk2jcg(a)yahoo.com.au This program uses undocumented CAT commands to read or update the EEPROM in the Yaesu FT817 and FT897 Radios. The soft jumper settings are stored in location 4 and 5 of the EEPROM. Power the radio off and on to activate the new settings. If you do a reset of the radio, you will have to run this program again to rewrite the values The program assumes that the radio is connected to COM1: and the CAT rate is set to 38400 baud *** USE AT YOUR OWN RISK *** Serial port COM1: successfully reconfigured. Read current data from EEPROM gives : patrol(a)arcus:~/ft817$ Its Linux version works well: patrol(a)arcus:~/ft817/Source$ ft ft by Peter May, VK2JCG, vk2jcg(a)yahoo.com.au This program uses undocumented CAT commands to read or update the EEPROM in the Yaesu FT817 and FT897 Radios. The soft jumper settings are stored in location 4 and 5 of the EEPROM. Power the radio off and on to activate the new settings. If you do a reset of the radio, you will have to run this program again to rewrite the values. *** USE AT YOUR OWN RISK *** Linux version by Pavel Troller - OK1XPT, <patrol(a)sinus.cz> Serial port /dev/tts/0 successfully reconfigured. Read current data from EEPROM gives : DD BF patrol(a)arcus:~/ft817/Source$ Do you see ? The windows version doesn't output the actual EEPROM data. +file,+comm trace from wine looks like this: trace:file:CreateFileW L"COM1:" GENERIC_READ GENERIC_WRITE creation 3 attributes 0x0 trace:file:RtlDosPathNameToNtPathName_U (L"COM1:",0x7fb3fdd0,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"COM1:" 520 0x7fb3fb44 (nil)) trace:file:get_dos_device L"COM1" -> "/dev/ttyS0" trace:file:CreateFileW returning 0x2c trace:comm:GetCommState handle 0x2c, ptr 0x7fb3fe70 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_BAUD_RATE (nil) 0 0x7fb3fe18 4 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_LINE_CONTROL (nil) 0 0x7fb3fe1d 3 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_HANDFLOW (nil) 0 0x7fb3fe00 16 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_CHARS (nil) 0 0x7fb3fe12 6 0x7fb3fdb0 trace:comm:GetCommState OK trace:comm:dump_dcb bytesize=8 baudrate=38400 fParity=0 Parity=0 stopbits=2 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=1 trace:comm:dump_dcb ~CRTSCTS trace:comm:dump_dcb bytesize=8 baudrate=38400 fParity=0 Parity=0 stopbits=2 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=0 trace:comm:dump_dcb ~CRTSCTS trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_BAUD_RATE 0x7fb3fe18 4 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_LINE_CONTROL 0x7fb3fe1d 3 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_HANDFLOW 0x7fb3fe00 16 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_CHARS 0x7fb3fe12 6 (nil) 0 0x7fb3fdb0 trace:comm:SetCommTimeouts (0x2c, 0x7fb3fe5c) trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_TIMEOUTS 0x7fb3fe0c 20 (nil) 0 0x7fb3fdb0 trace:file:WriteFile 0x8 0x7fb3f9cc 48 0x7fb3fdd4 (nil) Serial port COM1: successfully reconfigured. trace:file:WriteFile 0x2c 0x7fb3fe54 5 0x7fb3fe4c (nil) trace:file:ReadFile 0x2c 0x7fb3fe8c 4 0x7fb3fe4c (nil) trace:file:WriteFile 0x8 0x7fb3f9b4 38 0x7fb3fdbc (nil) Read current data from EEPROM gives : trace:file:WriteFile 0x8 0x7fb3f9b8 2 0x7fb3fdc0 (nil) You can see the port configuration phase, as well 5 bytes being written and a read being attempted. However, resulting "count" variable (see source) is probably 0, because there is no output of values read. I don't know, whether it is due to wrong command being written to the radio, or failure to read its response. Original package can be downloaded freely for example here: http://www.817-onair.de/download.php?id=6&sid=c66545090cd6b5cbc2e1c06321ff9… My Linux variant is attached to this mail. Sorry for the lengthy mail, but I hope that it can really help to improve the serial communication support in wine. With regards, Pavel Troller

2 1

wine-1.0 goal: fix all reported msi and ole bugs?
by Dan Kegel July 4, 2006

July 4, 2006

I just looked, and there aren't *that* many msi and ole bugs reported in bugzilla. http://bugs.winehq.org/buglist.cgi?product=Wine&component=wine-ole&keywords… lists 37 ole bugs with downloadable demos http://bugs.winehq.org/buglist.cgi?product=Wine&component=wine-ole&bug_stat… lists 89 ole bugs total http://bugs.winehq.org/buglist.cgi?product=Wine&component=wine-msi&keywords… lists 35 msi bugs with downloadable demos http://bugs.winehq.org/buglist.cgi?product=Wine&component=wine-msi&bug_stat… lists 71 msi bugs total Would it be unreasonable to set a goal of having all msi and ole bugs fixed for wine-1.0 ?

4 4

re: msi: Fix some copy/paste bugs in the implementation of condition operators.
by Dan Kegel July 3, 2006

July 3, 2006

Hans wrote: > [http://www.winehq.org/pipermail/wine-cvs/2006-June/023395.html] > Fix some copy/paste bugs in the implementation of condition operators. Congratulations on getting your patch into cvs! How far does this go towards fixing America's Army (http://bugs.winehq.org/show_bug.cgi?id=5139)? Also, are you still working on a conformance test for this, or did you stop once you found the obvious problem? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

12 23

Call for volunteer: dwarf2 testing
by Eric Pouech July 1, 2006

July 1, 2006

As you may have seen, there's now some support for the dwarf2 debug format (instead of stabs) in the Wine tree I'd like to get some feedback on the overall feedback on how it behaves. To do so, you need to reconfigure Wine with something like CFLAGS="$CFLAGS -gdwarf-2" ./configure and then make clean; make (so that all modules are recompiled with proper format) Normal debugging should be available with winedbg. If something goes wrong, please indicate: - console messages - error items - steps that led to it - version of gcc used TIA

3 4

WRT failed to Build
by Detlef Riekenberg July 1, 2006

July 1, 2006

Hi. The cross-compiled WRT failed since 17. May. The native WRT failed even longer. And Ideas? -- By By ... ... Detlef

2 3

Wine 0.9.16 and ddraw issues
by Alexander Nicolaysen Sørnes July 1, 2006

July 1, 2006

Greetings, I maintain several ddraw apps in the Application Database. While most of the problems introduced by Wine 0.9.16 have been fixed, some still remain. Command & Conquer and C&C: Red Alert When exiting the game, a messagebox displays: 'Unregonized Direct Draw result code: 1' A demo of Red Alert is available here: http://appdb.winehq.org/appview.php?versionId=4026 These two games, along with 'Warlords IIII: Darklords Rising' also have a strange SMP problem. In earlier Wine versions, these games would stop redrawing at some point. This also happens in Wine 0.9.16, but sometimes an error message is displayed instead, and then Wine receives a page fault. Emperor: Battle for Dune This game requires native d3drm.dll, which does not work anymore. Problems with this file was mentioned on this list a few days ago. Heroes of Might and Magic IV This game now displays a File menu when run in full-screen, which it is only supposed to do when run in a window. If I change the game's resolution, the menu disappears, but if I change it back to the resolution it had when it was started, the File menu is displayed again. Because of this menu, the game window is moved downwards, so the bottom part of the game is not displayed. Warcraft II Battle.net Edition The title screen is no longer displayed; it shows a black screen instead. This also happens with some of the campaign intro screens. The rest of the game seems to work as before. The new ddraw code fixes redrawing problems in at least a dozen games, and makes some of them faster, so it was a very good thing! :) Regards, Alexander N. Sørnes

3 4

DDRAW: Releasing attached surfaces
by Krzysztof Benkowski July 1, 2006

July 1, 2006

Hello, In the latest version of wine (0.9.16) there is a regression which makes Dune 2000 crash. After some debugging i found that the problem lays in IDirectDrawSurfaceImpl_Release method. The game (Dune 2000) shows that the assumption that all attached surfaces should be destroyed regardless of their refcount is wrong. What causes the crash in few words: - first Dune 2000 creates a surface with a backbuffer - then it gets the backbuffer interface by GetAttachedSurface method (refcount for the backbuffer is incremented) - it releases the frontbuffer (the backbuffer is destroyed even though its refcount is higher than frontbuffer's) - creates new frontbuffer and an offscreen plain - when one starts a mission the game tries to use the old backbuffer (which is then destroyed) and causes a page fault So my fix is rather quick and thus i'm not quite sure if it's correct. That's because the game works with it but when it quits it leaves the backbuffer not released. I don't know if it's the game's fault or the fix has to be done some other way. I've done it this way: --- surface.c 26 Jun 2006 12:15:20 -0000 1.6 +++ surface.c 29 Jun 2006 14:09:59 -0000 @@ -377,7 +377,7 @@ IDirectDrawSurfaceImpl_Release(IDirectDr while( (surf = This->next_complex) ) { This->next_complex = surf->next_complex; /* Unchain it from the complex listing */ - IDirectDrawSurfaceImpl_Destroy(surf); /* Destroy it */ + IDirectDrawSurfaceImpl_Release(surf); /* Release it */ } If you (Stefan probably) need more info about the bug i can provide some logs Krzysiek

4 5

Re: riched20: corrected EM_GETLINE and wrong hWnd patches (combined into one)
by James Hawkins June 30, 2006

June 30, 2006

On 6/30/06, Krzysztof Foltman <wdev(a)foltman.com> wrote: > ChangeLog: > * EM_GETLINE support (roughly based on code by Thomas Kho, although > there are important changes, for example, it works correctly in RichEdit > 1.0 emulation mode) (bug #4305) > * Workaround for wrong window handles (bug# 4452) > * EM_LINELENGTH handles paragraph ends properly (bug #5375) > > I'm sending it as one patch, just in case it gets rejected again - > trying to split the patch seems to give me some mysterious git problems. > I've just looked at this patch and the previous patch Thomas sent in, and saying that this is roughly based on his patch is putting it lightly. I see that you've added the 1.0 emulation change, but that doesn't warrant you putting your name on his patch. The correct way to go about this would be to wait till his patch gets accepted and then add your code in a new patch, or to make him aware of the problems in his implementation, so he can rewrite it or add the missing feature, but either way, he deserves credit for the code he wrote, and not just saying that your code was based off of his. -- James Hawkins

2 5

Gecko installer
by Jacek Caban June 30, 2006

June 30, 2006

Hi. Please consider this mail as: Re: Built-in iexplore Re: acad 2004 licence file bug Re: Broken FC5 packages - stay clear. Last week Wine Gecko was mentioned a few times on this mailing list and I can see that there is no understanding of it. It's not really surprising as it's a big mess ATM. We can still use Mozilla ActiveX control (but that needs to be removed) or (xor) directly Gecko. Sometimes (if the app uses HTMLDocument directly, not via WebBrowser, like iexplore does) only the second option works. That has led me to do what I am planning to do later. I've just sent Wine Gecko installer. After it will be committed, a system similar to Mozilla ActiveX control download will have to be set up (that is upload the package to SourceForge and add a script that directs download of it). That will allow us to get rid of Mozilla ActiveX control. Thanks, Jacek

7 14

Re: winspool.drv: Write-strings warnings fix
by Detlef Riekenberg June 30, 2006

June 30, 2006

Andrew Talbot wrote: > Changelog: > winspool.drv: Write-strings warnings fix. The touched parts should call the UNICODE-Functions instead of the ANSI-Functions. That's on my ToDo-List, but after the Port-Functions are fixed. Many tests for the affected Functions also needs to come before the touched Parts will be updated again. I'm ok with this Patch. -- By By ... ... Detlef

1 0

Re: mapi32: Replace CRITICAL_SECTION by RTL_CRITICAL_SECTION.
by Robert Shearman June 30, 2006

June 30, 2006

Hervé Poussineau wrote: >Replace CRITICAL_SECTION by RTL_CRITICAL_SECTION, according to prototype of >RtlEnterCriticalSection and others. > It would be better to fix the file to use the kernel32 critical section functions instead of the ntdll ones. -- Rob Shearman

1 0

Re: [AppDb] [Resend] prefix all GPC variables
by Chris Morgan June 30, 2006

June 30, 2006

There are several issues that I've found so far in this patch. It appears that you used a search and replace. You'll need to go through EVERY line of the patch and undo the changes to things like sql queries and others where the changes don't make sense. At some point we can discuss altering tables to match our internal variable scheme but we should wait until the php part of the patch is complete. Chris On Friday 30 June 2006 3:31 am, Jonathan Ernst wrote: > Before you ask, there was no possibility to split this one up because > everything is interdependant. > > Please commit it before other patches, it's a pain to rediff it agains head > and fix the conflicts everytime. > > Changelog: > - rename all Get/Post/Cookies variables using type prefixes so that we can > later use the autofiltering function

1 0

Re: [AppDb] appsubmit fix
by Chris Morgan June 30, 2006

June 30, 2006

Can we pass the parameters we need into the function instead of using a global? Chris On Thursday 29 June 2006 2:29 am, Jonathan Ernst wrote: > Changelog: > - $aClean was not visible in function

2 2

Debugging string comparison problem
by Juan Lang June 30, 2006

June 30, 2006

I'm trying to figure out why CompareStringA returns CSTR_EQUAL for the strings "\1" and "\2". (See bug 5469, and the todo_wine test case in dlls/kernel/tests/locale.c) CompareStringA does the usual thing, calls MultiByteToWideChar and calls CompareStringW. So CompareStringW is comparing L"\0001" to L"\0002". CompareStringW calls wine_compare_string, in libs/unicode/sortkey.c That calls compare_unicode_weights. That has this little bit of code: ce1 = collation_table[collation_table[*str1 >> 8] + (*str1 & 0xff)]; ce2 = collation_table[collation_table[*str2 >> 8] + (*str2 & 0xff)]; With the strings L"\0001" and L"\0002", *str1 is 0x0001, and *str2 is 0x0002. So *str1 >> 8 is 0, and *str2 >> 8 is 0. *str1 & 0xff is 0x01, *str2 & 0xff is 0x02. So, ce1 == collation_table[1], which is 0x00000300 (in collation.c), and ce2 == collation_table[2], which is 0x00000400. That gets us here: if (ce1 != (unsigned int)-1 && ce2 != (unsigned int)-1) ret = (ce1 >> 16) - (ce2 >> 16); else ret = *str1 - *str2; Well, 0x00000300 >> 16 is 0, and so is 0x00000400, so ce1 - ce2 is 0, so these strings are considered equal. But as the test case shows, they're not supposed to be. I'm just not sure what to do about it. Changing collation.c isn't really an option, since it's generated. So there's some flaw in the logic here, but I don't understand the meaning of collation_table. Could someone explain to me what it is? Thanks, --Juan

3 5

Using firefox with ietab extension
by Paul Vriens June 30, 2006

June 30, 2006

Hi, anybody tried this already? I wanted to use Firefox 1.5.4 together with the ietab extension for some specific sites (Outlook Web Access). I don't want to install the Mozilla ActiveX plugin but instead us our internal stuff, but wasn't able yet to get this going. Installation of firefox and the extension is fine btw. Cheers, Paul.

1 0