June 2006 - Wine-Devel - list.winehq.org

Hal and functions in setupapi
by Christian Gmeiner June 7, 2006

June 7, 2006

Hi all... at the momemt i am reading into functions to get some informations about e.g. cdrom drives. At the moment i am loking into SetupDiGetClassDevsW to support GUID_DEVINTERFACE_CDROM and later USB devices. My overall goal is it to get Line 6 software for my guitart effect board (USB) working with wine. Now i thought about a way to get all informations about a singe cdrom device. And i thought that I could use HAL perfectly for this. I thought about this way of doing it: Add hal.c file to setupapi dll, which contains function to get infromations about all needed hardware. This should work very nicly for this case. But as I want to programm RegisterDeviceNotification also we need a central way to handle hal stuff. So how should I go on? Use some own hal.c in setupapi or add an global wine way to interact with hal? Thanks, Christian

3 2

Re: libunicode: Add some more code page tables that are available for download from ftp.unicode.org, most notably the table for the us-ascii encoding, which is quite common.
by Alexandre Julliard June 7, 2006

June 7, 2006

Robert Shearman <rob(a)codeweavers.com> writes: > libs/unicode/Makefile.in | 3 > libs/unicode/c_1361.c | 5138 > ++++++++++++++++++++++++++++++++++++++++++++++ > libs/unicode/c_20000.c | 3587 ++++++++++++++++++++++++++++++++ > libs/unicode/c_20127.c | 683 ++++++ > libs/unicode/cpmap.pl | 3 > libs/unicode/cptable.c | 8 This won't work, the source files are not in the expected format, so the resulting tables contain garbage. You'll need to teach cpmap.pl to parse these files correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Avoid unnecessary casts
by Detlef Riekenberg June 7, 2006

June 7, 2006

Am Mittwoch, den 07.06.2006, 16:45 +0900 schrieb Dmitry Timoshkov: > - psh.u3.ppsp = (LPCPROPSHEETPAGEW) & psp; > + psh.u3.ppsp = psp; Where is the "&" ? -- By By ... ... Detlef

1 0

Re: [WINED3D 2/3] Fix missing light recording
by Michael Stefaniuc June 7, 2006

June 7, 2006

Ivan Gyurdiev wrote: > >> >From nobody Mon Sep 17 00:00:00 2001 >> > > Please delete this line in case the patch is corrupt.. missed it The patch is not corrupted as it starts only with the '---' line. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: lstrlen(A/W) patch
by Mike McCormack June 7, 2006

June 7, 2006

Clinton Stimpson wrote: > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" The inline lstrlenW is used only internally by Wine code, and we want it to crash when passed a NULL pointer. In this case, you should fix the Wine code calling lstrlenW to not use a NULL pointer. Mike

2 3

Re: D3D9: Add a test for setting / getting vertex shader constants
by Raphael June 6, 2006

June 6, 2006

On Tuesday 06 June 2006 23:17, H. Verbeet wrote: > This is a test for Ivan's patch for shader constants > (http://source.winehq.org/git/?p=wine.git;a=commit;h=5f5969b3c5bd237277b8f2 >f1eaa4ddacce5fb63b) > > Changelog: > - Add a test for setting / getting vertex shader constants Simple testing :) can you add border tests in future: hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 4, bool_in, 4); hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 2, bool_in, 4); I'm interested to see how windows handle that :) Regards, Raphael

3 3

winedbg - setting breakpoint
by Stephen Clark June 6, 2006

June 6, 2006

Hello List, I am trying to get classic Myst to run again under wine. How do I set a breakpoint in it when it run by winevdm. Thanks, Steve -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson)

2 1

re: Hal and functions in setupapi
by Dan Kegel June 6, 2006

June 6, 2006

Christian wrote: > as I want to programm RegisterDeviceNotification also we > need a central way to handle hal stuff. > > So how should I go on? Use some own hal.c in setupapi or > add an global wine way to interact with hal? I think programs/explorer already registers for device notification with hal. You should look at that before you go on. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: APPDB patch
by Tony Lambregts June 6, 2006

June 6, 2006

EA Durbin wrote: > fixed typographical errors. > > > ------------------------------------------------------------------------ > > ? patch.diff > Index: TODO > =================================================================== > RCS file: /home/wine/appdb/TODO,v > retrieving revision 1.22 > diff -u -p -r1.22 TODO > --- TODO 12 Jun 2005 02:50:18 -0000 1.22 > +++ TODO 6 Jun 2006 02:19:34 -0000 > @@ -7,7 +7,7 @@ WineHQ Application Database TODO List > AppDB Todo: > > * Improve application/version submission process > - Currently a user submits an application/version and a admin reviews it and > + Currently a user submits an application/version and an admin reviews it and > either makes changes to it and accepts it or writes a comment and rejects it. Upon > rejection the submission is deleted > > There is no sense in keeping our todos in two places. We should probabably just point to the wiki in this file. http://wiki.winehq.org/AppdbInfo Tony Lambregts

1 0

Re: lstrlen(A/W) patch
by Andreas Mohr June 6, 2006

June 6, 2006

Hi, On Mon, Jun 05, 2006 at 09:24:24PM -0600, Clinton Stimpson wrote: > > I encountered a crash when using PAF 5.2. > > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" MSDN documentation says many things... most of them wrong. ;-) (only slightly exaggerated, given Wine's experience with MSDN "correctness" over the years) IOW, I severely doubt that this is indeed the way Windows behaves, otherwise it'd have been fixed in Wine a long time ago already since apps would rely on and fully expect this behaviour of such a central and important function. Most likely you encountered application misbehaviour (feeding a NULL parameter to a function expecting non-NULL) due to a different Wine bug which thus caused the app to mis-step. Would be interesting to figure out why this happened (e.g. via +relay trace). Andreas Mohr

1 0

Wine updated in Fedora Extras!
by Neal Gompa June 6, 2006

June 6, 2006

Wine has been updated to 0.9.14 on May 30, 2006! So, this release took 6 days... Still, generally 3-5 days is pretty good estimation...

1 0

Re: winedbg: remove unneeded states from grammar (take 2)
by Alexandre Julliard June 6, 2006

June 6, 2006

Juan Lang <juan_lang(a)yahoo.com> writes: > Oops, last one had a missing brace. Sorry about that. > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them Won't that make it impossible to use command keywords as identifiers in commands that accept them, like disass? Come to think of it, your previous NOCMD patch probably has the same issue. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: wined3d: Another GLSL shader status update
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >A: wine-devel(a)winehq.com >De: Mike Hearn <mike(a)plan99.net> >Date: Tue, 06 Jun 2006 12:31:06 +0100 >Sujet: Re: wined3d: Another GLSL shader status update > >On Sun, 04 Jun 2006 12:04:21 -0400, Jason Green wrote: >> > This is an elaborate scheme with linked lists in each shader - is that >> > really necessary? >> > I'm very confused after reading the code (but maybe that's just me :) >> >> If we link the programs together every time the Set__Shader() is called, >> it brings performance to a halt (that what my glsl_hack4.diff did). > >Re: the recent discussion on code commenting and documentation, it'd be >nice if the patch explained this somewhere. It'd be even nicer still if at >some point one of you guys could take a break from the codeface and write >a chapter for the Wine Developer Guide on shaders and how all this works >... it seems incredibly opaque and the last thing we want is a re-run of >the DCOM situation where the only people who understood it left or hacked >on other things for a while and we lost the knowledge of how it worked. I Aggree that adding more comments about current architecture (at least on http://wiki.winehq.com/DirectX-Shaders and http://wiki.winehq.com/WineD3D) can help to better understand for non-d3d introduced wine hackers :) I was the first who delivered that code and it's my fault for the initial poor comments about architecture (who was understandable for opengl/directx hackers). We'll try to improve it (maybe beginning with "WineD3D for dummies" :) ) Anyway we are many who understand this code (and reviewing the flood of wined3d patches) so "DCOM situation" cannot happen :) >thanks -mike Regards, Raphael

1 0

Re: Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >Date: Tue, 06 Jun 2006 04:54:17 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: fenix(a)club-internet.fr >Copie à: wine-devel(a)winehq.org >Sujet: Re: [WINED3D 5/5] Remove constant type field in stateblock. > >Hi Raphael, > >Strange, your email shows up as an attachment. Yes it's my webmail who have strange behaviors :( > > + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start > > + 1)); > > should be: > > if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; > > UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); > > > as count and start are UINT (better to avoid ugliy > > unsigned/signed bugs). > >The current code checks if cnt < 0 later on. Yes but it was buggy :) MAX_VSHADER_CONSTANTS - (start + 1) can result on an unsigned overflow > > Anyway what windows do if (start + count > > > MAX_VSHADER_CONSTANTS) ? > > The code seems handle this case truncating the input > >It's possible that this is buggy [ I always thought it was off by one ], >or not handling this case properly. However, I've just copied the code >that was already there - unrolled the existing SetConstant function into >its callers, and made the change I was interested in. Fixing other bugs >would go into a separate patch. Ok, fine for me Waiting for more patches to review :) I'm really waiting to get my new GC to test last impressive work on shaders. Regards, Raphael

1 0

To K&R or not
by Molle Bestefich June 6, 2006

June 6, 2006

EA Durbin wrote: > >K&R style brack placements > > They are an eyesore and make things difficult to read. Highly subjective. I think K&R has distinct advantages, namely it unites the scope begin token with the relevant control statement. For me, this makes code easier and faster to read, since I can follow the indentation and arrive immediately at the relevant control statement. Also I think that K&R is nice in that it saves screen real estate, which again for me makes code easier to read because I can see more of it at once. I personally consider non-K&R style an eyesore because of this. CMIIW, but the only thing that non-K&R has going for it is that you can visually make out whether you've made the correct number of opening versus closing braces. I don't think that's much of an advantage, especially considering that any modern source code editor will highlight the starting brace or relevant control statement for you. That said, I don't care what people do, I can read both... In my perfect world though, my SCM client would convert source code to my preferred format on checkout, and to whatever universal format the repository uses on checkin. Ho hum...

7 11

Re: Re: Linux noob
by Mike Hearn June 6, 2006

June 6, 2006

On Tue, 06 Jun 2006 03:27:52 +0000, NikNot wrote: > Indeed! This is something that I found infuriating since I first > used wine. What possible reason would there be to make this > a "hidden" directory? From whom exactly should it be hidden > and why? Historical reasons. I'm switching this thread to wine-devel as TransGaming do in fact make the virtual C drive visible by default and it's maybe something we should do too. On the other hand, it might just be wallpapering over other usability problems (lack of menu integration, most obviously). How often does average jack need to go poking around C:\Program Files in real Windows? thanks -mike

1 0

re: acad 2004 license file bug
by Dan Kegel June 6, 2006

June 6, 2006

Jaap wrote: >The autocad installer indicated that I needed internet explorer 6.0, >so I installed that using winetools. Don't use winetools, please. As you noticed, it does bad things to your ~/.wine. Or, if you do use it, please report problems to the winetools developer, not here. > (can wine fake internet explorer, >so i don't need to install the real thing?) Yes. Here's what I do: # Fake IE per workaround in http://bugs.winehq.org/show_bug.cgi?id=3453 wineserver -k cat >> $HOME/.wine/system.reg <<"_EOF_" [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" _EOF_ - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

DirectX blitter bug
by Mike Hearn June 6, 2006

June 6, 2006

Lords of Magic works perfectly EXCEPT that rendering is corrupted when it is using DirectX "fast blitting"; they provide a software emulated workaround for some truly ancient cards (Matrox Mystique anyone?) and the game works well in this mode. But it should work properly in DirectX accelerated mode too. The kind of corruption varies but it appears as, for instance, mouse trails which to me suggests some kind of co-ordinate system problem. The demo is here: ftp://ftp.sierra.com/pub/sierra/lordsofmagic/demos/si_lordsofmagic_demo.exe and it installs cleanly on the master branch. If any DirectDraw gurus want to take a look, please do! I bet this problem affects other games too.... thanks -mike

2 2

Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >Date: Tue, 06 Jun 2006 02:46:59 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: wine patch <wine-patches(a)winehq.org> >Sujet: [WINED3D 5/5] Remove constant type field in stateblock. > >It is wrong to maintain a mapping from a constant index to a type field, >because different constant types do not share an index - boolean >constant 0 is supposed to co-exist with floating point constant 0, not >replace it. Drawprim and other code using the type array to decide >whether to look up a constant in bools, floats, or ints is wrong - you >can't make that decision based on the index. > >To do this: >========== >- split .set and .changed stateblock arrays for constants into >individual arrays for F, B, and I constants >- don't use shared SetConstant/GetConstant function in device.c, unroll >that into its callers, and make them use separate .set and .changed >arrays. Remove old SetConstant/GetConstant functions, not enough is >shared to justify them. Remove SetConstantN, it's not used anymore. >- change stateblock to not use the type array >- change drawprim to use the .set array, instead of a type array to >check if constants need to be loaded > Hi Ivan, just one comment: + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); should be: if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); as count and start are UINT (better to avoid ugliy unsigned/signed bugs). Anyway what windows do if (start + count > MAX_VSHADER_CONSTANTS) ? The code seems handle this case truncating the input Best Regards, Raphael

2 1

Re: winedbg: remove unneeded states from grammar
by Eric Pouech June 6, 2006

June 6, 2006

I'm not sure they are unneeded. for example, with your changes, b down would be seen by the grammar as tBREAKPOINT tDOWN which is not what we want. A+ 2006/6/6, Juan Lang <juan_lang(a)yahoo.com>: > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them > > --Juan > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > > > > > > -- Eric Pouech

1 0

GetDIBits() with a bitmap that is selected in a device context
by Michael Kaufmann June 6, 2006

June 6, 2006

The application "Fritz 5.32" calls GetDIBits() with a bitmap that is still selected in a device context (see bug 3893). The bitmap has a color table. GetDIBits() creates a memory DC, selects the bitmap into this DC, and calls GetDIBColorTable(). But this fails, because Wine can't select this bitmap in a memory device context again. According to MSDN, calling GetDIBits with a bitmap that is selected in a device context is not allowed. But surprisingly it works on Windows. Does anybody have an idea how to solve this problem? Regards, Michael

2 3

re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]
by Dan Kegel June 6, 2006

June 6, 2006

James wrote: > Is there anything wrong with this patch? Well, it doesn't have a conformance test... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 4

[Fwd: Re: msi patch submission - cond.y]
by Dominic Wise June 5, 2006

June 5, 2006

I may be wrong, but I feel it might be useful for a naive outsider to enter this discussion, even if it does mean I get burnt to a crisp. I'm neither a Wine nor a parser developer (though I do have a few years C/++ experience) and fully accept that I may be flamed to a tiny cinder for my comments, but from what I can ascertain, cond.y is a composite file, containing C and bison code. As far as I can tell (not quite brave enough to say AFAICT) the file is first read by the bison processor, which reads the bison parser rules and C code and generates compilable files for the C compiler. Having read what bison is (I think) supposed to do, the tokens declared DO look is if they might be wrong [having looked up 'tilde' and MSI on Google, it looks as though COND_I* actually relates to strings, as it seems that the tilde means 'case insensitive', but I wonder if it has been inadvertently used on integer comparisons by some installers]. It also looks as if the tests in compare_int() for COND_LE and COND_ILE may be wrong, unless there is some kind of (uncommented) logic inversion somewhere. However, uppermost in my mind is Mike McCormack's statement that 'Unfortunately cond.y has nothing to do with SQL.'. If this is indeed the case then everything I have said amounts to nought because I have assumed (very likely incorrectly) that the parser code in cond.y, being part of the MSI dll, relates to the parsing of SQL statements in MSI. If this is the case I fully expect to burn in newbie-land, and apologise for my presumption. Torch me if you want. Just trying to help, and open the discussion :)

1 0

Re: msi patch submission - cond.y
by Mike McCormack June 5, 2006

June 5, 2006

EA Durbin wrote: > fixed various SQL errors in COND_GetOperator() and compare_int() Unfortunately cond.y has nothing to do with SQL. Mike

3 3

re: Wine VM86 exception handling bug?
by Dan Kegel June 5, 2006

June 5, 2006

Andrey wrote: > My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86 > would restore vm86 registers correctly. I think i know what is the > problem; however, I lack experience to fix it myself :) > I need help; any hints would be appreciated. How about writing a conformance test that demonstrates the problem? That will help focus discussion and energy on it, and keep it from coming back. Thanks! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

7 11