June 2006 - Wine-Devel - list.winehq.org

Re: [Wine] Re: wine-0.9.15 & winetools problems.
by Rick Romero June 13, 2006

June 13, 2006

On Tue, 2006-06-13 at 21:47 +0200, Peter Åstrand wrote: > On Tue, 13 Jun 2006, Jonathan Ernst wrote: > > > BTW, as I used to maintain this entry, > > If you consider yourself an inactive maintainer, perhaps you should let > someone else takeover? > > > > I updated it with current > > informations. I don't have time to test the runtime settings so I'd be > > glad if you could fill the missing part and send me the details so I'll > > update the entry http://appdb.winehq.org/appview.php?versionId=469 > > Thanks for the update. A few comments: > > * I think the reference to WineTools and Sidenet should be removed. Wine > version 20050725 is quite old. I think we should focus on having the > latest AppDb pages document the latest Wine, rather than old stuff. > > * The manual installation still doesn't work for me (see bug 5409 etc), > but let's get back to that. > > * I think it would be nice if you could include my command lines for > fetching & extracting inseng.dll, for those users without a Windows > installation nearby: > > $ wget http://download.microsoft.com/download/ie6sp1/finrel/6_sp1/W98NT42KMeXP/EN-… > $ cabextract -L IE_S5.CAB > $ cabextract -L -F inseng.dll ie_5.cab > $ rm -rf ~/.wine ie_5.cab IE_S5.CAB > $ wineprefixcreate > $ cp inseng.dll ~/.wine/drive_c/windows/system32/ > $ wget http://download.microsoft.com/download/ie6sp1/finrel/6_sp1/W98NT42KMeXP/EN-… > $ wine ie6setup.exe > Interestingly I _JUST_ decided to go through this myself on a raw wine install of .9.15 So I did the following (Some relate this Subject, some just FYI): 1. Ok, RPM installed. Now what? I need IE. 2. run winecfg, create new Wine install. (Icon says 'Add Application', thought it was for installing applications :/ ) Exit. 2. Read Install/Config HowTo http://www.winehq.org/site/howto 3. Follow link to appdb 4. type 'Internet Explorer' in search 5. Click Internet Explorer link 6. Click 6.0 7. Look confused for a moment, then scroll down far enough to see there's a HOWTO with a dark green background that's hard to see in Opera. 8. 'Install dll?' Screw that, follow link to IE6 at MS. 9. Download IE6SP1 ie6setup.exe 500k. 10. wine ie6setup.exe 11. Error. Go back to Appdb, get dll from link at dlldump.com 12. wine ie6setup.exe 13. Error. "The download location information is damaged" WTF? 14. Ok, maybe I should choose custom install.. Did I get the option? wine ie6setup.exe No options, installs complete. 15. wine IEXPLORE.EXE White Page. Not good. 16. Search for 'Could not load Mozilla' 17. Install ActiveX Control and learn it's re-written and not done yet. So I did all this to test some 'web' VoiceChat, http://www.univoice.us/demo/ that installs from a cab file through IE. Is this functionality lost with this migration from IE to internal rendering? Rick > Regards, > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users

3 2

wined3d: GLSL Patch feedback requested
by Jason Green June 13, 2006

June 13, 2006

The current cumulative patch is located here: http://cmhousing.net/wine/glsl_cumul.diff (This includes the recently submitted "Split constant loading out of drawPrim()" patch, which hasn't been applied to git yet) Before submitting, I plan to fix the following things: - Fix relative addressing (it was working correctly, then I lost some stuff when my hard drive got corrupted, and now it's using R0 instead of A0 as the address register for some reason) - Switch the shader_reg_maps.constantsF[] to a CHAR array instead of a BOOL array (maybe even a bitmap(?)) This whole patchset should be a no-op for normal users, unless they have the UseGLSL registry key enabled. Here's a list of the changelogs that this cumulative patch entails, somewhat in the order that I'll be sending them: [already sent] Move constant loading out of DrawPrimDrawStrided() - DrawPrim is just too big of a function. This separates the passing of constants to the shader into new functions. - Fixes an off-by-one error when loading vertex declaration constants (should be <, not <=) - Adds a function for GLSL loading of constants (aka Uniforms) - Adds a GLSL program variable to the stateblock and sets it to 0 (a future patch will actually create this program) Add GLSL helper functions to device.c - Adds functions to attach & detach shader objects, create and delete programs, and maintain the list of programs. - Adds a list of GLSL shader programs to the device which is initialized on Init3D(), and deleted on Release() Add the bulk of the GLSL string generation functions - Add a new file glsl_shader.c which contains almost every GLSL specific function we'll need - Move print_glsl_info() into glsl_shader.c - Move the shader_reg_maps struct info into the private header, and make it part of SHADER_OPCODE_ARG. - Create a new shared ps/vs register map for float constants (future patch will make ARB programs use this, too) - This is a big patch, but none of the new functions in glsl_shader.c are being called yet. This just sets them up. Unified float constant register mapping between ARB pixel and vertex shaders. - Got rid of the separate constant maps. - Side effect of this is that the map is a bit larger for pixel shaders than it needs to be. - Will make this dynamic in a future patch. Added more declarations to GLSL in generate_glsl_declarations() - Declare more variable names for GLSL programs. - Correct output name for pixel shaders (gl_FragColor instead of glFragColor) Map pixel shader instructions to GLSL generating functions. - Also, delete the GLSL program when the refcount hits 0 Map vertex shader instructions to GLSL generating functions. - Also, delete the GLSL program when the refcount hits 0 Allow drawPrim to create and use the GLSL program - Now that we can fully create a GLSL program, this patch lets us actually use it. I would have submitted these all separate for review, but I have some janitorial git cleanup to do first to get all of this in the right order.

5 8

WINED3D: Bug 5418
by H. Verbeet June 13, 2006

June 13, 2006

http://bugs.winehq.org/show_bug.cgi?id=5418 The code in question does look a bit dodgy. Bad merge perhaps?

2 1

Re: Martin Fuchs : shell32: SHELL32_GetItemAttributes()
by Rein Klazes June 13, 2006

June 13, 2006

Hallo Martin. This patch is giving me trouble: >Author: Martin Fuchs <martin-fuchs(a)gmx.net> >Date: Sat Feb 11 12:16:56 2006 +0100 > >shell32: SHELL32_GetItemAttributes() >- correct documentation which incorrectly claimed not to set any > attribute bits >- retrieve file attributes using SHGetPathFromIDListW() when they are > not already present in the internal PIDL structures >- add test case to show the previously wrong folder attributes when > using absolute PIDLs >- fix some memory leaks in the tests in a couple of wine configurations that I use this leads to an infinite lop when the openfile dialog is called. The call sequence is SHELL32_GetItemAttributes->SHGetPathFromIDListW->ISF_Desktop_fnGetAttributesOf->SHELL32_GetItemAttributes which repeats until the stack overflows. Here is a part of a back trace: | 13 0x7b8533ed SHELL32_GetItemAttributes+0x2dd(psf=0x7bc6bc28, pidl=0x7bc5e058, pdwAttributes=0x7ba5ae54) [/usr/home/projects/wine/mywine/dlls/shell32/shlfolder.c:430] in shell32 (0x7b8533ed) | 14 0x7b83fcb8 ISF_Desktop_fnGetAttributesOf+0x148(iface=0x7bc6bc28, cidl=0x1, apidl=0x7ba5ae5c, rgfInOut=0x7ba5ae54) [/usr/home/projects/wine/mywine/dlls/shell32/shfldr_desktop.c:459] in shell32 (0x7b83fcb8) | 15 0x7b8288cd SHGetPathFromIDListW+0x7d(pidl=0x7bc5e058, pszPath=0x7ba5b0c0) [/usr/home/projects/wine/mywine/dlls/shell32/pidl.c:1273] in shell32 (0x7b8288cd) | 16 0x7b8533ed SHELL32_GetItemAttributes+0x2dd(psf=0x7bc6bbb8, pidl=0x7bc5e058, pdwAttributes=0x7ba5b334) [/usr/home/projects/wine/mywine/dlls/shell32/shlfolder.c:430] in shell32 (0x7b8533ed) | 17 0x7b83fcb8 ISF_Desktop_fnGetAttributesOf+0x148(iface=0x7bc6bbb8, cidl=0x1, apidl=0x7ba5b33c, rgfInOut=0x7ba5b334) [/usr/home/projects/wine/mywine/dlls/shell32/shfldr_desktop.c:459] in shell32 (0x7b83fcb8) | 18 0x7b8288cd SHGetPathFromIDListW+0x7d(pidl=0x7bc5e058, pszPath=0x7ba5b5a0) [/usr/home/projects/wine/mywine/dlls/shell32/pidl.c:1273] in shell32 (0x7b8288cd) | 19 0x7b8533ed SHELL32_GetItemAttributes+0x2dd(psf=0x7bc6dd70, pidl=0x7bc5e058, pdwAttributes=0x7ba5b814) [/usr/home/projects/wine/mywine/dlls/shell32/shlfolder.c:430] in shell32 (0x7b8533ed) A +relay,+shell log of one loop is attached below. Running wineprefixcreate or reinstalling wine.inf does not help. On a clean new installation there is no problem (but I like to keep using the old stuff with a hundred or so of installed windows programs). Any idea? Rein.

3 4

Re: riched20 patch
by James Hawkins June 13, 2006

June 13, 2006

On 6/12/06, Clinton Stimpson <clinton(a)elemtech.com> wrote: > > Second attempt (seems my last one email with this patch dropped through > the cracks ??): > > Attached is a patch to fix a crash when EM_SETTEXTEX is called with a > NULL lParam. > Return values and behavior has been verified and found equivalent to an > app on Windows. > This will have a much better chance getting accepted if you provide a test case for this behavior. -- James Hawkins

1 0

Wine's Mozilla Control - Very old
by Boaz Harrosh June 13, 2006

June 13, 2006

For any it might concern! The Mozilla ActiveX Control recommended for download by Wine is based on a pre FireFox 1.0 gecko engine and is missing support for many web standards! I was doing development in Windows and needed an Embedded browser. I wanted to also support Mozilla engine and was Quickly downloading the ActiveX from wine download page. (My installed FireFox does not supply one). My work involved embedding the FCKEditor (http://FCKEditor.sourceforge.net) So I installed and change the source code to use the Mozilla GUID and oops FCKEditor does not work. After some investigation I found that even though the Control's package is from Q4/2005 the engine included is much older and belongs to Mozilla 1.6 or something. Since then the Mozilla package did not include a new Control and Has eventually stopped been released. (Do to FireFox replacing it). The New (Mozilla 1.8) Control can only be found in the new SeaMonkey 1.0.x package, which is what I got. And with this control every thing works grate. (Even better than IE). Now SeaMonkey (http://www.mozilla.org/projects/seamonkey) is a very large package and is not something a user would be Happy to be forced with. I did Package a one time Installation of the new Control, stripping down from SeaMonkey anything I could guess does not belong. But this is a one time Job and I'm not sure is the right solution. Maybe we should contact the Sea-Monkey maintainers and ask them to Also produce an "on the side" extra package for our sake. I have not done that yet ... Any body in contact with Mozilla.org? Free Life Boaz

1 0

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW
by Juan Lang June 13, 2006

June 13, 2006

Hi Christian, thanks for working on setupapi, it could use some help. Huw already commnented on your patch, I have a couple more: + if (!list) { + goto cleanup; + } The style in this file has opening braces on lines of their own, e.g.: if (hInf == INVALID_HANDLE_VALUE) { return FALSE; } Please stick with that. + if (MachineName != NULL) { You should probably just fail if the machine name isn't NULL, since you don't use it and you don't connect to a remote machine anyway. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Crash in XOpenIM in wine 0.9.15
by Daniel Skorka June 13, 2006

June 13, 2006

Hello, I want to bring an issue that has appeared on wine-users to your attention. The issue is basically this: Any time a process in wine tries to execute another process, wine will crash following a call to XOpenIM. For details please look here [1]. I'm sure Leigh is willing to provide any additional info required. regards, Daniel [1] http://www.winehq.org/pipermail/wine-users/2006-June/021973.html

2 1

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW
by Huw Davies June 13, 2006

June 13, 2006

On Tue, Jun 13, 2006 at 03:42:22PM +0200, Christian Gmeiner wrote: > diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c > index f402f00..c24ae1e 100644 > --- a/dlls/setupapi/devinst.c > +++ b/dlls/setupapi/devinst.c > HDEVINFO WINAPI > -SetupDiCreateDeviceInfoListExW(const GUID *ClassGuid, > - HWND hwndParent, > - PCWSTR MachineName, > - PVOID Reserved) > +SetupDiCreateDeviceInfoListExW( > + const GUID *ClassGuid, > + HWND hwndParent, > + PCWSTR MachineName, > + PVOID Reserved) Please avoid these unnecessary whitespace changes, they just make the patch bigger. > diff --git a/dlls/setupapi/setupapi_private.h b/dlls/setupapi/setupapi_private.h > index bce05cb..77e4fb0 100644 > --- a/dlls/setupapi/setupapi_private.h > +++ b/dlls/setupapi/setupapi_private.h > +struct DeviceInfoSet > +{ > + DWORD magic; /* if is equal to SETUP_DEVICE_INFO_SET_MAGIC struct is okay */ > + GUID ClassGuid; > + PWSTR MachineName; > + HWND hwndParent; > +}; > + Is this struct going to be used by functions outside devinst.c? If not then this should be moved into that file. Also please include a test with your patch and, in this case, I think it makes sense to include the appropiate Destroy function too, that way it's easy to check that you haven't introduced a memory leak. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: What is needed to get more sites with a winetest executable
by Paul Vriens June 13, 2006

June 13, 2006

> Am Montag, 12. Juni 2006 20:22 schrieb Paul Vriens: >> Hi, >> >> in the last months we've experienced several times that there was no winetest.exe available at the usual location >> (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. >> >> What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? >> >> Cheers, >> >> Paul. > Hi, > > not the answer to your question, but some thoughts about the topic. > > As long as the automatic build of Paul Millar works, there is not reason to > have a second winetest binary for nearly the same git/cvs source of the tests. One binary a day is enough. If you check > http://test.winehq.org/data/ > you will see that we miss often tests results for some windows platforms. > > If building the winetest binary fails. Someone needs to look into the reason > anyway. In almost all cases its a missing import in a library the test ist linked against. So first "our mingw environment" needs to be fixed. Just running another automatic build will fail with the same error as the build of > Paul. > > Its not hard for me to do the manual build. I just need some webspace to put > the stuff on. And i need to know what needs to be modified in the source before the build (somehow the build date need to be patched into the source). > Also the question is how the new build is announce to the public (hope that > it si not the case that it appears on astro.gla.ac.uk). > > Bye Stefan > Hi, exactly my point. I know Paul Millar fixes stuff all the time by patches of you I think and Hans Leidekker (and others). But he is only one person, with of course a limited amount of time. Maybe we should have a few sites generating the winebuild and using a different path to publish stuff at test.winehq.org/data/[site]. We don't want to mix the output of different executables in one view (apples and pears). Another thing what we could is just use a well-known-url for the winetest.exe like we did with the Mozilla ActiveX component. This url should of course point to the latest available on all site (don't know if that's feasible). Cheers, Paul.

2 2

Re: msvcrt[1/2]: add initial tests for dlls/msvcrt/data.c
by Alexandre Julliard June 13, 2006

June 13, 2006

Andrew Ziem <ahziem1(a)mailbolt.com> writes: > +typedef void (*_INITTERMFUN)(void); > +unsigned int (WINAPI *p_initterm)(_INITTERMFUN *,_INITTERMFUN *); Msvcrt functions are not WINAPI. And why don't you simply call the function directly instead of loading it dynamically? -- Alexandre Julliard julliard(a)winehq.org

2 2

Vertex Buffer Objects for WineD3D
by Stefan Dösinger June 13, 2006

June 13, 2006

Hi, In the last days I've been working on using the OpenGL vertex buffer objects extension for IWineD3DVertexBuffer. The aims of this were: * Store geometry data in the hardware for more efficient rendering * Convert the colors and rhw values on upload and get rid of drawStridedSlow The result is in this diff, and it basically works, although not as good as I've hoped. It gives a nice performance boost to Battlefield 1942, and is an improvement for Half-Life 2, but it is not perfect yet. The main shortcomings are: * Shader support: I'm afraid that the conversion code at this points breaks shaders. I've tested with battlefield 1942. The vertex shaders in this game don't work correctly yet, the hands of soldiers are missing and there are some incorrect planes with odd colors. However, with this patch the hands are drawn as apparently random vertices all over the screen. I think I'll need a little help from the shader people for that. * The vertex conversion is slow, and it turned out that if the app Locks the Buffer every frame then drawStridedSlow is faster Converting + drawStridedSlow. Because of that VBOs and the conversion aren't used for vertex buffers in system memory and vbs with WINED3DUSAGE_DYNAMIC are not loaded into a vbo. * In Direct3D7 there is no way for the app to specify a range of vertices to be locked. Because of that DX7 apps are generally slower if they update the vertices regularily. To avoid that drawback there is no VBO created for DX7 apps if they have vertex data that needs conversion. The geometry in DX7 apps is usually quite simple, so DrawStridedSlow isn't a big performance hit in those apps. Stefan

3 4

What is needed to get more sites with a winetest executable
by Paul Vriens June 13, 2006

June 13, 2006

Hi, in the last months we've experienced several times that there was no winetest.exe available at the usual location (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? Cheers, Paul.

2 1

wined3d: Another GLSL shader status update
by Jason Green June 13, 2006

June 13, 2006

Well, I've fixed the speed issues with using GLSL (it's now just as fast as ARB shaders for the ones that actually work correctly) and gotten a few other things to work correctly. However, I'm still having issues with certain pixel/vertex shader combinations. Ohsix caught on that it may have to do with sampler limits on graphics cards and how sampling/textures are handled different in GLSL that with ARB. I'm not sure at the moment and could use some help. http://cmhousing.net/wine/glsl_hack6.diff is the diff against the most recent git tree. There are still some ugly hacks lying around in there. Note that I've separated out most of the GLSL functions into a new file "glsl_shader.c". Once again, to use GLSL instead of ARB shaders, you'll have to apply this patch, have a graphics card that's capable of GLSL, and add the following case senstive registry key: HKCU\Software\Wine\Direct3D\UseGLSL = "enabled" (String value)

6 13

comctl32.dll: Running siap and modules under wine, first steps
by Maximiliano Curia June 12, 2006

June 12, 2006

Hi, I'm trying to use a program called "siap"[1] under wine. It's the required program to pay taxes that the Argentinian government uses. So, it's quite important for the free software community in Argentina to be able to use it in a free software environment. However, I haven't heard of any real success on it, so far. I've been trying to make it run using winetools[2], and differents versions of wine. The furthest I've gone, has been with version 20050310 and all the "plugins" that winetools provides, installed. Only then, could I install the application, run it, switch between the different modules (although it worked only sometimes), but I can't really use it. There are a couple of important widgets that seem to be incompatible with wine. But as I'm not an expert neither in Windows nor in wine, the one I could really track down is a TreeView widget (from comctl32.dll) (from the main window of the program), that is not fully implemented in wine, and by using a native comctl32.dll (I tried using the win98, winme, win2k libraries) the widget would work but some of the other stuff, like switching to one of the modules wouldn't. I made a screenshot to make this clearer, the wine version[3] and the w2k version[4]. So, what should I do next? Is there some documentation of how to implement a certain Windows widget in wine? Is anybody working in this dll, or has worked on this widget? I'd appreciate any comments. Thanks, [1] http://www.afip.gov.ar/programas/siap_main.asp (spanish only) [2] http://www.von-thadden.de/Joachim/WineTools/ [3] http://gnuservers.com.ar/~maxy/wine/siap-wine.png [4] http://gnuservers.com.ar/~maxy/wine/siap-w2k.png -- Saludos, /\/\ /\ >< `/

4 8

Re: Gnome and KDE wine configuration tools
by Yuriy June 12, 2006

June 12, 2006

> > > Guidance : > --------------- > Its not completely wine configuration utility, but a general > purpose system configuration utility for KDE. It now has got some > module for configuring WINE also. I got this news from > http://dot.kde.org/1150047999/. I havent tested it, but it can be got > from here http://www.simonzone.com/software/guidance/ > > Conclusion, its for you all to decide which is the best tool. And not > to forget give some valuable inputs to the developers to improve. > > Thanks, > Vijay > Hi, I'm the one making that. There's nothing much to test yet (need to get busier!), and it's not on the site, it's in SVN. Input is good of course. ~Yuriy

1 0

Re: Alexandre Julliard : riched20: Fix an uninitialized variable bug.
by Marcus Meissner June 12, 2006

June 12, 2006

On Mon, Jun 12, 2006 at 10:02:35AM -0500, Alexandre Julliard wrote: > Module: wine > Branch: refs/heads/master > Commit: fe4c4780eb0a047f09a2e536eeaa1f51434b4b61 > URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=fe4c4780eb0a047f09a2e53… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Jun 12 16:09:50 2006 +0200 > > riched20: Fix an uninitialized variable bug. > > Mark todo a test that depended on the bug to succeed. And I wondered if only I was seeing this bug ;) Ciao, Marcus

1 0

re: WM_GETICON patch
by Dan Kegel June 12, 2006

June 12, 2006

Mike Hearn wrote: > ... obviously WM_GETICON > requires inter-process bitmaps to be supported in some fashion, which is a > fair bit of work. Maybe for efficiency reasons even requiring the dreaded > remote thread creation/service thread :) Adding support for remote thread creation is on Tommy Kho's to-do list. (Probably just for linux and nptl initially.) - Dan

1 0

WM_GETICON patch
by Chris June 12, 2006

June 12, 2006

Here's a patch I'm trying to make to implement the WM_GETICON message, which programs like GeoShell (a Win32 taskbar replacement) would use to get a taskbar icon for the running processes. I'm not quite sure if it's proper or not, though. Originally GeoShell would show no icon on the taskbar and print a lot of fixme messages about it being unsupported. With this patch it now (always) shows the Wine glass icon for programs, with no such fixme messages. Since I'm unable to try it on a real Windows machine, I don't know if it's the right behavior for it to always show the generic icon like that. Feedback and help would be appreciated.

2 5

Gnome and KDE wine configuration tools
by Vijay Kiran Kamuju June 12, 2006

June 12, 2006

Hi, I was just looking at browsing net for some linux stuff. I just happend to see some news related to wine Wine-doors : ------------------ Its just a wine installation utility for GNOME with preliminary(very basic and primitive) wine configuration.It has support for multiple installations, from screenshots i think so. I got this news from here http://gnomedesktop.org/node/2689, and more information can be got from its web site http://www.wine-doors.org/ Guidance : --------------- Its not completely wine configuration utility, but a general purpose system configuration utility for KDE. It now has got some module for configuring WINE also. I got this news from http://dot.kde.org/1150047999/. I havent tested it, but it can be got from here http://www.simonzone.com/software/guidance/ Conclusion, its for you all to decide which is the best tool. And not to forget give some valuable inputs to the developers to improve. Thanks, Vijay

2 1

x11drv: set window manager icon hints correctly
by Juris Smotrovs June 12, 2006

June 12, 2006

Currently, for many applications the generic Wine icon or a class default icon is used in window manager caption or taskbar instead of the application icon set with WM_SETICON. See, for instance, Bug 3370. What actually happens is this: the application icon is correctly set when processing WM_SETICON, but a bit later, when window is mapped, X11DRV_set_wm_hints resets it back to class default (or to none, leading to Wine icon). It seems that X11DRV_set_wm_hints has been designed to be called only when creating a window: it alocates WM hints -- XAllocWMHints() -- instead of checking for existing ones with XGetWMHints(...), and sets class default icon, instead of checking whether another icon has been set in the meantime. However, calls to X11DRV_set_wm_hints have been added at mapping a window and changing window style (see x11drv/winpos.c). Thus, Wine currently allocates WM hints anew and resets icon at every mapping and style change of a window. I attach a patch to X11DRV_set_wm_hints correcting this issue: 1) it checks for existing WM hints before allocating new ones, 2) it resets icon to class default only if no icon hint has been set earlier. Please, let me know if you see anything wrong with this patch. Cheers, Juris

1 0

Re: winmm: Add support for "open new" commands.
by Eric Pouech June 12, 2006

June 12, 2006

Peter Åstrand wrote: > > ChangeLog: > winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) A+

3 3

Re: WineD3D: Fog fixes, try 2
by Stefan Dösinger June 12, 2006

June 12, 2006

Hi, Apply this patch instead, the old patch had some sloppiness error(setting FOGSTART as FOGEND when restoring z-based fog). The problem is corrected in this patch. It also doesn't add a senseless space at the begin of the file and sets the fog to GL_FASTEST for vertex fog and GL_NICEST for table / pixel fog. ChangeLog: Stefan Dösinger(for CodeWeavers): Correct vertex fog for transformed vertices and correctly handle non-vertex, non-table fog

3 3

uxtheme efforts (wanted/needed ?)
by Paul Vriens June 12, 2006

June 12, 2006

Hi, I've sent 2 emails that are (for now) silently ignored: http://www.winehq.org/pipermail/wine-patches/2006-June/027253.html http://www.winehq.org/pipermail/wine-patches/2006-June/027350.html They both have to do with uxtheme and were meant as a starter for conformance tests and of course the fixes to it. I first wanted to start with input/return paramater and value testing before I touch any functional part (maybe not mutually exclusive). Was there anything wrong with the patches? How can I improve or what do I have to change? Cheers, Paul

2 1

Re: Broken FC5 packages - stay clear.
by Hans Leidekker June 12, 2006

June 12, 2006

On Monday 12 June 2006 12:04, Andreas Bierfert wrote: > > Good, but shouldn't zlib-devel be pulled in like that too then? > > Oh... don't even mention discussions on what should be in the minimal build > root and what shouldn't ;) I'm not, this isn't about the minimal build system. zlib-devel should be pulled in through whatever package depends on it. > It is :) gphoto2 is pulled in by sane? I believe... anyway last time I > checked (0.9.14) it was pulled in :) Right, but gphoto2 is a direct Wine dependency, so it would be better IMO to support it as such. It's also more flexible, i.e this way a user could choose to install gphoto2 but not sane support. -Hans

1 0