June 2006 - Wine-Devel - list.winehq.org

Re: notepad: settings saving code
by Robert Shearman June 9, 2006

June 9, 2006

Anoni Moose wrote: >/* This table is used to save all of the needed font settings in Notepad. > * It looks quite messy, when in fact it _hugely_ eases loading/setting of settings. Really. ;) > * It is layed out as follows: > * > * [n][0] == pointer to registry subkey name (WCHAR) > * [n][1] == type of registry entry > * [n][2] == pointer to buffer to store setting > * [n][3] == size of data returned > * [n][4] == default value to use if subkey was not found > * [n][5] == registry path to open (ANSI, not including root (HKEY_CURRENT_USER, etc)) > */ >DWORD settings_data[15][6] = { > { (DWORD)&heightW, REG_DWORD, (DWORD)&Globals.lfFont.lfHeight, > sizeof(REG_DWORD), -10, (DWORD)&FONT_SETTINGS_REG_PATH }, > > You should define a proper structure to put this data in rather than casting the values to DWORD (which won't work in 64-bit mode). -- Rob Shearman

1 0

Re: regedit: bug fixes/feature
by Robert Shearman June 9, 2006

June 9, 2006

Anoni Moose wrote: > These patches save current node on click, and remove items before > opening keys, so if a node has no keys/is invalid, no keys show, which > can lead to problems. Changelog: > > * programs/regedit/main.c, programs/regedit/childwnd.c: > regedit: Save current node to registry on change; load again after > regedit is reopened. > -Don't UpdateWindow() in InitInstance() (unneeded, adds > flicker). > -Delete all items from listview before opening key, so if > key open fails, no items display. > This patch looks good, but I'm not sure about removing the UpdateWindow call. I think it is still necessary, although it might be better to move it to after the getting of the default path, which should remove the flicker. -- Rob Shearman

1 0

Re: regedit: Refresh also refresh registry keys in listview
by James Hawkins June 9, 2006

June 9, 2006

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > These patches allow for refreshing of registry keys in listview, when > Refresh menu item is selected. > > Changelog: > > * programs/regedit/framewnd.c, programs/regedit/treeview.c: > regedit: Uncomment RefreshListView() call, comment TVM_SELECTITEM call, > to > let "Refresh" menu item/key also refresh registry values being > shown > in treeview. > One patch per email please. Same goes for all your other submissions. -- James Hawkins

1 0

Re: edit: Fix crashing, bugs
by James Hawkins June 9, 2006

June 9, 2006

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > This patch fix an unhandled page fault with MS notepad and Wine Notepad when > loading/editing large files, and some other bugs shown in the Changelog: > > * dlls/user/edit.c: > user: Fixed unhandled page-fault when text length exceeded buffer size. > -Don't gradually continue to highlight text if mouse button is > held in and > it's position moves out of the edit window, and doesn't move while > outside. > -Scroll up/down if mouse is outside of window and moving up/down. > -If a button was clicked in a dialog, therefore setting the focus > to it, and then > an application sent a SETFOCUS message to an editbox, it would > keep the focus on > the button. > You need to submit one fix per patch, one patch per email. -- James Hawkins

1 0

Re: str*casecmpW functions
by Vitaliy Margolen June 9, 2006

June 9, 2006

Thursday, June 8, 2006, 6:57:36 PM, Anoni Moose wrote: > This patch adds some functions for comparison of WCHAR strings, while ignoring case. Changelog: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. BTW what's wrong with strncmpiW? Vitaliy Margolen

1 0

Re: server: use getopt
by Mike McCormack June 9, 2006

June 9, 2006

Anoni Moose wrote: > This patch let's the server code use getopt to parse arguments. + while ((optchr = getopt(argc, argv, "d:fhk:p:vw")) != -1 && + optind < argc) { /* 'Tis possible we might have a variable declaration... */ + + switch (optchr) { + case 'd': - if (isdigit(argv[i][2])) debug_level = atoi( argv[i] + 2 ); + if (isdigit(optarg[0])) debug_level = atoi( optarg ); else debug_level++; break; Using getopt() doesn't really gain us anything here. Also, changing the indent and brace style to suit yourself (especially in wineserver) isn't appreciated. Mike

1 0

Re: wcmd: some features/bug fixes
by Mike McCormack June 9, 2006

June 9, 2006

Anoni Moose wrote: > * programs/wcmd/builtins.c, programs/wcmd/wcmdmain.c, > programs/wcmd/wcmd.h: > wcmd: Clear terminal screen using escape code. > -Fix infinite file-read loop with TYPE command. > -TITLE command use terminal escape code. > -Added FREEDISK command. Please send one patch per email. The patch should be standalone. + /* Clear the _terminal_ screen by giving the correct terminal escape code. */ + printf("%cc", 0x1B); You can't assume that you'll be using any sort of terminal here. If the backend is wineconsole or a non-xterm/vt100 terminal, then this won't work. You have to use the Win32 API. Mike

1 0

Re: str*casecmpW functions
by Mike McCormack June 9, 2006

June 9, 2006

Anoni Moose wrote: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. You've added a dependency on user32.tolowerW, which cannot be linked from all the places that unicode.h is used. Mike

1 0

Re: notepad: settings saving code
by Mike McCormack June 9, 2006

June 9, 2006

Anoni Moose wrote: > The following files allow saving and loading of notepad's settings to > the registry. No patch needed... new files. Changelog: Always send a patch, and make sure to create it from your wine/ directory so that the full path of the file that you're modifying is specified. These files won't be compiled unless you add something to the Makefile.in, and can't be used without some kind of change to the existing code. Mike

1 0

xlldrv/keyboard.c: Report of typos
by Andrew Talbot June 9, 2006

June 9, 2006

I believe there are numerous typos in this file. Starting at line 310, there seem to be several missing double quotes; they break compilation if -Wwrite-strings is specified. I was going to assume the missing quotes to be the only factor and fix things myself. But as there are some non-printing characters in there that I don't understand, I thought I would mention it here, instead, so that someone who knows about keyboard layouts might fix these arrays properly. -- Andy.

3 3

Prospects of an OpenAL audio driver...
by Nick Burns June 8, 2006

June 8, 2006

I have started work on an openal driver for wine... So far I have playback and recording working (with minor issues) (for some reason the DSound HEL is unhappy with my driver) OpenAL seems to have enough functionality to do the job. Are there any problems with using OpenAL for such a purpose? - Nick

3 7

Feedback requested for Mac OSX x86 stack patch
by Nick Burns June 8, 2006

June 8, 2006

(notes are at the top of the patch) I would like some feedback on my stack fix patch I do not know how it interacts with linux -- no access to a linux box This has been confirmed to fix numerous app issues (due to stack alignment) I am starting to think it would be better to have these options configured at config time -- e.g. If Mac OSX x86 -- then use mstackrealign + force_align_arg_pointer Any ideas/thoughts? - Nick

3 12

Feedback requested for Mac OSX x86 stack patch -- #2
by Nick Burns June 8, 2006

June 8, 2006

Ok I have fixed up my Mac OSX stack patch a bit as per the feedback -- thanks much This only patches windef.h There still needs to be some solution for msvcrt AND any other api entry points that are not denoted with __stdcall or __cdecl or WINAPI or WINAPIV.... This means that Morrowwind (uses msvcrt:pow just cause) will crash on OSX atm (bad alignment) - Nick

2 2

Feedback requested on an OpenAL audio driver patch -- #2
by Nick Burns June 8, 2006

June 8, 2006

Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff 2. configure.ac now checks for AL/al.h (which is where OpenAL should be) 3. dlls/Makefile.in should patch correctly now (I did not hand edit it this time -- still crossing fingers) 4. FIXME's -> ERR's for the legit OpenAL errs 5. alcCloseDevice in OpenAL 1.0 (no return value) in 1.1 it returns a boolean -- .: I dont check the boolean anymore -- meaning this error is now slient - Nick

2 2

Re: Linux noob
by Molle Bestefich June 8, 2006

June 8, 2006

Peter Beutner wrote: > Because it is the defacto standard to store settings > under ~/.<appname>. Only for stuff that's thought to be generally uninteresting. Your KDE desktop, for example, resides under ~/Desktop. > And with enough applications installed that use this "standard" > you probably will be glad that these directories are hidden so that > you don't have to scroll through them every time you open > your filemanager ;). I'm annoyed that .wine is inaccessible through KDE and Gnome apps. Not through the file manager, but often in various applications. It's not wine's fault per se that those apps lack a "show hidden folders" option, but it would be nice to make wine visible, as it contains useful stuff that you'll often mangle with. (I personally have a symlink from "wine" to ".wine"...) I do agree that there's too many applications dumping various .xxxxxx folders in my home directory. The least they could do is to put those files somewhere where they don't interfere with my user data, someplace sane like ~/Application Data/xxxxxx, or a more unixy ~/appdata/xxxxx... (Never cared much for hidden folders - they're a symptom that you're being too careless with your directory structure.)

6 13

Re: [MAPI32 2/3] interface IProfAdmin & its 12 methods, function MAPIAdminProfiles implemented
by Alexandre Julliard June 8, 2006

June 8, 2006

argentum(a)office.etersoft.ru writes: > +/************************************************************************** > + * IProfAdmin_GetLastError > + * > + * PARAMS > + * hResult [I] HRESULT data type containing the error value > + * generated in the previous method call. > + * lppMAPIError [O] Pointer to a pointer to the MAPIERROR structure > + * containing version, component, and context information > + * for the error. The lppMAPIError parameter can be set > + * to NULL if there is no MAPIERROR structure to return. > + * ulFlags [I] Bitmask of flags that controls the type of the string > + * pointed to by lpszProfileName. The following flag can be set: > + * 0 The strings in the structure returned in the pointer parameter > + * are in ANSI format > + * MAPI_UNICODE The structure's strings are in Unicode format. > + * RETURNS > + * S_OK The call succeeded and has returned the expected value or values. > + * MAPI_E_BAD_CHARWIDTH Either the MAPI_UNICODE flag was set and the implementation > + * does not support Unicode, or MAPI_UNICODE was not set and the > + * implementation only supports Unicode. > + */ Copying text from MSDN is not acceptable. If you are going to write documentation you have to do it in your own words, without looking at MSDN. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Feedback requested on an OpenAL audio driver patch -- #2
by Nick Burns June 8, 2006

June 8, 2006

(the elusive attachment) It helps when I hit the attach button (sorry) - Nick

1 0

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag June 8, 2006

June 8, 2006

P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon

3 2

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag June 8, 2006

June 8, 2006

> AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ > AudioUnit/AudioUnit.h \ > CoreAudio/CoreAudio.h \ > IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Suse 10.1) puts openal headers to AL/ instead of al/ and so configure with the patch as-is doesn't find files on my system. Also patching dlls/makefile.in fails. Had to patch it manually. Leon

2 1

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag June 8, 2006

June 8, 2006

My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal version is 1.0.20051129) 2) It'd be better to convert ALC errors from FIXMEs to ERRs. 3) You don't link the driver to openal somewhy (there's no -lopenal switch passed to gcc). Perhaps it's related to the configure.in hack I made, but I had to modify dlls/winmm/wineopenal/Makefile.in and add openal there too. 4) You check for al/al.h and OpenAL/al.h within the configure script but you include AL/al.h and OpenAL/al.h. This doesn't work on Linux, since Linux filesystems are case sensitive. Leon

2 1

Feedback requested on an OpenAL audio driver patch
by Nick Burns June 8, 2006

June 8, 2006

I finally figured out my dsound HEL problem (was making too many buffers) -- now I wait and only use a few buffers. It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) Remove the disable 'OPENAL_DISABLE_IN' to test wavein. (Forced off due to some issues of my OpenAL framework (I could only record at 44k -- could not figure out how to force 44k only for wavein) -- others may have better luck) So here is my patch -- It adds it to winecfg, the makefile.in, configure.ac And it adds the new files (the actual driver why not) I would like any feedback ppl out there may have. (It is missing a ChangeLog thingy -- that would look like the below) ---- 2006-06-04 Nick Burns <adger44(a)hotmail.com> * configure.ac: Added checks for OpenAL (Mac OSX and linux). * dlls/Makefile.in: Added OpenAL to build thingy. * include/config.h.in: Added OpenAL to config -- using autoheader (may not be needed). * programs/winecfg/audio.c: Added OpenAL to winecfg for choosing. * dlls/winmm/wineopenal/openal.c, dlls/winmm/wineopenal/openal.h, dlls/winmm/wineopenal/audio.c, dlls/winmm/wineopenal/wineopenal.drv.spec, dlls/winmm/wineopenal/Makefile.in: Initial checkin of OpenAL driver. ---- - Nick

2 2

Re: [KERNEL 1/2] changed test for function FindFirstFileA to find dosdevices
by Vitaliy Margolen June 8, 2006

June 8, 2006

Wednesday, June 7, 2006, 9:03:43 AM, Konstantin Petrov wrote: > changed test for function FindFirstFileA to find dosdevices. > As function FindFirstFile must accept such paths as > "c:\\windows\\win.ini" > "c:\\NUL", > "c:\\COM1", > "c:\\LPT1", > "c:\\LPT9", > "c:\\COM9", > "c:\\CON", > "c:\\AUX", > "c:\\PRN" > and mustn't accept paths: > "\\\\.\\CON", > "c:\\COM0", > "", > "c:\\LPT0", That's because you have only one serial and one parallel port. The special name is the special name. It's different how win9x and winNT handles them. Which system have you ran these tests on? Vitaliy Margolen

1 0

Re: shell32: Write-strings warning fix
by Robert Shearman June 7, 2006

June 7, 2006

Andrew Talbot wrote: >Changelog: > shell32: Write-strings warning fix. > >diff -urN a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c >--- a/dlls/shell32/shlview.c 2006-05-23 17:24:50.000000000 +0100 >+++ b/dlls/shell32/shlview.c 2006-06-07 19:37:41.000000000 +0100 >@@ -779,7 +779,9 @@ > */ > > static void ShellView_MergeViewMenu(IShellViewImpl * This, HMENU hSubMenu) >-{ MENUITEMINFOA mii; >+{ >+ MENUITEMINFOA mii; >+ static CHAR mii_type_data[] = "View"; > > TRACE("(%p)->(submenu=%p)\n",This,hSubMenu); > >@@ -791,7 +793,7 @@ > mii.cbSize = sizeof(mii); > mii.fMask = MIIM_SUBMENU | MIIM_TYPE | MIIM_DATA; > mii.fType = MFT_STRING; >- mii.dwTypeData = "View"; >+ mii.dwTypeData = mii_type_data; > mii.hSubMenu = LoadMenuA(shell32_hInstance, "MENU_001"); > InsertMenuItemA(hSubMenu, FCIDM_MENU_VIEW_SEP_OPTIONS, FALSE, &mii); > } > Sorry, this is wrong. If InsertMenuItemA writes to the string then it will be corrupted and will display the wrong thing for further uses in the process. It is therefore better to cast it from a "const char *" into a "char *" or to make it a non-static array at the top of the function. I think the first choice of keeping it a "const char *" is the best choice in this case. -- Rob Shearman

2 2

re: lstrlen(A/W) patch
by Dan Kegel June 7, 2006

June 7, 2006

Clinton wrote: >> Does the Richedit control return an error, or clear itself when passed >> EM_SETTEXTEX with lParam = NULL? >On Windows, it returns 1 and clears itself. Unless the ST_SELECTION >flag is set, in which case it returns 0, and actually replaces the text >with nothing. >My patch to wine results in the same behavior. I'll send it to >wine-patches. Great! Any chance you could include a conformance test in your patch? Thanks, Dan

1 0

Re: [uxtheme/tests] Add initial tests (Second try)
by Paul Vriens June 7, 2006

June 7, 2006

On Wed, 2006-06-07 at 08:44 +0200, Paul Vriens wrote: > Hi, > > I've added the framework and some initial (simple) tests. No > functionality tests (yet), only parameter and return-value checking. > > This one also 'fixes' the tests for Wine when theming is enabled. > > Changelog > Added framework and initial tests > > Cheers, > > Paul. Anything I can do to improve? This patch will of course be followed up by fixes. Cheers, Paul.

1 0

Hal and functions in setupapi
by Christian Gmeiner June 7, 2006

June 7, 2006

Hi all... at the momemt i am reading into functions to get some informations about e.g. cdrom drives. At the moment i am loking into SetupDiGetClassDevsW to support GUID_DEVINTERFACE_CDROM and later USB devices. My overall goal is it to get Line 6 software for my guitart effect board (USB) working with wine. Now i thought about a way to get all informations about a singe cdrom device. And i thought that I could use HAL perfectly for this. I thought about this way of doing it: Add hal.c file to setupapi dll, which contains function to get infromations about all needed hardware. This should work very nicly for this case. But as I want to programm RegisterDeviceNotification also we need a central way to handle hal stuff. So how should I go on? Use some own hal.c in setupapi or add an global wine way to interact with hal? Thanks, Christian

3 2

Re: libunicode: Add some more code page tables that are available for download from ftp.unicode.org, most notably the table for the us-ascii encoding, which is quite common.
by Alexandre Julliard June 7, 2006

June 7, 2006

Robert Shearman <rob(a)codeweavers.com> writes: > libs/unicode/Makefile.in | 3 > libs/unicode/c_1361.c | 5138 > ++++++++++++++++++++++++++++++++++++++++++++++ > libs/unicode/c_20000.c | 3587 ++++++++++++++++++++++++++++++++ > libs/unicode/c_20127.c | 683 ++++++ > libs/unicode/cpmap.pl | 3 > libs/unicode/cptable.c | 8 This won't work, the source files are not in the expected format, so the resulting tables contain garbage. You'll need to teach cpmap.pl to parse these files correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Avoid unnecessary casts
by Detlef Riekenberg June 7, 2006

June 7, 2006

Am Mittwoch, den 07.06.2006, 16:45 +0900 schrieb Dmitry Timoshkov: > - psh.u3.ppsp = (LPCPROPSHEETPAGEW) & psp; > + psh.u3.ppsp = psp; Where is the "&" ? -- By By ... ... Detlef

1 0

Re: [WINED3D 2/3] Fix missing light recording
by Michael Stefaniuc June 7, 2006

June 7, 2006

Ivan Gyurdiev wrote: > >> >From nobody Mon Sep 17 00:00:00 2001 >> > > Please delete this line in case the patch is corrupt.. missed it The patch is not corrupted as it starts only with the '---' line. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: lstrlen(A/W) patch
by Mike McCormack June 7, 2006

June 7, 2006

Clinton Stimpson wrote: > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" The inline lstrlenW is used only internally by Wine code, and we want it to crash when passed a NULL pointer. In this case, you should fix the Wine code calling lstrlenW to not use a NULL pointer. Mike

2 3

Re: D3D9: Add a test for setting / getting vertex shader constants
by Raphael June 6, 2006

June 6, 2006

On Tuesday 06 June 2006 23:17, H. Verbeet wrote: > This is a test for Ivan's patch for shader constants > (http://source.winehq.org/git/?p=wine.git;a=commit;h=5f5969b3c5bd237277b8f2 >f1eaa4ddacce5fb63b) > > Changelog: > - Add a test for setting / getting vertex shader constants Simple testing :) can you add border tests in future: hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 4, bool_in, 4); hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 2, bool_in, 4); I'm interested to see how windows handle that :) Regards, Raphael

3 3

winedbg - setting breakpoint
by Stephen Clark June 6, 2006

June 6, 2006

Hello List, I am trying to get classic Myst to run again under wine. How do I set a breakpoint in it when it run by winevdm. Thanks, Steve -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson)

2 1

re: Hal and functions in setupapi
by Dan Kegel June 6, 2006

June 6, 2006

Christian wrote: > as I want to programm RegisterDeviceNotification also we > need a central way to handle hal stuff. > > So how should I go on? Use some own hal.c in setupapi or > add an global wine way to interact with hal? I think programs/explorer already registers for device notification with hal. You should look at that before you go on. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: APPDB patch
by Tony Lambregts June 6, 2006

June 6, 2006

EA Durbin wrote: > fixed typographical errors. > > > ------------------------------------------------------------------------ > > ? patch.diff > Index: TODO > =================================================================== > RCS file: /home/wine/appdb/TODO,v > retrieving revision 1.22 > diff -u -p -r1.22 TODO > --- TODO 12 Jun 2005 02:50:18 -0000 1.22 > +++ TODO 6 Jun 2006 02:19:34 -0000 > @@ -7,7 +7,7 @@ WineHQ Application Database TODO List > AppDB Todo: > > * Improve application/version submission process > - Currently a user submits an application/version and a admin reviews it and > + Currently a user submits an application/version and an admin reviews it and > either makes changes to it and accepts it or writes a comment and rejects it. Upon > rejection the submission is deleted > > There is no sense in keeping our todos in two places. We should probabably just point to the wiki in this file. http://wiki.winehq.org/AppdbInfo Tony Lambregts

1 0

Re: lstrlen(A/W) patch
by Andreas Mohr June 6, 2006

June 6, 2006

Hi, On Mon, Jun 05, 2006 at 09:24:24PM -0600, Clinton Stimpson wrote: > > I encountered a crash when using PAF 5.2. > > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" MSDN documentation says many things... most of them wrong. ;-) (only slightly exaggerated, given Wine's experience with MSDN "correctness" over the years) IOW, I severely doubt that this is indeed the way Windows behaves, otherwise it'd have been fixed in Wine a long time ago already since apps would rely on and fully expect this behaviour of such a central and important function. Most likely you encountered application misbehaviour (feeding a NULL parameter to a function expecting non-NULL) due to a different Wine bug which thus caused the app to mis-step. Would be interesting to figure out why this happened (e.g. via +relay trace). Andreas Mohr

1 0

Wine updated in Fedora Extras!
by Neal Gompa June 6, 2006

June 6, 2006

Wine has been updated to 0.9.14 on May 30, 2006! So, this release took 6 days... Still, generally 3-5 days is pretty good estimation...

1 0

Re: winedbg: remove unneeded states from grammar (take 2)
by Alexandre Julliard June 6, 2006

June 6, 2006

Juan Lang <juan_lang(a)yahoo.com> writes: > Oops, last one had a missing brace. Sorry about that. > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them Won't that make it impossible to use command keywords as identifiers in commands that accept them, like disass? Come to think of it, your previous NOCMD patch probably has the same issue. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: wined3d: Another GLSL shader status update
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >A: wine-devel(a)winehq.com >De: Mike Hearn <mike(a)plan99.net> >Date: Tue, 06 Jun 2006 12:31:06 +0100 >Sujet: Re: wined3d: Another GLSL shader status update > >On Sun, 04 Jun 2006 12:04:21 -0400, Jason Green wrote: >> > This is an elaborate scheme with linked lists in each shader - is that >> > really necessary? >> > I'm very confused after reading the code (but maybe that's just me :) >> >> If we link the programs together every time the Set__Shader() is called, >> it brings performance to a halt (that what my glsl_hack4.diff did). > >Re: the recent discussion on code commenting and documentation, it'd be >nice if the patch explained this somewhere. It'd be even nicer still if at >some point one of you guys could take a break from the codeface and write >a chapter for the Wine Developer Guide on shaders and how all this works >... it seems incredibly opaque and the last thing we want is a re-run of >the DCOM situation where the only people who understood it left or hacked >on other things for a while and we lost the knowledge of how it worked. I Aggree that adding more comments about current architecture (at least on http://wiki.winehq.com/DirectX-Shaders and http://wiki.winehq.com/WineD3D) can help to better understand for non-d3d introduced wine hackers :) I was the first who delivered that code and it's my fault for the initial poor comments about architecture (who was understandable for opengl/directx hackers). We'll try to improve it (maybe beginning with "WineD3D for dummies" :) ) Anyway we are many who understand this code (and reviewing the flood of wined3d patches) so "DCOM situation" cannot happen :) >thanks -mike Regards, Raphael

1 0

Re: Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >Date: Tue, 06 Jun 2006 04:54:17 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: fenix(a)club-internet.fr >Copie à: wine-devel(a)winehq.org >Sujet: Re: [WINED3D 5/5] Remove constant type field in stateblock. > >Hi Raphael, > >Strange, your email shows up as an attachment. Yes it's my webmail who have strange behaviors :( > > + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start > > + 1)); > > should be: > > if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; > > UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); > > > as count and start are UINT (better to avoid ugliy > > unsigned/signed bugs). > >The current code checks if cnt < 0 later on. Yes but it was buggy :) MAX_VSHADER_CONSTANTS - (start + 1) can result on an unsigned overflow > > Anyway what windows do if (start + count > > > MAX_VSHADER_CONSTANTS) ? > > The code seems handle this case truncating the input > >It's possible that this is buggy [ I always thought it was off by one ], >or not handling this case properly. However, I've just copied the code >that was already there - unrolled the existing SetConstant function into >its callers, and made the change I was interested in. Fixing other bugs >would go into a separate patch. Ok, fine for me Waiting for more patches to review :) I'm really waiting to get my new GC to test last impressive work on shaders. Regards, Raphael

1 0

To K&R or not
by Molle Bestefich June 6, 2006

June 6, 2006

EA Durbin wrote: > >K&R style brack placements > > They are an eyesore and make things difficult to read. Highly subjective. I think K&R has distinct advantages, namely it unites the scope begin token with the relevant control statement. For me, this makes code easier and faster to read, since I can follow the indentation and arrive immediately at the relevant control statement. Also I think that K&R is nice in that it saves screen real estate, which again for me makes code easier to read because I can see more of it at once. I personally consider non-K&R style an eyesore because of this. CMIIW, but the only thing that non-K&R has going for it is that you can visually make out whether you've made the correct number of opening versus closing braces. I don't think that's much of an advantage, especially considering that any modern source code editor will highlight the starting brace or relevant control statement for you. That said, I don't care what people do, I can read both... In my perfect world though, my SCM client would convert source code to my preferred format on checkout, and to whatever universal format the repository uses on checkin. Ho hum...

7 11

Re: Re: Linux noob
by Mike Hearn June 6, 2006

June 6, 2006

On Tue, 06 Jun 2006 03:27:52 +0000, NikNot wrote: > Indeed! This is something that I found infuriating since I first > used wine. What possible reason would there be to make this > a "hidden" directory? From whom exactly should it be hidden > and why? Historical reasons. I'm switching this thread to wine-devel as TransGaming do in fact make the virtual C drive visible by default and it's maybe something we should do too. On the other hand, it might just be wallpapering over other usability problems (lack of menu integration, most obviously). How often does average jack need to go poking around C:\Program Files in real Windows? thanks -mike

1 0

re: acad 2004 license file bug
by Dan Kegel June 6, 2006

June 6, 2006

Jaap wrote: >The autocad installer indicated that I needed internet explorer 6.0, >so I installed that using winetools. Don't use winetools, please. As you noticed, it does bad things to your ~/.wine. Or, if you do use it, please report problems to the winetools developer, not here. > (can wine fake internet explorer, >so i don't need to install the real thing?) Yes. Here's what I do: # Fake IE per workaround in http://bugs.winehq.org/show_bug.cgi?id=3453 wineserver -k cat >> $HOME/.wine/system.reg <<"_EOF_" [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" _EOF_ - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

DirectX blitter bug
by Mike Hearn June 6, 2006

June 6, 2006

Lords of Magic works perfectly EXCEPT that rendering is corrupted when it is using DirectX "fast blitting"; they provide a software emulated workaround for some truly ancient cards (Matrox Mystique anyone?) and the game works well in this mode. But it should work properly in DirectX accelerated mode too. The kind of corruption varies but it appears as, for instance, mouse trails which to me suggests some kind of co-ordinate system problem. The demo is here: ftp://ftp.sierra.com/pub/sierra/lordsofmagic/demos/si_lordsofmagic_demo.exe and it installs cleanly on the master branch. If any DirectDraw gurus want to take a look, please do! I bet this problem affects other games too.... thanks -mike

2 2

Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr June 6, 2006

June 6, 2006

----Message d'origine---- >Date: Tue, 06 Jun 2006 02:46:59 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: wine patch <wine-patches(a)winehq.org> >Sujet: [WINED3D 5/5] Remove constant type field in stateblock. > >It is wrong to maintain a mapping from a constant index to a type field, >because different constant types do not share an index - boolean >constant 0 is supposed to co-exist with floating point constant 0, not >replace it. Drawprim and other code using the type array to decide >whether to look up a constant in bools, floats, or ints is wrong - you >can't make that decision based on the index. > >To do this: >========== >- split .set and .changed stateblock arrays for constants into >individual arrays for F, B, and I constants >- don't use shared SetConstant/GetConstant function in device.c, unroll >that into its callers, and make them use separate .set and .changed >arrays. Remove old SetConstant/GetConstant functions, not enough is >shared to justify them. Remove SetConstantN, it's not used anymore. >- change stateblock to not use the type array >- change drawprim to use the .set array, instead of a type array to >check if constants need to be loaded > Hi Ivan, just one comment: + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); should be: if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); as count and start are UINT (better to avoid ugliy unsigned/signed bugs). Anyway what windows do if (start + count > MAX_VSHADER_CONSTANTS) ? The code seems handle this case truncating the input Best Regards, Raphael

2 1

Re: winedbg: remove unneeded states from grammar
by Eric Pouech June 6, 2006

June 6, 2006

I'm not sure they are unneeded. for example, with your changes, b down would be seen by the grammar as tBREAKPOINT tDOWN which is not what we want. A+ 2006/6/6, Juan Lang <juan_lang(a)yahoo.com>: > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them > > --Juan > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > > > > > > -- Eric Pouech

1 0

GetDIBits() with a bitmap that is selected in a device context
by Michael Kaufmann June 6, 2006

June 6, 2006

The application "Fritz 5.32" calls GetDIBits() with a bitmap that is still selected in a device context (see bug 3893). The bitmap has a color table. GetDIBits() creates a memory DC, selects the bitmap into this DC, and calls GetDIBColorTable(). But this fails, because Wine can't select this bitmap in a memory device context again. According to MSDN, calling GetDIBits with a bitmap that is selected in a device context is not allowed. But surprisingly it works on Windows. Does anybody have an idea how to solve this problem? Regards, Michael

2 3

re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]
by Dan Kegel June 6, 2006

June 6, 2006

James wrote: > Is there anything wrong with this patch? Well, it doesn't have a conformance test... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 4

[Fwd: Re: msi patch submission - cond.y]
by Dominic Wise June 5, 2006

June 5, 2006

I may be wrong, but I feel it might be useful for a naive outsider to enter this discussion, even if it does mean I get burnt to a crisp. I'm neither a Wine nor a parser developer (though I do have a few years C/++ experience) and fully accept that I may be flamed to a tiny cinder for my comments, but from what I can ascertain, cond.y is a composite file, containing C and bison code. As far as I can tell (not quite brave enough to say AFAICT) the file is first read by the bison processor, which reads the bison parser rules and C code and generates compilable files for the C compiler. Having read what bison is (I think) supposed to do, the tokens declared DO look is if they might be wrong [having looked up 'tilde' and MSI on Google, it looks as though COND_I* actually relates to strings, as it seems that the tilde means 'case insensitive', but I wonder if it has been inadvertently used on integer comparisons by some installers]. It also looks as if the tests in compare_int() for COND_LE and COND_ILE may be wrong, unless there is some kind of (uncommented) logic inversion somewhere. However, uppermost in my mind is Mike McCormack's statement that 'Unfortunately cond.y has nothing to do with SQL.'. If this is indeed the case then everything I have said amounts to nought because I have assumed (very likely incorrectly) that the parser code in cond.y, being part of the MSI dll, relates to the parsing of SQL statements in MSI. If this is the case I fully expect to burn in newbie-land, and apologise for my presumption. Torch me if you want. Just trying to help, and open the discussion :)

1 0

Re: msi patch submission - cond.y
by Mike McCormack June 5, 2006

June 5, 2006

EA Durbin wrote: > fixed various SQL errors in COND_GetOperator() and compare_int() Unfortunately cond.y has nothing to do with SQL. Mike

3 3

re: Wine VM86 exception handling bug?
by Dan Kegel June 5, 2006

June 5, 2006

Andrey wrote: > My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86 > would restore vm86 registers correctly. I think i know what is the > problem; however, I lack experience to fix it myself :) > I need help; any hints would be appreciated. How about writing a conformance test that demonstrates the problem? That will help focus discussion and energy on it, and keep it from coming back. Thanks! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

7 11