June 2006 - Wine-Devel - list.winehq.org

x11drv: set window manager icon hints correctly
by Juris Smotrovs June 12, 2006

June 12, 2006

Currently, for many applications the generic Wine icon or a class default icon is used in window manager caption or taskbar instead of the application icon set with WM_SETICON. See, for instance, Bug 3370. What actually happens is this: the application icon is correctly set when processing WM_SETICON, but a bit later, when window is mapped, X11DRV_set_wm_hints resets it back to class default (or to none, leading to Wine icon). It seems that X11DRV_set_wm_hints has been designed to be called only when creating a window: it alocates WM hints -- XAllocWMHints() -- instead of checking for existing ones with XGetWMHints(...), and sets class default icon, instead of checking whether another icon has been set in the meantime. However, calls to X11DRV_set_wm_hints have been added at mapping a window and changing window style (see x11drv/winpos.c). Thus, Wine currently allocates WM hints anew and resets icon at every mapping and style change of a window. I attach a patch to X11DRV_set_wm_hints correcting this issue: 1) it checks for existing WM hints before allocating new ones, 2) it resets icon to class default only if no icon hint has been set earlier. Please, let me know if you see anything wrong with this patch. Cheers, Juris

1 0

Re: winmm: Add support for "open new" commands.
by Eric Pouech June 12, 2006

June 12, 2006

Peter Åstrand wrote: > > ChangeLog: > winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) A+

3 3

Re: WineD3D: Fog fixes, try 2
by Stefan Dösinger June 12, 2006

June 12, 2006

Hi, Apply this patch instead, the old patch had some sloppiness error(setting FOGSTART as FOGEND when restoring z-based fog). The problem is corrected in this patch. It also doesn't add a senseless space at the begin of the file and sets the fog to GL_FASTEST for vertex fog and GL_NICEST for table / pixel fog. ChangeLog: Stefan Dösinger(for CodeWeavers): Correct vertex fog for transformed vertices and correctly handle non-vertex, non-table fog

3 3

uxtheme efforts (wanted/needed ?)
by Paul Vriens June 12, 2006

June 12, 2006

Hi, I've sent 2 emails that are (for now) silently ignored: http://www.winehq.org/pipermail/wine-patches/2006-June/027253.html http://www.winehq.org/pipermail/wine-patches/2006-June/027350.html They both have to do with uxtheme and were meant as a starter for conformance tests and of course the fixes to it. I first wanted to start with input/return paramater and value testing before I touch any functional part (maybe not mutually exclusive). Was there anything wrong with the patches? How can I improve or what do I have to change? Cheers, Paul

2 1

Re: Broken FC5 packages - stay clear.
by Hans Leidekker June 12, 2006

June 12, 2006

On Monday 12 June 2006 12:04, Andreas Bierfert wrote: > > Good, but shouldn't zlib-devel be pulled in like that too then? > > Oh... don't even mention discussions on what should be in the minimal build > root and what shouldn't ;) I'm not, this isn't about the minimal build system. zlib-devel should be pulled in through whatever package depends on it. > It is :) gphoto2 is pulled in by sane? I believe... anyway last time I > checked (0.9.14) it was pulled in :) Right, but gphoto2 is a direct Wine dependency, so it would be better IMO to support it as such. It's also more flexible, i.e this way a user could choose to install gphoto2 but not sane support. -Hans

1 0

Re: Broken FC5 packages - stay clear.
by Hans Leidekker June 12, 2006

June 12, 2006

On Monday 12 June 2006 11:37, Andreas Bierfert wrote: > Why is there no BuildRequires for freetype? gphoto2? We also have > >These two are pulled in by other dependencies and thus don't need an explicit >listing (e.g. freetype by fontconfig-devel). Good, but shouldn't zlib-devel be pulled in like that too then? > zlib-devel on the other hand is not in the minimal buildroot :) Like Marcus said, freetype-devel is probably missing a dependency on zlib-devel. Wine doesn't directly depend on zlib-devel AFAICT. And it would be nice if you could add gphoto2 support. -Hans

1 0

Re: iphlpapi: forward Icmp* functions to icmp.dll
by Steven Edwards June 12, 2006

June 12, 2006

On 6/11/06, Simon Kissane <skissane(a)gmail.com> wrote: > In WinXP, these functions are implemented in iphlpapi.dll as well as > icmp.dll (Win2000). > They are already in Wine's icmp.dll, so forward the iphlpapi to icmp.dll Being its a small amount of code in icmp.dll I think we should just duplicate it. Our dependancies should really match windows and the last time I looked iphlpapi did not depend on icmp.dll in win2k. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

Re: DDraw: New ddraw lib
by Jesse Allen June 11, 2006

June 11, 2006

On 6/9/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > This is a resend of my ddraw rewrite, with some modifications Alexandre asked > for. I removed the whitespace fixes from the files which are taken from the > old ddraw code(light.c, material.c, clipper.c, viewport.c, executebuffer.c, > ddcomimpl.h, ddraw_thunks, surface_thunks). There are no functional changes > compared to the old patch, except a small change to forward the SYSTEMMEM and > WRITEONLY flags for vertexbuffers to WineD3D. > > The other files which have the same name as in the old code(main.c, > vertexbuffer.c): Those are rewrites(file deleted and re-created), so I won't > get a useful diff for them, no matter what I do. > > ChangeLog: > Stefan Dösinger: Use WineD3D for DDraw > I just want to state, the patch is very helpful when you can't use DGA. I just ran a test with Starcraft in multiplayer last night. Using OpenGL is noticibly faster than non-DGA. So I hope that it will get applied for 0.9.16. Jesse

2 6

Icmp* functions in iphlpapi.dll
by Simon Kissane June 11, 2006

June 11, 2006

Hi In Win2000, the ICMP functions exist in icmp.dll In WinXP, they are still there, but they have also been duplicated into iphlpapi.dll How would one go about adding them to iphlpapi? Does one just duplicate all the code in the second DLL, or is there a way to have some function implemented once & then exported by multiple DLLs? (I'm a Wine newbie...) Suppose one was to add code to iphlpapi's LibMain which did LoadLibrary & GetProcAddress to get the addresses of the functions in icmp.dll, and then the iphlpapi implementations just called the icmp.dll implementations? (I'm assuming doing a static import would result in some kind of name collission?) Cheers Simon

4 3

My new hero...
by Dan Kegel June 11, 2006

June 11, 2006

Qingdao is my new hero. He's really on a roll: http://www.winehq.org/pipermail/wine-cvs/2006-June/023427.html fixes a Visual Basic safearray redim bug, http://bugs.winehq.org/show_bug.cgi?id=5217 and he has two other fixes in unrelated areas this month. Mike, what was that you were saying about there not being any wine hackers who fixed problems all around the wine tree anymore? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1