July 2006 - Wine-Devel - list.winehq.org

Re: [AppDB] - move getMaintainersUserIds...() to version::getMaintainersUserIds()
by Jonathan Ernst July 7, 2006

July 7, 2006

Le vendredi 07 juillet 2006 à 01:21 -0400, Chris Morgan a écrit : > Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup > callers of this function. > > Chris > > > This one looks fine to me.

1 0

Re: Testing help needed: Pixel format whitelisting
by Jason Green July 7, 2006

July 7, 2006

On 7/1/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Hi, > The attached patch modifies IWineD3D::CheckDeviceFormat to whitelist supported > formats and return unsupported on unknown formats. Games which use funky > float formats or simmilar things should then see that the formats aren't > supported and (hopefully) fall back to less fancy formats. Before I send it > to wine-patches I'd like to know however how those games react to the change. > (Do they just fail with an error message or fall back to other formats). Here are my [limited] results: Prior to your patch, I'd get these errors from the startup of newer games (Oblivion, Civ4 at least): err:d3d:IWineD3DImpl_IsGLXFBConfigCompatibleWithRenderFmt unsupported format WINED3DFMT_A4R4G4B4 err:d3d:IWineD3DImpl_IsGLXFBConfigCompatibleWithRenderFmt unsupported format WINED3DFMT_A8 ... That list would go on for a ton of formats. After this patch, I still get it for the following formats: WINED3DFMT_X4R4G4B4 WINED3DFMT_A4R4G4B4 WINED3DFMT_A8 WINED3DFMT_A8R3G3B2 But, everything else remains the same in those apps. Half Life 2, on the other hand, won't launch the level after the patch (at least with pixel shaders enabled). I've attached the d3d_caps logs grepped for "CheckDeviceFormat" from before and after for comparison. The game launches, but it gets about half-way through the status bar loading the first level (Point Insertion), and then crashes.

1 1

Debugging _CheckNotSysLevel() errors?
by Dan Kegel July 7, 2006

July 7, 2006

http://bugs.winehq.org/show_bug.cgi?id=4063 is a crash on exit from a VB6 app due to a _CheckNotSysLevel() error. What typically causes these - are they a bug in the windows program? And is there a good reference from understanding the whole syslevel thing in gdi? Thanks!

3 3

Re: winecfg: Shift Graphics page up to fill the empty place.
by Ivan Gyurdiev July 7, 2006

July 7, 2006

Speaking of the graphics page... 1. Is there a reason why we allow the user to choose software vs hardware shaders? (i.e. why isn't this a developers' option, or no option at all) 2. Is there a reason why we allow the user to disable vertex and/or pixel shaders?

1 0

wine packages for Fedora Extras
by Andreas Bierfert July 7, 2006

July 7, 2006

Hi, some of you might have noticed that building 0.9.16 for Fedora Extras took me more time then the releases before. This was because of the discussions from a couple of weeks ago on this list. As a result I did spent some time on the mentioned issues and came across an easy solution: If you install wine form the Fedora Extras repository via 'yum install wine' nearly everything that would be in a monolithic package is going to be installed. The 'wine' package now is a meta-package containing requires for the various subpackages. So now 'normal' users who do a 'yum install wine' will get everything they need and experts who know what they are doing can go and install only the parts they want. I hope that this solution now leads to fewer 'false positives' on bug reports and for better user integration and satisfies some of the things you, the wine folks, brought up. Thanks for the input on this matter. I hope that this is only the first step towards a good relation ship between wine and the fedora packages for wine and that emails like the ones from a couple of weeks back won't happen again... So for the announcement: wine 0.9.16 for Fedora Extras 3,4,5,devel is build and should be pushed to the mirrors in a couple of hours. - Andreas -- Andreas Bierfert | http://awbsworld.de | GPG: C58CF1CB andreas.bierfert(a)lowlatency.de | http://lowlatency.de | signed/encrypted phone: +49 2402 102373 | cell: +49 173 5803043 | mail preferred

4 4

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.
by Ge van Geldorp July 7, 2006

July 7, 2006

> From: Ge van Geldorp [mailto:ge(a)gse.nl] > > Yes, this works fine, both with and without the change to > include/msvcrt/string.h. Sorry, I only tested dlls/msvcrt. When doing a full rebuild I get errors, will investigate and let you know. Ge.

1 0

[AppDB] Re: appdb/include incl.php
by Jonathan Ernst July 7, 2006

July 7, 2006

Le jeudi 06 juillet 2006 à 21:36 -0500, WineHQ a écrit : [...] > > +/** > + * rename $_REQUEST variables to preserve backwards compatibility > + * with bugzilla links and urls in emails and on google from before our > + * mass rename of GPC variables to use our coding standard prefixing > + * > + * NOTE: we may be able to remove these backwareds compatibility changes > + * in a few years, check in mid 2007 to see how many old > + * links are still poping up in google then > + */ > +if(isset($_REQUEST['versionId'])) > +{ > + $_REQUEST['iVersionId'] = $_REQUEST['versionId']; > + unset($_REQUEST['versionId']); > +} > +if(isset($_REQUEST['appId'])) > +{ > + $_REQUEST['iAppId'] = $_REQUEST['appId']; > + unset($_REQUEST['appId']); > +} This (+catId) is enough IMHO, looking at the results of google when you search for site:appdb.winehq.org, you'll see than only pages with catId, versionId and appId are indexed and I can't think of any reason that would make someone link to the AppDb with buglinkId or sub for example. > +if(isset($_REQUEST['buglinkId'])) > +{ > + $_REQUEST['iBuglinkId'] = $_REQUEST['buglinkId']; > + unset($_REQUEST['buglinkId']); > +} > +if(isset($_REQUEST['catId'])) > +{ > + $_REQUEST['iCatId'] = $_REQUEST['catId']; > + unset($_REQUEST['catId']); > +} > +if(isset($_REQUEST['sub'])) > +{ > + $_REQUEST['sSub'] = $_REQUEST['sub']; > + unset($_REQUEST['sub']); > +} > +if(isset($_REQUEST['topic'])) > +{ > + $_REQUEST['sTopic'] = $_REQUEST['topic']; > + unset($_REQUEST['topic']); > +} > +/* End backwards compatibility code */ > + > + > + > // create arrays > $sidebar_func_list = array(); > $help_list = array(); > > >

1 0

[AppDB] Re: appdb/include filter.php
by Jonathan Ernst July 7, 2006

July 7, 2006

Le jeudi 06 juillet 2006 à 23:49 -0500, WineHQ a écrit : > ChangeSet ID: 26258 > CVSROOT: /opt/cvs-commit > Module name: appdb > Changes by: wineowner(a)winehq.org 2006/07/06 23:49:32 > > Modified files: > include : filter.php > > Log message: > Tony Lambregts <tony.lambregts(a)gmail.com> > filter_gpc() should ignore any bugzilla parameters to avoid errors when these cookies are set > > Patch: http://cvs.winehq.org/patch.py?id=26258 > > Old revision New revision Changes Path > 1.3 1.4 +12 -1 appdb/include/filter.php > > Index: appdb/include/filter.php > diff -u -p appdb/include/filter.php:1.3 appdb/include/filter.php:1.4 > --- appdb/include/filter.php:1.3 7 Jul 2006 4:49:32 -0000 > +++ appdb/include/filter.php 7 Jul 2006 4:49:32 -0000 > @@ -42,8 +42,19 @@ function filter_gpc() > util_show_error_page_and_exit("Fatal error: ".$aKeys[$i]." should be an array."); > break; > default: > - if($aKeys[$i]!="whq_appdb" && $aKeys[$i]!="MAX_FILE_SIZE") // whq_appdb is the name of the session cookie > + if($aKeys[$i]!="whq_appdb" && // don't filter the appdb session cookie > + > + // or any bugzilla cookies > + $aKeys[$i]!="BUGLIST" && > + $aKeys[$i]!="DEFAULTFORMAT" && > + $aKeys[$i]!="Bugzilla_login" && > + $aKeys[$i]!="LASTORDER" && > + $aKeys[$i]!="Bugzilla_logincookie" && > + $aKeys[$i]!="DEFAULTFORMAT" && > + $aKeys[$i]!="MAX_FILE_SIZE") These cookies cannot be accessible in the real AppDB as bugzilla and AppDB are in separate hosts... I don't think this patch makes any sense in AppDB. A better fix would be to don't clear $_COOKIES in filter.php and have a unit test that checks that $_COOKIES is not used anywhere in the code (only in filter.php).

1 0

appdb url format change problem
by Dan Kegel July 6, 2006

July 6, 2006

All the links in Google to the appdb are of the form http://appdb.winehq.org/appview.php?appId=86 This no longer works. The new format appears to be http://appdb.winehq.org/appview.php?iAppId=86 Can we change the appdb code to also accept the old format? Thanks!

2 2

Troubles ith newest Ogre demo's
by Louis. Lenders July 6, 2006

July 6, 2006

Hi, the ogre demos from http://prdownloads.sourceforge.net/ogre/OgreDemos_1.2.0.msi?download are nice for testing wine's directx as you can run the samples in opengl and directx mode. The Newest samples fail however with an error that the application has made an attempt to load the C runtime library incorrectly. I then applied this patch: http://bugs.winehq.org/attachment.cgi?id=2500&action=view from Mike Mccormack, but it still failed. A trace showed this: 0009:Call kernel32.FindFirstFileW(7fc9bb14 L"C:\\Program Files\\OgreDemo\\Microsoft.VC80.CRT.manifest",7fc977ac) ret=78133da7 After a simple 'touch Microsoft.VC80.CRT.manifest' the demo's start just fine. Two simple questions: 1. Is there a reason that this patch has never been sent in? It also fixes another application with same problem. If not, could it be sent in. 2. Does wine need to provide this Microsoft.VC80.CRT.manifest file (as far as i understand this is an xml file) or should this file be provided by the application, and is this just Ogre's fault. thanks --------------------------------- All new Yahoo! Mail "The new Interface is stunning in its simplicity and ease of use." - PC Magazine

2 1