July 2006 - Wine-Devel - list.winehq.org

Re: Win64 patch 3/6 (resend)
by Dmitry Timoshkov July 25, 2006

July 25, 2006

"Ge van Geldorp" <ge(a)gse.nl> wrote: > --- a/include/wine/server_protocol.h > +++ b/include/wine/server_protocol.h > @@ -33,6 +33,9 @@ struct reply_header > struct request_max_size > { > int pad[16]; > +#ifdef _WIN64 > + int pad64[10]; > +#endif > }; Why is this required? Is that due to asserts in server/request.c, open_master_socket() ? Is changing 'int' to 'long' a better fix? Also probably the fix should go in server/protocol.def instead. -- Dmitry.

3 6

Repetitve fixme for each file accessed.
by Segin July 25, 2006

July 25, 2006

I keep getting stub fixme's for each and every single file that is access in Wine, especially via an installer. THe fixmes look like: fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\GeneXproTools 4\\SampleRuns\\XOR.gep") stub Does this have anything to do with the ClamAV integration I've heard you guys talking about? -- The real problem with C++ for kernel modules is: the language just sucks. -- Linus Torvalds

5 6

Re: oleaut32: Adding a NULL to a safearray is supposed to crash
by Robert Shearman July 25, 2006

July 25, 2006

Neil Skrypuch wrote: >diff --git a/dlls/oleaut32/safearray.c b/dlls/oleaut32/safearray.c >index 0eb92da..d3dd5e1 100644 >--- a/dlls/oleaut32/safearray.c >+++ b/dlls/oleaut32/safearray.c >@@ -843,12 +843,6 @@ HRESULT WINAPI SafeArrayPutElement(SAFEA > if (!psa || !rgIndices) > return E_INVALIDARG; > >- if (!pvData) >- { >- ERR("Invalid pvData would crash under Win32!\n"); >- return E_INVALIDARG; >- } >- > hRet = SafeArrayLock(psa); > > if (SUCCEEDED(hRet)) > > This patch looks good to me and it fixes a number of installers. -- Rob Shearman

2 1

Re: [oleaut32 2/3] Removes stub for varformat:VarWeekdayName
by Robert Shearman July 25, 2006

July 25, 2006

Benjamin Arai wrote: >diff --git a/dlls/oleaut32/oleaut32.spec b/dlls/oleaut32/oleaut32.spec >index ad110c7..9e1f1db 100644 >--- a/dlls/oleaut32/oleaut32.spec >+++ b/dlls/oleaut32/oleaut32.spec >@@ -124,7 +124,7 @@ > 125 stdcall VarBoolFromStr(wstr long long ptr) > 126 stdcall VarBoolFromDisp(ptr long ptr) > 127 stdcall VarFormatCurrency(ptr long long long long long ptr) >-128 stub VarWeekdayName # stdcall (long long long long ptr) >+128 stdcall VarWeekdayName(long long long long ptr) > 129 stdcall VarMonthName(long long long ptr) > 130 stdcall VarUI1FromI2(long ptr) > 131 stdcall VarUI1FromI4(long ptr) > > This should be included in the first patch. -- Rob Shearman

1 0

Re: [oleaut32 1/3] Implements function varformat:VarWeekdayName
by Robert Shearman July 25, 2006

July 25, 2006

Benjamin Arai wrote: > /********************************************************************** >+ * VarWeekdayName [OLEAUT32.128] >+ * >+ * Print the specified month as localized name. >+ * >+ * PARAMS >+ * iWeekday [I] day number of week 0 = sys default, 1 = Monday, etc >+ * fAbbrev [I] 0 - full name, !0 - abbreviated name >+ * iFirstDay [I] first day week, 0 = sys default, 1 = Monday, etc >+ * dwFlags [I] flag stuff. only VAR_CALENDAR_HIJRI possible. > > s/flag stuff/flags/ >+ >+ size = GetLocaleInfoW(LOCALE_USER_DEFAULT,localeValue, NULL, 0); >+ if (!size) { >+ FIXME("GetLocaleInfo 0x%lx failed.\n", localeValue); > > This should be an ERR instead. >+ return E_INVALIDARG; > > I don't think this is a good error code to return here. Even E_UNEXPECTED would be better, although perhaps HRESULT_FROM_WIN32(GetLastError()) would be the best. >+ } >+ str = HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*size); >+ if (!str) >+ return E_OUTOFMEMORY; >+ size = GetLocaleInfoW(LOCALE_USER_DEFAULT,localeValue, str, size); >+ if (!size) { >+ FIXME("GetLocaleInfo of 0x%lx failed in 2nd stage?!\n", localeValue); >+ HeapFree(GetProcessHeap(),0,str); >+ return E_INVALIDARG; > > Ditto for the above two comments; -- Rob Shearman

1 0

Re: usp10: Resend - Add funtionality for ScriptStringAnalyse
by Alexandre Julliard July 25, 2006

July 25, 2006

Jeff L <lats(a)yless4u.com.au> writes: > + psssa = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(Scriptstringanalysis)); > + *pssa = (Scriptstringanalysis*)psssa; Please try to find better names for your variables, don't name everything pssa or psssa or pssap etc. Also please use underscores to separate words in identifiers so that they are readable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Remove unused "ignore" field in widl structures
by Dan Hipschman July 25, 2006

July 25, 2006

On Mon, Jul 24, 2006 at 11:49:35AM -0700, Dan Hipschman wrote: > > This field is superfluous: > > [widl]$ find -name "*.[chly]" | xargs fgrep -n ignore > ./parser.y:1049: t->ignore = parse_only; > ./parser.y:1126: f->ignore = parse_only; > ./widltypes.h:208: int ignore, is_const, sign; > ./widltypes.h:238: int ignore, idx; > ./parser.tab.c:3841: t->ignore = parse_only; > ./parser.tab.c:3918: f->ignore = parse_only; This patch has been obsoleted by the patch, "widl [1/2]: Fix redefinition of types in output (take 2)," here: <http://www.winehq.org/pipermail/wine-patches/2006-July/028998.html>, which rather than removing the ignore field, puts it to use.

1 0

Cursor patches
by H. Verbeet July 24, 2006

July 24, 2006

Attached to this mail are a couple of patches that should fix some issues with mouse cursors. It would be nice if some people could have a look and see if the patches break anything. Patches 1-4 move cursors into the server, 5 adds support for Xcursor cursors, 6 & 7 are cleanups, 8 fixes loading of .cur cursors, 9 adds support for animated cursors and 10 adds support for 32bpp cursors.

4 9

Re: Possible bug in Wine or NDISWRAPPER
by gslink July 24, 2006

July 24, 2006

The most common problem with Ndiswrapper is that it requires more than a 4k stack. The result you are getting may be coming from a stack overflow caused by a combination of Wine and Ndiswrapper. Compile and install the native drivers for your lan card and see if that makes a difference. The signal strength icon will also start working.

3 5

Re: wcmd: strip quotes around executable and retry on error
by Thomas Kho July 24, 2006

July 24, 2006

On 7/6/06, Thomas Kho <tkho(a)ucla.edu> wrote: > wcmd: strip quotes around executable and retry on error > wcmd currently gives a 'File not found' error for the command: > `./wine wcmd /c "notepad test.txt"` because it only tries to execute the > program "notepad text.txt". In XP, cmd.exe starts notepad.exe with test.txt as > its argument upon not finding a "notepad text.txt" executable. Hi, Is there something wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2006-July/028367.html Thanks, Thomas Kho

3 4