August 2006 - Wine-Devel - list.winehq.org

Re: WineD3D: Properly initialize a variable
by H. Verbeet Aug. 27, 2006

Aug. 27, 2006

On 26/08/06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > In IWineD3DSurfaceImpl_SaveSnapshot tmpTexture might be uninitialized, which > might lead to accidentally binding the 0 texture. How does initialising it with 0 help then?

2 1

Wine CVS crashing in Direct3D code with XF86-DRI error
by Chris Rankin Aug. 26, 2006

Aug. 26, 2006

Hi, I am trying to run the World of Warcraft 1.11.0 (trial) client using Wine 0.9.20 and XOrg 7.1 with a Radeon 9200 video card. I don't have a guest access code yet, and so I have only reached Warcraft's login screen. However, this screen seems to be working fine... until I press the "Quit" button. When I do that, the client crashes. Here is the default console output: $ /opt/wine/World\ of\ Warcraft/WoW.exe libGL warning: 3D driver claims to not support visual 0x4b libGL warning: 3D driver claims to not support visual 0x4b Mesa: CPU vendor: GenuineIntel Mesa: CPU name: Intel(R) Xeon(TM) CPU 2.66GHz Mesa: MMX cpu detected. Mesa: SSE cpu detected. Mesa: Not testing OS support for SSE, leaving enabled. fixme:advapi:SetSecurityInfo stub fixme:powrprof:DllMain (0x7cad0000, 1, (nil)) not fully implemented fixme:ntdll:NtPowerInformation Unimplemented NtPowerInformation action: 11 fixme:powrprof:DllMain (0x7cad0000, 0, (nil)) not fully implemented fixme:win:EnumDisplayDevicesW ((null),0,0x34eeec,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f458,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f6f8,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f6f8,0x00000000), stub! fixme:d3d:IWineD3DImpl_GetDeviceCaps Caps support for directx9 is nonexistent at the moment! fixme:system:SystemParametersInfoW Unimplemented action: 113 (SPI_SETMOUSESPEED)fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x18ac48) : stub, simulating 253MB for now, returning 253MB left fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MIN not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MAX not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_CreateQuery (0x18ac48) Unhandled query type 9 fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MAX not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MIN not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_CreateQuery (0x18ac48) Unhandled query type 8 fixme:win:EnumDisplayDevicesW ((null),0,0x34f168,0x00000000), stub! fixme:system:SystemParametersInfoW Unimplemented action: 112 (SPI_GETMOUSESPEED)fixme:system:SystemParametersInfoW Unimplemented action: 113 (SPI_SETMOUSESPEED)fixme:sync:CreateIoCompletionPort (0xffffffff, (nil), 00000000, 00000000): stub.fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONNECT_TIMEOUT (5000): STUB fixme:wininet:InternetSetOptionW INTERNET_OPTION_SEND/RECEIVE_TIMEOUT not supported on protocol 4 fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONTEXT_VALUE; STUB fixme:imm:ImmAssociateContextEx (0x10024, (nil), 16): stub X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 145 (XFree86-DRI) Minor opcode of failed request: 9 () Value in failed request: 0x2c00058 Serial number of failed request: 485 Current serial number in output stream: 485 This crash is more serious than it looks because WoW only updates its configuration file when it exits, and (of course) this crash happens before it can do that. I have some WINEDEBUG=d3d output, but it's 300K compressed with bzip2 and so I cannot post it here. Can anyone suggest any way I might debug this, please? I *think* that the operation is XF86GetDrawableInfo(), but am not sure. And since this crash only happens on exit, could Wine be requesting "drawable info" for a resource that it has deleted? Thanks for any help, Cheers, Chris ___________________________________________________________ Now you can scan emails quickly with a reading pane. Get the new Yahoo! Mail. http://uk.docs.yahoo.com/nowyoucan.html

2 1

Re: Add support for tooltips for system tray icons
by Oleg Krylov Aug. 26, 2006

Aug. 26, 2006

Hello, On 8/25/06, James Liggett <jrliggett(a)cox.net> wrote: > Add support for tooltips for system tray icons. > > This patch partially based on the original systray implementation by Kai Morich <kai.morich(a)bigfoot.de>. I've been working on the simmilar patch and I want make several comments on the patch > + > + /* create icon tooltip */ > + icon->tooltip = CreateWindowEx(WS_EX_TOPMOST, TOOLTIPS_CLASS, NULL, > + WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP, > + CW_USEDEFAULT, CW_USEDEFAULT, > + CW_USEDEFAULT, CW_USEDEFAULT, > + icon->window, NULL, NULL, NULL); > Why the TTS_NOPREFIX flag is needed? It doesn't seem to be used on windows. Next, we need to set tooltip max width, primarily to enable multiline tooltips, as several applications relay on this. The code can be, just after tooltip creation: SendMessageW (icon->tooltip, TTM_SETMAXTIPWIDTH, 0, 400); On windows width value seem to be dependend on system DPI, but I haven't found the exact formula yet. 400 is value at the default 96 dpi, so it may be a good starting point. Then my idea is to create tool just after tooltip creation, and then in modify icon just change tooltip text if requested. Not sure if it is a better idea, but it fits better into the existing code. Something like this: after tooltip creation creation: TTTOOLINFOW ti; ZeroMemory (&ti, sizeof(TTTOOLINFOW)); ti.cbSize = sizeof(TTTOOLINFOW); ti.uFlags = TTF_SUBCLASS; ti.hwnd = icon->window; ti.hinst = 0; ti.uId = 0; ti.lpszText = NULL; GetClientRect (icon->window, &ti.rect); SendMessageW (icon->tooltip, TTM_ADDTOOLW, 0, (LPARAM)&ti); and in modify icon: if (nid->uFlags & NIF_TIP) { TTTOOLINFOW ti; ZeroMemory (&ti, sizeof(TTTOOLINFOW)); ti.cbSize = sizeof(TTTOOLINFOW); ti.hwnd = icon->window; ti.hinst = 0; ti.uId = 0; ti.lpszText = nid->szTip; SendMessageW (icon->tooltip, TTM_UPDATETIPTEXTW, 0, (LPARAM)&ti); }

2 3

Re: WineD3D: Unbind unused textures
by Stefan Dösinger Aug. 26, 2006

Aug. 26, 2006

Am Samstag 26 August 2006 21:56 schrieb Stefan Dösinger: > Apparently disabling texturing alone doesn't work, so bind texture 0 to all > unused texture units. This fixes the bad texture / reflections on many > objects in half-life 2, dxlevel 80, and makes the flashlight work more > reliably. The flashlight still doesn't work on bump mapped objects. Do not apply this patch, it doesn't fix the real issue.

1 0

Re: ole32: Add support for main-threaded apartments
by Alexandre Julliard Aug. 26, 2006

Aug. 26, 2006

Robert Shearman <rob(a)codeweavers.com> writes: > A main-threaded apartment is the first single-threaded apartment in > the process. It was designed to be used for legacy applications that > don't want to think about threading at all, even if they are always > called from the same context, as is the case for regular STAs. That one crashes the tests: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so compobj.c && touch compobj.ok wine: Unhandled page fault on read access to 0x00000017 at address 0x7bc27699 (thread 000e), starting debugger... WineDbg starting on pid 0xd Unhandled exception: page fault on read access to 0x00000017 in 32-bit code (0x7bc27699). fixme:dbghelp:elf_load_debug_info_from_map Alpha-support for Dwarf2 information for ntdll<elf> Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7bc27699 ESP:0033f970 EBP:0033fa28 EFLAGS:00010286( - 00 -RISP1) EAX:ffffffff EBX:7bc76420 ECX:00000000 EDX:0015e284 ESI:0033f9f8 EDI:0015e294 Stack dump: 0x0033f970: 00000040 0033fa5c 0000002e 0033f9cc 0x0033f980: 00000040 0033fa6c 0000002c 000004b8 0x0033f990: 00000002 7b8a9280 7bc53b4b 00000000 0x0033f9a0: 7bc7dca0 0033f9fc 7bc53b4b 6056b6dc 0x0033f9b0: 0033f9cc 0033fa0c 0033fa48 60526ff8 0x0033f9c0: 0033f9cc 03c00001 00000000 00000000 fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000119 Backtrace: =>1 0x7bc27699 RtlpWaitForCriticalSection+0xb9(crit=0x15e284) [/home/julliard/wine/wine/dlls/ntdll/critsection.c:398] in ntdll (0x7bc27699) 2 0x7bc27c37 RtlEnterCriticalSection+0x67(crit=0x15e284) [/home/julliard/wine/wine/dlls/ntdll/critsection.c:508] in ntdll (0x7bc27c37) 3 0x60420ee5 start_apartment_remote_unknown+0x45 [/home/julliard/wine/wine/dlls/ole32/stubmanager.c:749] in ole32 (0x60420ee5) 4 0x6040d6a1 RPC_StartRemoting+0x31(apt=0x15e260) [/home/julliard/wine/wine/dlls/ole32/rpc.c:706] in ole32 (0x6040d6a1) 5 0x603fd2cb StdMarshalImpl_MarshalInterface+0xab(iface=0x15e388, pStm=0x15e360, riid=0x603124f0, pv=0x6031a48c, dwDestContext=0x3, pvDestContext=0x0, mshlflags=0x0) [/home/julliard/wine/wine/dlls/ole32/marshal.c:1081] in ole32 (0x603fd2cb) 6 0x603fef58 CoMarshalInterface+0x528(pStream=0x15e360, riid=0x603124f0, pUnk=0x6031a48c, dwDestContext=0x3, pvDestContext=0x0, mshlFlags=0x0) [/home/julliard/wine/wine/dlls/ole32/marshal.c:1623] in ole32 (0x603fef58) 7 0x602ff177 func_compobj+0xcb7 [/home/julliard/wine/wine/dlls/ole32/tests/compobj.c:411] in ole32_test (0x602ff177) 8 0x603111d0 run_test+0x120(name=0x11039e) [/home/julliard/wine/wine/dlls/ole32/tests/../../../include/wine/test.h:365] in ole32_test (0x603111d0) 9 0x603117d1 main+0x141(argv=0x6031189b) [/home/julliard/wine/wine/dlls/ole32/tests/../../../include/wine/test.h:412] in ole32_test (0x603117d1) 10 0x6031189b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ole32_test (0x6031189b) 11 0x7b86f84b start_process+0xeb(arg=0x0) [/home/julliard/wine/wine/dlls/kernel/process.c:822] in kernel32 (0x7b86f84b) 12 0x6001f777 wine_switch_to_stack+0x17 in libwine.so.1 (0x6001f777) 0x7bc27699 RtlpWaitForCriticalSection+0xb9 [/home/julliard/wine/wine/dlls/ntdll/critsection.c:398] in ntdll: movl 0x18(%eax),%eax 398 if (crit->DebugInfo) name = (char *)crit->DebugInfo->Spare[0]; -- Alexandre Julliard julliard(a)winehq.org

1 1

WineDBG / dbghelp symbol problem
by Roderick Colenbrander Aug. 26, 2006

Aug. 26, 2006

Hi Eric, One of my wine development machines is running a 64bit version of Debian. In case of debian all 32bit libraries and programs are installed in a 32bit 'chroot' /emul/ia32-linux. Wine is installed there aswell and further the 32bit libs from the chroot environment are in the library path. Wine itself works fine but when some program crashes winedbg doesn't produce very usefull information. For instance a 'bt' using 'winedbg notepad' should give something like: 0x603984f7 start_process+0xe7 [/usr/src/wine/dlls/kernel/process.c:822] in kernel32: movl %edi,0x0(%esp) 822 ExitProcess( entry( peb ) ); On this system I get something like: Wine-dbg>bt Backtrace: =>1 0x603984f7 (0x603984f7) 2 0x60022657 (0x60022657) Further I notice lots of lines like this: fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\kernel32.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\ntdll.dll I think that the cause of the problem lies in here as I don't see these lines on a standard 32bit system. Further if I install wine into a standard /usr/local prefix, winedbg works ok aswell. It shows the correct information and the SymLoadModule lines don't fail either.Most likely there's some path issue in dbghelp. I have tried to look at the code but it is a big maze to me. Perhaps you have an idea where the problem can be. Regards, Roderick Colenbrander -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

3 4

Re: Alexandre Julliard : crypt32/tests: Avoid sizeof in traces.
by Dimi Paun Aug. 26, 2006

Aug. 26, 2006

On Fri, August 25, 2006 2:34 pm, Alexandre Julliard wrote: > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Aug 25 18:37:38 2006 +0200 > > crypt32/tests: Avoid sizeof in traces. This is non-obvious -- why is that? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

4 5

Bugzilla statistics: whole lotta fixing going on!
by Dan Kegel Aug. 26, 2006

Aug. 26, 2006

3 3

Re: Add support for tooltips for system tray icons
by Frank Richter Aug. 26, 2006

Aug. 26, 2006

On 25.08.2006 07:44, James Liggett wrote: > + icon->tooltip = CreateWindowEx(WS_EX_TOPMOST, TOOLTIPS_CLASS, NULL, > + WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP, > + CW_USEDEFAULT, CW_USEDEFAULT, > + CW_USEDEFAULT, CW_USEDEFAULT, > + icon->window, NULL, NULL, NULL); Hm, wouldn't it be more economic to try to use one tooltip for all icons? -f.r.

2 3

Wine CVS - r1.88 of dlls/opengl32/wgl.c
by Chris Rankin Aug. 25, 2006

Aug. 25, 2006

Hi, I have just updated my wine installation from CVS, and my OpenGL game is now crashing: X Error of failed request: GLXBadPixmap Major opcode of failed request: 129 (GLX) Minor opcode of failed request: 17 (X_GLXVendorPrivateWithReply) Serial number of failed request: 441 Current serial number in output stream: 441 Reverting wgl.c to r1.87 fixes the problem. I have a Radeon 9250 card with XOrg 7.1 and DRI enabled, but am not using the proprietary ATI driver. Cheers, Chris ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

2 4

FEAR Combat
by Jeremy Newman Aug. 25, 2006

Aug. 25, 2006

Tried FEAR Combat on Wine. Looks like it needs a d3dx9_27.dll which we don't provide. Anyone else have any luck with this one? I'm not sure what the status is of all the required dx 9.0c dlls are.

9 15

Write-strings warning: the endgame
by Andrew Talbot Aug. 25, 2006

Aug. 25, 2006

Currently, there are just eight write-strings violations remaining in the codebase: six in mshtml/nsembed.c (lines 271, 353, 356, 367, 432 and 1237), one in mshtml/nsservice.c (line 454) and one in widl/parser.c (line 848). So I would advocate that the -Wwrite-strings switch could now be turned on. I have just submitted two speculative patches to attempt to fix these remaining warnings, but, if they are wrong, I would be grateful if those of you with mshtml expertise or yacc expertise should kindly step in and finish the respective job properly. Thanks, -- Andy.

3 3

Re: Write-strings warning fix
by Dan Hipschman Aug. 25, 2006

Aug. 25, 2006

On Fri, Aug 25, 2006 at 11:08:03AM +0100, Andrew Talbot wrote: > What confused me - especially with my ignorance of yacc - is that I couldn't > find a corresponding xmalloc() that assigns the char * variables that the > above free() frees. make_var() gains storage for a var_t type, but the > free() in get_type() releases the storage of a char *. I couldn't quite > follow what was going on, there. Is it because the string is the first > element in the structure, so the pointer to the string also points to the > start of the var_t type? The strings are allocated in the lexer (parser.l): yylval.str = xstrdup(kw); The patch that was actually committed (using xstrdup) is most consistent.

2 1

Re: getwinegit.sh v0.4 released!
by Michael [Plouj] Ploujnikov Aug. 25, 2006

Aug. 25, 2006

In light of the recent discussion about moving to GIT I would like to let send this email to everyone on wine lists. Since Christian's last update to his getwinegit script I have tried to improve it to be more general and work in my special setup. I sent him this same email but I haven't heard a reply yet. ---------- Forwarded message ---------- From: Michael [Plouj] Ploujnikov <ploujj(a)gmail.com> Date: Jul 26, 2006 10:34 AM Subject: Re: getwinegit.sh v0.4 released! To: Christian Lachner <gladiac.lists(a)gmail.com> I have made some fixes to the script and an example config file: - Removed the check for root user. The script shouldn't require root access, not to compile wine, not even to install it. I think the best way is to just check that the user running the script has write permissions to install, log, and git checkout folders. - changed the CONFIGURE variable to be an array to allow for quoted words passed to ./configure. From my configuration that would be something like this: ./configure --x-libraries=/emul/linux/x86/usr/lib/ LDFLAGS="-L/emul/linux/x86/usr/lib -L/emul/linux/x86/lib" (because I need to compile 32bit wine on a 64bit machine with emulation libraries) - fixed one typo that I noticed - added a definition of MAKE to my config file. Without it DEPEND=$MAKE" depend"; and others don't execute make. The same should also be added to the nocolors.config file: MAKE="make"; Of course, you can ignore the path changes in the config file, unless you want an example of what a non-root user would do. The changes are attached as unified diffs. For some reason google made me reply to you rather than wine-devel and I guess it's up to you to post the changes there anyways ... after a thorough review! Enjoy.

1 0

Re: LOSTWAGES: Replace references to CVS with Git
by Robert Shearman Aug. 25, 2006

Aug. 25, 2006

Mike McCormack wrote: >Index: templates/en/development.template >=================================================================== >RCS file: /home/wine/lostwages/templates/en/development.template,v >retrieving revision 1.6 >diff -u -p -r1.6 development.template >--- templates/en/development.template 28 Oct 2005 16:05:10 -0000 1.6 >+++ templates/en/development.template 18 Aug 2006 01:02:06 -0000 >@@ -6,7 +6,7 @@ > WineHQ hosts a number of services aiding the Wine development process. > > <ul> >- <li><a href="{$root}/site/cvs">Wine CVS tree</a></li> >+ <li><a href="{$root}/site/git">Wine Git tree</a></li> > <li><a href="{$root}/site/contributing">Contributing to Wine</a></li> > <li><a href="http://bugs.winehq.org/">Bug tracking</a></li> > <li><a href="http://appdb.winehq.org/">Application Database</a></li> > I think we should leave the reference to the CVS tree page (but still add a link to the Git tree). Some people find it easier to work with CVS than Git. -- Rob Shearman

12 22

Re: LOSTWAGES: Fix the UI status page html and links
by Dimi Paun Aug. 25, 2006

Aug. 25, 2006

On Fri, 2006-08-25 at 19:30 +0900, Mike McCormack wrote: > > Maybe we should move this to the Wiki too? Maybe. But it changes seldom enough, and I think it will be ugly to get all the formatting right in the Wiki format. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: msi: Store properties in a hash table, not the database.
by Dan Kegel Aug. 25, 2006

Aug. 25, 2006

On 8/24/06, Mike McCormack <mike(a)codeweavers.com> wrote: > Use string insensitive comparisons for property names. > --- > dlls/msi/package.c | 253 package.c: In function 'MSI_CreatePackage': package.c:426: error: 'PROPERTY_HASH_SIZE' undeclared (first use in this function) package.c:427: error: 'struct tagMSIPACKAGE' has no member named 'props' Did you forget to include your change to msipriv.h?

1 0

Finding a regression
by Doug Laidlaw Aug. 25, 2006

Aug. 25, 2006

I may be on the wrong list. A program I use has shown a backward step in graphics between Wine 0.9.15 and 0.9.16, and I am trying to find the change responsible. I currently have Wine set as at 2006-06-21 16:21:20 CDT, it is identifying as 0.9.16, and the fault is present. The Web site says to get the CVS history from the mailing list archives, but the archive is only up to mid-2005. What is the best way to step backwards? Doug. -- When we want to read of the deeds that are done for love, whither do we turn? To the murder column. - G.B. Shaw.

4 9

Re: msi 5: Add initial implementation of the DirectoryListUp event
by Mike McCormack Aug. 25, 2006

Aug. 25, 2006

James Hawkins wrote: > +UINT msi_dialog_directorylist_up( msi_dialog *dialog ) > +{ > + msi_control *control; > + BOOL indirect; > + LPWSTR prop, path, ptr; > + > + control = msi_dialog_find_control_by_class( dialog, WC_LISTVIEWW ); > + indirect = control->attributes & msidbControlAttributesIndirect; > + prop = msi_dialog_dup_property( dialog, control->property, indirect ); I don't think we should be looking up controls by their Window class. Either look up "DirectoryList" by it's MSI control type, or have the DirectoryList code subscribe to the event somehow. > +UINT msi_dialog_directorylist_up( msi_dialog *dialog ); Please put declarations for functions in a different file in msipriv.h Mike

1 0

Re: msi 4: Add initial implementation of the DirectoryCombo control
by Mike McCormack Aug. 25, 2006

Aug. 25, 2006

James Hawkins wrote: > + indirect = msi_dup_property( dialog->package, control->property ); > + prop = indirect; > + } > + > + val = msi_dup_property( dialog->package, prop ); > + lstrcpynW( path, val, MAX_PATH ); > + > + PathStripPathW( path ); > + PathRemoveBackslashW( path ); Calling msi_dup_property allocates new strings, so you need to remember to free those strings too. Since it's allocated, why not use PathStripPathW and PathRemoveBackslashW on the allocated string, rather than trying to copy it first? Mike

1 0

Re: msi: Inform the user with an error message when the MSI file path is invalid
by Alexandre Julliard Aug. 24, 2006

Aug. 24, 2006

"James Hawkins" <truiken(a)gmail.com> writes: > This fixes bug 4404 and matches native behavior. As an aside, is it a > legal problem if our message matches native exactly? I personally > can't see why it would be a problem (interface vs. implementation, > this is User Interface), but I can always change it if it's a problem. It's better not to use the exact same messages, since it's not required for compatibility. Particularly in this case, since you know that the error is that the file does not exist, there's no reason to tell people to "contact the application vendor"... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: Fix strings with lengths that are exact multiples of 2^16.
by Alexandre Julliard Aug. 24, 2006

Aug. 24, 2006

Mike McCormack <mike(a)codeweavers.com> writes: > if ( datasize != offset ) > - ERR("string table load failed! (%08x != %08lx)\n", datasize, offset ); > + { > + ERR("string table load failed! (%08x != %08lx), please report\n", datasize, offset ); > + ExitProcess(1); > + } Surely it could fail more nicely than by killing the whole process... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: remove limit on number of handles (take 3)
by Alexandre Julliard Aug. 24, 2006

Aug. 24, 2006

"Dan Kegel" <dank(a)kegel.com> writes: > @@ -66,18 +67,29 @@ MSIHANDLE alloc_msihandle( MSIOBJECTHDR > > EnterCriticalSection( &MSI_handle_cs ); > > + if (msihandletable == NULL) > + { > + msihandletable_size = 256; > + msihandletable = msi_alloc_zero( > + msihandletable_size*sizeof(msi_handle_info)); > + } > + > /* find a slot */ > - for(i=0; i<MSIMAXHANDLES; i++) > + for(i=0; i<msihandletable_size; i++) > if( !msihandletable[i].obj ) > break; > - if( (i>=MSIMAXHANDLES) || msihandletable[i].obj ) > - goto out; > + if( i==msihandletable_size ) > + { > + msihandletable_size *= 2; > + msihandletable = msi_realloc_zero(msihandletable, > + msihandletable_size*sizeof(msi_handle_info)); > + } You should check for allocation failures and fail gracefully instead of crashing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: replace fchmod() with chmod()
by Alexandre Julliard Aug. 24, 2006

Aug. 24, 2006

"Steven Edwards" <winehacker(a)gmail.com> writes: > Detlef sent this in a while back and I think it slipped through the que. > > Changelog: > Detlef Riekenberg wine.dev at web.de > - tools/winedump: replace fchmod() with chmod() The right way to make that code portable is to get rid of the shell script. -- Alexandre Julliard julliard(a)winehq.org

1 0

Regression with 'explorer' starting automatically by 'Process Explorer'
by Paul Vriens Aug. 24, 2006

Aug. 24, 2006

Hi, normally when I start Process Explorer it automatically launches the 'explorer' process. With the latest git 'explorer' crashes. Regression testing showed that this is most likely due to the XEmbed patch: http://source.winehq.org/git/?p=wine.git;a=commit;h=60a97505a63e5102f239d0d… Debug output: 000b:trace:x11drv:X11DRV_CreateBitmap (0x28c) 16x16 24 bpp 000b:trace:x11drv:X11DRV_GetBitmapBits (bmp=0x28c, buffer=0x16c1a4, count=0x300) 0009:trace:x11drv:X11DRV_SetWindowPos hwnd 0x1003a, after (nil), swp 0,0 391x17 flags 00000014 0009:trace:x11drv:SWP_DoWinPosChanging hwnd 0x1003a, after (nil), swp 0,0 391x17 flags 00001814 0009:trace:x11drv:SWP_DoWinPosChanging current (0,0)-(391,17) style 500000c2 new (0,0)-(391,17) 0009:trace:x11drv:X11DRV_set_window_pos win 0x1003a window (0,0)-(391,17) client (0,0)-(391,17) style 500000c2 0009:trace:x11drv:X11DRV_SetWindowPos status flags = 1807 000b:trace:x11drv:X11DRV_CreateBitmap (0x298) 15x15 24 bpp 000b:trace:x11drv:X11DRV_GetBitmapBits (bmp=0x298, buffer=0x16c122, count=0x2b2) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (0,0)-(26,45) style 04c00000 000b:trace:x11drv:systray_dock_window Docking tray icon 0x10052 000b:trace:x11drv:X11DRV_SetWindowPos hwnd 0x10052, after (nil), swp 1025,769 0x0 flags 00000005 000b:trace:x11drv:SWP_DoWinPosChanging hwnd 0x10052, after (nil), swp 1025,769 0x0 flags 00001805 000b:trace:x11drv:SWP_DoWinPosChanging current (0,0)-(26,45) style 04c00000 new (1025,769)-(1051,814) 000b:trace:x11drv:SWP_DoOwnedPopups (0x10052) hInsertAfter = (nil) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (1025,769)-(1051,814) client (1025,769)-(1051,814) style 04c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 1028,791,20x20 after 3 changes=f 000b:trace:x11drv:X11DRV_SetWindowPos status flags = 0801 000b:trace:x11drv:X11DRV_CreateBitmap (0x2a8) 32x32 1 bpp 000b:trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2a8, bits=0x15b760, count=0x80) 000b:trace:x11drv:X11DRV_CreateBitmap (0x2a4) 32x32 24 bpp 000b:trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2a4, bits=0x16c3e0, count=0xc00) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (0,0)-(26,45) style 04c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 3,22,20x20 after 3 changes=3 000b:trace:x11drv:X11DRV_CreateWindow hwnd 0x10052 cs 0,0 26x45 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (3,22)-(23,42) style 04c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 3,22,20x20 after 3 changes=40 000b:trace:x11drv:X11DRV_CreateWindow win 0x10052 window 0,0,26,45 client 3,22,23,42 whole 3,22,23,42 X client 0,0,20,20 xwin 3e00002 000b:trace:x11drv:X11DRV_ShowWindow hwnd=0x10052, cmd=8, wasVisible 0 000b:trace:x11drv:X11DRV_SetWindowPos hwnd 0x10052, after (nil), swp 0,0 0x0 flags 00000053 000b:trace:x11drv:SWP_DoWinPosChanging hwnd 0x10052, after (nil), swp 0,0 0x0 flags 00001853 000b:trace:x11drv:SWP_DoWinPosChanging current (0,0)-(26,45) style 04c00000 new (0,0)-(26,45) 000b:trace:x11drv:SWP_DoOwnedPopups (0x10052) hInsertAfter = (nil) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (3,22)-(23,42) style 14c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 3,22,20x20 after 3 changes=40 000b:trace:x11drv:X11DRV_set_window_pos mapping win 0x10052 000b:trace:x11drv:systray_dock_window Docking tray icon 0x10052 000b:trace:x11drv:X11DRV_SetWindowPos hwnd 0x10052, after (nil), swp 1025,769 0x0 flags 00000005 000b:err:syslevel:_CheckNotSysLevel Holding lock 0x603ef040 level 2 000b:trace:seh:raise_exception code=80000003 flags=0 addr=0x77a5fc40 000b:trace:seh:raise_exception eax=00000044 ebx=77a83f64 ecx=602daa80 edx=00000044 esi=7ffdc044 edi=00000000 000b:trace:seh:raise_exception ebp=0034e2b8 esp=0034e290 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00000206 000b:trace:seh:call_stack_handlers calling handler at 0x77a05ec8 code=80000003 flags=0 wine: Unhandled exception 0x80000003 at address 0x77a5fc40 (thread 000b), starting debugger... 000b:trace:seh:start_debugger Starting debugger "winedbg --auto 10 64" WineDbg starting on pid 0xa 000b:trace:seh:call_stack_handlers handler at 0x77a05ec8 returned 1 000d:fixme:ntdll:NtDeviceIoControlFile Unsupported ioctl 8335000c (device=8335 access=0 func=3 method=0) 0009:trace:seh:raise_exception code=c000013a flags=0 addr=0x7bfff400 0009:trace:seh:raise_exception eax=00000003 ebx=00000007 ecx=0033e2ec edx=00000008 esi=0033e2ec edi=7ffdc000 0009:trace:seh:raise_exception ebp=0033e300 esp=0033e2b8 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00000293 0009:trace:seh:call_stack_handlers calling handler at 0x441d00 code=c000013a flags=0 [paul(a)penguin latest]$ _CheckNotSysLevel () at /wine/wine-git/dlls/kernel/syslevel.c:178 0x77a5fc41 _CheckNotSysLevel+0x41 [/wine/wine-git/dlls/kernel/syslevel.c:178] in kernel32: addl $36,%esp 178 } Modules: Module Address Debug info Name (46 modules) ELF 101000-16f000 Deferred libfreetype.so.6 ELF 175000-190000 Deferred ld-linux.so.2 ELF 192000-1b7000 Deferred libm.so.6 ELF 1b9000-1bd000 Deferred libdl.so.2 ELF 1bf000-1d2000 Deferred libz.so.1 ELF 1d4000-1da000 Deferred libxdmcp.so.6 ELF 1dc000-1df000 Deferred libxau.so.6 ELF 222000-232000 Deferred libxext.so.6 ELF 23a000-25b000 Deferred libexpat.so.0 ELF 25d000-266000 Deferred libxrender.so.1 ELF 2c2000-2c4000 Deferred libnvidia-tls.so.1 ELF 2cb000-2e1000 Deferred libnsl.so.1 ELF 4e8000-4ec000 Deferred libcap.so.1 ELF 4ee000-561000 Deferred libdbus-1.so.2 ELF 74e000-752000 Deferred libxrandr.so.2 ELF 7bd000-7c2000 Deferred libxxf86vm.so.1 ELF 7da000-7df000 Deferred libxfixes.so.3 ELF 927000-931000 Deferred libxcursor.so.1 ELF adf000-c12000 Deferred libc.so.6 ELF c9b000-ca5000 Deferred libhal.so.1 ELF ca8000-da5000 Deferred libx11.so.6 ELF da7000-dbb000 Deferred libpthread.so.0 ELF dbd000-dfa000 Deferred libfontconfig.so.1 ELF 41b4000-49cb000 Deferred libglcore.so.1 ELF 49cd000-4a5c000 Deferred libgl.so.1 ELF 78d5000-78ef000 Deferred libice.so.6 ELF 7915000-791e000 Deferred libsm.so.6 ELF 60000000-60111000 Deferred libwine.so.1 ELF 6025c000-602dc000 Deferred ntdll<elf> \-PE 60270000-602dc000 \ ntdll ELF 602dc000-602f3000 Deferred explorer<elf> \-PE 602e0000-602f3000 \ explorer ELF 602f3000-60429000 Deferred user32<elf> \-PE 60310000-60429000 \ user32 ELF 60429000-604b9000 Deferred gdi32<elf> \-PE 60440000-604b9000 \ gdi32 ELF 604b9000-604ff000 Deferred advapi32<elf> \-PE 604c0000-604ff000 \ advapi32 ELF 6055d000-605e0000 Deferred winex11<elf> \-PE 60570000-605e0000 \ winex11 ELF 60fcc000-60fe8000 Deferred imm32<elf> \-PE 60fd0000-60fe8000 \ imm32 ELF 778e0000-778eb000 Deferred libnss_files.so.2 ELF 779da000-77adf000 Stabs kernel32<elf> \-PE 779f0000-77adf000 \ kernel32 ELF 7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 0000000a (D) c:\windows\system32\explorer.exe 0000000c 0 0000000b 0 <== Any idea where to start looking? Cheers, Paul. P.S. I write 'most likely due' as I've seen several cases of different results when bisecting.

2 5

Default background erase code does not respect WM_CLIPSIBLINGS
by Troy Rollo Aug. 24, 2006

Aug. 24, 2006

The attached program demonstrates a bug in the default background-erase code in send_erase (dlls/user/painting.c). The code includes a top level window with WS_CLIPCHILDREN | WS_CLIPSIBLINGS, and two overlapping child windows - one that draws nothing and has a white background (first child), and the other being a standard drop-down list (second child). When the window is first created the second child is completely visible, having drawn over the first child. Click anywhere in the grey area of the window and the second child disappears. Click again and only half of it reappears (you may see the other half reappear briefly but be overwritten by the first child). The second child is correctly redrawn if you cover the window and expose it again. Under Windows, the same code results in the second window (being at the top of the Z order) appearing intact on the second click. This looks like one of those cases where there are probably a lot of wrong ways to fix it and only one right way, and so needs to be fixed by somebody familiar with the code involved. -- Troy Rollo - wine(a)troy.rollo.name

1 0

Re: msi: Add an initial implementation of the PathEdit control
by Mike McCormack Aug. 24, 2006

Aug. 24, 2006

James Hawkins wrote: > @@ -65,6 +65,7 @@ struct msi_control_tag > float progress_current; > float progress_max; > WCHAR name[1]; > + DWORD attributes; You shouldn't add members after name[1], as the string in name[] will overwrite them. > + sz = 0x20; > + buf = msi_alloc( sz*sizeof(WCHAR) ); > + while( buf ) > + { > + r = GetWindowTextW( control->hwnd, buf, sz ); > + if( r < (sz-1) ) > + break; > + sz *= 2; > + buf = msi_realloc( buf, sz*sizeof(WCHAR) ); > + } There's already code to get the window text in msi_dialog_edit_handler(), so please factor it out into a new function rather than copying it. (maybe LPWSTR msi_get_window_text(HWND)?) > + LPCWSTR prop; > + prop = (LPWSTR)MSI_RecordGetString( rec, 9 ); You shouldn't need a cast here... Mike

2 1

Re: msi: Add Set/GetLastError to the property tests
by Alexandre Julliard Aug. 23, 2006

Aug. 23, 2006

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -2087,33 +2087,44 @@ static void test_getproperty(void) > ok( hPackage != 0, " Failed to create package\n"); > > /* set the property */ > + SetLastError(0xdeadbeef); > r = MsiSetProperty(hPackage, "Name", "Value"); > ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); > + ok( GetLastError() == 0xdeadbeef, "Expected 0xdeadbeef, got %ld\n", GetLastError()); In general, testing that last error isn't set on success is not useful, unless you really have an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: comdlg: Send missing CDN_FOLDERCHANGE (resend 2)
by Alexandre Julliard Aug. 23, 2006

Aug. 23, 2006

"Renu Rajput" <renu.rajput(a)gmail.com> writes: > diff -urN OldDir/dlls/comdlg32/filedlg.c NewDir/dlls/comdlg32/filedlg.c > --- OldDir/dlls/comdlg32/filedlg.c 2006-08-10 18:45:12.000000000 +0530 > +++ NewDir/dlls/comdlg32/filedlg.c 2006-08-11 16:09:32.000000000 +0530 > @@ -2011,7 +2011,10 @@ > IPersistFolder2_Release(ppf2); > if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent, fodInfos->ShellInfos.pidlAbsCurrent)) > { > - IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, > pidlCurrent, SBSP_ABSOLUTE); > + if (SUCCEEDED(IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, > pidlCurrent, SBSP_ABSOLUTE))) > + { > + SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); > + } > } > else if( nOpenAction == ONOPEN_SEARCH ) There's no point in sending a (corrupted) inline version of the patch plus another one as attachment, all it does is prevent the patch from being applied. Please send only one instance of the patch, in a non-corrupted format. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: remove limit on number of handles
by Michael Stefaniuc Aug. 23, 2006

Aug. 23, 2006

Dan Kegel wrote: > Changelog: > msi: remove limit on number of handles > > handle.c | 30 +++++++++++++++++++++++------- > msipriv.h | 1 - > 2 files changed, 23 insertions(+), 8 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/msi/handle.c b/dlls/msi/handle.c > index 1cd82b3..79664f5 100644 > @@ -66,18 +67,29 @@ MSIHANDLE alloc_msihandle( MSIOBJECTHDR > > EnterCriticalSection( &MSI_handle_cs ); > > + if (msihandletable == NULL) > + { > + /* start table off small to avoid hiding resize bugs */ > + msihandletable_size = 1; Isn't this very small start value something to be used only for debugging while one writes the resizing code? For "production" I would use a value that is big enough to handle the common case (handles at least 50% of the real life cases). As the old MSIMAXHANDLES was good enough for a whole lot of programs i would define that as common case to save me work of finding what the common case is. > + msihandletable = msi_alloc_zero(1*sizeof(msi_handle_info)); > + } > + bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 2

Re: msi: increase MSIMAXHANDLES to 2048
by Alexandre Julliard Aug. 23, 2006

Aug. 23, 2006

"Dan Kegel" <dank(a)kegel.com> writes: > This lets http://bugs.winehq.org/show_bug.cgi?id=4227 > get to the next problem. (1024 handles wasn't enough, I checked. > 2048 might not be enough for a truly huge app, but this should > hold us for a while.) Dynamic allocation would be better, it's really not hard to do in this case. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: developers-hints 2 -- second try
by Alexandre Julliard Aug. 23, 2006

Aug. 23, 2006

"Tom Wickline" <twickline(a)gmail.com> writes: > Changelog: add newly implemented dlls and update http links I think the DEVELOPERS-HINTS contents should really be moved to the Wiki, it would be a lot easier to keep up to date there. Does anybody feel like doing that? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: resend add missing glyph code to GetGlyphIndices
by Dmitry Timoshkov Aug. 23, 2006

Aug. 23, 2006

"Jeff L" <lats(a)yless4u.com.au> wrote: > if(dc->gdiFont) > - ret = WineEngGetGlyphIndices(dc->gdiFont, lpstr, count, pgi, flags); > + ret = WineEngGetGlyphIndices(hdc, dc->gdiFont, lpstr, count, pgi, flags); ... > + GetTextMetricsW(hdc, &textm); As an additional optimization, probably it would be better to call WineEngGetTextMetrics instead of GetTextMetricsW to avoid introducing hdc as another parameter of WineEngGetGlyphIndices. -- Dmitry.

2 1

Re: opengl pixel format regression
by Roderick Colenbrander Aug. 23, 2006

Aug. 23, 2006

> Hello > > > Both of you try to remove the following code from > src/winex11.drv/opengl.c: > > /* Aux buffers */ > > pglXGetFBConfigAttrib(gdi_display, cfgs[fmt_index], > GLX_AUX_BUFFERS, > > &value); if (ppfd->cAuxBuffers && !value) { > > goto choose_exit; > > } > > Is this code in current CVS/GIT? I'm currently using 0.9.19 and could not > find > the code in wine sources (gentoo). I have fixed a bug related to the pixel format which should be in cvs now. So your bug might be fixed in cvs. Could you try it and could you also attach a log of glxinfo? I need that log to fix some other opengl issues and I don't have have data from cards like yours. Thanks, Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

Re: regedit[1/2]: remove custom filter from open/save dialogs
by Alexandre Julliard Aug. 23, 2006

Aug. 23, 2006

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > --- framewnd_orig.c 2006-08-10 15:15:12.000000000 +0200 > +++ framewnd.c 2006-08-22 22:10:05.000000000 +0200 Please generate diffs from the top-level directory. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi: resend add missing glyph code to GetGlyphIndices
by Alexandre Julliard Aug. 23, 2006

Aug. 23, 2006

Jeff L <lats(a)yless4u.com.au> writes: > for(i = 0; i < count; i++) > + { > pgi[i] = get_glyph_index(font, lpstr[i]); > - > + if (pgi[i] == 0) > + { > + if (flags & GGI_MARK_NONEXISTING_GLYPHS) > + pgi[i] = 0x001f; /* Indicate non existance */ > + else > + { > + /* Note that the call to GetTextMetricsW is made in the loop * > + * because it is less likely to have non existant glyphs * > + * and hence we should have few calls to GetTextMetricsW as * > + * a result */ > + GetTextMetricsW(hdc, &textm); > + pgi[i] = textm.tmDefaultChar; It's a good idea to not call GetTextMetrics unless you need it, but there's no reason to call it multiple times. It isn't hard to call it only the first time you need the default char. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user: [2/2] Pass hook handle to the destination thread. Call server to get hook information
by Vitaliy Margolen Aug. 23, 2006

Aug. 23, 2006

Thursday, August 17, 2006, 8:46:12 AM, Vitaliy Margolen wrote: > ChangeLog: > user: Pass hook handle to the destination thread. Call server to get hook > information for inter-thread hooks. > Currently Wine has a major problem with LL hooks (low level hooks) when > second hook is installed in a separate thread - the second hook callback is > never called. And while attempting to call it Wine almost locks up in never > ending loop. This happening because instead of calling current thread's > hook callback Wine restarts the whole hook chain from the start. > This patch deals with both sides of this problem. > Fixes Bug [5803], [5712] and possibly others. > dlls/user/hook.c | 41 +++++++++++++++++++++++++++++++++++++---- > dlls/user/message.c | 13 +++++++++---- > dlls/user/user_private.h | 7 +++++++ > server/hook.c | 29 +++++++++++++++++++++++++++++ > server/protocol.def | 13 +++++++++++++ > 5 files changed, 95 insertions(+), 8 deletions(-) Why wasn't this patch accepted? Alexandre on IRC said that there are some race conditions here. I don't see how and where. The only possible place that I can think of is passing handle from one thread to the other thread using internal message. But that is covered. If the hook gets removed, we don't remove it in the server: http://source.winehq.org/source/server/hook.c#L291 When new hook is added, it's being placed ahead of all others, so it's not a problem either - we can't call it anyway after hook-chain has been started. Am I missing something here? Vitaliy Margolen

1 0

Re: msiexec: Add handling for msiexec's regserver option
by Vitaliy Margolen Aug. 23, 2006

Aug. 23, 2006

Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote: > Hi, > More and more installers are expecting the MSI service to exist, or at > least be installable using msiexec /regserver. This patch is the > first step in fixing bug 5540. > + if (!scm) > + { > + fprintf(stderr, "Failed to open the service control manager.\n"); > + return 1; > + } Please use proper WINE_[ERR|WARN|FIXME|TRACE] macros. Vitaliy Margolen

2 1

regression with gothic1/2
by Sebastian Schlingmann Aug. 22, 2006

Aug. 22, 2006

Hi everybody, I noticed yesterday that the gothic 1/2 demos don't work anymore. Console output is the following: ... err:ntdll:RtlpWaitForCriticalSection section 0x7fe90020 "heap.c: main process heap section" wait timed out in thread 000f, blocked by 0009, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7bc7ef44 "loader.c: loader_section" wait timed out in thread 0009, blocked by 000f, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7fe90020 "heap.c: main process heap section" wait timed out in thread 000d, blocked by 0009, retrying (60 sec) ... A regression test came up with the following result: $ git bisect bad 13163349521e50e7039e188a22b6a814dcfcfc37 is first bad commit commit 13163349521e50e7039e188a22b6a814dcfcfc37 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 21 11:53:24 2006 +0200 ntdll: Add a few more free list entries to the heap. :040000 040000 dba2d276a01c6d148826a913f4163e0db0ed4689 eb1abe2301ff4698ac939b7e1b1fa225ceca4338 M dlls I can provide traces and additional info if needed. Bye Sebastian

3 4

Re: riched20: add EM_EXSETSEL conformance tests and fixes bug 4462
by Matt Finnicum Aug. 22, 2006

Aug. 22, 2006

Hi, Is there something wrong with this patch / a reason it's not being accepted? Sorry if this might have been answered this on IRC last night - X died while I was away, so I'd have missed it. Thanks, --Matt Finnicum On 8/19/06, Matt Finnicum <mattfinn(a)gmail.com> wrote: > Hi, > I've cleaned up / re-diffed this patch from Brian Chang. It fixes bug > 4462 by handling several odd ways in which EM_EXSETSEL can be called. > It also make the message return a proper value, not just zero. > > --Matt Finnicum (Please commit as Brian Chang) > > The last version of this patch can be found here: > http://www.winehq.com/pipermail/wine-patches/2006-March/024976.html > > --- > dlls/riched20/editor.c | 25 +++++++++++++++++--- > dlls/riched20/tests/editor.c | 52 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 73 insertions(+), 4 deletions(-) > > >

2 1

Read to 0x7ffe02c0
by Juan Lang Aug. 22, 2006

Aug. 22, 2006

Hi folks, I'm trying to debug an access (by native userenv.dll in my case, but also by MS Money 2006) to address 0x7ffe02c0. This is my understanding so far: The TEB is at 0x7ffe0000, so, according to winternl.h, offset 0x02c0 within it is in the middle of GDI_TEB_BATCH. That doesn't make any sense to me. Anyone have any idea what's going on? Thanks, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 7

Re: Fwd: RFC: OpenGL x11drv rewrite (WoW fix)
by Raphael Aug. 22, 2006

Aug. 22, 2006

On Monday 14 August 2006 19:57, you wrote: > Hi Raphael, Hi Roderick, sorry for late response i was in holidays (and before that a long moving to my new apartment) > I'm not sure how well you are monitoring the wine-devel lists these days, > so I'm also directing this mail directly to you. I have been trying to fix > various problems in the Wine OpenGL code. See the attached email and the > patch for more info. > > Basicly I changed the opengl code to only advertise the format of wine's > main visual. I think the changes I made are more or less correct to > Alexandre changes like this sounded correct aswell. But as he isn't an > OpenGL expert he wanted to know the opinion of others and especially from > people who know the code well. > > I already asked Lionel but he said that he isn't that familiar with the > current code which you rewrote a while ago. To Lionel the format > advertising change sounded correctly aswell although he hasn't checked the > code. > > Could you comment on the patch? (reply to the wine-devel list) > > Regards, > Roderick Colenbrander > > -------- Original-Message -------- > Datum: Mon, 14 Aug 2006 17:04:52 +0200 > From: "Roderick Colenbrander" <thunderbird2k(a)gmx.net> > To: wine-devel(a)winehq.org > Subject: RFC: OpenGL x11drv rewrite (WoW fix) > > Hi, > <snip> For me your patch seems correct Anyway the problem is you can add regression in cases: - application want a very specific needs that isn't compatible with current selected visual (use of SetPixelFormat before first CreateContext, now you don't care about user wanted PixelFormat) - application wants to create many context with not compatible pixel format (supported on windows) So you may restore many of the original problems but fixed the more problematic problem of BadMatch :) What it'll be interesting to do next is to move all low-level GLW/GLX utilities calls to x11drv to permit better access to x11drv internals (and to permit better portability on non GLX os, and better share with wined3d). This will help a lot for the famous bug of openGL chils windows. And after that, when user use the SetPixelFormat API, find a way to change the default created wine visual (use of SetPixelFormat is only permited once on windows). The problem is that visual is created by default before the application specify it's needs (ie. when the windows is created). We have the same problem for WineD3D, many games create a window and after want to choose a specific frame buffer (and if not compatible with current visual -> problem) I wanted to delay this visual creation (or better dynamically change this on X, if permited) but no chance (same problem for glwShareLists) :( Keep your good job :) Best Regards, Raphael

5 10

Re: [TRY 2] XEmbed System Tray Support
by Alexandre Julliard Aug. 22, 2006

Aug. 22, 2006

James Liggett <jrliggett(a)cox.net> writes: > + /* fall back to he KDE hints if the WM doesn't support XEMBED'ed > + * systrays */ > + > + /* Put the window back within the screen so it will be mapped */ > + SetWindowPos( data->hwnd, NULL, 0, 0, 0, 0, SWP_NOZORDER | SWP_NOSIZE ); It would be nicer to create the window with normal coordinates, and only move it off-screen when needed, instead of having off-screen be the default behavior. It would also avoid having explorer know about internals of the systray implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/9] DDraw: Make IDirectDrawImpl thread safe
by Alexandre Julliard Aug. 22, 2006

Aug. 22, 2006

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -245,11 +252,12 @@ void > IDirectDrawImpl_Destroy(IDirectDrawImpl *This) > { > IDirectDrawImpl *prev; > + DDOBJ_LOCK(This); You shouldn't need locking in Destroy, if the refcount is zero no one else can be using the object. > for(prev = ddraw_list; prev; prev = prev->next) > + { > if(prev->next == This) break; > + } > > if(prev) > + { > + DDOBJ_LOCK(prev); > prev->next = This->next; > + DDOBJ_UNLOCK(prev); > + } You can't lock just one object, you have the protect the whole list. -- Alexandre Julliard julliard(a)winehq.org

1 0

opengl pixel format regression
by Stefan Dösinger Aug. 22, 2006

Aug. 22, 2006

Hi Roderick, Your pixel format patches caused a regression in half-life 1 for me with the fglrx drivers. It refuses to start in opengl mode and reports "ChoosePixelFormat failed", and then comes up in software(ddraw) mode. The d3d mode still works fine. This problem also does not occur with the open source radeon driver. I tested with fglrx 8.28.8 and fglrx 8.27.10. Other games seem to work fine(appart of a few fglrx bugs) What infos do you need to debug this? This is the format table glxinfo reports: visual x bf lv rg d st colorbuffer ax dp st accumbuffer ms cav id dep cl sp sz l ci b ro r g b a bf th cl r g b a ns b eat ---------------------------------------------------------------------- 0x23 24 tc 0 32 0 r y . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x24 24 tc 0 32 0 r . . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x25 24 tc 0 32 0 r y . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x26 24 tc 0 32 0 r . . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x27 24 tc 0 32 0 r y . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x28 24 tc 0 32 0 r . . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x29 24 tc 0 32 0 r y . 8 8 8 8 0 24 0 0 0 0 0 1 0 None 0x2a 24 tc 0 32 0 r . . 8 8 8 8 0 24 0 0 0 0 0 1 0 None 0x2b 24 dc 0 32 0 r y . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x2c 24 dc 0 32 0 r . . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x2d 24 dc 0 32 0 r y . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x2e 24 dc 0 32 0 r . . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x2f 24 dc 0 32 0 r y . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x30 24 dc 0 32 0 r . . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x31 24 dc 0 32 0 r y . 8 8 8 8 0 24 0 0 0 0 0 1 0 None 0x32 24 dc 0 32 0 r . . 8 8 8 8 0 24 0 0 0 0 0 1 0 None

3 2

wine and other xservers
by Vijay Kiran Kamuju Aug. 22, 2006

Aug. 22, 2006

Hi, How does wine work/perform with other opensource X servers, like nano Xserver. Thanks, VJ

1 0

Re: Using winehq to store patches that have not yet got into the wine code
by Tony Lambregts Aug. 22, 2006

Aug. 22, 2006

Nick Law wrote: > Hi Tony / Chris > > Is there someway of storing a patch on the winehq/appdb domain so that > I can put a link on the APPDB page to it, rather than use links to > other places like thehandofagony (which doesn't look like the sort of > place we should be using). I've been using rapid.de (I think it's > called which I can carry on doing, which gives you download stats). > However I thought as we store screenshots it would be nice to store > patches approved by the maintainers (prior to be incorporated into the > code, or the code fixed). > > Regards > Nick Law > There are a number of places that patches can be stored within winehq. The first place that you could store them is in the wiki like http://wiki.winehq.org/InterestingPatches, or if they fix/hack around a bug in the application then you can start a bug report and attach the patch there and link back to it. Finally you can submit a patch to wine-patches(a)winehq.org and link to the archive. http://www.winehq.org/pipermail/wine-patches/ ie: http://www.winehq.org/pipermail/wine-patches/2006-August/029455.html I do not know what the best way is but I tend to favor the wiki.

1 0

Re: crypt32: work around an apparent compiler bug
by Robert Shearman Aug. 22, 2006

Aug. 22, 2006

Juan Lang wrote: >This seems like voodoo to me too, but the combined condition if statement >would always fail for me, while two distinct if statements succeed. > >ChangeLog: >- add a couple traces to make following execution easier >- expand an if condition to work around an apparent gcc bug > > >- if (HIWORD(function->entry.pszOID && >- !strcasecmp(function->entry.pszOID, pszOID))) > > Looks like HIWORD(function->entry.pszOID is just missing a closing bracket to me. -- Rob Shearman

2 1

Re: wined3d: print real unhandled D3DCMPFUNC value
by Jan Zerebecki Aug. 21, 2006

Aug. 21, 2006

On Sun, Aug 20, 2006 at 01:37:04PM -0700, Chris Robinson wrote: > --- dlls/wined3d/device.c 10 Aug 2006 09:43:54 -0000 1.275 > +++ dlls/wined3d/device.c 20 Aug 2006 20:31:10 -0000 > @@ -3666,7 +3666,7 @@ > case D3DCMP_GREATEREQUAL: glParm = GL_GEQUAL; break; > case D3DCMP_ALWAYS: glParm = GL_ALWAYS; break; > default: > - FIXME("Unrecognized/Unhandled D3DCMPFUNC value %ld\n", Value); > + FIXME("Unrecognized/Unhandled D3DCMPFUNC value %ld\n", This->stateBlock->renderState[WINED3DRS_ALPHAFUNC]); (I forgot if I verified this, but) I think that when a state is beeing set This->stateBlock->renderState[State] has the previous value and only Value has the one to be set. From a quick glance it seems the code for this renderstate (and maybe more renderstates) wrongly assumes the contrary. Jan

3 2

KDE wineconfig module & audio
by Yuriy Aug. 21, 2006

Aug. 21, 2006

Hi, I'm creating a KDE guidance module for wine. I'm stuck on something. winecfg tries to open each audio driver to get a list of available drivers. So far, I've just put in the list of all possible drivers, but I want to get a list consistent with winecfg. I don't know how to go about testing which drivers are available. I'm using regedit for settings, so I'm not linking to wine so I can't just use the function(s) provided in wine. Also, I'd like to put in a button to test if sound is working. Is there any software included in wine to play a wav? It needs to be something that would be installed by default when wine is installed, rather than something that's just in the source like the tests in winmm. Thanks for any help ~Yuriy

3 3