August 2006 - Wine-Devel - list.winehq.org

configure.ac: Show Messages about additional Packages with "--verbose"
by Detlef Riekenberg Aug. 20, 2006

Aug. 20, 2006

We should inform the User, when Wine is build without some Features. This Patch add Hints for additional Packages, which Wine can use. + X11-Extensions: Xext (Shm and shape), XRandr, XRender, Xxf86vmode added + libxslt1 added (libxslt1 depends on libxml2) + libhal added (libhal depends on libdbus-1) + libncurses / libcurses added + libsane added + libgphoto2 added + libicu added + liblcms added + libungif added - libdbus-1 not needed: libhal depends on libdbus-1 - libxml2 not needed: libxslt1 depends on libxml2 As requested by Alexandre, the Messages are displayed only, when requested by the User. I use the Option "--verbose" to enable the Messages. ("--verbose" is a standard Option for configure, but was unused) Changelog: - configure.ac: Show Messages about additional Packages with "--verbose" -- By by ... Detlef

1 0

compiling monolithic winetest executable with MSVC
by Saulius Krasuckas Aug. 20, 2006

Aug. 20, 2006

I've run "tools/api/msvcmaker --no-wine" and got winetest.dsp and wineruntests.dsp project files. If I exclude MSVC-non-compilable separate tests from the last project, some exe file is made. But is does nothing usefull. The first project produces winetest.lib, but its size is only 1272 bytes. I guess something is wrong with msvcmaker. Has anyone tried this? Did I miss something?

1 0

Re: [AppDB] Assorted language fixes for the front page
by Kai Blin Aug. 20, 2006

Aug. 20, 2006

On Sunday 20 August 2006 12:48, Alexander Nicolaysen Sørnes wrote: > Assorted language fixes for the AppDB front page. Shouldn't the first hunk be "howtos" instead of "howto's", anyway? Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: Allow older game to start up directx
by Stefan Dösinger Aug. 20, 2006

Aug. 20, 2006

Am Sonntag 20 August 2006 04:42 schrieb Tony Lambregts: > I have a game that uses Direct X[1] and complains that it is not > installed without this device. Credit for this patch goes to / > <mailto:lionel.ulmer(a)free.fr>/Lionel Ulmer <lionel.ulmer(a)free.fr> > > [1] See bug 2229 for more details. > http://bugs.winehq.org/show_bug.cgi?id=2229 > > Change log: Allow IID_IDirect3DRampDevice as valid Direct X interface. > > Files Changed: dlls/ddraw/direct3d_opengl.c This patch looks outdated, this file does not exist anymore since the ddraw write in 0.9.16. In the new code I couldn't find any check for the device ID(it always succeeds), so this patch shouldn't be needed.

1 0

Re: WineD3D: gpu detection
by Tom Wickline Aug. 19, 2006

Aug. 19, 2006

On 8/18/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > Hello, > > This patch tackles the problem in a different way. The idea is not to return the exact videocard but a close match (a card supporting more or less the same opengl features or with similar performance). Based on test using the closed source drivers from nvidia and ati and also using the opensource radeon dri drivers, I made a list of what extensions are available on the cards. Further I checked which of the extensions indicate correspond to certain directx versions. > You may already be aware of this "Graphics Card Comparison Guide" but in case you don't here is the links, it may help in the match making process....... ATI : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=0 NVIDIA : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=1 XGI : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=2 S3 : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=3 SiS : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=4 Matrox : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=5 PowerVR : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=6 3dfx : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=7 Trident : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=8 Intel : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=9 Tom

4 3

Re: WineD3D: gpu detection
by Frank Richter Aug. 19, 2006

Aug. 19, 2006

On 19.08.2006 00:09, Roderick Colenbrander wrote: > + } else if(WINE_D3D8_CAPABLE(gl_info)) { > + if (strstr(gl_info->gl_renderer, "GeForce4 Ti") || strstr(gl_info->gl_renderer, "Quadro4")) > + gl_info->gl_card = CARD_NVIDIA_GEFORCE4_TI4200; /* Geforce4 Ti4200/Ti4400/Ti4600/Ti4800, Quadro4 */ > + else if (strstr(gl_info->gl_renderer, "GeForce4 MX")) > + gl_info->gl_card = CARD_NVIDIA_GEFORCE4_MX; /* MX420/MX440/MX460/MX4000 */ Small note: GeForce4 MX is not a DX8 capable card. It's a souped-up GeForce2 MX and labelled "4" for marketing reasons. So perhaps move that check into the DX7 branch. -f.r.

1 0

Re: WineD3D: gpu detection
by Jesse Allen Aug. 18, 2006

Aug. 18, 2006

On 8/18/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > In case of Direct3D each device exports the pci device/vendor ids of the videocard. Lots of programs use these ids to get an idea about the capabilities of the card, enable/disable features based on the detected card or sometimes they are used for evil purposes aswell (working around bugs). .... > > Compared to the first method which I described which solely relied on the parsing of renderer strings this method is better because it takes into account the opengl capabilities of the videocard. So when a new card is out which isn't in our list, we won't fallback to a very basic card but can still return a 'close match' because of the opengl extension checks. > This patch is a nice idea. Some games query pci ids and do stupid things with it if it gets one it doesn't recognize. Using fake ids of a common card will help some. This potentially means that Wine will have better compatability with older games on newer hardware. For me this fixes a problem with battlefront under wine where battlefront sees CARD_WINE and turns everything to low and disables use of programmable shaders completely. It was very annoying because there was no way to force shaders back on in the game. I wrote a hack to fix it, but now I'm glad there is a patch that does this lots better! Thanks Roderick, Jesse

1 0

re-reading from registry
by Christoph Probst Aug. 18, 2006

Aug. 18, 2006

Hi, I'm still working on the clamav integration in wine. One question that came up recently is how to handle configuration changes. I'd like to allow to configure the virusscanner 'online' without restarting the wineserver or applications currently running. As the configuration is stored in the registry I could read all affected values every time I need them (that means several RegQueryValueExA() calls for every virusscan). But I found that this costs quite some time and even seems to cause IE5 to crash (does anyone know or want to know the reason?). When I save a local copy of my registry values and only update them every x seconds everything is fine. But is that a recommended way or is there a better solution to get notified if a registry key has been changed? If found RegNotifyChangeKeyValue() but I'm not sure if it is the right approach ... Cheers Chris -- Kontakt-Details: http://www.christoph-probst.com/kontakt/ PGP-FP: B171 7EA4 988C DD90 1601 D21C 5279 2FAF 9978 AF86

1 0

Re: tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory
by Vitaliy Margolen Aug. 18, 2006

Aug. 18, 2006

Thursday, August 17, 2006, 2:08:25 PM, Mikolaj Zalewski wrote: > When creating the wineprefix, create a directory for the menu and a > configuration file that enables this menu in the freedesktop.org menu > structure. As suggested on wine-devel the menu directory is a > subdirectory of ~/.wine, so if the user deletes it, all menu items > created there will be automatically removed. > +<Name>Applications</Name> > + <Menu> > + <Name>Wine</Name> > + <LegacyDir>__HOME__/.wine/menu</LegacyDir> > + </Menu> > +</Menu> Why are you hard-coding this path to being .wine? You correctly used $WINEPREFIX before. Also that means that you should add files that are WINEPREFIX related. Or you will keep overwriting the other ones. Vitaliy Margolen

2 1

riched20: Send EN_LINK notifications. Properly underline / color links.
by renu.rajput＠tcs.com Aug. 17, 2006

Aug. 17, 2006

The patch at http://www.winehq.org/pipermail/wine-patches/2006-August/029855.html needs to be corrected a bit: In file editor.c, there is a change as follows > case WM_MOUSEMOVE: > if (GetCapture() == hWnd) > ME_MouseMove(editor, (short)LOWORD(lParam), (short)HIWORD(lParam)); > break; > + ME_LinkNotify(editor,msg,wParam,lParam); > Here, the function ME_LinkNotify is called after the break. So it would not get executed. Thanks! =====-----=====-----===== Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited. If you have received this communication in error, please notify us by reply e-mail or telephone and immediately and permanently delete the message and any attachments. Thank you

1 0

Re: X11Drv/OpenGL pixelformat rewrite
by Tomas Carnecky Aug. 17, 2006

Aug. 17, 2006

Testing with World of Warcraft, the game runs fine, but I see this in the console: err:wgl:wglGetPixelFormatAttribivARB Unable to convert iPixelFormat 0 to a GLX one, expect problems! tom

2 1

[UPDATE 4] RFC: XEmbed System Tray Patch
by James Liggett Aug. 17, 2006

Aug. 17, 2006

Attached is the fourth update to my XEmbed system tray patches. For this version I made some fairly major changes: 1. Did away with the low-level checks for systrays, and instead had the systray icon windows created off-screen so they aren't mapped, as per Alexandre's suggestion. 2. systray_dock_window will put the icon windows back on the screen if there isn't an XEmbed tray to dock with. 3. Eliminated the WS_EX_TRAYWINDOW style hack, and moved the call to systray_dock_window to X11DRV_CreateWindow. I used the window class name to see if it was a tray window being created or not. 4. Consolidated all patches into one, as the individual patches weren't really individual changes. (Thanks to Mike McCormack for this advice.) As usual, comments/suggestions appreciated. Thanks again, James Liggett

2 1

[Fwd: Wine 0.9.19 upgrade problem]
by Scott Ritchie Aug. 17, 2006

Aug. 17, 2006

1 0

Last call for hotel and mailing list sign up
by Jeremy White Aug. 16, 2006

Aug. 16, 2006

Hi Folks, I got a brief repreive from the U of Reading, so I'm sending them the final counts tomorrow morning, so this is your last chance to request a room. Also, I'd like to start a thread on proposed meeting topics, so I'd like to ask everyone that's coming to make sure that they're subscribed to the wineconf mailing list so they can follow along. (And give those that don't want to be on it any longer to unsubscribe). Cheers, Jeremy

1 0

wined3d: direct3d.c variable-names request
by Andrew Talbot Aug. 16, 2006

Aug. 16, 2006

This request is aimed at the wined3d specialists. Hi, I'm looking to fix a couple of write-strings warnings in direct3d.c: lines 323 and 334, the second parameter to Callback(), but I don't know enough to give suitable names to the intended substitute variables. So I would be glad of suggestions, please. Thanks, -- Andy.

2 4

Re: widl [1/4]: Fix NdrConformantArrayUnmarshall calls in generated code
by Robert Shearman Aug. 16, 2006

Aug. 16, 2006

Dan Hipschman wrote: >This series of four patches allow gcc to compile the proxy file that widl >generates for oaidl.idl. This first patch fixes the number and types of >arguments widl generates for NdrConformantArrayUnmarshall calls. > >ChangeLog: >* Generate the correct args for NdrConformantArrayUnmarshall in proxy code > > Hi Dan, It might be better to reuse the code in typegen.c rather than maintaining two different pieces of code that essentially do the same job. -- Rob Shearman

2 2

Re: [RESEND] user: Select entire text if DLGC_HASSETSEL set
by Alexandre Julliard Aug. 16, 2006

Aug. 16, 2006

Stefan Siebert <stefan.siebert(a)web.de> writes: > +static void DIALOG_SelectTextIfHasSetSel( HWND hwndEdit ) > +{ > + MSG msg; > + LRESULT dlgCode; > + > + dlgCode = SendMessageW (hwndEdit, WM_GETDLGCODE, msg.wParam, (LPARAM)&msg); msg is not initialized, you are sending garbage to the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: appdefaults: use more strings from resources, unicode
by Paul Vriens Aug. 16, 2006

Aug. 16, 2006

On Wed, 2006-08-16 at 06:23 +0200, Frank Richter wrote: > +#define IDS_DEFAULT_SETTINGS 8017 > +#define IDS_EXECUTABLE_FILTER 8018 > +#define IDS_USE_GLOBAL_SETTINGS 8019 > +#define IDS_SELECT_EXECUTABLE 8020 Hi Frank, the patch is applied but the strings are not defined in the .rc files. Looks a bit strange now when starting winecfg. Cheers, Paul.

1 0

Benchmarking Wine
by Tom Wickline Aug. 16, 2006

Aug. 16, 2006

Hello, I'm planning to update the benchmarks on the wiki with version 9.20 when it's released and thought I would ask in advance if anyone here has any ideas about the benchmarks. The three new benchmarks that I plan to add are 3DMark03, 3DMark05?? and 3DMark06 Anyone here interested in ShaderMark or AquaMark? or any other bench for that matter. Also Ive made a small update to : http://wiki.winehq.org/BenchMark-0%2e9%2e6 The test were not run under optimal conditions, other apps open, not from a clean boot, run in a window, and with debugging on... So the scores should improve :) Cheers, Tom

5 11

Re: advapi32: add GetComputerObjectName tests (revised)
by Paul Vriens Aug. 16, 2006

Aug. 16, 2006

On Wed, 2006-08-16 at 07:28 -0400, Robert Reif wrote: > Revision based on feedback from Paul Vriens. Hi Robert, your patch was already applied. Could you diff it against current? Cheers, Paul.

1 0

Re: regedit: Write-strings warnings fix and remove superfluous casts (Resend)
by Alexandre Julliard Aug. 16, 2006

Aug. 16, 2006

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > Please tell me what is wrong with this patch. Thank you. It's causing warnings: gcc -c -I. -I. -I../../include -I../../include -I../../include/msvcrt -DNO_LIBWINE_PORT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -fno-builtin -o childwnd.o childwnd.c childwnd.c: In function 'GetItemFullPath': childwnd.c:135: warning: passing argument 1 of 'CombinePaths' from incompatible pointer type childwnd.c: In function 'GetPathFullPath': childwnd.c:144: warning: passing argument 1 of 'CombinePaths' from incompatible pointer type -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Use WCHARs for window title
by Alexandre Julliard Aug. 16, 2006

Aug. 16, 2006

Frank Richter <frank.richter(a)gmail.com> writes: > From 8aaa9ca3552c7e3662c58671c9bc789b1492aa32 Mon Sep 17 00:00:00 2001 > From: Frank Richter frank.richter(a)gmail.com <frank.richter(a)gmail.com> > Date: Wed, 16 Aug 2006 05:44:29 +0200 > Subject: [PATCH] winecfg: Use WCHARs for window title You should switch the app name to Unicode too, this way you wouldn't need to change all the format strings. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] kernel: add VirtualAllocEx remote thread conformance tests (updated)
by Alexandre Julliard Aug. 16, 2006

Aug. 16, 2006

tkho(a)ucla.edu (Thomas Kho) writes: > diff --git a/dlls/kernel/tests/Makefile.in b/dlls/kernel/tests/Makefile.in > index bfeae14..5f6c12e 100644 > --- a/dlls/kernel/tests/Makefile.in > +++ b/dlls/kernel/tests/Makefile.in > @@ -3,7 +3,7 @@ TOPOBJDIR = ../../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = kernel32.dll > -IMPORTS = kernel32 > +IMPORTS = kernel32 user32 It would be cleaner to avoid importing user32 in the kernel tests. What you probably should do is have the test create more instances of itself the way the process test does. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add GetComputerObjectName tests (resend)
by Paul Vriens Aug. 16, 2006

Aug. 16, 2006

On Tue, 2006-08-15 at 19:01 -0400, Robert Reif wrote: > plain text document attachment (secur32.tests.diff.txt) > diff -puN wine.cvs/dlls/secur32/tests/Makefile.in wine/dlls/secur32/tests/Makefile.in > + rc = GetComputerObjectNameW(formats[i], nameW, &size); > + ok(rc || ((formats[i] == NameUnknown) && > + (GetLastError() == ERROR_INVALID_PARAMETER)) || > + (GetLastError() == ERROR_CANT_ACCESS_DOMAIN_INFO), > + "GetComputerObjectNameW(%d) failed: %ld\n", > + formats[i], GetLastError()); > + } > +} > + > +START_TEST(secur32) > +{ > + testGetComputerObjectName(); > +} Hi Robert, you must likely have to change the tests to check: a) if secur32 is available (NT4 seems to lack this one) b) W-calls are (sometimes) not present on non-unicode versions of windows. http://test.winehq.org/data/200608151000/ already shows errors with secur32 and NT4 (I get a pop-up that it can't find secur32.dll). Cheers, Paul.

1 0

RFC: XEmbed Systray Patches
by James Liggett Aug. 16, 2006

Aug. 16, 2006

Hello everyone, After a long hiatus, I'm trying again to get XEmbed systray support into Wine. I've been working on it for the past few days and I've got these patches. These are based on the system tray code from the Wine version used in the Linux port of Picasa [1] (which in turn was based on the work of Mike Hearn and Rob Shearman.) These patches are basically the same thing, with some fixes: 1. Use proper wine_tsx11 locking. 2. Clean up inappropriate C++ comments in that code. 3. Properly populated the XEvent structure to send docking messages. (According to the XEmbed systray spec [2], any unused fields in the message must be set to 0.) 4. Broken into five atomic patches against today's GIT. In my testing on Gnome 2.14, these patches dock much more reliabaly than the last ones, but they're still not quite perfect. In most cases, programs dock fine until about the seventh consecutive run (behavior observed with Steam and a small test program I wrote.) However, I noticed that it works perfectly if I enabled a +x11drv trace, so I suspect that this has something to do with stack problems, but I've been unable to find the source of the problem. I'd appreciate it if someone could give me some assistance on tracking down this issue. If you'd like to test these, please apply them in the order that they're numbered. Any comments/suggestions appreciated. Thnaks, James Liggett [1]: http://code.google.com/wine.html [2]: http://standards.freedesktop.org/systemtray-spec/systemtray-spec-0.2.html#m…

2 13

Re: oleaut32: Added insufficient memory check to ITypelib2:GetDocumentation2
by Dan Kegel Aug. 16, 2006

Aug. 16, 2006

2006/8/15, Benjamin Arai <me(a)benjaminarai.com>: > ChangeLog: > - Added insufficient memory check to ITypelib2::GetDocumentation2 > - Returns MSDN specified value STG_E_INSUFFICIENTMEMORY Have you *ever* seen this run out of memory in real life? - Dan

1 0

Re: oleaut32: Added insufficient memory check to ITypelib2:GetDocumentation2
by Frank Richter Aug. 16, 2006

Aug. 16, 2006

On 16.08.2006 04:23, Benjamin Arai wrote: > if(pbstrHelpString) > + { > *pbstrHelpString=SysAllocString(This->DocString); > + if(!*pbstrHelpString) > + return STG_E_INSUFFICIENTMEMORY; > + } > if(pdwHelpStringContext) > *pdwHelpStringContext=This->dwHelpContext; > if(pbstrHelpStringDll) > + { > *pbstrHelpStringDll=SysAllocString(This->HelpStringDll); > + if(!pbstrHelpStringDll) > + return STG_E_INSUFFICIENTMEMORY; > + } Hm, shouldn't pbstrHelpString be freed in case the 2nd allocation fails? -f.r.

1 0

Re: kernel32: add GetNativeSystemInfo (Try 2)
by Dan Kegel Aug. 15, 2006

Aug. 15, 2006

This patch is good, and helps fix MS Photostory 2 LE's installer ( http://bugs.winehq.org/show_bug.cgi?id=5966 ). Robert, you might need to repost, though; there was a wrapped line.

1 0

[meta-bug] I can not contact Jeremy Newman
by Jérôme Bouat Aug. 15, 2006

Aug. 15, 2006

Hello, I can not reach Jeremy Newman. I hope he goes well. A very important bug still exist for years but its bugzilla issue gets no response at all : http://bugs.winehq.org/show_bug.cgi?id=5202 Please, say something (i.e. WONTFIX, INVALID, LATER, ...). I hope someone will respond. Thanks.

4 4

Re: user: Pass all required information with internal message when chaining hooks
by Alexandre Julliard Aug. 15, 2006

Aug. 15, 2006

Vitaliy Margolen <wine-patch(a)kievinfo.com> writes: > This patch deals with two sides of this problem. And actually saves > some time by not calling server one extra time. I don't think that's a good thing, now you risk calling a hook that has been deleted already. You really want to fetch the hook info from the destination thread. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: usp10: Resend - Remove unnecessary casts in test suite
by Alexandre Julliard Aug. 15, 2006

Aug. 15, 2006

Jeff L <lats(a)yless4u.com.au> writes: > Any problems? It doesn't apply. When resending a patch please regenerate it against the current tip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10: Resend - Add funtionality for ScriptStringAnalyse
by Alexandre Julliard Aug. 15, 2006

Aug. 15, 2006

Jeff L <lats(a)yless4u.com.au> writes: > + cMaxItems = 255; /* Pick an abritary size for buffers */ > + if (!*pssa) /* Clean it out and start again */ > + ScriptStringFree(pssa); I still don't see why you want to free a NULL pointer. > + { > + prtssa(*pssa); > + analysis = * pssa; > + prtssa((SCRIPT_STRING_ANALYSIS *)analysis); Why do you print the same object twice? There seems to be a lot of confusion in your code between pointers and pointers to pointers, I think you need to define better data types to clarify this. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: XEmbed Systray Patches
by James Liggett Aug. 15, 2006

Aug. 15, 2006

Hi Everyone, First, I'd like to apologize for sending those tarballs to wine-devel, as I've just been advised on IRC that such a practice discourages reviews. I've attached a text version of the patches in the hopes that it will get some more exposure. Again, sorry for the trouble. :) James

2 1

All right, let's solve these .desktop issues forever
by Scott Ritchie Aug. 14, 2006

Aug. 14, 2006

As of right now, I'd estimate that over half of our users are using Wine from a terminal window to launch their applications, largely because their window manager doesn't put Wine's Start Menu entries into their applications menu. Wine's been making .desktop files for some time, however it seems like they're being put in the wrong place. There's supposedly a proper, standard place to put them (or there should be), and perhaps a hack can be put in at the package-maintainer level, but in any case this is a pretty big usability issue at the moment. I'm pretty confident that someone here knows the answer to how things should be, and I'm also pretty sure it's a fairly simple change to make. Either way, we need to have a discussion about it - what's the next step here? Thanks, Scott Ritchie

7 8

Re: USER: SystemParametersInfo fixes
by Alexandre Julliard Aug. 14, 2006

Aug. 14, 2006

Frank Richter <frank.richter(a)gmail.com> writes: > Subject: [PATCH] USER: Fix SPI_SETICONTITLELOGFONT to check for LOGFONTW size > [...] > Subject: [PATCH] USER: initialize size of nonclients struct in load_nonclient_metrics Please don't attach multiple patches, each patch should be a separate mail. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: WineD3D: add rgb24 colorkey conversion
by Alexandre Julliard Aug. 14, 2006

Aug. 14, 2006

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > + for (x = 0; x < len; x++) { > + /* Retrieve RGB24 color */ > + DWORD color = *((DWORD*)src); > + /* Store the RGB portion in dest and reserve a byte for alpha */ > + *Dest = color << 8; > + if ((color < surf->SrcBltCKey.dwColorSpaceLowValue) || > + (color > surf->SrcBltCKey.dwColorSpaceHighValue)) > + *Dest |= 0xff; > + src += 3; You should avoid unaligned DWORD accesses, this doesn't work on all platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: OpenGL x11drv rewrite (WoW fix)
by Roderick Colenbrander Aug. 14, 2006

Aug. 14, 2006

Hi, Since the WM rewrite we can only use the visual which was created by x11drv at x11drv initialization. In general this is a simple 32bit RGBA visual or when that's not available it is some 16bit visual. The problem is that the opengl code advertises more formats than this single format. The problem which this can cause is that a 'bad' format is set by SetPixelFormat. In the end when we create a context using wglCreateContext this 'bad' pixelformat is used. When some time later glXMakeCurrent is called we will get a BadMatch. (Note that in a few cases we catch the 'BadMatch' before it happens and create a new GLX Context; this is when context is NULL) The proposed patch which I attached to this email rewrites the pixel format code. First I'll give a short introduction and then I will explain my changes. The functions ChoosePixelFormat/GetPixelFormat/SetPixelFormat/DescribePixelFormat all work with a parameter 'iPixelFormat'. This variable is an index into the table of supported pixel formats. At the moment the index is a direct mapping to the FB config table exported by GLX. I have changed ChoosePixelFormat to only return the format of the main visual. Further this function needs to find a 'closest match' to the requested format, before it tried to find an exact match. I changed the function to look for a close match. Further because only 1 format is supported, the max index the function can return is 1. This kills the direct mapping of the index to the index in the GLX FB config table. All the opengl calls in x11drv got changed to only accept our single format. As I mentioned earlier the opengl calls used the specified iPixelFormat as an index in the GLX FB config table. Because the 1:1 mapping of iPixelFormat to this table got lost I have added a function to retrieve the index of the main visual. Further I had to change our wglMakeCurrent call to retrieve the pixel format to use from the main visual instead of getting it from a GetPixelFormat call. This was done because wglMakeCurrent needs an index into the GLX FB Config table and not in our 'win32 opengl format table' (which only contains 1 format). I have tested the patch in several programs. Before Halflife1 didn't work in 16bit because ChoosePixelFormat was too strict, the game works fine now. Further the patch also fixes the BadMatch error Nvidia users received in World Of Warcraft when using the OpenGL renderer. I think the patch is a correct fix for the BadMatch / ChoosePixelFormat issues. The patch isn't 100% complete yet as I haven't updated the WGL extensions for pbuffer and wglChoosePixelFormat to work with the new pixelformats yet (that's why you see a line WoW hack). I will fix that part when you guys think that the patch is correct. Regards, Roderick Colenbrander -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

2 1

Is anyone going to or presenting at Linuxworld?
by Scott Ritchie Aug. 14, 2006

Aug. 14, 2006

Linuxworldexpo is this week. Since no one's mentioned it yet, I'm assuming that we don't have a booth or speech planned :) http://www.linuxworldexpo.com/live/12/events/12SFO06A At any rate, perhaps we should be going to things like this. There's usually a convention like this (OSCON, etc) every couple of months, and it certainly couldn't hurt to have a Wine evangelist there talking about how powerful Wine is getting and why Wine should be considered as a bigger part of the Linux strategy. What do you think? Thanks, Scott Ritchie

2 1

Re: resend add missing glyph code to GetGlyphIndices
by Dmitry Timoshkov Aug. 14, 2006

Aug. 14, 2006

"Jeff L" <lats(a)yless4u.com.au> wrote: > -DWORD WineEngGetGlyphIndices(GdiFont font, LPCWSTR lpstr, INT count, > + * */ Strange indentation at the end of a comment. > +DWORD WineEngGetGlyphIndices(HDC hdc, GdiFont font, LPCWSTR lpstr, INT count, > LPWORD pgi, DWORD flags) > { > INT i; > - > + TEXTMETRICW textm; > for(i = 0; i < count; i++) > + { > pgi[i] = get_glyph_index(font, lpstr[i]); > - > + if (pgi[i] == 0) > + { > + if (flags & GGI_MARK_NONEXISTING_GLYPHS) > + pgi[i] = 0x001f; /* Indicate non existance */ > + else > + { > + GetTextMetricsW(hdc, &textm); > + pgi[i] = textm.tmDefaultChar; > + } > + } > + } > return count; > } I'd suggest to move GetTextMetricsW outside of the loop to not kill the performance. > + WCHAR testtext[] = {'T',0x0000,'s','t',0xffff,0}; > + WORD glyphs[(sizeof(testtext)/2)-1]; > + TEXTMETRIC textm; > + > + memset(&lf, 0, sizeof(lf)); > + strcpy(lf.lfFaceName, "Symbol"); > + lf.lfHeight = 20; > + > + hfont = CreateFontIndirectA(&lf); > + hdc = GetDC(0); > + > + ok(GetTextMetrics(hdc, &textm), "GetTextMetric failed\n"); Please set tab width to 8 instead of 4 and do not mix tabs and spaces. -- Dmitry.

3 3

Re: secur32: Fix heap error.
by Kai Blin Aug. 14, 2006

Aug. 14, 2006

On Monday 14 August 2006 11:57, Kai Blin wrote: > --- > dlls/secur32/dispatcher.c | 1 - > dlls/secur32/ntlm.c | 1 + > 2 files changed, 1 insertions(+), 1 deletions(-) Sorry, this one is obviously a typo. Sending a new one. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: secur32: Make AcceptSecurityContext behaviour consistent withWindows.
by Dmitry Timoshkov Aug. 14, 2006

Aug. 14, 2006

"Kai Blin" <kai.blin(a)gmail.com> wrote: > phNewContext->dwUpper = ctxt_attr; > - phNewContext->dwLower = ret; > + phNewContext->dwLower = (DWORD)helper; You need to cast to ULONG_PTR to make the code 64-bit safe. Also please fix (DWORD)helper casts in other places. -- Dmitry.

2 1

Re: secur32: Clean up AcceptSecurityContext (reduce indent and duplication).
by Kai Blin Aug. 14, 2006

Aug. 14, 2006

On Sunday 13 August 2006 14:44, Kai Blin wrote: > --- > dlls/secur32/ntlm.c | 372 > ++++++++++++++++++++++----------------------------- > 1 files changed, 164 insertions(+), 208 deletions(-) After sending in the fixes for my "Make AcceptSecurityContext behaviour consistent with Windows, try2" patch, this one won't apply anymore. I'll resend it later today. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: gdi: Implement GetFontUnicodeRanges.
by Huw Davies Aug. 14, 2006

Aug. 14, 2006

On Sun, Aug 13, 2006 at 08:26:24PM +0200, Hans Leidekker wrote: > > Any word on this patch? > > -Hans > > Changelog > Implement GetFontUnicodeRanges on top of fontconfig and freetype. I wonder whether FcFreeTypeCharSet is what you really want here. It uses a lot of heuristics which almost certainly won't match what Windows does, so we're probably better off writing our own. A test (on say Arial) would be useful here. Also note that even if you do use the Fc* functions you'll need to check that the pFc* ptrs are non-NULL before calling them. Huw.

2 1

[UPDATE 3] RFC: XEmbed System Tray Patches
by James Liggett Aug. 14, 2006

Aug. 14, 2006

Attached is the third update to the xembed systray patches. For this version I've simplified the if statements for checking if we should map tray icon windows or not (As per Scott Ritchie's advice--Thanks again Scott.) As always, further comments/suggestions appreciated. Thanks, James Liggett

1 0

[UPDATE 2] RFC: XEmbed System Tray Patches
by James Liggett Aug. 14, 2006

Aug. 14, 2006

Attached is the second update of the XEmbed systray patches. Changes in this version: 1. On the advice of Juan Lang, I only acquire the wine tsx11 lock when actually making X calls, and not while initializing data. 2. Added the ability to detect if we have an XEmbed systray so that we can selectively determine if we need to map tray windows or not. Under the last version, the icons would not be mapped under any circumstances whatsoever. While it would work if we had an XEmbed-compliant tray to dock with, the icon wouldn't show up at all if there wasn't one. Things work both ways now. But, if you look at the patches, you'll notice that the logic in the if statements is a little ugly. Is there a cleaner way to do this? Thanks, James Liggett

2 3

Re: secur32: make GetComputerObjectNameA use GetComputerObjectNameW (revised)
by Chris Robinson Aug. 13, 2006

Aug. 13, 2006

On Sunday 13 August 2006 06:45, Robert Reif wrote: > This patch also adds a partial implementation of GetComputerObjectNameW. The GetComputerObjectNameA function appears to be broken. When GetComputerObjectNameW fails due to too little memory in the name buffer, it sets the buffer size as specified by MSDN. However, when GetComputerObjectNameA calls GetComputerObjectNameW and receives an error code, this isn't copied into its nSize parameter.

2 1

Re: reasons for not accepting the patch
by Dan Kegel Aug. 13, 2006

Aug. 13, 2006

2006/8/12, Vijay Kiran Kamuju <infyquest(a)gmail.com>: > [Why wasn't the patch > http://www.winehq.org/pipermail/wine-patches/2006-July/029145.html > accepted?] I looked at this a couple days ago, and sent this to the patches' author to encourage him to repost it: -- snip --- 1. The patch is missing the filename header, and cannot be applied to the sources by running 'patch'. 2. the patch was posted with the following legal notice: "Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited." That tells us "You may not use this patch." You have to post patches without that. 3. the message did not contain any license information (e.g. Author: Renu Rajput (Tata Inc.) Copyright 2006 Tata Inc License: LGPL. Adding that would help. 4. The message essentially repeated much of the bug report in bugzilla. That's not needed. Just refer to the bug report. Any one of the above four might have been enough to cause the patch to be ignored. Fix them all and you've got a good shot. Two more tips: 5. The bug report in bugzilla does not link to your proposed fix. Often after I post a proposed fix, I add a comment to bugzilla saying something like "Patch sent: http://www.winehq.org/pipermail/wine-patches/2006-July/029145.html" Not only does this give another way for people to stumble across and review your patch, it also helps avoid duplication of effort. I had no idea you had sent in a patch for this bug already! 6. Patches that do not get applied need to be resent after a few days. Every time you resend it, you should try to improve it or the test case a bit, and make sure it still applies against current cvs or git. Use the same subject line as before, but append "(resend)" to the end. Patches are like TCP/IP. There is no ACK when a packet is corrupt, you have to resend after correcting a bit error! --- snip --- Hope that helps. - Dan

2 1

Re: winmm: prevent NULL dereference in MCI_Close
by Eric Pouech Aug. 12, 2006

Aug. 12, 2006

Jan Zerebecki wrote: >If this patch is rejected from inclusion, please tell me why, as >I would have to ask anyway. > >From: Jan Zerebecki <jan.wine(a)zerebecki.de> > > > Jan, do you have a specific program that depends on this case ?

2 1

Missing subtitle in WWN 307
by Francois Gouget Aug. 12, 2006

Aug. 12, 2006

Hi, It's not a big issue but I have noticed that in WWN 311 the article about 'Microsoft WGA & Wine' does not have a subject: http://www.winehq.org/?issue=311#Microsoft%20WGA%20&%20Wine Currently it reads: +----------------------------------------+---------+ |Microsoft WGA & Wine | Archive | +----------------------------------------+---------+ That is it is missing the 'subtitle' underneath the gray bar. So it should look something like this: +----------------------------------------+---------+ |Microsoft WGA & Wine | Archive | +----------------------------------------+---------+ WINE & Microsoft WGA Is this an XML parsing bug? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

1 0

Wide-string Functions: Double Casting
by Andrew Talbot Aug. 12, 2006

Aug. 12, 2006

Although I accept that my opinion may not be universally shared :-), I believe that it is better to turn -Wcast-qual on permanently and double-cast the appropriate return values of the relevant wide-string functions (strchrW(), strrchrW(), strpbrkW(), memchrW() and memrchrW()) than to leave it normally turned off: that way, the developers can avoid violations as they go, and give the janitors a break ;-). These functions are ubiquitous and widely understood, and they account for the vast majority of cast-qual warnings. Because, as I understand it, we are aiming for C89 compatibility, and to try to maximise portability, I am proposing to use size_t, rather than uintptr_t (which is a C99 type): it seems like the next-best thing. So I would like to submit a patch that, for example, changes strchrW() to: extern inline WCHAR *strrchrW( const WCHAR *str, WCHAR ch ) { WCHAR *ret = NULL; do { if (*str == ch) ret = (WCHAR *)(size_t)str; } while (*str++); return ret; } What do people think? Should I just send in the patch and see what criticism it engenders? Does anyone have a system on which this would fail or generate other warnings in place of the cast-qual one? Needless to say, I hope to be tackling the cast-qual janitorial task, soon; hence, my sudden interest in this. Thanks, -- Andy.

4 9