September 2006 - Wine-Devel

Re: Implement GetKerningPairs for TrueType fonts, take 4
by Huw Davies Sept. 20, 2006

Sept. 20, 2006

On Thu, Sep 21, 2006 at 12:18:51AM +0900, Dmitry Timoshkov wrote: > this version of the patch incorporates another Huw's suggestion > in eliminating redundant local variable and simplifying the code. Thanks Dmitry, Looks good to me. -- Huw Davies huw(a)codeweavers.com

1 0

Recovering a patch accidentally removed by git reset
by Jeff L Sept. 20, 2006

Sept. 20, 2006

How do you get a patch back that you have managed to remove completely from your system with a git reset HEAD^ git reset git checkout patchname ? git fetch does not seem to refresh the patch from the repository. I was going fairly well with git then stuffed this up. Jeff

4 4

Re: Implement GetKerningPairs for TrueType fonts, take 3
by Huw Davies Sept. 20, 2006

Sept. 20, 2006

On Wed, Sep 20, 2006 at 03:22:02PM +0900, Dmitry Timoshkov wrote: > Changelog: > Implement GetKerningPairs for TrueType fonts. Hi Dmitry, Looks good, apart from one small nitpick below. I still think it would be nice to add the tests that you have to the test suite, even if it's just something that checks the first few pairs of Arial at some fixed font height. .... > +static DWORD parse_format0_kern_subtable(GdiFont font, > + const struct TT_format0_kern_subtable *tt_f0_ks, > + const USHORT *glyph_to_char, > + KERNINGPAIR *kern_pair, DWORD cPairs) > +{ .... > + kern_pairs_copied = 0; > + > + for (i = 0; i < nPairs; i++) > + { > + kern_pair->wFirst = glyph_to_char[GET_BE_WORD(tt_kern_pair[i].left)]; > + kern_pair->wSecond = glyph_to_char[GET_BE_WORD(tt_kern_pair[i].right)]; > + kern_pair->iKernAmount = MulDiv((short)GET_BE_WORD(tt_kern_pair[i].value), font->ppem, font->ft_face->units_per_EM); > + > + TRACE("left %u right %u value %d\n", > + kern_pair->wFirst, kern_pair->wSecond, kern_pair->iKernAmount); > + > + kern_pair++; > + kern_pairs_copied++; > + if (!--cPairs) break; > + } Seems to me that if you set nPairs = min(cPairs, nPairs) at the start of the loop, then you can eliminate the break and get rid of the kern_pairs_copied variable that basically mirrors i. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

make test failure
by Ivan Leo Puoti Sept. 20, 2006

Sept. 20, 2006

Here is a make test failure I'm getting on my laptop (for those of you who were not at wineconf, make test should, in theory, work everywhere) ../../../../wine/tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so ../../../../wine/dlls/gdi/tests/font.c && touch font.ok font.c:276: Test failed: Courier(13): tm.tmAscent 10 != 11 font.c:277: Test failed: Courier(13): tm.tmDescent 3 != 2 make[2]: *** [font.ok] Error 2 make[2]: Leaving directory `/home/ivan/build/dlls/gdi/tests' make[1]: *** [gdi/tests/__test__] Error 2 make[1]: Leaving directory `/home/ivan/build/dlls' make: *** [dlls/__test__] Error 2

8 7

RegisterHotKey/UnregisterHotKey implementation...success?
by Aaron Slunt Sept. 20, 2006

Sept. 20, 2006

http://www.winehq.com/pipermail/wine-devel/2006-May/047460.html The above link I looked at, and I saw this person was apparently crashing with the patch when trying to register a hotkey twice (that's how I interpreted it). Anyways, I looked at the patch, and cleaned it up so it applies to the current git tree. Anyways, it seems that I simply cannot reproduce the crash he was talking about. I binded F1 in HLSS (Half-Life Sound Selector), and opened another copy of HLSS. It simply would not allow me to register the key again. So I closed the second copy of HLSS and opened Ventrilo. I attempted to bind F1, and again it simply would not allow it. And let me make this clear, not once did I crash with this patch. HLSS works (fundamentally, not perfectly) when using it with Counter-strike (the hotkey works, there are window management problems though which have nothing to do with this) and I just never crashed with it. I'm attaching the patch for others to test if they could, and to see if a crash can be reproduced. But to me it looks like the work Robert Reif and Vincent Povirk is a huge success.* *

2 2

COM
by Joe McCay Sept. 20, 2006

Sept. 20, 2006

A recent article in a Linux magazine talking about winelib mentioned using __attribute__((com_interface)). I thought that attribute was no longer valid in gcc. The reason I am asking is because I am trying to do COM development using mingw, C++, & (hopefully) WIDL. I thought the 3.x and higher version of gcc supported -fvtable-thunks by default making it binary compatible with windows COM. Does anyone know if this is really true? jmccay

1 0

Problem with a Turbolog4.exe application under wine
by James Courtier-Dutton Sept. 19, 2006

Sept. 19, 2006

Hi, A demo version of Turbolog4 can be downloaded from: http://www.turbolog.de/ The program installs ok, but fails to run correctly. It asks for a License key, one should be able to press cancel and bypass it into demo mode where a window is displayed for entering log records. Can anyone help be diagnose why it fails. James

2 1

Something's wrong with my GIT tree
by Aaron Slunt Sept. 19, 2006

Sept. 19, 2006

http://pastebin.ca/176787 I've had this for several days, and git fetch tells me everything's up to date. Is this a known issue? How do I get rid of this? ./configure --x-libraries=/emul/linux/x86/usr/lib/ LDFLAGS="-L/emul/linux/x86/usr/lib -L/emul/linux/x86/lib" && make depend && make That configure has always worked for me, and it gets through make depend, it's just failing on make with that error message.

2 1

Error in GDI (StretchBlt) - proper fix?
by David Gümbel Sept. 19, 2006

Sept. 19, 2006

Hello everybody, I am debugging an application and got up to the point where I have reason to believe that the StretchBlt function in GDI is part of the problem. A backtrace of the exception I always run into looks like this: err:syslevel:_CheckNotSysLevel Holding lock 0x7ecd0820 level 3 wine: Unhandled exception 0x80000003 at address 0x0000:0x7ee96b34 (thread 0011), starting debugger... WineDbg starting on pid 0x10 err:syslevel:_CheckNotSysLevel Holding lock 0x7ecd0820 level 3 0x7ee96b35 _CheckNotSysLevel+0x3d in kernel32: addl $36,%esp Wine-dbg>bt Backtrace: =>1 0x7ee96b35 _CheckNotSysLevel+0x3d in kernel32 (0x7ee96b35) 2 0x7ec84c81 GDI_CheckNotLock+0x20 in gdi32 (0x7ec84c81) 3 0x7ec628e8 DeleteDC+0x26 in gdi32 (0x7ec628e8) 4 0x7ec6420b GetDIBits+0x1fd in gdi32 (0x7ec6420b) 5 0x7ec6c282 in gdi32 (+0x2c282) (0x7ec6c282) 6 0x7ec5bfee StretchBlt+0xca in gdi32 (0x7ec5bfee) 7 0x0042a3aa in bav (+0x2a3aa) (0x0042a3aa) 8 0x00425460 in bav (+0x25460) (0x00425460) 9 0x005d1304 in bav (+0x1d1304) (0x005d1304) 10 0x005e4f5d in bav (+0x1e4f5d) (0x005e4f5d) 11 0x0066f10b in bav (+0x26f10b) (0x0066f10b) 12 0x00681f8b in bav (+0x281f8b) (0x00681f8b) 13 0x7ee7ff5f in kernel32 (+0x4ff5f) (0x7ee7ff5f) 14 0xb7e9d387 wine_switch_to_stack+0x17 in libwine.so.1 (0xb7e9d387) When looking at StretchBlt's source code, I see a comment saying that there is a race condition in this function[1]. If I'm not mistaken, this problem has been reported in january as bug #4284, causing trouble (a deadlock) with MS PowerPoint[2]. Walt Ogburn suggested in january that commenting out #define STRETCH_VIA_DIB in dlls/gdi/mfdrv/bitblt.c could work around the problem[3]. Does anybody have any idea on how a proper fix for that function might approximately look like? Thanks, David [1] http://source.winehq.org/source/dlls/gdi/bitblt.c#L139 [2] http://bugs.winehq.com/show_bug.cgi?id=4284 [3] http://www.winehq.org/pipermail/wine-devel/2006-January/044040.html

1 0

Re: Fix a memory leak, fix a typo in the comment, add a trace
by Huw Davies Sept. 19, 2006

Sept. 19, 2006

On Tue, Sep 19, 2006 at 11:44:52AM +0900, Dmitry Timoshkov wrote: > please apply after "Implement GetKerningPairs for TrueType fonts". > > Changelog: > - fix a memory leak > - fix a typo in the comment > - add a trace about skipped a not supported kerning table format Hi Dmitry, Wouldn't it be nicer to simply resend the first patch again with these fixes applied? Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0