September 2006 - Wine-Devel

wine and dos support
by Vijay Kiran Kamuju Sept. 7, 2006

Sept. 7, 2006

Hi, A friend of mine is asking me to get dos based games to work using wine. Well, I generally tell to use dosbox for that. Is it possible make them work in wine. If yes, what effort should we put into that. I mean what should we need to implement. Is it possible to lift some parts of other LGPL dos projects. Thanks, VJ

1 0

Re: tools: Remove redundant NULL checks before free() (found by Smatch).
by Robert Shearman Sept. 7, 2006

Sept. 7, 2006

I think the checks are necessary to be compatible with libc's on other platforms. -- Rob Shearman

2 1

Should I give up?
by Damjan Jovanovic Sept. 7, 2006

Sept. 7, 2006

Hi My work on the still image system for wine has highlighted a bug in setupapi's SetupDiOpenClassRegKeyExW(). In short, the registry keys for device classes have the form HKEY_LOCAL_MACHINE\System\CurrentControlSet\ Class\{xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx} while wine incorrectly tries to open HKEY_LOCAL_MACHINE\System\CurrentControlSet\ Class\xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx ie. no curly braced around the guid. And in addition it incorrectly returns FALSE for a return type of HKEY (instead of INVALID_HANDLE_VALUE). I've submitted a test and patch to wine-patches 7 times now, and received very little feedback, which I've always followed. If this is how difficult it is to submit a patch, no wonder I hear people complaining about how wine doesn't have enough developers. How are you ever going to accept my still image code, which is 4000+ lines long and growing, when you can't accept a simple 182 line long patch? Normally I'm very patient - but this is ridiculous. I'm attaching my latest patch and would appreciate any comments. Thank you Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --- a/dlls/setupapi/tests/Makefile.in 2006-07-10 18:01:08.000000000 +0200 +++ b/dlls/setupapi/tests/Makefile.in 2006-08-31 21:29:12.000000000 +0200 @@ -3,7 +3,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = setupapi.dll -IMPORTS = setupapi kernel32 +IMPORTS = setupapi kernel32 advapi32 rpcrt4 CTESTS = \ devinst.c \ --- a/dlls/setupapi/devinst.c 2006-08-28 20:35:44.000000000 +0200 +++ b/dlls/setupapi/devinst.c 2006-08-31 22:27:19.000000000 +0200 @@ -1413,6 +1413,7 @@ PVOID Reserved) { LPWSTR lpGuidString; + LPWSTR lpBracedGuidString; HKEY hClassesKey; HKEY hClassKey; LPCWSTR lpKeyName; @@ -1453,21 +1454,30 @@ if (UuidToStringW((UUID*)ClassGuid, &lpGuidString) != RPC_S_OK) { RegCloseKey(hClassesKey); - return FALSE; + return INVALID_HANDLE_VALUE; } + lpBracedGuidString = (LPWSTR) HeapAlloc(GetProcessHeap(), 0, + (1 + strlenW(lpGuidString) + 1 + 1) * sizeof(WCHAR)); + lpBracedGuidString[0] = (WCHAR) '{'; + memcpy(&lpBracedGuidString[1], lpGuidString, + strlenW(lpGuidString) * sizeof(WCHAR)); + lpBracedGuidString[1 + strlenW(lpGuidString)] = (WCHAR) '}'; + lpBracedGuidString[1 + strlenW(lpGuidString) + 1] = (WCHAR) 0; + RpcStringFreeW(&lpGuidString); + if (RegOpenKeyExW(hClassesKey, - lpGuidString, + lpBracedGuidString, 0, KEY_ALL_ACCESS, &hClassKey)) { - RpcStringFreeW(&lpGuidString); + RpcStringFreeW(&lpBracedGuidString); RegCloseKey(hClassesKey); - return FALSE; + return INVALID_HANDLE_VALUE; } - RpcStringFreeW(&lpGuidString); + RpcStringFreeW(&lpBracedGuidString); RegCloseKey(hClassesKey); return hClassKey; --- a/dlls/setupapi/tests/devinst.c 2006-08-28 20:35:53.000000000 +0200 +++ b/dlls/setupapi/tests/devinst.c 2006-08-31 22:14:36.000000000 +0200 @@ -26,6 +26,7 @@ #include "wingdi.h" #include "winuser.h" #include "winreg.h" +#include "rpc.h" #include "setupapi.h" #include "wine/test.h" @@ -34,6 +35,7 @@ static HMODULE hSetupAPI; static HDEVINFO (WINAPI *pSetupDiCreateDeviceInfoListExW)(GUID*,HWND,PCWSTR,PVOID); static BOOL (WINAPI *pSetupDiDestroyDeviceInfoList)(HDEVINFO); +static HKEY (WINAPI *pSetupDiOpenClassRegKeyExW)(GUID*,REGSAM,DWORD,PCWSTR,PVOID); static void init_function_pointers(void) { @@ -43,6 +45,7 @@ { pSetupDiCreateDeviceInfoListExW = (void *)GetProcAddress(hSetupAPI, "SetupDiCreateDeviceInfoListExW"); pSetupDiDestroyDeviceInfoList = (void *)GetProcAddress(hSetupAPI, "SetupDiDestroyDeviceInfoList"); + pSetupDiOpenClassRegKeyExW = (void *)GetProcAddress(hSetupAPI, "SetupDiOpenClassRegKeyExW"); } } @@ -79,6 +82,86 @@ ok(ret, "SetupDiDestroyDeviceInfoList failed : %ld\n", error); } +static void test_SetupDiOpenClassRegKeyExW() +{ + GUID guid; + RPC_STATUS rpcStatus; + HKEY hkey; + WCHAR *unbracedGuid; + WCHAR *bracedGuid; + + rpcStatus = UuidCreate(&guid); + if (rpcStatus != RPC_S_OK) + { + ok(FALSE, "failed to generate test guid, error %ld", rpcStatus); + return; + } + + /* Check return value for non-existant key */ + hkey = pSetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS, + DIOCR_INSTALLER, NULL, NULL); + ok(hkey == INVALID_HANDLE_VALUE, + "invalid return value %p from SetupDiOpenClassRegKeyExW " + "for non-existant key, expected %p\n", hkey, INVALID_HANDLE_VALUE); + + rpcStatus = UuidToStringW(&guid, &unbracedGuid); + if (rpcStatus != RPC_S_OK) + { + ok(FALSE, "failed to get string form of guid, error %ld", rpcStatus); + return; + } + + bracedGuid = HeapAlloc(GetProcessHeap(), 0, + (lstrlenW(unbracedGuid) + 3) * sizeof(WCHAR)); + if (bracedGuid != NULL) + { + HKEY classesKey; + + bracedGuid[0] = (WCHAR) '{'; + memcpy(&bracedGuid[1], unbracedGuid, + lstrlenW(unbracedGuid) * sizeof(WCHAR)); + bracedGuid[1 + lstrlenW(unbracedGuid)] = (WCHAR) '}'; + bracedGuid[1 + lstrlenW(unbracedGuid) + 1] = (WCHAR) 0; + + SetLastError(0xdeadbeef); + classesKey = pSetupDiOpenClassRegKeyExW(NULL, KEY_ALL_ACCESS, + DIOCR_INSTALLER, NULL, NULL); + ok(classesKey != INVALID_HANDLE_VALUE, + "failed to open the device classes registry key: error %ld\n", + GetLastError()); + if (classesKey != INVALID_HANDLE_VALUE) + { + DWORD ret; + HKEY classKey; + ret = RegCreateKeyW(classesKey, bracedGuid, &classKey); + if (ret == ERROR_SUCCESS) + { + RegCloseKey(classKey); + SetLastError(0xdeadbeef); + classKey = pSetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS, + DIOCR_INSTALLER, NULL, NULL); + ok(classKey != INVALID_HANDLE_VALUE, + "failed opening class key, error %ld\n", GetLastError()); + ret = RegCloseKey(classKey); + ok(ret == ERROR_SUCCESS, + "failed closing class key, error %ld\n", ret); + + RegDeleteKeyW(classesKey, bracedGuid); + } + else + ok(FALSE, "failed creating device key: error %ld\n", ret); + + RegCloseKey(classesKey); + } + + HeapFree(GetProcessHeap(), 0, bracedGuid); + } + else + ok(FALSE, "failed to allocate memory for braced guid\n"); + + RpcStringFreeW(&unbracedGuid); +} + START_TEST(devinst) { init_function_pointers(); @@ -88,5 +171,10 @@ if (pSetupDiCreateDeviceInfoListExW && pSetupDiDestroyDeviceInfoList) test_SetupDiCreateDeviceInfoListEx(); else - trace("Needed calls not all available, skipping tests.\n"); + trace("Needed calls for SetupDiCreateDeviceInfoListEx not all available, skipping test.\n"); + + if (pSetupDiOpenClassRegKeyExW) + test_SetupDiOpenClassRegKeyExW(); + else + trace("Needed call for SetupDiOpenClassRegKeyExW not available, skipping test.\n"); }

6 5

Re: user: test and fix SwitchToThisWindow [2nd try]
by James Hawkins Sept. 7, 2006

Sept. 7, 2006

On 9/7/06, Jan Zerebecki <jan.wine(a)zerebecki.de> wrote: > Bugreport about this patch: http://bugs.winehq.org/show_bug.cgi?id=5725 > I compiled-tested this and successfully ran the test on wine and > (thx kblin) on native, because the author said that he is not > able to compile wine. > > If this patch is rejected from inclusion, please tell me why, as > I would have to ask anyway. > > From: Neil Rashbrook <neil(a)parkwaycc.co.uk> > Changelog: > user: test and fix SwitchToThisWindow > > --- > > dlls/user/tests/Makefile.in | 1 > dlls/user/tests/win_sttw.c | 127 +++++++++++++++++++++++++++++++++++++++++++ > dlls/user/winpos.c | 15 +++++ > 3 files changed, 142 insertions(+), 1 deletions(-) > > diff --git a/dlls/user/tests/Makefile.in b/dlls/user/tests/Makefile.in > index 7a78a5b..4e10563 100644 > --- a/dlls/user/tests/Makefile.in > +++ b/dlls/user/tests/Makefile.in > @@ -23,6 +23,7 @@ CTESTS = \ > sysparams.c \ > text.c \ > win.c \ > + win_sttw.c \ > winstation.c \ > wsprintf.c > Why is this in a new file? It should be in win.c. -- James Hawkins

1 0

Google SOC projects Success/Failure
by Vijay Kiran Kamuju Sept. 6, 2006

Sept. 6, 2006

Hi, As the Google SOC concluded. We need to evaluate whether our SOC projects were successfull or not. Some of them got through like Oleview, Trash implementation, riched20 improvisation. I really dont know about the clamav integration, shell integration (there were some patches regarding this I think), improve mswscock.dll and ntlm using gensec. Wineconf is about to start, I think we need to re-think what might be good additions and how should we proceed for 1.0 release. I see about 50-60% success in the SOC - 2006. There were a lotta widl improvements, this thing should have been a SOC project ;) Please feel to comment on this. Thanks, VJ

2 1

Wineconf 06 Keysigning
by David Gümbel Sept. 6, 2006

Sept. 6, 2006

Hi, at Wineconf 2005, we've had a quite successful GPG key signing party. Thus, I'd like to volunteer for organizing a GPG keysigning party at Wineconf 2006 as well. Quoting last year's party organizer (Shachar Shemesh), anyone who wishes to participate, please: 1. Have a PGP key. You can generate one for yourself using gpg. 2. Send the PGP (public) key and its finger print to me AT THE VERY LATEST ON TUESDAY 12. Any later then that, and it is not certain that we'll manage to get your key on the printed piece of paper that is necessary for carrying out the party. 3. Bring a copy you can trust to wineconf, to make sure other people are really signing your key (i.e. - that I'm not pulling anybody's leg). 4. Bring an identifying ID to wineconf. Two is preferable. Passport or a driver license in a language people can read. If you can only bring one, a passport is definitely preferable. The full details of what a key signing party is, why are the procedures as they are, and what's so important about *not* signing the keys with your laptop at the party can be found at http://www.cryptnet.net/fdp/crypto/gpg-party.html Note: No aliases on PGP keys. If your PGP key says "lord master of compiler optimization", then your passport had better say the same or no one will be able to sign your key. Also, if you DON'T want the key published to a key server, please let me know well in advance. Obviously, your key will be published to all the people present at the key party. If your name's not there on your email headers, include it in the body. The name must be the same as appears on your formal IDs. The purpose of a pgp signing party is to establish a link between your virtual identity (your key) and your real one (as verified by an ID). For that reason it is impossible to participate by proxy, or under an alias. Cheers David

1 0

Re: regedit: also refresh the listview
by Vitaliy Margolen Sept. 6, 2006

Sept. 6, 2006

Jan Zerebecki wrote: > case ID_VIEW_REFRESH: > RefreshTreeView(g_pChildWnd->hTreeWnd); > - /*RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); */ > + RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); > break; There was a reason why it was commented in the first place. Please indicate what has changed that you can enable it now. Vitaliy.

2 1

Re: LOSTWAGES: press update
by Paul Vriens Sept. 6, 2006

Sept. 6, 2006

On Wed, 2006-09-06 at 12:58 -0400, Tom Wickline wrote: > Hello, > > If I overlooked something send me the link. > > Tom > > Changelog: update the press page Hi Tom, the latest edition of Tux Magazine (http://www.tuxmagazine.com/) has some stuff about CrossOver Office, Cedega and Wine. Cheers, Paul.

2 1

winehq.org Announcements
by EA Durbin Sept. 6, 2006

Sept. 6, 2006

Why is there no release announcement for the 0.9.20 release of wine on the homepage?

4 4

Re: LOSTWAGES: who's who
by Christoph Frick Sept. 6, 2006

Sept. 6, 2006

On Wed, Sep 06, 2006 at 10:21:42AM -0400, Tom Wickline wrote: > -<h3>Jason Edmeades</h3><blockquote> > -<h3>Jukka Heinonen</h3><blockquote> > -<h3>Ove Kåven</h3><blockquote> > -<h3>Shachar Shemesh</h3><blockquote> > -<h3>Oliver Stieber</h3><blockquote> > -<h3>Greg Turner</h3><blockquote> would it not be more kind to move the "veterans" into their own section instead of removing them at all? at least they managed to get in this list by their previous contributions to the project. please ignore this, if i intercepted with this mail further patches in that direction ;) -- cu

2 1