January 2007 - Wine-Devel - list.winehq.org

Re: [ws2_32] INET_ADDRSTRLEN (1/2) add INET_ADDRSTRLEN and INET_ADDRSTRLEN6
by Francois Gouget Jan. 30, 2007

Jan. 30, 2007

On Tue, 30 Jan 2007, Damjan Jovanovic wrote: > Changelog: > * Added INET_ADDRSTRLEN and INET_ADDRSTRLEN6 defines. > > --- a/include/ws2tcpip.h 2006-11-24 18:18:04.000000000 +0200 > +++ b/include/ws2tcpip.h 2007-01-26 21:14:25.000000000 +0200 > @@ -204,6 +204,9 @@ > # define WS_EAI_SOCKTYPE WSAESOCKTNOSUPPORT > #endif > > +#define INET_ADDRSTRLEN 16 > +#define INET6_ADDRSTRLEN 46 The PSDK says that the values for these are respectively 22 and 65. Also the latest PSDK defines these in ws2ipdef.h which is a new header which is included from ws2tcpip.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

Re: Make.rules.in: Generate better output
by Francois Gouget Jan. 30, 2007

Jan. 30, 2007

On Tue, 30 Jan 2007, Bang Jun-Young wrote: > It's quite annoying to see tons of ugly "gcc -I. -I. -I../../include > -I../../include" > on the screen during build and in the log file thereafter, so... [...] > +ifeq ($(TOPSRCDIR),$(TOPOBJDIR)) > +ifeq ($(SRCDIR),.) > +INCLUDES = -I. -I$(TOPSRCDIR)/include $(EXTRAINCL) 'ifeq' is a GNU Make extension and thus the policy is to avoid it, especially for purely cosmetic issues. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

1 0

Another report of malware running on Wine
by Dan Kegel Jan. 30, 2007

Jan. 30, 2007

A user reports that a trojan horse runs ok on wine, and indeed it had him fooled (right up to the point where it popped up a window offering to optimize his registry, anyway): http://www.postproductie.nl/?p=9

2 1

Please help me debug wineserver
by Misha Koshelev Jan. 29, 2007

Jan. 29, 2007

Hi, I am new to wine programming but have a fair amount of experience with C/C++ programming in general. I have recently decided to make the Vector NTI application work on Wine, and after overcoming quite a few installation difficulties by making an install shell script, I have run in to a problem that I have traced down to wineserver. This problem occurs after repeatedly changing folders in the Vector NTI "Open Molecule File" dialog, which does not use the standard open file Windows dialog (e.g., the "Open Shortcut" dialog in the same program works fine). Wineserver crashes with the following error message: wineserver: object.c:274: release_object: Assertion `obj->refcount' failed. On looking at the output of WINEDEBUG=+server, it seems that the "Vector NTI" thread is woken up, and then receives a USER_APC, at which time this crash occurs. I am including at the end of this message a wineserver gdb backtrace and the last few lines of the WINEDEBUG=+server output. If anyone sees anything that jumps out, I would appreciate your help. Thank you very much. Misha --- Backtrace: #0 0xffffe410 in __kernel_vsyscall () #1 0xb7d56770 in raise () from /lib/tls/i686/cmov/libc.so.6 #2 0xb7d57ef3 in abort () from /lib/tls/i686/cmov/libc.so.6 #3 0xb7d4fdbb in __assert_fail () from /lib/tls/i686/cmov/libc.so.6 #4 0x0805ad0a in release_object (ptr=0x83ad0a0) at object.c:274 #5 0x0806c196 in end_wait (thread=0x83ad100) at thread.c:451 #6 0x0806c9b7 in wake_thread (thread=0x83ad100) at thread.c:578 #7 0x0806cddd in queue_apc (process=<value optimized out>, thread=0x83ad100, apc=0x83ad888) at thread.c:751 #8 0x0806cebb in thread_queue_apc (thread=0x83ad100, owner=0x0, call_data=0xbffe77b8) at thread.c:764 #9 0x08052dc2 in async_terminate (async=0x82e7780, status=6) at fd.c:1294 #10 0x0804bf70 in dir_destroy (obj=0x83ad0a0) at file.h:131 #11 0x0805ac9a in release_object (ptr=0x83ad0a0) at object.c:279 #12 0x0806c196 in end_wait (thread=0x83ad100) at thread.c:451 #13 0x0806cf30 in thread_timeout (ptr=0x83aa1c0) at thread.c:598 #14 0x08051e3a in get_next_timeout () at fd.c:688 #15 0x08052ea0 in main_loop () at fd.c:456 #16 0x08057c4a in main (argc=2, argv=0xbffe8034) at main.c:136 Last few lines of WINEDEBUG=+server output: 0009: create_key() = 0 { hkey=0x168, created=0 } 0009: get_key_value( hkey=0x168, name=L"Desktop" ) 0009: get_key_value() = 0 { type=2, total=44, data={25,00,55,00,53,00,45,00,52,00,50,00,52,00,4f,00,46,00,49,00,4c,00,45,00,25,00,5c,00,44,00,65,00,73,00,6b,00,74,00,6f,00,70,00,00,00} } 0009: create_key( parent=0x6c, access=000f003f, attributes=00000000, options=00000000, modif=0, namelen=112, name=L"Software\\Microsoft\\Windows NT\\CurrentVersion\\ProfileList", class=L"" ) 0009: create_key() = 0 { hkey=0x16c, created=0 } 0009: get_key_value( hkey=0x16c, name=L"ProfilesDirectory" ) 0009: get_key_value() = 0 { type=2, total=40, data={63,00,3a,00,5c,00,77,00,69,00,6e,00,64,00,6f,00,77,00,73,00,5c,00,70,00,72,00,6f,00,66,00,69,00,6c,00,65,00,73,00,00,00} } 0011: *wakeup* signaled=258 STATUS_TIMEOUT cookie=0x7bbfe880 0011: *wakeup* signaled=192 STATUS_USER_APC cookie=0x7bbfe880 wineserver: object.c:274: release_object: Assertion `obj->refcount' failed.

1 0

Re: Test case for Bug 50 [Was: Bug 50]
by Pedro Araujo Chaves Jr. Jan. 29, 2007

Jan. 29, 2007

I think I've managed to patch [1] bug 50 [2], but I'm having a little trouble coming up with a proper test case... I'm already at it, studying and investigating, but could someone test that, too? [1] http://bugs.winehq.org/attachment.cgi?id=4543&action=view [2] http://bugs.winehq.org/show_bug.cgi?id=50 TIA, - Pedro.

2 3

Re: DirectPlay should initialize The session guid when creating a session
by Tomas Carnecky Jan. 29, 2007

Jan. 29, 2007

Alessandro Pignotti wrote: > Hi, > this is my first patch i hope it's well formatted formating is good. > From Microsoft DirectX SDK Documentation it seems that directplay should > initialize the instance guid on session creation, this trivial patch does > that. Two questions: 1. Does windows do this, too? You can't rely on the MS SDK Documentation, always look what windows does and do it likewise. In many cases, a wine test should be written to verify the behavior. 2. Does it solve anything? A bug, a problem with an application? tom

3 2

Wine study
by TRENY Simon Jan. 29, 2007

Jan. 29, 2007

Hello guys :) We are a team of French students (at ENSEIRB, an engineering school in Bordeaux), and we are studying the Wine project as an example of open source project. We'd like to find out more about how things work from the inside, from any developer's point of view. So we have compiled here our main questions for those who are willing to help us.. Feel free to answer further than the actual question, we are looking for a real insight! :) Sorry in advance for those who are not interested, you can just skip this mail ;) -First, what is the nick under which u commit ? -What is your role in the Wine project? -Which country do u code from? -Who are the programmers you consider to be the "core" of the project? -Who are those you actually ask for help when you need some (e.g. about compatibility issues)? -Do you use means of communicating with the rest of the devs other than irc and the mailing lists? Do you find it (irc and MLs) entirely suited to your needs? -When there is a decision concerning the whole team you wish to see taken, how do u see to that? -Have you developed links with some devs that go beyond working on the same project? -How much time do you spend doing Wine developing (per week and per day, depending on the day)? -What do you do aside from Wine? -When, why and how did you join the Wine project? -Is there any recurrent problem you find to be responsible of unnecessary extra work/loss of time for you or the team? Well, thanks for reading, and greater thanks for answering us if you do.. :) Best regards

1 0

kernel32: allow profile section and key names of zero length
by Claudio Fontana Jan. 29, 2007

Jan. 29, 2007

Hello, following up on the profile changes started on this thread: http://www.winehq.org/pipermail/wine-devel/2006-December/053009.html I tried a patch in git format made against latest. First attempt at using git, that is. dlls/kernel32/profile.c: allow section and key names of zero length dlls/kernel32/tests/profile.c: add testcases where KEY or SECTION are "". Note: still requires testing on a real Windows 95, to determine if that version behaves differently. If you have access to a Windows 95 installation, please help by applying this patch and: [optional] * run the updated tests in wine (all should pass) * revert changes in dlls/kernel32/profile.c, and run the updated tests in wine (the two new tests should fail) [important] * run the updated test program under a real Windows 95. If tests pass, then Windows 95 behaves exactly the same as later versions. If tests do not pass, then Windows 95 is indeed different, and this patch should be modified accordingly. --- dlls/kernel32/profile.c | 10 ++-------- dlls/kernel32/tests/profile.c | 8 ++++++-- 2 files changed, 8 insertions(+), 10 deletions(-)

1 0

Vacations
by Alexandre Julliard Jan. 28, 2007

Jan. 28, 2007

Folks, I'm going skiing for a week, so don't be surprised if there aren't any new commits for a while. Now all I need is some snow... -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: USER32: resource.c: add LoadStringW description
by Dmitry Timoshkov Jan. 27, 2007

Jan. 27, 2007

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > Add description for LoadStringW > + * Can be called with buffer = NULL for get size of the requested string That LoadString behaviour in Wine has been questioned already, MSDN keeps silence about that, it needs at least a test case. -- Dmitry.

1 0

Re: [cmd][buildins] Change output resource strings for correctlydisplayed
by Dmitry Timoshkov Jan. 27, 2007

Jan. 27, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- programs/cmd/builtins.c 23 Jan 2007 12:20:55 -0000 1.5 > +++ programs/cmd/builtins.c 26 Jan 2007 09:23:05 -0000 > @@ -44,6 +44,13 @@ struct env_stack > WCHAR *strings; > }; > > +static inline unsigned int strlenW( const WCHAR *str ) > +{ > + const WCHAR *s = str; > + while (*s) s++; > + return s - str; > +} Please use normal lstrlenW instead of introducing a handmade version. -- Dmitry.

1 0

Re: scroll window fix
by Peter Oberndorfer Jan. 26, 2007

Jan. 26, 2007

On Thursday 25 January 2007 18:56, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still falls > within the clipping rect. This generates an additional update region > that needs > to be invalidated. > includes a test Hi, I can't argue about the correctness of the patch itself but it adds tabs and a few trailing spaces. Greetings Peter > --- > dlls/user32/painting.c | 21 +++++++++++++++++++++ > dlls/user32/tests/win.c | 9 +++++++++ > 2 files changed, 30 insertions(+), 0 deletions(-) >

2 1

Re: [PATCH 1/4] widl: Handle TKIND_DISPATCH when generating MSFT typelibs.
by Huw Davies Jan. 26, 2007

Jan. 26, 2007

On Fri, Jan 26, 2007 at 09:13:52PM +0900, Mike McCormack wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 6248c80..576601b 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -126,6 +126,8 @@ typedef struct _msft_typeinfo_t > } msft_typeinfo_t; > > > +static void add_dispinterface_typeinfo(msft_typelib_t *typelib, type_t *dispinterface); Could you move that so it's with all the other forward declarations of add_*_typeinfo funcs (or move all the others to be with this one)? Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Initial MIDI Out support on Mac OS X
by Emmanuel Maillard Jan. 26, 2007

Jan. 26, 2007

Hi, anything wrong with this patch : http://www.winehq.org/pipermail/wine- patches/2007-January/035027.html thanks Emmanuel

1 0

Is anyone monitoring Transgaming's changes to the LGPL files?
by Scott Ritchie Jan. 26, 2007

Jan. 26, 2007

I don't know when it started, but Transgaming has been using LGPL chunks of Wine for quite some time. As they're required to, they've released the source for these files, along with whatever changes they've made. However, they're not required to tell us what they did, to send us patches, or to even let us know they've made a change. What this means is that it's possible, even likely, that Transgaming has improved the LGPL parts of Cedega in some important way that would be useful to Wine as well, without us having even known about it. The simplest thing to do is for someone to just track the code they release and diff it against our own stuff, and note if anything new and interesting (eg an implementation of a function) comes up. Then send in a patch if it seems like it could help us too. But, is anyone doing this? Thanks, Scott Ritchie

3 4

make crosstest broken (tmarshal)
by Stefan Leichter Jan. 25, 2007

Jan. 25, 2007

Hello, the tmarshal tests broke cross compiling. Compiling fails for me with i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o tmarshal.cross.o ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:28:22: tmarshal.h: Datei oder Verzeichnis nicht gefunden ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: type defaults to `int' in declaration of `IWidgetVtbl' ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: no semicolon at end of struct or union ... make[2]: *** [tmarshal.cross.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-mingw/dlls/oleaut32/tests' make[1]: *** [oleaut32/tests/__crosstest__] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls' make: *** [dlls/__crosstest__] Fehler 2 The problem is related to the fact that i'm doing out of tree builds. Therefore i have three directories: 1. wine-git : the source tree 2. wine-build : the normal build (unix) 3. wine-mingw : the cross compile build The missing tmarshal.h file is in wine-build/dlls/oleauth32/tests Bye Stefan

4 8

Patch to make X11DRV_GetAsyncKeyState work for TacOps
by Martin Cracauer Jan. 25, 2007

Jan. 25, 2007

The appended patch against the CVS version fixes one issue for me. The game "TacOps" (a standalone 2D wargame, not to be mixed up with the Unreal mod "Tac Ops") uses home-grown scrollbars. They have autorepeat, that means holding the mouse button on the "down" or "up" icons will continue to scroll until you release the button. Without the appended patch Wine will never notice when you release the mouse button. That effectively means an application hang since you can never do anything else anymore, as the game continue to execute "down" autorepeat. To reproduce, download the demo at http://www.battlefront.com/products/tacops4/demo.html . Set up your units as per the instructions (place from floating window into the grey box). The scrollbars in question are under artillery support and under air support. Clicking on the up/down icons in the scrollbars will hang the application without the patch and will work with the patch. Please mail me if you want a better walkthrough. In case the patch attachment gets stripped by the list I put a copy of the patch here: http://www.cons.org/cracauer/wine-tacops-2.diff Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer(a)cons.org> http://www.cons.org/cracauer/ FreeBSD - where you want to go, today. http://www.freebsd.org/

2 2

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols
by Dmitry Timoshkov Jan. 25, 2007

Jan. 25, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- dlls/kernel32/tests/locale.c 5 Jan 2007 19:37:02 -0000 1.8 > +++ dlls/kernel32/tests/locale.c 24 Jan 2007 14:15:14 -0000 > @@ -35,6 +35,9 @@ > #include "winerror.h" > #include "winnls.h" > > +#include "locale.h" > +#include "tables_CP1251.h" I'd suggest to test specific strings instead of auto-generated tables. Since microsoft apparently uses their own unicode tables that differ from unicode.org ones that's almost impossible to get the exactly same behaviour among Wine and Windows. > +static int compare_string2_non_latin(const void *e1, const void *e2) > +{ > + const char *s1 = (char *)e1; > + const char *s2 = (char *)e2; > + > + return CompareStringA(LOCALE_USER_DEFAULT,0,s1,1, s2,1) - 2; > +} You need to directly specify the locale id, otherwise the test won't pass on a system with different user default locale (like the Alexandre's one). -- Dmitry.

2 2

Debian Etch package
by Paavo Pokkinen Jan. 25, 2007

Jan. 25, 2007

Hi, I would like to maintain latest Debian Etch(to-be-stable in about month) packages for wine. The download page says "If you can help provide up-to-date Debian packages, please contact Scott Ritchie", but I already contacted, maybe month ago. Didn't get any answer. The debs are located http://blitzkrieg.homelinux.org/~paveq/wine/ I got enough bandwith(10Mb) to host them myself. Comments? -- Paavo Pokkinen paveq2(a)gmail.com

3 2

Re: cabinet: Fix overrun of static array (Coverity)
by Alexandre Julliard Jan. 25, 2007

Jan. 25, 2007

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > This patch is aimed at fixing Coverity CID-297. The existing code writes > 52 values to a 51-value array. The patch code only writes the first 51. > > Please let me know what is wrong with this patch. It may well be correct, but I think both the old and the new code are very confusing. Initializing this from a static constant would be a lot cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [try 4] slist support (2/2) slist declarations and functions
by Mike McCormack Jan. 25, 2007

Jan. 25, 2007

Damjan Jovanovic wrote: > diff -ur a/include/winbase.h b/include/winbase.h > --- a/include/winbase.h 2007-01-12 20:59:52.000000000 +0200 > +++ b/include/winbase.h 2007-01-24 20:42:35.000000000 +0200 I would recommend you at least split the modifications to winbase into a separate patch, as they are not dependent on your implementation. Mike

1 0

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols
by Mike McCormack Jan. 25, 2007

Jan. 25, 2007

Anatoly Lyutin wrote: > Changelog: Add test for CompareStringA for non latin symbols. Hmm. > + if (0) test_sorting_non_latin(); Adding a test that won't run... > +/* If you want to get the source code of the program generating a file, > + * please write to me on vostok(a)etersoft.ru. > + * Automatically generated file; DO NOT EDIT!! > + */ without the source code to generate the test data... Seems like it's unlikely this patch will be accepted. What exactly are you trying to show? Mike

1 0

Re: winex11.drv: Copy the GL extensions string because it may be freed.
by Chris Robinson Jan. 25, 2007

Jan. 25, 2007

On Wednesday 24 January 2007 21:51, Ken Thomases wrote: > + WineGLInfo.glExtensions = strdup((const char *) pglGetString(GL_EXTENSIONS)); Shouldn't this be free'd somewhere? What about the other strings?

2 1

Re: Tests for NtCreateMailslotFile
by Vitaliy Margolen Jan. 25, 2007

Jan. 25, 2007

Jeff Latimer wrote: > This is the first of some tests for NtCreateMailslotFile. I have > included them in kernel32/tests as I thought it better that the Mailslot > tests be collocated. Why do you need to test NtCreateMailslotFile directly? Why can't you use CreateMailslot instead? Vitaliy.

2 1

Re: cmdlg32: update Russian translation
by Dmitry Timoshkov Jan. 25, 2007

Jan. 25, 2007

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changes: > Done Russian translation PD32_NO_DEVICES translation is missing a comma after 'Проверьте'. IDS_COLOR_MAROON translation has a spelling error. -- Dmitry.

1 0