January 2007 - Wine-Devel - list.winehq.org

memory corruption in dlls/oleaut32/olepicture.c?
by Damjan Jovanovic Jan. 9, 2007

Jan. 9, 2007

Hi In dlls/oleaut32/olepicture.c, there are several places where memory is allocated and then used immediately, without checking whether allocation succeeded. For example: 1479 xbuf = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, origsize); 1480 if (headerisdata) 1481 memcpy (xbuf, &header, 8); Is there something I'm missing, or does that sort of code lead to memory corruption / segmentation faults when allocating memory fails? >From what I see on http://people.redhat.com/mstefani/wine/smatch/bugs_all.html, smatch doesn't detect this as an error. What should we do? Damjan

2 1

RawInput
by Michał Majchrowicz Jan. 9, 2007

Jan. 9, 2007

Hi. I am trying to write functions for RawInput in wine. If understand correctly GetRawInputDeviceList function gives us an array of rawinputdevice's registered with function RegisterRawInputDevices. So implementing it would be just geting and setting data in array. But I have two question: 1) Where should i put this array? In which file? 2) How can I get data to fill the begining of the array (according to my tests when Windows has only mouse and keyboard connected there are 4 input devices) Regards Michael.

2 1

Re: Proposed patch for "fonts.c"
by Marcus Meissner Jan. 9, 2007

Jan. 9, 2007

On Mon, Jan 08, 2007 at 11:49:49PM +0100, Bernard Choppy wrote: > Good day, > > online(a)noteworthysoftware.com sent a patch covering bug 7040 I've initiated. > > The problem is that wine doesn't handle properly Symbol-encoded fonts, > which makes rendering of special fonts (in this case, music notation for > the NoteWorthy version 2 softwares) inaccurate. > > I suppose he will sent this patch too, but to make sure, please find it > here. > > 352c352 > < static LPWSTR FONT_mbtowc(LPCSTR str, INT count, INT *plenW) > --- > > static LPWSTR FONT_mbtowc(HDC hdc, LPCSTR str, INT count, INT *plenW) Please use "diff -u". Ciao, Marcus

1 0

Re: appdb/ ./account.php ./addcomment.php ./appbro ...
by Tony Lambregts Jan. 9, 2007

Jan. 9, 2007

WineHQ wrote: > ChangeSet ID: 30851 > CVSROOT: /opt/cvs-commit > Module name: appdb > Changes by: wineowner(a)winehq.org 2007/01/03 20:35:02 > > Modified files: > . : account.php addcomment.php appbrowse.php > appimage.php appsubmit.php appview.php > browse_by_rating.php browse_newest_apps.php > commentview.php deletecomment.php > distributionView.php maintainerdelete.php > maintainersubmit.php preferences.php > screenshots.php search.php testResults.php > vendorview.php viewScreenshots.php viewbugs.php > votestats.php > admin : addAppNote.php addCategory.php > adminAppDataQueue.php adminAppQueue.php > adminBugs.php adminCommentView.php > adminMaintainerQueue.php adminMaintainers.php > adminScreenshots.php adminTestResults.php > adminUsers.php deleteAny.php editAppFamily.php > editAppNote.php editAppVersion.php > editBundle.php editDistribution.php > editVendor.php moveAppVersion.php > help : index.php > include : application.php bugs.php comment.php > distribution.php filter.php form_edit.php > form_login.php form_new.php incl.php note.php > screenshot.php sidebar.php testData.php url.php > util.php version.php vote.php > > Log message: > Chris Morgan <cmorgan(a)alum.wpi.edu> > Fix and enable input filtering through include/filter.php > > Patch: http://cvs.winehq.org/patch.py?id=30851 > > Old revision New revision Changes Path > 1.34 1.35 +0 -1 appdb/account.php > 1.33 1.34 +0 -1 appdb/addcomment.php > 1.22 1.23 +0 -1 appdb/appbrowse.php > 1.28 1.29 +0 -1 appdb/appimage.php > 1.57 1.58 +6 -20 appdb/appsubmit.php > 1.96 1.97 +0 -8 appdb/appview.php > 1.1 1.2 +0 -1 appdb/browse_by_rating.php > 1.2 1.3 +0 -1 appdb/browse_newest_apps.php > 1.15 1.16 +0 -1 appdb/commentview.php > 1.30 1.31 +0 -1 appdb/deletecomment.php > 1.22 1.23 +0 -1 appdb/distributionView.php > 1.24 1.25 +0 -7 appdb/maintainerdelete.php > 1.33 1.34 +0 -7 appdb/maintainersubmit.php > 1.33 1.34 +3 -25 appdb/preferences.php > 1.41 1.42 +0 -1 appdb/screenshots.php > 1.21 1.22 +0 -1 appdb/search.php > 1.22 1.23 +2 -10 appdb/testResults.php > 1.23 1.24 +0 -1 appdb/vendorview.php > 1.7 1.8 +0 -1 appdb/viewScreenshots.php > 1.10 1.11 +0 -1 appdb/viewbugs.php > 1.27 1.28 +0 -1 appdb/votestats.php > 1.30 1.31 +1 -8 appdb/admin/addAppNote.php > 1.15 1.16 +0 -8 appdb/admin/addCategory.php > 1.30 1.31 +0 -9 appdb/admin/adminAppDataQueue.php > 1.69 1.70 +6 -21 appdb/admin/adminAppQueue.php > 1.14 1.15 +0 -9 appdb/admin/adminBugs.php > 1.16 1.17 +0 -5 appdb/admin/adminCommentView.php > 1.35 1.36 +0 -8 appdb/admin/adminMaintainerQueue.php > 1.28 1.29 +0 -5 appdb/admin/adminMaintainers.php > 1.16 1.17 +0 -9 appdb/admin/adminScreenshots.php > 1.17 1.18 +1 -6 appdb/admin/adminTestResults.php > 1.13 1.14 +0 -9 appdb/admin/adminUsers.php > 1.22 1.23 +0 -8 appdb/admin/deleteAny.php > 1.43 1.44 +0 -5 appdb/admin/editAppFamily.php > 1.29 1.30 +2 -9 appdb/admin/editAppNote.php > 1.41 1.42 +0 -6 appdb/admin/editAppVersion.php > 1.15 1.16 +10 -10 appdb/admin/editBundle.php > 1.11 1.12 +1 -7 appdb/admin/editDistribution.php > 1.15 1.16 +0 -6 appdb/admin/editVendor.php > 1.11 1.12 +0 -6 appdb/admin/moveAppVersion.php > 1.10 1.11 +5 -5 appdb/help/index.php > 1.82 1.83 +5 -11 appdb/include/application.php > 1.19 1.20 +4 -6 appdb/include/bugs.php > 1.31 1.32 +1 -4 appdb/include/comment.php > 1.3 1.4 +2 -6 appdb/include/distribution.php > 1.8 1.9 +13 -8 appdb/include/filter.php > 1.10 1.11 +0 -3 appdb/include/form_edit.php > 1.8 1.9 +0 -4 appdb/include/form_login.php > 1.10 1.11 +0 -6 appdb/include/form_new.php > 1.38 1.39 +8 -1 appdb/include/incl.php > 1.20 1.21 +1 -7 appdb/include/note.php > 1.53 1.54 +1 -3 appdb/include/screenshot.php > 1.24 1.25 +3 -5 appdb/include/sidebar.php > 1.15 1.16 +6 -12 appdb/include/testData.php > 1.10 1.11 +2 -6 appdb/include/url.php > 1.77 1.78 +40 -38 appdb/include/util.php > 1.90 1.91 +5 -9 appdb/include/version.php > 1.23 1.24 +1 -5 appdb/include/vote.php > > This patch breaks xinha editing... -- Tony Lambregts

3 4

Re: comctl32: Rewrite the up-down control tests to add message checking
by Dmitry Timoshkov Jan. 9, 2007

Jan. 9, 2007

"James Hawkins" <truiken(a)gmail.com> wrote: > + if ((expected->flags & defwinproc) != (actual->flags & defwinproc) && todo) > + { > + todo_wine > + { > + failcount++; > + ok_(file, line) (FALSE, > + "%s: in msg 0x%04x expecting lParam 0x%lx got 0x%lx\n", > + context, expected->message, expected->lParam, actual->lParam); > + } > + } This is an old typo/misleading message that I've fixed in the original msg.c code. -- Dmitry.

1 0

Re: [user32][test] Add test for messageboxes
by Dmitry Timoshkov Jan. 9, 2007

Jan. 9, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > + thread = CreateThread( NULL, 0, create_messagebox_thread, &info, 0, &tid ); > + while(info.hWndDlg == NULL) > + info.hWndDlg = FindWindowA(NULL,info.ch); This is too hackish IMO, if dialog creation fails for some reason the test will hang. > + > + PostMessageA(info.hWndDlg,WM_COMMAND,IDCANCEL,0); > + Sleep(nTimeOut); > + if(info.ret==-1) > + SendMessageA(info.hWndDlg,WM_COMMAND,Data[i].nExitMessage,(LPARAM)GetDlgItem( info.hWndDlg, > Data[i].nExitMessage )); Why don't you check whether 'info.ret==-1' is a legitimate response or not? > + Sleep(nTimeOut); > + ok(info.ret == Data[i].nReact,"This dialogue has incorrect reaction on IDCANCEL!\n"); > + CloseHandle( thread ); > + } > +} And these Sleep() calls are potential races. -- Dmitry.

1 0

Re: Add tests to odbccp32
by Detlef Riekenberg Jan. 8, 2007

Jan. 8, 2007

On Mo, 2007-01-08 at 09:58 -0800, Bill Medland wrote: > Bill Medland (billmedland(a)shaw.ca) > Add tests structure to odbccp32 > +START_TEST(error) > +{ > +} We really need more tests, but I do not think, that an empty testfile can go in the tree. And as another hint, you should use the same filename. You might want to look, how I add the tests for "localspl.dll": I use the testfile "dlls/localspl/tests/localmon.c" to test the implementation of "dlls/localspl/localmon.c" The History for the tests: http://source.winehq.org/git/wine.git/?a=history;f=dlls/localspl/tests My Patch for the initial test: http://www.winehq.org/pipermail/wine-patches/2006-September/031009.html -- By by ... Detlef

1 0

Compilation problem during regression testing
by L. Rahyen Jan. 8, 2007

Jan. 8, 2007

I'm doing regression testing of Hogia software and have following compilation problem near wine-0.9.12: ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./ddraw.spec d3d_utils.o device_main.o device_opengl.o direct3d_main.o direct3d_opengl.o executebuffer.o light.o material.o opengl_utils.o texture.o vertexbuffer.o viewport.o clipper.o ddraw_hal.o ddraw_main.o ddraw_thunks.o ddraw_user.o ddraw_utils.o main.o palette_hal.o palette_main.o regsvr.o surface_dib.o surface_fakezbuffer.o surface_gamma.o surface_hal.o surface_main.o surface_thunks.o surface_user.o surface_wndproc.o version.res -Wl,--rpath, \$ORIGIN/`../../tools/relpath /usr/local/lib/wine /usr/local/lib` -o ddraw.dll.so -L../../dlls -lole32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -L../../libs -lwine -ldxguid -luuid -lSM -lICE -lXxf86vm -lXext -lX11 -L../../libs/port -lwine_port surface_dib.o: In function `create_dib': /var/pkgs/wine/wine-git.experimental/dlls/ddraw/surface_dib.c:159: undefined reference to `DIB_CreateDIBSection' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [ddraw.dll.so] Error 2 make[2]: Leaving directory `/var/pkgs/wine/wine-git.experimental/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/var/pkgs/wine/wine-git.experimental/dlls' make: *** [dlls] Error 2 Any idea how to resolve this? I tried to compile with 3.4.6 and 4.1.2 - same result.

1 0

Re: [try 3] systray patches
by Kirill K. Smirnov Jan. 8, 2007

Jan. 8, 2007

Please, explain me, what is wrong with this serie of patches? What to do to improve them? http://www.winehq.org/pipermail/wine-patches/2007-January/034408.html http://www.winehq.org/pipermail/wine-patches/2007-January/034409.html http://www.winehq.org/pipermail/wine-patches/2007-January/034410.html http://www.winehq.org/pipermail/wine-patches/2007-January/034412.html http://www.winehq.org/pipermail/wine-patches/2007-January/034413.html Regards, Kirill K. Smirnov

2 1

Re: [Fwd: patch for bz 6855]
by James Hawkins Jan. 8, 2007

Jan. 8, 2007

On 1/7/07, Neil Marko <nmarko(a)isyssoft.com> wrote: > Very sorry, I meant 0.9.28 and I forgot the patch!!! > > Hope this helps. > > Neil Marko > > -------- Original Message -------- > Subject: patch for bz 6855 > Date: Sun, 07 Jan 2007 17:42:56 -0500 > From: Neil Marko <nmarko(a)isyssoft.com> > To: wine-patches(a)winehq.org > > > > Hi all: > > Sorry that this is not in GIT format. I do not have the time to learn > this. I just wanted to get Off2K installed on 9.2.28. > > My determination of this bug is that around version 9.2.20 or so, > dlls/msi/files.c was rewritten. This bug seems to come from that. In > the routine ACTION_InstallFiles, there is a loop of all the file > objects. The first few steps of that loop attempt to detect a media > change. That ultimately causes a call to load_media_info. The select > statement in load_media_info has a where clause where table column > LastSequence is greater than the value of the current file. The problem > I detected is that what is selected in the first pass through the loop > is the media for the next sequence (COMCTL.OCX) and not the current > file. When a successful select occurs, the value of mi->last_sequence > is updated from the select row, which is obviously not correct. When we > loop eventually to the file structure where we should have a media > change (COMCTL.OCX), we do not do the media change and then we do not > extract the compressed file and the install fails. I solved this by > simply setting mi->last_sequence to file->Sequence in the loop in > ACTION_InstallFiles. > > It is possible that maybe changing the ">=" to a "=" in the select in > load_media_info might also solve this but I do not have enough knowledge > about msi to know if that could cause any other problems. I think we > would also have to change the error condition so that not reading rows > there would not cause a failure. That seemed like a lot more work! > > I eventually successfully installed Off2K on 9.2.28 with this. > (Eventually since I have only an "upgrade" version of Off2K and > therefore, some of the registry was not setup correctly. I made it work.) > It would be great if you could add a test for this case to dlls/msi/tests/install.c. That way we can verify that the fix is correct. Thanks, James Hawkins

1 0

Re: Add tests to odbccp32
by James Hawkins Jan. 8, 2007

Jan. 8, 2007

On 1/8/07, Bill Medland <billmedland(a)shaw.ca> wrote: > Bill Medland (billmedland(a)shaw.ca) > Add tests structure to odbccp32 > You need to add tests for this patch to be accepted. Also, you've labeled the test suite 'error'. How many functions in odbccp32 are you planning on testing in this file? I see only SQLInstallerError and SQLPostInstallerError in the spec file, which is not enough to warrant a whole test file. Please read other test files to get a better of idea what needs to happen with these tests. -- James Hawkins

2 4

Re: dinput, wheel/joystick and richard burns rally
by Vitaliy Margolen Jan. 8, 2007

Jan. 8, 2007

Christoph Frick wrote: > On Mon, Jan 08, 2007 at 10:28:22AM -0700, Vitaliy Margolen wrote: > >> That is correct. I already fixed mouse and keyboard the proper way. >> Now left to fix joysticks. It seems joysticks are in the worse shape >> that I thought. Number of places using wrong object indexes. > > does that mean, you are already working in this area? > Well I've been looking at what will it take to fix it. Also made few patches for EnumObjects and GetObjectInfo. But I can't send those, because other parts using wrong indexes. And it will really brake things (but should fix the problem Tuomo was talking about). If you want to pick it up, I can move on to something else. Vitaliy.

1 0

dinput, wheel/joystick and richard burns rally
by Tuomo Kohvakka Jan. 8, 2007

Jan. 8, 2007

Hello, first, appdb entry: http://appdb.winehq.org/appview.php?iVersionId=5934&iTestingId=6382 As shown there, joystick (that ofcourse really means the wheel :) isn't detected by the game with current wine. I decided to take a look at that, figuring that it might be fixable. Well, I managed to "fix" it. Code follows, dlls/dinput/device.c, create_DataFormat() around line 387 says that && (/* Then check if it accepts any instance id, and if not, if it matches Wine's * instance id. */ ((asked_format->rgodf[j].dwType & DIDFT_INSTANCEMASK) == DIDFT_ANYINSTANCE) || (DIDFT_GETINSTANCE(asked_format->rgodf[j].dwType) == 0x00FF) || /* This is mentionned in no DX docs, but it works fine - tested on WinXP */ (DIDFT_GETINSTANCE(asked_format->rgodf[j].dwType) == DIDFT_GETINSTANCE(format->wine_df->rgodf[i].dwType))) && Now, adding || ((asked_format->rgodf[j].dwType&0xff) == (format->wine_df->rgodf[i]. =>dwType&0xff)) into middle of that fixes it. It works fine and doesn't seem to break anything (didn't try other applications thought). It took me a couple of hours to figure above ou, a few more comments more might have helped! :) (code itself is rather easy to follow) Now, my problem is that I don't really know anything about directx or much about windows anyhow. That means that I don't know if above "fix" is really proper way to fix anything. I figure that purpose of this function make a mapping from devices axes and buttons (wine datastructure) into applications preferred structure (which is used later on in fill_DataFormat). Mapping goes wrong without above, as application requests "3" in dwType and wine has something like 0x80ffff03. It's defined in c_dfDIJoystick2, data_formats.c as DIDFT_OPTIONAL|DIDFT_AXIS|DIDFT_ANYINSTANCE. If mapping goes wrong offset_in becomes -1 and that means that default values will be used (button not pressed etc). (If I would submit a patch containing only comments, some probably wrong guesses, would it be accepted?) Someone here on list probably has more insight on this. What is that dwType anyways? :) Is above fix correct, or should dwType be something else from the beginning with, or am I just completely lost? Bottom line ofcourse is that I would like to see a proper fix in wine .29 that would allow rbr and wheel co-operate :) Should I just try to submit this as a patch? -- Tuomo Kohvakka

3 2

Re: odbccp32 SQLGetInstalledDrivers etc
by Bill Medland Jan. 8, 2007

Jan. 8, 2007

On Fri, 2007-05-01 at 16:14 -0800, Bill Medland wrote: > Bill Medland (billmedland(a)shaw.ca) > Implement SQLGetInstalledDrivers > Implement a basic SQLInstallerError > Add test framework and some initial tests Would it help if this was split into three patches?

1 0

Missing tables in the AppDB dump
by Tony Lambregts Jan. 8, 2007

Jan. 8, 2007

The dump of the AppDB is missing the following tables appMaintainers, buglinks, appHitStats, catHitStats Could someone please add them to the nightly dump. Thanks -- Tony Lambregts

2 1

Re: Stub for GetRawInputDeviceList
by L. Rahyen Jan. 8, 2007

Jan. 8, 2007

Monday January 8 2007 14:35、Michał Majchrowicz さんは書きました: (from the attached file) > A modification of patch found on wine mailing list It checks whether Also, for more information you can mention my name if you wish as initial author of this patch. I know that my patch was silently rejected long time ago - I didn't asked why because I was too busy for some time and... my little patch was simply lost because of this (I wasn't very active because my patch is very small and simple). But some time ago I have received a message from unofficial wine-wiki that it "has a quote based upon your October mailing list post" (actually the patch).

1 1

Re: Stub for GetRawInputDeviceList
by Dmitry Timoshkov Jan. 8, 2007

Jan. 8, 2007

Michal Majchrowicz mmajchrowicz(a)gmail.com wrote: > Everything is in the file :) > Regards. You are using tab == 4 spaces in your editor and that messes up formatting in 2 places in your patch. Also you should leave at least 1 empty line between function implementations like it is in the existing code. -- Dmitry.

1 0

Re: [15/20] WineD3D: Clean up drawprim a bit
by Ivan Gyurdiev Jan. 7, 2007

Jan. 7, 2007

Stefan Dösinger wrote: > Now that almost everything is gone from drawPrimitiveDrawStrided we don't need > a subfunction for calling drawStridedSlow/Fast any longer > I think while we're cleaning up things, all of software shaders should be removed. There's tons of code in drawprim and *shader.c, which is disabled, doesn't work, and isn't on the right track if you ask me. None of the changes to make the shader parser 3.0 compliant are used in the disabled paths. There's even an "Emulation" value in winecfg which just confuses the user, since it doesn't work. I did have a working implementation of software shaders some time ago, which broke things up into functions, and shared the tracing and parser with hardware shaders - but in the end it was too slow, and I abandoned it as the wrong approach too. Unless we generate asm on the fly for the shader or something like that, I don't think software shaders will be made to work soon.

2 2

Re: make_makefiles: Ignore backups of edited files.
by Patrik Stridvall Jan. 7, 2007

Jan. 7, 2007

On Sunday 07 January 2007 13:16, Robert Shearman wrote: > --- > tools/make_makefiles | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Since the "*~" files are not generated by the build process this is perhaps not the right place to do it. Rather each developer should ignore such files by editing the .git/info/exclude file. Works for me! Somebody probably should update the website to make other developers aware of this.

1 0

Re: fix a typo
by Detlef Riekenberg Jan. 6, 2007

Jan. 6, 2007

On Sa, 2007-01-06 at 15:08 +0100, Jonathan Ernst wrote: > (I think) I decided to use "options", because native Ports have: COM*: Multiple options (BaudRate, DataBits, StopBits, Parity) LPT*: A single option (TransmissionRetryTimeout) FILE: No options Wine will add Redirection, what we can set in the registry at HKCU\Software\Wine\Printing\Spooler\<portname> -- By by ... Detlef

2 1

Re: [17/20] WineD3D: Vertex buffers can use the declaration from the device
by Ivan Gyurdiev Jan. 6, 2007

Jan. 6, 2007

Stefan Dösinger wrote: > Now that the decoded vertex declaration is put into the device with > baseVertexIndex = 0, vertex buffers can just memcpy it instead of decoding it > Here's an issue I see - isn't introduced by your patch, but I am just confused. In the vertex buffer code: if(device->stateBlock->vertexShader != NULL && wined3d_settings.vs_mode != VS_NONE &&((IWineD3DVertexShaderImpl *)device->stateBlock->vertexShader)->baseShader.function != NULL && GL_SUPPORT(ARB_VERTEX_PROGRAM)) { /* Case 1: Vertex Shader: No conversion */ TRACE("Vertex Shader, no conversion needed\n"); } else if(device->stateBlock->vertexDecl || device->stateBlock->vertexShader) { 1) No code should be looking at wined3d_settings.vs_mode. This is the user spec from winecfg, which is taken into account as one of the things that determines shader mode. There are a number of other things involved - use device->shader_mode instead. 2) GL_SUPPORT(ARB_VERTEX_PROGRAM) has already been accounted for when selecting the shader mode in the device 3) This if statement looks kind of like the "useVertexShaderFunction" variable in drawprim 4) Why is the "device->stateblock->vertexShader" case included in the else statement? You cannot use this function with a vertex shader - it would not work at all, as the strided data is formatted differently (same issue as the trace function discussed earlier).

1 0

Re: French translation of localspl
by Detlef Riekenberg Jan. 6, 2007

Jan. 6, 2007

On Sa, 2007-01-06 at 15:09 +0100, Jonathan Ernst wrote: > + IDS_NOTHINGTOCONFIG "Ce port n'a pas d'option Ã configurer" This is encoded as UFT-8 -- By by ... Detlef

1 0

appdb rating inflation
by Dan Kegel Jan. 6, 2007

Jan. 6, 2007

The appdb says "Only applications which install and run flawlessly on an out-of-the-box Wine installation make it to the Platinum list" But several platinum-rated apps seem to deserve a silver or bronze rating. For instance, Call to Duty, http://appdb.winehq.org/appview.php?iVersionId=3603 has all sorts of caveats: - Punkbuster enabled Multiplayer will not work - Sound out of sync. - Runs without crashes, but only if installed as root - requires whacky third-party Loki installer; real installer fails on cd change (http://bugs.winehq.org/show_bug.cgi?id=6594) - "with alsa, the sound lags ~ 1 second behind the game.... if i choose oss i got the 166 sound files missing error" And Diablo II, http://appdb.winehq.org/appview.php?iVersionId=49, also has lots of complaints / caveats / complicated howto's. Should we impose some standards on appdb ratings? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

19 39

Re: listview: Remove over constrained restriction on creating subitems.
by Alexandre Julliard Jan. 6, 2007

Jan. 6, 2007

Duane Clark <fpga(a)pacbell.net> writes: > Changelog: Remove over constrained restriction on creating subitems. > Subject: [PATCH] Remove over constrained restriction on creating subitems. This breaks the tests: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so listview.c && touch listview.ok listview.c:305: Test failed: ret 1 make[2]: *** [listview.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Problem with App Data screen
by Tony Lambregts Jan. 6, 2007

Jan. 6, 2007

There is a problem with submitting/administrating screen shots. I cannot see any screenshots that were submitted recently. This is probably a problem with filtering but I cannot be sure. http://appdb.winehq.org/admin/adminAppDataQueue.php http://appdb.winehq.org/admin/adminAppDataQueue.php?iId=5572 -- Tony Lambregts

2 1