October 2007 - Wine-Devel - list.winehq.org

.NET going open source(sort of)
by EA Durbin Oct. 4, 2007

Oct. 4, 2007

Looks like Microsoft is making their source code available for the .NET libraries. under their reference license. http://www.whurley.com/blog/2007/10/opennet-microso.html _________________________________________________________________ Climb to the top of the charts! Play Star Shuffle: the word scramble challenge with star power. http://club.live.com/star_shuffle.aspx?icid=starshuffle_wlmailtextlink_oct

4 4

Bits: DLL name and svchost questions
by Roy Shea Oct. 3, 2007

Oct. 3, 2007

Howdy All, Thanks for helping me these past weeks as I get started with Wine development! I'm gaining a better understanding of the bits (Background Intelligent Transfer Service) COM service. Bits is run as a service via the svchost group netsvcs. Within netsvcs is the BITS service that is tied to qmgr.dll. The qmgr name is used for backwards compatibility and is where the bits implementation lives. Two questions for the wine gods: (1) Shall I add bits to wine in dlls/bits or dlls/qmgr? I recommend the former, since current Windows documentation refers to "bits". But this may confuse folks who don't understand the tie between qmgr and bits, as demonstrated by my patch attempt last week :-\ (2) Need I treat svchost as a prerequisite to my bits work? I recommend developing bits first (starting bits as a service on demand) and then worrying about svchost. Off the top of my head I think this will look the same to applications wanting to use bits. However, I'm new to the COM world and may be overlooking something... Thanks for the advice, -Roy

1 1

Re: [PATCH 3/3] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions. [Try 2]
by Juan Lang Oct. 3, 2007

Oct. 3, 2007

Hi Rob, + file->mode |= st.st_mode & (S_IRWXU|S_IRWXO); Why "|=" rather than simply "="? --Juan

2 1

Re: ntdll: loader.c prevent accidental calls of entry point during dll events(resend)
by James Hawkins Oct. 3, 2007

Oct. 3, 2007

On 9/30/07, EA Durbin <ead1234(a)hotmail.com> wrote: > > Patch by Anastacious Focht > > The last one I submitted had a typo. > - if (nt->FileHeader.Characteristics & IMAGE_FILE_DLL) + /* do not setup entry point if kernel driver */ + if( !( Don't change the style (space after opening parenthesis). -- James Hawkins

3 3

Re: [PATCH 4/4] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions.
by Alexandre Julliard Oct. 3, 2007

Oct. 3, 2007

Robert Shearman <rob(a)codeweavers.com> writes: > + /* assume we are the owner */ > + if (st.st_mode & S_IRWXU) > + { Why are you assuming that? There doesn't seem to be much sense in checking permissions without checking the owner. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: [PATCH] check return value of get_dc_ptr
by Alexandre Julliard Oct. 3, 2007

Oct. 3, 2007

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity also spotted this one, and I agree. I don't, the DC is always valid since we are inside a driver call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine.inf[1/2]: remove non-existing modules from the fake dlls list
by Alexandre Julliard Oct. 3, 2007

Oct. 3, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > ddhelp.exe is on the list of fake dlls even if I couldn't find any > reference to building such a file in Wine sources. The created fake > DLL couldn't be loaded with LoadLibrary (however what's interesting it > could be loaded with LoadLibraryEx(..., LOAD_AS_DATAFILE)) what upset > the GeoInfo installer. I've found that dsound.vxd also isn't > (anymore?) built in Wine. These two files are on the list by mistake? No, they are here because an app needs them. It's not always necessary to have a corresponding builtin, if the app doesn't try to actually load the dll a fake is enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

secur32: Fix some memory leaks
by Andrew Talbot Oct. 2, 2007

Oct. 2, 2007

Please ignore this patch: I overlooked the original scope of the allocations. -- Andy.

1 0

Font issues when building Wine from sources
by Reece Dunn Oct. 2, 2007

Oct. 2, 2007

Hi, When I run an application using Wine from an X terminal, e.g. $ /opt/wine-0.9.43/bin/wine winecfg I get all the text (with the exception of the window title) displayed in the characters from the Marlett font. I have a Linux From Scratch 6.2 box with the following additional packages: * libpng 1.2.12 (needed by Xorg) * freetype 2.1.10 (needed by fontconfig) * expat 2.0.0 (needed by fontconfig) * fontconfig 2.3.2 (needed by Xorg) * Xorg 6.9.0 * fontforge 20070917 (Wine's ./configure says it needs this to build the fonts) * wine 0.9.42 (taken from git using the wine-0.9.43 tag) I am building wine as follows: ./configure --prefix=/opt/wine-0.9.43 make depend make make install all from a bash terminal (i.e. not X). Is there anything that I am missing, or am doing wrong? Thanks, - Reece

1 0

Re: Alexandre Julliard : ntdll: Remove assumptions that the subheap is at the beginning of the memory block .
by Allan Tong Oct. 2, 2007

Oct. 2, 2007

> ntdll: Remove assumptions that the subheap is at the beginning of the memory block. In HEAP_CreateSubHeap, shouldn't the return value also be changed, e.g. return "&((HEAP*)address)->subheap" if a main heap was created? - Allan

2 1

Re: programs/net: Add russian resources (resend)
by Kirill K. Smirnov Oct. 2, 2007

Oct. 2, 2007

My note is a nitpicking, but... >--- /dev/null 2007-06-28 07:33:44 +0400 >+++ programs/net/Ru.rc 2007-07-13 10:05:45 +0400 >@@ -0,0 +1,40 @@ >+/* >+ * NET.EXE - Wine-compatible net program >+ * English language support This file supports Russian language, not English >+ * >+ * Copyright (C) 2007 Konstantin Kondratyuk (Etersoft) >+ * Patching against git-current tree: $ cat net_russian.patch | patch -p0 patching file programs/net/rsrc.rc Hunk #1 succeeded at 24 (offset 1 line). patching file programs/net/Ru.rc It seems that something is definitely missed... -- Kirill

2 1

Are *any* games as popular as World of Warcraft?
by Dan Kegel Oct. 2, 2007

Oct. 2, 2007

I spent some time noodling around looking at what games are really popular (I wouldn't know firsthand, I don't play much). There's some data at http://www.amazon.com/gp/bestsellers/videogames (click on PC Games). I tried to cross-check titles with Google Trends to see which ones seem enduringly popular, but I haven't found any that beat World of Warcraft yet: http://www.google.com/trends?q=world+of+warcraft%2C+guild+wars%2C+tomb+raid… Is Google search popularity a bad measure, or does it reflect the public's mood well? - Dan

9 10

Re: Janitorial : Rename 16-Bit files
by Alexandre Julliard Oct. 1, 2007

Oct. 1, 2007

Rémi Assailly <remi.assailly(a)free.fr> writes: > I started 16 Bit separation. > This first patch renames : > - files containing 16 Bit functions only > - some 16 Bit functions. Please don't do that, there's no reason to rename things that are already separated properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Prefer a Microsoft cmap table over other platform ones
by Alexandre Julliard Oct. 1, 2007

Oct. 1, 2007

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > the bug 9840 has the ttf font attached that has incomplete default unicode > charmap which Freetype selects. Assuming that Microsoft and Macintosh cmaps > are more widely used/tested, let's use a priority to choose from available > character maps. Freetype developers think that it's a better choice to fix > this kind of problem. > > Changelog: > gdi32: Prefer a Microsoft cmap table over other platform ones. This fails make test here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok fixme:font:WineEngGetKerningPairs encoding 1634889070 not supported font.c:761: Test failed: got matches 0, expected 26 fixme:font:WineEngGetKerningPairs encoding 1634889070 not supported font.c:761: Test failed: got matches 0, expected 26 fixme:font:WineEngGetKerningPairs encoding 1634889070 not supported font.c:761: Test failed: got matches 0, expected 26 fixme:font:get_font_unicode_ranges encoding 1634889070 not supported fixme:font:get_font_unicode_ranges encoding 1634889070 not supported make[2]: *** [font.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] Fix Ugly borders around undecorated windows in Gnome
by Kirill K. Smirnov Oct. 1, 2007

Oct. 1, 2007

>This is my first attempt at submitting a patch to WINE, so please excuse >me if I have broken any conventions or am going through the wrong >channel. As it currently stands, wine is setting the 'MWM_DECOR_BORDER' >hint on managed but undecorated windows, such as iTunes, or Winamp. >This does not cause problems in KDE, but in Gnome it puts a gray border >around such windows. For me this causes problem in KDE too. Not just border but an ugly caption too :-( See http://www.winehq.org/pipermail/wine-devel/2007-September/059366.html >Not setting this hint does not seem to cause >problems in KDE and fixes the problem in Gnome. A patch to do just that >is attached. Comments? >--- dlls/winex11.drv/window_orig.c 2007-09-30 18:14:56.281259713 -0400 >+++ dlls/winex11.drv/window.c 2007-09-30 18:18:44.724576520 -0400 >@@ -591,11 +591,6 @@ > if (style & WS_MINIMIZEBOX) mwm_hints.decorations |= MWM_DECOR_MINIMIZE; > if (style & WS_MAXIMIZEBOX) mwm_hints.decorations |= MWM_DECOR_MAXIMIZE; > } >- if (ex_style & WS_EX_DLGMODALFRAME) mwm_hints.decorations |= >MWM_DECOR_BORDER; >- else if (style & WS_THICKFRAME) mwm_hints.decorations |= >MWM_DECOR_BORDER | MWM_DECOR_RESIZEH; >- else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER; >- else if (style & WS_BORDER) mwm_hints.decorations |= MWM_DECOR_BORDER; >- else if (!(style & (WS_CHILD|WS_POPUP))) mwm_hints.decorations |= MWM_DECOR_BORDER; > } > XChangeProperty( display, data->whole_window, x11drv_atom(_MOTIF_WM_HINTS), You overdid here a little: WS_THICKFRAME must have thick border. As I think, we should not mix WS_BORDER and MWM_DECOR_BORDER. They have DIFFERENT semantics. WS_BORDER is 1px border, but MWM_DECOR_BORDER is a thick border. What for me, I'd deleted just these lines: >- else if (style & WS_BORDER) mwm_hints.decorations |= MWM_DECOR_BORDER; >- else if (!(style & (WS_CHILD|WS_POPUP))) mwm_hints.decorations |= MWM_DECOR_BORDER; and draw thin 1px border 'manually' (I mean, in user32, do not left it to Window Manager) -- Kirill

1 0

Re: msinkaut.idl: Add stub IInkCollector interface (resend)
by Alexandre Julliard Oct. 1, 2007

Oct. 1, 2007

"John Klehm" <xixsimplicityxix(a)gmail.com> writes: > typedef float single; > + > + [ > + odl, > + uuid(F0F060B5-8B1F-4A7C-89EC-880692588A4F), > + dual, > + oleautomation > + ] > + interface IInkCollector : IDispatch { > + }; You have to list all the functions, a partial interface definition can't work right. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Fix some memory leaks
by Alexandre Julliard Oct. 1, 2007

Oct. 1, 2007

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > diff --git a/dlls/ole32/compositemoniker.c b/dlls/ole32/compositemoniker.c > index c49e9b8..88f141e 100644 > --- a/dlls/ole32/compositemoniker.c > +++ b/dlls/ole32/compositemoniker.c > @@ -1817,8 +1817,10 @@ CompositeMonikerImpl_Construct(IMoniker* > This->tabSize+=BLOCK_TAB_SIZE; > This->tabMoniker=HeapReAlloc(GetProcessHeap(),0,This->tabMoniker,This->tabSize*sizeof(IMoniker)); > > - if (This->tabMoniker==NULL) > + if (This->tabMoniker==NULL) { > + HeapFree(GetProcessHeap(), 0, This); > return E_OUTOFMEMORY; This->tabMoniker is leaked too in that case, it would be good to fix it while you are at it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] winex11.drv: Use ClipCursor to grab/ungrab the pointer.
by Alexandre Julliard Oct. 1, 2007

Oct. 1, 2007

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > +/*********************************************************************** > + * do_grab_pointer > + * > + * Helper to call grab_pointer from any thread. > + * > + * x11_lock have to be held when calling this function. It will be > + * released upon return. Don't do that, lock/unlock should be done at the same level, it makes it really hard to verify otherwise. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Add tests for DefWindowProc processing the undocumented 0x3Bmessage.
by Dmitry Timoshkov Oct. 1, 2007

Oct. 1, 2007

"Robert Shearman" <rob(a)codeweavers.com> wrote: > --- > dlls/user32/tests/msg.c | 71 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 71 insertions(+), 0 deletions(-) > > Found from observations with Spy++ whilst testing log-off behaviour in > XP. I don't see any point in using this message type over the documented > messages though. http://wiki.winprog.org/wiki/Windows_messages names 0x003b as WM_CLIENTSHUTDOWN. That page also lists some other not documented messages. -- Dmitry.

1 0

Weekly Newsletter
by EA Durbin Oct. 1, 2007

Oct. 1, 2007

Who maintains the weekly newsletter? I noticed it hasn't been updated since May. _________________________________________________________________ Invite your mail contacts to join your friends list with Windows Live Spaces. It's easy! http://spaces.live.com/spacesapi.aspx?wx_action=create&wx_url=/friends.aspx…

2 1