October 2007 - Wine-Devel - list.winehq.org

Beer apps under Wine :-)
by Dan Kegel Oct. 26, 2007

Oct. 26, 2007

Seems that most beer apps run ok on wine, judging by this thread: http://www.tastybrew.com/forum/thread/120190

1 0

Re: crypt32: Remove a test because of a Windows 2003 SP1 bug
by Reece Dunn Oct. 25, 2007

Oct. 25, 2007

Juan Lang wrote: > - /* Now check just the time */ > - flags = CERT_STORE_TIME_VALIDITY_FLAG; > - parent = CertGetIssuerCertificateFromStore(store, child, NULL, &flags); > - ok(parent != NULL, "CertGetIssuerCertificateFromStore failed: %08x\n", > - GetLastError()); > - /* Oops: the child is not expired, so the time validity check actually > - * succeeds, even though the signing cert is expired. > + /* Checking time validity is not productive, because while most Windows > + * versions return 0 (time valid) because the child is not expired, > + * Windows 2003 SP1 returns that it is expired. Thus the range of > + * possibilities is covered, and a test verifies nothing. > */ The test being removed is correct and valid. Removing it could lead to a regression in Wine as this case is not being covered when this patch is applied. While a 100% pass rate is ideal, on Windows 2003 SP1 that test *is* failing due to a bug. However, this is the correct behaviour, and the bug is detected by this test. - Reece

2 4

How long should 'make test' take?
by Dan Kegel Oct. 25, 2007

Oct. 25, 2007

Here are all the tests that take more than five seconds: 5.407s advapi32_test.exe.so service.c 6.010s kernel32_test.exe.so console.c 6.252s user32_test.exe.so msg.c 9.657s kernel32_test.exe.so process.c 12.053s winmm_test.exe.so timer.c 14.080s shell32_test.exe.so shlexec.c 17.760s msi_test.exe.so install.c 24.018s winmm_test.exe.so wave.c 648.722s wininet_test.exe.so ftp.c Other than wininet's ftp test and maybe winmm's wave test, the overall time seems reasonable. IMHO we should disable the ftp test until its runtime can be brought down below 20 seconds. It's just too slow, and too dependent on stuff not under Wine's control (e.g. one's internet connection). And I have a really fast internet connection... it's just that my ping time to winehq is 80ms. I bet the ftp test runs fast in Minneapolis... - Dan

4 5

Re: Start: Convert start to Unicode.
by Dmitry Timoshkov Oct. 25, 2007

Oct. 25, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > -/** > +WINE_DEFAULT_DEBUG_CHANNEL(start); > + > +/* All these changes /** -> /* make the diff larger, and are not really necessary. > Output given message to stdout without formatting. > */ > -static void output(const char *message) > +static void output(const WCHAR *message) > { > DWORD count; > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); > + DWORD res; > + int wlen = strlenW(message); Once you change your editor settings to use natural 8 spaces for a tab you will see how ugly the formatting in your new code is. > -static void fatal_error(const char *msg, DWORD error_code) > +static void fatal_error(const WCHAR *msg, DWORD error_code) fatal_error() is not called with strings outside of ASCII charset, so there is no much point in converting it to unicode. It only makes your patch full of controversial changes. IMHO fatal_error() should be removed altogether, and replaced by proper error handling instead. -- Dmitry.

3 5

Re: winmm: fix uninitialized variable that caused near-infinite loop
by Alexandre Julliard Oct. 25, 2007

Oct. 25, 2007

"Dan Kegel" <dank(a)kegel.com> writes: > Without this patch, winmm/tests/mixer.c appears to hang on one of my machines. > > I think the problem was capsA was uninitialized in: > for (d=0;d<capsA.cDestinations;d++) { That's just hiding the bug. If mixerGetDevCapsA failed we shouldn't go on to use the data that it hasn't returned, we should abort the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shlwapi: Update exported API entries according to the info published by Geoff Chappell
by Alexandre Julliard Oct. 25, 2007

Oct. 25, 2007

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1,18 +1,18 @@ > -1 stdcall -noname ParseURLA(str ptr) > -2 stdcall -noname ParseURLW(wstr ptr) > +1 stdcall ParseURLA(str ptr) > +2 stdcall ParseURLW(wstr ptr) That doesn't look right, why are you removing -noname on these and many other functions? AFAICT they are not exported by name in most shlwapi versions. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: shlwapi: Update exported API entries according to the info published by Geoff Chappell
by Robert Shearman Oct. 25, 2007

Oct. 25, 2007

Dmitry Timoshkov wrote: > +1 stdcall ParseURLA(str ptr) > +2 stdcall ParseURLW(wstr ptr) > +12 stdcall SHCreateMemStream(ptr long) > +168 stdcall ConnectToConnectionPoint(ptr ptr long ptr ptr ptr) > +169 stdcall IUnknown_AtomicRelease(long) > +172 stdcall IUnknown_GetWindow(ptr ptr) > +174 stdcall IUnknown_SetSite(ptr ptr) > +176 stdcall IUnknown_QueryService(ptr ptr ptr ptr) > +184 stdcall IStream_Read(ptr ptr long) SHIStream_Read > +185 stdcall SHMessageBoxCheckA(ptr str str long long str) > +191 stdcall SHMessageBoxCheckW(ptr wstr wstr long long wstr) > > +199 stdcall IUnknown_Set(ptr ptr) > +203 stdcall SHStripMneumonicA(str) > +204 stdcall SHIsChildOrSelf(long long) > +212 stdcall IStream_Write(ptr ptr long) SHIStream_Write > +213 stdcall IStream_Reset(ptr) > +214 stdcall IStream_Size(ptr ptr) > +215 stdcall SHAnsiToUnicode(str ptr long) > +217 stdcall SHUnicodeToAnsi(wstr ptr ptr) > +219 stdcall QISearch(long long long long) > +225 stdcall SHStripMneumonicW(wstr) > +256 stdcall IUnknown_GetSite(ptr ptr ptr) > +276 stdcall WhichPlatform() > +280 stdcall SHRegGetIntW(ptr wstr long) > +345 stdcall SHAnsiToAnsi(str ptr long) > +346 stdcall SHUnicodeToUnicode(wstr ptr long) > +353 stub SHFormatDateTimeA > +354 stub SHFormatDateTimeW > +388 varargs ShellMessageBoxW(long long wstr wstr long) ShellMessageBoxWrapW > +418 stdcall MLFreeLibrary(long) > +432 stub SHSendMessageBroadcastA > +433 stub SHSendMessageBroadcastW > +437 stdcall IsOS(long) > +462 stub UrlFixupW > +467 stub SHRunIndirectRegClientCommand > +512 stub IStream_ReadPidl > +513 stub IStream_WritePidl > These are all exported by ordinal only up to Windows 2003 SP1 (w/ IE 6.0). +196 stub -noname SHVerbExistsNA #stdcall @(ptr ptr ptr ptr) dnsapi.DnsRecordSetCompare You need to fix the name of the function in the comment here. -- Rob Shearman

2 1

Re: winex11.drv: Support HWND_TOPMOST/HWND_BOTTOM windows using NETWM states.
by Alexandre Julliard Oct. 25, 2007

Oct. 25, 2007

Robert Shearman <rob(a)codeweavers.com> writes: > */ > -static void update_wm_states( Display *display, struct x11drv_win_data *data, BOOL force ) > +static void update_wm_states( Display *display, struct x11drv_win_data *data, > + BOOL force, BOOL set_zorder, HWND insert_after ) > { > static const unsigned int state_atoms[NB_WM_STATES] = > { > XATOM__NET_WM_STATE_FULLSCREEN, > XATOM__NET_WM_STATE_SKIP_PAGER, > - XATOM__NET_WM_STATE_SKIP_TASKBAR > + XATOM__NET_WM_STATE_SKIP_TASKBAR, > + XATOM__NET_WM_STATE_ABOVE, > + XATOM__NET_WM_STATE_BELOW, It's not that easy, there's a lot more to HWND_TOPMOST than simply setting window manager hints, it needs to enforce proper ordering in the server, and set/clear the WS_EX_TOPMOST style as needed. I have that on my todo list... -- Alexandre Julliard julliard(a)winehq.org

1 0

start:start.c Display messages in the console encoding.
by Kirill K. Smirnov Oct. 25, 2007

Oct. 25, 2007

> static void output(const char *message) > { >- DWORD count; >- WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), >&count, NULL); >+ DWORD count = 0; >+ WCHAR *mesW = NULL; >+ char *mes = NULL; >+ int wlen = 0; >+ int len = 0; >+ >+ wlen = MultiByteToWideChar( CP_ACP, 0, message, -1, NULL, 0 ); >+ mesW = HeapAlloc( GetProcessHeap(), 0, wlen * sizeof(WCHAR) ); >+ mes = HeapAlloc( GetProcessHeap(), 0, wlen * sizeof(char) ); >+ >+ MultiByteToWideChar( CP_ACP, 0, message, -1, mesW, wlen ); >+ len = WideCharToMultiByte( GetConsoleOutputCP(), 0, mesW, wlen, NULL, 0, >NULL, NULL ); >+ WideCharToMultiByte( GetConsoleOutputCP(), 0, mesW, wlen, mes, len, NULL, >NULL ); >+ >+ WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), mes, len, &count, NULL); >+ if( !count && len ) >+ SetLastError( ERROR_FUNCTION_FAILED ); >+ >+ HeapFree(GetProcessHeap(), 0, mesW); >+ HeapFree(GetProcessHeap(), 0, mes); > } WriteFile does not output unicode characters to console screen buffer, so if ConsoleOutputCP is smth like 65001, this will fail. The page http://msdn2.microsoft.com/en-us/library/ms687401.aspx contains remedy by Microsoft how to deal with problem: 1) If device handle is console, then output wide chars using WriteConsoleW 2) If device handle is not console, then convert wide chars to ConsoleOutputCP and output using WriteFileA. This way is already implemented in cmd (See WCMD_output_asis_len function). And it may be much better to convert start utility to unicode. -- Kirill P.S. all this manipulations is supposed to be done by msvcrt printf function family, but wine lacks this functionality :-(

2 1

any clues as to what's wrong with patches (system palette entries)?
by Alexander Dorofeyev Oct. 25, 2007

Oct. 25, 2007

Hello. I've sent a patch that changes X11DRV_GetSystemPaletteEntries behavior and a test something like a week ago. I guess they fell into that so called not obviously correct category (or maybe not correct at all one). I'll appreciate any comments or suggestions on possible improvements. Thanks. > On Windows, GetSystemPaletteEntries() call in non-palettized graphics > modes returns back reserved colors from the default palette. This patch > modifies winex11.drv's X11DRV_GetSystemPaletteEntries() function to > imitate this behavior instead of just returning 0. This partially solves > bug #201 (helps igowin.exe transparency problem, untested with another app).

1 0

Git Page on website
by Alistair Leslie-Hughes Oct. 24, 2007

Oct. 24, 2007

Hi, On the git web page, the commands to run to perform "Cleaning up your existing tree" and "Staying Up-To-Date" have been merge to one line. Best Regards Alistair Leslie-Hughes

1 0

AppDB: login
by speedator＠gmx.de Oct. 24, 2007

Oct. 24, 2007

Hi, would be great to have a longer period to stay logged in. A setting under preference for the period seems a good solution, Btw: What is the status of appdb/bugzilla(wiki?)-account-fusion? Bye, Julian

2 1

PulseAudio as a sound output?
by King InuYasha Oct. 24, 2007

Oct. 24, 2007

I would like to suggest that eventually Wine would support PulseAudio as a sound output natively. I am already aware of Wine supporting ESD, which PulseAudio can use, but supporting PulseAudio natively I think would be much better.

13 20

Anything wrong with my patch from 16.10. about w32x86 and win40 creation?
by Pat Oct. 24, 2007

Oct. 24, 2007

I usually use the archives for viewing patches, sometimes the patches are archived separately to the email. Markus' patch is here: http://www.winehq.org/pipermail/wine-patches/2007-October/045288.html

3 3

Re: iphlpapi: Intel Mac do not implement /proc filesystem so return Unimplemented for the functions trying to read from there.
by Juan Lang Oct. 24, 2007

Oct. 24, 2007

Hi Aric, @@ -104,6 +104,9 @@ DWORD getInterfaceStatsByName(const char { FILE *fp; +#ifdef __APPLE__ + return ERROR_NOT_SUPPORTED; +#endif This is ugly. Why not just change the case when fp is NULL? You've already got: fp = fopen("/proc/net/dev", "r"); if (fp) { ... } else ERR ("unimplemented!\n"); You could change this to set the return value, rather than using all these #ifdefs. Same thing throughout the patch. --Juan

2 1

Re: "typos" on some include files
by Dmitry Timoshkov Oct. 24, 2007

Oct. 24, 2007

"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > $ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def > --- liboleaut32.def 2007-08-23 16:15:48.000000000 +0200 > +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.000000000 +0200 > @@ -366,7 +366,6 @@ EXPORTS > OleCreatePictureIndirect(a)16 @419 > OleCreateFontIndirect(a)12 @420 > OleTranslateColor(a)12 @421 > - OleLoadPictureFile(a)12 @422 > OleLoadPicturePath(a)24 @424 > VarUI4FromI8(a)12 @425 > VarUI4FromUI8(a)12 @426 Also you can't just add an entry to the .def file, it's auto generated. You have to add a stub to the source file, and change the 'stub' entry in the .spec file. -- Dmitry.

2 4

Re: "typos" on some include files
by Dmitry Timoshkov Oct. 24, 2007

Oct. 24, 2007

"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > Attached is the "patch" file (diff -up) regarding the bug: > > http://bugs.winehq.org/show_bug.cgi?format=multiple&id=10156 The patch is reversed, please change the source/dest, rediff and resend. -- Dmitry.

2 1

Re: dlls/rpcrt4/rpc_server.c initiale variable
by Robert Shearman Oct. 24, 2007

Oct. 24, 2007

Gerald Pfeifer wrote: > It seems there are some code paths (in the error case?) which may > leave this unitialized. At least the compiler thinks so, and I > could not convince myself otherwise reading this code for a while. > It's a false positive, probably coming from the compiler not picking up that it is set when the exception variable is false and that when exception is true it is set earlier in the function. > - RpcPktHdr *response; > + RpcPktHdr *response = 0; > > If you're going to change the code at all, then at least keep to the coding convention used in the rest of the function and use NULL here. -- Rob Shearman

2 1

Re: oleaut32 [2/2]: Use widl to generate oaidl_p.c
by Alexandre Julliard Oct. 24, 2007

Oct. 24, 2007

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This patch sets up the oleaut32 Makefile and shuffles some files > around so we can use widl to generate oaidl_p.c. The patch is *very* > large since it contains a diff for all of oaidl_p.c (which was > removed), and also two for oaidl.idl (which was moved). That's ugly, we need to make this work without having to rename the public headers. -- Alexandre Julliard julliard(a)winehq.org

1 0

windows on solaris
by S E Oct. 24, 2007

Oct. 24, 2007

Hi , I have an executable that resides and compiled on windows 2003 server, I want to approach from my UNIX Solaris machine and run the executable. If anyone knows how to do that, or what can I use to run that I will be very happy. Thanks, SE

1 0

wineconf photos
by Steven Edwards Oct. 24, 2007

Oct. 24, 2007

Hi, I was not lucky enough to have my digital camara with me during Wineconf, so if you've got photos uploaded somewhere please post urls or better yet add them to the Wiki. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: start:start.c Display messages in the console encoding.
by Dmitry Timoshkov Oct. 24, 2007

Oct. 24, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > static void output(const char *message) > { > - DWORD count; > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); > + DWORD count = 0; > + WCHAR *mesW = NULL; > + char *mes = NULL; > + int wlen = 0; > + int len = 0; There is no need to initialize variables to 0 since you are going to explicitly initialize them later anyway. > + wlen = MultiByteToWideChar( CP_ACP, 0, message, -1, NULL, 0 ); > + mesW = HeapAlloc( GetProcessHeap(), 0, wlen * sizeof(WCHAR) ); > + mes = HeapAlloc( GetProcessHeap(), 0, wlen * sizeof(char) ); Allocating wlen chars for 'mes' won't work correctly on a multibyte locale. > + MultiByteToWideChar( CP_ACP, 0, message, -1, mesW, wlen ); > + len = WideCharToMultiByte( GetConsoleOutputCP(), 0, mesW, wlen, NULL, 0, NULL, NULL ); Just move the call to allocate 'len' bytes for 'mes' here. > + WideCharToMultiByte( GetConsoleOutputCP(), 0, mesW, wlen, mes, len, NULL, NULL ); -- Dmitry.

1 0

rpc: (resend) Add missing headers
by Roy Shea Oct. 24, 2007

Oct. 24, 2007

Hello, Attached is a corrected version of this patch. I thank Mikolaj who brought to my attention the fact that rpcproxy.h is the incorrect location to include the files I added in the earlier patch. This revised patch adds the includes directly to rpc.h. The Windows version of rpc.h accesses these includes throuh windows.h. Peace, -Roy On Tue, Oct 23, 2007 at 09:50:25AM -0700, Roy Shea wrote: > Howdy, > > The REGISTER_PROXY_DLL_ROUTINES macro defined in rpcproxy.h calls > DisableThreadLibraryCalls. This patch adds two header files needed > for calls to DisableThreadLibraryCalls. > > Peace, > -Roy >

1 0

Re: [PATCH 3/3] configure: Use 0 instead of NULL because NULL isn't defined.
by Stefan Dösinger Oct. 23, 2007

Oct. 23, 2007

Am Freitag, 19. Oktober 2007 23:18:51 schrieb Ken Thomases: > This makes the test test the proper thing on Mac OS X. It still fails, but > for a good reason. > --- > configure.ac | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > - char *name=NULL; > + char *name=0; Shouldn't that be (void *) 0 or (char *) 0?

6 7

Re: widl [3/4]: Remove printf format strings that aren't really format strings.
by Michael Stefaniuc Oct. 23, 2007

Oct. 23, 2007

Dan Hipschman wrote: > This is just a minor cleanup patch. Even if we're definitely sure a > string doesn't contain any % signs, it's still better not to use it as a > printf format string. fputs() would be a faster alternative to that. Though i doubt that matters in this case. bye michael > --- > tools/widl/typegen.c | 4 ++-- > tools/widl/widl.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index bf24d3f..53ec78c 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -2501,7 +2501,7 @@ void print_phase_basetype(FILE *file, int indent, enum remoting_phase phase, > fprintf(file, " *)_StubMsg.Buffer = *"); > else > fprintf(file, " *)_StubMsg.Buffer = "); > - fprintf(file, varname); > + fprintf(file, "%s", varname); > fprintf(file, ";\n"); > } > else if (phase == PHASE_UNMARSHAL) > @@ -2510,7 +2510,7 @@ void print_phase_basetype(FILE *file, int indent, enum remoting_phase phase, > print_file(file, indent, ""); > else > print_file(file, indent, "*"); > - fprintf(file, varname); > + fprintf(file, "%s", varname); > if (pass == PASS_IN && is_ptr(type)) > fprintf(file, " = ("); > else > diff --git a/tools/widl/widl.c b/tools/widl/widl.c > index 53c9e29..37f1a5e 100644 > --- a/tools/widl/widl.c > +++ b/tools/widl/widl.c > @@ -422,13 +422,13 @@ int main(int argc,char *argv[]) > idfile_name = xstrdup(optarg); > break; > case 'V': > - printf(version_string); > + printf("%s", version_string); > return 0; > case 'W': > pedantic = 1; > break; > default: > - fprintf(stderr, usage); > + fprintf(stderr, "%s", usage); > return 1; > } > } > @@ -458,7 +458,7 @@ int main(int argc,char *argv[]) > input_name = xstrdup(argv[optind]); > } > else { > - fprintf(stderr, usage); > + fprintf(stderr, "%s", usage); > return 1; > } > > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

3 3