October 2007 - Wine-Devel - list.winehq.org

Make test drill, next steps, call for help with Winetest
by Jeremy White Oct. 19, 2007

Oct. 19, 2007

Hi Folks, So I had plan to report on the status of make test, and sound a call to action. That is, one of the best and most fun things we did at Wineconf was to call bullshit on the failure of make test to work reliably. That is, it only runs cleanly on Alexandre's machine, and not even all the time then. So, we worked hard to make 'make test' work reliably on other folks systems at Wineconf. We made a lot of progress; cutting failures by half, I would say. The closest we got was with Michael; I think he was down to 3 at the end. However, we're still plagued with differences due to chipsets, locales, and other differences. But I think it is vital that we continue this work. The fact that 'make test' doesn't work anywhere, really, is bullshit. However, I'm enough of a weasel that I wanted to get out of collating all of this data myself. So I investigated (or tried to investigate) winetest to see if I could dump this work on a tool. And it looks like it would be great. Of course, with a few caveats :-/. In my opinion, it needs the following: 1. A Wiki page! I could not find *any* documentation on this utility. For example, I'm still not entirely clear on how to setup and/or register my build.id so that my results are available on the web site. (And the rather non intuitive requirement to 'know' the unpublished url http://test.winehq.org/data/ is harsh). 2. Headless operation From my experiments, there were a number of dialogs I had to dismiss, and some worrying complaints in unpacking msvcrtd and msvcrt tests. This second point is probably a bit less important than the first. However, it looked like if just a few little glitches could be ironed out, that it would be a fantastic tool for working on the make test problem. We'd be able to see the common failures, and work to resolve them and drive them to zero. Is there someone that could do the first part of this? Just document what is already there? Or point me to the page that exists that I just missed? Cheers, Jeremy

4 8

Re: D3DX8: [4/13]: implement D3DX__Add with a test
by Stefan Dösinger Oct. 19, 2007

Oct. 19, 2007

Am Freitag, 19. Oktober 2007 10:13:39 schrieb David.Adam(a)math.cnrs.fr: > +#define expect_vec3(expectedvec,gotvec) ok((fabs(expectedvec.x-gotvec.x)<admitted_error)&&(fabs(expectedvec.y-gotvec.y)<admitted_error)&&(fabs(expectedvec.z-gotvec.z)<admitted_error),"Expected Vector= (%f, %f,%f)\n , Got Vector= (%f, %f, %f)\n", expectedvec.x, expectedvec.y, expectedvec.z, gotvec.x, gotvec.y, gotvec.z); Usually inline functions are prefered over macros. I don't know how well that works with ok though, since it might drop the line of the error and make debugging harder.

1 0

Re: D3DX8: [1/13] resent: implement D3Dx__Length with a test
by Stefan Dösinger Oct. 19, 2007

Oct. 19, 2007

Am Freitag, 19. Oktober 2007 10:10:07 schrieb David.Adam(a)math.cnrs.fr: > ----- > Pièces jointes (Les liens expireront le May 1, 2008) > https://webmail.math.cnrs.fr/horde/imp/attachment.php?u=dadam%40math.cnrs.f >r&t=1192788607&f=0001-Implement-D3DX___Length-function-with-a-test.patch.pat >ch Did you forget to attachthe file?

1 0

Use warn+heap when running 'make test'
by Dan Kegel Oct. 19, 2007

Oct. 19, 2007

As noted in http://bugs.winehq.org/show_bug.cgi?id=9916 using warn+heap poisons free memory, and finds a few more bugs. People who run 'make test' should consider running WINEDEBUG=warn+heap make test instead. (I don't know whether we should make that the default, though. Anyone have an opinion?)

2 1

Re: wined3d: Fix resource cleanup if CreateCubeTexture fails.
by Stefan Dösinger Oct. 19, 2007

Oct. 19, 2007

Am Freitag, 19. Oktober 2007 07:14:17 schrieb Allan Tong: Looks good to me

1 0

notepad: Dangling pointer fix
by Andrew Talbot Oct. 18, 2007

Oct. 18, 2007

Please ignore this patch. Thanks, -- Andy.

1 0

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA (try 2)
by Detlef Riekenberg Oct. 18, 2007

Oct. 18, 2007

On Mi, 2007-10-17 at 13:17 -0700, Nigel Liang wrote: > + urlCompa.dwStructSize = sizeof(urlCompa); > + bRet = InternetCrackUrlA(sUrl, 11, 0, &urlCompa); > + ZeroMemory(&urlCompa, sizeof(urlCompa)); > + ZeroMemory(&szBuf, sizeof(char)*1024); > + urlCompa.dwUserNameLength = 1024; It looks much better, when you avoid constant numbers. I suggest to use sizeof() instead. (but never use "sizeof()" in "ok()" or in "trace()".) Thanks for helping wine. -- By by ... Detlef

1 0

Re: widl [4/4]: Detect conformant arrays of user types correctly.
by Robert Shearman Oct. 18, 2007

Oct. 18, 2007

Dan Hipschman wrote: > @@ -1859,6 +1859,7 @@ static int get_struct_type(var_list_t *fields) > case RPC_FC_OP: > case RPC_FC_CARRAY: > case RPC_FC_CVARRAY: > + case RPC_FC_BOGUS_ARRAY: > has_pointer = 1; > break; > > @@ -1897,15 +1898,9 @@ static int get_struct_type(var_list_t *fields) > /* fallthru - treat it as complex */ > > /* as soon as we see one of these these members, it's bogus... */ > - case RPC_FC_IP: > case RPC_FC_ENCAPSULATED_UNION: > case RPC_FC_NON_ENCAPSULATED_UNION: > - case RPC_FC_TRANSMIT_AS: > - case RPC_FC_REPRESENT_AS: > - case RPC_FC_PAD: > - case RPC_FC_EMBEDDED_COMPLEX: > case RPC_FC_BOGUS_STRUCT: > - case RPC_FC_BOGUS_ARRAY: > return RPC_FC_BOGUS_STRUCT; > } > } > Hi Dan, What's the reasoning behind this part of the patch? It seems to me like most of the cases that you removed from becoming a complex structure are actually valid. The hunk further up also confuses me - the presence of a complex array shouldn't just make the resulting structure into a pointer structure, it should make it into a complex structure, since it can't be marshalled solely by using memcpy. -- Rob Shearman

2 1

Priority/severity of test suite hangs
by Dan Kegel Oct. 18, 2007

Oct. 18, 2007

I'm going to start filing bugs for anything that makes the test suite hang, and I'm going to lash out and give them unreasonably high priority and severity. There's just no excuse for a test suite that can't run to completion. -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: [2/3] hlink: Undefine the GetObject macro when compiling the Wine source to avoid errors.
by Jacek Caban Oct. 18, 2007

Oct. 18, 2007

Hi Francois, Francois Gouget wrote: > > +/* GetObject is defined in wingdi.h as WINELIB_NAME_AW(GetObject), > + * which resolves to a compilation failure if WINE_NO_UNICODE_MACROS is > + * defined, but GetObject is used as a valid method name below, so we have > + * to undefine it in that case */ > +cpp_quote("#ifdef WINE_NO_UNICODE_MACROS") > +cpp_quote("#undef GetObject") > +cpp_quote("#endif") > + > /***************************************************************************** > * IHlinkBrowseContext interface > */ > I've sent a patch for it yesterday and it's applied now: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a41cab9b52893f472de6c… I've also sent a patch for mshtml.idl patch (but my version didn't include import shtypes.idl): http://source.winehq.org/git/wine.git/?a=commitdiff;h=62894b488d0b03a922b80… Thanks, Jacek

1 0

Re: inkobj: Implement IClassFactory
by Alexandre Julliard Oct. 18, 2007

Oct. 18, 2007

"John Klehm" <xixsimplicityxix(a)gmail.com> writes: > This patch is largely based on the code found in mshtml. What I did > was separate it into its own file and restyle it to my liking. Restyling it wasn't such a good idea I'm afraid, the original code is better without these ugly casts, and the Release function was correct, unlike yours. Also please don't name your files inkobj_something, they are in the inkobj directory already, no need to repeat that in the file name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW (try 2)
by Alexandre Julliard Oct. 18, 2007

Oct. 18, 2007

Nigel Liang <ncliang(a)gmail.com> writes: > Previous patch had incorrect bounds for memchrW. There are other places in that function that assume that the string is null-terminated, please fix those too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Added support for installing Gecko from build dir.
by Alexandre Julliard Oct. 18, 2007

Oct. 18, 2007

Jacek Caban <jacek(a)codeweavers.com> writes: > - static const char gecko_dir[] = "/gecko/"; > - > - data_dir = wine_get_data_dir(); > - if(!data_dir) return FALSE; > + if((data_dir = wine_get_data_dir())) > + subdir = "/gecko/"; > + else if((data_dir = wine_get_build_dir())) > + subdir = "/dlls/mshtml/"; I don't think this file should be inside the build dir, it's not something that can be easily regenerated. Maybe we should look for it in $build_dir/.. ? -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: msi: make the WriteEnvironmentStrings handling of [~] a bit better
by EA Durbin Oct. 18, 2007

Oct. 18, 2007

The compiler complains at this line about lstrlenW being passed an incompatible pointer type + else if (lstrlenW(value) >= prefix_len) should it be lstrlenW(*value) ? _________________________________________________________________ Climb to the top of the charts! Play Star Shuffle: the word scramble challenge with star power. http://club.live.com/star_shuffle.aspx?icid=starshuffle_wlmailtextlink_oct

2 1

Re: [PATCH] wininet: Close sockets open in http requests
by Misha Koshelev Oct. 18, 2007

Oct. 18, 2007

> n 10/13/07, Nigel Liang <ncliang at gmail.com> wrote: > > Hi, > > > > Http requests open sockets and forget to close them. Left running over a long > > period, the socket file descriptor starts getting large. Once it exceeds > > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > > > > -Nigel > > > > --- > > dlls/wininet/internet.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > > index 0edca74..8e3a98e 100644 > > --- a/dlls/wininet/internet.c > > +++ b/dlls/wininet/internet.c > > @@ -1014,6 +1014,9 @@ BOOL WINAPI InternetCloseHandle(HINTERNE > > return FALSE; > > } > > > > + if (lpwh->htype == WH_HHTTPREQ) > > + NETCON_close(&((LPWININETHTTPREQW)lpwh)->netConnection); > > + > > WININET_Release( lpwh ); > > WININET_FreeHandle( hInternet ); > > > > -- > > 1.4.1 > > > > > > Hi, > > This patch was sent 4 days ago and it hasn't gone in yet. Could anyone > give me some comments on it? Dan filed bug 10032 which is related to > this. While we shouldn't be using select() on high FDs for networking, > this patch closes the sockets that were open by http requests to avoid > getting to high FDs... > > Thanks, > -Nigel Hi, well looking over this very quickly right off the bat it does not seem correct to me. WININET_Release will call the close_connection method of the handle if it is defined, and for WH_HHTTPREQ this is HTTP_CloseConnection, which does call NETCON_Close along with sending all the proper status notifications, etc. So if in fact NETCON_Close is _not_ being called for some reason, you need to track down where involving those functions either why the proper one is not getting called (if that is the case) or if that function somehow needs to call NETCON_Close when it doesn't. Misha

2 3

Re: [PATCH] wininet: Close sockets open in http requests
by Nigel Liang Oct. 17, 2007

Oct. 17, 2007

On 10/13/07, Nigel Liang <ncliang(a)gmail.com> wrote: > Hi, > > Http requests open sockets and forget to close them. Left running over a long > period, the socket file descriptor starts getting large. Once it exceeds > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > > -Nigel > > --- > dlls/wininet/internet.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 0edca74..8e3a98e 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -1014,6 +1014,9 @@ BOOL WINAPI InternetCloseHandle(HINTERNE > return FALSE; > } > > + if (lpwh->htype == WH_HHTTPREQ) > + NETCON_close(&((LPWININETHTTPREQW)lpwh)->netConnection); > + > WININET_Release( lpwh ); > WININET_FreeHandle( hInternet ); > > -- > 1.4.1 > > Hi, This patch was sent 4 days ago and it hasn't gone in yet. Could anyone give me some comments on it? Dan filed bug 10032 which is related to this. While we shouldn't be using select() on high FDs for networking, this patch closes the sockets that were open by http requests to avoid getting to high FDs... Thanks, -Nigel

1 0

wnaspi and DVD Burner
by Stefan Leichter Oct. 17, 2007

Oct. 17, 2007

Hello, i tried to make some progress with Ahead Nero, but now i'm stuck. I found the NeroSDK-1.08.zip and inside the comand line tool NeroAPITest.exe. The source code of NeroAPITest.exe is in the archive too. This makes finding the problems easier. Executing the comand 'wine NeroAPITest.exe --listdrives' the open function in SCSI_OpenDevice fails first with ENOMEDIUM. Putting a disk into the drive the command fails with errno 30 (Read-only). Opening the drive read only works, but next is a write on the file descriptor that fails because it was opened readonly ... The scenario above fails only for my PATA DVD burner. My SCSI DVD reader and my SCSI CD reader are working well with the command sequence listed above. My OS is Debian etch (32bit) the burner is a Plextor PX-716A. Is the reason for this the difference between IDE and SCSI in the kernel? Is it a fault of the DVD burner device (firmware)? What might be a workaround for the problem? Thanks for your thought Stefan

1 0

Wine Stats Malfunctioning
by luis.busquets＠ilidium.com Oct. 17, 2007

Oct. 17, 2007

Web page: http://www.winehq.org/site/winapi_stats on wine statistics does not work.

2 1

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW.txt
by Frank Richter Oct. 17, 2007

Oct. 17, 2007

On 17.10.2007 06:49, Nigel Liang wrote: > Hi, > > strchrW assumes a NULL-terminated string. May crash if terminating character is > not found. memchrW is better because you can specify the maximum number of > bytes to search. On the flipside, memchrW() doesn't stop at a NUL... -f.r.

2 1

Possible WIne regression with Warcraft
by Michael Lothian Oct. 17, 2007

Oct. 17, 2007

Hi I've noticed a problem in wine recently. When I try and join a network game in Warcraft I can see the game but I'm unable to join it. These errors are printing out: fireburn(a)tau ~/.wine/drive_c/Program Files/Warcraft III $ wine Frozen\ Throne.exe ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib control.c:909:(snd_ctl_open_noupdate) Invalid CTL default:0 err:ole:CoCreateInstance apartment not initialised fixme:advapi:SetSecurityInfo stub fixme:win:EnumDisplayDevicesW ((null),0,0x34f3d8,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f7b0,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f3bc,0x00000000), stub! fireburn(a)tau ~/.wine/drive_c/Program Files/Warcraft III $ fixme:winsock:WSAIoctl unsupported WS_IOCTL cmd (9800000c) fixme:mswsock:AcceptEx (listen=8552, accept=8564, 0x31100e8, 0, 32, 32, 0x34f498, 0x31100b8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8568, 0x3110170, 0, 32, 32, 0x34f498, 0x3110140), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8572, 0x31101f8, 0, 32, 32, 0x34f498, 0x31101c8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8576, 0x3110280, 0, 32, 32, 0x34f498, 0x3110250), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8580, 0x3110308, 0, 32, 32, 0x34f498, 0x31102d8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8584, 0x3110390, 0, 32, 32, 0x34f498, 0x3110360), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8588, 0x3110418, 0, 32, 32, 0x34f498, 0x31103e8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8592, 0x31104a0, 0, 32, 32, 0x34f498, 0x3110470), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8596, 0x3110528, 0, 32, 32, 0x34f498, 0x31104f8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8600, 0x31105b0, 0, 32, 32, 0x34f498, 0x3110580), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8604, 0x3110638, 0, 32, 32, 0x34f498, 0x3110608), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8608, 0x31106c0, 0, 32, 32, 0x34f498, 0x3110690), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8612, 0x3110748, 0, 32, 32, 0x34f498, 0x3110718), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8616, 0x31107d0, 0, 32, 32, 0x34f498, 0x31107a0), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8620, 0x3110858, 0, 32, 32, 0x34f498, 0x3110828), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8624, 0x31108e0, 0, 32, 32, 0x34f498, 0x31108b0), not implemented fixme:imm:ImmAssociateContextEx (0x30028, (nil), 16): stub I'm going to try rolling back to an old version of Wine, I currently use the latest git. I'll post back if it does work. Mike

4 7

Re: widl [1/2]: Improve file cleanup when errors occur
by Alexandre Julliard Oct. 17, 2007

Oct. 17, 2007

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -446,10 +441,18 @@ static void rm_tempfile(void) > abort_import(); > if(temp_name) > unlink(temp_name); > - if (header_name) > - unlink(header_name); > - if (client_name) > - unlink(client_name); > - if (server_name) > - unlink(server_name); > + if (nerrors) { > + if (do_header) > + unlink(header_name); > + if (do_client) > + unlink(client_name); > + if (do_server) > + unlink(server_name); > + if (do_idfile) > + unlink(idfile_name); > + if (do_proxies) > + unlink(proxy_name); > + if (do_typelib) > + unlink(typelib_name); > + } This will break cleanup on signals. I think it's better to always remove the files instead of relying on the error count being set correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

"make test" failure in gdi32/bitmap.c
by Dan Kegel Oct. 17, 2007

Oct. 17, 2007

"make test" fails for me with: bitmap.c:1113: Test failed: GetDIBits with 4 bpp DIB selected in DC: Invalid DIB bits bitmap.c:1113: Test failed: GetDIBits with 8 bpp DIB selected in DC: Invalid DIB bits err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=24 err:bitmap:DIB_GetBitmapInfo (39): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (11): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (13): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (16): unknown/wrong size for header make[2]: *** [bitmap.ok] Error 2 make[2]: Leaving directory `/home/dank/wine-git/dlls/gdi32/tests' I think this is new since I last ran the tests (at wineconf)...?

3 2

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA.txt
by Dmitry Timoshkov Oct. 17, 2007

Oct. 17, 2007

"Nigel Liang" <ncliang(a)gmail.com> wrote: > + ok( GetLastError() == ERROR_INVALID_PARAMETER, "Last error wrong: %p\n", > + GetLastError()); GetLastError() returns not a pointer. -- Dmitry.

1 0

Wine 1.0 bugs, release criteria
by Denali Coldstar Oct. 16, 2007

Oct. 16, 2007

Dan Kegel <dank <at> kegel.com> writes: >* *>* At Wineconf 2007, I was appointed to be the guy who decides *>* (with Alexandre's approval) what bugs are 1.0 bugs and what aren't. *>* So I've started adjusting the "Target Release" fields on a few *>* bugs in Bugzilla. *>* Over the next month or so, I'd like Wine developers to nominate important * >* Comments? *>* - Dan *>* *> === Good Afternoon, I believe Ventrilo meets the criteria set forth in http://wiki.winehq.org/WineReleaseCriteria. In the gaming community, when you use VOIP applications, it generally boils down to TeamSpeak and Ventrilo. While TeamSpeak has a Linux native client, Ventrilo doesn't. I can't necessarily say Vent holds 50% of the market, but I feel safe in saying it holds a significant share of it. This is mainly based on the fact several companies have sprung up over the years to offer hosting of Vent servers. The client can be freely downloaded from the Ventrilo website ( http://www.ventrilo.com/download.php) but I'm not sure if it can be grabbed with wget. Lastly, it does not have an autoupdate but it will pop up a notice if a new version is available. If it is found that Ventrilo would be a suitable program for consideration in the 1.0 release, the following issues would need to be addressed: http://bugs.winehq.org/show_bug.cgi?id=1348 http://bugs.winehq.org/show_bug.cgi?id=5178 http://bugs.winehq.org/show_bug.cgi?id=5924 http://bugs.winehq.org/show_bug.cgi?id=5978 Thank you for reading this post. Steve

2 1

Error compiling progman
by Daniel Nylander Oct. 16, 2007

Oct. 16, 2007

I have some problems compiling progman. gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o string.o string.c ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -forsrc.res rsrc.rc Xx.rc:23:8: Error: syntax error make: *** [rsrc.res] Error 1 Line 23 in Xx.rc looks like this: CONCAT(MENU_, LANGUAGE_ID) MENU What could be the problem? -- Daniel Nylander (CISSP, GCUX, GCFA) Stockholm, Sweden http://www.DanielNylander.se info(a)danielnylander.se yeager(a)ubuntu.com dnylande(a)gnome.org

2 1